)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a3a53e1f960ecf0a26674303e20778ee9d008344","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Uwe Jäger \u003cuwe.jaeger@valiton.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-17 16:53:18 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update skyline configuration to enable sso"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5b4a30e605bb143cf342f83f0c811c25046269ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c9e9a408_9a8ede93","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":42},"updated":"2024-01-18 09:38:12.000000000","message":"SSO","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a3a53e1f960ecf0a26674303e20778ee9d008344","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Uwe Jäger \u003cuwe.jaeger@valiton.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-17 16:53:18 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update skyline configuration to enable sso"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5b4a30e605bb143cf342f83f0c811c25046269ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff0332c0_d84a6bc8","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":14},"updated":"2024-01-18 09:38:12.000000000","message":"Skyline","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8b0059b43bbf6b09956c6ec355674477d5cf4333","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Uwe Jäger \u003cuwe.jaeger@valiton.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-17 16:53:18 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update skyline configuration to enable sso"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5b4a30e605bb143cf342f83f0c811c25046269ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"40539ec1_e872776f","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":42},"in_reply_to":"63d478f5_9ac9028a","updated":"2024-01-25 15:29:43.000000000","message":"Done","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8b0059b43bbf6b09956c6ec355674477d5cf4333","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Uwe Jäger \u003cuwe.jaeger@valiton.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-17 16:53:18 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update skyline configuration to enable sso"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5b4a30e605bb143cf342f83f0c811c25046269ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bb10bc8a_aaa13ed4","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":14},"in_reply_to":"b6dacf52_b7498dad","updated":"2024-01-25 15:29:43.000000000","message":"Done","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"6e53e51efb09357eb019dc613b005cd48a4b76d2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Uwe Jäger \u003cuwe.jaeger@valiton.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-17 16:53:18 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update skyline configuration to enable sso"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5b4a30e605bb143cf342f83f0c811c25046269ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"63d478f5_9ac9028a","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":42},"in_reply_to":"c9e9a408_9a8ede93","updated":"2024-01-24 07:28:31.000000000","message":"Fixed","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"6e53e51efb09357eb019dc613b005cd48a4b76d2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Uwe Jäger \u003cuwe.jaeger@valiton.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-17 16:53:18 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update skyline configuration to enable sso"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5b4a30e605bb143cf342f83f0c811c25046269ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b6dacf52_b7498dad","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":14},"in_reply_to":"ff0332c0_d84a6bc8","updated":"2024-01-24 07:28:31.000000000","message":"Fixed","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1222197dd84e625a9dff0591f07c73b2e197b5c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b36f7b99_4dd4b3ff","updated":"2024-01-18 09:17:44.000000000","message":"Also this kind of duplicates what has been proposed in https://review.opendev.org/c/openstack/kolla-ansible/+/888496 although with some tweaks, not sure yet what to make of that, maybe you can check and compare yourself?","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"b93d41ce828c74d2e94247faa77e5bab8de62896","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b592f809_f389f07d","updated":"2024-01-18 11:04:53.000000000","message":"I can do the proposed changes early next week, but I think we need a decision whether to stick with this change or https://review.opendev.org/c/openstack/kolla-ansible/+/888496. I\u0027m fine with either decision.","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0d0be81a2ea4fdd04b42a869be65489ebf8df7ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dd1cfe2b_70df714d","updated":"2024-01-18 08:57:26.000000000","message":"I think with https://review.opendev.org/c/openstack/kolla-ansible/+/905861 this is no longer necessary, as you could simple add the variables in an overlay?","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ef9bd21f55e2645f3649c4a28f84f64e48dd4d8d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c5eaeb1d_8e682dfa","in_reply_to":"4e3235de_b4c3ddb8","updated":"2024-01-26 15:37:04.000000000","message":"mhm, I\u0027m no expert in this niche, is federation really required for the trusted_dashboard to work?\n\nif yes this seems fine.","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ee233a2a928169e38d9bf3fa31f24034a59a3ba7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0227e23a_9896a063","in_reply_to":"540b9c7a_9bf69e10","updated":"2024-03-18 10:22:00.000000000","message":"Done","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8b0059b43bbf6b09956c6ec355674477d5cf4333","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8442ccd6_e627320e","in_reply_to":"79a8dcf8_4d1a018b","updated":"2024-01-25 15:29:43.000000000","message":"well this projects goal is - to quote our own docs:\n\n\u003e Kolla’s mission is to provide production-ready containers and deployment tools for operating OpenStack clouds.\n\n\u003e Kolla Ansible is highly opinionated out of the box, but allows for complete customization.\n\nSo I would really prefer if this works out of the box with keystone, without requiring any additional manual steps.\n\nYou can always override it manually if you don\u0027t want to use keystone.","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"718824e0c209d5bffa64f53103595058fe68303b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4e3235de_b4c3ddb8","in_reply_to":"8442ccd6_e627320e","updated":"2024-01-26 09:12:41.000000000","message":"@kieske@osism.tech: Would it be ok for you to keep the \"skyline_sso_enabled\" and set the Keystone \"trusted_dashboard\" to the correct url for Skyline in addition to Horizon if federation in Keystone is enabled and Skyline SSO is enabled?","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"b93d41ce828c74d2e94247faa77e5bab8de62896","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"79a8dcf8_4d1a018b","in_reply_to":"b36f7b99_4dd4b3ff","updated":"2024-01-18 11:04:53.000000000","message":"Just looked at https://review.opendev.org/c/openstack/kolla-ansible/+/888496. The change there includes the necessary config for Keystone which is missing here. I think it is a matter of taste whether you want to have that automatically or not but I would prefer to have that setup manually and not tie Keystone and Skyline setup together.","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d4fdb1051219240e41a7c4b2f6fc66ccd780a53a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"540b9c7a_9bf69e10","in_reply_to":"ba3d2938_b378dba2","updated":"2024-02-27 10:16:54.000000000","message":"LGTM, now we only need to sort out which of the two patches we merge.\nI ping some people on IRC to decide this.","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"8c88eb23f36a9aa98c78fe21c1cd1223cc6200e2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ba3d2938_b378dba2","in_reply_to":"c5eaeb1d_8e682dfa","updated":"2024-02-27 09:00:02.000000000","message":"This has been addressed with the latest patch set.","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"b93d41ce828c74d2e94247faa77e5bab8de62896","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"415fa273_e18ff45d","in_reply_to":"dd1cfe2b_70df714d","updated":"2024-01-18 11:04:53.000000000","message":"I think this changes makes it just simpler to set up SSO for Skyline. The other change just gives more flexibility for other changes.","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"90cc55fc208cda3a24e2da26a203489761000332","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"eb4f735d_ac99cc94","updated":"2024-01-22 19:08:18.000000000","message":"I\u0027m not sure if the build failures are related to this change. I will check this change locally tomorrow.","commit_id":"a1784653d5ba0edbd23d3da0dac7bcd86ce8380e"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"6e53e51efb09357eb019dc613b005cd48a4b76d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8d755322_ae2aa489","updated":"2024-01-24 07:28:31.000000000","message":"Not sure about who is supposed to resolve the comments once the changes have been applied ...","commit_id":"a1784653d5ba0edbd23d3da0dac7bcd86ce8380e"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"41749e7c0985e7017ebc62cbdb61e303813a3056","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"85043234_e2c14c80","updated":"2024-01-22 16:44:23.000000000","message":"Sorry, just learning how this works, removed you by accident.","commit_id":"a1784653d5ba0edbd23d3da0dac7bcd86ce8380e"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"eda5c394dce30977f9ca0fd308cc4213574a7a76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e02bff30_85bea163","updated":"2024-01-22 07:44:32.000000000","message":"Updated change according to comments","commit_id":"a1784653d5ba0edbd23d3da0dac7bcd86ce8380e"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"bca039c50d9ce63492399c30f5e1fc7b6c83053a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"936f9b32_87ba806d","updated":"2024-01-22 16:41:52.000000000","message":"recheck","commit_id":"a1784653d5ba0edbd23d3da0dac7bcd86ce8380e"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"787bdcc5a32664262c8c5c8111b207c514efbb66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cfb5ba78_f31d6f5b","updated":"2024-02-18 17:07:46.000000000","message":"Hi, I finally had a change to test the whole setup locally with an SSO setup. The current solution works now out of the box: as soon as a keystone openid identity provider is set up in kolla ansible, skyline sso is also enabled.","commit_id":"371bac218d2739214a7c4a04c03a949fce7058d1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5f6a80d691e6458b6620ce653e6aff477e418a60","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bad7f5fa_f727ce3c","updated":"2024-02-27 10:23:29.000000000","message":"This is basically a new feature so a release note is missing","commit_id":"371bac218d2739214a7c4a04c03a949fce7058d1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"00d41fd6fecd901769331203501ab0c744528452","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5d05a399_55084b0d","in_reply_to":"6bf34b52_a8c24f99","updated":"2024-02-27 11:07:54.000000000","message":"Done","commit_id":"371bac218d2739214a7c4a04c03a949fce7058d1"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"95022d0e75ff59b85fc2c333372262c5bd6db743","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"92389b32_ee54def2","in_reply_to":"6bf34b52_a8c24f99","updated":"2024-02-27 11:03:58.000000000","message":"Done","commit_id":"371bac218d2739214a7c4a04c03a949fce7058d1"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"21459a15e872e4ab56b37015a7750ad95dbe7185","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6bf34b52_a8c24f99","in_reply_to":"bad7f5fa_f727ce3c","updated":"2024-02-27 10:51:55.000000000","message":"Added a release note.","commit_id":"371bac218d2739214a7c4a04c03a949fce7058d1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7c524cdc62e120725a8ba26b7f3a49fd62da08f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d32f7ce3_a43118a1","updated":"2024-02-27 10:57:03.000000000","message":"thanks for quickly providing the reno!","commit_id":"562af4636aa1732b9769b09115d806c8e9b958bf"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"00d41fd6fecd901769331203501ab0c744528452","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9d6fce27_5baecd14","updated":"2024-02-27 11:07:54.000000000","message":"we need to check if we have some skyline ci where we could test this.\nI\u0027ll investigate but @uwe.jaeger@valiton.com I\u0027ll be unable to extend or write tests for skyline myself as I\u0027m not really using it.\n\nSo could you maybe add some tests? You can see some basic dashboard tests in `tests/test-dashboard.sh`. Maybe these can be extended.\n\nThanks.","commit_id":"72e6434348a5a85ddad922d156bcf6490922f5c9"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"29dbbcdbd467013d12aef48475492268439e8ef9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d30a8b41_4f6eaf41","in_reply_to":"9d6fce27_5baecd14","updated":"2024-02-27 19:28:57.000000000","message":"There is already a \"test-skyline.sh\". I added a test for SSO being enabled (without having run the test itself). Another test with SSO enabled will be a bit more complicated since we need a new scenario then (with skyline_enable_sso: \"no\" in globals.yml).","commit_id":"72e6434348a5a85ddad922d156bcf6490922f5c9"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"e8c52c1f79e8131678046a94c578a236228d24ec","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"daaff075_b0b94471","in_reply_to":"d30a8b41_4f6eaf41","updated":"2024-03-11 15:15:56.000000000","message":"Test is there and added to the checks.","commit_id":"72e6434348a5a85ddad922d156bcf6490922f5c9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0a7fe35a5d756e412162af5082f40142977467ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"742016cc_a6b22410","in_reply_to":"daaff075_b0b94471","updated":"2024-03-11 17:45:21.000000000","message":"Done","commit_id":"72e6434348a5a85ddad922d156bcf6490922f5c9"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"cac8907b051a2c0bae185b7cfb7d91da94759847","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"098c4e78_50d60cce","updated":"2024-03-03 12:37:10.000000000","message":"I added (and got it running successfully) a test that shows that Skyline API-Server returns that SSO is enabled when skyline_enable_sso is set to true. Getting a test running that uses Keystone federation configuration turns out to be more complicated since you have to set up everything in /etc/kolla to make it work.\n\nI also decided to document the SSO feature in a standalone file since there is more to document for Skyline in the following change: https://review.opendev.org/c/openstack/kolla-ansible/+/909481\n\nIf there is anything left to do to get this merged, please let me know.","commit_id":"a0b56794fbce14fdff937b81a59e2f7860cc41f3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"40a9dfac25344b09172abf184714ee81673d6761","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"76f8e127_9defc4a8","updated":"2024-03-05 07:40:49.000000000","message":"Uwe, thanks for docs","commit_id":"a0b56794fbce14fdff937b81a59e2f7860cc41f3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0a7fe35a5d756e412162af5082f40142977467ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1857497f_963f8314","updated":"2024-03-11 17:45:21.000000000","message":"there\u0027s one important typo I believe, so -1 for now. But the rest LGTM, so if the typo is fixed I guess this can get merged.","commit_id":"a0b56794fbce14fdff937b81a59e2f7860cc41f3"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"255656fb16722406369aae97af9fe85a195b0c99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"39e17b83_4cd0d17f","updated":"2024-03-14 17:58:53.000000000","message":"I can resolve the merge conflict, but then everybody has to vote again, just let me know what is best workflow wise.","commit_id":"47f8efc36caadf128a5966b5412a831abde13d03"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"daf66a3da435bc03edef33311efe9c9140b32d8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d572f96c_73044ee5","updated":"2024-03-12 13:57:02.000000000","message":"recheck multi node tooz failures should be solved now","commit_id":"47f8efc36caadf128a5966b5412a831abde13d03"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b522cf1489a41e4b1187246001ef8843b35f02a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d9addd8a_5e7c63fa","in_reply_to":"39e17b83_4cd0d17f","updated":"2024-03-15 16:09:20.000000000","message":"yes, that\u0027s the intended workflow, or to be more precise: if zuul detects no sufficient code change it can preserve votes in some scenarios. with a conflict it\u0027s likely we have to vote again, but that\u0027s fine.","commit_id":"47f8efc36caadf128a5966b5412a831abde13d03"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"eb7689686b744e6cf72402eef4fa812383c6bcd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"c69e981e_7282bf7d","updated":"2024-03-15 18:16:18.000000000","message":"Rebase done.","commit_id":"9aed3e6e83e72da84188fb7fb01fd201639ea0c9"}],"ansible/roles/skyline/defaults/main.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d31d255eed4502a441a6109a7623e231e918d5a9","unresolved":true,"context_lines":[{"line_number":185,"context_line":"####################"},{"line_number":186,"context_line":"# SSO"},{"line_number":187,"context_line":"####################"},{"line_number":188,"context_line":"skyline_enable_sso: \"{{ enable_keystone_federation | bool and keystone_identity_providers | selectattr(\u0027protocol\u0027, \u0027equalto\u0027, \u0027openid\u0027) | list | count \u003e 0 }}\""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"####################"},{"line_number":191,"context_line":"# TLS"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"15d99095_f65ff432","line":188,"range":{"start_line":188,"start_character":0,"end_line":188,"end_character":158},"updated":"2024-02-27 12:29:23.000000000","message":"since this is global if case, this should be moved to group_vars, role default should be skyline_enable_sso: \"no\"","commit_id":"72e6434348a5a85ddad922d156bcf6490922f5c9"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"29dbbcdbd467013d12aef48475492268439e8ef9","unresolved":true,"context_lines":[{"line_number":185,"context_line":"####################"},{"line_number":186,"context_line":"# SSO"},{"line_number":187,"context_line":"####################"},{"line_number":188,"context_line":"skyline_enable_sso: \"{{ enable_keystone_federation | bool and keystone_identity_providers | selectattr(\u0027protocol\u0027, \u0027equalto\u0027, \u0027openid\u0027) | list | count \u003e 0 }}\""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"####################"},{"line_number":191,"context_line":"# TLS"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"d5c4c5cb_620fafd4","line":188,"range":{"start_line":188,"start_character":0,"end_line":188,"end_character":158},"in_reply_to":"15d99095_f65ff432","updated":"2024-02-27 19:28:57.000000000","message":"Thanks. Changed in the latest patch set","commit_id":"72e6434348a5a85ddad922d156bcf6490922f5c9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c57b79222a4a39da8ee7f2b9b13279f2e3b59792","unresolved":false,"context_lines":[{"line_number":185,"context_line":"####################"},{"line_number":186,"context_line":"# SSO"},{"line_number":187,"context_line":"####################"},{"line_number":188,"context_line":"skyline_enable_sso: \"{{ enable_keystone_federation | bool and keystone_identity_providers | selectattr(\u0027protocol\u0027, \u0027equalto\u0027, \u0027openid\u0027) | list | count \u003e 0 }}\""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"####################"},{"line_number":191,"context_line":"# TLS"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"b218385c_61318273","line":188,"range":{"start_line":188,"start_character":0,"end_line":188,"end_character":158},"in_reply_to":"d5c4c5cb_620fafd4","updated":"2024-02-28 08:51:52.000000000","message":"Done","commit_id":"72e6434348a5a85ddad922d156bcf6490922f5c9"}],"ansible/roles/skyline/templates/skyline.yaml.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a3a53e1f960ecf0a26674303e20778ee9d008344","unresolved":true,"context_lines":[{"line_number":77,"context_line":"{% if enable_cinder | bool %}"},{"line_number":78,"context_line":"    volumev3: cinder"},{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":"  sso_enabled: {{ skyline_sso_enabled }}"},{"line_number":81,"context_line":"  sso_protocols:"},{"line_number":82,"context_line":"    - openid"},{"line_number":83,"context_line":"  sso_region: {{ openstack_region_name }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"57821bc5_6df1f46d","line":80,"range":{"start_line":80,"start_character":18,"end_line":80,"end_character":37},"updated":"2024-01-18 09:38:12.000000000","message":"skyline_sso_enabled | bool","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"6e53e51efb09357eb019dc613b005cd48a4b76d2","unresolved":true,"context_lines":[{"line_number":77,"context_line":"{% if enable_cinder | bool %}"},{"line_number":78,"context_line":"    volumev3: cinder"},{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":"  sso_enabled: {{ skyline_sso_enabled }}"},{"line_number":81,"context_line":"  sso_protocols:"},{"line_number":82,"context_line":"    - openid"},{"line_number":83,"context_line":"  sso_region: {{ openstack_region_name }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bdc26976_dec8c604","line":80,"range":{"start_line":80,"start_character":18,"end_line":80,"end_character":37},"in_reply_to":"57821bc5_6df1f46d","updated":"2024-01-24 07:28:31.000000000","message":"Fixed","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8b0059b43bbf6b09956c6ec355674477d5cf4333","unresolved":false,"context_lines":[{"line_number":77,"context_line":"{% if enable_cinder | bool %}"},{"line_number":78,"context_line":"    volumev3: cinder"},{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":"  sso_enabled: {{ skyline_sso_enabled }}"},{"line_number":81,"context_line":"  sso_protocols:"},{"line_number":82,"context_line":"    - openid"},{"line_number":83,"context_line":"  sso_region: {{ openstack_region_name }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"d9ab83a4_126417fd","line":80,"range":{"start_line":80,"start_character":18,"end_line":80,"end_character":37},"in_reply_to":"bdc26976_dec8c604","updated":"2024-01-25 15:29:43.000000000","message":"Done","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2f22cd3a7efb3055030b125f612982e03969f8a6","unresolved":true,"context_lines":[{"line_number":78,"context_line":"    volumev3: cinder"},{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":"  sso_enabled: {{ skyline_sso_enabled }}"},{"line_number":81,"context_line":"  sso_protocols:"},{"line_number":82,"context_line":"    - openid"},{"line_number":83,"context_line":"  sso_region: {{ openstack_region_name }}"},{"line_number":84,"context_line":"  system_admin_roles:"},{"line_number":85,"context_line":"{% for skyline_system_admin_role in skyline_system_admin_roles %}"},{"line_number":86,"context_line":"  - {{ skyline_system_admin_role }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"8143dc24_95173847","line":83,"range":{"start_line":81,"start_character":0,"end_line":83,"end_character":41},"updated":"2024-01-18 09:37:19.000000000","message":"should be in \u0027if skyline_sso_enabled\u0027 block","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"b93d41ce828c74d2e94247faa77e5bab8de62896","unresolved":true,"context_lines":[{"line_number":78,"context_line":"    volumev3: cinder"},{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":"  sso_enabled: {{ skyline_sso_enabled }}"},{"line_number":81,"context_line":"  sso_protocols:"},{"line_number":82,"context_line":"    - openid"},{"line_number":83,"context_line":"  sso_region: {{ openstack_region_name }}"},{"line_number":84,"context_line":"  system_admin_roles:"},{"line_number":85,"context_line":"{% for skyline_system_admin_role in skyline_system_admin_roles %}"},{"line_number":86,"context_line":"  - {{ skyline_system_admin_role }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"da0500b4_20323fac","line":83,"range":{"start_line":81,"start_character":0,"end_line":83,"end_character":41},"in_reply_to":"8143dc24_95173847","updated":"2024-01-18 11:04:53.000000000","message":"OK, I just took it from the Skyline code base. Of course I can add the if.","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8b0059b43bbf6b09956c6ec355674477d5cf4333","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    volumev3: cinder"},{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":"  sso_enabled: {{ skyline_sso_enabled }}"},{"line_number":81,"context_line":"  sso_protocols:"},{"line_number":82,"context_line":"    - openid"},{"line_number":83,"context_line":"  sso_region: {{ openstack_region_name }}"},{"line_number":84,"context_line":"  system_admin_roles:"},{"line_number":85,"context_line":"{% for skyline_system_admin_role in skyline_system_admin_roles %}"},{"line_number":86,"context_line":"  - {{ skyline_system_admin_role }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1ebf1121_20a320d8","line":83,"range":{"start_line":81,"start_character":0,"end_line":83,"end_character":41},"in_reply_to":"a4a1234b_3d2bcfd0","updated":"2024-01-25 15:29:43.000000000","message":"Done","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"6e53e51efb09357eb019dc613b005cd48a4b76d2","unresolved":true,"context_lines":[{"line_number":78,"context_line":"    volumev3: cinder"},{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":"  sso_enabled: {{ skyline_sso_enabled }}"},{"line_number":81,"context_line":"  sso_protocols:"},{"line_number":82,"context_line":"    - openid"},{"line_number":83,"context_line":"  sso_region: {{ openstack_region_name }}"},{"line_number":84,"context_line":"  system_admin_roles:"},{"line_number":85,"context_line":"{% for skyline_system_admin_role in skyline_system_admin_roles %}"},{"line_number":86,"context_line":"  - {{ skyline_system_admin_role }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"a4a1234b_3d2bcfd0","line":83,"range":{"start_line":81,"start_character":0,"end_line":83,"end_character":41},"in_reply_to":"da0500b4_20323fac","updated":"2024-01-24 07:28:31.000000000","message":"Has been fixed in the latest patch set","commit_id":"9b50da381f38efb985607fb7dfa266070073f1a3"}],"releasenotes/notes/skyline-sso-2036301-9a2118472dd0d8cf.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7c524cdc62e120725a8ba26b7f3a49fd62da08f7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enables SSO in Skyline Console if Keystone federation is enabled and "},{"line_number":5,"context_line":"    at least one identity provider with protocol openid is set up."},{"line_number":6,"context_line":"    Skyline Console\u0027s redirect URI is added to Keystone\u0027s trusted dashboards."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"447c8b55_31f73ce2","line":4,"range":{"start_line":4,"start_character":72,"end_line":4,"end_character":73},"updated":"2024-02-27 10:57:03.000000000","message":"nit: space","commit_id":"562af4636aa1732b9769b09115d806c8e9b958bf"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"98e6c8799ba3f01ae06c66ecd57a3a8573c52f35","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enables SSO in Skyline Console if Keystone federation is enabled and "},{"line_number":5,"context_line":"    at least one identity provider with protocol openid is set up."},{"line_number":6,"context_line":"    Skyline Console\u0027s redirect URI is added to Keystone\u0027s trusted dashboards."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f8c12e9_f5e0515b","line":4,"range":{"start_line":4,"start_character":72,"end_line":4,"end_character":73},"in_reply_to":"447c8b55_31f73ce2","updated":"2024-02-27 11:03:24.000000000","message":"Fixed","commit_id":"562af4636aa1732b9769b09115d806c8e9b958bf"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d31d255eed4502a441a6109a7623e231e918d5a9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"43dbe61d_aa6a34b0","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":0},"updated":"2024-02-27 12:29:23.000000000","message":"thanks for short reno, but as a new feature all the mechanisms should be well described, so there need more information how to force enable or force disable sso if needed. at least advanced-configuration.rst should be updated with control variables.","commit_id":"72e6434348a5a85ddad922d156bcf6490922f5c9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0a7fe35a5d756e412162af5082f40142977467ec","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dafc1a68_fad06073","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":0},"in_reply_to":"31086749_270335f0","updated":"2024-03-11 17:45:21.000000000","message":"the docs are short, but LGTM so far. Again as I\u0027m not a skyline or gui user, really, it would be better if someone actually using the stuff did leave a review.\n\nAt least the SSO Stuff and how to enable/disable it is covered.","commit_id":"72e6434348a5a85ddad922d156bcf6490922f5c9"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"e8c52c1f79e8131678046a94c578a236228d24ec","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"31086749_270335f0","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":0},"in_reply_to":"3d9b873b_f8e29e2e","updated":"2024-03-11 15:15:56.000000000","message":"I think this is now resolved, documentation is there.","commit_id":"72e6434348a5a85ddad922d156bcf6490922f5c9"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"29dbbcdbd467013d12aef48475492268439e8ef9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"701db43e_04b614ae","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":0},"in_reply_to":"43dbe61d_aa6a34b0","updated":"2024-02-27 19:28:57.000000000","message":"Thanks for your review. In order to stream line this process would you be so kind and give me a hint where exactly in that file you suggest to add the needed information? I had a quick look at it and found no information on any individual service there. We could set up an extra file dedicated to Skyline in the shared-services folder (I have some other changes that would need documentation, too).","commit_id":"72e6434348a5a85ddad922d156bcf6490922f5c9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c57b79222a4a39da8ee7f2b9b13279f2e3b59792","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"87c5b763_771297ff","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":0},"in_reply_to":"701db43e_04b614ae","updated":"2024-02-28 08:51:52.000000000","message":"the document has no clear structure to be fair.\n\nthere are some individual services in there, namely rabbitmq, external elasticsearch/kibana (should probably rename that to opensearch).\n\nI guess just another section with \"skyline sso\" there would suffice?\n\nI agree we need some more docs.","commit_id":"72e6434348a5a85ddad922d156bcf6490922f5c9"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"c4c7b22e5797a96cdbe411ae8a15670c469b4002","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3d9b873b_f8e29e2e","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":0},"in_reply_to":"87c5b763_771297ff","updated":"2024-02-28 09:27:48.000000000","message":"I would prefer some more opinions before I start ...","commit_id":"72e6434348a5a85ddad922d156bcf6490922f5c9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ee233a2a928169e38d9bf3fa31f24034a59a3ba7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"28dfcb85_63cc4c55","line":7,"range":{"start_line":4,"start_character":4,"end_line":7,"end_character":0},"in_reply_to":"dafc1a68_fad06073","updated":"2024-03-18 10:22:00.000000000","message":"Done","commit_id":"72e6434348a5a85ddad922d156bcf6490922f5c9"}],"zuul.d/base.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0a7fe35a5d756e412162af5082f40142977467ec","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    parent: kolla-ansible-base"},{"line_number":73,"context_line":"    voting: false"},{"line_number":74,"context_line":"    files:"},{"line_number":75,"context_line":"      - ^requiremeGnts-core.yml"},{"line_number":76,"context_line":"      - ^ansible/roles/(nova-cell)/"},{"line_number":77,"context_line":"      - ^tests/templates/nova-compute-overrides.j2"},{"line_number":78,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9fc92039_bef33bfb","line":75,"range":{"start_line":75,"start_character":9,"end_line":75,"end_character":22},"updated":"2024-03-11 17:45:21.000000000","message":"this seems to have been changed by accident? Please fix!","commit_id":"a0b56794fbce14fdff937b81a59e2f7860cc41f3"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"c3336a6f567de3bae0b45d5608c1224287a8c8cf","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    parent: kolla-ansible-base"},{"line_number":73,"context_line":"    voting: false"},{"line_number":74,"context_line":"    files:"},{"line_number":75,"context_line":"      - ^requiremeGnts-core.yml"},{"line_number":76,"context_line":"      - ^ansible/roles/(nova-cell)/"},{"line_number":77,"context_line":"      - ^tests/templates/nova-compute-overrides.j2"},{"line_number":78,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"fa72ba9f_444b0b62","line":75,"range":{"start_line":75,"start_character":9,"end_line":75,"end_character":22},"in_reply_to":"9fc92039_bef33bfb","updated":"2024-03-11 18:08:05.000000000","message":"Sorry and thanks for spotting, no idea how that happened.\nAnd fixed.","commit_id":"a0b56794fbce14fdff937b81a59e2f7860cc41f3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"daf66a3da435bc03edef33311efe9c9140b32d8d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    parent: kolla-ansible-base"},{"line_number":73,"context_line":"    voting: false"},{"line_number":74,"context_line":"    files:"},{"line_number":75,"context_line":"      - ^requiremeGnts-core.yml"},{"line_number":76,"context_line":"      - ^ansible/roles/(nova-cell)/"},{"line_number":77,"context_line":"      - ^tests/templates/nova-compute-overrides.j2"},{"line_number":78,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"8e5ff881_bbe45a08","line":75,"range":{"start_line":75,"start_character":9,"end_line":75,"end_character":22},"in_reply_to":"fa72ba9f_444b0b62","updated":"2024-03-12 13:57:02.000000000","message":"Done","commit_id":"a0b56794fbce14fdff937b81a59e2f7860cc41f3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"517e01754b08989a7ef473a43b9bae3cd037d38b","unresolved":true,"context_lines":[{"line_number":322,"context_line":"    vars:"},{"line_number":323,"context_line":"      scenario: skyline"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"- job:"},{"line_number":326,"context_line":"    name: kolla-ansible-skyline-sso-base"},{"line_number":327,"context_line":"    parent: kolla-ansible-base"},{"line_number":328,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ac23605d_d90c225c","line":325,"updated":"2024-03-18 06:45:42.000000000","message":"I\u0027m fine with that as a starter, but we could think of a general IdP enabled job that enables both horizon and skyline (if possible).","commit_id":"a4e6e58e4ed3293312fd8732b2c5fdef145abd58"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"05dea129da7e5f709b84114c1864fffd6423b597","unresolved":true,"context_lines":[{"line_number":322,"context_line":"    vars:"},{"line_number":323,"context_line":"      scenario: skyline"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"- job:"},{"line_number":326,"context_line":"    name: kolla-ansible-skyline-sso-base"},{"line_number":327,"context_line":"    parent: kolla-ansible-base"},{"line_number":328,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"85e3d58b_540cae8d","line":325,"in_reply_to":"20b64156_3045ca09","updated":"2024-03-26 07:22:40.000000000","message":"@mnasiadka@gmail.com are you OK with my proposal and can we resolve this comment here or does this change need any other work?","commit_id":"a4e6e58e4ed3293312fd8732b2c5fdef145abd58"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c4959109bd9459566042eb336fd5f30bd1e09f1d","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    vars:"},{"line_number":323,"context_line":"      scenario: skyline"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"- job:"},{"line_number":326,"context_line":"    name: kolla-ansible-skyline-sso-base"},{"line_number":327,"context_line":"    parent: kolla-ansible-base"},{"line_number":328,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"8ead644c_21ecd07e","line":325,"in_reply_to":"85e3d58b_540cae8d","updated":"2024-04-02 14:02:00.000000000","message":"I\u0027ll mark this as resolved as Michal did +2 this already.","commit_id":"a4e6e58e4ed3293312fd8732b2c5fdef145abd58"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"6c6547cf6eb27cf5f184384fc1bb55508a0a20fc","unresolved":true,"context_lines":[{"line_number":322,"context_line":"    vars:"},{"line_number":323,"context_line":"      scenario: skyline"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"- job:"},{"line_number":326,"context_line":"    name: kolla-ansible-skyline-sso-base"},{"line_number":327,"context_line":"    parent: kolla-ansible-base"},{"line_number":328,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"20b64156_3045ca09","line":325,"in_reply_to":"ac23605d_d90c225c","updated":"2024-03-20 06:52:11.000000000","message":"IF you agree, I could do that in a follow up change. Is there anything that we can use as a real IdP or would we just set up the configuration and test that there is the SSO option active in the dashboards?","commit_id":"a4e6e58e4ed3293312fd8732b2c5fdef145abd58"}]}