)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f0b98493503334f445948d463ea6ace0383f1987","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0fce5960_fe7ba71d","updated":"2024-01-18 09:01:47.000000000","message":"I just noticed that this is essentially a duplicate of https://review.opendev.org/c/openstack/kolla-ansible/+/902182 , we would usually have to give priority to the older patch and possibly amend that one if needed.","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"d2877ade5424b4fbcb3b8d74c15ce56981ba0543","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bef5d499_431f1d1f","updated":"2024-01-18 10:52:46.000000000","message":"Thanks again for the review. I did not check other reviews and I admit I\u0027m fairly new to working with Openstack. We are setting up Openstack as a private cloud offering for our internal customers and prefer Skyline over Horizon. Single Sign On is our first priority but we might also contribute to Skyline.\n\nTo enable SSO we can just work with my other contribution (https://review.opendev.org/c/openstack/kolla-ansible/+/905860) I just created this to have more flexibility in the future. As Sykline evolves the configuration will also be extented and having the this flexibility here gives everybody wanting to adopt Skyline more freedom.\n\nIf there is an agreement, I can amend this to just include the one node_custom_config that uses the sub directory. If I have to add release notes or something else please let me know what is needed.","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2d900474e486ecc3ccf9bb24b5b4c507eb70a0d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4f616dfc_da2290bc","updated":"2024-01-18 08:55:51.000000000","message":"Welcome new contributor, thanks for deciding to work with us on improving the project. Just in case you haven\u0027t seen this, you may want to take a look at the contributor docs at https://docs.openstack.org/kolla-ansible/latest/contributor/index.html , in particular you might want to join us in the IRC channel and possibly participate in the weekly meetings. Although it looks chaotic at first, there is also a lot of useful information hidden in https://etherpad.openstack.org/p/KollaWhiteBoard .\n\nPlease also see my question inline.","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d3ae23d8ae954b5f1a3a586d3ccaf0fcedefc94b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"35c703f9_5a6863c1","updated":"2024-01-18 09:30:32.000000000","message":"agree one node_custom_config is enough, also inventory based config is useless","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f840837cad3fe6a3f0069285a68a3a386f38f857","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bbd6cfee_f908b9fc","updated":"2024-01-18 09:31:53.000000000","message":"duplicate https://review.opendev.org/c/openstack/kolla-ansible/+/902182","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3ce23f42651158629c24a3a96a8c247775b4dbd7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"29a06229_86ef340e","in_reply_to":"0fce5960_fe7ba71d","updated":"2024-01-18 13:45:46.000000000","message":"was this comment marked as resolved by accident?\n\nI see no point in going on with reviewing both changesets until it isn\u0027t clear which one should be worked on? It seems a waste of time to work on both at the same time.","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fca31fa9b258bc227a58f8669b13fd7d00e0abc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fb540d1a_35c6a402","in_reply_to":"29a06229_86ef340e","updated":"2024-03-15 16:11:04.000000000","message":"as there is no activity in the other review from the developer and this comment was originally marked as resolved I take the liberty to mark it as resolved again.","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"d2877ade5424b4fbcb3b8d74c15ce56981ba0543","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8d3924b2_1c9c67ad","in_reply_to":"35c703f9_5a6863c1","updated":"2024-01-18 10:52:46.000000000","message":"My choice then would be to keep \"{{ node_custom_config }}/skyline/skyline.yaml\"","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"5aa76166779e8430b508f8592e306cd9f1c8f346","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"98bcb549_be5e724f","in_reply_to":"8d3924b2_1c9c67ad","updated":"2024-01-24 07:31:42.000000000","message":"Done","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b53c287d3386d13dca8d730e03da26eaefff1f81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3d146989_84c97e16","in_reply_to":"98bcb549_be5e724f","updated":"2024-03-07 11:46:00.000000000","message":"Done","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"c8259e6b14d6d3a701749bfb96658a0186834a11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ff3ecedc_d8186627","updated":"2024-01-22 07:39:19.000000000","message":"I only kept the location in a the sub directory for skyline.yaml and added the ability to override nginx.conf which might be needed for additional services (e.g. barbican).","commit_id":"428a5ba8ba471505de991109c7151241ac8821a1"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"5aa76166779e8430b508f8592e306cd9f1c8f346","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2779629d_5aab39e2","updated":"2024-01-24 07:31:42.000000000","message":"Proposed changes have been done.","commit_id":"428a5ba8ba471505de991109c7151241ac8821a1"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"80b9e0c399f1c54d74aa6afe071470d3494596f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"12ff8e12_3c4e11cd","updated":"2024-01-24 07:25:57.000000000","message":"recheck","commit_id":"428a5ba8ba471505de991109c7151241ac8821a1"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"26682f4a06dd3b163a0faf0e3341685abc484743","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9ab0c487_6e9cda60","updated":"2024-02-18 19:01:07.000000000","message":"Once again I was finally able to test this and had to change a few things. gunicorn.py is only used by the apiserver and nginx.conf is only for the console.","commit_id":"62091a3cd23176812c9a9a0fad1c408fd43a68b2"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"1cf10196ff8f51fd42ba91f0d0011224cca8e78a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"84ba8469_c26741ee","updated":"2024-03-04 15:59:05.000000000","message":"Please let me know if I can do anything else to get this merged (I\u0027m new to the process)","commit_id":"62091a3cd23176812c9a9a0fad1c408fd43a68b2"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"cbce30f6a07c0a6eef87f189fdeb5dc9d594dd75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8bafc52d_cd31ea0b","updated":"2024-03-04 19:57:14.000000000","message":"Uwe, thanks for docs","commit_id":"62091a3cd23176812c9a9a0fad1c408fd43a68b2"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"39eb5f58c0d0ebfb049877a72a6ee20b494bdf73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f865329b_da7a8775","in_reply_to":"8bafc52d_cd31ea0b","updated":"2024-03-05 07:35:05.000000000","message":"@maksim.malchuk@gmail.com I will add a reno here. If we can finish change https://review.opendev.org/c/openstack/kolla-ansible/+/905860 I can rebase and add more detailed information in the page created there.","commit_id":"62091a3cd23176812c9a9a0fad1c408fd43a68b2"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"95d61fc5dc79a89956befa89c896dfc7c97f6146","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"31705fab_6f593144","in_reply_to":"f865329b_da7a8775","updated":"2024-03-05 07:40:36.000000000","message":"fine. thanks.","commit_id":"62091a3cd23176812c9a9a0fad1c408fd43a68b2"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"9cb305a1a0a8281935940acf46aa39b2061c1cc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4c044466_6fbd1b13","updated":"2024-03-14 17:59:50.000000000","message":"Anything else to do?","commit_id":"2185be008ecd6825b24101253b6ae8d1316189de"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"203c0031a044542a594c0806ff63fb8571ef92e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"516c9fe3_5569342d","updated":"2024-03-11 15:14:12.000000000","message":"If there is anything left to do please let me know. I would be happy to get that done.","commit_id":"2185be008ecd6825b24101253b6ae8d1316189de"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c6f46edc423d00d6fa271c7b046ac13b59fd8981","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9c409847_926d32e8","updated":"2024-03-18 06:46:31.000000000","message":"Trivial","commit_id":"2185be008ecd6825b24101253b6ae8d1316189de"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fd689dec6e7143a2b664da2dea6276445ae7ab8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fbbd5ee1_e38d0481","updated":"2024-03-11 17:34:53.000000000","message":"as the other patchset that seems to deal with the same problem doesn\u0027t have any updates this seems to be the more recent patchset.","commit_id":"2185be008ecd6825b24101253b6ae8d1316189de"}],"ansible/roles/skyline/tasks/config.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2d900474e486ecc3ccf9bb24b5b4c507eb70a0d8","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    sources:"},{"line_number":22,"context_line":"      - \"{{ role_path }}/templates/skyline.yaml.j2\""},{"line_number":23,"context_line":"      - \"{{ node_custom_config }}/skyline.yaml\""},{"line_number":24,"context_line":"      - \"{{ node_custom_config }}/skyline/skyline.yaml\""},{"line_number":25,"context_line":"      - \"{{ node_custom_config }}/skyline/{{ inventory_hostname }}/skyline.yaml\""},{"line_number":26,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/skyline.yaml\""},{"line_number":27,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"93578aaf_a1bdba51","line":24,"updated":"2024-01-18 08:55:51.000000000","message":"I think one of the previous two would be enough, not sure which one to prefer. Or do you have a specific reason why these are both needed?","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e23a0bd21fbfd872f35f08b0d3b29fc9fa50b8e4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    sources:"},{"line_number":22,"context_line":"      - \"{{ role_path }}/templates/skyline.yaml.j2\""},{"line_number":23,"context_line":"      - \"{{ node_custom_config }}/skyline.yaml\""},{"line_number":24,"context_line":"      - \"{{ node_custom_config }}/skyline/skyline.yaml\""},{"line_number":25,"context_line":"      - \"{{ node_custom_config }}/skyline/{{ inventory_hostname }}/skyline.yaml\""},{"line_number":26,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/skyline.yaml\""},{"line_number":27,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a850b8ab_2459067f","line":24,"in_reply_to":"0e818517_e9abf6c4","updated":"2024-01-26 15:41:36.000000000","message":"ah never mind, I guess my regex search fooled my, thanks for the pointer. I didn\u0027t find that code at first.\n\nno need to switch this implementation out, if it works, I guess.","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5a2add632a48904464a74c32352b8e27543ba667","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    sources:"},{"line_number":22,"context_line":"      - \"{{ role_path }}/templates/skyline.yaml.j2\""},{"line_number":23,"context_line":"      - \"{{ node_custom_config }}/skyline.yaml\""},{"line_number":24,"context_line":"      - \"{{ node_custom_config }}/skyline/skyline.yaml\""},{"line_number":25,"context_line":"      - \"{{ node_custom_config }}/skyline/{{ inventory_hostname }}/skyline.yaml\""},{"line_number":26,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/skyline.yaml\""},{"line_number":27,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7fe241c0_75796ba5","line":24,"in_reply_to":"4371e831_e09e037b","updated":"2024-01-25 15:44:09.000000000","message":"does it really make sense to merge a node custom config - which in most cases totally overrides it - with a default template? we have never done this in the past, we always just merge `*.yml` files, no templates.\n\nI\u0027m not even 100% sure if our merge_yaml action plugin, which uses PyYAML under the hood to merge yaml files supports merging templates?\n\nthis probably should be a template, that uses `with_first_found` see https://github.com/openstack/kolla-ansible/blob/d690177e5846c183da18839eaf805b0ee7200cdc/ansible/roles/grafana/tasks/config.yml#L102 for an example.","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"dbdf2dddc4e1187aee4ed99b6a650357e5fee696","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    sources:"},{"line_number":22,"context_line":"      - \"{{ role_path }}/templates/skyline.yaml.j2\""},{"line_number":23,"context_line":"      - \"{{ node_custom_config }}/skyline.yaml\""},{"line_number":24,"context_line":"      - \"{{ node_custom_config }}/skyline/skyline.yaml\""},{"line_number":25,"context_line":"      - \"{{ node_custom_config }}/skyline/{{ inventory_hostname }}/skyline.yaml\""},{"line_number":26,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/skyline.yaml\""},{"line_number":27,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ae40a76f_199d6903","line":24,"in_reply_to":"7fe241c0_75796ba5","updated":"2024-01-25 16:01:55.000000000","message":"A quick search shows it is used in the roles for bifrost, ceilometer and opensearch, but I\u0027m totally fine with changing this. \n\nOverriding the complete template makes you loose all automatisms of the configuration, while merging (if it works which I don\u0027t know), could be used to just override a part of the configuration or add new configuration. \n\nIs there a easy way to check if it really works?","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"d2877ade5424b4fbcb3b8d74c15ce56981ba0543","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    sources:"},{"line_number":22,"context_line":"      - \"{{ role_path }}/templates/skyline.yaml.j2\""},{"line_number":23,"context_line":"      - \"{{ node_custom_config }}/skyline.yaml\""},{"line_number":24,"context_line":"      - \"{{ node_custom_config }}/skyline/skyline.yaml\""},{"line_number":25,"context_line":"      - \"{{ node_custom_config }}/skyline/{{ inventory_hostname }}/skyline.yaml\""},{"line_number":26,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/skyline.yaml\""},{"line_number":27,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e9cdd147_6d630b56","line":24,"in_reply_to":"93578aaf_a1bdba51","updated":"2024-01-18 10:52:46.000000000","message":"Thanks for the quick feedback. I really just took this from the playbook for opensearch. At least there all three places are implemented (see https://opendev.org/openstack/kolla-ansible/src/branch/master/ansible/roles/opensearch/tasks/config.yml#L35). \n\nFrom my point of view, one location would be enough and if I can choose I would stick with {{ node_custom_config }}/skyline/skyline.yaml. That way you can keep customizing in one folder in case we end up adding more flexibility e.g. for nginx.conf.","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"8d01b73b7127d2ab898713c3b195aff43e5610fc","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    sources:"},{"line_number":22,"context_line":"      - \"{{ role_path }}/templates/skyline.yaml.j2\""},{"line_number":23,"context_line":"      - \"{{ node_custom_config }}/skyline.yaml\""},{"line_number":24,"context_line":"      - \"{{ node_custom_config }}/skyline/skyline.yaml\""},{"line_number":25,"context_line":"      - \"{{ node_custom_config }}/skyline/{{ inventory_hostname }}/skyline.yaml\""},{"line_number":26,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/skyline.yaml\""},{"line_number":27,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0e818517_e9abf6c4","line":24,"in_reply_to":"ae40a76f_199d6903","updated":"2024-01-26 09:14:46.000000000","message":"@kieske@osism.tech I will change the Skyline config part so that it works the same way as the nginx config part.","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"5aa76166779e8430b508f8592e306cd9f1c8f346","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    sources:"},{"line_number":22,"context_line":"      - \"{{ role_path }}/templates/skyline.yaml.j2\""},{"line_number":23,"context_line":"      - \"{{ node_custom_config }}/skyline.yaml\""},{"line_number":24,"context_line":"      - \"{{ node_custom_config }}/skyline/skyline.yaml\""},{"line_number":25,"context_line":"      - \"{{ node_custom_config }}/skyline/{{ inventory_hostname }}/skyline.yaml\""},{"line_number":26,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/skyline.yaml\""},{"line_number":27,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4371e831_e09e037b","line":24,"in_reply_to":"e9cdd147_6d630b56","updated":"2024-01-24 07:31:42.000000000","message":"Change to only keep  - \"{{ node_custom_config }}/skyline/skyline.yaml\" in the latest patch set","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f0b98493503334f445948d463ea6ace0383f1987","unresolved":true,"context_lines":[{"line_number":22,"context_line":"      - \"{{ role_path }}/templates/skyline.yaml.j2\""},{"line_number":23,"context_line":"      - \"{{ node_custom_config }}/skyline.yaml\""},{"line_number":24,"context_line":"      - \"{{ node_custom_config }}/skyline/skyline.yaml\""},{"line_number":25,"context_line":"      - \"{{ node_custom_config }}/skyline/{{ inventory_hostname }}/skyline.yaml\""},{"line_number":26,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/skyline.yaml\""},{"line_number":27,"context_line":"    mode: \"0660\""},{"line_number":28,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"023f30e4_fde5d2cb","line":25,"updated":"2024-01-18 09:01:47.000000000","message":"What is the reason one would want to have different configuration per host for the dashboard?","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"d2877ade5424b4fbcb3b8d74c15ce56981ba0543","unresolved":true,"context_lines":[{"line_number":22,"context_line":"      - \"{{ role_path }}/templates/skyline.yaml.j2\""},{"line_number":23,"context_line":"      - \"{{ node_custom_config }}/skyline.yaml\""},{"line_number":24,"context_line":"      - \"{{ node_custom_config }}/skyline/skyline.yaml\""},{"line_number":25,"context_line":"      - \"{{ node_custom_config }}/skyline/{{ inventory_hostname }}/skyline.yaml\""},{"line_number":26,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/skyline.yaml\""},{"line_number":27,"context_line":"    mode: \"0660\""},{"line_number":28,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b029b811_e9f2da0f","line":25,"in_reply_to":"023f30e4_fde5d2cb","updated":"2024-01-18 10:52:46.000000000","message":"See above, just taken from opensearch playbook.","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5a2add632a48904464a74c32352b8e27543ba667","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      - \"{{ role_path }}/templates/skyline.yaml.j2\""},{"line_number":23,"context_line":"      - \"{{ node_custom_config }}/skyline.yaml\""},{"line_number":24,"context_line":"      - \"{{ node_custom_config }}/skyline/skyline.yaml\""},{"line_number":25,"context_line":"      - \"{{ node_custom_config }}/skyline/{{ inventory_hostname }}/skyline.yaml\""},{"line_number":26,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/skyline.yaml\""},{"line_number":27,"context_line":"    mode: \"0660\""},{"line_number":28,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a65a73e_cd69ec65","line":25,"in_reply_to":"11f1d2a0_bc866d86","updated":"2024-01-25 15:44:09.000000000","message":"Done","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"5aa76166779e8430b508f8592e306cd9f1c8f346","unresolved":true,"context_lines":[{"line_number":22,"context_line":"      - \"{{ role_path }}/templates/skyline.yaml.j2\""},{"line_number":23,"context_line":"      - \"{{ node_custom_config }}/skyline.yaml\""},{"line_number":24,"context_line":"      - \"{{ node_custom_config }}/skyline/skyline.yaml\""},{"line_number":25,"context_line":"      - \"{{ node_custom_config }}/skyline/{{ inventory_hostname }}/skyline.yaml\""},{"line_number":26,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/skyline.yaml\""},{"line_number":27,"context_line":"    mode: \"0660\""},{"line_number":28,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"11f1d2a0_bc866d86","line":25,"in_reply_to":"b029b811_e9f2da0f","updated":"2024-01-24 07:31:42.000000000","message":"Done","commit_id":"c83eb5474714b4d5dab65c11f334116d0b3a846c"}]}