)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3be7c5e8c1f9012fcdbe47f0cb815d774ef43879","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c8dd0785_3632c57f","updated":"2024-01-24 20:59:00.000000000","message":"recheck keystone timeout","commit_id":"c6d8a6e53dcab25f318091489070aad18616aece"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f1c84fa2ec5504b169d03533c88cb5e77b1b1d8c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"adfda9e3_70185028","updated":"2024-01-25 06:06:44.000000000","message":"Not sure yet why but this is causing a failure in kolla-ansible-ubuntu-multinode-ipv6 https://zuul.opendev.org/t/openstack/build/19c45ebea34845ed9476597e00562846 : FAILURE in 53m 34s (non-voting)","commit_id":"3f6b3a0a4ad8da4ec5e2884438e48904d149b07d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5da5ec0b9cb226a06f5de236d8ad4a79d1aa69e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b736eee8_701fbea8","in_reply_to":"2bb359bd_e73fe283","updated":"2024-01-25 16:40:35.000000000","message":"Horizon ipv6 fixed , reason pymemcached library use different format for ipv6 address","commit_id":"3f6b3a0a4ad8da4ec5e2884438e48904d149b07d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cc4b97cb558bdfe5ab1e211d3682af5a886fb463","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2bb359bd_e73fe283","in_reply_to":"adfda9e3_70185028","updated":"2024-01-25 07:54:44.000000000","message":"yep, I was also surprised, maybe only coincidence?","commit_id":"3f6b3a0a4ad8da4ec5e2884438e48904d149b07d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"820eb77befcff704307d54ea060a263312c408c2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"16cb5f39_0306e755","updated":"2024-01-30 09:29:30.000000000","message":"The idea itself makes sense to me, but there are lots of changes from ansible/roles/horizon/templates/local_settings.j2 to ansible/roles/horizon/templates/_9998-kolla-settings.py.j2 which IMO make this patch unreviewable. Are these all neccessary? Can you split this up into two patches, one renaming the file and another modifying it?\n\nThis will also need a release note for deployers to update their modifications if they have some.","commit_id":"036c8d8f946c6e910cc110dd49ea460e295b3a4d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f78948379b2e2a65f1e64cecd74bd49b01691e0b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a954dd5f_d3ec60d9","in_reply_to":"0cb74dc5_97dc5ce8","updated":"2024-01-31 10:07:11.000000000","message":"I remember that I didn\u0027t change anything and also leave vars set as they were before, but yeah - it was probably not good idea to reorder config - I just wanted to have some nice logical structure... I will reorder it as it was before.","commit_id":"036c8d8f946c6e910cc110dd49ea460e295b3a4d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2524d02043ff7cb04384e1c63a38d66f4f255b3e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"55a9c28d_a7574059","in_reply_to":"16cb5f39_0306e755","updated":"2024-01-30 09:55:54.000000000","message":"I was expecting such a comment, but actually lot of changes just means lot of comment removals as we are not tracking the comments in other projects ... I will check deeper and explain .. I will also potentially split into two patches","commit_id":"036c8d8f946c6e910cc110dd49ea460e295b3a4d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0072ca409bcc28a44a58df7ec15c29d0260cd857","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0cb74dc5_97dc5ce8","in_reply_to":"55a9c28d_a7574059","updated":"2024-01-31 08:17:28.000000000","message":"Removing comments is fine by me, but can you avoid reordering what remains? The current diff is still too much work to review properly for actual changes IMO. Still no reno either.","commit_id":"036c8d8f946c6e910cc110dd49ea460e295b3a4d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a4a67abae9dbb765a02acd88071da6477e0cd035","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"cb0ae302_b1000956","in_reply_to":"a954dd5f_d3ec60d9","updated":"2024-02-07 15:45:35.000000000","message":"I guess this discussion is resolved?","commit_id":"036c8d8f946c6e910cc110dd49ea460e295b3a4d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"59511f3a8a5aa7fc913b126203d5383806e9c830","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"36dbf223_f5564047","in_reply_to":"cb0ae302_b1000956","updated":"2024-02-07 16:04:52.000000000","message":"reordered","commit_id":"036c8d8f946c6e910cc110dd49ea460e295b3a4d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d76b622343c73fc29c1c8b593c033dadf655f5bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"d351fa59_e24f67a4","updated":"2024-02-07 09:59:14.000000000","message":"IMO this still needs a release note. there\u0027s also a section in doc/source/reference/shared-services/horizon-guide.rst that looks related","commit_id":"5149f4fb92fced620962816439e866c5b249cf85"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"84c03d9ef7e09066c071e13e69ede4d7feb59a48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"45d615d8_9fda34fd","updated":"2024-02-08 15:54:25.000000000","message":"recheck previous change merged","commit_id":"b5aa63dee197c9c2c275e07eb8d1749df92ba664"}],"ansible/roles/horizon/tasks/config.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a4a67abae9dbb765a02acd88071da6477e0cd035","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  with_first_found:"},{"line_number":89,"context_line":"    - \"{{ node_custom_config }}/horizon/{{ inventory_hostname }}/_9998-kolla-settings.py\""},{"line_number":90,"context_line":"    - \"{{ node_custom_config }}/horizon/_9998-kolla-settings.py\""},{"line_number":91,"context_line":"    - \"_9998-kolla-settings.py.j2\""},{"line_number":92,"context_line":"  when:"},{"line_number":93,"context_line":"    - horizon.enabled | bool"},{"line_number":94,"context_line":"    - inventory_hostname in groups[horizon.group]"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bde33aa7_566d40bb","line":91,"range":{"start_line":91,"start_character":7,"end_line":91,"end_character":33},"updated":"2024-02-07 15:45:35.000000000","message":"just wondering: is there some historical reason why this file would start with an underscore? I know it\u0027s not related to the patch, just curious.","commit_id":"b5aa63dee197c9c2c275e07eb8d1749df92ba664"}],"ansible/roles/horizon/templates/_9998-kolla-settings.py.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"64d48893c44a3632d990f1f02dc202a96e62ec05","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import os"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1a30387e_8f30e478","side":"PARENT","line":1,"updated":"2024-02-05 10:24:46.000000000","message":"I assume we\u0027re only deleting the defaults that we don\u0027t change in K-A?","commit_id":"7da0f2010a790d3cb925528e27ccbe418a7f365f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"aa9d93eff21d8ff0016d1067d546ba056884b67d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import os"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"ded0f5e9_44b31c68","side":"PARENT","line":1,"in_reply_to":"1a30387e_8f30e478","updated":"2024-02-05 10:31:40.000000000","message":"This is already included in local_settings (https://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example) and local_settings.d files are imported via https://github.com/openstack/horizon/blob/d42e40ab30ee10b37272e329f1251c29b4312228/openstack_dashboard/settings.py#L275","commit_id":"7da0f2010a790d3cb925528e27ccbe418a7f365f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b7bf8808331b283a3821dc482770b68251307535","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import os"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"from django.utils.translation import gettext_lazy as _"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"from openstack_dashboard import exceptions"},{"line_number":8,"context_line":"from openstack_dashboard.settings import HORIZON_CONFIG"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"7064a3c5_8a7614e1","side":"PARENT","line":5,"updated":"2024-02-06 09:09:26.000000000","message":"This func is still being used below, not sure how this isn\u0027t failing. some kind of late evaluation happening?","commit_id":"ae2082ee0c0814a6993872d8c6edd881ef315712"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4d1b624faead683381297adba291ec7dfad61bad","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import os"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"from django.utils.translation import gettext_lazy as _"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"from openstack_dashboard import exceptions"},{"line_number":8,"context_line":"from openstack_dashboard.settings import HORIZON_CONFIG"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"8be697ce_40fc6a19","side":"PARENT","line":5,"in_reply_to":"7064a3c5_8a7614e1","updated":"2024-02-06 11:19:41.000000000","message":"Because as I said this was reworked in horizon itself long time ago. In horizon there are some defaults in defaults.py and settings.py.\n\nLocal_settings.d are overides and shouldn\u0027t be used as local_setting.py but more as overrides.\n\nimport os \nhttps://github.com/openstack/horizon/blob/1966d5ce82cd154ed984c4bcbdf1c119ffba47a0/openstack_dashboard/settings.py#L21\n\nfrom django.utils.translation import gettext_lazy as _\nhttps://github.com/openstack/horizon/blob/1966d5ce82cd154ed984c4bcbdf1c119ffba47a0/openstack_dashboard/settings.py#L25C1-L25C55\n\nfrom openstack_dashboard import exceptions\nhttps://github.com/openstack/horizon/blob/1966d5ce82cd154ed984c4bcbdf1c119ffba47a0/openstack_dashboard/settings.py#L30\n\nfrom openstack_dashboard.settings import HORIZON_CONFIG\nhttps://github.com/openstack/horizon/blob/1966d5ce82cd154ed984c4bcbdf1c119ffba47a0/openstack_dashboard/settings.py#L55C1-L75C2","commit_id":"ae2082ee0c0814a6993872d8c6edd881ef315712"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b7bf8808331b283a3821dc482770b68251307535","unresolved":true,"context_lines":[{"line_number":94,"context_line":"WEBSSO_ENABLED \u003d True"},{"line_number":95,"context_line":"WEBSSO_KEYSTONE_URL \u003d \"{{ keystone_public_url }}/v3\""},{"line_number":96,"context_line":"WEBSSO_CHOICES \u003d ("},{"line_number":97,"context_line":"    (\"credentials\", _(\"Keystone Credentials\")),"},{"line_number":98,"context_line":"    {% for idp in keystone_identity_providers %}"},{"line_number":99,"context_line":"    (\"{{ idp.name }}_{{ idp.protocol }}\", \"{{ idp.public_name }}\"),"},{"line_number":100,"context_line":"    {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"2500b3f0_bedace5e","line":97,"updated":"2024-02-06 09:09:26.000000000","message":"_() is still being used here","commit_id":"7313cdd4b9186a14bc0535b57dc60c733fe6183c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4d1b624faead683381297adba291ec7dfad61bad","unresolved":false,"context_lines":[{"line_number":94,"context_line":"WEBSSO_ENABLED \u003d True"},{"line_number":95,"context_line":"WEBSSO_KEYSTONE_URL \u003d \"{{ keystone_public_url }}/v3\""},{"line_number":96,"context_line":"WEBSSO_CHOICES \u003d ("},{"line_number":97,"context_line":"    (\"credentials\", _(\"Keystone Credentials\")),"},{"line_number":98,"context_line":"    {% for idp in keystone_identity_providers %}"},{"line_number":99,"context_line":"    (\"{{ idp.name }}_{{ idp.protocol }}\", \"{{ idp.public_name }}\"),"},{"line_number":100,"context_line":"    {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"d1b868a5_cb6efd76","line":97,"in_reply_to":"2500b3f0_bedace5e","updated":"2024-02-06 11:19:41.000000000","message":"Check comment 1.","commit_id":"7313cdd4b9186a14bc0535b57dc60c733fe6183c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b7bf8808331b283a3821dc482770b68251307535","unresolved":true,"context_lines":[{"line_number":42,"context_line":"     (\u0027{{ theme.name|e }}\u0027, \u0027{{ theme.label|e }}\u0027, \u0027/etc/openstack-dashboard/themes/{{ theme.name|e }}\u0027),"},{"line_number":43,"context_line":"{% endfor %}"},{"line_number":44,"context_line":"]"},{"line_number":45,"context_line":"{% endif %}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Cache"},{"line_number":48,"context_line":"{% if horizon_backend_database | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"802c14f2_d1bdd177","line":45,"updated":"2024-02-06 09:09:26.000000000","message":"the previous 40 lines are still being reordered from other locations","commit_id":"fd63e495f6e3bc3d3341c13dee5099a00ce55027"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d76b622343c73fc29c1c8b593c033dadf655f5bc","unresolved":false,"context_lines":[{"line_number":42,"context_line":"     (\u0027{{ theme.name|e }}\u0027, \u0027{{ theme.label|e }}\u0027, \u0027/etc/openstack-dashboard/themes/{{ theme.name|e }}\u0027),"},{"line_number":43,"context_line":"{% endfor %}"},{"line_number":44,"context_line":"]"},{"line_number":45,"context_line":"{% endif %}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Cache"},{"line_number":48,"context_line":"{% if horizon_backend_database | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"da3525ee_db4e7216","line":45,"in_reply_to":"802c14f2_d1bdd177","updated":"2024-02-07 09:59:14.000000000","message":"Done","commit_id":"fd63e495f6e3bc3d3341c13dee5099a00ce55027"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d76b622343c73fc29c1c8b593c033dadf655f5bc","unresolved":true,"context_lines":[{"line_number":18,"context_line":"}"},{"line_number":19,"context_line":"{% else %}"},{"line_number":20,"context_line":"SESSION_ENGINE \u003d \u0027django.contrib.sessions.backends.cache\u0027"},{"line_number":21,"context_line":"CACHES[\u0027default\u0027][\u0027LOCATION\u0027] \u003d [{% for host in groups[\u0027memcached\u0027] %}\u0027{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ memcached_port }}\u0027{% if not loop.last %},{% endif %}{% endfor %}]"},{"line_number":22,"context_line":"{% endif %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% if kolla_enable_tls_external | bool or kolla_enable_tls_internal | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"df59bf93_c1a8ca48","line":21,"updated":"2024-02-07 09:59:14.000000000","message":"o.k., now we\u0027re getting somewhere and one can clearly see these three lines as the \"fix horizon deployment\" part of the patch. this should get at least mentionen in the commit message, maybe even better be moved into its own patch","commit_id":"5149f4fb92fced620962816439e866c5b249cf85"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3044df1771e58a22a6c02d54a51e8dee22c28531","unresolved":false,"context_lines":[{"line_number":18,"context_line":"}"},{"line_number":19,"context_line":"{% else %}"},{"line_number":20,"context_line":"SESSION_ENGINE \u003d \u0027django.contrib.sessions.backends.cache\u0027"},{"line_number":21,"context_line":"CACHES[\u0027default\u0027][\u0027LOCATION\u0027] \u003d [{% for host in groups[\u0027memcached\u0027] %}\u0027{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ memcached_port }}\u0027{% if not loop.last %},{% endif %}{% endfor %}]"},{"line_number":22,"context_line":"{% endif %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% if kolla_enable_tls_external | bool or kolla_enable_tls_internal | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"6cc1d75e_4dee8435","line":21,"in_reply_to":"df59bf93_c1a8ca48","updated":"2024-02-07 15:13:48.000000000","message":"Done","commit_id":"5149f4fb92fced620962816439e866c5b249cf85"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a4a67abae9dbb765a02acd88071da6477e0cd035","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import os"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"from django.utils.translation import gettext_lazy as _"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"from openstack_dashboard import exceptions"},{"line_number":8,"context_line":"from openstack_dashboard.settings import HORIZON_CONFIG"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"DEBUG \u003d {{ horizon_logging_debug }}"},{"line_number":11,"context_line":"TEMPLATE_DEBUG \u003d DEBUG"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"d7e72349_fdd3b527","side":"PARENT","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":55},"updated":"2024-02-07 15:45:35.000000000","message":"why are these not needed anymore?","commit_id":"43272acfc3fd7dfa2427bbdd7808ef8bb2f6fa3a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"59511f3a8a5aa7fc913b126203d5383806e9c830","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import os"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"from django.utils.translation import gettext_lazy as _"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"from openstack_dashboard import exceptions"},{"line_number":8,"context_line":"from openstack_dashboard.settings import HORIZON_CONFIG"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"DEBUG \u003d {{ horizon_logging_debug }}"},{"line_number":11,"context_line":"TEMPLATE_DEBUG \u003d DEBUG"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"2936367b_42482a4a","side":"PARENT","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":55},"in_reply_to":"d7e72349_fdd3b527","updated":"2024-02-07 16:04:52.000000000","message":"import os \nhttps://github.com/openstack/horizon/blob/ba2b5fe7845a09f7544044db1cdefafe83a1a106/openstack_dashboard/settings.py#L21\nfrom django.utils.translation import gettext_lazy as _\nhttps://github.com/openstack/horizon/blob/ba2b5fe7845a09f7544044db1cdefafe83a1a106/openstack_dashboard/settings.py#L25\nfrom openstack_dashboard.settings import HORIZON_CONFIG\nhttps://github.com/openstack/horizon/blob/ba2b5fe7845a09f7544044db1cdefafe83a1a106/openstack_dashboard/settings.py#L55C1-L75C2","commit_id":"43272acfc3fd7dfa2427bbdd7808ef8bb2f6fa3a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a4a67abae9dbb765a02acd88071da6477e0cd035","unresolved":true,"context_lines":[{"line_number":866,"context_line":"{% endif %}"},{"line_number":867,"context_line":""},{"line_number":868,"context_line":"# Allow operators to overwrite variables (LP: #1769970)."},{"line_number":869,"context_line":"from .custom_local_settings import *"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"51bc2666_e8e8ebe2","side":"PARENT","line":869,"range":{"start_line":869,"start_character":0,"end_line":869,"end_character":36},"updated":"2024-02-07 15:45:35.000000000","message":"any explanation why this is not needed anymore?","commit_id":"43272acfc3fd7dfa2427bbdd7808ef8bb2f6fa3a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"59511f3a8a5aa7fc913b126203d5383806e9c830","unresolved":false,"context_lines":[{"line_number":866,"context_line":"{% endif %}"},{"line_number":867,"context_line":""},{"line_number":868,"context_line":"# Allow operators to overwrite variables (LP: #1769970)."},{"line_number":869,"context_line":"from .custom_local_settings import *"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"246c3861_bbaf20b1","side":"PARENT","line":869,"range":{"start_line":869,"start_character":0,"end_line":869,"end_character":36},"in_reply_to":"51bc2666_e8e8ebe2","updated":"2024-02-07 16:04:52.000000000","message":"Because horizon supports execution of python scripts inside the local_settings.d dir.\n\nhttps://github.com/openstack/horizon/blob/ba2b5fe7845a09f7544044db1cdefafe83a1a106/openstack_dashboard/settings.py#L268C1-L280C70\n\nAnd they are executed alphabetical ...and loaded in one for cycle in a code as above.","commit_id":"43272acfc3fd7dfa2427bbdd7808ef8bb2f6fa3a"}],"tests/run.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0072ca409bcc28a44a58df7ec15c29d0260cd857","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        build_image_tag: \"change_{{ zuul.change | default(\u0027none\u0027) }}\""},{"line_number":23,"context_line":"        openstack_core_enabled: \"{{ openstack_core_enabled }}\""},{"line_number":24,"context_line":"        openstack_core_tested: \"{{ scenario in [\u0027core\u0027, \u0027cephadm\u0027, \u0027zun\u0027, \u0027cells\u0027, \u0027swift\u0027, \u0027ovn\u0027, \u0027lets-encrypt\u0027] }}\""},{"line_number":25,"context_line":"        dashboard_enabled: \"{{ openstack_core_enabled }}\""},{"line_number":26,"context_line":"        upper_constraints_file: \"{{ ansible_env.HOME }}/src/opendev.org/openstack/requirements/upper-constraints.txt\""},{"line_number":27,"context_line":"        docker_image_tag_suffix: \"{{ \u0027-aarch64\u0027 if ansible_architecture \u003d\u003d \u0027aarch64\u0027 else \u0027\u0027 }}\""},{"line_number":28,"context_line":"        kolla_ansible_venv_path: \"{{ ansible_env.HOME }}/kolla-ansible-venv\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"b055eab2_1a8ea7a0","line":25,"updated":"2024-01-31 08:17:28.000000000","message":"this actually looks unrelated to me, why is this needed? might warrant a line or two in the commit message","commit_id":"f233cbca480cc944c27e69fbcd2160cc4eb91be0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"20cf933fa0a492e0182d2493a46cfb5f999d00ca","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        build_image_tag: \"change_{{ zuul.change | default(\u0027none\u0027) }}\""},{"line_number":23,"context_line":"        openstack_core_enabled: \"{{ openstack_core_enabled }}\""},{"line_number":24,"context_line":"        openstack_core_tested: \"{{ scenario in [\u0027core\u0027, \u0027cephadm\u0027, \u0027zun\u0027, \u0027cells\u0027, \u0027swift\u0027, \u0027ovn\u0027, \u0027lets-encrypt\u0027] }}\""},{"line_number":25,"context_line":"        dashboard_enabled: \"{{ openstack_core_enabled }}\""},{"line_number":26,"context_line":"        upper_constraints_file: \"{{ ansible_env.HOME }}/src/opendev.org/openstack/requirements/upper-constraints.txt\""},{"line_number":27,"context_line":"        docker_image_tag_suffix: \"{{ \u0027-aarch64\u0027 if ansible_architecture \u003d\u003d \u0027aarch64\u0027 else \u0027\u0027 }}\""},{"line_number":28,"context_line":"        kolla_ansible_venv_path: \"{{ ansible_env.HOME }}/kolla-ansible-venv\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6d6f214f_eae88c89","line":25,"in_reply_to":"1fee7ca7_54e7ab04","updated":"2024-02-05 13:28:43.000000000","message":"BUT, as you can see ...horizon is broken ..so horizon testing needs to be enabled in this patch where it is fixed...","commit_id":"f233cbca480cc944c27e69fbcd2160cc4eb91be0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5d362e0253ccd0a43f0bce2edc729c6a9fce012e","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        build_image_tag: \"change_{{ zuul.change | default(\u0027none\u0027) }}\""},{"line_number":23,"context_line":"        openstack_core_enabled: \"{{ openstack_core_enabled }}\""},{"line_number":24,"context_line":"        openstack_core_tested: \"{{ scenario in [\u0027core\u0027, \u0027cephadm\u0027, \u0027zun\u0027, \u0027cells\u0027, \u0027swift\u0027, \u0027ovn\u0027, \u0027lets-encrypt\u0027] }}\""},{"line_number":25,"context_line":"        dashboard_enabled: \"{{ openstack_core_enabled }}\""},{"line_number":26,"context_line":"        upper_constraints_file: \"{{ ansible_env.HOME }}/src/opendev.org/openstack/requirements/upper-constraints.txt\""},{"line_number":27,"context_line":"        docker_image_tag_suffix: \"{{ \u0027-aarch64\u0027 if ansible_architecture \u003d\u003d \u0027aarch64\u0027 else \u0027\u0027 }}\""},{"line_number":28,"context_line":"        kolla_ansible_venv_path: \"{{ ansible_env.HOME }}/kolla-ansible-venv\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"87a84119_0b551299","line":25,"in_reply_to":"28a6298d_14ed350a","updated":"2024-02-05 13:32:25.000000000","message":"It can\u0027t because previous patches will fail ... Because current situation is that horizon is not working ...","commit_id":"f233cbca480cc944c27e69fbcd2160cc4eb91be0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"64d48893c44a3632d990f1f02dc202a96e62ec05","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        build_image_tag: \"change_{{ zuul.change | default(\u0027none\u0027) }}\""},{"line_number":23,"context_line":"        openstack_core_enabled: \"{{ openstack_core_enabled }}\""},{"line_number":24,"context_line":"        openstack_core_tested: \"{{ scenario in [\u0027core\u0027, \u0027cephadm\u0027, \u0027zun\u0027, \u0027cells\u0027, \u0027swift\u0027, \u0027ovn\u0027, \u0027lets-encrypt\u0027] }}\""},{"line_number":25,"context_line":"        dashboard_enabled: \"{{ openstack_core_enabled }}\""},{"line_number":26,"context_line":"        upper_constraints_file: \"{{ ansible_env.HOME }}/src/opendev.org/openstack/requirements/upper-constraints.txt\""},{"line_number":27,"context_line":"        docker_image_tag_suffix: \"{{ \u0027-aarch64\u0027 if ansible_architecture \u003d\u003d \u0027aarch64\u0027 else \u0027\u0027 }}\""},{"line_number":28,"context_line":"        kolla_ansible_venv_path: \"{{ ansible_env.HOME }}/kolla-ansible-venv\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"b61971a3_e093e9ec","line":25,"in_reply_to":"6d2dafc4_2adf54dd","updated":"2024-02-05 10:24:46.000000000","message":"That should still go in a separate patch","commit_id":"f233cbca480cc944c27e69fbcd2160cc4eb91be0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"52de0c6e3b6c47bc1da637de39abff0f8c44ba08","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        build_image_tag: \"change_{{ zuul.change | default(\u0027none\u0027) }}\""},{"line_number":23,"context_line":"        openstack_core_enabled: \"{{ openstack_core_enabled }}\""},{"line_number":24,"context_line":"        openstack_core_tested: \"{{ scenario in [\u0027core\u0027, \u0027cephadm\u0027, \u0027zun\u0027, \u0027cells\u0027, \u0027swift\u0027, \u0027ovn\u0027, \u0027lets-encrypt\u0027] }}\""},{"line_number":25,"context_line":"        dashboard_enabled: \"{{ openstack_core_enabled }}\""},{"line_number":26,"context_line":"        upper_constraints_file: \"{{ ansible_env.HOME }}/src/opendev.org/openstack/requirements/upper-constraints.txt\""},{"line_number":27,"context_line":"        docker_image_tag_suffix: \"{{ \u0027-aarch64\u0027 if ansible_architecture \u003d\u003d \u0027aarch64\u0027 else \u0027\u0027 }}\""},{"line_number":28,"context_line":"        kolla_ansible_venv_path: \"{{ ansible_env.HOME }}/kolla-ansible-venv\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"28a6298d_14ed350a","line":25,"in_reply_to":"6d6f214f_eae88c89","updated":"2024-02-05 13:31:09.000000000","message":"It can be stacked on top of the change where it\u0027s fixed.","commit_id":"f233cbca480cc944c27e69fbcd2160cc4eb91be0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ee2fa43fe7991b9cbad3ccda6ca46e39a2513812","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        build_image_tag: \"change_{{ zuul.change | default(\u0027none\u0027) }}\""},{"line_number":23,"context_line":"        openstack_core_enabled: \"{{ openstack_core_enabled }}\""},{"line_number":24,"context_line":"        openstack_core_tested: \"{{ scenario in [\u0027core\u0027, \u0027cephadm\u0027, \u0027zun\u0027, \u0027cells\u0027, \u0027swift\u0027, \u0027ovn\u0027, \u0027lets-encrypt\u0027] }}\""},{"line_number":25,"context_line":"        dashboard_enabled: \"{{ openstack_core_enabled }}\""},{"line_number":26,"context_line":"        upper_constraints_file: \"{{ ansible_env.HOME }}/src/opendev.org/openstack/requirements/upper-constraints.txt\""},{"line_number":27,"context_line":"        docker_image_tag_suffix: \"{{ \u0027-aarch64\u0027 if ansible_architecture \u003d\u003d \u0027aarch64\u0027 else \u0027\u0027 }}\""},{"line_number":28,"context_line":"        kolla_ansible_venv_path: \"{{ ansible_env.HOME }}/kolla-ansible-venv\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"b4c3dfbd_7fd5cc4c","line":25,"in_reply_to":"87a84119_0b551299","updated":"2024-02-07 08:20:44.000000000","message":"Horizon testing enabled on top of chain.","commit_id":"f233cbca480cc944c27e69fbcd2160cc4eb91be0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6b3993061440685f465a21f290608e90c14e7150","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        build_image_tag: \"change_{{ zuul.change | default(\u0027none\u0027) }}\""},{"line_number":23,"context_line":"        openstack_core_enabled: \"{{ openstack_core_enabled }}\""},{"line_number":24,"context_line":"        openstack_core_tested: \"{{ scenario in [\u0027core\u0027, \u0027cephadm\u0027, \u0027zun\u0027, \u0027cells\u0027, \u0027swift\u0027, \u0027ovn\u0027, \u0027lets-encrypt\u0027] }}\""},{"line_number":25,"context_line":"        dashboard_enabled: \"{{ openstack_core_enabled }}\""},{"line_number":26,"context_line":"        upper_constraints_file: \"{{ ansible_env.HOME }}/src/opendev.org/openstack/requirements/upper-constraints.txt\""},{"line_number":27,"context_line":"        docker_image_tag_suffix: \"{{ \u0027-aarch64\u0027 if ansible_architecture \u003d\u003d \u0027aarch64\u0027 else \u0027\u0027 }}\""},{"line_number":28,"context_line":"        kolla_ansible_venv_path: \"{{ ansible_env.HOME }}/kolla-ansible-venv\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6d2dafc4_2adf54dd","line":25,"in_reply_to":"b055eab2_1a8ea7a0","updated":"2024-01-31 10:03:50.000000000","message":"It was merged in Ib7f72b2663199ef80844a412bc436c6ef09322cc as we needed to pass linters but horizon was failing also, so we merged linters with temporarily disabled dashboard ...then we merged horizon workaround and from that point it\u0027s disabled ...this patch enables horizon deploy and test again.","commit_id":"f233cbca480cc944c27e69fbcd2160cc4eb91be0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ab1dffb9ea662aaad842c9ba8969557980e02fcc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        build_image_tag: \"change_{{ zuul.change | default(\u0027none\u0027) }}\""},{"line_number":23,"context_line":"        openstack_core_enabled: \"{{ openstack_core_enabled }}\""},{"line_number":24,"context_line":"        openstack_core_tested: \"{{ scenario in [\u0027core\u0027, \u0027cephadm\u0027, \u0027zun\u0027, \u0027cells\u0027, \u0027swift\u0027, \u0027ovn\u0027, \u0027lets-encrypt\u0027] }}\""},{"line_number":25,"context_line":"        dashboard_enabled: \"{{ openstack_core_enabled }}\""},{"line_number":26,"context_line":"        upper_constraints_file: \"{{ ansible_env.HOME }}/src/opendev.org/openstack/requirements/upper-constraints.txt\""},{"line_number":27,"context_line":"        docker_image_tag_suffix: \"{{ \u0027-aarch64\u0027 if ansible_architecture \u003d\u003d \u0027aarch64\u0027 else \u0027\u0027 }}\""},{"line_number":28,"context_line":"        kolla_ansible_venv_path: \"{{ ansible_env.HOME }}/kolla-ansible-venv\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1fee7ca7_54e7ab04","line":25,"in_reply_to":"b61971a3_e093e9ec","updated":"2024-02-05 10:51:36.000000000","message":"Done","commit_id":"f233cbca480cc944c27e69fbcd2160cc4eb91be0"}]}