)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"185f12b74a03ecea95b2e6d16a7a5552a70bbf22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7af73fb4_9b616323","updated":"2024-01-30 12:57:43.000000000","message":"btw, shouldn\u0027t we add service role ? fix this ? there is also bug https://bugs.launchpad.net/kolla-ansible/+bug/2049762","commit_id":"90ac854bb2863c8ca7642d99125b4a56ac4ac331"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"edbb2b3947239c5bb3eda20326cf58d7ca15557b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7fb6a38e_32a5137b","updated":"2024-01-31 09:27:59.000000000","message":"should we have a bug to track this? according to the reno in [1] it also sounds like this workaround might no longer be feasible once 2024.1 gets released?","commit_id":"90ac854bb2863c8ca7642d99125b4a56ac4ac331"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"5011525c11459149836656ac513aaa61644f2341","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"328c2d20_c66d4a82","in_reply_to":"35944068_fb0be712","updated":"2024-01-31 11:51:16.000000000","message":"added Related-Bug flag to commit message","commit_id":"90ac854bb2863c8ca7642d99125b4a56ac4ac331"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"d2e597bd30748217b6dc11b95dd1ed9e30b4d258","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8d7df951_5c84a300","in_reply_to":"7af73fb4_9b616323","updated":"2024-01-30 12:59:58.000000000","message":"yes we should, however this is still in the works on ironic side, as per commit message: https://review.opendev.org/c/openstack/ironic/+/907148","commit_id":"90ac854bb2863c8ca7642d99125b4a56ac4ac331"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d5d4ae32b3b7b28d7da0c081304cec35f14635e1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"35944068_fb0be712","in_reply_to":"7fb6a38e_32a5137b","updated":"2024-01-31 10:58:01.000000000","message":"Seems reasonable.","commit_id":"90ac854bb2863c8ca7642d99125b4a56ac4ac331"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"036297943fde9fdfeb88c467312edb59fed603bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"71a9bc10_7bd05cd2","in_reply_to":"8d7df951_5c84a300","updated":"2024-01-31 11:52:27.000000000","message":"Done","commit_id":"90ac854bb2863c8ca7642d99125b4a56ac4ac331"}],"ansible/roles/ironic/templates/ironic.conf.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"447017f56d3f5153e697edb4e9c6b01ab8655351","unresolved":true,"context_lines":[{"line_number":49,"context_line":"{% endif %}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[oslo_policy]"},{"line_number":52,"context_line":"TODO(bbezak): Remove enforce_* once secure RBAC is supported"},{"line_number":53,"context_line":"enforce_scope\u003dFalse"},{"line_number":54,"context_line":"enforce_new_defaults\u003dFalse"},{"line_number":55,"context_line":"{% if ironic_policy_file is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"524c66b2_1d2ec9b6","line":52,"updated":"2024-01-31 10:55:31.000000000","message":"Did you want that to be a comment?","commit_id":"90ac854bb2863c8ca7642d99125b4a56ac4ac331"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d5d4ae32b3b7b28d7da0c081304cec35f14635e1","unresolved":true,"context_lines":[{"line_number":49,"context_line":"{% endif %}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[oslo_policy]"},{"line_number":52,"context_line":"TODO(bbezak): Remove enforce_* once secure RBAC is supported"},{"line_number":53,"context_line":"enforce_scope\u003dFalse"},{"line_number":54,"context_line":"enforce_new_defaults\u003dFalse"},{"line_number":55,"context_line":"{% if ironic_policy_file is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"78b965f7_684a92bb","line":52,"updated":"2024-01-31 10:58:01.000000000","message":"It\u0027s interesting that it doesn\u0027t care you missed the # here","commit_id":"90ac854bb2863c8ca7642d99125b4a56ac4ac331"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"5011525c11459149836656ac513aaa61644f2341","unresolved":false,"context_lines":[{"line_number":49,"context_line":"{% endif %}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[oslo_policy]"},{"line_number":52,"context_line":"TODO(bbezak): Remove enforce_* once secure RBAC is supported"},{"line_number":53,"context_line":"enforce_scope\u003dFalse"},{"line_number":54,"context_line":"enforce_new_defaults\u003dFalse"},{"line_number":55,"context_line":"{% if ironic_policy_file is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9070b787_8d59e64c","line":52,"in_reply_to":"524c66b2_1d2ec9b6","updated":"2024-01-31 11:51:16.000000000","message":"Done","commit_id":"90ac854bb2863c8ca7642d99125b4a56ac4ac331"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"5011525c11459149836656ac513aaa61644f2341","unresolved":false,"context_lines":[{"line_number":49,"context_line":"{% endif %}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[oslo_policy]"},{"line_number":52,"context_line":"TODO(bbezak): Remove enforce_* once secure RBAC is supported"},{"line_number":53,"context_line":"enforce_scope\u003dFalse"},{"line_number":54,"context_line":"enforce_new_defaults\u003dFalse"},{"line_number":55,"context_line":"{% if ironic_policy_file is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"fdcdf5e3_8e6469e2","line":52,"in_reply_to":"78b965f7_684a92bb","updated":"2024-01-31 11:51:16.000000000","message":"Done","commit_id":"90ac854bb2863c8ca7642d99125b4a56ac4ac331"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d5d4ae32b3b7b28d7da0c081304cec35f14635e1","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[oslo_policy]"},{"line_number":52,"context_line":"TODO(bbezak): Remove enforce_* once secure RBAC is supported"},{"line_number":53,"context_line":"enforce_scope\u003dFalse"},{"line_number":54,"context_line":"enforce_new_defaults\u003dFalse"},{"line_number":55,"context_line":"{% if ironic_policy_file is defined %}"},{"line_number":56,"context_line":"policy_file \u003d {{ ironic_policy_file }}"},{"line_number":57,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"e092aeb0_c5a712fc","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":26},"updated":"2024-01-31 10:58:01.000000000","message":"Let\u0027s wrap this in\n\n{% if openstack_release \u003d\u003d \u0027master\u0027 %}\n\nJust to be sure we don\u0027t release with it.","commit_id":"90ac854bb2863c8ca7642d99125b4a56ac4ac331"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"5011525c11459149836656ac513aaa61644f2341","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[oslo_policy]"},{"line_number":52,"context_line":"TODO(bbezak): Remove enforce_* once secure RBAC is supported"},{"line_number":53,"context_line":"enforce_scope\u003dFalse"},{"line_number":54,"context_line":"enforce_new_defaults\u003dFalse"},{"line_number":55,"context_line":"{% if ironic_policy_file is defined %}"},{"line_number":56,"context_line":"policy_file \u003d {{ ironic_policy_file }}"},{"line_number":57,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"0e3ed983_e6310a8e","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":26},"in_reply_to":"e092aeb0_c5a712fc","updated":"2024-01-31 11:51:16.000000000","message":"Done","commit_id":"90ac854bb2863c8ca7642d99125b4a56ac4ac331"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b6edf5b3231ec11f6bcce4d3be9ae28cd36e9d02","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[oslo_policy]"},{"line_number":52,"context_line":"{% if openstack_release \u003d\u003d \u0027master\u0027 %}"},{"line_number":53,"context_line":"# TODO(bbezak): Remove enforce_* once secure RBAC is supported"},{"line_number":54,"context_line":"enforce_scope\u003dFalse"},{"line_number":55,"context_line":"enforce_new_defaults\u003dFalse"},{"line_number":56,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"80b204c1_c52d571e","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":2},"updated":"2024-01-31 11:56:47.000000000","message":"can we maybe directly link here to https://review.opendev.org/c/openstack/ironic/+/907148 (and possibly other relevant links?) so it\u0027s easier to track this todo?","commit_id":"47f932c2c2cfa5218b5cddc5f9e74899768ec58d"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"808755f6673cbe5c0d85368f426f93eb6d62e85b","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[oslo_policy]"},{"line_number":52,"context_line":"{% if openstack_release \u003d\u003d \u0027master\u0027 %}"},{"line_number":53,"context_line":"# TODO(bbezak): Remove enforce_* once secure RBAC is supported"},{"line_number":54,"context_line":"enforce_scope\u003dFalse"},{"line_number":55,"context_line":"enforce_new_defaults\u003dFalse"},{"line_number":56,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"92de26c6_268fefee","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":2},"in_reply_to":"80b204c1_c52d571e","updated":"2024-01-31 12:52:46.000000000","message":"added bug https://bugs.launchpad.net/kolla-ansible/+bug/2051837 to TODO note - which has all info there","commit_id":"47f932c2c2cfa5218b5cddc5f9e74899768ec58d"}]}
