)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8e34d106eab6d30bea45c5d8ad400be46a9c72ff","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove redis precheck for octavia"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"instead make redis activation conditional"},{"line_number":10,"context_line":"on jobboard"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Sven Kieske \u003ckieske@osism.tech\u003e"},{"line_number":13,"context_line":"Change-Id: I82a14107da4174c1694ce06cc8c5ba6d8b1f1408"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0fd95fb6_f27aa2aa","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":11},"updated":"2024-01-27 07:50:42.000000000","message":"Nit: this can be all on one line.","commit_id":"3bb3dd8fe9168115853a330f002c630fc74bb9be"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8642dc966695e189d61fba115a88cbd0046a6545","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove redis precheck for octavia"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"instead make redis activation conditional"},{"line_number":10,"context_line":"on jobboard"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Sven Kieske \u003ckieske@osism.tech\u003e"},{"line_number":13,"context_line":"Change-Id: I82a14107da4174c1694ce06cc8c5ba6d8b1f1408"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"22d05856_e6460824","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":11},"in_reply_to":"0fd95fb6_f27aa2aa","updated":"2024-03-01 16:43:25.000000000","message":"this is the first time I get a review stating that my lines are too short (usually they are too long).","commit_id":"3bb3dd8fe9168115853a330f002c630fc74bb9be"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1180359e3f2754122e58a4d4620f2bc134c524c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"855b3d2a_ee2fb13d","updated":"2024-03-01 16:55:28.000000000","message":"Just found small bug in ansible/roles/octavia/templates/octavia.conf.j2 .\n\nPlease fix also {% if enable_octavia_jobboard %} to {% if enable_octavia_jobboard | bool %} in this review as it is trivial.","commit_id":"3bb3dd8fe9168115853a330f002c630fc74bb9be"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"842055f21e284979073598de56a822f95329c4a1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dba244bb_1c793b83","in_reply_to":"855b3d2a_ee2fb13d","updated":"2024-03-01 17:31:02.000000000","message":"Not resolved...","commit_id":"3bb3dd8fe9168115853a330f002c630fc74bb9be"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"419d1d6494180fc015d2504936e496a559bceb23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1bd4f589_aa9f0937","updated":"2024-03-01 17:29:49.000000000","message":"I am not sure if there is need to define also Upgrade: block in release note as it means (for user) \"you need to take some action before upgrade\". This is actually not true ..because precheck will handle this ... \n\nBut I don\u0027t care so much ...","commit_id":"7bc5c0cb17a031b57e8619d6f5f29854d13ec469"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c9f77122fe465959ae1ed72f46ec66a00c341d07","unresolved":true,"context_lines":[{"line_number":886,"context_line":"enable_placement: \"{{ enable_nova | bool or enable_zun | bool }}\""},{"line_number":887,"context_line":"enable_prometheus: \"no\""},{"line_number":888,"context_line":"enable_proxysql: \"no\""},{"line_number":889,"context_line":"enable_redis: \"{{ enable_octavia_jobboard | bool }}\""},{"line_number":890,"context_line":"enable_sahara: \"no\""},{"line_number":891,"context_line":"enable_senlin: \"no\""},{"line_number":892,"context_line":"enable_skyline: \"no\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b407aeed_a669fe59","line":889,"updated":"2024-03-13 14:56:24.000000000","message":"If somebody has etcd enabled - then we use this for tooz/coordination in couple of services - and if next release will enable redis automatically - all of coordination gets reconfigured to redid","commit_id":"7bc5c0cb17a031b57e8619d6f5f29854d13ec469"}],"ansible/roles/octavia/tasks/precheck.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8e34d106eab6d30bea45c5d8ad400be46a9c72ff","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    - octavia_network_type \u003d\u003d \"tenant\""},{"line_number":65,"context_line":"    - neutron_plugin_agent !\u003d \u0027openvswitch\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- name: Checking whether Redis is enabled for octavia jobboard"},{"line_number":68,"context_line":"  assert:"},{"line_number":69,"context_line":"    that: enable_redis | bool"},{"line_number":70,"context_line":"    fail_msg: \"Redis must be enabled when using octavia jobboard\""},{"line_number":71,"context_line":"  run_once: True"},{"line_number":72,"context_line":"  when:"},{"line_number":73,"context_line":"    - enable_octavia_jobboard | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2a2ef27c_f8c22ac9","side":"PARENT","line":73,"range":{"start_line":67,"start_character":0,"end_line":73,"end_character":36},"updated":"2024-01-27 07:50:42.000000000","message":"Maybe keep the recheck in case operator have explicitly disabled redis for some reason?","commit_id":"d690177e5846c183da18839eaf805b0ee7200cdc"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8642dc966695e189d61fba115a88cbd0046a6545","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    - octavia_network_type \u003d\u003d \"tenant\""},{"line_number":65,"context_line":"    - neutron_plugin_agent !\u003d \u0027openvswitch\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- name: Checking whether Redis is enabled for octavia jobboard"},{"line_number":68,"context_line":"  assert:"},{"line_number":69,"context_line":"    that: enable_redis | bool"},{"line_number":70,"context_line":"    fail_msg: \"Redis must be enabled when using octavia jobboard\""},{"line_number":71,"context_line":"  run_once: True"},{"line_number":72,"context_line":"  when:"},{"line_number":73,"context_line":"    - enable_octavia_jobboard | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"31e428ff_1041bead","side":"PARENT","line":73,"range":{"start_line":67,"start_character":0,"end_line":73,"end_character":36},"in_reply_to":"2a2ef27c_f8c22ac9","updated":"2024-03-01 16:43:25.000000000","message":"the point of this change was to make our code simpler by removing an unnecessary precheck via this refactor (as is stated in the commit message).\n\nif people want to shoot themselves in the foot by changing this code I guess they always can do that?","commit_id":"d690177e5846c183da18839eaf805b0ee7200cdc"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"77275918fe83054c746d8c630ad9ed3502bc9283","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    - octavia_network_type \u003d\u003d \"tenant\""},{"line_number":65,"context_line":"    - neutron_plugin_agent !\u003d \u0027openvswitch\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- name: Checking whether Redis is enabled for octavia jobboard"},{"line_number":68,"context_line":"  assert:"},{"line_number":69,"context_line":"    that: enable_redis | bool"},{"line_number":70,"context_line":"    fail_msg: \"Redis must be enabled when using octavia jobboard\""},{"line_number":71,"context_line":"  run_once: True"},{"line_number":72,"context_line":"  when:"},{"line_number":73,"context_line":"    - enable_octavia_jobboard | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"edeaea02_b2c1a9b8","side":"PARENT","line":73,"range":{"start_line":67,"start_character":0,"end_line":73,"end_character":36},"in_reply_to":"31e428ff_1041bead","updated":"2024-03-01 17:07:13.000000000","message":"Yes, people can shoot themselves in the foot, which is why we have precheck tasks that tell the user - fix this or you\u0027ll shoot yourself in the foot. \n\nIf these users don\u0027t want or don\u0027t have time for help/validation, they don\u0027t need to run prechecks tasks - not just for the Octavia project, but for any project.\n\nMoreover, ff this type of check already exists, there\u0027s no need to delete it - especially when the jobboard without Redis doesn\u0027t work at all, and it\u0027s a hard requirement.","commit_id":"d690177e5846c183da18839eaf805b0ee7200cdc"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1536975fc149acba90abfc16c7695a264aba7626","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    - octavia_network_type \u003d\u003d \"tenant\""},{"line_number":65,"context_line":"    - neutron_plugin_agent !\u003d \u0027openvswitch\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- name: Checking whether Redis is enabled for octavia jobboard"},{"line_number":68,"context_line":"  assert:"},{"line_number":69,"context_line":"    that: enable_redis | bool"},{"line_number":70,"context_line":"    fail_msg: \"Redis must be enabled when using octavia jobboard\""},{"line_number":71,"context_line":"  run_once: True"},{"line_number":72,"context_line":"  when:"},{"line_number":73,"context_line":"    - enable_octavia_jobboard | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2edb61f3_0850b423","side":"PARENT","line":73,"range":{"start_line":67,"start_character":0,"end_line":73,"end_character":36},"in_reply_to":"edeaea02_b2c1a9b8","updated":"2024-03-01 17:16:33.000000000","message":"Done","commit_id":"d690177e5846c183da18839eaf805b0ee7200cdc"}]}