)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"11741b97ea6ead19a625a6d7a72e850403431b2f","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Kolla-ansible supports configuration"},{"line_number":10,"context_line":"when multiple ceph clusters are used."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch only refactor kolla-ansible code."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This is also very handy when testing multiple ceph"},{"line_number":15,"context_line":"cluster with one ceph cluster but with different"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"900ba6eb_4599e93c","line":12,"updated":"2024-08-22 07:01:41.000000000","message":"Missing motivation for refactoring","commit_id":"0b837d46b790e5e69e411547ec98c12ee447c394"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"667f22b7b8fc003b1d089e762ed3e0e8a144de34","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Kolla-ansible supports configuration"},{"line_number":10,"context_line":"when multiple ceph clusters are used."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch only refactor kolla-ansible code."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This is also very handy when testing multiple ceph"},{"line_number":15,"context_line":"cluster with one ceph cluster but with different"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"1de9b7d0_4efbd46f","line":12,"in_reply_to":"0ad30948_93a40e26","updated":"2024-08-22 10:05:38.000000000","message":"DOCUMENTED motivation in commit message.","commit_id":"0b837d46b790e5e69e411547ec98c12ee447c394"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b8d8c19613e46705ab57447a89f44b9376fb4f08","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Kolla-ansible supports configuration"},{"line_number":10,"context_line":"when multiple ceph clusters are used."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch only refactor kolla-ansible code."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This is also very handy when testing multiple ceph"},{"line_number":15,"context_line":"cluster with one ceph cluster but with different"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"8ffec75a_79ba9435","line":12,"in_reply_to":"1de9b7d0_4efbd46f","updated":"2024-08-22 10:07:44.000000000","message":"Not mentioning - stop calling it refactor - refactor is without any impact on users.","commit_id":"0b837d46b790e5e69e411547ec98c12ee447c394"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"dd8670bfe30a97a9116ab7e61bbedd4190d18ce0","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Kolla-ansible supports configuration"},{"line_number":10,"context_line":"when multiple ceph clusters are used."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch only refactor kolla-ansible code."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This is also very handy when testing multiple ceph"},{"line_number":15,"context_line":"cluster with one ceph cluster but with different"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"d6b03c86_56e35ab9","line":12,"in_reply_to":"8ffec75a_79ba9435","updated":"2024-08-22 10:18:57.000000000","message":"But it\u0027s not impacting users who uses default kolla setup - it works same. From kolla view it\u0027s refactor.","commit_id":"0b837d46b790e5e69e411547ec98c12ee447c394"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cc1918c289978bf8a9d06c9bbe5f53a678e0071d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Kolla-ansible supports configuration"},{"line_number":10,"context_line":"when multiple ceph clusters are used."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch only refactor kolla-ansible code."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This is also very handy when testing multiple ceph"},{"line_number":15,"context_line":"cluster with one ceph cluster but with different"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"0ad30948_93a40e26","line":12,"in_reply_to":"900ba6eb_4599e93c","updated":"2024-08-22 10:01:42.000000000","message":"It\u0027s not :  \n\n1. I am trying to get this code from 30.1.2024 (deployed in production for two versions already with no problem) - i have big motivation \n2. This refactor follows ceph external official user management https://docs.ceph.com/en/latest/rados/operations/user-management/#keyring-management  - means ceph keyring name is $cluster.client.$user.keyring - as it is in this review\n3. When you have multiple clusters for example in multiple availability zones, you want to identify which cluster is which one ...without this patch you need to workaround it and have everywhere ceph.client.client_name.keyring and you have mess in configuration ..also ceph.conf is only one ..with different configs ..but still name ceph - which don\u0027t correspond with official ceph user guide. But yeah, you can reach the same functionality with various config overrides.\n4. I can\u0027t handle custom user overrides . Important is that default is not changed. - what I can add is upgrade note into reno in which cases user  need to amend the config.\n5. Multiple users on irc asks for this patch to be merged ..because then multiple backends, multiple ceph clusters and in overall is more easy - another motivation - to deliver what user needs - i am also one of them\n6. Documentation is written\n\nIt\u0027s the same as we changed rabbitmq queues to be quorum - which is reaaally big change with outage - and we did it. This is about read the reno and amend the config .. and run with --check if everything works.\n\nOR \n\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/798851 for changed users from @mark@stackhpc.com\n\nWhat I can do is add upgrade note into reno. But don\u0027t accept just comment ..there is no motivation.. because actually there is a motivation... make kolla code usable and simpler.","commit_id":"0b837d46b790e5e69e411547ec98c12ee447c394"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"563ad9f7ac0bcd195a4a13e3ac12dce3a95eabdd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Kolla-ansible supports configuration"},{"line_number":10,"context_line":"when multiple ceph clusters are used."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch only refactor kolla-ansible code."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This is also very handy when testing multiple ceph"},{"line_number":15,"context_line":"cluster with one ceph cluster but with different"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"c3d033f4_18df79e1","line":12,"in_reply_to":"d6b03c86_56e35ab9","updated":"2024-09-30 20:33:53.000000000","message":"Commit message updated, reno updated.","commit_id":"0b837d46b790e5e69e411547ec98c12ee447c394"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"206bcd5c3a0ba4082e6866cac07f52e65ac49c9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"15dbbaa0_712ae1f8","updated":"2024-02-01 06:15:16.000000000","message":"recheck seems not related","commit_id":"458bdfbf009d5a3ffe0733d3accc6eca84ba3cfd"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cf8ef007bf1cecbca9adddccd9417c62ae2fd25d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"057d3758_14b7c8d3","updated":"2024-03-20 05:31:45.000000000","message":"Either refactor or add something, not in one patch please","commit_id":"015cc31793bcb2433e0effea6691b33f1654a0ce"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"25ecc1d6a766a31ab04a19b8e69c24a54b45910f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"752941af_11c7ac85","in_reply_to":"057d3758_14b7c8d3","updated":"2024-03-20 08:48:22.000000000","message":"It\u0027s just refactor, default is same, no users affected. What am I missing ?","commit_id":"015cc31793bcb2433e0effea6691b33f1654a0ce"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b537bb4998f7d796620d195cb2a998af0f1b6025","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1db116cc_a52f2d71","in_reply_to":"20da5317_844b3692","updated":"2024-03-20 11:57:56.000000000","message":"Okay, removed from commit message.","commit_id":"015cc31793bcb2433e0effea6691b33f1654a0ce"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8be6d82cd2720fb38d3cb0c0b3f690fea0279a8e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"20da5317_844b3692","in_reply_to":"752941af_11c7ac85","updated":"2024-03-20 08:53:08.000000000","message":"\"and adds a way how to configure user/pool/cluster.\" in commit message","commit_id":"015cc31793bcb2433e0effea6691b33f1654a0ce"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9fd34e5502ce9672a3e2314df77f3ccf0578fbe0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2bb7467d_f6e56d81","updated":"2024-04-02 12:51:13.000000000","message":"Can we return to this review please ?","commit_id":"ea7b276f821df1b7fda2a6ac8ae9ff8e8f95b0aa"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cd3886037338f9002f25fbec7a0a286ab5f554cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e37dd78e_7221abf4","updated":"2024-06-17 11:15:12.000000000","message":"Ping, can we merge it finally ?","commit_id":"0b0de0091b6628e628514b537ed7ff34a8909a93"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4fb1448a4faca48328a9be0746eedf0f53c8a2a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0da304bd_bed2daf4","updated":"2024-06-17 14:42:00.000000000","message":"recheck cephadm failures need fresh logs to analyze (logs expired).\nCode mostly LGTM.","commit_id":"0b0de0091b6628e628514b537ed7ff34a8909a93"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4e475a3b42e01b99a9106983c3aa041511cbd2ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9df5894c_3d73d532","updated":"2024-07-17 10:28:16.000000000","message":"Okay, now everything ready I think... tested. It would be nice to merge finally.","commit_id":"eba72c7860aa760a05d5e69f94f3c630b9ff85f8"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"13ab29dbc1f23f5c2537e3572ae8fcffea9b5bd2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9baf8987_5eb9c45e","updated":"2024-07-17 13:28:38.000000000","message":"and release note missing","commit_id":"eba72c7860aa760a05d5e69f94f3c630b9ff85f8"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"06430c81e716754fa01623508bf9dace74d1cdef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"8bb844a8_321064a2","in_reply_to":"9baf8987_5eb9c45e","updated":"2024-07-18 13:00:56.000000000","message":"Done","commit_id":"eba72c7860aa760a05d5e69f94f3c630b9ff85f8"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"06430c81e716754fa01623508bf9dace74d1cdef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b405c2de_9e3aec6c","updated":"2024-07-18 13:00:56.000000000","message":"Reno added","commit_id":"f3bd958320ed68d614a4b9efb2e8a3345415ac04"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"af67b21cb2db25a9a4b866e284ff92855d5e32f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5431cdce_51f95e45","updated":"2024-07-18 15:28:07.000000000","message":"This is very weird that cephadm is now failing :/","commit_id":"f3bd958320ed68d614a4b9efb2e8a3345415ac04"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a1d8abbd50c4a5761c0a9b4ea6773e9919cf2b0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"562201f7_ab763635","updated":"2024-07-18 13:47:45.000000000","message":"code LGTM, currently investigating why all the cephadm jobs are failing.","commit_id":"f3bd958320ed68d614a4b9efb2e8a3345415ac04"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d7608e9df9334371cf457814a721543d86baa7fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"3c94d39f_314d5570","updated":"2024-07-19 00:23:51.000000000","message":"i really don\u0027t see any issue :( ...tried to remove if service \u003d\u003d cinder-volume. But i don\u0027t have it on my test and working  ....","commit_id":"f3bd958320ed68d614a4b9efb2e8a3345415ac04"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"58cebd1ef80979e3a436add55bdc075c02ddb7d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9ec61903_82c1566d","updated":"2024-07-18 14:35:31.000000000","message":"need to find the reason why cephadm jobs now fail at volume attachment to an instance.","commit_id":"f3bd958320ed68d614a4b9efb2e8a3345415ac04"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"27397e434ac92305ba645518193c423721475b8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ac975f81_ef0f3fac","updated":"2024-07-18 16:27:47.000000000","message":"recheck cephadm","commit_id":"f3bd958320ed68d614a4b9efb2e8a3345415ac04"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"24b0f05c32d5ef672d5e923e6c54de4d1bf1d223","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"333ad304_6b6d253c","updated":"2024-07-18 13:51:10.000000000","message":"recheck volume attachment not working in job kolla-ansible-ubuntu-cephadm in test-core-openstack.sh","commit_id":"f3bd958320ed68d614a4b9efb2e8a3345415ac04"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"58cebd1ef80979e3a436add55bdc075c02ddb7d0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"839e426c_eb86f00c","in_reply_to":"53659a2a_8f5fae85","updated":"2024-07-18 14:35:31.000000000","message":"mhm, attachement seems to persistently fail somehow, and yeah, I agree that it should probably give us at least one complete green result.\n\nsee: https://zuul.opendev.org/t/openstack/build/912b6eefa45e4e7fad681392a54fced4/log/primary/logs/ansible/test-core-openstack\n\nlooking into if I can find anything, if anybody has a good idea I\u0027m really inclined to hear it thought :)","commit_id":"f3bd958320ed68d614a4b9efb2e8a3345415ac04"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cbed56f5f8066edcdc1d8a905e20e385c9efb727","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"53659a2a_8f5fae85","in_reply_to":"562201f7_ab763635","updated":"2024-07-18 13:49:17.000000000","message":"would say those are essential ;-)","commit_id":"f3bd958320ed68d614a4b9efb2e8a3345415ac04"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d94747619c73e540028ea9a4f45e9fd6d1a9c001","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"8f73d9a7_00390ac1","in_reply_to":"839e426c_eb86f00c","updated":"2024-07-20 19:36:19.000000000","message":"Okay, now it\u0027s solved. As I changed hardcoded values of client.nova and client.cinder to the rendered ones - from kolla variables. It caused same libvirt secret\u0027s name issue. In that case just the second libvirt secret was created not the first one , simply said..it was overiden. So nova/cinder or cinder/nova was not working.\n\nFixed by previous commit in chain, also created a bug which i found during the test.","commit_id":"f3bd958320ed68d614a4b9efb2e8a3345415ac04"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"dc2241b28ff381a6f01c6f5ac5cc5c277e4b0fa7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"c4436973_610f3bb9","updated":"2024-07-20 09:54:47.000000000","message":"recheck rocky cephadm","commit_id":"cbf2a064288b7fd3cbbb809d1ea70558664ab0ea"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2b925f3801e5085c097cfcc90364f49b9f43913b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"6b256059_d42b2c47","updated":"2024-07-20 19:09:46.000000000","message":"Okay, it will pass :). Just a moment :)","commit_id":"66875a569df6e8991bbb865bf9849f626a783114"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ff514d153657b39ff9407ba5454d5c1498f2e30d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"33af717d_84d1ef20","updated":"2024-07-20 16:52:44.000000000","message":"now, working , ceph upgrade rocky failing in deploy phase so it\u0027s not my fault","commit_id":"66875a569df6e8991bbb865bf9849f626a783114"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"bc7b7325cfc5147630a123f44104f265120f61ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"3f350266_295c0604","updated":"2024-07-20 16:37:36.000000000","message":"recheck rocky cephadm upgrade","commit_id":"66875a569df6e8991bbb865bf9849f626a783114"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"575054dc4686afcd060aeb00d3672356c13ac116","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"6d2ed5a5_203f3793","updated":"2024-07-20 19:31:14.000000000","message":"vuala, success","commit_id":"66875a569df6e8991bbb865bf9849f626a783114"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6032e53594ae66b6c23c558df6e9a70c4ffbd0fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"01d9feb8_bf8c287c","in_reply_to":"33af717d_84d1ef20","updated":"2024-07-20 18:51:34.000000000","message":"Oh, hmm ..sorry ..now i am see it better ..it\u0027s same job but rocky ..that\u0027s weird.","commit_id":"66875a569df6e8991bbb865bf9849f626a783114"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6249e672474775c3562ac02faa89ad600d4b5fe3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"02df32a4_31170ce0","updated":"2024-07-22 10:16:50.000000000","message":"recheck rocky cephadm","commit_id":"bc5a7719b3d39caf0b83aaa527df75ebb9bebac5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"935f0690b39151cbc8e481a33246449f6c15796e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"b7bd7a37_154014da","updated":"2024-08-08 13:57:56.000000000","message":"ping","commit_id":"50f09d26d3500e835b558393782f8636f81ab372"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f8998e8c18a2079387dcde3ab234e61970a6d745","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"f165ea47_c6753b38","updated":"2024-07-30 06:50:37.000000000","message":"recheck build failure in kolla-ansible-ubuntu-upgrade-cephadm in test-core-openstack-upgrade.sh (falsely reported as test-core-openstack.sh, separate bug filed in https://bugs.launchpad.net/kolla-ansible/+bug/2075123 ) failed during: TESTING: Instance (Nova and Neutron) upgrade stability (PHASE: upgrade) Failed to access server via SSH after 12 attempts","commit_id":"50f09d26d3500e835b558393782f8636f81ab372"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"40d6945a3bd5b61b12f2f2caddb4f9a239b0764c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"a07f0ee1_ee0cdd7a","updated":"2024-07-22 17:08:16.000000000","message":"recheck cephadm","commit_id":"50f09d26d3500e835b558393782f8636f81ab372"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"31cd618b8358cf0715e32b011a4d1c5ae900678e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"9166c53c_b9397bac","updated":"2024-07-29 10:08:14.000000000","message":"recheck kolla ansible debian ironic fails with critical error in placement-api: 2024-07-22 18:00:15.880 21 CRITICAL keystonemiddleware.auth_token [req-33b859da-fef5-4a08-b7f1-1e663525b8e8 req-1766d60e-7e1f-41b4-9d83-115673321bac - - - - - -] Unable to validate token: Identity server rejected authorization necessary to fetch token data: keystonemiddleware.auth_token._exceptions.ServiceError: Identity server rejected authorization necessary to fetch token data","commit_id":"50f09d26d3500e835b558393782f8636f81ab372"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"190207a117480d307d325c7668da0851d535068f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":25,"id":"28ecb982_9d08d38b","updated":"2024-08-22 07:06:36.000000000","message":"And I believe this breaks users that supply a custom name for the keyring","commit_id":"0b837d46b790e5e69e411547ec98c12ee447c394"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"190207a117480d307d325c7668da0851d535068f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"92b336f0_406f86a8","updated":"2024-08-22 07:06:36.000000000","message":"And I believe this breaks users that supply a custom name for the keyrings","commit_id":"0b837d46b790e5e69e411547ec98c12ee447c394"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cc1918c289978bf8a9d06c9bbe5f53a678e0071d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":25,"id":"3bf3ff24_6c23fe18","in_reply_to":"28ecb982_9d08d38b","updated":"2024-08-22 10:01:42.000000000","message":"By making this statement, you\u0027re contradicting yourself because the patch that broke the users https://review.opendev.org/c/openstack/kolla-ansible/+/798851 was also merged in past. To be fair, yes, in that case, a reno was written specifying that users who were using a different value for the user should take note of this.\n\nSo if we\u0027re being fair, it should hold that if something similar or the same was merged before, there\u0027s no reason to make excuses for it now.","commit_id":"0b837d46b790e5e69e411547ec98c12ee447c394"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"667f22b7b8fc003b1d089e762ed3e0e8a144de34","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":25,"id":"c0f10e29_3693d041","in_reply_to":"3bf3ff24_6c23fe18","updated":"2024-08-22 10:05:38.000000000","message":"So update the reno.","commit_id":"0b837d46b790e5e69e411547ec98c12ee447c394"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5f9a14a37f20302c221b78f036fbb612f0315019","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"3a68f04e_fcdfc58a","in_reply_to":"c0f10e29_3693d041","updated":"2024-09-30 20:33:31.000000000","message":"Commit message updated, reno updated.","commit_id":"0b837d46b790e5e69e411547ec98c12ee447c394"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d3273a24b73fcf7871333908304aa85112ab8858","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"276f71c3_6903fdbe","updated":"2024-11-25 10:15:14.000000000","message":"I think this is now really fine, good documentation imho, users who read the release notes and have differing keyring names should not be surprised.\n\ncephadm tests passing as well.","commit_id":"e5f0e24d222efa45ab419f1f0b33c9d12aa5de2f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ae091f1089722afe29c8b7dc25770443469605ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"fb0c07d8_724f0e26","updated":"2024-11-14 09:14:14.000000000","message":"ceph passing","commit_id":"e5f0e24d222efa45ab419f1f0b33c9d12aa5de2f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1533784570526e7c85cc7a519c9c2fa4f2e0a76e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"c64be2e3_ea28a6a8","updated":"2024-11-08 16:38:34.000000000","message":"recheck need fresh logs to analyze cephadm upgrade failures (logs vanished after 30 days)","commit_id":"e5f0e24d222efa45ab419f1f0b33c9d12aa5de2f"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"90ff03ecf963cd5594b5b6465d1703a05bd50654","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"d4744635_c376c36a","updated":"2025-03-06 11:44:53.000000000","message":"We ran into issue on Caracal, where config for two Ceph backends was generated with the same pool name - caused by the rbd_pool not used from backends dictionary:\nhttps://opendev.org/openstack/kolla-ansible/src/branch/stable/2024.1/ansible/roles/cinder/templates/cinder.conf.j2#L153\n\nThis was reworked in this change - shouldn\u0027t we backport it? @sven_oss@posteo.de @mnasiadka@gmail.com @michal.arbet@ultimum.io","commit_id":"66534e9dc5b9248bea962a3e1e1ed20e5c2535b5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6798af2be19a74effafe8ca55c0c4cebf11c9a27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"fa0b9224_a9c5bf3d","updated":"2024-11-25 14:07:35.000000000","message":"recheck podman failed","commit_id":"66534e9dc5b9248bea962a3e1e1ed20e5c2535b5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"73bf340a41713ec4357e79cca43d1bce77fef86c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":27,"id":"741accb7_9946349d","in_reply_to":"d4744635_c376c36a","updated":"2025-03-06 15:19:49.000000000","message":"Are you sure it’s backwards compatible? doesn’t look like it is","commit_id":"66534e9dc5b9248bea962a3e1e1ed20e5c2535b5"}],"ansible/roles/cinder/tasks/external_ceph.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"64c6f3c3234cdcda589aa87249b644c71fd2d073","unresolved":true,"context_lines":[{"line_number":65,"context_line":"  become: true"},{"line_number":66,"context_line":"  register: cinder_backup_ceph_keyring"},{"line_number":67,"context_line":"  with_items:"},{"line_number":68,"context_line":"    - \"{{ cinder_backup_ceph_backend.cluster }}.{{ ceph_cinder_keyring }}\""},{"line_number":69,"context_line":"    - \"{{ cinder_backup_ceph_backend.cluster }}.{{ ceph_cinder_backup_keyring }}\""},{"line_number":70,"context_line":"  when:"},{"line_number":71,"context_line":"    - external_ceph_cephx_enabled | bool"},{"line_number":72,"context_line":"    - inventory_hostname in groups[\u0027cinder-backup\u0027]"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"708c84b9_ba49d686","line":69,"range":{"start_line":68,"start_character":0,"end_line":69,"end_character":81},"updated":"2024-06-19 17:25:40.000000000","message":"this fails with:\n\n```\nTASK [cinder : Copy over Ceph keyring files for cinder-backup] *****************\n\ntask path: /home/zuul/kolla-ansible-venv/share/kolla-ansible/ansible/roles/cinder/tasks/external_ceph.yml:60\n\nMonday 17 June 2024  15:26:21 +0000 (0:00:01.528)       0:12:21.827 *********** \n\nfatal: [primary]: FAILED! \u003d\u003e {\n\n    \"msg\": \"\u0027ceph_cinder_keyring\u0027 is undefined. \u0027ceph_cinder_keyring\u0027 is undefined\"\n```\n\nin kolla-ansible-rocky9-cephadm (non-voting)\n\nhttps://zuul.opendev.org/t/openstack/build/72ac1e06582b4febbbf2fc6e6b66148b/log/primary/logs/ansible/deploy","commit_id":"0b0de0091b6628e628514b537ed7ff34a8909a93"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c88c53bc29209532d6b626152b87026d10a7b7d9","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  become: true"},{"line_number":66,"context_line":"  register: cinder_backup_ceph_keyring"},{"line_number":67,"context_line":"  with_items:"},{"line_number":68,"context_line":"    - \"{{ cinder_backup_ceph_backend.cluster }}.{{ ceph_cinder_keyring }}\""},{"line_number":69,"context_line":"    - \"{{ cinder_backup_ceph_backend.cluster }}.{{ ceph_cinder_backup_keyring }}\""},{"line_number":70,"context_line":"  when:"},{"line_number":71,"context_line":"    - external_ceph_cephx_enabled | bool"},{"line_number":72,"context_line":"    - inventory_hostname in groups[\u0027cinder-backup\u0027]"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"580b8d00_fe44a964","line":69,"range":{"start_line":68,"start_character":0,"end_line":69,"end_character":81},"in_reply_to":"708c84b9_ba49d686","updated":"2024-07-16 15:34:12.000000000","message":"Done","commit_id":"0b0de0091b6628e628514b537ed7ff34a8909a93"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6c06211828c9a1a708559620f18cb1d717b04d8d","unresolved":true,"context_lines":[{"line_number":67,"context_line":"  become: true"},{"line_number":68,"context_line":"  with_items:"},{"line_number":69,"context_line":"    - \"{{ cinder_ceph_backends }}\""},{"line_number":70,"context_line":"    - - \"{{ cinder_backup_ceph_backend }}\""},{"line_number":71,"context_line":"  when:"},{"line_number":72,"context_line":"    - external_ceph_cephx_enabled | bool"},{"line_number":73,"context_line":"    - inventory_hostname in groups[\u0027cinder-backup\u0027]"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"8acf0b79_604e1aa9","line":70,"range":{"start_line":70,"start_character":6,"end_line":70,"end_character":8},"updated":"2024-07-16 16:17:47.000000000","message":"extra dash","commit_id":"724bdae44f5a740180fbb04182f09cde8325e17f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"de25776847a9a33b69ecae20eb3d758f318fcf25","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  become: true"},{"line_number":68,"context_line":"  with_items:"},{"line_number":69,"context_line":"    - \"{{ cinder_ceph_backends }}\""},{"line_number":70,"context_line":"    - - \"{{ cinder_backup_ceph_backend }}\""},{"line_number":71,"context_line":"  when:"},{"line_number":72,"context_line":"    - external_ceph_cephx_enabled | bool"},{"line_number":73,"context_line":"    - inventory_hostname in groups[\u0027cinder-backup\u0027]"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"e60396cc_ba3b5a9a","line":70,"range":{"start_line":70,"start_character":6,"end_line":70,"end_character":8},"in_reply_to":"8acf0b79_604e1aa9","updated":"2024-07-16 20:01:53.000000000","message":"Done","commit_id":"724bdae44f5a740180fbb04182f09cde8325e17f"}],"ansible/roles/cinder/templates/cinder.conf.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"26766c54edf31febe81706a38c0a67228f8865ca","unresolved":true,"context_lines":[{"line_number":21,"context_line":"glance_ca_certificates_file \u003d {{ openstack_cacert }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% if cinder_enabled_backends %}"},{"line_number":24,"context_line":"{% if service_name \u003d\u003d \u0027cinder-volume\u0027 %}"},{"line_number":25,"context_line":"enabled_backends \u003d {{ cinder_enabled_backends|map(attribute\u003d\u0027name\u0027)|join(\u0027,\u0027) }}"},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"5806651c_9fcec615","line":24,"updated":"2024-07-17 13:28:12.000000000","message":"if cinder_enabled_backends and service_name \u003d\u003d \u0027cinder-volume\u0027 ?","commit_id":"724bdae44f5a740180fbb04182f09cde8325e17f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"db5e20d0e0f1f491a5988df2d48dc1d053350d04","unresolved":true,"context_lines":[{"line_number":21,"context_line":"glance_ca_certificates_file \u003d {{ openstack_cacert }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% if cinder_enabled_backends %}"},{"line_number":24,"context_line":"{% if service_name \u003d\u003d \u0027cinder-volume\u0027 %}"},{"line_number":25,"context_line":"enabled_backends \u003d {{ cinder_enabled_backends|map(attribute\u003d\u0027name\u0027)|join(\u0027,\u0027) }}"},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"e15244a2_4531803d","line":24,"in_reply_to":"5806651c_9fcec615","updated":"2024-07-17 13:31:40.000000000","message":"yes, because this is configuration for cinder-volume. Cinder-scheduler and cinder-api is not reading this option. So, in this case it\u0027s better to render only what\u0027s really needed to avoid restart services which don\u0027t need to be restarted.","commit_id":"724bdae44f5a740180fbb04182f09cde8325e17f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"35c7c2df68ac5e43d1f556c5f565de80399dcc61","unresolved":true,"context_lines":[{"line_number":21,"context_line":"glance_ca_certificates_file \u003d {{ openstack_cacert }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% if cinder_enabled_backends %}"},{"line_number":24,"context_line":"{% if service_name \u003d\u003d \u0027cinder-volume\u0027 %}"},{"line_number":25,"context_line":"enabled_backends \u003d {{ cinder_enabled_backends|map(attribute\u003d\u0027name\u0027)|join(\u0027,\u0027) }}"},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"c4d8b2ae_92e0e196","line":24,"in_reply_to":"9b0ca915_d220af4d","updated":"2024-07-18 12:58:55.000000000","message":"I only meant having it in one line ;-)","commit_id":"724bdae44f5a740180fbb04182f09cde8325e17f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2f395571a2cf171c2b48b0c0c19b996269adcdb7","unresolved":true,"context_lines":[{"line_number":21,"context_line":"glance_ca_certificates_file \u003d {{ openstack_cacert }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% if cinder_enabled_backends %}"},{"line_number":24,"context_line":"{% if service_name \u003d\u003d \u0027cinder-volume\u0027 %}"},{"line_number":25,"context_line":"enabled_backends \u003d {{ cinder_enabled_backends|map(attribute\u003d\u0027name\u0027)|join(\u0027,\u0027) }}"},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9b0ca915_d220af4d","line":24,"in_reply_to":"acc86cd0_0b201701","updated":"2024-07-18 12:51:23.000000000","message":"Of course cinder-backup also don\u0027t need to ... I have it deployed on test...","commit_id":"724bdae44f5a740180fbb04182f09cde8325e17f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"06430c81e716754fa01623508bf9dace74d1cdef","unresolved":false,"context_lines":[{"line_number":21,"context_line":"glance_ca_certificates_file \u003d {{ openstack_cacert }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% if cinder_enabled_backends %}"},{"line_number":24,"context_line":"{% if service_name \u003d\u003d \u0027cinder-volume\u0027 %}"},{"line_number":25,"context_line":"enabled_backends \u003d {{ cinder_enabled_backends|map(attribute\u003d\u0027name\u0027)|join(\u0027,\u0027) }}"},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"20e96300_d30a8465","line":24,"in_reply_to":"c4d8b2ae_92e0e196","updated":"2024-07-18 13:00:56.000000000","message":"Done","commit_id":"724bdae44f5a740180fbb04182f09cde8325e17f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"09fc3ff945ab96489365253e14be2ef5ff0c2f33","unresolved":true,"context_lines":[{"line_number":21,"context_line":"glance_ca_certificates_file \u003d {{ openstack_cacert }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% if cinder_enabled_backends %}"},{"line_number":24,"context_line":"{% if service_name \u003d\u003d \u0027cinder-volume\u0027 %}"},{"line_number":25,"context_line":"enabled_backends \u003d {{ cinder_enabled_backends|map(attribute\u003d\u0027name\u0027)|join(\u0027,\u0027) }}"},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"acc86cd0_0b201701","line":24,"in_reply_to":"e15244a2_4531803d","updated":"2024-07-17 15:57:25.000000000","message":"what about cinder-backup though? But I\u0027m actually not sure if it needs access to all enabled backends for the backup, or if access to the backup_ceph_pool is sufficient.\n\nEven after reading https://docs.openstack.org/cinder/latest/configuration/block-storage/backup/ceph-backup-driver.html I\u0027m not really sure. I guess it should not be needed but I don\u0027t use cinder-backup myself, so just adding this here for posterity.","commit_id":"724bdae44f5a740180fbb04182f09cde8325e17f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"26766c54edf31febe81706a38c0a67228f8865ca","unresolved":true,"context_lines":[{"line_number":148,"context_line":"{% endif %}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"{% if cinder_backend_ceph | bool %}"},{"line_number":151,"context_line":"{% if service_name \u003d\u003d \u0027cinder-volume\u0027 %}"},{"line_number":152,"context_line":"{% for backend in cinder_ceph_backends %}"},{"line_number":153,"context_line":"[{{ backend.name }}]"},{"line_number":154,"context_line":"volume_driver \u003d cinder.volume.drivers.rbd.RBDDriver"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"0b42ac7d_61daac1c","line":151,"updated":"2024-07-17 13:28:12.000000000","message":"ditto?","commit_id":"724bdae44f5a740180fbb04182f09cde8325e17f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"db5e20d0e0f1f491a5988df2d48dc1d053350d04","unresolved":true,"context_lines":[{"line_number":148,"context_line":"{% endif %}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"{% if cinder_backend_ceph | bool %}"},{"line_number":151,"context_line":"{% if service_name \u003d\u003d \u0027cinder-volume\u0027 %}"},{"line_number":152,"context_line":"{% for backend in cinder_ceph_backends %}"},{"line_number":153,"context_line":"[{{ backend.name }}]"},{"line_number":154,"context_line":"volume_driver \u003d cinder.volume.drivers.rbd.RBDDriver"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"52702618_9a27d6c0","line":151,"in_reply_to":"0b42ac7d_61daac1c","updated":"2024-07-17 13:31:40.000000000","message":"Ditto as above.","commit_id":"724bdae44f5a740180fbb04182f09cde8325e17f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"06430c81e716754fa01623508bf9dace74d1cdef","unresolved":false,"context_lines":[{"line_number":148,"context_line":"{% endif %}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"{% if cinder_backend_ceph | bool %}"},{"line_number":151,"context_line":"{% if service_name \u003d\u003d \u0027cinder-volume\u0027 %}"},{"line_number":152,"context_line":"{% for backend in cinder_ceph_backends %}"},{"line_number":153,"context_line":"[{{ backend.name }}]"},{"line_number":154,"context_line":"volume_driver \u003d cinder.volume.drivers.rbd.RBDDriver"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"cd611f29_14f1a395","line":151,"in_reply_to":"52702618_9a27d6c0","updated":"2024-07-18 13:00:56.000000000","message":"Done","commit_id":"724bdae44f5a740180fbb04182f09cde8325e17f"}],"releasenotes/notes/ceph-external-refactor-d29815a12c223152.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7fc020cd96ad11b3b33881db2fba4379e5789bc2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Refactores ceph-external so that it is now possible to use different users, different Ceph configurations,"},{"line_number":5,"context_line":"    different pools and similar options. See the `External ceph guide"},{"line_number":6,"context_line":"    \u003chttps://docs.openstack.org/kolla-ansible/latest/reference/storage/external-ceph-guide.html\u003e`__"},{"line_number":7,"context_line":"    for details."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6134d71d_e29467f1","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"updated":"2024-07-18 14:30:25.000000000","message":"line to long, linter complains :)\nhttps://zuul.opendev.org/t/openstack/build/bb6e2250aae348e6a6633c96972e7662","commit_id":"f3bd958320ed68d614a4b9efb2e8a3345415ac04"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1db7e6209de8a3afc43c99a5909fbca031095d24","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Refactores ceph-external so that it is now possible to use different users, different Ceph configurations,"},{"line_number":5,"context_line":"    different pools and similar options. See the `External ceph guide"},{"line_number":6,"context_line":"    \u003chttps://docs.openstack.org/kolla-ansible/latest/reference/storage/external-ceph-guide.html\u003e`__"},{"line_number":7,"context_line":"    for details."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"cdc2bbfc_8dd2da53","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"in_reply_to":"6134d71d_e29467f1","updated":"2024-07-19 07:36:25.000000000","message":"Done","commit_id":"f3bd958320ed68d614a4b9efb2e8a3345415ac04"}]}