)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a511df197fdf6a7e655079a0ed116bbe03c75812","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1cc62e4c_fb0e776a","updated":"2024-02-01 06:15:25.000000000","message":"recheck seems not related","commit_id":"a18a3c86377072ac5cd91a1c98cc655b5329de5e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"163e4a1ccdadc8b3e2fbffd2094850482c4f617d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8eaf2675_402901e5","updated":"2024-06-20 17:59:55.000000000","message":"Do you plan for this to get backported? Please set the Backport-Candidate flag accordingly. Not sure if worth a bug-report and/or release note.\n\n-1 just for the missing things in the commit message, a sentence or two explaining to the unintiated why this change is needed might be good.","commit_id":"557b15a8f64841fadeec6f6dfb488bcfc8d65a24"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c8a2c08f3857e6a0a95d0228ec718f60372bda48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fa1b1c11_68897e30","updated":"2024-06-17 11:15:38.000000000","message":"Hi, can we merge this ?","commit_id":"557b15a8f64841fadeec6f6dfb488bcfc8d65a24"}],"ansible/roles/cinder/tasks/external_ceph.yml":[{"author":{"_account_id":35931,"name":"Robert Breker","display_name":"Robert Breker","email":"mail@robertbreker.de","username":"rbreker"},"change_message_id":"7c8d310db4db7b8bec69a7e534db9bd5a5c7df83","unresolved":true,"context_lines":[{"line_number":67,"context_line":"  become: true"},{"line_number":68,"context_line":"  with_items:"},{"line_number":69,"context_line":"    - \"{{ cinder_ceph_backends }}\""},{"line_number":70,"context_line":"    - - \"{{ cinder_backup_ceph_backend }}\""},{"line_number":71,"context_line":"  when:"},{"line_number":72,"context_line":"    - external_ceph_cephx_enabled | bool"},{"line_number":73,"context_line":"    - inventory_hostname in groups[\u0027cinder-backup\u0027]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"55e76d59_fdb899ff","line":70,"updated":"2024-04-15 08:05:29.000000000","message":"Typo?","commit_id":"557b15a8f64841fadeec6f6dfb488bcfc8d65a24"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"39f8f4fa14154e065aaa23b99853f8789436dfbf","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  become: true"},{"line_number":68,"context_line":"  with_items:"},{"line_number":69,"context_line":"    - \"{{ cinder_ceph_backends }}\""},{"line_number":70,"context_line":"    - - \"{{ cinder_backup_ceph_backend }}\""},{"line_number":71,"context_line":"  when:"},{"line_number":72,"context_line":"    - external_ceph_cephx_enabled | bool"},{"line_number":73,"context_line":"    - inventory_hostname in groups[\u0027cinder-backup\u0027]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"8b4c2f71_056fff2d","line":70,"in_reply_to":"4b1b97e3_ae1c943f","updated":"2024-07-16 15:30:23.000000000","message":"You was right, that dash is not needed, fixed in previous commit as I squashed this commit into previous one as it\u0027s actually refactor.","commit_id":"557b15a8f64841fadeec6f6dfb488bcfc8d65a24"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"76a25f0f40e9bc3e11c8f94d5bd595f28f08b982","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  become: true"},{"line_number":68,"context_line":"  with_items:"},{"line_number":69,"context_line":"    - \"{{ cinder_ceph_backends }}\""},{"line_number":70,"context_line":"    - - \"{{ cinder_backup_ceph_backend }}\""},{"line_number":71,"context_line":"  when:"},{"line_number":72,"context_line":"    - external_ceph_cephx_enabled | bool"},{"line_number":73,"context_line":"    - inventory_hostname in groups[\u0027cinder-backup\u0027]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"eb54206e_3dd5d162","line":70,"in_reply_to":"4e142476_1dac2c21","updated":"2024-05-14 10:15:55.000000000","message":"Nope, it\u0027s not","commit_id":"557b15a8f64841fadeec6f6dfb488bcfc8d65a24"},{"author":{"_account_id":35931,"name":"Robert Breker","display_name":"Robert Breker","email":"mail@robertbreker.de","username":"rbreker"},"change_message_id":"d400e7503d508db5ff71e98103d058eb508a36c1","unresolved":true,"context_lines":[{"line_number":67,"context_line":"  become: true"},{"line_number":68,"context_line":"  with_items:"},{"line_number":69,"context_line":"    - \"{{ cinder_ceph_backends }}\""},{"line_number":70,"context_line":"    - - \"{{ cinder_backup_ceph_backend }}\""},{"line_number":71,"context_line":"  when:"},{"line_number":72,"context_line":"    - external_ceph_cephx_enabled | bool"},{"line_number":73,"context_line":"    - inventory_hostname in groups[\u0027cinder-backup\u0027]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4e142476_1dac2c21","line":70,"in_reply_to":"55e76d59_fdb899ff","updated":"2024-04-15 08:10:01.000000000","message":"Double dash\n\\- - \"{{ cinder_backup_ceph_backend }}\"","commit_id":"557b15a8f64841fadeec6f6dfb488bcfc8d65a24"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ab34b22fb623f418b638b4be9a6adb1fcbfc1a7d","unresolved":true,"context_lines":[{"line_number":67,"context_line":"  become: true"},{"line_number":68,"context_line":"  with_items:"},{"line_number":69,"context_line":"    - \"{{ cinder_ceph_backends }}\""},{"line_number":70,"context_line":"    - - \"{{ cinder_backup_ceph_backend }}\""},{"line_number":71,"context_line":"  when:"},{"line_number":72,"context_line":"    - external_ceph_cephx_enabled | bool"},{"line_number":73,"context_line":"    - inventory_hostname in groups[\u0027cinder-backup\u0027]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4b1b97e3_ae1c943f","line":70,"in_reply_to":"c2b37e2f_18defdda","updated":"2024-06-20 17:55:50.000000000","message":"IIUC the idea is to copy the list concatenation from L40. Looking at the ansible docs, this is valid, but not actually necessary, since `with_items` does flatten the first level of it\u0027s arguments. So\n\n```\n  with_items:\n    - [ a, b, c ]\n    - [ d ]\n```\n\nis the same as\n\n```\n  with_items:\n    - [ a, b, c ]\n    - d\n```\n\nis the same as\n\n```\n  with_items:\n    - a\n    - b\n    - c\n    - d\n```\n\nI\u0027m not sure which of the first two options is less confusing though. The most clear variant would probably be to setfact a new variable with the concatenated list first and use that in both places.","commit_id":"557b15a8f64841fadeec6f6dfb488bcfc8d65a24"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ae0288f45d7e79c8fab5cc2dce998251e2242fde","unresolved":true,"context_lines":[{"line_number":67,"context_line":"  become: true"},{"line_number":68,"context_line":"  with_items:"},{"line_number":69,"context_line":"    - \"{{ cinder_ceph_backends }}\""},{"line_number":70,"context_line":"    - - \"{{ cinder_backup_ceph_backend }}\""},{"line_number":71,"context_line":"  when:"},{"line_number":72,"context_line":"    - external_ceph_cephx_enabled | bool"},{"line_number":73,"context_line":"    - inventory_hostname in groups[\u0027cinder-backup\u0027]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c2b37e2f_18defdda","line":70,"in_reply_to":"eb54206e_3dd5d162","updated":"2024-06-20 15:56:48.000000000","message":"I\u0027m pretty sure you have a stray dash here?\n\n```suggestion\n    - \"{{ cinder_backup_ceph_backend }}\"\n```","commit_id":"557b15a8f64841fadeec6f6dfb488bcfc8d65a24"}],"ansible/roles/cinder/templates/cinder.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"163e4a1ccdadc8b3e2fbffd2094850482c4f617d","unresolved":true,"context_lines":[{"line_number":21,"context_line":"glance_ca_certificates_file \u003d {{ openstack_cacert }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% if cinder_enabled_backends %}"},{"line_number":24,"context_line":"{% if service_name \u003d\u003d \u0027cinder-volume\u0027 %}"},{"line_number":25,"context_line":"enabled_backends \u003d {{ cinder_enabled_backends|map(attribute\u003d\u0027name\u0027)|join(\u0027,\u0027) }}"},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"553e63da_5b7134f8","line":24,"updated":"2024-06-20 17:59:55.000000000","message":"This change doesn\u0027t match the title of the commit message, at least it should get mentioned and explained there?","commit_id":"557b15a8f64841fadeec6f6dfb488bcfc8d65a24"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"39f8f4fa14154e065aaa23b99853f8789436dfbf","unresolved":false,"context_lines":[{"line_number":21,"context_line":"glance_ca_certificates_file \u003d {{ openstack_cacert }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% if cinder_enabled_backends %}"},{"line_number":24,"context_line":"{% if service_name \u003d\u003d \u0027cinder-volume\u0027 %}"},{"line_number":25,"context_line":"enabled_backends \u003d {{ cinder_enabled_backends|map(attribute\u003d\u0027name\u0027)|join(\u0027,\u0027) }}"},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"235e3976_b6ec415b","line":24,"in_reply_to":"553e63da_5b7134f8","updated":"2024-07-16 15:30:23.000000000","message":"As this is actually part of refactor, I squashed into previous commit and reuploaded for review. I will abandon this one.","commit_id":"557b15a8f64841fadeec6f6dfb488bcfc8d65a24"}]}