)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d5a9d7f48d51304f8900901987bb226206da08a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e45870d4_27fb7cdf","updated":"2024-06-27 16:04:34.000000000","message":"bash used for test ...we decided to remove bashes ...not add another one","commit_id":"f0a11053b005bc151d70814a33b9b93d8a68c065"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b2c65bb7943c6cbb292e64f7212c56b1b9e21e6d","unresolved":true,"context_lines":[{"line_number":886,"context_line":"enable_placement: \"{{ enable_nova | bool or enable_zun | bool }}\""},{"line_number":887,"context_line":"enable_prometheus: \"no\""},{"line_number":888,"context_line":"enable_proxysql: \"no\""},{"line_number":889,"context_line":"enable_redis: \"{{ enable_openstack_core }}\""},{"line_number":890,"context_line":"enable_sahara: \"no\""},{"line_number":891,"context_line":"enable_senlin: \"no\""},{"line_number":892,"context_line":"enable_skyline: \"no\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e351ec6d_60f9f09c","line":889,"updated":"2024-02-02 09:01:15.000000000","message":"Unsure about this - anyone using etcd as a coordination backend will get a surprise","commit_id":"f0a11053b005bc151d70814a33b9b93d8a68c065"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"efc2236e86666c5fcaf53842c2ea95a4bca2d1fb","unresolved":true,"context_lines":[{"line_number":886,"context_line":"enable_placement: \"{{ enable_nova | bool or enable_zun | bool }}\""},{"line_number":887,"context_line":"enable_prometheus: \"no\""},{"line_number":888,"context_line":"enable_proxysql: \"no\""},{"line_number":889,"context_line":"enable_redis: \"{{ enable_openstack_core }}\""},{"line_number":890,"context_line":"enable_sahara: \"no\""},{"line_number":891,"context_line":"enable_senlin: \"no\""},{"line_number":892,"context_line":"enable_skyline: \"no\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b5252d42_f9c2fc70","line":889,"in_reply_to":"043eea92_8386e4b9","updated":"2024-03-19 15:51:47.000000000","message":"Well, the precheck is already there - but if every deploy will hit that precheck - then probably it\u0027s not the best idea.","commit_id":"f0a11053b005bc151d70814a33b9b93d8a68c065"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"05196e2d5279c5b5287c31d16b8c704bcfec8503","unresolved":true,"context_lines":[{"line_number":886,"context_line":"enable_placement: \"{{ enable_nova | bool or enable_zun | bool }}\""},{"line_number":887,"context_line":"enable_prometheus: \"no\""},{"line_number":888,"context_line":"enable_proxysql: \"no\""},{"line_number":889,"context_line":"enable_redis: \"{{ enable_openstack_core }}\""},{"line_number":890,"context_line":"enable_sahara: \"no\""},{"line_number":891,"context_line":"enable_senlin: \"no\""},{"line_number":892,"context_line":"enable_skyline: \"no\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"152eeed7_c71e11ea","line":889,"in_reply_to":"20087044_a394333b","updated":"2024-03-20 12:07:26.000000000","message":"I don\u0027t think you can choose - it seems jobboard supports only Redis and Zookeeper https://opendev.org/openstack/octavia/commit/9c13499d216ef6638a08ba4158575b182084b64f","commit_id":"f0a11053b005bc151d70814a33b9b93d8a68c065"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"42dcef81909257063c177c27f7b0dd627a4742c4","unresolved":true,"context_lines":[{"line_number":886,"context_line":"enable_placement: \"{{ enable_nova | bool or enable_zun | bool }}\""},{"line_number":887,"context_line":"enable_prometheus: \"no\""},{"line_number":888,"context_line":"enable_proxysql: \"no\""},{"line_number":889,"context_line":"enable_redis: \"{{ enable_openstack_core }}\""},{"line_number":890,"context_line":"enable_sahara: \"no\""},{"line_number":891,"context_line":"enable_senlin: \"no\""},{"line_number":892,"context_line":"enable_skyline: \"no\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"20087044_a394333b","line":889,"in_reply_to":"b5252d42_f9c2fc70","updated":"2024-03-20 11:18:35.000000000","message":"It would need to be documented in the quickstart that you need to decide which coordination backend to use.","commit_id":"f0a11053b005bc151d70814a33b9b93d8a68c065"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2064a9460e57423f5a9cf69b2335754d8e1d5e23","unresolved":true,"context_lines":[{"line_number":886,"context_line":"enable_placement: \"{{ enable_nova | bool or enable_zun | bool }}\""},{"line_number":887,"context_line":"enable_prometheus: \"no\""},{"line_number":888,"context_line":"enable_proxysql: \"no\""},{"line_number":889,"context_line":"enable_redis: \"{{ enable_openstack_core }}\""},{"line_number":890,"context_line":"enable_sahara: \"no\""},{"line_number":891,"context_line":"enable_senlin: \"no\""},{"line_number":892,"context_line":"enable_skyline: \"no\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"043eea92_8386e4b9","line":889,"in_reply_to":"c2145aa9_411f693c","updated":"2024-03-19 14:08:14.000000000","message":"Currently octavia users already need to explicitly enable redis.\n\nI think it would be better to have a precheck in octavia that fails if redis is disabled. Then if a user uses etcd for coordination they can plan a migration.","commit_id":"f0a11053b005bc151d70814a33b9b93d8a68c065"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d71d96f9374d78f36602988ee624502a1353daa3","unresolved":true,"context_lines":[{"line_number":886,"context_line":"enable_placement: \"{{ enable_nova | bool or enable_zun | bool }}\""},{"line_number":887,"context_line":"enable_prometheus: \"no\""},{"line_number":888,"context_line":"enable_proxysql: \"no\""},{"line_number":889,"context_line":"enable_redis: \"{{ enable_openstack_core }}\""},{"line_number":890,"context_line":"enable_sahara: \"no\""},{"line_number":891,"context_line":"enable_senlin: \"no\""},{"line_number":892,"context_line":"enable_skyline: \"no\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c2145aa9_411f693c","line":889,"in_reply_to":"e351ec6d_60f9f09c","updated":"2024-02-02 09:02:50.000000000","message":"Well, Octavia won\u0027t work without redis - so what do you propose?","commit_id":"f0a11053b005bc151d70814a33b9b93d8a68c065"}],"tests/test-octavia.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2064a9460e57423f5a9cf69b2335754d8e1d5e23","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Test deployment of octavia."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"277d30fc_36fc91cb","side":"PARENT","line":1,"updated":"2024-03-19 14:08:14.000000000","message":"I don\u0027t think it hurts to keep this separate","commit_id":"c9737d2446715be96e57f70480189673d12bdb4c"}]}