)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fcd60f58cbf8dbbf937f358467bf11a4a2ca43f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"93526a14_63c463d7","updated":"2024-05-14 08:33:07.000000000","message":"some typos, the rest LGTM","commit_id":"9966f7fb45dd42df8cdb51792b751dd882f037a1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bcd3304243b9f73f4c5a5875477341825629ea30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"3902b120_67ebc38b","updated":"2024-07-10 15:03:00.000000000","message":"please adjust the readme to the current code. LGTM :)","commit_id":"851c8919bcac62750028f075a530a14c80c9cfdb"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"a77126768164843a2a90ade965b18372b9cd2d4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"2d7222fe_2527f248","updated":"2024-07-16 10:55:41.000000000","message":"recheck","commit_id":"57b2f589a4c54f74498478714d409bbd8fc3b0c6"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0d07bc17b28c69f91d5a49cf8d20994a5c8813f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"79d5909a_f91dabfa","updated":"2024-11-27 13:43:51.000000000","message":"recheck get fresh CI results after almost 30 days.","commit_id":"3e7fb72da26b21a3333fc2a42240d0f3e3c425bf"}],"ansible/roles/keystone/defaults/main.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8367fe03163364cb29b28e031cab63469fb0df6c","unresolved":true,"context_lines":[{"line_number":238,"context_line":"####################"},{"line_number":239,"context_line":"# Cache"},{"line_number":240,"context_line":"####################"},{"line_number":241,"context_line":"keystone_cache_enabled: \"yes\""},{"line_number":242,"context_line":"keystone_cache_backend: \"oslo_cache.memcache_pool\""},{"line_number":243,"context_line":"keystone_cache_memcache_servers: \"{{ memcache_servers if oslo_cache_backend \u003d\u003d \u0027oslo_cache.memcache_pool\u0027 else \u0027\u0027 }}\""},{"line_number":244,"context_line":"keystone_cache_redis_port: \"{{ redis_sentinel_tls_port if redis_enable_tls | bool else redis_sentinel_port }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"66799608_dc1d378c","line":241,"range":{"start_line":241,"start_character":0,"end_line":241,"end_character":2},"updated":"2024-02-22 16:43:36.000000000","message":"I\u0027m not sure we want to enable caching in keystone by default as it might have security implications.\n\nAlso there are some implementation notes here, which suggest that it is best practice to enable caching for each keystone manager separately:\n\nhttps://docs.openstack.org/keystone/latest/contributor/caching-layer.html","commit_id":"a5046ac42331f133e8f796c387dcc41725f2727e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"c62297df7c38c6e6d2e9a555810eb50dbfe395ae","unresolved":true,"context_lines":[{"line_number":238,"context_line":"####################"},{"line_number":239,"context_line":"# Cache"},{"line_number":240,"context_line":"####################"},{"line_number":241,"context_line":"keystone_cache_enabled: \"yes\""},{"line_number":242,"context_line":"keystone_cache_backend: \"oslo_cache.memcache_pool\""},{"line_number":243,"context_line":"keystone_cache_memcache_servers: \"{{ memcache_servers if oslo_cache_backend \u003d\u003d \u0027oslo_cache.memcache_pool\u0027 else \u0027\u0027 }}\""},{"line_number":244,"context_line":"keystone_cache_redis_port: \"{{ redis_sentinel_tls_port if redis_enable_tls | bool else redis_sentinel_port }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bad4a37b_b3d6e878","line":241,"range":{"start_line":241,"start_character":0,"end_line":241,"end_character":2},"in_reply_to":"66799608_dc1d378c","updated":"2024-02-26 10:55:33.000000000","message":"I am not quite sure what you mean by this, but I found that in the config, there are options to disable the cache for each configuration section, e.g. [application_credential](https://docs.openstack.org/keystone/latest/configuration/config-options.html#application_credential.caching). This boolean is `true` by default, and has no effect if [cache.enabled](https://docs.openstack.org/keystone/latest/configuration/config-options.html#cache.enabled) is `false`. I added the options to change this for all keystone components we use. Made them `true` by default, we can go with false, but we need to mention this somewhere, because keystone default is `true`","commit_id":"a5046ac42331f133e8f796c387dcc41725f2727e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cb7b69a5fbb5018dff89c46a59fbda288fbdf859","unresolved":false,"context_lines":[{"line_number":238,"context_line":"####################"},{"line_number":239,"context_line":"# Cache"},{"line_number":240,"context_line":"####################"},{"line_number":241,"context_line":"keystone_cache_enabled: \"yes\""},{"line_number":242,"context_line":"keystone_cache_backend: \"oslo_cache.memcache_pool\""},{"line_number":243,"context_line":"keystone_cache_memcache_servers: \"{{ memcache_servers if oslo_cache_backend \u003d\u003d \u0027oslo_cache.memcache_pool\u0027 else \u0027\u0027 }}\""},{"line_number":244,"context_line":"keystone_cache_redis_port: \"{{ redis_sentinel_tls_port if redis_enable_tls | bool else redis_sentinel_port }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"63c3d74a_148c9a77","line":241,"range":{"start_line":241,"start_character":0,"end_line":241,"end_character":2},"in_reply_to":"bad4a37b_b3d6e878","updated":"2024-02-26 17:09:22.000000000","message":"ah, nevermind then! I thought the global default for caching in keystone was disabled. Seems I was wrong. (I could swear this was not enabled in the past by default, but maybe I misremember or it just changed sometime ago).\n\nThanks for correcting me.","commit_id":"a5046ac42331f133e8f796c387dcc41725f2727e"}],"ansible/roles/keystone/templates/keystone.conf.j2":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fcd60f58cbf8dbbf937f358467bf11a4a2ca43f3","unresolved":true,"context_lines":[{"line_number":25,"context_line":"[identity]"},{"line_number":26,"context_line":"domain_specific_drivers_enabled \u003d true"},{"line_number":27,"context_line":"domain_config_dir \u003d /etc/keystone/domains"},{"line_number":28,"context_line":"caching \u003d {{  \u0027True\u0027 if  keystone_cahce_enabled_identity | bool else \u0027False\u0027}}"},{"line_number":29,"context_line":"{% endif %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[token]"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"a0cac78a_6b6a901b","line":28,"range":{"start_line":28,"start_character":34,"end_line":28,"end_character":39},"updated":"2024-05-14 08:33:07.000000000","message":"typo: keystone_cache_enabled_identity","commit_id":"9966f7fb45dd42df8cdb51792b751dd882f037a1"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"fcf71103c47b08350254d56436e7471b8959cc89","unresolved":false,"context_lines":[{"line_number":25,"context_line":"[identity]"},{"line_number":26,"context_line":"domain_specific_drivers_enabled \u003d true"},{"line_number":27,"context_line":"domain_config_dir \u003d /etc/keystone/domains"},{"line_number":28,"context_line":"caching \u003d {{  \u0027True\u0027 if  keystone_cahce_enabled_identity | bool else \u0027False\u0027}}"},{"line_number":29,"context_line":"{% endif %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[token]"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"2c9689b0_01e8ff36","line":28,"range":{"start_line":28,"start_character":34,"end_line":28,"end_character":39},"in_reply_to":"a0cac78a_6b6a901b","updated":"2024-05-14 10:29:24.000000000","message":"Done","commit_id":"9966f7fb45dd42df8cdb51792b751dd882f037a1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fcd60f58cbf8dbbf937f358467bf11a4a2ca43f3","unresolved":true,"context_lines":[{"line_number":87,"context_line":"{% for dashboard in keystone_trusted_dashboards %}"},{"line_number":88,"context_line":"trusted_dashboard \u003d {{ dashboard }}"},{"line_number":89,"context_line":"{% endfor %}"},{"line_number":90,"context_line":"caching \u003d {{  \u0027True\u0027 if  keystone_cahce_enabled_federation | bool else \u0027False\u0027}}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"sso_callback_template \u003d /etc/keystone/sso_callback_template.html"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"daae2740_767acef7","line":90,"range":{"start_line":90,"start_character":34,"end_line":90,"end_character":39},"updated":"2024-05-14 08:33:07.000000000","message":"typo: \"cache\"","commit_id":"9966f7fb45dd42df8cdb51792b751dd882f037a1"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"fcf71103c47b08350254d56436e7471b8959cc89","unresolved":false,"context_lines":[{"line_number":87,"context_line":"{% for dashboard in keystone_trusted_dashboards %}"},{"line_number":88,"context_line":"trusted_dashboard \u003d {{ dashboard }}"},{"line_number":89,"context_line":"{% endfor %}"},{"line_number":90,"context_line":"caching \u003d {{  \u0027True\u0027 if  keystone_cahce_enabled_federation | bool else \u0027False\u0027}}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"sso_callback_template \u003d /etc/keystone/sso_callback_template.html"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"d5e80543_dae574c2","line":90,"range":{"start_line":90,"start_character":34,"end_line":90,"end_character":39},"in_reply_to":"daae2740_767acef7","updated":"2024-05-14 10:29:24.000000000","message":"Done","commit_id":"9966f7fb45dd42df8cdb51792b751dd882f037a1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"733f71577e0732323534ec85c628cdf4579405fc","unresolved":true,"context_lines":[{"line_number":102,"context_line":"enabled \u003d \"{{ \u0027True\u0027 if keystone_cache_enabled | bool else \u0027False\u0027 }}\""},{"line_number":103,"context_line":"backend \u003d {{ keystone_cache_backend }}"},{"line_number":104,"context_line":"{% if keystone_cache_backend \u003d\u003d \u0027dogpile.cache.redis_sentinel\u0027 %}"},{"line_number":105,"context_line":"redis_username \u003d default"},{"line_number":106,"context_line":"redis_password \u003d {{ redis_master_password }}"},{"line_number":107,"context_line":"redis_sentinels \u003d {{ keystone_cache_redis_sentinel_servers }}"},{"line_number":108,"context_line":"redis_sentinel_service_name \u003d kolla"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"e72c3096_6db5df8d","line":105,"range":{"start_line":105,"start_character":17,"end_line":105,"end_character":24},"updated":"2024-05-14 08:36:02.000000000","message":"please make the redis username configurable.","commit_id":"9966f7fb45dd42df8cdb51792b751dd882f037a1"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"fcf71103c47b08350254d56436e7471b8959cc89","unresolved":false,"context_lines":[{"line_number":102,"context_line":"enabled \u003d \"{{ \u0027True\u0027 if keystone_cache_enabled | bool else \u0027False\u0027 }}\""},{"line_number":103,"context_line":"backend \u003d {{ keystone_cache_backend }}"},{"line_number":104,"context_line":"{% if keystone_cache_backend \u003d\u003d \u0027dogpile.cache.redis_sentinel\u0027 %}"},{"line_number":105,"context_line":"redis_username \u003d default"},{"line_number":106,"context_line":"redis_password \u003d {{ redis_master_password }}"},{"line_number":107,"context_line":"redis_sentinels \u003d {{ keystone_cache_redis_sentinel_servers }}"},{"line_number":108,"context_line":"redis_sentinel_service_name \u003d kolla"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"08e95cbf_066645ef","line":105,"range":{"start_line":105,"start_character":17,"end_line":105,"end_character":24},"in_reply_to":"e72c3096_6db5df8d","updated":"2024-05-14 10:29:24.000000000","message":"Done","commit_id":"9966f7fb45dd42df8cdb51792b751dd882f037a1"}],"releasenotes/notes/add-redis-cache-for-keystone-a9c93d22f3372a1d.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bcd3304243b9f73f4c5a5875477341825629ea30","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Implements Redis as caching backend for Keystone"},{"line_number":5,"context_line":"    Memcached remains the default caching backend."},{"line_number":6,"context_line":"    To enable Redis as a caching backend for Keystone set"},{"line_number":7,"context_line":"    ``keystone_caching_backend: \"dogpile.cache.redis_sentinel\"``"},{"line_number":8,"context_line":"    `Partial Blueprint [redis-caching-backend]  \u003chttps://blueprints.launchpad.net/kolla-ansible/+spec/redis-caching-backend\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"95728133_28e40af0","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"updated":"2024-07-10 15:03:00.000000000","message":"This has changed now:\n\n```suggestion\n    ``cache_backend: \"redis\"``\n```","commit_id":"851c8919bcac62750028f075a530a14c80c9cfdb"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"3ea60023a5c524ff4d417cf6b11eea9cc46bb4cf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Implements Redis as caching backend for Keystone"},{"line_number":5,"context_line":"    Memcached remains the default caching backend."},{"line_number":6,"context_line":"    To enable Redis as a caching backend for Keystone set"},{"line_number":7,"context_line":"    ``keystone_caching_backend: \"dogpile.cache.redis_sentinel\"``"},{"line_number":8,"context_line":"    `Partial Blueprint [redis-caching-backend]  \u003chttps://blueprints.launchpad.net/kolla-ansible/+spec/redis-caching-backend\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"0e9d8088_a6b78f12","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"in_reply_to":"95728133_28e40af0","updated":"2024-07-16 09:08:20.000000000","message":"Done","commit_id":"851c8919bcac62750028f075a530a14c80c9cfdb"}]}