)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8555663d2dd01b397599ec8807ed6f7d9dd7ce08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"af905fd1_6f81a605","updated":"2024-04-30 09:36:39.000000000","message":"Code itself LGTM, please add some more docs, I provided some example as possible guidance.","commit_id":"79e6d251208624b86661edb3a5cea8ec73a81a80"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"1bf4fbc2ca61ac3087802d821c984ff135b9c0e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e64ca6bd_0ded4d31","updated":"2024-04-30 10:26:13.000000000","message":"Thanks for review. I added it to the reno. Will do the same for other services.\n\n I think there should be a global documentation for caching, because it\u0027s similar for all services. Maybe another patch just for docs? Or perhaps we may introduce another patch where user can set \ncaching variables globally `kolla_caching_backend: \"dogpile.cache.redis_sentinel\"` And then set e.g. `heat_caching_backend: \"{{ kolla_caching_backend }}\"`","commit_id":"79e6d251208624b86661edb3a5cea8ec73a81a80"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ed59259c54e6afacaf28a962b8754814996527ab","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f961b123_5532d7bd","in_reply_to":"e64ca6bd_0ded4d31","updated":"2024-05-03 14:11:52.000000000","message":"ok, then please link the docs change once it is ready here.","commit_id":"79e6d251208624b86661edb3a5cea8ec73a81a80"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"37e4982a79bb598b619d16417bd3073664a8f412","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"21e41c21_2e60a1ab","in_reply_to":"f961b123_5532d7bd","updated":"2024-05-06 08:24:45.000000000","message":"https://review.opendev.org/c/openstack/kolla-ansible/+/918285","commit_id":"79e6d251208624b86661edb3a5cea8ec73a81a80"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"51b99290db24e9c2ca0f4420118657efc29057d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4a71d5f2_d640219b","updated":"2024-06-27 10:06:25.000000000","message":"Thanks for the review.\nI will implement your comments latter today","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f521c5e43a8a40247d96e6209c073a41896e5c55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3d1ee86e_ffbee520","updated":"2024-06-27 10:53:19.000000000","message":"c","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"80b8ec9a1669dd960ddc7c505d4b122ef7caebf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"954872a2_b365c585","updated":"2024-06-26 16:24:23.000000000","message":"make it configurable... now you just removing cache for memcached and render redis cache conf ...but you can\u0027t suppose if user has redis turned on ...\n\nI would say that better approach is to give user an option to choose redis or memcached ..default memcached as it is now","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"352c5b60eddd447a262b06a838e8a18eb22c1b25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b5974270_ed9b7d5a","updated":"2024-08-05 15:49:25.000000000","message":"LGTM now!","commit_id":"757b55c76af9a8fd889309c13427a8e9809b9231"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"8c60e3c193f57ee0db0a4d8530f72ed4e569fba9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a0d27063_f67293b9","updated":"2025-03-04 09:35:31.000000000","message":"rechceck mariadb not synced","commit_id":"cee4bd54257dc3a67a230fe59c29cd00b9e80154"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"51b0f5743f3504f00799abdb8361b75c7052946e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"466aa0fa_ef9bc8aa","updated":"2025-03-05 09:10:03.000000000","message":"recheck mariadb","commit_id":"cee4bd54257dc3a67a230fe59c29cd00b9e80154"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"51b0f5743f3504f00799abdb8361b75c7052946e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"53b1f78e_11575726","in_reply_to":"a0d27063_f67293b9","updated":"2025-03-05 09:10:03.000000000","message":"Done","commit_id":"cee4bd54257dc3a67a230fe59c29cd00b9e80154"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"3d3247131f117b1d5f20c736279dfb876b8e5be0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"8108d3a3_a16abf04","updated":"2025-03-06 12:09:15.000000000","message":"recheck podman","commit_id":"beaf253ddb65782fd879f783731981bfac76086a"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"9a06bad325bd873a9c9598198dbbe336e1aa0b0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"36b3c1fb_ea151e62","updated":"2025-03-10 14:19:38.000000000","message":"recheck timeout","commit_id":"beaf253ddb65782fd879f783731981bfac76086a"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"71436e268d1ae350da1f0f955ef2bb4641492adf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"6ddac5ce_146f638f","updated":"2025-03-07 17:31:17.000000000","message":"recheck timeout again","commit_id":"beaf253ddb65782fd879f783731981bfac76086a"}],"ansible/roles/heat/defaults/main.yml":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4152b1ce6d179eae3505880a6bd9b257b8c8db3d","unresolved":true,"context_lines":[{"line_number":250,"context_line":"# Cache"},{"line_number":251,"context_line":"####################"},{"line_number":252,"context_line":"heat_cache_enabled: \"yes\""},{"line_number":253,"context_line":"heat_cache_backend: \"oslo_cache.memcache_pool\""},{"line_number":254,"context_line":"heat_cache_memcache_servers: \"{% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":255,"context_line":"heat_cache_redis_port: \"{{ redis_sentinel_tls_port if redis_enable_tls | bool else redis_sentinel_port }}\""},{"line_number":256,"context_line":"heat_cache_redis_sentinel_servers: \"{% for host in groups[\u0027redis\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) ~ \u0027:\u0027 ~ redis_port ~ ( \u0027,\u0027 if  loop.revindex \u003e 1  else  \u0027\u0027 )  }}{% endfor %}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e21bf977_5717e48e","line":253,"range":{"start_line":253,"start_character":0,"end_line":253,"end_character":46},"updated":"2024-06-27 08:39:26.000000000","message":"Here I don\u0027t have strong opinion but maybe it can be \"oslo_cache.memcache_pool\" by default and dogpile.cache.redis_sentinel if redis enabled ... But let others also comment.\n\nAlso, i think user should override heat_cache_backend in globals with values \u0027memcached\u0027 and \u0027redis\u0027, template dogpile.cache...or oslo.cache in template.","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"19164a5739cebaf6c406dd0f997d981fcc1a9187","unresolved":false,"context_lines":[{"line_number":250,"context_line":"# Cache"},{"line_number":251,"context_line":"####################"},{"line_number":252,"context_line":"heat_cache_enabled: \"yes\""},{"line_number":253,"context_line":"heat_cache_backend: \"oslo_cache.memcache_pool\""},{"line_number":254,"context_line":"heat_cache_memcache_servers: \"{% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":255,"context_line":"heat_cache_redis_port: \"{{ redis_sentinel_tls_port if redis_enable_tls | bool else redis_sentinel_port }}\""},{"line_number":256,"context_line":"heat_cache_redis_sentinel_servers: \"{% for host in groups[\u0027redis\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) ~ \u0027:\u0027 ~ redis_port ~ ( \u0027,\u0027 if  loop.revindex \u003e 1  else  \u0027\u0027 )  }}{% endfor %}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dbffe273_43d72764","line":253,"range":{"start_line":253,"start_character":0,"end_line":253,"end_character":46},"in_reply_to":"2141699f_20beec9b","updated":"2024-06-28 08:41:30.000000000","message":"Done","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9b6a654579c6871b19b5fcdb60d2a980c9ce10b9","unresolved":true,"context_lines":[{"line_number":250,"context_line":"# Cache"},{"line_number":251,"context_line":"####################"},{"line_number":252,"context_line":"heat_cache_enabled: \"yes\""},{"line_number":253,"context_line":"heat_cache_backend: \"oslo_cache.memcache_pool\""},{"line_number":254,"context_line":"heat_cache_memcache_servers: \"{% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":255,"context_line":"heat_cache_redis_port: \"{{ redis_sentinel_tls_port if redis_enable_tls | bool else redis_sentinel_port }}\""},{"line_number":256,"context_line":"heat_cache_redis_sentinel_servers: \"{% for host in groups[\u0027redis\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) ~ \u0027:\u0027 ~ redis_port ~ ( \u0027,\u0027 if  loop.revindex \u003e 1  else  \u0027\u0027 )  }}{% endfor %}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2141699f_20beec9b","line":253,"range":{"start_line":253,"start_character":0,"end_line":253,"end_character":46},"in_reply_to":"c013d579_1ddaae87","updated":"2024-06-27 10:50:52.000000000","message":"Yeah, you are right, but i still think that user should set \n\nheat_cache_backend: \"memcached\" or heat_cache_backend: \"redis\" (because it\u0027s more user friendly)\n\nAnd then just render the \"python module\" in template  like\n\n[cache]\nbackend \u003d {{ \u0027oslo_cache.memcache\u0027 if heat_cache_backend \u003d\u003d \u0027memcached\u0027 else \u0027redis\u0027 }}\n\n^^ or similar","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"51b99290db24e9c2ca0f4420118657efc29057d7","unresolved":true,"context_lines":[{"line_number":250,"context_line":"# Cache"},{"line_number":251,"context_line":"####################"},{"line_number":252,"context_line":"heat_cache_enabled: \"yes\""},{"line_number":253,"context_line":"heat_cache_backend: \"oslo_cache.memcache_pool\""},{"line_number":254,"context_line":"heat_cache_memcache_servers: \"{% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":255,"context_line":"heat_cache_redis_port: \"{{ redis_sentinel_tls_port if redis_enable_tls | bool else redis_sentinel_port }}\""},{"line_number":256,"context_line":"heat_cache_redis_sentinel_servers: \"{% for host in groups[\u0027redis\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) ~ \u0027:\u0027 ~ redis_port ~ ( \u0027,\u0027 if  loop.revindex \u003e 1  else  \u0027\u0027 )  }}{% endfor %}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c013d579_1ddaae87","line":253,"range":{"start_line":253,"start_character":0,"end_line":253,"end_character":46},"in_reply_to":"e21bf977_5717e48e","updated":"2024-06-27 10:06:25.000000000","message":"I don\u0027t think that\u0027s a good idea. The operator may want to use Redis only for coordination, and for cache use memcached.","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4152b1ce6d179eae3505880a6bd9b257b8c8db3d","unresolved":true,"context_lines":[{"line_number":251,"context_line":"####################"},{"line_number":252,"context_line":"heat_cache_enabled: \"yes\""},{"line_number":253,"context_line":"heat_cache_backend: \"oslo_cache.memcache_pool\""},{"line_number":254,"context_line":"heat_cache_memcache_servers: \"{% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":255,"context_line":"heat_cache_redis_port: \"{{ redis_sentinel_tls_port if redis_enable_tls | bool else redis_sentinel_port }}\""},{"line_number":256,"context_line":"heat_cache_redis_sentinel_servers: \"{% for host in groups[\u0027redis\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) ~ \u0027:\u0027 ~ redis_port ~ ( \u0027,\u0027 if  loop.revindex \u003e 1  else  \u0027\u0027 )  }}{% endfor %}\""},{"line_number":257,"context_line":"heat_cache_redis_sentinel_service_name: \"kolla\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"81638973_999a1349","line":254,"range":{"start_line":254,"start_character":0,"end_line":254,"end_character":205},"updated":"2024-06-27 08:39:26.000000000","message":"heat_cache_memcache_servers and heat_cache_redis_sentinel_servers can be one variable heat_cache_servers\n\nHeat_cache_servers can be set by jinja conditionals ...","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"19164a5739cebaf6c406dd0f997d981fcc1a9187","unresolved":false,"context_lines":[{"line_number":251,"context_line":"####################"},{"line_number":252,"context_line":"heat_cache_enabled: \"yes\""},{"line_number":253,"context_line":"heat_cache_backend: \"oslo_cache.memcache_pool\""},{"line_number":254,"context_line":"heat_cache_memcache_servers: \"{% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":255,"context_line":"heat_cache_redis_port: \"{{ redis_sentinel_tls_port if redis_enable_tls | bool else redis_sentinel_port }}\""},{"line_number":256,"context_line":"heat_cache_redis_sentinel_servers: \"{% for host in groups[\u0027redis\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) ~ \u0027:\u0027 ~ redis_port ~ ( \u0027,\u0027 if  loop.revindex \u003e 1  else  \u0027\u0027 )  }}{% endfor %}\""},{"line_number":257,"context_line":"heat_cache_redis_sentinel_service_name: \"kolla\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d669e0b2_e2e11b70","line":254,"range":{"start_line":254,"start_character":0,"end_line":254,"end_character":205},"in_reply_to":"81638973_999a1349","updated":"2024-06-28 08:41:30.000000000","message":"Done","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4152b1ce6d179eae3505880a6bd9b257b8c8db3d","unresolved":true,"context_lines":[{"line_number":252,"context_line":"heat_cache_enabled: \"yes\""},{"line_number":253,"context_line":"heat_cache_backend: \"oslo_cache.memcache_pool\""},{"line_number":254,"context_line":"heat_cache_memcache_servers: \"{% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":255,"context_line":"heat_cache_redis_port: \"{{ redis_sentinel_tls_port if redis_enable_tls | bool else redis_sentinel_port }}\""},{"line_number":256,"context_line":"heat_cache_redis_sentinel_servers: \"{% for host in groups[\u0027redis\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) ~ \u0027:\u0027 ~ redis_port ~ ( \u0027,\u0027 if  loop.revindex \u003e 1  else  \u0027\u0027 )  }}{% endfor %}\""},{"line_number":257,"context_line":"heat_cache_redis_sentinel_service_name: \"kolla\""},{"line_number":258,"context_line":"heat_cache_additional_backend_arguments: {}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9400ce25_f5fcb4a6","line":255,"range":{"start_line":255,"start_character":0,"end_line":255,"end_character":106},"updated":"2024-06-27 08:39:26.000000000","message":"Is it needed in heat role ? maybe this should go to group_vars/all.yml so it will be usable as redis_port: or similar ?","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f521c5e43a8a40247d96e6209c073a41896e5c55","unresolved":true,"context_lines":[{"line_number":252,"context_line":"heat_cache_enabled: \"yes\""},{"line_number":253,"context_line":"heat_cache_backend: \"oslo_cache.memcache_pool\""},{"line_number":254,"context_line":"heat_cache_memcache_servers: \"{% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":255,"context_line":"heat_cache_redis_port: \"{{ redis_sentinel_tls_port if redis_enable_tls | bool else redis_sentinel_port }}\""},{"line_number":256,"context_line":"heat_cache_redis_sentinel_servers: \"{% for host in groups[\u0027redis\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) ~ \u0027:\u0027 ~ redis_port ~ ( \u0027,\u0027 if  loop.revindex \u003e 1  else  \u0027\u0027 )  }}{% endfor %}\""},{"line_number":257,"context_line":"heat_cache_redis_sentinel_service_name: \"kolla\""},{"line_number":258,"context_line":"heat_cache_additional_backend_arguments: {}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5e48a3dd_37a2a1f8","line":255,"range":{"start_line":255,"start_character":0,"end_line":255,"end_character":106},"in_reply_to":"323ac0e3_0567cd33","updated":"2024-06-27 10:53:19.000000000","message":"Exactly :)","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"470c7c7863b448404d67c20e1c0e4c39c1137237","unresolved":false,"context_lines":[{"line_number":252,"context_line":"heat_cache_enabled: \"yes\""},{"line_number":253,"context_line":"heat_cache_backend: \"oslo_cache.memcache_pool\""},{"line_number":254,"context_line":"heat_cache_memcache_servers: \"{% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":255,"context_line":"heat_cache_redis_port: \"{{ redis_sentinel_tls_port if redis_enable_tls | bool else redis_sentinel_port }}\""},{"line_number":256,"context_line":"heat_cache_redis_sentinel_servers: \"{% for host in groups[\u0027redis\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) ~ \u0027:\u0027 ~ redis_port ~ ( \u0027,\u0027 if  loop.revindex \u003e 1  else  \u0027\u0027 )  }}{% endfor %}\""},{"line_number":257,"context_line":"heat_cache_redis_sentinel_service_name: \"kolla\""},{"line_number":258,"context_line":"heat_cache_additional_backend_arguments: {}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8e669f04_a20d0d7a","line":255,"range":{"start_line":255,"start_character":0,"end_line":255,"end_character":106},"in_reply_to":"5e48a3dd_37a2a1f8","updated":"2024-06-28 08:37:40.000000000","message":"Done","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"51b99290db24e9c2ca0f4420118657efc29057d7","unresolved":true,"context_lines":[{"line_number":252,"context_line":"heat_cache_enabled: \"yes\""},{"line_number":253,"context_line":"heat_cache_backend: \"oslo_cache.memcache_pool\""},{"line_number":254,"context_line":"heat_cache_memcache_servers: \"{% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":255,"context_line":"heat_cache_redis_port: \"{{ redis_sentinel_tls_port if redis_enable_tls | bool else redis_sentinel_port }}\""},{"line_number":256,"context_line":"heat_cache_redis_sentinel_servers: \"{% for host in groups[\u0027redis\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) ~ \u0027:\u0027 ~ redis_port ~ ( \u0027,\u0027 if  loop.revindex \u003e 1  else  \u0027\u0027 )  }}{% endfor %}\""},{"line_number":257,"context_line":"heat_cache_redis_sentinel_service_name: \"kolla\""},{"line_number":258,"context_line":"heat_cache_additional_backend_arguments: {}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"323ac0e3_0567cd33","line":255,"range":{"start_line":255,"start_character":0,"end_line":255,"end_character":106},"in_reply_to":"9400ce25_f5fcb4a6","updated":"2024-06-27 10:06:25.000000000","message":"I agree we should use generic variables, such as `redis_port`and \u0027redis_sentinel_servers\u0027 in all.yaml. There\u0027s no reason to have these variables per role, as there is only one Redis for all services.","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4152b1ce6d179eae3505880a6bd9b257b8c8db3d","unresolved":true,"context_lines":[{"line_number":253,"context_line":"heat_cache_backend: \"oslo_cache.memcache_pool\""},{"line_number":254,"context_line":"heat_cache_memcache_servers: \"{% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":255,"context_line":"heat_cache_redis_port: \"{{ redis_sentinel_tls_port if redis_enable_tls | bool else redis_sentinel_port }}\""},{"line_number":256,"context_line":"heat_cache_redis_sentinel_servers: \"{% for host in groups[\u0027redis\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) ~ \u0027:\u0027 ~ redis_port ~ ( \u0027,\u0027 if  loop.revindex \u003e 1  else  \u0027\u0027 )  }}{% endfor %}\""},{"line_number":257,"context_line":"heat_cache_redis_sentinel_service_name: \"kolla\""},{"line_number":258,"context_line":"heat_cache_additional_backend_arguments: {}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"89cda957_ac705bd0","line":256,"range":{"start_line":256,"start_character":0,"end_line":256,"end_character":209},"updated":"2024-06-27 08:39:26.000000000","message":"check above comment.","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"19164a5739cebaf6c406dd0f997d981fcc1a9187","unresolved":false,"context_lines":[{"line_number":253,"context_line":"heat_cache_backend: \"oslo_cache.memcache_pool\""},{"line_number":254,"context_line":"heat_cache_memcache_servers: \"{% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":255,"context_line":"heat_cache_redis_port: \"{{ redis_sentinel_tls_port if redis_enable_tls | bool else redis_sentinel_port }}\""},{"line_number":256,"context_line":"heat_cache_redis_sentinel_servers: \"{% for host in groups[\u0027redis\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) ~ \u0027:\u0027 ~ redis_port ~ ( \u0027,\u0027 if  loop.revindex \u003e 1  else  \u0027\u0027 )  }}{% endfor %}\""},{"line_number":257,"context_line":"heat_cache_redis_sentinel_service_name: \"kolla\""},{"line_number":258,"context_line":"heat_cache_additional_backend_arguments: {}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c2b810bb_c85f5451","line":256,"range":{"start_line":256,"start_character":0,"end_line":256,"end_character":209},"in_reply_to":"89cda957_ac705bd0","updated":"2024-06-28 08:41:30.000000000","message":"Done","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"}],"ansible/roles/heat/tasks/copy-certs.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fcac19fbbf43a6f675014cac9c8449cd5ffe7c1b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    role: service-cert-copy"},{"line_number":5,"context_line":"  vars:"},{"line_number":6,"context_line":"    project_services: \"{{ heat_services }}\""},{"line_number":7,"context_line":"- name: \"Copy Redis certificates for {{ project_name }}\""},{"line_number":8,"context_line":"  import_role:"},{"line_number":9,"context_line":"    role: redis"},{"line_number":10,"context_line":"    tasks_from: copy-certs"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"435227eb_517f7e1d","line":7,"updated":"2024-04-26 08:15:54.000000000","message":"newline between tasks","commit_id":"6c8c027b2d26f1082e71e6ee736167f2403d418e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"5f9fb689ac3a05c235db84ed89db690fd8633514","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    role: service-cert-copy"},{"line_number":5,"context_line":"  vars:"},{"line_number":6,"context_line":"    project_services: \"{{ heat_services }}\""},{"line_number":7,"context_line":"- name: \"Copy Redis certificates for {{ project_name }}\""},{"line_number":8,"context_line":"  import_role:"},{"line_number":9,"context_line":"    role: redis"},{"line_number":10,"context_line":"    tasks_from: copy-certs"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"178b892f_e41451c9","line":7,"in_reply_to":"435227eb_517f7e1d","updated":"2024-04-26 15:35:27.000000000","message":"Done","commit_id":"6c8c027b2d26f1082e71e6ee736167f2403d418e"}],"ansible/roles/heat/templates/heat.conf.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fcac19fbbf43a6f675014cac9c8449cd5ffe7c1b","unresolved":true,"context_lines":[{"line_number":99,"context_line":"{% endif %}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"[cache]"},{"line_number":102,"context_line":"enabled \u003d \"{{ \u0027True\u0027 if heat_cache_enabled | bool else \u0027False\u0027 }}\""},{"line_number":103,"context_line":"backend \u003d {{ heat_cache_backend }}"},{"line_number":104,"context_line":"{% if heat_cache_backend \u003d\u003d \u0027dogpile.cache.redis_sentinel\u0027 %}"},{"line_number":105,"context_line":"redis_username \u003d {{ redis_username }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"20ab6dcc_014dba27","line":102,"updated":"2024-04-26 08:15:54.000000000","message":"{{ heat_cache_enabled | bool }} should be enough","commit_id":"6c8c027b2d26f1082e71e6ee736167f2403d418e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"5f9fb689ac3a05c235db84ed89db690fd8633514","unresolved":false,"context_lines":[{"line_number":99,"context_line":"{% endif %}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"[cache]"},{"line_number":102,"context_line":"enabled \u003d \"{{ \u0027True\u0027 if heat_cache_enabled | bool else \u0027False\u0027 }}\""},{"line_number":103,"context_line":"backend \u003d {{ heat_cache_backend }}"},{"line_number":104,"context_line":"{% if heat_cache_backend \u003d\u003d \u0027dogpile.cache.redis_sentinel\u0027 %}"},{"line_number":105,"context_line":"redis_username \u003d {{ redis_username }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"8d768bf0_ba9abd52","line":102,"in_reply_to":"20ab6dcc_014dba27","updated":"2024-04-26 15:35:27.000000000","message":"Done","commit_id":"6c8c027b2d26f1082e71e6ee736167f2403d418e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fcac19fbbf43a6f675014cac9c8449cd5ffe7c1b","unresolved":true,"context_lines":[{"line_number":116,"context_line":"{% for argument, value in heat_cache_additional_backend_arguments.items() %}"},{"line_number":117,"context_line":"backend_argument \u003d {{ argument ~\u0027:\u0027~ value}}"},{"line_number":118,"context_line":"{% endfor %}"},{"line_number":119,"context_line":"{% if heat_cache_backend \u003d\u003d \u0027oslo_cache.memcache_pool\u0027 and heat_cache_memcache_servers | length %}"},{"line_number":120,"context_line":"memcache_servers \u003d {{ heat_cache_memcache_servers }}"},{"line_number":121,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"a9cee830_ac396836","line":119,"updated":"2024-04-26 08:15:54.000000000","message":"elif?","commit_id":"6c8c027b2d26f1082e71e6ee736167f2403d418e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"5f9fb689ac3a05c235db84ed89db690fd8633514","unresolved":false,"context_lines":[{"line_number":116,"context_line":"{% for argument, value in heat_cache_additional_backend_arguments.items() %}"},{"line_number":117,"context_line":"backend_argument \u003d {{ argument ~\u0027:\u0027~ value}}"},{"line_number":118,"context_line":"{% endfor %}"},{"line_number":119,"context_line":"{% if heat_cache_backend \u003d\u003d \u0027oslo_cache.memcache_pool\u0027 and heat_cache_memcache_servers | length %}"},{"line_number":120,"context_line":"memcache_servers \u003d {{ heat_cache_memcache_servers }}"},{"line_number":121,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"b4cf8241_80695d03","line":119,"in_reply_to":"a9cee830_ac396836","updated":"2024-04-26 15:35:27.000000000","message":"Done","commit_id":"6c8c027b2d26f1082e71e6ee736167f2403d418e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e52b5017879c3214bd84783cd55dbd43b5faec5c","unresolved":true,"context_lines":[{"line_number":73,"context_line":"{% if om_enable_rabbitmq_high_availability | bool %}"},{"line_number":74,"context_line":"amqp_durable_queues \u003d true"},{"line_number":75,"context_line":"{% endif %}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"{% if om_enable_rabbitmq_quorum_queues | bool %}"},{"line_number":78,"context_line":"rabbit_quorum_queue \u003d true"},{"line_number":79,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"c56551b8_935148f6","line":76,"updated":"2024-05-27 12:32:38.000000000","message":"nit: unnecessary newline","commit_id":"4d92e2adb6ead236ffd2c30c04bf3b071eb4590a"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"311b8b4ddede99866b2e3d621b047baa6338d5ac","unresolved":false,"context_lines":[{"line_number":73,"context_line":"{% if om_enable_rabbitmq_high_availability | bool %}"},{"line_number":74,"context_line":"amqp_durable_queues \u003d true"},{"line_number":75,"context_line":"{% endif %}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"{% if om_enable_rabbitmq_quorum_queues | bool %}"},{"line_number":78,"context_line":"rabbit_quorum_queue \u003d true"},{"line_number":79,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"6b3da225_42739801","line":76,"in_reply_to":"c56551b8_935148f6","updated":"2024-05-28 13:48:51.000000000","message":"Done","commit_id":"4d92e2adb6ead236ffd2c30c04bf3b071eb4590a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4152b1ce6d179eae3505880a6bd9b257b8c8db3d","unresolved":true,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"[cache]"},{"line_number":101,"context_line":"enabled \u003d \"{{ heat_cache_enabled | bool }}\""},{"line_number":102,"context_line":"backend \u003d {{ heat_cache_backend }}"},{"line_number":103,"context_line":"{% if heat_cache_backend \u003d\u003d \u0027dogpile.cache.redis_sentinel\u0027 %}"},{"line_number":104,"context_line":"redis_username \u003d {{ redis_username }}"},{"line_number":105,"context_line":"redis_password \u003d {{ redis_master_password }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"2dca6b07_5d9c3b65","line":102,"range":{"start_line":102,"start_character":13,"end_line":102,"end_character":31},"updated":"2024-06-27 08:39:26.000000000","message":"check above comment.","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"19164a5739cebaf6c406dd0f997d981fcc1a9187","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"[cache]"},{"line_number":101,"context_line":"enabled \u003d \"{{ heat_cache_enabled | bool }}\""},{"line_number":102,"context_line":"backend \u003d {{ heat_cache_backend }}"},{"line_number":103,"context_line":"{% if heat_cache_backend \u003d\u003d \u0027dogpile.cache.redis_sentinel\u0027 %}"},{"line_number":104,"context_line":"redis_username \u003d {{ redis_username }}"},{"line_number":105,"context_line":"redis_password \u003d {{ redis_master_password }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"bde48d6a_d7e26a79","line":102,"range":{"start_line":102,"start_character":13,"end_line":102,"end_character":31},"in_reply_to":"2dca6b07_5d9c3b65","updated":"2024-06-28 08:41:30.000000000","message":"Done","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4152b1ce6d179eae3505880a6bd9b257b8c8db3d","unresolved":true,"context_lines":[{"line_number":100,"context_line":"[cache]"},{"line_number":101,"context_line":"enabled \u003d \"{{ heat_cache_enabled | bool }}\""},{"line_number":102,"context_line":"backend \u003d {{ heat_cache_backend }}"},{"line_number":103,"context_line":"{% if heat_cache_backend \u003d\u003d \u0027dogpile.cache.redis_sentinel\u0027 %}"},{"line_number":104,"context_line":"redis_username \u003d {{ redis_username }}"},{"line_number":105,"context_line":"redis_password \u003d {{ redis_master_password }}"},{"line_number":106,"context_line":"redis_sentinels \u003d {{ heat_cache_redis_sentinel_servers }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"333b4178_c3d39ec7","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":61},"updated":"2024-06-27 08:39:26.000000000","message":"check above comment","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"19164a5739cebaf6c406dd0f997d981fcc1a9187","unresolved":false,"context_lines":[{"line_number":100,"context_line":"[cache]"},{"line_number":101,"context_line":"enabled \u003d \"{{ heat_cache_enabled | bool }}\""},{"line_number":102,"context_line":"backend \u003d {{ heat_cache_backend }}"},{"line_number":103,"context_line":"{% if heat_cache_backend \u003d\u003d \u0027dogpile.cache.redis_sentinel\u0027 %}"},{"line_number":104,"context_line":"redis_username \u003d {{ redis_username }}"},{"line_number":105,"context_line":"redis_password \u003d {{ redis_master_password }}"},{"line_number":106,"context_line":"redis_sentinels \u003d {{ heat_cache_redis_sentinel_servers }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"c07c1fca_37be7e30","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":61},"in_reply_to":"333b4178_c3d39ec7","updated":"2024-06-28 08:41:30.000000000","message":"Done","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4152b1ce6d179eae3505880a6bd9b257b8c8db3d","unresolved":true,"context_lines":[{"line_number":111,"context_line":"tls_keyfile \u003d /etc/redis/certs/redis-key.pem"},{"line_number":112,"context_line":"tls_cafile \u003d {{ openstack_cacert  if redis_tls_use_openstack_ca | bool else \u0027/etc/redis/certs/ca-certificate.pem\u0027}}"},{"line_number":113,"context_line":"{% endif %}"},{"line_number":114,"context_line":"{% elif heat_cache_backend \u003d\u003d \u0027oslo_cache.memcache_pool\u0027 and heat_cache_memcache_servers | length %}"},{"line_number":115,"context_line":"memcache_servers \u003d {{ heat_cache_memcache_servers }}"},{"line_number":116,"context_line":"{% endif %}"},{"line_number":117,"context_line":"{% for argument, value in heat_cache_additional_backend_arguments.items() %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"c47d56c5_ba4963c5","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":100},"updated":"2024-06-27 08:39:26.000000000","message":"check above comment with heat_cache_backend and also heat_cache_memcache_servers can be one common variable with redis ...check above comment also.","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"470c7c7863b448404d67c20e1c0e4c39c1137237","unresolved":false,"context_lines":[{"line_number":111,"context_line":"tls_keyfile \u003d /etc/redis/certs/redis-key.pem"},{"line_number":112,"context_line":"tls_cafile \u003d {{ openstack_cacert  if redis_tls_use_openstack_ca | bool else \u0027/etc/redis/certs/ca-certificate.pem\u0027}}"},{"line_number":113,"context_line":"{% endif %}"},{"line_number":114,"context_line":"{% elif heat_cache_backend \u003d\u003d \u0027oslo_cache.memcache_pool\u0027 and heat_cache_memcache_servers | length %}"},{"line_number":115,"context_line":"memcache_servers \u003d {{ heat_cache_memcache_servers }}"},{"line_number":116,"context_line":"{% endif %}"},{"line_number":117,"context_line":"{% for argument, value in heat_cache_additional_backend_arguments.items() %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"b06759db_ad987f83","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":100},"in_reply_to":"259fb4d0_5a62a9c1","updated":"2024-06-28 08:37:40.000000000","message":"Done","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f521c5e43a8a40247d96e6209c073a41896e5c55","unresolved":true,"context_lines":[{"line_number":111,"context_line":"tls_keyfile \u003d /etc/redis/certs/redis-key.pem"},{"line_number":112,"context_line":"tls_cafile \u003d {{ openstack_cacert  if redis_tls_use_openstack_ca | bool else \u0027/etc/redis/certs/ca-certificate.pem\u0027}}"},{"line_number":113,"context_line":"{% endif %}"},{"line_number":114,"context_line":"{% elif heat_cache_backend \u003d\u003d \u0027oslo_cache.memcache_pool\u0027 and heat_cache_memcache_servers | length %}"},{"line_number":115,"context_line":"memcache_servers \u003d {{ heat_cache_memcache_servers }}"},{"line_number":116,"context_line":"{% endif %}"},{"line_number":117,"context_line":"{% for argument, value in heat_cache_additional_backend_arguments.items() %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"259fb4d0_5a62a9c1","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":100},"in_reply_to":"8481299d_8f1f20cd","updated":"2024-06-27 10:53:19.000000000","message":"well\n\nyou can leave heat_cache_backend: \"{{ kolla_cahce_backend }}\" by default in defaults\n\nSo, by default it will be the cache used for other services globally. But, you will still have an option to override heat_cache_backend to your value in globals.","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"51b99290db24e9c2ca0f4420118657efc29057d7","unresolved":true,"context_lines":[{"line_number":111,"context_line":"tls_keyfile \u003d /etc/redis/certs/redis-key.pem"},{"line_number":112,"context_line":"tls_cafile \u003d {{ openstack_cacert  if redis_tls_use_openstack_ca | bool else \u0027/etc/redis/certs/ca-certificate.pem\u0027}}"},{"line_number":113,"context_line":"{% endif %}"},{"line_number":114,"context_line":"{% elif heat_cache_backend \u003d\u003d \u0027oslo_cache.memcache_pool\u0027 and heat_cache_memcache_servers | length %}"},{"line_number":115,"context_line":"memcache_servers \u003d {{ heat_cache_memcache_servers }}"},{"line_number":116,"context_line":"{% endif %}"},{"line_number":117,"context_line":"{% for argument, value in heat_cache_additional_backend_arguments.items() %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"8481299d_8f1f20cd","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":100},"in_reply_to":"c47d56c5_ba4963c5","updated":"2024-06-27 10:06:25.000000000","message":"We should  change `heat_cache_backend` to be something like `kolla_cahce_backend` which would be global for all services, so user may globally set backend for all services. This variable should be introduced in a different patch, because it will be used by other roles as well.\n \nAs for `heat_cache_enabled` we may use similar approach, question is whether we want user to turn cache on/off per service or just globally.","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4152b1ce6d179eae3505880a6bd9b257b8c8db3d","unresolved":true,"context_lines":[{"line_number":112,"context_line":"tls_cafile \u003d {{ openstack_cacert  if redis_tls_use_openstack_ca | bool else \u0027/etc/redis/certs/ca-certificate.pem\u0027}}"},{"line_number":113,"context_line":"{% endif %}"},{"line_number":114,"context_line":"{% elif heat_cache_backend \u003d\u003d \u0027oslo_cache.memcache_pool\u0027 and heat_cache_memcache_servers | length %}"},{"line_number":115,"context_line":"memcache_servers \u003d {{ heat_cache_memcache_servers }}"},{"line_number":116,"context_line":"{% endif %}"},{"line_number":117,"context_line":"{% for argument, value in heat_cache_additional_backend_arguments.items() %}"},{"line_number":118,"context_line":"backend_argument \u003d {{ argument ~\u0027:\u0027~ value}}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"4a6849da_ccd140ea","line":115,"range":{"start_line":115,"start_character":22,"end_line":115,"end_character":49},"updated":"2024-06-27 08:39:26.000000000","message":"again ..can be common variable.","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"0d7bcc03cf755b19c14716d72ec2a6eaafe3b587","unresolved":false,"context_lines":[{"line_number":112,"context_line":"tls_cafile \u003d {{ openstack_cacert  if redis_tls_use_openstack_ca | bool else \u0027/etc/redis/certs/ca-certificate.pem\u0027}}"},{"line_number":113,"context_line":"{% endif %}"},{"line_number":114,"context_line":"{% elif heat_cache_backend \u003d\u003d \u0027oslo_cache.memcache_pool\u0027 and heat_cache_memcache_servers | length %}"},{"line_number":115,"context_line":"memcache_servers \u003d {{ heat_cache_memcache_servers }}"},{"line_number":116,"context_line":"{% endif %}"},{"line_number":117,"context_line":"{% for argument, value in heat_cache_additional_backend_arguments.items() %}"},{"line_number":118,"context_line":"backend_argument \u003d {{ argument ~\u0027:\u0027~ value}}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1f5c5cd4_b7e9cda2","line":115,"range":{"start_line":115,"start_character":22,"end_line":115,"end_character":49},"in_reply_to":"4a6849da_ccd140ea","updated":"2024-06-28 12:14:14.000000000","message":"Done","commit_id":"0cdfd3e5870d35bb4b7daead88c1f37452ed7c8b"}],"releasenotes/notes/add-redis-cache-for-heat-7a75e9f9e501bcc6.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8555663d2dd01b397599ec8807ed6f7d9dd7ce08","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Implements Redis cache for Heat."},{"line_number":5,"context_line":"    `Partial Blueprint redis-caching-backend  \u003chttps://blueprints.launchpad.net/kolla-ansible/+spec/redis-caching-backend\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9dbf7894_fc776810","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"updated":"2024-04-30 09:36:39.000000000","message":"Some docs would be nice how to use it, at the very least in the renos, or better yet in the actual docs.\nSomething along the lines of \"To enable Redis as a caching backend for Heat set heat_caching_backend to dogpile.cache.redis_sentinel\"\nAlso worth mentioning that the default backend still is memcached and users don\u0027t need to change anything if they want to stick with memcached.\n\nThanks","commit_id":"79e6d251208624b86661edb3a5cea8ec73a81a80"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"1bf4fbc2ca61ac3087802d821c984ff135b9c0e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Implements Redis cache for Heat."},{"line_number":5,"context_line":"    `Partial Blueprint redis-caching-backend  \u003chttps://blueprints.launchpad.net/kolla-ansible/+spec/redis-caching-backend\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2f1caafa_8442da88","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"in_reply_to":"9dbf7894_fc776810","updated":"2024-04-30 10:26:13.000000000","message":"Done","commit_id":"79e6d251208624b86661edb3a5cea8ec73a81a80"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8646645c7bdca5e3d3293e576ae9cbad6da7d1ef","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Implements Redis cache for Heat."},{"line_number":5,"context_line":"    Memcached remains the default caching backend."},{"line_number":6,"context_line":"    To enable Redis as a caching backend for Heat set"},{"line_number":7,"context_line":"    ``heat_caching_backend: \"dogpile.cache.redis_sentinel\"``"},{"line_number":8,"context_line":"    `Partial Blueprint redis-caching-backend  \u003chttps://blueprints.launchpad.net/kolla-ansible/+spec/redis-caching-backend\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"669f3547_b9c0c7e5","line":7,"range":{"start_line":6,"start_character":4,"end_line":7,"end_character":60},"updated":"2024-05-28 11:40:26.000000000","message":"https://review.opendev.org/c/openstack/kolla-ansible/+/909222/4/releasenotes/notes/add-redis-cache-for-placement-14bf6738bd397c0b.yaml#7","commit_id":"4d92e2adb6ead236ffd2c30c04bf3b071eb4590a"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"c5705f107f075ab30185942382e41cd20dd0d411","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Implements Redis cache for Heat."},{"line_number":5,"context_line":"    Memcached remains the default caching backend."},{"line_number":6,"context_line":"    To enable Redis as a caching backend for Heat set"},{"line_number":7,"context_line":"    ``heat_caching_backend: \"dogpile.cache.redis_sentinel\"``"},{"line_number":8,"context_line":"    `Partial Blueprint redis-caching-backend  \u003chttps://blueprints.launchpad.net/kolla-ansible/+spec/redis-caching-backend\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2376a011_9ca265fe","line":7,"range":{"start_line":6,"start_character":4,"end_line":7,"end_character":60},"in_reply_to":"669f3547_b9c0c7e5","updated":"2024-05-28 12:17:48.000000000","message":"Acknowledged","commit_id":"4d92e2adb6ead236ffd2c30c04bf3b071eb4590a"}]}