)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"064c8ca803857ee44439b451d0ddd5a94fb8ed9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bb4a8ac6_d34f5e52","updated":"2024-03-18 06:42:59.000000000","message":"Can somebody explain to me why skyline needs those? Any docs reference? Surely needs some explanation in commit message + reno","commit_id":"dab64f03adf2c1a8bfae6bd9b4f556544e432b7c"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"c208bc5179d8035e6e359382511c43fcd807c826","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e3bd0a9d_3341daef","updated":"2024-02-27 10:54:03.000000000","message":"Included missing entries in skyline.yaml.j2","commit_id":"dab64f03adf2c1a8bfae6bd9b4f556544e432b7c"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"a8373faf1a73a565605d707ea11f80e6c3492317","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c7be97c4_8f7d1819","in_reply_to":"bb4a8ac6_d34f5e52","updated":"2024-03-18 07:33:45.000000000","message":"Thanks for your review. Skyline Console is a Javascript (React) application that talks directly to the services endpoints. As I\u0027m not a Skyline developer, just someone who wants to use Skyline, I can only guess why they made it like this: the javascript application talks to the services through nginx as a proxy, that get\u0027s around CORS issues and you can move the configuration of those endpoints to the nginx configuration and can keep the javascript part rather \"static\". As the Skyline developers add more services, user that install Skyline with Kolla-ansible can not use those services in Skyline if the nginx configuration is not updated. I\u0027m certainly happy to add a reno stating this.","commit_id":"dab64f03adf2c1a8bfae6bd9b4f556544e432b7c"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"62247c9858553e525c31c09795dec8a84e65d377","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"da412525_75e983a8","in_reply_to":"c7be97c4_8f7d1819","updated":"2024-03-26 07:24:47.000000000","message":"@mnasiadka@gmail.com did my reply answer your question? Can we resolve this or is there anything else I can do for this change?","commit_id":"dab64f03adf2c1a8bfae6bd9b4f556544e432b7c"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"50f0bd74b1243f891006a9bc86de3535c73cda50","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8fd7641f_d04de412","in_reply_to":"da412525_75e983a8","updated":"2024-04-23 16:05:44.000000000","message":"Anything else I can do for this change?","commit_id":"dab64f03adf2c1a8bfae6bd9b4f556544e432b7c"}],"ansible/roles/skyline/templates/nginx.conf.j2":[{"author":{"_account_id":35638,"deleted":true},"change_message_id":"f3c7b09ca839f3258d75c983e5defab4f90892db","unresolved":true,"context_lines":[{"line_number":287,"context_line":"            proxy_set_header Host $http_host;"},{"line_number":288,"context_line":"        }"},{"line_number":289,"context_line":"        {% endif %}"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        {% if enable_swift | bool %}# Region: {{ openstack_region_name }}, Service: swift"},{"line_number":292,"context_line":"        location {{ skyline_nginx_prefix }}/{{ openstack_region_name | lower }}/swift {"},{"line_number":293,"context_line":"            proxy_pass {{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_api_port }}/;"},{"line_number":294,"context_line":"            proxy_redirect {{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_api_port }}/ {{ skyline_nginx_prefix }}/{{ openstack_region_name | lower }}/swift/;"},{"line_number":295,"context_line":"            proxy_buffering off;"},{"line_number":296,"context_line":"            proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;"},{"line_number":297,"context_line":"            proxy_set_header X-Forwarded-Proto $scheme;"},{"line_number":298,"context_line":"            proxy_set_header X-Forwarded-Host $host;"},{"line_number":299,"context_line":"            proxy_set_header Host $http_host;"},{"line_number":300,"context_line":"        }"},{"line_number":301,"context_line":"        {% endif %}"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"69604df6_835aba40","line":302,"range":{"start_line":290,"start_character":0,"end_line":302,"end_character":0},"updated":"2024-03-16 21:01:01.000000000","message":"Do you think it would be possible to also activate this when using an external Ceph RGW service?","commit_id":"dab64f03adf2c1a8bfae6bd9b4f556544e432b7c"},{"author":{"_account_id":35638,"deleted":true},"change_message_id":"9208fb1041af5f4e5e7a2298ce415ea17fea1a68","unresolved":true,"context_lines":[{"line_number":287,"context_line":"            proxy_set_header Host $http_host;"},{"line_number":288,"context_line":"        }"},{"line_number":289,"context_line":"        {% endif %}"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        {% if enable_swift | bool %}# Region: {{ openstack_region_name }}, Service: swift"},{"line_number":292,"context_line":"        location {{ skyline_nginx_prefix }}/{{ openstack_region_name | lower }}/swift {"},{"line_number":293,"context_line":"            proxy_pass {{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_api_port }}/;"},{"line_number":294,"context_line":"            proxy_redirect {{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_api_port }}/ {{ skyline_nginx_prefix }}/{{ openstack_region_name | lower }}/swift/;"},{"line_number":295,"context_line":"            proxy_buffering off;"},{"line_number":296,"context_line":"            proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;"},{"line_number":297,"context_line":"            proxy_set_header X-Forwarded-Proto $scheme;"},{"line_number":298,"context_line":"            proxy_set_header X-Forwarded-Host $host;"},{"line_number":299,"context_line":"            proxy_set_header Host $http_host;"},{"line_number":300,"context_line":"        }"},{"line_number":301,"context_line":"        {% endif %}"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9c709744_51011875","line":302,"range":{"start_line":290,"start_character":0,"end_line":302,"end_character":0},"in_reply_to":"33e0bd5c_9a8d0767","updated":"2024-03-20 14:48:52.000000000","message":"I agree.\nWe could probably add some checks in the precheck stage to avoid this or at least print some warning, not sure whether if its something that should be avoided. Just an idea from my side.","commit_id":"dab64f03adf2c1a8bfae6bd9b4f556544e432b7c"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"02185e5508689603eb01a18ddd06d9a2135c1ae4","unresolved":true,"context_lines":[{"line_number":287,"context_line":"            proxy_set_header Host $http_host;"},{"line_number":288,"context_line":"        }"},{"line_number":289,"context_line":"        {% endif %}"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        {% if enable_swift | bool %}# Region: {{ openstack_region_name }}, Service: swift"},{"line_number":292,"context_line":"        location {{ skyline_nginx_prefix }}/{{ openstack_region_name | lower }}/swift {"},{"line_number":293,"context_line":"            proxy_pass {{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_api_port }}/;"},{"line_number":294,"context_line":"            proxy_redirect {{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_api_port }}/ {{ skyline_nginx_prefix }}/{{ openstack_region_name | lower }}/swift/;"},{"line_number":295,"context_line":"            proxy_buffering off;"},{"line_number":296,"context_line":"            proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;"},{"line_number":297,"context_line":"            proxy_set_header X-Forwarded-Proto $scheme;"},{"line_number":298,"context_line":"            proxy_set_header X-Forwarded-Host $host;"},{"line_number":299,"context_line":"            proxy_set_header Host $http_host;"},{"line_number":300,"context_line":"        }"},{"line_number":301,"context_line":"        {% endif %}"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"c9b69b2c_0ad4c0fa","line":302,"range":{"start_line":290,"start_character":0,"end_line":302,"end_character":0},"in_reply_to":"69604df6_835aba40","updated":"2024-03-17 17:28:54.000000000","message":"I see your point but I\u0027m not sure whether it\u0027s that simple since there is an option in ceph-rgw to include the project id in the url (see https://opendev.org/openstack/kolla-ansible/src/branch/master/ansible/roles/ceph-rgw/defaults/main.yml#L59). If this is configured I guess we need a more dynamic proxy that knows about the current project of the user.\nHaving said that, I might try to find a solution as this is our current setup but it will take some time and might also need so changes to Skyline itself.","commit_id":"dab64f03adf2c1a8bfae6bd9b4f556544e432b7c"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"1a059a8501e71b9823a617aca3d56f34ecaa05f1","unresolved":true,"context_lines":[{"line_number":287,"context_line":"            proxy_set_header Host $http_host;"},{"line_number":288,"context_line":"        }"},{"line_number":289,"context_line":"        {% endif %}"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        {% if enable_swift | bool %}# Region: {{ openstack_region_name }}, Service: swift"},{"line_number":292,"context_line":"        location {{ skyline_nginx_prefix }}/{{ openstack_region_name | lower }}/swift {"},{"line_number":293,"context_line":"            proxy_pass {{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_api_port }}/;"},{"line_number":294,"context_line":"            proxy_redirect {{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_api_port }}/ {{ skyline_nginx_prefix }}/{{ openstack_region_name | lower }}/swift/;"},{"line_number":295,"context_line":"            proxy_buffering off;"},{"line_number":296,"context_line":"            proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;"},{"line_number":297,"context_line":"            proxy_set_header X-Forwarded-Proto $scheme;"},{"line_number":298,"context_line":"            proxy_set_header X-Forwarded-Host $host;"},{"line_number":299,"context_line":"            proxy_set_header Host $http_host;"},{"line_number":300,"context_line":"        }"},{"line_number":301,"context_line":"        {% endif %}"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"e645cd0c_477f0d9f","line":302,"range":{"start_line":290,"start_character":0,"end_line":302,"end_character":0},"in_reply_to":"b804f8d4_e6d888db","updated":"2024-03-17 18:29:14.000000000","message":"Are you using the project id in the rgw urls? My problem right now is, that I would love to include that but have no way to test it right now. But if you can just post the location block here as a comment, I can have a look at it and maybe include it.","commit_id":"dab64f03adf2c1a8bfae6bd9b4f556544e432b7c"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"ec79cd5b7aa2d06d1ed9769c829397560677b07c","unresolved":true,"context_lines":[{"line_number":287,"context_line":"            proxy_set_header Host $http_host;"},{"line_number":288,"context_line":"        }"},{"line_number":289,"context_line":"        {% endif %}"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        {% if enable_swift | bool %}# Region: {{ openstack_region_name }}, Service: swift"},{"line_number":292,"context_line":"        location {{ skyline_nginx_prefix }}/{{ openstack_region_name | lower }}/swift {"},{"line_number":293,"context_line":"            proxy_pass {{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_api_port }}/;"},{"line_number":294,"context_line":"            proxy_redirect {{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_api_port }}/ {{ skyline_nginx_prefix }}/{{ openstack_region_name | lower }}/swift/;"},{"line_number":295,"context_line":"            proxy_buffering off;"},{"line_number":296,"context_line":"            proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;"},{"line_number":297,"context_line":"            proxy_set_header X-Forwarded-Proto $scheme;"},{"line_number":298,"context_line":"            proxy_set_header X-Forwarded-Host $host;"},{"line_number":299,"context_line":"            proxy_set_header Host $http_host;"},{"line_number":300,"context_line":"        }"},{"line_number":301,"context_line":"        {% endif %}"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"33e0bd5c_9a8d0767","line":302,"range":{"start_line":290,"start_character":0,"end_line":302,"end_character":0},"in_reply_to":"c3ac1bad_8635e6bb","updated":"2024-03-20 06:57:58.000000000","message":"@maximilian.sesterhenn@epg.com I included your snippet. Since we can not have swift and ceph-rgw at the same time (we would have the location block twice for the same location) the swift version will win over ceph-rgw. But I think in real live you neither can\u0027t have both.","commit_id":"dab64f03adf2c1a8bfae6bd9b4f556544e432b7c"},{"author":{"_account_id":35638,"deleted":true},"change_message_id":"bb318a7ab863b71ab9f6badec0c547378c6980fd","unresolved":true,"context_lines":[{"line_number":287,"context_line":"            proxy_set_header Host $http_host;"},{"line_number":288,"context_line":"        }"},{"line_number":289,"context_line":"        {% endif %}"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        {% if enable_swift | bool %}# Region: {{ openstack_region_name }}, Service: swift"},{"line_number":292,"context_line":"        location {{ skyline_nginx_prefix }}/{{ openstack_region_name | lower }}/swift {"},{"line_number":293,"context_line":"            proxy_pass {{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_api_port }}/;"},{"line_number":294,"context_line":"            proxy_redirect {{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_api_port }}/ {{ skyline_nginx_prefix }}/{{ openstack_region_name | lower }}/swift/;"},{"line_number":295,"context_line":"            proxy_buffering off;"},{"line_number":296,"context_line":"            proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;"},{"line_number":297,"context_line":"            proxy_set_header X-Forwarded-Proto $scheme;"},{"line_number":298,"context_line":"            proxy_set_header X-Forwarded-Host $host;"},{"line_number":299,"context_line":"            proxy_set_header Host $http_host;"},{"line_number":300,"context_line":"        }"},{"line_number":301,"context_line":"        {% endif %}"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"b804f8d4_e6d888db","line":302,"range":{"start_line":290,"start_character":0,"end_line":302,"end_character":0},"in_reply_to":"c9b69b2c_0ad4c0fa","updated":"2024-03-17 17:40:12.000000000","message":"I extended our installation yesterday, so I can say for sure that it\u0027s just a matter of configuring nginx to proxy our requests and modify the skyline config to activate that feature when ceph rgw is enabled. I would offer to post a patchset with the changes that I\u0027m using but I\u0027m not sure whether I can do that since I\u0027m not the creator of this change.","commit_id":"dab64f03adf2c1a8bfae6bd9b4f556544e432b7c"},{"author":{"_account_id":35638,"deleted":true},"change_message_id":"c78551083c1590587062d9e015ad231aac6bbbcb","unresolved":true,"context_lines":[{"line_number":287,"context_line":"            proxy_set_header Host $http_host;"},{"line_number":288,"context_line":"        }"},{"line_number":289,"context_line":"        {% endif %}"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        {% if enable_swift | bool %}# Region: {{ openstack_region_name }}, Service: swift"},{"line_number":292,"context_line":"        location {{ skyline_nginx_prefix }}/{{ openstack_region_name | lower }}/swift {"},{"line_number":293,"context_line":"            proxy_pass {{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_api_port }}/;"},{"line_number":294,"context_line":"            proxy_redirect {{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_api_port }}/ {{ skyline_nginx_prefix }}/{{ openstack_region_name | lower }}/swift/;"},{"line_number":295,"context_line":"            proxy_buffering off;"},{"line_number":296,"context_line":"            proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;"},{"line_number":297,"context_line":"            proxy_set_header X-Forwarded-Proto $scheme;"},{"line_number":298,"context_line":"            proxy_set_header X-Forwarded-Host $host;"},{"line_number":299,"context_line":"            proxy_set_header Host $http_host;"},{"line_number":300,"context_line":"        }"},{"line_number":301,"context_line":"        {% endif %}"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"c3ac1bad_8635e6bb","line":302,"range":{"start_line":290,"start_character":0,"end_line":302,"end_character":0},"in_reply_to":"e645cd0c_477f0d9f","updated":"2024-03-17 19:44:53.000000000","message":"nginx.conf.j2:\n\n        {% if enable_ceph_rgw | bool %}# Region: {{ openstack_region_name }}, Service: ceph_rgw\n        location {{ skyline_nginx_prefix }}/{{ openstack_region_name | lower }}/swift {\n            proxy_pass {{ internal_protocol }}://{{ ceph_rgw_internal_fqdn }}:{{ ceph_rgw_port }}/{{ \u0027swift\u0027 if not ceph_rgw_swift_compatibility | bool }};\n            proxy_redirect {{ internal_protocol }}://{{ ceph_rgw_internal_fqdn }}:{{ ceph_rgw_port }}/{{ \u0027swift\u0027 if not ceph_rgw_swift_compatibility | bool }} {{ skyline_nginx_prefix }}/{{ openstack_region_name | lower }}/swift/;\n            proxy_buffering off;\n            proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;\n            proxy_set_header X-Forwarded-Proto $scheme;\n            proxy_set_header X-Forwarded-Host $host;\n            proxy_set_header Host $http_host;\n        }\n        {% endif %}\n\n        \nskyline.yaml.j2:\n\n{% if enable_swift | bool or enable_ceph_rgw | bool %}\n    object-store: swift\n{% endif %}\n\nYes, we have the project id in the URL (ceph_rgw_swift_account_in_url\u003dTrue).\nSkyline already has Ceph RGW support and seems to automatically request the correct URL.","commit_id":"dab64f03adf2c1a8bfae6bd9b4f556544e432b7c"}]}