)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"894786772ef025f87263c153421ceda1b0e0d3bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9f3457ab_a569e59a","updated":"2024-02-22 16:55:09.000000000","message":"Going to expose this as a config option instead.","commit_id":"bdb01008df55fcf57bab84f0d9d257337008087b"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"6a81d1a3d2d46c14fa20d4aec79b9d01eca37afd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8b3d5141_8dd91beb","updated":"2024-02-23 10:05:33.000000000","message":"Hit a rabbit timeout in the slurp job. Took the opportunity to reword the release note.","commit_id":"336e2b7938d366ef82bf1d6ca3d193d4d68d9942"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"ecf38a567a8a658dad9c0a6f94333b772ddabd93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"00c537cb_df6da217","updated":"2024-02-27 16:31:50.000000000","message":"recheck","commit_id":"60da5c5bdd74071a5b3dd803571e09e6797a7d18"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3a62c6ea1d0304557fd78cf995c88bf31ff49ac2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6dff61ad_ec700e48","updated":"2024-02-23 10:40:09.000000000","message":"we should maybe also actually configure ironic-inspector if it get\u0027s enabled, no?\n\ne.g. fix the default broken transport_url from \"rabbit://\" to \"fake://\".\n\nSee https://bugs.launchpad.net/kolla-ansible/+bug/2054705 for details.","commit_id":"60da5c5bdd74071a5b3dd803571e09e6797a7d18"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"166dd8ce43716a397996915a58057c64a9c72436","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"71ef31bd_0863ae8c","in_reply_to":"57457d14_64c96c76","updated":"2024-02-28 10:24:36.000000000","message":"Done","commit_id":"60da5c5bdd74071a5b3dd803571e09e6797a7d18"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"37693e9c5669ffc9168c04ce0e0420ef7770a216","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"903bbf40_74fb0919","in_reply_to":"6dff61ad_ec700e48","updated":"2024-02-23 10:59:07.000000000","message":"Cheers, I checked this out and seems like bifrost is overriding the default here:\n\nhttps://github.com/openstack/bifrost/blob/7a6af41a265cb641f5900afe1ab8b8abb31dc2c0/playbooks/roles/bifrost-ironic-install/templates/ironic-inspector.conf.j2#L18","commit_id":"60da5c5bdd74071a5b3dd803571e09e6797a7d18"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"a4c3e851065675c57a46db535bdcc9bbb14c5578","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"57457d14_64c96c76","in_reply_to":"903bbf40_74fb0919","updated":"2024-02-28 10:22:57.000000000","message":"Sven, are you happy to mark this one as resolved since bifrost seems to use the fake transport url?","commit_id":"60da5c5bdd74071a5b3dd803571e09e6797a7d18"}],"ansible/roles/bifrost/defaults/main.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5ebf1a613360f7a92a9fd7f897a55ead3786b5fb","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"bifrost_deploy_verbosity: \"-vvvv\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Whether to enable the legacy ironic-inspector service"},{"line_number":16,"context_line":"bifrost_enable_ironic_inspector: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"75bd9749_83379045","line":15,"updated":"2024-02-22 17:39:31.000000000","message":"should we add a TODO note about dropping legacy?","commit_id":"336e2b7938d366ef82bf1d6ca3d193d4d68d9942"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b89345c0fbeb40c0e4f4f22d60c66c7c515562fc","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"bifrost_deploy_verbosity: \"-vvvv\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Whether to enable the legacy ironic-inspector service"},{"line_number":16,"context_line":"bifrost_enable_ironic_inspector: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"42ae559b_5b9de241","line":15,"in_reply_to":"0ca53d5c_ed591b83","updated":"2024-02-28 09:01:28.000000000","message":"personally I\u0027m in favor of a TODO that links to a bug report somewhere, so it\u0027s easily tracked.\n\nWe have a lot of todos without those and most times I check them, they or the code in question can be removed, because nobody ever did the todo checking because it\u0027s to cumbersome to chase git commit history. a bug report link on the other hand should have actual actionable information.","commit_id":"336e2b7938d366ef82bf1d6ca3d193d4d68d9942"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"185bf2c0031f7d937e7b3777537674a845c46692","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"bifrost_deploy_verbosity: \"-vvvv\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Whether to enable the legacy ironic-inspector service"},{"line_number":16,"context_line":"bifrost_enable_ironic_inspector: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8e123222_1ab936e4","line":15,"in_reply_to":"42ae559b_5b9de241","updated":"2024-02-28 10:21:36.000000000","message":"I\u0027ve added a NOTE as in my mind it is not really a TODO since we are just using a feature in Bifrost. There is no real rush to remove it until Bifrost drops support.","commit_id":"336e2b7938d366ef82bf1d6ca3d193d4d68d9942"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"37693e9c5669ffc9168c04ce0e0420ef7770a216","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"bifrost_deploy_verbosity: \"-vvvv\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Whether to enable the legacy ironic-inspector service"},{"line_number":16,"context_line":"bifrost_enable_ironic_inspector: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0ca53d5c_ed591b83","line":15,"in_reply_to":"7018946a_68a2ffac","updated":"2024-02-23 10:59:07.000000000","message":"Could add a note if people think it is useful. I believe the bifrost plan is to drop support for enable_inspector once native in-band inspection has reached feature parity. Do we need to a reminder or should we just look out for this change in bifrost release notes?","commit_id":"336e2b7938d366ef82bf1d6ca3d193d4d68d9942"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3a62c6ea1d0304557fd78cf995c88bf31ff49ac2","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"bifrost_deploy_verbosity: \"-vvvv\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Whether to enable the legacy ironic-inspector service"},{"line_number":16,"context_line":"bifrost_enable_ironic_inspector: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7018946a_68a2ffac","line":15,"in_reply_to":"75bd9749_83379045","updated":"2024-02-23 10:40:09.000000000","message":"you can watch this story I guess, for tracking progress of the merging of ironic-inspector into ironic (not sure if this will still be updated in the future):\n\nhttps://storyboard.openstack.org/#!/story/2010275\n\nthe spec is here: https://specs.openstack.org/openstack/ironic-specs/specs/approved/merge-inspector.html (this has also some more links, there doesn\u0027t seem to be a good gerrit topic to follow here unfortunately, or I overlooked it).","commit_id":"336e2b7938d366ef82bf1d6ca3d193d4d68d9942"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"166dd8ce43716a397996915a58057c64a9c72436","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"bifrost_deploy_verbosity: \"-vvvv\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Whether to enable the legacy ironic-inspector service"},{"line_number":16,"context_line":"bifrost_enable_ironic_inspector: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ae8399b3_1ebf4fee","line":15,"in_reply_to":"8e123222_1ab936e4","updated":"2024-02-28 10:24:36.000000000","message":"Done","commit_id":"336e2b7938d366ef82bf1d6ca3d193d4d68d9942"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"75fde60123edf2a6e71db2ec4cb59b4d62807903","unresolved":true,"context_lines":[{"line_number":17,"context_line":"# inspection reaches feature parity. Please see:"},{"line_number":18,"context_line":"# https://bugs.launchpad.net/kolla/+bug/2054685 which contains links for"},{"line_number":19,"context_line":"# tracking the progress."},{"line_number":20,"context_line":"bifrost_enable_ironic_inspector: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b321ec15_4e9f85dc","line":20,"updated":"2024-02-28 14:07:49.000000000","message":"Does it make any sense to default to false now?","commit_id":"3eb56860a97804037f846af3806f4d4872d2a99d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f726b71e00b6bead4d25d04985727698c72aeeb8","unresolved":true,"context_lines":[{"line_number":17,"context_line":"# inspection reaches feature parity. Please see:"},{"line_number":18,"context_line":"# https://bugs.launchpad.net/kolla/+bug/2054685 which contains links for"},{"line_number":19,"context_line":"# tracking the progress."},{"line_number":20,"context_line":"bifrost_enable_ironic_inspector: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"549e6878_74d168ee","line":20,"in_reply_to":"3fac2c5e_f880080a","updated":"2024-02-28 14:23:01.000000000","message":"I think majority of Kayobe users use Inspector rules - so that change basically breaks them - I would default to true until Ironic gets feature parity.","commit_id":"3eb56860a97804037f846af3806f4d4872d2a99d"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"e0424a65dd29fe251da24e5be333d3d510078563","unresolved":true,"context_lines":[{"line_number":17,"context_line":"# inspection reaches feature parity. Please see:"},{"line_number":18,"context_line":"# https://bugs.launchpad.net/kolla/+bug/2054685 which contains links for"},{"line_number":19,"context_line":"# tracking the progress."},{"line_number":20,"context_line":"bifrost_enable_ironic_inspector: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8657b4c2_c788ee70","line":20,"in_reply_to":"549e6878_74d168ee","updated":"2024-02-28 15:01:28.000000000","message":"Sounds sensible. I\u0027ve updated the default to true.","commit_id":"3eb56860a97804037f846af3806f4d4872d2a99d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cb626c2bb386c5756625069b6991103a44c0bf01","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# inspection reaches feature parity. Please see:"},{"line_number":18,"context_line":"# https://bugs.launchpad.net/kolla/+bug/2054685 which contains links for"},{"line_number":19,"context_line":"# tracking the progress."},{"line_number":20,"context_line":"bifrost_enable_ironic_inspector: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8e2f5994_6c4838aa","line":20,"in_reply_to":"8657b4c2_c788ee70","updated":"2024-02-29 13:20:46.000000000","message":"Done","commit_id":"3eb56860a97804037f846af3806f4d4872d2a99d"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"6006f53452a9fa732c52217a07a44f844d281c3c","unresolved":true,"context_lines":[{"line_number":17,"context_line":"# inspection reaches feature parity. Please see:"},{"line_number":18,"context_line":"# https://bugs.launchpad.net/kolla/+bug/2054685 which contains links for"},{"line_number":19,"context_line":"# tracking the progress."},{"line_number":20,"context_line":"bifrost_enable_ironic_inspector: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fac2c5e_f880080a","line":20,"in_reply_to":"b321ec15_4e9f85dc","updated":"2024-02-28 14:12:44.000000000","message":"Happy to make it default to true, if you think that would be better.","commit_id":"3eb56860a97804037f846af3806f4d4872d2a99d"}],"ansible/roles/bifrost/templates/bifrost.yml.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5ebf1a613360f7a92a9fd7f897a55ead3786b5fb","unresolved":true,"context_lines":[{"line_number":35,"context_line":"tls_root: \"/etc/bifrost-certs\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Whether to enable the legacy ironic-inspector service."},{"line_number":38,"context_line":"enable_inspector: \"{{ bifrost_enable_ironic_inspector }}\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"94d72364_907d7dc2","line":38,"updated":"2024-02-22 17:39:31.000000000","message":"same question about set to true later?","commit_id":"336e2b7938d366ef82bf1d6ca3d193d4d68d9942"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cb626c2bb386c5756625069b6991103a44c0bf01","unresolved":false,"context_lines":[{"line_number":35,"context_line":"tls_root: \"/etc/bifrost-certs\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Whether to enable the legacy ironic-inspector service."},{"line_number":38,"context_line":"enable_inspector: \"{{ bifrost_enable_ironic_inspector }}\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"8ab65c9c_2e4e9b3a","line":38,"in_reply_to":"94d72364_907d7dc2","updated":"2024-02-29 13:20:46.000000000","message":"Done","commit_id":"336e2b7938d366ef82bf1d6ca3d193d4d68d9942"}]}