)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"eb8a77925e2028c99ea65c6dafe2f46e26c74d40","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Matus Jenca \u003cmatus.jenca@dnation.cloud\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-02-23 10:59:33 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add backend TLS between MariaDB and ProxySQL"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds TLS connection between ProxySQL and MariaDB."},{"line_number":10,"context_line":"Frontend TLS ( between services and ProxySQL) will be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c3b4177c_1a953b42","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":44},"updated":"2024-02-23 12:15:21.000000000","message":"is that only for ProxySQL scenario?","commit_id":"f32ae0ae6b801118a05a30edc74eae4c50d0c225"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"c5ccab09762549f0cc3f67a1471b0f4a814713e8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matus Jenca \u003cmatus.jenca@dnation.cloud\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-02-23 10:59:33 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add backend TLS between MariaDB and ProxySQL"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds TLS connection between ProxySQL and MariaDB."},{"line_number":10,"context_line":"Frontend TLS ( between services and ProxySQL) will be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9c1f416b_b792a705","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":44},"in_reply_to":"c3b4177c_1a953b42","updated":"2024-02-23 13:09:25.000000000","message":"Yes. This is only between proxysql and mariadb as in [this article](https://proxysql.com/blog/ssl-at-proxysql-part1/)\n\nI found that MariaDB tls was done [here](https://review.opendev.org/c/openstack/kolla-ansible/+/836791), but proxysql was suggested instead. As the PR hasn\u0027t been active for nearly 2 years, I created a new one with proxysql","commit_id":"f32ae0ae6b801118a05a30edc74eae4c50d0c225"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ef18d2610e4e161ef3a54d4f9443baa7b2616bc2","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Frontend TLS ( between services and ProxySQL) will be"},{"line_number":11,"context_line":"added in another commit."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Parially Implements: mariadb-ssl-support"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I154cbb096469c5515c9d8156c2c1c5dd07b95849"},{"line_number":16,"context_line":"Signed-off-by: Matus Jenca \u003cmatus.jenca@dnation.cloud\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"758e7719_53dece21","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":8},"updated":"2024-03-28 11:15:36.000000000","message":"nit: Partially","commit_id":"0439ac5656a10d602731020a45042a0992977135"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22310ae59aac14d1f9bf20991698b40a935a80f0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Frontend TLS ( between services and ProxySQL) will be"},{"line_number":11,"context_line":"added in another commit."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Parially Implements: mariadb-ssl-support"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I154cbb096469c5515c9d8156c2c1c5dd07b95849"},{"line_number":16,"context_line":"Signed-off-by: Matus Jenca \u003cmatus.jenca@dnation.cloud\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"900ff83f_01183568","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":8},"in_reply_to":"758e7719_53dece21","updated":"2024-04-02 10:16:23.000000000","message":"Acknowledged","commit_id":"0439ac5656a10d602731020a45042a0992977135"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5358fdcc89d1984879dad6d806f1f1667fc77d60","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Frontend TLS ( between services and ProxySQL) will be"},{"line_number":11,"context_line":"added in another commit."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/913724"},{"line_number":14,"context_line":"Parialy Implements: mariadb-ssl-support"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I154cbb096469c5515c9d8156c2c1c5dd07b95849"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"8d994f72_e4adde30","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":2},"updated":"2024-07-29 08:06:19.000000000","message":"nit: not necessary, just rebase on top of this change and zuul should figure it out as long as the dependency is in the same repository.\n\nwe only need Depends-On for cross repo dependencies.","commit_id":"70ef75644334d79f3edff79d5522e175801db507"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"e34c4accd315ce9534c19742bef75cf721c0dac3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Frontend TLS ( between services and ProxySQL) will be"},{"line_number":11,"context_line":"added in another commit."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/913724"},{"line_number":14,"context_line":"Parialy Implements: mariadb-ssl-support"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I154cbb096469c5515c9d8156c2c1c5dd07b95849"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"1139396b_f2aedf19","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":2},"in_reply_to":"8d994f72_e4adde30","updated":"2024-07-29 10:01:34.000000000","message":"Done","commit_id":"70ef75644334d79f3edff79d5522e175801db507"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fa16e05f4257374da76c641ebd9d4db9aba85328","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Frontend TLS ( between services and ProxySQL) will be"},{"line_number":11,"context_line":"added in another commit."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Parialy Implements: mariadb-ssl-support"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I154cbb096469c5515c9d8156c2c1c5dd07b95849"},{"line_number":16,"context_line":"Signed-off-by: Matus Jenca \u003cmatus.jenca@dnation.cloud\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"e7988bd3_89641371","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":7},"updated":"2024-07-30 15:46:43.000000000","message":"nit: Typo \"Partially\"","commit_id":"4cfaca76865f33c94eb859ac7e8f60020f1dadc7"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"343a1ed0eed95e94350fcd386752108d727900cf","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Frontend TLS ( between services and ProxySQL) will be"},{"line_number":11,"context_line":"added in another commit."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Parialy Implements: mariadb-ssl-support"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I154cbb096469c5515c9d8156c2c1c5dd07b95849"},{"line_number":16,"context_line":"Signed-off-by: Matus Jenca \u003cmatus.jenca@dnation.cloud\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"8ad53fdc_b10c21e9","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":7},"in_reply_to":"e7988bd3_89641371","updated":"2024-08-01 13:38:20.000000000","message":"Done","commit_id":"4cfaca76865f33c94eb859ac7e8f60020f1dadc7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c834114a01d98063a04a005d93a259b2ebcc9908","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6602b90d_87121c96","updated":"2024-03-25 13:32:03.000000000","message":"Can u provide proxysql role patch in same (this) chain and add some test which will verify implementation ?","commit_id":"416abd49e6a7291a73fc5af7e46d7701d5af9809"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b3e1a0fb6422e274d6a2f712537bb48ee8eb70d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1311a7ae_529b3e90","updated":"2024-02-23 13:47:23.000000000","message":"Nice to see that my proxysql stuff is used 😊, will review later. Thanks !","commit_id":"416abd49e6a7291a73fc5af7e46d7701d5af9809"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ef18d2610e4e161ef3a54d4f9443baa7b2616bc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"44c6fa44_7a9859d1","updated":"2024-03-28 11:15:36.000000000","message":"-1 because I\u0027m not sure if we really want to basically duplicate the service-cert-copy role into it\u0027s own mariadb task. At least I want to have some more opinions on this topic.","commit_id":"0439ac5656a10d602731020a45042a0992977135"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22310ae59aac14d1f9bf20991698b40a935a80f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a93b53dc_e0e85e3e","updated":"2024-04-02 10:16:23.000000000","message":"thanks for the review","commit_id":"0439ac5656a10d602731020a45042a0992977135"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"57bb6f772991883515974c483db73362a339de67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3a4b8127_53fbc783","updated":"2024-04-15 08:55:00.000000000","message":"Thanks for reusing the service-cert-copy role instead.\n\nAlmost there.","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1bd9c64abbad6bbde228893a6f9c20692788299d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a82da6e9_faeabf7e","updated":"2024-04-15 14:31:30.000000000","message":"service-cert-copy changes should go to a separate patch","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"71380784fbe9b3de3375eb0625bf9172ed775507","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1e3df012_3aeaccad","in_reply_to":"a82da6e9_faeabf7e","updated":"2024-04-16 11:35:29.000000000","message":"I made a new patch for it. \nhttps://review.opendev.org/c/openstack/kolla-ansible/+/915901?usp\u003dmerge-conflict","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b4cb1e61f908081771db0fc65b340be0e5a1333e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0528c624_cc1676e9","updated":"2024-04-19 10:29:55.000000000","message":"most comments got addressed I think. Thanks! Please also address the rest (e.g. testing) and add a\n\"Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/915901\" to your commit message. This way gerrit nows about the dependency and you don\u0027t need to carry this patch in both changesets.","commit_id":"719221beb247d14c0cfbc6dd1bdd42bbd70d143e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"17c882e8fe2082fa1e1d77025b0b6282d05f68c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5fd1b806_1f1409b9","in_reply_to":"0528c624_cc1676e9","updated":"2024-04-23 15:30:15.000000000","message":"I think I addressed all the of them now.","commit_id":"719221beb247d14c0cfbc6dd1bdd42bbd70d143e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fc9cba80233f8a761b4924e33ac13efdf3bd7b17","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"bc302943_9293c76c","updated":"2024-04-24 09:27:31.000000000","message":"LGTM, apart from one comment (see below).\nAlso we need to look at the cells jobs, which are non voting, as those failed and now execute the proxysql testcase.","commit_id":"41fc59d5c94510ba5f90adac648e2e303342a548"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"1e2403ec6c8907df12626f39e45c1611e03b233c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"976c2e93_bd559c5a","in_reply_to":"66a36e29_3dc19f28","updated":"2024-05-14 07:14:40.000000000","message":"Acknowledged","commit_id":"41fc59d5c94510ba5f90adac648e2e303342a548"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"6c1e3d0b11c5d2e4596ec5a54ef1e38c491da446","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"66a36e29_3dc19f28","in_reply_to":"a66c1135_18607d33","updated":"2024-04-26 15:46:26.000000000","message":"Im looking at the cells scenario in base.yaml and it seems that it is to test nova.\n```\n- job:\n    name: kolla-ansible-cells-base\n    parent: kolla-ansible-base\n    voting: false\n    files:\n      - ^requirements-core.yml\n      - ^ansible/roles/nova/\n      - ^tests/test-core-openstack.sh\n```\n\nIt doesn\u0027t seem to have anything with proxysql. Should we test it somewhere different?","commit_id":"41fc59d5c94510ba5f90adac648e2e303342a548"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"95b2c6d90fba781119b1d12c13db942f0a384250","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"a66c1135_18607d33","in_reply_to":"bc302943_9293c76c","updated":"2024-04-24 13:59:23.000000000","message":"I see the job failed. I don\u0027t understand why ` \u0027kola_ansible_src_dir\u0027 is undefined`\nbecause the variable is used in other jobs and it works there. Am I missing something?","commit_id":"41fc59d5c94510ba5f90adac648e2e303342a548"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"34b44bbb6234a50f10c63f2692888d6736f4f3b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"0b5dcefe_4099c68a","updated":"2024-05-21 12:56:20.000000000","message":"Thanks for the review","commit_id":"6abc47de2b9e1750b7033375b3a4ba7e8c7c495f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7e3a5ffbc85c5ae604795f42a78311bf837775ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"d94ce14e_0b48be3c","updated":"2024-05-21 09:32:22.000000000","message":"This afaik needs ProxySQL to be enabled, but instead currently unconditionally enables TLS for mariadb, even if proxysql is not enabled, which is the default.\n\nI think this change should depend on https://review.opendev.org/c/openstack/kolla-ansible/+/913724 which enables proxysql globally for mariadb usage.","commit_id":"6abc47de2b9e1750b7033375b3a4ba7e8c7c495f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7741a2c5f49263ceb4563f3be4f884024280149c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"96f18bd7_30d8b57a","updated":"2024-05-21 09:20:00.000000000","message":"looking into task failure:\n\n```\n\nTASK [mariadb : Fail when MariaDB services are not synced across the whole cluster] ***\n\ntask path: /home/zuul/kolla-ansible-venv/share/kolla-ansible/ansible/roles/mariadb/tasks/lookup_cluster.yml:72\n\nFriday 10 May 2024  09:27:58 +0000 (0:00:00.168)       0:01:19.596 ************ \n\nfatal: [primary]: FAILED! \u003d\u003e {\n\n    \"changed\": false,\n\n    \"msg\": \"MariaDB cluster is not synced. Please wait for WSREP sync before proceeding.\"\n```\n\nin job kolla-ansible-rocky9-mariadb (non voting).","commit_id":"6abc47de2b9e1750b7033375b3a4ba7e8c7c495f"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"c9cece2a261a9584d85174205ef72392a63e585c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"87bd56c7_44a6052b","in_reply_to":"96f18bd7_30d8b57a","updated":"2024-07-23 13:23:52.000000000","message":"Done","commit_id":"6abc47de2b9e1750b7033375b3a4ba7e8c7c495f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"862f3174ba48e9775295aecea56ccf2f64091ba6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"a50db2ea_10a6c5f5","updated":"2024-05-28 09:48:22.000000000","message":"mutlinode ipv6 scenario fails during ssh connect with:\n\nTimeout when waiting for fd::2:6032 (for all three respective nodes).\n\nMight or might not be related.","commit_id":"efad4f26bdd6587d572307ca84dc16a3bfd15c1d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2a9660cba06f16534e670655ca7d47d9f0b75ca7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"77f6a9f6_8100d25e","updated":"2024-05-27 15:47:52.000000000","message":"recheck CI issue with requests and docker-py versions should be fixed.","commit_id":"efad4f26bdd6587d572307ca84dc16a3bfd15c1d"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"ad987633eda2be990f1173291a5ea665692ed484","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"bd014f34_e87e31d7","in_reply_to":"7ed7c679_b6cb0808","updated":"2024-07-26 09:20:26.000000000","message":"I discovered ansible has `ipwrap` filter just for this. I\u0027m marking this comment resolved, the ipv6 pipelines are OK now.","commit_id":"efad4f26bdd6587d572307ca84dc16a3bfd15c1d"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"8fd2de7ce3d5f5e8056b422d57f0f1657df1e015","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"7ed7c679_b6cb0808","in_reply_to":"a50db2ea_10a6c5f5","updated":"2024-07-23 15:01:09.000000000","message":"I found out why IPv6 pipelines do not work. It\u0027s a problem with proxysql.yaml\n```yaml\n   mysql_ifaces: \"{{ api_interface_address }}:{{ proxysql_admin_port }};{{ kolla_internal_vip_address }}:{{ proxysql_admin_port }};/var/lib/kolla/proxysql/admin.sock\"\n\n```\n this will render the ifaces as `fd::2:6032` but the correct format would be `[fd::2]:6032` see https://en.wikipedia.org/wiki/IPv6#Addressing\n \n I think I can fix this but I will make a different patch for it, because it\u0027s unrelated to proxysql.\n \n Note: I can also see that ipv6 pipelines fail in [this proxysql patch](https://review.opendev.org/c/openstack/kolla-ansible/+/913724 as well)","commit_id":"efad4f26bdd6587d572307ca84dc16a3bfd15c1d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ddfbbdd590ff15746d19e4fd0ac809c161c50788","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"4b869d53_fb110d38","updated":"2024-07-11 08:25:54.000000000","message":"needs some work on the logic around service-cert-copy, see my comment for details where it fails.","commit_id":"21de08733a93ad85b18abf3652fa170f718635dd"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"15982a9961e7576125a031a023af9be993521257","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":25,"id":"6467d84c_650fdfe0","updated":"2024-07-17 13:26:27.000000000","message":"recheck timeout","commit_id":"c21ec488e9acd2fcc9a81a2c976dae962b14de73"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"391d54fdac4c3e03589087e1a89cc5a899f8d83a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":25,"id":"fe3f6d65_9f8ded4d","in_reply_to":"6467d84c_650fdfe0","updated":"2024-07-17 13:34:17.000000000","message":"I will try to run Zuul one more time, because many errors were just time outs. I will investigate if it fails again","commit_id":"c21ec488e9acd2fcc9a81a2c976dae962b14de73"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"c9cece2a261a9584d85174205ef72392a63e585c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"c75a5590_7255dd92","in_reply_to":"fe3f6d65_9f8ded4d","updated":"2024-07-23 13:23:52.000000000","message":"Done","commit_id":"c21ec488e9acd2fcc9a81a2c976dae962b14de73"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"e34c4accd315ce9534c19742bef75cf721c0dac3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"e0f70a2d_973c47e4","updated":"2024-07-29 10:01:34.000000000","message":"Thanks for the review","commit_id":"4cfaca76865f33c94eb859ac7e8f60020f1dadc7"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"142e0cd89a118f6e79ad7db1367a26a1bac6172c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":33,"id":"94bc85af_09b0c533","updated":"2024-07-29 12:40:46.000000000","message":"recheck ansible-galaxy timeout","commit_id":"4cfaca76865f33c94eb859ac7e8f60020f1dadc7"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"9d42107a2121f85517d37c9dbd2098d61df1d264","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":33,"id":"a68011e9_e7688698","updated":"2024-07-30 13:39:51.000000000","message":"recheck timeout","commit_id":"4cfaca76865f33c94eb859ac7e8f60020f1dadc7"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"9d42107a2121f85517d37c9dbd2098d61df1d264","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"1ed57dec_0d286421","in_reply_to":"94bc85af_09b0c533","updated":"2024-07-30 13:39:51.000000000","message":"Done","commit_id":"4cfaca76865f33c94eb859ac7e8f60020f1dadc7"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"343a1ed0eed95e94350fcd386752108d727900cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"f68fe5ff_696b350f","in_reply_to":"a68011e9_e7688698","updated":"2024-08-01 13:38:20.000000000","message":"Done","commit_id":"4cfaca76865f33c94eb859ac7e8f60020f1dadc7"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ea652cc95c4fb4f52ccd0e5d29afcdc6117232e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"d88baa1d_cd81de0a","updated":"2024-08-02 15:33:05.000000000","message":"code LGTM now, but there are quite some (non-voting) failures in CI. Let\u0027s investigate those first.","commit_id":"29d7d89a32222f7d83f1f56807f9879dd92c7861"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5fb5a393793a59ab14a80b9dcdc268d8094a3d08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"6729b79b_fcc2b1ab","updated":"2024-08-02 15:43:10.000000000","message":"there\u0027s a bug in `test-octavia.sh` where the code is not waiting long enough for a VM being created/a port being assigned in job kolla-ansible-ubuntu-octavia (non-voting)FAILURE\n\nI created a bug for it, which has all the details:\n\nhttps://bugs.launchpad.net/kolla-ansible/+bug/2075966","commit_id":"29d7d89a32222f7d83f1f56807f9879dd92c7861"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"293f593265a40dcdd02bbbc7c40e1aa3d798c887","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":42,"id":"9277db46_45217543","updated":"2024-08-27 16:23:04.000000000","message":"mariadb clustercheck needs to be fixed/changed for this to work imho:\n\n```\n+ sudo -E kolla_set_configs\nINFO:__main__:Loading config file at /var/lib/kolla/config_files/config.json\nERROR:__main__:Unexpected error:\nTraceback (most recent call last):\n  File \"/usr/local/bin/kolla_set_configs\", line 431, in main\n    config \u003d load_config()\n  File \"/usr/local/bin/kolla_set_configs\", line 293, in load_config\n    config \u003d load_from_file()\n  File \"/usr/local/bin/kolla_set_configs\", line 283, in load_from_file\n    with open(config_file) as f:\nFileNotFoundError: [Errno 2] No such file or directory: \u0027/var/lib/kolla/config_files/config.json\u0027\n+ check_docker_unhealthies\n++ sudo docker ps -a --format \u0027{{.Names}}\u0027 --filter health\u003dunhealthy\n+ unhealthy_containers\u003d\n+ [[ -n \u0027\u0027 ]]\n+ [[ -n mariadb_clustercheck ]]\n+ exit 1\n```\n\nfrom:\n\nhttps://zuul.opendev.org/t/openstack/build/45a3804c60c54f0289f184811f57e758\n\nthat is: kolla-ansible-ubuntu-mariadb (non-voting)FAILURE Task \nRun check-failure.sh script failed running on host primary","commit_id":"ee8c82c72c8d4265bf7e71d65b8a32cd53d90e82"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"17569b5a4409afc71e47ac9e008ab1663f6f511f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":42,"id":"9349770d_7322bc02","in_reply_to":"9277db46_45217543","updated":"2024-08-28 10:29:36.000000000","message":"Looking into it.\nI noticed that mariadb pipelines are failing [this patch](https://review.opendev.org/c/openstack/kolla-ansible/+/913724/6)  I see that `mariadb-clustercheck` container is disabled in this patch, but it\u0027s apparently its trying to start and [fails](https://b6b25c444f602a2193e4-25632cacac12665a0cc8d10743d2803a.ssl.cf5.rackcdn.com/909912/42/check/kolla-ansible-ubuntu-mariadb/45a3804/primary/logs/container_logs/mariadb_clustercheck.txt)\n\nIt looks like the container is not supposed to start but starts anyway","commit_id":"ee8c82c72c8d4265bf7e71d65b8a32cd53d90e82"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"b2cc73485d43f8668f7aac9f85d8cf269914dc25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"f48fa433_f1df72d8","in_reply_to":"9349770d_7322bc02","updated":"2024-08-30 07:16:12.000000000","message":"The pipelines are no longer failing","commit_id":"ee8c82c72c8d4265bf7e71d65b8a32cd53d90e82"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5503b3646d86ceaf332ec76a27c5ffefe533a529","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"ccf8ae20_866c21b3","updated":"2024-08-30 08:14:00.000000000","message":"LGTM now, also non voting mariadb jobs are no longer failing.","commit_id":"4e7917376396c21f5eca383ea23f4726788b75fb"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"01119ba7d3b3dd87077163a0b23b092fce35db70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"21c111f0_57f00249","updated":"2024-10-01 22:06:32.000000000","message":"recheck rocky unrelated","commit_id":"b2c119d6f9522bee43192e91d53b493865b1b4c2"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1a35c000ad1bb3058427de56b09ed1ff4b5ff807","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":50,"id":"012decb0_45fed4e5","updated":"2024-10-03 09:56:48.000000000","message":"recheck mariadb on rocky failed on reconfigure","commit_id":"d263b9550e749185215db9f31632a1428065ed76"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"01d2e19988aa2fdf8559d7955c97809e855825ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":56,"id":"22023f83_c6c4b48c","updated":"2024-10-25 19:42:17.000000000","message":"recheck mariadb reconfig unrelated fail","commit_id":"23413d4e0f74a8f94f8c5e1e5fceb61c7d7d8327"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1bd9c64abbad6bbde228893a6f9c20692788299d","unresolved":true,"context_lines":[{"line_number":94,"context_line":"database_connection_recycle_time: 10"},{"line_number":95,"context_line":"database_max_pool_size: 1"},{"line_number":96,"context_line":"database_tls_backend_enable: \"{{ kolla_enable_tls_backend }}\""},{"line_number":97,"context_line":"database_tls_backend_container_path: \"/etc/mariadb/certs\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"####################"},{"line_number":100,"context_line":"# Container engine options"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"352101bd_8c16bfc3","line":97,"range":{"start_line":97,"start_character":1,"end_line":97,"end_character":57},"updated":"2024-04-15 14:31:30.000000000","message":"is there a case when this would need to be customised by an operator?","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b4cb1e61f908081771db0fc65b340be0e5a1333e","unresolved":true,"context_lines":[{"line_number":94,"context_line":"database_connection_recycle_time: 10"},{"line_number":95,"context_line":"database_max_pool_size: 1"},{"line_number":96,"context_line":"database_tls_backend_enable: \"{{ kolla_enable_tls_backend }}\""},{"line_number":97,"context_line":"database_tls_backend_container_path: \"/etc/mariadb/certs\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"####################"},{"line_number":100,"context_line":"# Container engine options"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9049b48b_228b71f1","line":97,"range":{"start_line":97,"start_character":1,"end_line":97,"end_character":57},"in_reply_to":"352101bd_8c16bfc3","updated":"2024-04-19 10:29:55.000000000","message":"I don\u0027t think so? Do you have anything specific in mind?","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"d7f972c26420edb7374ff9a99db7721034bce84b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"database_connection_recycle_time: 10"},{"line_number":95,"context_line":"database_max_pool_size: 1"},{"line_number":96,"context_line":"database_tls_backend_enable: \"{{ kolla_enable_tls_backend }}\""},{"line_number":97,"context_line":"database_tls_backend_container_path: \"/etc/mariadb/certs\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"####################"},{"line_number":100,"context_line":"# Container engine options"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"a27e7a3a_4487917a","line":97,"range":{"start_line":97,"start_character":1,"end_line":97,"end_character":57},"in_reply_to":"45e9207d_2f8b2298","updated":"2024-04-23 10:20:27.000000000","message":"Acknowledged","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"bcaa450253ddfe49ccaca535817669005fe4527d","unresolved":true,"context_lines":[{"line_number":94,"context_line":"database_connection_recycle_time: 10"},{"line_number":95,"context_line":"database_max_pool_size: 1"},{"line_number":96,"context_line":"database_tls_backend_enable: \"{{ kolla_enable_tls_backend }}\""},{"line_number":97,"context_line":"database_tls_backend_container_path: \"/etc/mariadb/certs\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"####################"},{"line_number":100,"context_line":"# Container engine options"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"45e9207d_2f8b2298","line":97,"range":{"start_line":97,"start_character":1,"end_line":97,"end_character":57},"in_reply_to":"9049b48b_228b71f1","updated":"2024-04-23 10:20:07.000000000","message":"I removed the variable and make the certificates location its default value `/etc/mariadb/certs`. There\u0027s no reason for operator to change it right now.","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"},{"author":{"_account_id":37013,"name":"Ivan Vnučko","display_name":"Ivan Vnucko","email":"ivan@vnucko.com","username":"ivnucko"},"change_message_id":"4436d239a4c0443dfd158a3279facc7dfae066aa","unresolved":true,"context_lines":[{"line_number":93,"context_line":"database_port: \"3306\""},{"line_number":94,"context_line":"database_connection_recycle_time: 10"},{"line_number":95,"context_line":"database_max_pool_size: 1"},{"line_number":96,"context_line":"database_tls_backend_enable: \"{{ \u0027yes\u0027 if ((kolla_enable_tls_backend | bool ) and ( enable_proxysql | bool)) else \u0027no\u0027 }}\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"####################"},{"line_number":99,"context_line":"# Container engine options"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"b97cda07_eb7e8c86","line":96,"updated":"2024-07-23 07:05:53.000000000","message":"Could you rename this flag to \u0027database_enable_tls_backend\u0027 to be consistent with other backend TLS flags? It has a technical reason also - certificates role doesn\u0027t generate backend certificate if only these service level flags are set (\u003cservice\u003e_enable_tls_backend) and not the global kolla_enable_tls_backend and I addressed this in my CR with a task using pattern matching with _enable_tls_backend.","commit_id":"d4ed8349d1af85db974a4e5525c0f4647fb6fea3"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"7df6c27912cab56f21687377d3332e42115dc8dc","unresolved":false,"context_lines":[{"line_number":93,"context_line":"database_port: \"3306\""},{"line_number":94,"context_line":"database_connection_recycle_time: 10"},{"line_number":95,"context_line":"database_max_pool_size: 1"},{"line_number":96,"context_line":"database_tls_backend_enable: \"{{ \u0027yes\u0027 if ((kolla_enable_tls_backend | bool ) and ( enable_proxysql | bool)) else \u0027no\u0027 }}\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"####################"},{"line_number":99,"context_line":"# Container engine options"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"8c5b2049_1e91b6b0","line":96,"in_reply_to":"b97cda07_eb7e8c86","updated":"2024-07-23 10:35:03.000000000","message":"Done","commit_id":"d4ed8349d1af85db974a4e5525c0f4647fb6fea3"}],"ansible/roles/certificates/tasks/generate-backend.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"343a041b3dbcafb4a95201a4626159bd7556ad0b","unresolved":true,"context_lines":[{"line_number":77,"context_line":"      dest: \"{{ kolla_certificates_dir }}/rabbitmq-key.pem\""},{"line_number":78,"context_line":"  when:"},{"line_number":79,"context_line":"    - rabbitmq_enable_tls | bool"},{"line_number":80,"context_line":"- name: Copy backend TLS certificate and key for Mariadb"},{"line_number":81,"context_line":"  copy:"},{"line_number":82,"context_line":"    src: \"{{ item.src }}\""},{"line_number":83,"context_line":"    dest: \"{{ item.dest }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ca53614e_07288b2c","line":80,"updated":"2024-02-23 12:16:29.000000000","message":"add a newline before that task for visibility","commit_id":"f32ae0ae6b801118a05a30edc74eae4c50d0c225"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"c5ccab09762549f0cc3f67a1471b0f4a814713e8","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      dest: \"{{ kolla_certificates_dir }}/rabbitmq-key.pem\""},{"line_number":78,"context_line":"  when:"},{"line_number":79,"context_line":"    - rabbitmq_enable_tls | bool"},{"line_number":80,"context_line":"- name: Copy backend TLS certificate and key for Mariadb"},{"line_number":81,"context_line":"  copy:"},{"line_number":82,"context_line":"    src: \"{{ item.src }}\""},{"line_number":83,"context_line":"    dest: \"{{ item.dest }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"61fd5663_098ffa5b","line":80,"in_reply_to":"ca53614e_07288b2c","updated":"2024-02-23 13:09:25.000000000","message":"Acknowledged","commit_id":"f32ae0ae6b801118a05a30edc74eae4c50d0c225"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ef18d2610e4e161ef3a54d4f9443baa7b2616bc2","unresolved":true,"context_lines":[{"line_number":82,"context_line":"  copy:"},{"line_number":83,"context_line":"    src: \"{{ item.src }}\""},{"line_number":84,"context_line":"    dest: \"{{ item.dest }}\""},{"line_number":85,"context_line":"    remote_src: true"},{"line_number":86,"context_line":"  with_items:"},{"line_number":87,"context_line":"    - src: \"{{ kolla_tls_backend_cert }}\""},{"line_number":88,"context_line":"      dest: \"{{ kolla_certificates_dir }}/mariadb-cert.pem\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c3b2e296_b066194b","line":85,"range":{"start_line":85,"start_character":4,"end_line":85,"end_character":20},"updated":"2024-03-28 11:15:36.000000000","message":"are we certain that we don\u0027t need `mode: \"0660\"` here?","commit_id":"0439ac5656a10d602731020a45042a0992977135"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22310ae59aac14d1f9bf20991698b40a935a80f0","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  copy:"},{"line_number":83,"context_line":"    src: \"{{ item.src }}\""},{"line_number":84,"context_line":"    dest: \"{{ item.dest }}\""},{"line_number":85,"context_line":"    remote_src: true"},{"line_number":86,"context_line":"  with_items:"},{"line_number":87,"context_line":"    - src: \"{{ kolla_tls_backend_cert }}\""},{"line_number":88,"context_line":"      dest: \"{{ kolla_certificates_dir }}/mariadb-cert.pem\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ffd259b9_0bbd5991","line":85,"range":{"start_line":85,"start_character":4,"end_line":85,"end_character":20},"in_reply_to":"c3b2e296_b066194b","updated":"2024-04-02 10:16:23.000000000","message":"Acknowledged","commit_id":"0439ac5656a10d602731020a45042a0992977135"}],"ansible/roles/loadbalancer/tasks/config.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"57bb6f772991883515974c483db73362a339de67","unresolved":true,"context_lines":[{"line_number":141,"context_line":"  notify:"},{"line_number":142,"context_line":"    - Restart haproxy container"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"- name: DEBUG PROXYSQL CONFIG"},{"line_number":145,"context_line":"  debug:"},{"line_number":146,"context_line":"    msg: \"{{lookup(\u0027template\u0027,\u0027proxysql/proxysql.yaml.j2\u0027)}}\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"- name: Copying over proxysql config"},{"line_number":149,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"b27ea245_a0c084d7","line":146,"range":{"start_line":144,"start_character":0,"end_line":146,"end_character":61},"updated":"2024-04-15 08:55:00.000000000","message":"this seems like debug code during testing was added?\n\nPlease remove it or specify why it is needed. Thank you!","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"599cf3395ec4ed60eec83c366a03e0f45346b903","unresolved":false,"context_lines":[{"line_number":141,"context_line":"  notify:"},{"line_number":142,"context_line":"    - Restart haproxy container"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"- name: DEBUG PROXYSQL CONFIG"},{"line_number":145,"context_line":"  debug:"},{"line_number":146,"context_line":"    msg: \"{{lookup(\u0027template\u0027,\u0027proxysql/proxysql.yaml.j2\u0027)}}\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"- name: Copying over proxysql config"},{"line_number":149,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"f009e386_61cdba0a","line":146,"range":{"start_line":144,"start_character":0,"end_line":146,"end_character":61},"in_reply_to":"b27ea245_a0c084d7","updated":"2024-04-15 14:31:39.000000000","message":"Acknowledged","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"}],"ansible/roles/loadbalancer/tasks/copy-certs.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"343a041b3dbcafb4a95201a4626159bd7556ad0b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    role: service-cert-copy"},{"line_number":5,"context_line":"  vars:"},{"line_number":6,"context_line":"    project_services: \"{{ loadbalancer_services }}\""},{"line_number":7,"context_line":"- name: \"Copy MariaDB certificates for {{ project_name }}\""},{"line_number":8,"context_line":"  import_role:"},{"line_number":9,"context_line":"    role: mariadb"},{"line_number":10,"context_line":"    tasks_from: copy-certs"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f82caaaa_d7b0a705","line":7,"updated":"2024-02-23 12:16:29.000000000","message":"ditto","commit_id":"f32ae0ae6b801118a05a30edc74eae4c50d0c225"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"c5ccab09762549f0cc3f67a1471b0f4a814713e8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    role: service-cert-copy"},{"line_number":5,"context_line":"  vars:"},{"line_number":6,"context_line":"    project_services: \"{{ loadbalancer_services }}\""},{"line_number":7,"context_line":"- name: \"Copy MariaDB certificates for {{ project_name }}\""},{"line_number":8,"context_line":"  import_role:"},{"line_number":9,"context_line":"    role: mariadb"},{"line_number":10,"context_line":"    tasks_from: copy-certs"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1af9b75d_da7dfd8d","line":7,"in_reply_to":"f82caaaa_d7b0a705","updated":"2024-02-23 13:09:25.000000000","message":"Acknowledged","commit_id":"f32ae0ae6b801118a05a30edc74eae4c50d0c225"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1bd9c64abbad6bbde228893a6f9c20692788299d","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  vars:"},{"line_number":12,"context_line":"    project_services: \"{{ loadbalancer_services }}\""},{"line_number":13,"context_line":"    project_name: \"mariadb\""},{"line_number":14,"context_line":"    dont_use_haproxy: true"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"65eb70c4_5d076f4f","line":14,"updated":"2024-04-15 14:31:30.000000000","message":"use_haproxy: false?","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b4cb1e61f908081771db0fc65b340be0e5a1333e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  vars:"},{"line_number":12,"context_line":"    project_services: \"{{ loadbalancer_services }}\""},{"line_number":13,"context_line":"    project_name: \"mariadb\""},{"line_number":14,"context_line":"    dont_use_haproxy: true"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3ba56393_46d21701","line":14,"in_reply_to":"65eb70c4_5d076f4f","updated":"2024-04-19 10:29:55.000000000","message":"Done","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ddfbbdd590ff15746d19e4fd0ac809c161c50788","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":23,"id":"6bed2130_7c7347f6","line":15,"range":{"start_line":8,"start_character":0,"end_line":15,"end_character":1},"updated":"2024-07-11 08:25:54.000000000","message":"this fails in job kolla-ansible-ubuntu-cells (non-voting) with a POST_FAILURE: https://zuul.opendev.org/t/openstack/build/df8c4a59eb1f42cbbce65ad7a4330a8e/log/primary/logs/ansible/deploy\n\nwith:\n\n```\n\nTASK [service-cert-copy : loadbalancer | Copying over backend internal TLS certificate] ***\n\ntask path: /home/zuul/kolla-ansible-venv/share/kolla-ansible/ansible/roles/service-cert-copy/tasks/main.yml:14\n\nWednesday 10 July 2024  12:52:34 +0000 (0:00:00.257)       0:00:46.307 ******** \n\nfatal: [primary]: FAILED! \u003d\u003e {\n\n    \"msg\": \"An unhandled exception occurred while templating \u0027{{ lookup(\u0027first_found\u0027, certs) }}\u0027. Error was a \u003cclass \u0027ansible.errors.AnsibleLookupError\u0027\u003e, original message: No file was found when using first_found.\"\n\n}\n\nfatal: [secondary1]: FAILED! \u003d\u003e {\n\n    \"msg\": \"An unhandled exception occurred while templating \u0027{{ lookup(\u0027first_found\u0027, certs) }}\u0027. Error was a \u003cclass \u0027ansible.errors.AnsibleLookupError\u0027\u003e, original message: No file was found when using first_found.\"\n\n}\n\nfatal: [secondary2]: FAILED! \u003d\u003e {\n\n    \"msg\": \"An unhandled exception occurred while templating \u0027{{ lookup(\u0027first_found\u0027, certs) }}\u0027. Error was a \u003cclass \u0027ansible.errors.AnsibleLookupError\u0027\u003e, original message: No file was found when using first_found.\"\n\n}\n```\n\nthe corresponding code from the service-cert-copy role is:\n\n```\n- name: \"{{ project_name }} | Copying over backend internal TLS certificate\"\n  vars:\n    certs:\n      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}/{{ project_name }}-cert.pem\"\n      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}-cert.pem\"\n      - \"{{ kolla_certificates_dir }}/{{ project_name }}-cert.pem\"\n      - \"{{ kolla_tls_backend_cert }}\"\n    backend_tls_cert: \"{{ lookup(\u0027first_found\u0027, certs) }}\"\n  copy:\n    src: \"{{ backend_tls_cert }}\"\n    dest: \"{{ node_config_directory }}/{{ item.key }}/{{ project_name }}-cert.pem\"\n    mode: \"0644\"\n  become: true\n  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\"\n  notify:\n    - \"Restart {{ item.key }} container\"\n```","commit_id":"21de08733a93ad85b18abf3652fa170f718635dd"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"b9468e58e373704ee3fb44037d9dcfa0f6e353b0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":23,"id":"d11b8a2f_80b03dca","line":15,"range":{"start_line":8,"start_character":0,"end_line":15,"end_character":1},"in_reply_to":"6bed2130_7c7347f6","updated":"2024-07-16 14:21:54.000000000","message":"waiting for Zuul to run, but I\u0027ve found the issue.","commit_id":"21de08733a93ad85b18abf3652fa170f718635dd"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"c9cece2a261a9584d85174205ef72392a63e585c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"7c837424_20c283e8","line":15,"range":{"start_line":8,"start_character":0,"end_line":15,"end_character":1},"in_reply_to":"d11b8a2f_80b03dca","updated":"2024-07-23 13:23:52.000000000","message":"Done","commit_id":"21de08733a93ad85b18abf3652fa170f718635dd"}],"ansible/roles/loadbalancer/templates/proxysql/proxysql.yaml.j2":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e830ab7b844dda7ac8b948e75e4b3b8c5e0e2be0","unresolved":true,"context_lines":[{"line_number":24,"context_line":"   connect_timeout_server: 30000"},{"line_number":25,"context_line":"   connect_timeout_server_max: 100000"},{"line_number":26,"context_line":"{% if database_tls_backend_enable | bool %}"},{"line_number":27,"context_line":"   ssl_p2s_ca: \"/etc/mariadb/certs/root.crt\""},{"line_number":28,"context_line":"   ssl_p2s_cert: \"/etc/mariadb/certs/mariadb-cert.pem\""},{"line_number":29,"context_line":"   ssl_p2s_key: \"/etc/mariadb/certs/mariadb-key.pem\""},{"line_number":30,"context_line":"   have_ssl: true"},{"line_number":31,"context_line":"{% endif %}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"b4374295_c7b5b851","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":52},"updated":"2024-07-22 08:03:20.000000000","message":"I think it\u0027s better to store keys in /etc/proxysql/certs for example ... It\u0027s a bit confusing to have a folder named mariadb in the proxysql container, isn\u0027t it?","commit_id":"ac24d83189bb8a148b49d488f5b2484fdf48f026"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"cdda4e386fba474f3dff593d53653fa320e317b7","unresolved":false,"context_lines":[{"line_number":24,"context_line":"   connect_timeout_server: 30000"},{"line_number":25,"context_line":"   connect_timeout_server_max: 100000"},{"line_number":26,"context_line":"{% if database_tls_backend_enable | bool %}"},{"line_number":27,"context_line":"   ssl_p2s_ca: \"/etc/mariadb/certs/root.crt\""},{"line_number":28,"context_line":"   ssl_p2s_cert: \"/etc/mariadb/certs/mariadb-cert.pem\""},{"line_number":29,"context_line":"   ssl_p2s_key: \"/etc/mariadb/certs/mariadb-key.pem\""},{"line_number":30,"context_line":"   have_ssl: true"},{"line_number":31,"context_line":"{% endif %}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"a614d15f_deb3a387","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":52},"in_reply_to":"b4374295_c7b5b851","updated":"2024-07-22 11:04:58.000000000","message":"Done","commit_id":"ac24d83189bb8a148b49d488f5b2484fdf48f026"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5358fdcc89d1984879dad6d806f1f1667fc77d60","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"admin_variables:"},{"line_number":12,"context_line":"   admin_credentials: \"{{ proxysql_admin_user }}:{{ proxysql_admin_password }}\""},{"line_number":13,"context_line":"   mysql_ifaces: \"{{ api_interface_address | ipwrap }}:{{ proxysql_admin_port }};{{ kolla_internal_vip_address | ipwrap }}:{{ proxysql_admin_port }};/var/lib/kolla/proxysql/admin.sock\""},{"line_number":14,"context_line":"   stats_credentials: \"{{ proxysql_stats_user }}:{{ proxysql_stats_password }}\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"mysql_variables:"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"0f8e1f56_0b329450","line":13,"range":{"start_line":13,"start_character":45,"end_line":13,"end_character":51},"updated":"2024-07-29 08:06:19.000000000","message":"this filter plugin is not part of ansible-core, according to the docs at:\n\nhttps://docs.ansible.com/ansible/latest/collections/ansible/utils/ipwrap_filter.html\n\nI think we should add it to `requirements-core.yml`?","commit_id":"70ef75644334d79f3edff79d5522e175801db507"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"e34c4accd315ce9534c19742bef75cf721c0dac3","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"admin_variables:"},{"line_number":12,"context_line":"   admin_credentials: \"{{ proxysql_admin_user }}:{{ proxysql_admin_password }}\""},{"line_number":13,"context_line":"   mysql_ifaces: \"{{ api_interface_address | ipwrap }}:{{ proxysql_admin_port }};{{ kolla_internal_vip_address | ipwrap }}:{{ proxysql_admin_port }};/var/lib/kolla/proxysql/admin.sock\""},{"line_number":14,"context_line":"   stats_credentials: \"{{ proxysql_stats_user }}:{{ proxysql_stats_password }}\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"mysql_variables:"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"2f7e4792_88b27950","line":13,"range":{"start_line":13,"start_character":45,"end_line":13,"end_character":51},"in_reply_to":"0f8e1f56_0b329450","updated":"2024-07-29 10:01:34.000000000","message":"Done","commit_id":"70ef75644334d79f3edff79d5522e175801db507"}],"ansible/roles/mariadb/tasks/copy-certs.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"343a041b3dbcafb4a95201a4626159bd7556ad0b","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    - kolla_copy_ca_into_containers | bool and database_tls_backend_enable |bool"},{"line_number":11,"context_line":"  notify:"},{"line_number":12,"context_line":"    - \"Restart {{ item.key }} \""},{"line_number":13,"context_line":"- name: Copying over TLS certificate"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":16,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"85496399_85f5f543","line":13,"updated":"2024-02-23 12:16:29.000000000","message":"ditto","commit_id":"f32ae0ae6b801118a05a30edc74eae4c50d0c225"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"c5ccab09762549f0cc3f67a1471b0f4a814713e8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    - kolla_copy_ca_into_containers | bool and database_tls_backend_enable |bool"},{"line_number":11,"context_line":"  notify:"},{"line_number":12,"context_line":"    - \"Restart {{ item.key }} \""},{"line_number":13,"context_line":"- name: Copying over TLS certificate"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":16,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"529d8cf0_7133ef1f","line":13,"in_reply_to":"85496399_85f5f543","updated":"2024-02-23 13:09:25.000000000","message":"Acknowledged","commit_id":"f32ae0ae6b801118a05a30edc74eae4c50d0c225"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"343a041b3dbcafb4a95201a4626159bd7556ad0b","unresolved":true,"context_lines":[{"line_number":26,"context_line":"  notify:"},{"line_number":27,"context_line":"    - \"restart {{ item.key }}\""},{"line_number":28,"context_line":"  when: database_tls_backend_enable | bool"},{"line_number":29,"context_line":"- name: Copying over TLS key"},{"line_number":30,"context_line":"  become: true"},{"line_number":31,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":32,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"974d27c9_5f6bd423","line":29,"updated":"2024-02-23 12:16:29.000000000","message":"ditto","commit_id":"f32ae0ae6b801118a05a30edc74eae4c50d0c225"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"c5ccab09762549f0cc3f67a1471b0f4a814713e8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  notify:"},{"line_number":27,"context_line":"    - \"restart {{ item.key }}\""},{"line_number":28,"context_line":"  when: database_tls_backend_enable | bool"},{"line_number":29,"context_line":"- name: Copying over TLS key"},{"line_number":30,"context_line":"  become: true"},{"line_number":31,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":32,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"440e3b98_f6019690","line":29,"in_reply_to":"974d27c9_5f6bd423","updated":"2024-02-23 13:09:25.000000000","message":"Acknowledged","commit_id":"f32ae0ae6b801118a05a30edc74eae4c50d0c225"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ef18d2610e4e161ef3a54d4f9443baa7b2616bc2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Copying over extra CA certificates"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":5,"context_line":"  copy:"},{"line_number":6,"context_line":"    src: \"{{ kolla_certificates_dir }}/ca/\""},{"line_number":7,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/ca-certificates\""},{"line_number":8,"context_line":"    mode: \"0644\""},{"line_number":9,"context_line":"  when:"},{"line_number":10,"context_line":"    - kolla_copy_ca_into_containers | bool and database_tls_backend_enable |bool"},{"line_number":11,"context_line":"  notify:"},{"line_number":12,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Copying over TLS certificate"},{"line_number":15,"context_line":"  become: true"},{"line_number":16,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":17,"context_line":"  copy:"},{"line_number":18,"context_line":"    src: \"{{ backend_tls_cert }}\""},{"line_number":19,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/{{ database_tls_backend_cert }}\""},{"line_number":20,"context_line":"    mode: \"0644\""},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    certs:"},{"line_number":23,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}/{{ database_tls_backend_cert }}\""},{"line_number":24,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}-cert.pem\""},{"line_number":25,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ database_tls_backend_cert }}\""},{"line_number":26,"context_line":"    backend_tls_cert: \"{{ lookup(\u0027first_found\u0027, certs) }}\""},{"line_number":27,"context_line":"  notify:"},{"line_number":28,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":29,"context_line":"  when: database_tls_backend_enable | bool"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Copying over TLS key"},{"line_number":32,"context_line":"  become: true"},{"line_number":33,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":34,"context_line":"  copy:"},{"line_number":35,"context_line":"    src: \"{{ backend_tls_key }}\""},{"line_number":36,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key}}/{{ database_tls_backend_key }}\""},{"line_number":37,"context_line":"    mode: \"0600\""},{"line_number":38,"context_line":"  vars:"},{"line_number":39,"context_line":"    keys:"},{"line_number":40,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}/{{ project_name }}-key.pem\""},{"line_number":41,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}-key.pem\""},{"line_number":42,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ database_tls_backend_key }}\""},{"line_number":43,"context_line":"    backend_tls_key: \"{{ lookup(\u0027first_found\u0027, keys) }}\""},{"line_number":44,"context_line":"  notify:"},{"line_number":45,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":46,"context_line":"  when: database_tls_backend_enable | bool"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2da918f8_2a5d1097","line":46,"range":{"start_line":1,"start_character":0,"end_line":46,"end_character":42},"updated":"2024-03-28 11:15:36.000000000","message":"so this basically does the same as the already existing role `service-cert-copy` with the addition that it checks if the new `database_tls_backend_enable` variable is set.\n\nI\u0027m not sure if it worth the effort to make a complete copy of this existing role into this task.\n\nImho it would be better to just extend the service-cert-copy role to discern between an enabled or disabled database TLS backend.\n\nI could even argue against having the option to disable TLS encryption here at all, in which case we could just reuse the existing role without any larger changes needed.","commit_id":"0439ac5656a10d602731020a45042a0992977135"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22310ae59aac14d1f9bf20991698b40a935a80f0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Copying over extra CA certificates"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":5,"context_line":"  copy:"},{"line_number":6,"context_line":"    src: \"{{ kolla_certificates_dir }}/ca/\""},{"line_number":7,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/ca-certificates\""},{"line_number":8,"context_line":"    mode: \"0644\""},{"line_number":9,"context_line":"  when:"},{"line_number":10,"context_line":"    - kolla_copy_ca_into_containers | bool and database_tls_backend_enable |bool"},{"line_number":11,"context_line":"  notify:"},{"line_number":12,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Copying over TLS certificate"},{"line_number":15,"context_line":"  become: true"},{"line_number":16,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":17,"context_line":"  copy:"},{"line_number":18,"context_line":"    src: \"{{ backend_tls_cert }}\""},{"line_number":19,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/{{ database_tls_backend_cert }}\""},{"line_number":20,"context_line":"    mode: \"0644\""},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    certs:"},{"line_number":23,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}/{{ database_tls_backend_cert }}\""},{"line_number":24,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}-cert.pem\""},{"line_number":25,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ database_tls_backend_cert }}\""},{"line_number":26,"context_line":"    backend_tls_cert: \"{{ lookup(\u0027first_found\u0027, certs) }}\""},{"line_number":27,"context_line":"  notify:"},{"line_number":28,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":29,"context_line":"  when: database_tls_backend_enable | bool"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Copying over TLS key"},{"line_number":32,"context_line":"  become: true"},{"line_number":33,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":34,"context_line":"  copy:"},{"line_number":35,"context_line":"    src: \"{{ backend_tls_key }}\""},{"line_number":36,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key}}/{{ database_tls_backend_key }}\""},{"line_number":37,"context_line":"    mode: \"0600\""},{"line_number":38,"context_line":"  vars:"},{"line_number":39,"context_line":"    keys:"},{"line_number":40,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}/{{ project_name }}-key.pem\""},{"line_number":41,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}-key.pem\""},{"line_number":42,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ database_tls_backend_key }}\""},{"line_number":43,"context_line":"    backend_tls_key: \"{{ lookup(\u0027first_found\u0027, keys) }}\""},{"line_number":44,"context_line":"  notify:"},{"line_number":45,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":46,"context_line":"  when: database_tls_backend_enable | bool"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"cae72765_33ba9c3e","line":46,"range":{"start_line":1,"start_character":0,"end_line":46,"end_character":42},"in_reply_to":"2da918f8_2a5d1097","updated":"2024-04-02 10:16:23.000000000","message":"The original `service-cert-copy` role is unusable for that. It skips copying certificates because it requires haproxy for the service which Proxysql obviously does not have\n```\n  when:\n    - item.value.haproxy is defined\n    - item.value.haproxy.values() | selectattr(\u0027enabled\u0027, \u0027defined\u0027) | map(attribute\u003d\u0027enabled\u0027) | map(\u0027bool\u0027) | select | list | length \u003e 0\n    - item.value.haproxy.values() | selectattr(\u0027tls_backend\u0027, \u0027defined\u0027) | map(attribute\u003d\u0027tls_backend\u0027) | map(\u0027bool\u0027) | select | list | length \u003e 0\n    - not kolla_externally_managed_cert | bool\n```\n\nThe solution would be write another role for non-haproxy services, basically copy this role without the conditions or change the condition to something like. \n```\nwhen:\n- \u003chaproxy_condition\u003e OR service_does_not_have_haproxy\n```\n\nThere\u0027s already a copy of this role for [RabbitMQ](https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/rabbitmq/tasks/copy-certs.yml), that\u0027s why I originally made a copy of the role.","commit_id":"0439ac5656a10d602731020a45042a0992977135"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b4cb1e61f908081771db0fc65b340be0e5a1333e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Copying over extra CA certificates"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":5,"context_line":"  copy:"},{"line_number":6,"context_line":"    src: \"{{ kolla_certificates_dir }}/ca/\""},{"line_number":7,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/ca-certificates\""},{"line_number":8,"context_line":"    mode: \"0644\""},{"line_number":9,"context_line":"  when:"},{"line_number":10,"context_line":"    - kolla_copy_ca_into_containers | bool and database_tls_backend_enable |bool"},{"line_number":11,"context_line":"  notify:"},{"line_number":12,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Copying over TLS certificate"},{"line_number":15,"context_line":"  become: true"},{"line_number":16,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":17,"context_line":"  copy:"},{"line_number":18,"context_line":"    src: \"{{ backend_tls_cert }}\""},{"line_number":19,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/{{ database_tls_backend_cert }}\""},{"line_number":20,"context_line":"    mode: \"0644\""},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    certs:"},{"line_number":23,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}/{{ database_tls_backend_cert }}\""},{"line_number":24,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}-cert.pem\""},{"line_number":25,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ database_tls_backend_cert }}\""},{"line_number":26,"context_line":"    backend_tls_cert: \"{{ lookup(\u0027first_found\u0027, certs) }}\""},{"line_number":27,"context_line":"  notify:"},{"line_number":28,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":29,"context_line":"  when: database_tls_backend_enable | bool"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Copying over TLS key"},{"line_number":32,"context_line":"  become: true"},{"line_number":33,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":34,"context_line":"  copy:"},{"line_number":35,"context_line":"    src: \"{{ backend_tls_key }}\""},{"line_number":36,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key}}/{{ database_tls_backend_key }}\""},{"line_number":37,"context_line":"    mode: \"0600\""},{"line_number":38,"context_line":"  vars:"},{"line_number":39,"context_line":"    keys:"},{"line_number":40,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}/{{ project_name }}-key.pem\""},{"line_number":41,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}-key.pem\""},{"line_number":42,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ database_tls_backend_key }}\""},{"line_number":43,"context_line":"    backend_tls_key: \"{{ lookup(\u0027first_found\u0027, keys) }}\""},{"line_number":44,"context_line":"  notify:"},{"line_number":45,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":46,"context_line":"  when: database_tls_backend_enable | bool"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9efa8e40_5eb92cff","line":46,"range":{"start_line":1,"start_character":0,"end_line":46,"end_character":42},"in_reply_to":"b9a812c0_f0b1f2c8","updated":"2024-04-19 10:29:55.000000000","message":"Done","commit_id":"0439ac5656a10d602731020a45042a0992977135"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ac25f3cb804aeab6d0e04933677d446a6b00f84f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Copying over extra CA certificates"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":5,"context_line":"  copy:"},{"line_number":6,"context_line":"    src: \"{{ kolla_certificates_dir }}/ca/\""},{"line_number":7,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/ca-certificates\""},{"line_number":8,"context_line":"    mode: \"0644\""},{"line_number":9,"context_line":"  when:"},{"line_number":10,"context_line":"    - kolla_copy_ca_into_containers | bool and database_tls_backend_enable |bool"},{"line_number":11,"context_line":"  notify:"},{"line_number":12,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Copying over TLS certificate"},{"line_number":15,"context_line":"  become: true"},{"line_number":16,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":17,"context_line":"  copy:"},{"line_number":18,"context_line":"    src: \"{{ backend_tls_cert }}\""},{"line_number":19,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/{{ database_tls_backend_cert }}\""},{"line_number":20,"context_line":"    mode: \"0644\""},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    certs:"},{"line_number":23,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}/{{ database_tls_backend_cert }}\""},{"line_number":24,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}-cert.pem\""},{"line_number":25,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ database_tls_backend_cert }}\""},{"line_number":26,"context_line":"    backend_tls_cert: \"{{ lookup(\u0027first_found\u0027, certs) }}\""},{"line_number":27,"context_line":"  notify:"},{"line_number":28,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":29,"context_line":"  when: database_tls_backend_enable | bool"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Copying over TLS key"},{"line_number":32,"context_line":"  become: true"},{"line_number":33,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":34,"context_line":"  copy:"},{"line_number":35,"context_line":"    src: \"{{ backend_tls_key }}\""},{"line_number":36,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key}}/{{ database_tls_backend_key }}\""},{"line_number":37,"context_line":"    mode: \"0600\""},{"line_number":38,"context_line":"  vars:"},{"line_number":39,"context_line":"    keys:"},{"line_number":40,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}/{{ project_name }}-key.pem\""},{"line_number":41,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}-key.pem\""},{"line_number":42,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ database_tls_backend_key }}\""},{"line_number":43,"context_line":"    backend_tls_key: \"{{ lookup(\u0027first_found\u0027, keys) }}\""},{"line_number":44,"context_line":"  notify:"},{"line_number":45,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":46,"context_line":"  when: database_tls_backend_enable | bool"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e2f5678a_68ba6642","line":46,"range":{"start_line":1,"start_character":0,"end_line":46,"end_character":42},"in_reply_to":"cae72765_33ba9c3e","updated":"2024-04-02 17:21:45.000000000","message":"I personally still think it would be much more sensible to alter the condition of the role to fit for this purpose rather than copy all the code around.\n\nBut I also would like to hear more opinions from someone else. I try to reach out and see if anybody is willing to comment on this.","commit_id":"0439ac5656a10d602731020a45042a0992977135"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22b0df864e2143a1092a4f19291760fcf553fed8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Copying over extra CA certificates"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":5,"context_line":"  copy:"},{"line_number":6,"context_line":"    src: \"{{ kolla_certificates_dir }}/ca/\""},{"line_number":7,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/ca-certificates\""},{"line_number":8,"context_line":"    mode: \"0644\""},{"line_number":9,"context_line":"  when:"},{"line_number":10,"context_line":"    - kolla_copy_ca_into_containers | bool and database_tls_backend_enable |bool"},{"line_number":11,"context_line":"  notify:"},{"line_number":12,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Copying over TLS certificate"},{"line_number":15,"context_line":"  become: true"},{"line_number":16,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":17,"context_line":"  copy:"},{"line_number":18,"context_line":"    src: \"{{ backend_tls_cert }}\""},{"line_number":19,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/{{ database_tls_backend_cert }}\""},{"line_number":20,"context_line":"    mode: \"0644\""},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    certs:"},{"line_number":23,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}/{{ database_tls_backend_cert }}\""},{"line_number":24,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}-cert.pem\""},{"line_number":25,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ database_tls_backend_cert }}\""},{"line_number":26,"context_line":"    backend_tls_cert: \"{{ lookup(\u0027first_found\u0027, certs) }}\""},{"line_number":27,"context_line":"  notify:"},{"line_number":28,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":29,"context_line":"  when: database_tls_backend_enable | bool"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Copying over TLS key"},{"line_number":32,"context_line":"  become: true"},{"line_number":33,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":34,"context_line":"  copy:"},{"line_number":35,"context_line":"    src: \"{{ backend_tls_key }}\""},{"line_number":36,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key}}/{{ database_tls_backend_key }}\""},{"line_number":37,"context_line":"    mode: \"0600\""},{"line_number":38,"context_line":"  vars:"},{"line_number":39,"context_line":"    keys:"},{"line_number":40,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}/{{ project_name }}-key.pem\""},{"line_number":41,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}-key.pem\""},{"line_number":42,"context_line":"      - \"{{ kolla_certificates_dir }}/{{ database_tls_backend_key }}\""},{"line_number":43,"context_line":"    backend_tls_key: \"{{ lookup(\u0027first_found\u0027, keys) }}\""},{"line_number":44,"context_line":"  notify:"},{"line_number":45,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":46,"context_line":"  when: database_tls_backend_enable | bool"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"b9a812c0_f0b1f2c8","line":46,"range":{"start_line":1,"start_character":0,"end_line":46,"end_character":42},"in_reply_to":"e2f5678a_68ba6642","updated":"2024-04-11 15:33:47.000000000","message":"I changed the condition, now the original role can be used. I think now it can be used in other TLS roles where it was copied, such as RabbitMQ","commit_id":"0439ac5656a10d602731020a45042a0992977135"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1bd9c64abbad6bbde228893a6f9c20692788299d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    role: service-cert-copy"},{"line_number":5,"context_line":"  vars:"},{"line_number":6,"context_line":"    project_services: \"{{ mariadb_services }}\""},{"line_number":7,"context_line":"    dont_use_haproxy: true"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7812dfbb_82742146","line":7,"updated":"2024-04-15 14:31:30.000000000","message":"use_haproxy: false?","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b4cb1e61f908081771db0fc65b340be0e5a1333e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    role: service-cert-copy"},{"line_number":5,"context_line":"  vars:"},{"line_number":6,"context_line":"    project_services: \"{{ mariadb_services }}\""},{"line_number":7,"context_line":"    dont_use_haproxy: true"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"6dddb6ec_2a2d0a9d","line":7,"in_reply_to":"7812dfbb_82742146","updated":"2024-04-19 10:29:55.000000000","message":"Done","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"}],"ansible/roles/service-cert-copy/defaults/main.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"57bb6f772991883515974c483db73362a339de67","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"kolla_externally_managed_cert: False"},{"line_number":4,"context_line":"dont_use_haproxy: false"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"0fc480d7_f4c8c0f6","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"updated":"2024-04-15 08:55:00.000000000","message":"Thanks for tweaking the service-cert-copy role instead.\n\nCould you simplify the logic by calling this `use_haproxy: true` instead of using negation twice? This would have to be adjusted in the other files as well.","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"599cf3395ec4ed60eec83c366a03e0f45346b903","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"kolla_externally_managed_cert: False"},{"line_number":4,"context_line":"dont_use_haproxy: false"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"704d6d83_61b49ddb","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"in_reply_to":"0fc480d7_f4c8c0f6","updated":"2024-04-15 14:31:39.000000000","message":"Acknowledged","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1bd9c64abbad6bbde228893a6f9c20692788299d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"kolla_externally_managed_cert: False"},{"line_number":4,"context_line":"dont_use_haproxy: false"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1d3e0615_cf299b19","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"in_reply_to":"0fc480d7_f4c8c0f6","updated":"2024-04-15 14:31:30.000000000","message":"Agree with Sven - it should be use_haproxy: true","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"}],"releasenotes/notes/mariadb-proxysql-ssl-support-dd0b264212655424.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ef18d2610e4e161ef3a54d4f9443baa7b2616bc2","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Implements SSL between Proxysql and MariaDB"},{"line_number":5,"context_line":"    ProxySQL should be enabled in order for encryption to work"},{"line_number":6,"context_line":"    `Partial Blueprint  mariadb-ssl-support  \u003chttps://blueprints.launchpad.net/kolla-ansible/+spec/mariadb-ssl-support\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"561018c0_a5497094","line":5,"range":{"start_line":5,"start_character":13,"end_line":5,"end_character":19},"updated":"2024-03-28 11:15:36.000000000","message":"should or must?","commit_id":"0439ac5656a10d602731020a45042a0992977135"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22310ae59aac14d1f9bf20991698b40a935a80f0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Implements SSL between Proxysql and MariaDB"},{"line_number":5,"context_line":"    ProxySQL should be enabled in order for encryption to work"},{"line_number":6,"context_line":"    `Partial Blueprint  mariadb-ssl-support  \u003chttps://blueprints.launchpad.net/kolla-ansible/+spec/mariadb-ssl-support\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"35b84b81_e1186521","line":5,"range":{"start_line":5,"start_character":13,"end_line":5,"end_character":19},"in_reply_to":"561018c0_a5497094","updated":"2024-04-02 10:16:23.000000000","message":"Acknowledged","commit_id":"0439ac5656a10d602731020a45042a0992977135"}],"tests/j2lint.py":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5358fdcc89d1984879dad6d806f1f1667fc77d60","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        return source, template, lambda: mtime \u003d\u003d os.path.getmtime(template)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def fake_ipwrap(x):"},{"line_number":49,"context_line":"    return x"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def check(template, out, err, env\u003dEnvironment(loader\u003dAbsolutePathLoader(),"}],"source_content_type":"text/x-python","patch_set":32,"id":"4108e5e2_ad15207a","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":12},"updated":"2024-07-29 08:06:19.000000000","message":"why is this necessary?","commit_id":"70ef75644334d79f3edff79d5522e175801db507"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"e34c4accd315ce9534c19742bef75cf721c0dac3","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        return source, template, lambda: mtime \u003d\u003d os.path.getmtime(template)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def fake_ipwrap(x):"},{"line_number":49,"context_line":"    return x"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def check(template, out, err, env\u003dEnvironment(loader\u003dAbsolutePathLoader(),"}],"source_content_type":"text/x-python","patch_set":32,"id":"bcb9fe82_f1865c23","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":12},"in_reply_to":"4108e5e2_ad15207a","updated":"2024-07-29 10:01:34.000000000","message":"the linter does not know the filter otherwise. I wasn\u0027t able to find the path to the real filter so I just did it like this","commit_id":"70ef75644334d79f3edff79d5522e175801db507"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"c16c4c4901da6c6c863fa92521425edc9e0b9af3","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        return source, template, lambda: mtime \u003d\u003d os.path.getmtime(template)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def fake_ipwrap(x):"},{"line_number":49,"context_line":"    return x"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def check(template, out, err, env\u003dEnvironment(loader\u003dAbsolutePathLoader(),"}],"source_content_type":"text/x-python","patch_set":32,"id":"ba38b85a_217387d9","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":12},"in_reply_to":"50e5dde5_ce25d10c","updated":"2024-07-31 08:59:52.000000000","message":"The proble is not `tox -e ansible-lint` that runs fine without `fake_ipwrap`. \n\nIt\u0027s  `tox -e j2lint` which has the following error if `fake_ipwrap` changes are not present:\n```\n./ansible/roles/loadbalancer/templates/proxysql/proxysql.yaml.j2: Syntax check failed: No filter named \u0027ipwrap\u0027. in ./ansible/roles/loadbalancer/templates/proxysql/proxysql.yaml.j2 at 13\n```\n\nNote that bot `ansible-lint` and `j2lint` run when `tox -e linters` is ran, which is run in Zuul `openstack-tox-linters`","commit_id":"70ef75644334d79f3edff79d5522e175801db507"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"122726010d530d05e6a0737285112d5246d315f5","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        return source, template, lambda: mtime \u003d\u003d os.path.getmtime(template)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def fake_ipwrap(x):"},{"line_number":49,"context_line":"    return x"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def check(template, out, err, env\u003dEnvironment(loader\u003dAbsolutePathLoader(),"}],"source_content_type":"text/x-python","patch_set":32,"id":"8b395e52_d6ebdef3","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":12},"in_reply_to":"6905b127_2bb3b662","updated":"2024-07-31 14:32:11.000000000","message":"should we add ipwrap filter like in upsteream j2lint or should I just delete the linter entirely?","commit_id":"70ef75644334d79f3edff79d5522e175801db507"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"aa0a0daa0441f059ffb59dd6562efd3359966827","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        return source, template, lambda: mtime \u003d\u003d os.path.getmtime(template)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def fake_ipwrap(x):"},{"line_number":49,"context_line":"    return x"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def check(template, out, err, env\u003dEnvironment(loader\u003dAbsolutePathLoader(),"}],"source_content_type":"text/x-python","patch_set":32,"id":"0b89bb33_2a7b9c94","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":12},"in_reply_to":"8b395e52_d6ebdef3","updated":"2024-08-01 13:37:11.000000000","message":"Done","commit_id":"70ef75644334d79f3edff79d5522e175801db507"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"669b3cccdbc39b5d6707c37ddf748fef392b13fd","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        return source, template, lambda: mtime \u003d\u003d os.path.getmtime(template)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def fake_ipwrap(x):"},{"line_number":49,"context_line":"    return x"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def check(template, out, err, env\u003dEnvironment(loader\u003dAbsolutePathLoader(),"}],"source_content_type":"text/x-python","patch_set":32,"id":"d09d1fc5_54f63307","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":12},"in_reply_to":"ba38b85a_217387d9","updated":"2024-07-31 09:10:28.000000000","message":"ah thanks, I will check it out and report back, maybe your solution is already the correct one!","commit_id":"70ef75644334d79f3edff79d5522e175801db507"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"31c577ec604238649736a49a75745303fcbfd92d","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        return source, template, lambda: mtime \u003d\u003d os.path.getmtime(template)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def fake_ipwrap(x):"},{"line_number":49,"context_line":"    return x"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def check(template, out, err, env\u003dEnvironment(loader\u003dAbsolutePathLoader(),"}],"source_content_type":"text/x-python","patch_set":32,"id":"ec587b76_9e0e52e2","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":12},"in_reply_to":"bcb9fe82_f1865c23","updated":"2024-07-30 15:45:01.000000000","message":"mhm, there was an issue with ansible-lint not recognizing ipwrap, but it was fixed via:\n\nhttps://github.com/ansible/ansible-lint/issues/2462\n\nlet me see and check if our version is up to date or if maybe the bug got reintroduced upstream.","commit_id":"70ef75644334d79f3edff79d5522e175801db507"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ce5337feabac1bb3b8aea2a12bad5c746612b5e5","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        return source, template, lambda: mtime \u003d\u003d os.path.getmtime(template)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def fake_ipwrap(x):"},{"line_number":49,"context_line":"    return x"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def check(template, out, err, env\u003dEnvironment(loader\u003dAbsolutePathLoader(),"}],"source_content_type":"text/x-python","patch_set":32,"id":"6905b127_2bb3b662","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":12},"in_reply_to":"d09d1fc5_54f63307","updated":"2024-07-31 12:07:15.000000000","message":"I think we should implement custom filters like upstream j2lint did, e.g. here:\n\nhttps://github.com/drm/jinja2-lint/blob/master/j2lint.py#L18\n\nsee this commit for more details:\n\nhttps://github.com/drm/jinja2-lint/commit/930b7405fa326725c26109d08e52d80021d058f0#diff-65e2b85f1aa5f6d32d7706dd32bfef1b8d84ccb517267440aff55fbd7a8287c2\n\nBut I actually have doubts we can even use this library, as it\u0027s licence is afaik not OSI OSS compliance, at least it\u0027s not on the approved list of licences.","commit_id":"70ef75644334d79f3edff79d5522e175801db507"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cbac8bc8ae361683f946c0fc393ca0c422d8a513","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        return source, template, lambda: mtime \u003d\u003d os.path.getmtime(template)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def fake_ipwrap(x):"},{"line_number":49,"context_line":"    return x"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def check(template, out, err, env\u003dEnvironment(loader\u003dAbsolutePathLoader(),"}],"source_content_type":"text/x-python","patch_set":32,"id":"50e5dde5_ce25d10c","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":12},"in_reply_to":"ec587b76_9e0e52e2","updated":"2024-07-30 16:05:24.000000000","message":"I just checked this locally, I ran `tox -e ansible-lint` on this Patchset without the `fake_ipwrap` changes in this file and it did not complain.\n\nAre you certain that it was related to ipwrap/ansible-lint?\n\nDo you happen do have written down the actual error code somewhere?\n\nI would really like to try to reproduce this withtout the changes to j2lint.py\n\nThanks!","commit_id":"70ef75644334d79f3edff79d5522e175801db507"}],"tests/run.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fc9cba80233f8a761b4924e33ac13efdf3bd7b17","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    - name: Set facts for commonly used variables"},{"line_number":11,"context_line":"      vars:"},{"line_number":12,"context_line":"        # NOTE(yoctozepto): needed here to use in other facts too"},{"line_number":13,"context_line":"        openstack_core_enabled: \"{{ scenario not in [\u0027bifrost\u0027, \u0027mariadb\u0027, \u0027prometheus-opensearch\u0027, \u0027venus\u0027, \u0027proxysql\u0027] }}\""},{"line_number":14,"context_line":"      set_fact:"},{"line_number":15,"context_line":"        kolla_inventory_path: \"/etc/kolla/inventory\""},{"line_number":16,"context_line":"        logs_dir: \"/tmp/logs\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"6600fef7_63ea6e82","line":13,"range":{"start_line":13,"start_character":110,"end_line":13,"end_character":118},"updated":"2024-04-24 09:27:31.000000000","message":"I think this was removed again and is not used anymore.","commit_id":"41fc59d5c94510ba5f90adac648e2e303342a548"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"95b2c6d90fba781119b1d12c13db942f0a384250","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    - name: Set facts for commonly used variables"},{"line_number":11,"context_line":"      vars:"},{"line_number":12,"context_line":"        # NOTE(yoctozepto): needed here to use in other facts too"},{"line_number":13,"context_line":"        openstack_core_enabled: \"{{ scenario not in [\u0027bifrost\u0027, \u0027mariadb\u0027, \u0027prometheus-opensearch\u0027, \u0027venus\u0027, \u0027proxysql\u0027] }}\""},{"line_number":14,"context_line":"      set_fact:"},{"line_number":15,"context_line":"        kolla_inventory_path: \"/etc/kolla/inventory\""},{"line_number":16,"context_line":"        logs_dir: \"/tmp/logs\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"10772be7_09f4bc9d","line":13,"range":{"start_line":13,"start_character":110,"end_line":13,"end_character":118},"in_reply_to":"6600fef7_63ea6e82","updated":"2024-04-24 13:59:23.000000000","message":"Acknowledged","commit_id":"41fc59d5c94510ba5f90adac648e2e303342a548"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"df605122fd8228cea82da2b016a2e0574e14bffd","unresolved":true,"context_lines":[{"line_number":557,"context_line":"          script:"},{"line_number":558,"context_line":"            cmd: test-proxysql.sh"},{"line_number":559,"context_line":"            executable: /bin/bash"},{"line_number":560,"context_line":"            chdir: \"{{ kola_ansible_src_dir }}\""},{"line_number":561,"context_line":"          when: scenario \u003d\u003d \"cells\""},{"line_number":562,"context_line":"          environment:"},{"line_number":563,"context_line":"            VIP: \"{{ kolla_internal_vip_address }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"669b2987_58e012b9","line":560,"range":{"start_line":560,"start_character":23,"end_line":560,"end_character":44},"updated":"2024-05-08 13:17:48.000000000","message":"typo, which made the test fail:\n`kolla_ansible_src_dir`","commit_id":"37aae45d39a146754b2dce40edd186efaaaa3a90"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"38470eef21ecea17df31529d4ef302503153705f","unresolved":false,"context_lines":[{"line_number":557,"context_line":"          script:"},{"line_number":558,"context_line":"            cmd: test-proxysql.sh"},{"line_number":559,"context_line":"            executable: /bin/bash"},{"line_number":560,"context_line":"            chdir: \"{{ kola_ansible_src_dir }}\""},{"line_number":561,"context_line":"          when: scenario \u003d\u003d \"cells\""},{"line_number":562,"context_line":"          environment:"},{"line_number":563,"context_line":"            VIP: \"{{ kolla_internal_vip_address }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7ba03816_ce567107","line":560,"range":{"start_line":560,"start_character":23,"end_line":560,"end_character":44},"in_reply_to":"669b2987_58e012b9","updated":"2024-05-10 09:13:19.000000000","message":"Done","commit_id":"37aae45d39a146754b2dce40edd186efaaaa3a90"}],"tests/templates/globals-default.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b0686c7c0b60e01f6e64229ea7627dd89792da11","unresolved":true,"context_lines":[{"line_number":273,"context_line":"{% endraw %}"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"{% endif %}"},{"line_number":276,"context_line":"{% if scenario \u003d\u003d \"proxysql\" %}"},{"line_number":277,"context_line":"enable_proxysql: \"yes\""},{"line_number":278,"context_line":"database_tls_backend_enable: \"yes\""},{"line_number":279,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"f00066ce_6a00e97f","line":276,"updated":"2024-04-15 14:32:13.000000000","message":"We usually test proxysql in the cells scenario - what\u0027s wrong with that?","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"17c882e8fe2082fa1e1d77025b0b6282d05f68c2","unresolved":false,"context_lines":[{"line_number":273,"context_line":"{% endraw %}"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"{% endif %}"},{"line_number":276,"context_line":"{% if scenario \u003d\u003d \"proxysql\" %}"},{"line_number":277,"context_line":"enable_proxysql: \"yes\""},{"line_number":278,"context_line":"database_tls_backend_enable: \"yes\""},{"line_number":279,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"237ce53a_4648ade5","line":276,"in_reply_to":"f00066ce_6a00e97f","updated":"2024-04-23 15:30:15.000000000","message":"I moved it to the cells scenario, I hope the tests won\u0027t fail now.","commit_id":"98c7e5493a33b60ed19867d2877289b361d790a4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7e3a5ffbc85c5ae604795f42a78311bf837775ee","unresolved":true,"context_lines":[{"line_number":273,"context_line":"{% raw %}"},{"line_number":274,"context_line":"rabbitmq_tag: \"2023.2-{{ kolla_base_distro }}-{{ kolla_base_distro_version }}{{ openstack_tag_suffix }}\""},{"line_number":275,"context_line":"{% endraw %}"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"0e86eacb_2f946f13","line":276,"updated":"2024-05-21 09:32:22.000000000","message":"nit: unnecessary newline added","commit_id":"6abc47de2b9e1750b7033375b3a4ba7e8c7c495f"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"34b44bbb6234a50f10c63f2692888d6736f4f3b7","unresolved":false,"context_lines":[{"line_number":273,"context_line":"{% raw %}"},{"line_number":274,"context_line":"rabbitmq_tag: \"2023.2-{{ kolla_base_distro }}-{{ kolla_base_distro_version }}{{ openstack_tag_suffix }}\""},{"line_number":275,"context_line":"{% endraw %}"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"ae51b40f_89b7c712","line":276,"in_reply_to":"0e86eacb_2f946f13","updated":"2024-05-21 12:56:20.000000000","message":"Done","commit_id":"6abc47de2b9e1750b7033375b3a4ba7e8c7c495f"}],"tests/test-proxysql.sh":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ef18d2610e4e161ef3a54d4f9443baa7b2616bc2","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    return $result"},{"line_number":19,"context_line":"}"},{"line_number":20,"context_line":"function test_proxysql_ssl_connection {"},{"line_number":21,"context_line":"    querry\u003d\"SELECT SUBSTRING_INDEX(variable_value, \u0027,\u0027, -1) AS \u0027\u0027 FROM information_schema.session_status WHERE variable_name \u003d \u0027Ssl_cipher\u0027 LIMIT 1;\""},{"line_number":22,"context_line":"    result\u003d$(mariadb -h $VIP -P$DATABASE_PORT -u$DATABASE_USER -p$DATABASE_PASSWORD -e \"$querry\" --silent)"},{"line_number":23,"context_line":"    echo $result"},{"line_number":24,"context_line":"    if [[ \"$result\" \u003d~ ^[[:space:]]*$ || -z \"${result}\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"2518c75e_cb8962b5","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":10},"updated":"2024-03-28 11:15:36.000000000","message":"nit: query","commit_id":"0439ac5656a10d602731020a45042a0992977135"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22310ae59aac14d1f9bf20991698b40a935a80f0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    return $result"},{"line_number":19,"context_line":"}"},{"line_number":20,"context_line":"function test_proxysql_ssl_connection {"},{"line_number":21,"context_line":"    querry\u003d\"SELECT SUBSTRING_INDEX(variable_value, \u0027,\u0027, -1) AS \u0027\u0027 FROM information_schema.session_status WHERE variable_name \u003d \u0027Ssl_cipher\u0027 LIMIT 1;\""},{"line_number":22,"context_line":"    result\u003d$(mariadb -h $VIP -P$DATABASE_PORT -u$DATABASE_USER -p$DATABASE_PASSWORD -e \"$querry\" --silent)"},{"line_number":23,"context_line":"    echo $result"},{"line_number":24,"context_line":"    if [[ \"$result\" \u003d~ ^[[:space:]]*$ || -z \"${result}\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"c2763501_c7c1f22d","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":10},"in_reply_to":"2518c75e_cb8962b5","updated":"2024-04-02 10:16:23.000000000","message":"Acknowledged","commit_id":"0439ac5656a10d602731020a45042a0992977135"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ef18d2610e4e161ef3a54d4f9443baa7b2616bc2","unresolved":true,"context_lines":[{"line_number":19,"context_line":"}"},{"line_number":20,"context_line":"function test_proxysql_ssl_connection {"},{"line_number":21,"context_line":"    querry\u003d\"SELECT SUBSTRING_INDEX(variable_value, \u0027,\u0027, -1) AS \u0027\u0027 FROM information_schema.session_status WHERE variable_name \u003d \u0027Ssl_cipher\u0027 LIMIT 1;\""},{"line_number":22,"context_line":"    result\u003d$(mariadb -h $VIP -P$DATABASE_PORT -u$DATABASE_USER -p$DATABASE_PASSWORD -e \"$querry\" --silent)"},{"line_number":23,"context_line":"    echo $result"},{"line_number":24,"context_line":"    if [[ \"$result\" \u003d~ ^[[:space:]]*$ || -z \"${result}\" ]]; then"},{"line_number":25,"context_line":"        echo \"ERROR: SSL is not utilized in ProxySQL\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"666e976d_aa2f247b","line":22,"range":{"start_line":22,"start_character":89,"end_line":22,"end_character":95},"updated":"2024-03-28 11:15:36.000000000","message":"nit: query","commit_id":"0439ac5656a10d602731020a45042a0992977135"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22310ae59aac14d1f9bf20991698b40a935a80f0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"}"},{"line_number":20,"context_line":"function test_proxysql_ssl_connection {"},{"line_number":21,"context_line":"    querry\u003d\"SELECT SUBSTRING_INDEX(variable_value, \u0027,\u0027, -1) AS \u0027\u0027 FROM information_schema.session_status WHERE variable_name \u003d \u0027Ssl_cipher\u0027 LIMIT 1;\""},{"line_number":22,"context_line":"    result\u003d$(mariadb -h $VIP -P$DATABASE_PORT -u$DATABASE_USER -p$DATABASE_PASSWORD -e \"$querry\" --silent)"},{"line_number":23,"context_line":"    echo $result"},{"line_number":24,"context_line":"    if [[ \"$result\" \u003d~ ^[[:space:]]*$ || -z \"${result}\" ]]; then"},{"line_number":25,"context_line":"        echo \"ERROR: SSL is not utilized in ProxySQL\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"b623c56d_f1b8aff4","line":22,"range":{"start_line":22,"start_character":89,"end_line":22,"end_character":95},"in_reply_to":"666e976d_aa2f247b","updated":"2024-04-02 10:16:23.000000000","message":"Acknowledged","commit_id":"0439ac5656a10d602731020a45042a0992977135"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ef18d2610e4e161ef3a54d4f9443baa7b2616bc2","unresolved":true,"context_lines":[{"line_number":154,"context_line":"    vars:"},{"line_number":155,"context_line":"      base_distro: rocky"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"- job:"},{"line_number":158,"context_line":"    name: kolla-ansible-ubuntu-proxysql"},{"line_number":159,"context_line":"    parent: kolla-ansible-proxysql-base"},{"line_number":160,"context_line":"    nodeset: kolla-ansible-jammy-multi"},{"line_number":161,"context_line":"    vars:"},{"line_number":162,"context_line":"      base_distro: ubuntu"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"- job:"},{"line_number":165,"context_line":"    name: kolla-ansible-rocky9-upgrade"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"db54d32e_f9f04669","line":162,"range":{"start_line":157,"start_character":0,"end_line":162,"end_character":25},"updated":"2024-03-28 11:15:36.000000000","message":"@frickler@offenerstapel.de not sure, do we also want debian jobs here?","commit_id":"0439ac5656a10d602731020a45042a0992977135"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"3865228600366446d3b7c7fbaa72a92d0d5d7107","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    vars:"},{"line_number":155,"context_line":"      base_distro: rocky"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"- job:"},{"line_number":158,"context_line":"    name: kolla-ansible-ubuntu-proxysql"},{"line_number":159,"context_line":"    parent: kolla-ansible-proxysql-base"},{"line_number":160,"context_line":"    nodeset: kolla-ansible-jammy-multi"},{"line_number":161,"context_line":"    vars:"},{"line_number":162,"context_line":"      base_distro: ubuntu"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"- job:"},{"line_number":165,"context_line":"    name: kolla-ansible-rocky9-upgrade"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"cd6ac275_a5e50a2c","line":162,"range":{"start_line":157,"start_character":0,"end_line":162,"end_character":25},"in_reply_to":"db54d32e_f9f04669","updated":"2024-04-23 15:32:50.000000000","message":"Acknowledged","commit_id":"0439ac5656a10d602731020a45042a0992977135"}]}