)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cc30cc1f83458506fc7479b52f5215592ae8615a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"89f5472b_b9e59a23","updated":"2024-03-11 23:27:10.000000000","message":"recheck","commit_id":"4e1ded0156fb58059697a23af577dc30fea476ee"}],"ansible/roles/rabbitmq/tasks/precheck.yml":[{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"f49a2947bae0a39a384e850b99a4384c253e5952","unresolved":true,"context_lines":[{"line_number":228,"context_line":"    - name: List RabbitMQ queues"},{"line_number":229,"context_line":"      become: true"},{"line_number":230,"context_line":"      shell:"},{"line_number":231,"context_line":"        # TODO(mattcrees): remove ``| egrep -v \u0027(fanout|reply)\u0027`` once https://review.opendev.org/c/openstack/oslo.messaging/+/888479 is merged."},{"line_number":232,"context_line":"        cmd: \"{{ kolla_container_engine }} exec rabbitmq rabbitmqctl list_queues --silent name type | egrep -v \u0027(fanout|reply)\u0027 | awk \u0027{ print $NF }\u0027\""},{"line_number":233,"context_line":"      register: rabbitmq_queues"},{"line_number":234,"context_line":"      changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7d632482_14bff058","line":231,"updated":"2024-03-06 09:38:56.000000000","message":"Now merged","commit_id":"9949de0724e525da2f1bb57c8cd0dd2f1befe96c"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"7d0640343e30c5c9727cf82ae5f36f77e135dfbc","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    - name: List RabbitMQ queues"},{"line_number":229,"context_line":"      become: true"},{"line_number":230,"context_line":"      shell:"},{"line_number":231,"context_line":"        # TODO(mattcrees): remove ``| egrep -v \u0027(fanout|reply)\u0027`` once https://review.opendev.org/c/openstack/oslo.messaging/+/888479 is merged."},{"line_number":232,"context_line":"        cmd: \"{{ kolla_container_engine }} exec rabbitmq rabbitmqctl list_queues --silent name type | egrep -v \u0027(fanout|reply)\u0027 | awk \u0027{ print $NF }\u0027\""},{"line_number":233,"context_line":"      register: rabbitmq_queues"},{"line_number":234,"context_line":"      changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"140709b7_f36f862f","line":231,"in_reply_to":"7d632482_14bff058","updated":"2024-03-06 10:02:25.000000000","message":"It wasn\u0027t backported though. But good catch, will need to propose this in Caracal.","commit_id":"9949de0724e525da2f1bb57c8cd0dd2f1befe96c"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"f49a2947bae0a39a384e850b99a4384c253e5952","unresolved":true,"context_lines":[{"line_number":244,"context_line":"        fail_msg: \u003e"},{"line_number":245,"context_line":"          om_enable_rabbitmq_quorum_queues is True but non-quorum queues have been found."},{"line_number":246,"context_line":"          Currently the procedure to migrate to quorum queues is manual."},{"line_number":247,"context_line":"          Please follow the process described here: https://docs.openstack.org/kolla-ansible/latest/reference/message-queues/rabbitmq.html#high-availability."},{"line_number":248,"context_line":"          Note that this process may take several hours on larger systems, and may cause a degredation in performance at large scale."},{"line_number":249,"context_line":"          If you do not wish to enable this feature, set om_enable_rabbitmq_quorum_queues to False."},{"line_number":250,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"40da3b21_427b67b0","line":247,"updated":"2024-03-06 09:38:56.000000000","message":"Might be better to direct users to the antelope docs, rather than latest","commit_id":"9949de0724e525da2f1bb57c8cd0dd2f1befe96c"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"7d0640343e30c5c9727cf82ae5f36f77e135dfbc","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        fail_msg: \u003e"},{"line_number":245,"context_line":"          om_enable_rabbitmq_quorum_queues is True but non-quorum queues have been found."},{"line_number":246,"context_line":"          Currently the procedure to migrate to quorum queues is manual."},{"line_number":247,"context_line":"          Please follow the process described here: https://docs.openstack.org/kolla-ansible/latest/reference/message-queues/rabbitmq.html#high-availability."},{"line_number":248,"context_line":"          Note that this process may take several hours on larger systems, and may cause a degredation in performance at large scale."},{"line_number":249,"context_line":"          If you do not wish to enable this feature, set om_enable_rabbitmq_quorum_queues to False."},{"line_number":250,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ad6b4616_9bdba6b1","line":247,"in_reply_to":"40da3b21_427b67b0","updated":"2024-03-06 10:02:25.000000000","message":"Seems sensible, done.","commit_id":"9949de0724e525da2f1bb57c8cd0dd2f1befe96c"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"f49a2947bae0a39a384e850b99a4384c253e5952","unresolved":true,"context_lines":[{"line_number":245,"context_line":"          om_enable_rabbitmq_quorum_queues is True but non-quorum queues have been found."},{"line_number":246,"context_line":"          Currently the procedure to migrate to quorum queues is manual."},{"line_number":247,"context_line":"          Please follow the process described here: https://docs.openstack.org/kolla-ansible/latest/reference/message-queues/rabbitmq.html#high-availability."},{"line_number":248,"context_line":"          Note that this process may take several hours on larger systems, and may cause a degredation in performance at large scale."},{"line_number":249,"context_line":"          If you do not wish to enable this feature, set om_enable_rabbitmq_quorum_queues to False."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"  run_once: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"928b09fa_26c88ab3","line":248,"updated":"2024-03-06 09:38:56.000000000","message":"nit: \"may degrade performance\" is more clear than \"may cause a degradation in performance\"","commit_id":"9949de0724e525da2f1bb57c8cd0dd2f1befe96c"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"7d0640343e30c5c9727cf82ae5f36f77e135dfbc","unresolved":false,"context_lines":[{"line_number":245,"context_line":"          om_enable_rabbitmq_quorum_queues is True but non-quorum queues have been found."},{"line_number":246,"context_line":"          Currently the procedure to migrate to quorum queues is manual."},{"line_number":247,"context_line":"          Please follow the process described here: https://docs.openstack.org/kolla-ansible/latest/reference/message-queues/rabbitmq.html#high-availability."},{"line_number":248,"context_line":"          Note that this process may take several hours on larger systems, and may cause a degredation in performance at large scale."},{"line_number":249,"context_line":"          If you do not wish to enable this feature, set om_enable_rabbitmq_quorum_queues to False."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"  run_once: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"94f12010_24f62c20","line":248,"in_reply_to":"928b09fa_26c88ab3","updated":"2024-03-06 10:02:25.000000000","message":"I agree, but given this is a cherry-pick I think we should avoid making changes that aren\u0027t reflected in the later releases.","commit_id":"9949de0724e525da2f1bb57c8cd0dd2f1befe96c"}]}