)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d06854b73b319cd741a8f8a54241802ec28e687e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"57c28d8f_3d0a0c94","updated":"2024-03-12 13:40:37.000000000","message":"recheck (tooz pinned)","commit_id":"2af7d22c177294ee67e75caaddd9e481a26bbd73"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"21d46de494809f277dc35c9fce9f64a28c315661","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"1cd302ac_424ce965","updated":"2024-05-10 09:11:54.000000000","message":"Needs moving to target stable/2024.1\nRMQ migrations to be removed from master CI.","commit_id":"a0bfe161e54fbb8ad21fedb7f233ef27aa94d3e3"}],"tests/upgrade.sh":[{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"c3aa9060beb8175baf8ba5812bec62d1b03d500d","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    source $KOLLA_ANSIBLE_VENV_PATH/bin/activate"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    # NOTE(mattcrees): As om_enable_rabbitmq_quorum_queues now defaults to true"},{"line_number":16,"context_line":"    # in Bobcat, we need to perform a migration to durable queues during SLURP"},{"line_number":17,"context_line":"    # upgrades from Antelope."},{"line_number":18,"context_line":"    # TODO(mattcrees): Remove in Dalmation."},{"line_number":19,"context_line":"    if [[ $IS_SLURP ]]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"4a444f5f_064b1007","line":16,"updated":"2024-03-06 10:07:01.000000000","message":"Caracal","commit_id":"0e6a9bc64055eec482226e37cefe23d907c89525"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"cac2c6c5c7be16fe2cb48fa7378d582966272ca0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    source $KOLLA_ANSIBLE_VENV_PATH/bin/activate"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    # NOTE(mattcrees): As om_enable_rabbitmq_quorum_queues now defaults to true"},{"line_number":16,"context_line":"    # in Bobcat, we need to perform a migration to durable queues during SLURP"},{"line_number":17,"context_line":"    # upgrades from Antelope."},{"line_number":18,"context_line":"    # TODO(mattcrees): Remove in Dalmation."},{"line_number":19,"context_line":"    if [[ $IS_SLURP ]]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"0090ce98_4417ca04","line":16,"in_reply_to":"4a444f5f_064b1007","updated":"2024-03-06 10:12:55.000000000","message":"I\u0027ve updated the wording so it is clearer what I meant here.","commit_id":"0e6a9bc64055eec482226e37cefe23d907c89525"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9e7c1473dc7246020ca91f94418eac34c72c46ab","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    # from Bobcat, we need to perform a migration to durable queues during"},{"line_number":17,"context_line":"    # SLURP upgrades from Antelope to Caracal."},{"line_number":18,"context_line":"    # TODO(mattcrees): Remove in Dalmatian."},{"line_number":19,"context_line":"    if $IS_SLURP; then"},{"line_number":20,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --skip-tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/upgrade-prechecks-slurp"},{"line_number":21,"context_line":"        SERVICE_TAGS\u003d\"heat,keystone,neutron,nova\""},{"line_number":22,"context_line":"        if [[ $SCENARIO \u003d\u003d \"zun\" ]] || [[ $SCENARIO \u003d\u003d \"cephadm\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":8,"id":"1ac105b1_c6c40250","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":16},"updated":"2024-03-14 15:57:54.000000000","message":"this is just wrong, we set `is_slurp` to \"yes\", e.g. in jobs.yaml\n\nwhat this then does, is, call in bash `if yes; then`\n\nnow if the binary \"yes\" is installed this get\u0027s executed forever, spilling \"y\" on the command line.\n\nbash is not python, please make a real test if the variable is set and to what value.\n\nThe default value we seem to set is `false` in base.yaml\n\nso e.g.:\n\n```\nif [[ \"$IS_SLURP\" \u003d\u003d \"yes\" ]]\n```\n\nwould fix this and also ensure proper quoting.","commit_id":"7282cb12f340619e1de1554e4089de82014da59e"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"e069ab2b18ea08bd800ffb6cd923a07710c42619","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    # from Bobcat, we need to perform a migration to durable queues during"},{"line_number":17,"context_line":"    # SLURP upgrades from Antelope to Caracal."},{"line_number":18,"context_line":"    # TODO(mattcrees): Remove in Dalmatian."},{"line_number":19,"context_line":"    if $IS_SLURP; then"},{"line_number":20,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --skip-tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/upgrade-prechecks-slurp"},{"line_number":21,"context_line":"        SERVICE_TAGS\u003d\"heat,keystone,neutron,nova\""},{"line_number":22,"context_line":"        if [[ $SCENARIO \u003d\u003d \"zun\" ]] || [[ $SCENARIO \u003d\u003d \"cephadm\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":8,"id":"6fbf8daa_6d4a2a06","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":16},"in_reply_to":"1ac105b1_c6c40250","updated":"2024-03-14 17:36:30.000000000","message":"Thanks for the explanation, I\u0027ve updated to your suggested fix.","commit_id":"7282cb12f340619e1de1554e4089de82014da59e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a0900cf9182b1896ad49d0e63ffb990f77a1ebdf","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv pull \u0026\u003e /tmp/logs/ansible/pull-upgrade"},{"line_number":49,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv upgrade \u0026\u003e /tmp/logs/ansible/upgrade"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    if $IS_SLURP; then"},{"line_number":52,"context_line":"        # Check that all appropriate RabbitMQ queues are now quorum queues."},{"line_number":53,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/rabbitmq-ha-precheck"},{"line_number":54,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"f2afd373_55918be0","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":2},"updated":"2024-03-14 16:02:37.000000000","message":"see my comment above.\n\na good source, by the way, for common bash pitfalls are these:\n\nhttps://github.com/rawiriblundell/wiki.bash-hackers.org/blob/main/syntax/ccmd/conditional_expression.md\n\nhttps://mywiki.wooledge.org/BashPitfalls\n\nhttps://www.shellcheck.net/wiki/\n\nHTH","commit_id":"7282cb12f340619e1de1554e4089de82014da59e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c78afccf19e4b2279be1689c941b9296ecac153b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv pull \u0026\u003e /tmp/logs/ansible/pull-upgrade"},{"line_number":49,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv upgrade \u0026\u003e /tmp/logs/ansible/upgrade"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    if $IS_SLURP; then"},{"line_number":52,"context_line":"        # Check that all appropriate RabbitMQ queues are now quorum queues."},{"line_number":53,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/rabbitmq-ha-precheck"},{"line_number":54,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"1aeee8a7_c45575b6","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":2},"in_reply_to":"709fd0f7_23a88a19","updated":"2024-03-18 10:35:25.000000000","message":"I\u0027m actually in the process of adding more bash CI coverage, because this change - I really don\u0027t want to pick on your personally here! - just shows how bad we are all when it comes to bash coding, it\u0027s really really easy to make grave mistakes in bash, I have done enough of them myself in over 12 years now.\n\nIf you are interested, check: https://review.opendev.org/c/openstack/kolla-ansible/+/882497\n\nalmost all CI jobs run now and I hope I can merge it soon. But be warned, it complains a lot about bash code ;)","commit_id":"7282cb12f340619e1de1554e4089de82014da59e"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"e069ab2b18ea08bd800ffb6cd923a07710c42619","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv pull \u0026\u003e /tmp/logs/ansible/pull-upgrade"},{"line_number":49,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv upgrade \u0026\u003e /tmp/logs/ansible/upgrade"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    if $IS_SLURP; then"},{"line_number":52,"context_line":"        # Check that all appropriate RabbitMQ queues are now quorum queues."},{"line_number":53,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/rabbitmq-ha-precheck"},{"line_number":54,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"709fd0f7_23a88a19","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":2},"in_reply_to":"f2afd373_55918be0","updated":"2024-03-14 17:36:30.000000000","message":"Cheers Sven, clearly my inexperience with bash is showing :)","commit_id":"7282cb12f340619e1de1554e4089de82014da59e"},{"author":{"_account_id":36781,"name":"Massimiliano Favaro-Bedford","display_name":"Max","email":"max@stackhpc.com","username":"MaxBed4d"},"change_message_id":"f7572b119527947d45f8a6affbfab66f74bbafba","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    # from Bobcat, we need to perform a migration to durable queues during"},{"line_number":17,"context_line":"    # SLURP upgrades from Antelope to Caracal."},{"line_number":18,"context_line":"    # TODO(mattcrees): Remove in Dalmatian."},{"line_number":19,"context_line":"    if [[ \"$IS_SLURP\" \u003d\u003d \"yes\" ]]; then"},{"line_number":20,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --skip-tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/upgrade-prechecks-slurp"},{"line_number":21,"context_line":"        SERVICE_TAGS\u003d\"heat,keystone,neutron,nova\""},{"line_number":22,"context_line":"        if [[ $SCENARIO \u003d\u003d \"zun\" ]] || [[ $SCENARIO \u003d\u003d \"cephadm\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":9,"id":"26d793f2_0f50df13","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":39},"updated":"2024-03-15 11:19:24.000000000","message":"This variable comes from an Ansible playbook which, when set to \u0027yes\u0027, will be interpreted as a boolean variable and as such cannot be interpreted as a string. \n\nThus, to resolve this, change this line to:\n\n    if $IS_SLURP; then\n\nThe same will need to be done for a similar \u0027if\u0027 statement further on below, however, the \"SCENARIO\" variables should be strings and can be left as they are.","commit_id":"3f047028bd0cb1779b62c1a751f072cdda84fbdb"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8b1b94af0f6ca8f45d09923edd045b13062f18fd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    # from Bobcat, we need to perform a migration to durable queues during"},{"line_number":17,"context_line":"    # SLURP upgrades from Antelope to Caracal."},{"line_number":18,"context_line":"    # TODO(mattcrees): Remove in Dalmatian."},{"line_number":19,"context_line":"    if [[ \"$IS_SLURP\" \u003d\u003d \"yes\" ]]; then"},{"line_number":20,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --skip-tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/upgrade-prechecks-slurp"},{"line_number":21,"context_line":"        SERVICE_TAGS\u003d\"heat,keystone,neutron,nova\""},{"line_number":22,"context_line":"        if [[ $SCENARIO \u003d\u003d \"zun\" ]] || [[ $SCENARIO \u003d\u003d \"cephadm\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":9,"id":"698ab469_a5f51f0e","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":39},"in_reply_to":"26d793f2_0f50df13","updated":"2024-03-18 10:37:41.000000000","message":"this is wrong, as I already explained in a acknowledged comment.\n\nPlease look up how to check the contents of a variable in bash first, before giving wrong advice. Bash is not python.\n\nThanks.","commit_id":"3f047028bd0cb1779b62c1a751f072cdda84fbdb"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c78afccf19e4b2279be1689c941b9296ecac153b","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    # from Bobcat, we need to perform a migration to durable queues during"},{"line_number":17,"context_line":"    # SLURP upgrades from Antelope to Caracal."},{"line_number":18,"context_line":"    # TODO(mattcrees): Remove in Dalmatian."},{"line_number":19,"context_line":"    if [[ $IS_SLURP \u003d\u003d \"True\" ]]; then"},{"line_number":20,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --skip-tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/upgrade-prechecks-slurp"},{"line_number":21,"context_line":"        SERVICE_TAGS\u003d\"heat,keystone,neutron,nova\""},{"line_number":22,"context_line":"        if [[ $SCENARIO \u003d\u003d \"zun\" ]] || [[ $SCENARIO \u003d\u003d \"cephadm\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":10,"id":"bc79cb25_f71508e1","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":38},"updated":"2024-03-18 10:35:25.000000000","message":"I\u0027m very sorry to complain again, but I don\u0027t think this works!\n\ngrepping our codebase for `is_slurp` - the yaml variable we use to set the bash variable `IS_SLURP` here, I only find results in `zuul.d/base.yaml` and `zuul.d/jobs.yaml`\n\nin base.yaml it is set to `false` and in jobs.yaml it is always only set to `yes`.\n\nas I don\u0027t see any conversion taking place here or elsewhere in the code (so no casting from string to boolean or the like) I think these are just string values.\n\nAs a side note, bash has not really good boolean value support.\n\nso if you check the way you do this doesn\u0027t work:\n\n```\n bash --version\nGNU bash, Version 5.2.26(1)-release (x86_64-redhat-linux-gnu)\n[[ \"yes\" \u003d\u003d \"True\" ]] \u0026\u0026 echo \"yes equals true\" || echo \"this is not how bash works\";\nthis is not how bash works\n```\n\nso please just adjust this to - or adjust the variable in base.yaml and jobs.yaml to `true|false`:\n\n```\nif [[ \"$IS_SLURP\" \u003d\u003d \"yes\" ]]; then\n```\n\nalso please always quote bash variables.","commit_id":"3233068d3da438ab6c252a103c8c020b9504d2fa"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"5dad02a21a09276bd6091c784c0a8f4fad438674","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    # from Bobcat, we need to perform a migration to durable queues during"},{"line_number":17,"context_line":"    # SLURP upgrades from Antelope to Caracal."},{"line_number":18,"context_line":"    # TODO(mattcrees): Remove in Dalmatian."},{"line_number":19,"context_line":"    if [[ $IS_SLURP \u003d\u003d \"True\" ]]; then"},{"line_number":20,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --skip-tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/upgrade-prechecks-slurp"},{"line_number":21,"context_line":"        SERVICE_TAGS\u003d\"heat,keystone,neutron,nova\""},{"line_number":22,"context_line":"        if [[ $SCENARIO \u003d\u003d \"zun\" ]] || [[ $SCENARIO \u003d\u003d \"cephadm\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":10,"id":"a71a48d5_171cd501","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":38},"in_reply_to":"30bd8afb_7c838f65","updated":"2024-03-18 10:58:53.000000000","message":"So I tried setting ``if [[ \"$IS_SLURP\" \u003d\u003d \"yes\" ]]; then`` in patchset 9 and this was failing, we can see that the slurp code path was not executed: https://zuul.opendev.org/t/openstack/build/ea7f220e50b04a6fa087b678ad324c81/logs\n\nMax and I have tested the behaviour with the following scripts, and we are seeing that setting the ansible var ``is_slurp: yes`` will result in ``IS_SLURP\u003dTrue``:\n\n```\n---\n- hosts: localhost\n  gather_facts: no\n  vars:\n    is_slurp: yes\n  tasks:\n  - name: Run ifstatement.sh script\n    shell:\n      cmd: ./ifstatement.sh\n      executable: /bin/bash\n    environment:\n      IS_SLURP: \"{{ is_slurp }}\"\n    register: output\n\n  - name: Print\n    debug:\n      var: output\n```\n\n```\n#!/bin/bash\n\nprintf \"The value of IS_SLURP is: $IS_SLURP\"\n\nfunction upgrade {\n    if  [[ \"$IS_SLURP\" \u003d\u003d \"True\" ]]; then\n        printf \"Migrating RabbitMQ queues to durable\"\n    else\n        printf \"No need to upgrade\"\n        # printf \"kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks \u0026\u003e /tmp/logs/ansible/upgrade-prechecks\"\n    fi\n    }\n\n upgrade\n```\n\n```\nTASK [Print] ******\nok: [localhost] \u003d\u003e {\n    \"output.stdout\": \"The value of IS_SLURP is: TrueMigrating RabbitMQ queues to durable\"\n}\n```\n\nPerhaps as you say we should move to explicitly setting the environment variable ``IS_SLURP`` to 0/1 to avoid the confusion here at all.","commit_id":"3233068d3da438ab6c252a103c8c020b9504d2fa"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"9cab542d8fa982494d917e05b837adab0af28ae4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    # from Bobcat, we need to perform a migration to durable queues during"},{"line_number":17,"context_line":"    # SLURP upgrades from Antelope to Caracal."},{"line_number":18,"context_line":"    # TODO(mattcrees): Remove in Dalmatian."},{"line_number":19,"context_line":"    if [[ $IS_SLURP \u003d\u003d \"True\" ]]; then"},{"line_number":20,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --skip-tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/upgrade-prechecks-slurp"},{"line_number":21,"context_line":"        SERVICE_TAGS\u003d\"heat,keystone,neutron,nova\""},{"line_number":22,"context_line":"        if [[ $SCENARIO \u003d\u003d \"zun\" ]] || [[ $SCENARIO \u003d\u003d \"cephadm\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":10,"id":"abbb92f9_1636f4bf","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":38},"in_reply_to":"7d322778_7d3f2e35","updated":"2024-03-21 09:20:51.000000000","message":"Appreciate all your patience Sven :)\n\nI\u0027ve changed to set ``is_slurp: True`` as I agree this makes it clearer.","commit_id":"3233068d3da438ab6c252a103c8c020b9504d2fa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1337b6a9fa54102f0a498c2ac72a06ea6b7a4c1a","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    # from Bobcat, we need to perform a migration to durable queues during"},{"line_number":17,"context_line":"    # SLURP upgrades from Antelope to Caracal."},{"line_number":18,"context_line":"    # TODO(mattcrees): Remove in Dalmatian."},{"line_number":19,"context_line":"    if [[ $IS_SLURP \u003d\u003d \"True\" ]]; then"},{"line_number":20,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --skip-tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/upgrade-prechecks-slurp"},{"line_number":21,"context_line":"        SERVICE_TAGS\u003d\"heat,keystone,neutron,nova\""},{"line_number":22,"context_line":"        if [[ $SCENARIO \u003d\u003d \"zun\" ]] || [[ $SCENARIO \u003d\u003d \"cephadm\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":10,"id":"7d322778_7d3f2e35","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":38},"in_reply_to":"a71a48d5_171cd501","updated":"2024-03-20 13:01:33.000000000","message":"this is the case, because ansible automatically converts your environment variable `IS_SLURP: {{ is_slurp }}` (where is_slurp is set to yes) automatically to true during rendering, see e.g. here:\n\nhttps://github.com/ansible/ansible/issues/11905#issuecomment-130496173\n\nthe tl;dr is that ansible automatically converts all strings that it can identify as a boolean to true|false (see the linked comment for the list).\n\nStill these end up as strings in bash, not as boolean values.\n\nso imho it would be better to also fix the occasions where we set this to yes to explicitly set this to true instead and don\u0027t rely on ansibles auto conversion here (at least it makes the code harder to read/grep imho).\n\nI\u0027m also wondering why ansible-lint doesn\u0027t complain that we use \"yes\" instead of \"true\" at some occasions. I think this was a warning in the past at least.\n\nI don\u0027t think it is worth it to convert any string to a boolean value in bash, because the string comparison just works as well and the general \"data type\" support in bash is very poor, so most stuff ends up being a string in bash anyway.\n\nSo I would leave this as it is now, if you ask for my opinion.\n\nThanks for your investigation! I somehow forgot about the ansible automatic conversion (it\u0027s not really good documented tbh).","commit_id":"3233068d3da438ab6c252a103c8c020b9504d2fa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fcb33d3db428e040e6e5d16e06cacbf7234fd079","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    # from Bobcat, we need to perform a migration to durable queues during"},{"line_number":17,"context_line":"    # SLURP upgrades from Antelope to Caracal."},{"line_number":18,"context_line":"    # TODO(mattcrees): Remove in Dalmatian."},{"line_number":19,"context_line":"    if [[ $IS_SLURP \u003d\u003d \"True\" ]]; then"},{"line_number":20,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --skip-tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/upgrade-prechecks-slurp"},{"line_number":21,"context_line":"        SERVICE_TAGS\u003d\"heat,keystone,neutron,nova\""},{"line_number":22,"context_line":"        if [[ $SCENARIO \u003d\u003d \"zun\" ]] || [[ $SCENARIO \u003d\u003d \"cephadm\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":10,"id":"30bd8afb_7c838f65","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":38},"in_reply_to":"bc79cb25_f71508e1","updated":"2024-03-18 10:43:03.000000000","message":"for more context, if you really want to utilize boolean values in bash, you have to go with `0` and `1`, so you would still need to convert your code accordingly.\n\nif you have anything from python/yaml like \"yes,true,false,no\" these are all strings in bash, not boolean values! So you need to do string comparisons on these, because these are strings in bash.\n\nsee e.g. https://ioflood.com/blog/bash-boolean/ there are countless articles about this.","commit_id":"3233068d3da438ab6c252a103c8c020b9504d2fa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"14d8a0dde7611e3993a4867f1fa34eb202d67abd","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    # NOTE(mattcrees): As om_enable_rabbitmq_quorum_queues now defaults to true"},{"line_number":16,"context_line":"    # from Bobcat, we need to perform a migration to durable queues during"},{"line_number":17,"context_line":"    # SLURP upgrades from Antelope to Caracal."},{"line_number":18,"context_line":"    # TODO(mattcrees): Remove in Dalmatian."},{"line_number":19,"context_line":"    if [[ $IS_SLURP \u003d\u003d \"True\" ]]; then"},{"line_number":20,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --skip-tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/upgrade-prechecks-slurp"},{"line_number":21,"context_line":"        SERVICE_TAGS\u003d\"heat,keystone,neutron,nova\""}],"source_content_type":"text/x-sh","patch_set":15,"id":"8bb30c68_7875d66f","line":18,"range":{"start_line":17,"start_character":2,"end_line":18,"end_character":43},"updated":"2024-03-28 12:43:49.000000000","message":"I know we use this pattern a lot, but I wonder if it wouldn\u0027t just be more robust to check for the actual release here? e.g. do this migration only during upgrade from antelope to caracal? so e.g. check for the openstack_release_name instead of simply checking for IS_SLURP? This way this does not break in Dalmatian? (Well I guess it doesn\u0027t break, it\u0027s just not necessary there).\n\nWhat do you think?","commit_id":"4d498967a0c92eeaa3aecd86824457a66048f9b4"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"caf66ff2ba78c6711c0c9f2a64fea022474d9d11","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    # NOTE(mattcrees): As om_enable_rabbitmq_quorum_queues now defaults to true"},{"line_number":16,"context_line":"    # from Bobcat, we need to perform a migration to durable queues during"},{"line_number":17,"context_line":"    # SLURP upgrades from Antelope to Caracal."},{"line_number":18,"context_line":"    # TODO(mattcrees): Remove in Dalmatian."},{"line_number":19,"context_line":"    if [[ $IS_SLURP \u003d\u003d \"True\" ]]; then"},{"line_number":20,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --skip-tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/upgrade-prechecks-slurp"},{"line_number":21,"context_line":"        SERVICE_TAGS\u003d\"heat,keystone,neutron,nova\""}],"source_content_type":"text/x-sh","patch_set":15,"id":"a13a5258_a012ca0d","line":18,"range":{"start_line":17,"start_character":2,"end_line":18,"end_character":43},"in_reply_to":"8bb30c68_7875d66f","updated":"2024-04-26 15:31:09.000000000","message":"I get what you\u0027re saying here, it\u0027s not ideal to carry around TODOs that could be solved by a check instead. However, in this case we won\u0027t need any of the queue migrations code in CI after Caracal. As such, there will not need to be any different behaviour between the regular and SLURP upgrades so we wouldn\u0027t need a release check at all.","commit_id":"4d498967a0c92eeaa3aecd86824457a66048f9b4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5dc6412df81b3ddbe5836e558a198d74e10c706b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    # NOTE(mattcrees): As om_enable_rabbitmq_quorum_queues now defaults to true"},{"line_number":16,"context_line":"    # from Bobcat, we need to perform a migration to durable queues during"},{"line_number":17,"context_line":"    # SLURP upgrades from Antelope to Caracal."},{"line_number":18,"context_line":"    # TODO(mattcrees): Remove in Dalmatian."},{"line_number":19,"context_line":"    if [[ $IS_SLURP \u003d\u003d \"True\" ]]; then"},{"line_number":20,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --skip-tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/upgrade-prechecks-slurp"},{"line_number":21,"context_line":"        SERVICE_TAGS\u003d\"heat,keystone,neutron,nova\""}],"source_content_type":"text/x-sh","patch_set":15,"id":"e374e100_5a63059d","line":18,"range":{"start_line":17,"start_character":2,"end_line":18,"end_character":43},"in_reply_to":"a13a5258_a012ca0d","updated":"2024-04-29 15:04:20.000000000","message":"Acknowledged","commit_id":"4d498967a0c92eeaa3aecd86824457a66048f9b4"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"85059d491acc3d39690d65bcc7febc08557c9a49","unresolved":true,"context_lines":[{"line_number":190,"context_line":"      base_distro: debian"},{"line_number":191,"context_line":"      is_upgrade: yes"},{"line_number":192,"context_line":"      is_slurp: yes"},{"line_number":193,"context_line":"      previous_release: 2023.1"},{"line_number":194,"context_line":"      tls_enabled: true"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"2cc66727_20fb0622","side":"PARENT","line":193,"range":{"start_line":193,"start_character":0,"end_line":193,"end_character":2},"updated":"2024-03-21 09:23:41.000000000","message":"isn\u0027t this needed anymore?\nthe other jobs still have it?","commit_id":"1e971bca4037871d06b5d836d1e928f3689657ed"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"fe36d625ced04cbe030f36549a2fe5780acd0dcf","unresolved":false,"context_lines":[{"line_number":190,"context_line":"      base_distro: debian"},{"line_number":191,"context_line":"      is_upgrade: yes"},{"line_number":192,"context_line":"      is_slurp: yes"},{"line_number":193,"context_line":"      previous_release: 2023.1"},{"line_number":194,"context_line":"      tls_enabled: true"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"d0823ea6_97755cb5","side":"PARENT","line":193,"range":{"start_line":193,"start_character":0,"end_line":193,"end_character":2},"in_reply_to":"2cc66727_20fb0622","updated":"2024-03-21 09:40:10.000000000","message":"My bad, I deleted this line by mistake.","commit_id":"1e971bca4037871d06b5d836d1e928f3689657ed"}]}