)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"e2e5a49c8e2870492bbbb881e841e0856360f496","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b20e048a_6b72e648","updated":"2024-04-19 14:11:54.000000000","message":"Looks nice. I think reno would be useful with this feature - that it is now a variable to define cinder config for HA supported backends - also useful for possible backports release notes. Maybe also commit message expanded with similar info as in docs would be good for future reference.","commit_id":"01a35892d694eb3a2d4d0db3bc18f1408a1c8768"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"11d8fdaaa8e11eaeef4040d1fc2f4271fd66309a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d7e455f6_7bc252cf","in_reply_to":"263332d3_90b01b32","updated":"2024-04-22 13:04:06.000000000","message":"Done","commit_id":"01a35892d694eb3a2d4d0db3bc18f1408a1c8768"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a1b67ef8c35548ac50b92124c477b4c359573e10","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"263332d3_90b01b32","in_reply_to":"b20e048a_6b72e648","updated":"2024-04-22 12:53:27.000000000","message":"agreed, and I don\u0027t think it\u0027s resolved just now :)","commit_id":"01a35892d694eb3a2d4d0db3bc18f1408a1c8768"},{"author":{"_account_id":36045,"name":"Yusuf Güngör","email":"yusufyusufyusuf@gmail.com"},"change_message_id":"b4904d850885902a44383d56a5fbf7f25d31be8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f0bc01c7_612b7fb2","updated":"2024-05-21 13:58:21.000000000","message":"After enabling the cluster config, all existing volumes cluster_name column updated on database. If user want to remove the cluster config, db records not updated and this cause troubles like deleting existing volumes.\n\nEven removing the cluster config, cluster definitions still exist and cinder-manage command can not remove them, it says backend hosts exist.\n\nWe have found a hack way like below to undo cluster config. Should kolla-ansible consider this scenario? Do you know any method to undo cluster config?\n\n1. remove the cluster config from cinder.conf and reconfigure\n2. disable and remove the all volume backends like below!\n\nopenstack volume service set --disable \u003call_volume_services\u003e\ncinder-manage service remove cinder-volume \u003call_volume_services\u003e (run from any cinder container)\n\n3. remove the cluster defination via cinder-manage (run from any cinder container)\n\ncinder-manage cluster list\ncinder-manage cluster remove\n\n4. connect to the DB and update the existing volume records\n\n\"select id,cluster_name  from cinder.volumes where cluster_name is not NULL;\"\n\n\"update cinder.volumes set cluster_name\u003dNULL where cluster_name is not NULL;\"\n\nafter these we are able to undo cluster configuration.","commit_id":"7a620f0228fe6e98291fc929ffadb493ea5341a9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"363067b76fd471a1cd0c7dd49cf4c1a0256aa859","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a8025f54_1d42f5dc","in_reply_to":"0b856436_37b119c3","updated":"2024-05-28 09:54:01.000000000","message":"I think it would be good and enough to document the drawback like:\n\n\"before removing cluster config, ensure that all cinder volumes need to be updated in the database like this: [..]\"\n\nmaybe that is even documented in cinder already and we can point to that?","commit_id":"7a620f0228fe6e98291fc929ffadb493ea5341a9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c3d35b97eeaefccb0538f73385cb45563f299708","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"61793231_ccabd598","in_reply_to":"27312433_3542ef3e","updated":"2024-07-15 07:42:31.000000000","message":"First of all - I feel that the steps required to remove a cluster config should be a Cinder bug - have you raised one Yusuf?\nOnce there\u0027s a bug record in Launchpad - we can add that to Kolla-Ansible docs for posterity.","commit_id":"7a620f0228fe6e98291fc929ffadb493ea5341a9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6f66962ae29f0fff943b7b544725f7cc45a74456","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"21867c3e_3139ca76","in_reply_to":"61793231_ccabd598","updated":"2024-10-25 09:40:34.000000000","message":"Done","commit_id":"7a620f0228fe6e98291fc929ffadb493ea5341a9"},{"author":{"_account_id":36045,"name":"Yusuf Güngör","email":"yusufyusufyusuf@gmail.com"},"change_message_id":"7bbff1bbb4f88f9687cd8ff9a4910f22ded09cf2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"27312433_3542ef3e","in_reply_to":"a8025f54_1d42f5dc","updated":"2024-05-29 07:12:06.000000000","message":"Hi Jens, Sven\n\nI am not certainly sure but i have read a comment like below:\n\n\u003eAlso, notice this turns on clustering for all backends. I.e., enabling Ceph \u003esuddenly makes other backends try active-active HA only to fail (see \u003ehttps://review.opendev.org/c/openstack/kolla-ansible/+/847352). Also, other \u003ebackends than Ceph might benefit from this setting (netapp, pure). I suggest we \u003eonly document the way to get active-active HA and not force it on users at all. \u003eWDYT?\n\nThe comment exist for an old review which focused enable cluster config for rbd and abandoned: \n\ncinder: start using active-active for rbd : https://review.opendev.org/c/openstack/kolla-ansible/+/763011\n\nI have thought that, cluster config given under [default] section for cinder.conf and it activates the cluster config for all backends. If not all backends supporting the Active-Active then user may want to remove the cluster configuration. As i said, removing the cluster config is not enough to undo the cluster config.","commit_id":"7a620f0228fe6e98291fc929ffadb493ea5341a9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9adaaa930488bd6adfc25b9bea710e02e7ea8e0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0b856436_37b119c3","in_reply_to":"f0bc01c7_612b7fb2","updated":"2024-05-27 18:51:21.000000000","message":"Why would one want to remove the cluster configuration, is there any drawback connected to it?","commit_id":"7a620f0228fe6e98291fc929ffadb493ea5341a9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"363067b76fd471a1cd0c7dd49cf4c1a0256aa859","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6a8331ba_779aad20","updated":"2024-05-28 09:54:01.000000000","message":"ack to most of fricklers comments (I don\u0027t think we really need to warn users if they implemented this themselves, they are on their own anyway).\n\nspecifically I think a short sentence should be added that you can\u0027t easily rollback into an \"unclustered\" state without manually going into the DB.","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fea529be83b6a19dd0051e646b971fc263d1a938","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"05613400_6f1b145b","updated":"2024-05-27 15:55:04.000000000","message":"not sure about backport voting, this could be viewed as a \"bug\" we might want to backport the fix for?","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9adaaa930488bd6adfc25b9bea710e02e7ea8e0b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cbd7c85c_3aa017fb","in_reply_to":"05613400_6f1b145b","updated":"2024-05-27 18:51:21.000000000","message":"Adding new variables is always a difficult thing to do for backports, deployments can have the functionality via an extra config snippet anyway.","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"363067b76fd471a1cd0c7dd49cf4c1a0256aa859","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"63eef4ba_65dbc21a","in_reply_to":"cbd7c85c_3aa017fb","updated":"2024-05-28 09:54:01.000000000","message":"Acknowledged","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"76e259e1da00eac8a7aaa35aefa2897607f00471","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"19ca3d6d_c331e38e","updated":"2024-09-10 13:52:06.000000000","message":"Are u sure it\u0027s good idea to provide variable for skip check  ? \nIf i am correct and user will just skip prechecks and upgrade with some default cluster value ... it will not work anymore, or better said new volumes will be ok but not old ones.","commit_id":"c8cab1b9bec3025c09d7cbd17a8291643f4fe103"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2e748ff0cf80dcda708de2fd7e735ad4fd26b938","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d589b63d_c50254b3","updated":"2024-10-25 09:51:10.000000000","message":"LGTM; docs seem complete, tests seem to pass.","commit_id":"c8cab1b9bec3025c09d7cbd17a8291643f4fe103"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8dbd77b5e71107390f827d012b68776a14b70ccf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1172457d_45851bba","updated":"2024-10-25 14:41:02.000000000","message":"anyway lets save the CI ;)","commit_id":"c8cab1b9bec3025c09d7cbd17a8291643f4fe103"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d0c787b51b20fdf588fdf6f059f06e435efe71bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b5516a27_cfc583c9","updated":"2024-10-25 10:22:12.000000000","message":"recheck logs expired - rocky9-cephadm job was failing, better check whether it might be related","commit_id":"c8cab1b9bec3025c09d7cbd17a8291643f4fe103"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"311b76bc00542a8df9d800be79a0d994370ff8a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9db7842f_1b8ba273","updated":"2024-10-25 14:23:12.000000000","message":"recheck ubuntu cephadm should be fine now","commit_id":"c8cab1b9bec3025c09d7cbd17a8291643f4fe103"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a6fbb6a653dfa090a888bcf2071df24c8487f60d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"f750e7e5_248a144c","in_reply_to":"19ca3d6d_c331e38e","updated":"2024-10-25 09:33:07.000000000","message":"This is user\u0027s choice, we can only warn that he\u0027s using Cinder in a non-effective way, after changing from non-clustered to cluster cinder will manage ownership in a way that old volumes work as well.","commit_id":"c8cab1b9bec3025c09d7cbd17a8291643f4fe103"}],"ansible/roles/cinder/tasks/precheck.yml":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"a7f2e0cd2fcebbd8d1e10acc6abcf9c248112a4d","unresolved":true,"context_lines":[{"line_number":71,"context_line":"  assert:"},{"line_number":72,"context_line":"    that:"},{"line_number":73,"context_line":"      - cinder_cluster_name !\u003d \"\""},{"line_number":74,"context_line":"    msg: \"Multiple cinder-volume instances detected but cinder_cluster_name is not set - please see Kolla-Ansible documentation for guidance.\""},{"line_number":75,"context_line":"  when:"},{"line_number":76,"context_line":"    - not cinder_cluster_skip_precheck"},{"line_number":77,"context_line":"    - groups[\u0027cinder-volume\u0027] | length \u003e 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d3f25301_ce46ab89","line":74,"updated":"2024-03-01 15:45:24.000000000","message":"Can we link to the docs here?","commit_id":"6a43781bff8a90c3f9a0aea54bd3f082c1a0cddf"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"39d9ec9b209924369806658aa4b1b03e90fc150b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  assert:"},{"line_number":72,"context_line":"    that:"},{"line_number":73,"context_line":"      - cinder_cluster_name !\u003d \"\""},{"line_number":74,"context_line":"    msg: \"Multiple cinder-volume instances detected but cinder_cluster_name is not set - please see Kolla-Ansible documentation for guidance.\""},{"line_number":75,"context_line":"  when:"},{"line_number":76,"context_line":"    - not cinder_cluster_skip_precheck"},{"line_number":77,"context_line":"    - groups[\u0027cinder-volume\u0027] | length \u003e 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4fa4663d_2c1f8e1e","line":74,"in_reply_to":"d3f25301_ce46ab89","updated":"2024-04-19 12:25:32.000000000","message":"Done","commit_id":"6a43781bff8a90c3f9a0aea54bd3f082c1a0cddf"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"01b64cc0337b5c7bb5f1cd5c89d9ff9644785e0f","unresolved":true,"context_lines":[{"line_number":71,"context_line":"  assert:"},{"line_number":72,"context_line":"    that:"},{"line_number":73,"context_line":"      - cinder_cluster_name !\u003d \"\""},{"line_number":74,"context_line":"    msg: \"Multiple cinder-volume instances detected but cinder_cluster_name is not set - please see https://docs.openstack.org/kolla-ansible/latest/reference/storage/cinder-guide.html#ha for guidance.\""},{"line_number":75,"context_line":"  when:"},{"line_number":76,"context_line":"    - not cinder_cluster_skip_precheck"},{"line_number":77,"context_line":"    - groups[\u0027cinder-volume\u0027] | length \u003e 1"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"eb2428c7_ad76e54e","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":2},"updated":"2024-04-30 09:55:02.000000000","message":"do we want to add an additional precheck to detect the reverse as well?\nso cinder_cluster_name set, but not multiple cinder-volume instances configured?\n\nBecause we do check this in: https://review.opendev.org/c/openstack/kolla-ansible/+/909974/6/ansible/roles/cinder/templates/cinder.conf.j2#23\nbefore we set the actual cluster_name.","commit_id":"7a620f0228fe6e98291fc929ffadb493ea5341a9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b28663cea861f82a0f492d8a3c159c33f922e14d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  assert:"},{"line_number":72,"context_line":"    that:"},{"line_number":73,"context_line":"      - cinder_cluster_name !\u003d \"\""},{"line_number":74,"context_line":"    msg: \"Multiple cinder-volume instances detected but cinder_cluster_name is not set - please see https://docs.openstack.org/kolla-ansible/latest/reference/storage/cinder-guide.html#ha for guidance.\""},{"line_number":75,"context_line":"  when:"},{"line_number":76,"context_line":"    - not cinder_cluster_skip_precheck"},{"line_number":77,"context_line":"    - groups[\u0027cinder-volume\u0027] | length \u003e 1"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"266c5e69_00f50d3d","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":2},"in_reply_to":"9abdf669_a20b617f","updated":"2024-05-22 05:01:40.000000000","message":"Done","commit_id":"7a620f0228fe6e98291fc929ffadb493ea5341a9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c5c089b187ce56bc874b7a40242398252e9c6482","unresolved":true,"context_lines":[{"line_number":71,"context_line":"  assert:"},{"line_number":72,"context_line":"    that:"},{"line_number":73,"context_line":"      - cinder_cluster_name !\u003d \"\""},{"line_number":74,"context_line":"    msg: \"Multiple cinder-volume instances detected but cinder_cluster_name is not set - please see https://docs.openstack.org/kolla-ansible/latest/reference/storage/cinder-guide.html#ha for guidance.\""},{"line_number":75,"context_line":"  when:"},{"line_number":76,"context_line":"    - not cinder_cluster_skip_precheck"},{"line_number":77,"context_line":"    - groups[\u0027cinder-volume\u0027] | length \u003e 1"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9abdf669_a20b617f","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":2},"in_reply_to":"eb2428c7_ad76e54e","updated":"2024-05-22 05:01:25.000000000","message":"We might, because then it will have no effect.","commit_id":"7a620f0228fe6e98291fc929ffadb493ea5341a9"}],"ansible/roles/cinder/templates/cinder.conf.j2":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"01b64cc0337b5c7bb5f1cd5c89d9ff9644785e0f","unresolved":true,"context_lines":[{"line_number":20,"context_line":"glance_num_retries \u003d {{ groups[\u0027glance-api\u0027] | length }}"},{"line_number":21,"context_line":"glance_ca_certificates_file \u003d {{ openstack_cacert }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% if service_name \u003d\u003d \"cinder-volume\" and groups[\u0027cinder-volume\u0027] | length \u003e 1 and cinder_cluster_name !\u003d \"\" %}"},{"line_number":24,"context_line":"cluster \u003d {{ cinder_cluster_name }}"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"b56970de_6a09074d","line":23,"range":{"start_line":23,"start_character":38,"end_line":23,"end_character":78},"updated":"2024-04-30 09:55:02.000000000","message":"I\u0027m not sure if this check is strictly necessary/should be done here, because we already check for the groups length in the precheck (see my other comment there as well).","commit_id":"7a620f0228fe6e98291fc929ffadb493ea5341a9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b28663cea861f82a0f492d8a3c159c33f922e14d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"glance_num_retries \u003d {{ groups[\u0027glance-api\u0027] | length }}"},{"line_number":21,"context_line":"glance_ca_certificates_file \u003d {{ openstack_cacert }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% if service_name \u003d\u003d \"cinder-volume\" and groups[\u0027cinder-volume\u0027] | length \u003e 1 and cinder_cluster_name !\u003d \"\" %}"},{"line_number":24,"context_line":"cluster \u003d {{ cinder_cluster_name }}"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"c6b83486_d329b8e2","line":23,"range":{"start_line":23,"start_character":38,"end_line":23,"end_character":78},"in_reply_to":"4082ed34_34f8a240","updated":"2024-05-22 05:01:40.000000000","message":"Done","commit_id":"7a620f0228fe6e98291fc929ffadb493ea5341a9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c5c089b187ce56bc874b7a40242398252e9c6482","unresolved":true,"context_lines":[{"line_number":20,"context_line":"glance_num_retries \u003d {{ groups[\u0027glance-api\u0027] | length }}"},{"line_number":21,"context_line":"glance_ca_certificates_file \u003d {{ openstack_cacert }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% if service_name \u003d\u003d \"cinder-volume\" and groups[\u0027cinder-volume\u0027] | length \u003e 1 and cinder_cluster_name !\u003d \"\" %}"},{"line_number":24,"context_line":"cluster \u003d {{ cinder_cluster_name }}"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"4082ed34_34f8a240","line":23,"range":{"start_line":23,"start_character":38,"end_line":23,"end_character":78},"in_reply_to":"b56970de_6a09074d","updated":"2024-05-22 05:01:25.000000000","message":"prechecks are not mandatory - so I guess it makes sense.","commit_id":"7a620f0228fe6e98291fc929ffadb493ea5341a9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9adaaa930488bd6adfc25b9bea710e02e7ea8e0b","unresolved":true,"context_lines":[{"line_number":20,"context_line":"glance_num_retries \u003d {{ groups[\u0027glance-api\u0027] | length }}"},{"line_number":21,"context_line":"glance_ca_certificates_file \u003d {{ openstack_cacert }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% if service_name \u003d\u003d \"cinder-volume\" and groups[\u0027cinder-volume\u0027] | length \u003e 1 and cinder_cluster_name !\u003d \"\" %}"},{"line_number":24,"context_line":"cluster \u003d {{ cinder_cluster_name }}"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"2d46219e_405d2a08","line":23,"range":{"start_line":23,"start_character":42,"end_line":23,"end_character":78},"updated":"2024-05-27 18:51:21.000000000","message":"I\u0027m not sure that this condition is needed. Maybe a deployment wants to prepare for an HA setup but starts with a single controller? Or a previous multi controller setup is reduced? IMO if cinder_cluster_name is specified, this var can be set.\n\nThis would imply that then also the second precheck is obsolete.","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1821b665b9c1b08756e334881f44330af30a6356","unresolved":false,"context_lines":[{"line_number":20,"context_line":"glance_num_retries \u003d {{ groups[\u0027glance-api\u0027] | length }}"},{"line_number":21,"context_line":"glance_ca_certificates_file \u003d {{ openstack_cacert }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% if service_name \u003d\u003d \"cinder-volume\" and groups[\u0027cinder-volume\u0027] | length \u003e 1 and cinder_cluster_name !\u003d \"\" %}"},{"line_number":24,"context_line":"cluster \u003d {{ cinder_cluster_name }}"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"0c38d7d3_705634d0","line":23,"range":{"start_line":23,"start_character":42,"end_line":23,"end_character":78},"in_reply_to":"2d46219e_405d2a08","updated":"2024-07-15 07:35:43.000000000","message":"Makes sense.","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"}],"doc/source/reference/storage/cinder-guide.rst":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ba85b8805fbd1c311e54a816e531b65ead530d4e","unresolved":true,"context_lines":[{"line_number":16,"context_line":"When using cinder-volume in an HA configuration (more than one host in"},{"line_number":17,"context_line":"cinder-volume/storage group):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Make sure that the driver you are using supports clustering configuration"},{"line_number":20,"context_line":"- Add ``cinder_cluster: cluster_name`` to your ``globals.yml`` (or host_vars"},{"line_number":21,"context_line":"  for advanced multi-cluster configuration)"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ae725029_a7836848","line":19,"range":{"start_line":19,"start_character":2,"end_line":19,"end_character":75},"updated":"2024-04-22 14:29:31.000000000","message":"is this referring to active/active HA support?\nThere seems to be no notion of \"clustering\" in the cinder driver docs at least:\n\nhttps://docs.openstack.org/cinder/latest/reference/support-matrix.html#driver-support-matrix\n\nIt might also be worth to link to the driver matrix directly in this case.","commit_id":"c33d1c54d16d26d2c33f1a929cbdfa22e198856e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"091def8e806a19793a270e75681041129034e63b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"When using cinder-volume in an HA configuration (more than one host in"},{"line_number":17,"context_line":"cinder-volume/storage group):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Make sure that the driver you are using supports clustering configuration"},{"line_number":20,"context_line":"- Add ``cinder_cluster: cluster_name`` to your ``globals.yml`` (or host_vars"},{"line_number":21,"context_line":"  for advanced multi-cluster configuration)"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"d5475855_dd8ffd1d","line":19,"range":{"start_line":19,"start_character":2,"end_line":19,"end_character":75},"in_reply_to":"ae725029_a7836848","updated":"2024-04-22 15:26:00.000000000","message":"Done","commit_id":"c33d1c54d16d26d2c33f1a929cbdfa22e198856e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9adaaa930488bd6adfc25b9bea710e02e7ea8e0b","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Cinder can be deployed using Kolla and for a list of supported backends"},{"line_number":11,"context_line":"see `Cinder driver support matrix \u003chttps://docs.openstack.org/cinder/|KOLLA_OPENSTACK_RELEASE|/reference/support-matrix.html#driver-support-matrix\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"HA"},{"line_number":14,"context_line":"~~"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"When using cinder-volume in an HA configuration (more than one host in"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5b654b0e_3a32f430","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":2},"updated":"2024-05-27 18:51:21.000000000","message":"nit: Spell this out once for clarity? \"High Availability (HA)\"","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1821b665b9c1b08756e334881f44330af30a6356","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Cinder can be deployed using Kolla and for a list of supported backends"},{"line_number":11,"context_line":"see `Cinder driver support matrix \u003chttps://docs.openstack.org/cinder/|KOLLA_OPENSTACK_RELEASE|/reference/support-matrix.html#driver-support-matrix\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"HA"},{"line_number":14,"context_line":"~~"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"When using cinder-volume in an HA configuration (more than one host in"}],"source_content_type":"text/x-rst","patch_set":7,"id":"c8ede1b9_9303d9e3","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":2},"in_reply_to":"5b654b0e_3a32f430","updated":"2024-07-15 07:35:43.000000000","message":"Done","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9adaaa930488bd6adfc25b9bea710e02e7ea8e0b","unresolved":true,"context_lines":[{"line_number":16,"context_line":"When using cinder-volume in an HA configuration (more than one host in"},{"line_number":17,"context_line":"cinder-volume/storage group):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Make sure that the driver you are using supports `Active/Active High Availability \u003chttps://docs.openstack.org/cinder/latest/reference/support-matrix.html#operation_active_active_ha\u003e`"},{"line_number":20,"context_line":"  configuration"},{"line_number":21,"context_line":"- Add ``cinder_cluster: cluster_name`` to your ``globals.yml`` (or host_vars"},{"line_number":22,"context_line":"  for advanced multi-cluster configuration)"}],"source_content_type":"text/x-rst","patch_set":7,"id":"28764709_336facc8","line":19,"range":{"start_line":19,"start_character":119,"end_line":19,"end_character":125},"updated":"2024-05-27 18:51:21.000000000","message":"this should use |KOLLA_OPENSTACK_RELEASE| as above","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1821b665b9c1b08756e334881f44330af30a6356","unresolved":false,"context_lines":[{"line_number":16,"context_line":"When using cinder-volume in an HA configuration (more than one host in"},{"line_number":17,"context_line":"cinder-volume/storage group):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Make sure that the driver you are using supports `Active/Active High Availability \u003chttps://docs.openstack.org/cinder/latest/reference/support-matrix.html#operation_active_active_ha\u003e`"},{"line_number":20,"context_line":"  configuration"},{"line_number":21,"context_line":"- Add ``cinder_cluster: cluster_name`` to your ``globals.yml`` (or host_vars"},{"line_number":22,"context_line":"  for advanced multi-cluster configuration)"}],"source_content_type":"text/x-rst","patch_set":7,"id":"23150ae1_17bc6f59","line":19,"range":{"start_line":19,"start_character":119,"end_line":19,"end_character":125},"in_reply_to":"28764709_336facc8","updated":"2024-07-15 07:35:43.000000000","message":"Done","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9adaaa930488bd6adfc25b9bea710e02e7ea8e0b","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Make sure that the driver you are using supports `Active/Active High Availability \u003chttps://docs.openstack.org/cinder/latest/reference/support-matrix.html#operation_active_active_ha\u003e`"},{"line_number":20,"context_line":"  configuration"},{"line_number":21,"context_line":"- Add ``cinder_cluster: cluster_name`` to your ``globals.yml`` (or host_vars"},{"line_number":22,"context_line":"  for advanced multi-cluster configuration)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1b55518f_748fd252","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":22},"updated":"2024-05-27 18:51:21.000000000","message":"the variable is named ``cinder_cluster_name``?\n\nalso maybe use \"example_cluster_name\" to indicate that any name will do","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1821b665b9c1b08756e334881f44330af30a6356","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Make sure that the driver you are using supports `Active/Active High Availability \u003chttps://docs.openstack.org/cinder/latest/reference/support-matrix.html#operation_active_active_ha\u003e`"},{"line_number":20,"context_line":"  configuration"},{"line_number":21,"context_line":"- Add ``cinder_cluster: cluster_name`` to your ``globals.yml`` (or host_vars"},{"line_number":22,"context_line":"  for advanced multi-cluster configuration)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"826b17dc_31de29c0","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":22},"in_reply_to":"1b55518f_748fd252","updated":"2024-07-15 07:35:43.000000000","message":"Done","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fea529be83b6a19dd0051e646b971fc263d1a938","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. note::"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"   In case of non-standard configurations (e.g. HA and non-HA backends setup),"},{"line_number":27,"context_line":"   you can skip the prechecks by setting ``cinder_cluster_skip_precheck`` to"},{"line_number":28,"context_line":"   ``true``."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"063027bf_a2dcf5a4","line":26,"range":{"start_line":26,"start_character":48,"end_line":26,"end_character":76},"updated":"2024-05-27 15:55:04.000000000","message":"thanks for adding a note, but I honestly don\u0027t quite grasp the example in the brackets?\nmaybe that\u0027s just me though. Does this mean: \"HA frontend and non-HA backend setup\"? Not sure actually.","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1951e1adb3542123d3362167a13e26a76d0ddbf4","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. note::"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"   In case of non-standard configurations (e.g. HA and non-HA backends setup),"},{"line_number":27,"context_line":"   you can skip the prechecks by setting ``cinder_cluster_skip_precheck`` to"},{"line_number":28,"context_line":"   ``true``."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ce634d36_b0d48b44","line":26,"range":{"start_line":26,"start_character":48,"end_line":26,"end_character":76},"in_reply_to":"063027bf_a2dcf5a4","updated":"2024-07-15 07:40:11.000000000","message":"No, that means two different backends on the same cinder-volume - one is HA, and the other one is not (because the Cinder driver does not support that).\nWhere did you find the word frontend here?","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ee17ffecfddd5f5f07f5e27752ac9cd0fe2ec174","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Overview"},{"line_number":8,"context_line":"~~~~~~~~"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Cinder can be deployed using Kolla and supports the following storage"},{"line_number":11,"context_line":"backends:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* ceph"},{"line_number":14,"context_line":"* hnas_nfs"},{"line_number":15,"context_line":"* iscsi"},{"line_number":16,"context_line":"* lvm"},{"line_number":17,"context_line":"* nfs"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"LVM"},{"line_number":20,"context_line":"~~~"}],"source_content_type":"text/x-rst","patch_set":14,"id":"39429d57_ec616028","side":"PARENT","line":17,"range":{"start_line":10,"start_character":0,"end_line":17,"end_character":5},"updated":"2024-10-25 13:53:47.000000000","message":"removal not related for this change. lets remove this in future generic backends change.","commit_id":"527ca510b03a1b4304835dbe64f0648a1b00004b"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"83e4898d6a80fb1bc2f81986ad69f78ac4966a84","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Overview"},{"line_number":8,"context_line":"~~~~~~~~"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Cinder can be deployed using Kolla and supports the following storage"},{"line_number":11,"context_line":"backends:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* ceph"},{"line_number":14,"context_line":"* hnas_nfs"},{"line_number":15,"context_line":"* iscsi"},{"line_number":16,"context_line":"* lvm"},{"line_number":17,"context_line":"* nfs"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"LVM"},{"line_number":20,"context_line":"~~~"}],"source_content_type":"text/x-rst","patch_set":14,"id":"468eac7a_b7255aa6","side":"PARENT","line":17,"range":{"start_line":10,"start_character":0,"end_line":17,"end_character":5},"in_reply_to":"39429d57_ec616028","updated":"2024-10-25 13:58:07.000000000","message":"No really true. This list is extremely out of date and this seems like the perfect patch to update that part of the documentation, given the fact this patch is releated to cinder backend HA support and to get the list of HA supporting backends the link provided is the accepted source of truth for this support.","commit_id":"527ca510b03a1b4304835dbe64f0648a1b00004b"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"10a854b46e76ece3c2b637a3839a0ded9866a486","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Overview"},{"line_number":8,"context_line":"~~~~~~~~"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Cinder can be deployed using Kolla and supports the following storage"},{"line_number":11,"context_line":"backends:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* ceph"},{"line_number":14,"context_line":"* hnas_nfs"},{"line_number":15,"context_line":"* iscsi"},{"line_number":16,"context_line":"* lvm"},{"line_number":17,"context_line":"* nfs"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"LVM"},{"line_number":20,"context_line":"~~~"}],"source_content_type":"text/x-rst","patch_set":14,"id":"975c2bd4_ecc57037","side":"PARENT","line":17,"range":{"start_line":10,"start_character":0,"end_line":17,"end_character":5},"in_reply_to":"468eac7a_b7255aa6","updated":"2024-10-25 14:00:49.000000000","message":"Ideally this should be in the separate patch if we want get rid of this right now.","commit_id":"527ca510b03a1b4304835dbe64f0648a1b00004b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d3270102addb03500c3bbe2cd0971c61d7d7b184","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Overview"},{"line_number":8,"context_line":"~~~~~~~~"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Cinder can be deployed using Kolla and supports the following storage"},{"line_number":11,"context_line":"backends:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* ceph"},{"line_number":14,"context_line":"* hnas_nfs"},{"line_number":15,"context_line":"* iscsi"},{"line_number":16,"context_line":"* lvm"},{"line_number":17,"context_line":"* nfs"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"LVM"},{"line_number":20,"context_line":"~~~"}],"source_content_type":"text/x-rst","patch_set":14,"id":"0020b07e_df1541d1","side":"PARENT","line":17,"range":{"start_line":10,"start_character":0,"end_line":17,"end_character":5},"in_reply_to":"83777cbe_f5b2e491","updated":"2024-10-25 14:41:22.000000000","message":"Acknowledged","commit_id":"527ca510b03a1b4304835dbe64f0648a1b00004b"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b012eabae047dfabe6c1892eff82786f2ee38062","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Overview"},{"line_number":8,"context_line":"~~~~~~~~"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Cinder can be deployed using Kolla and supports the following storage"},{"line_number":11,"context_line":"backends:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* ceph"},{"line_number":14,"context_line":"* hnas_nfs"},{"line_number":15,"context_line":"* iscsi"},{"line_number":16,"context_line":"* lvm"},{"line_number":17,"context_line":"* nfs"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"LVM"},{"line_number":20,"context_line":"~~~"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7d8ca00b_a43a022a","side":"PARENT","line":17,"range":{"start_line":10,"start_character":0,"end_line":17,"end_character":5},"in_reply_to":"83777cbe_f5b2e491","updated":"2024-10-25 14:41:20.000000000","message":"Done","commit_id":"527ca510b03a1b4304835dbe64f0648a1b00004b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b99a18efdf2d54634501d0cae9350173049fdef5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Overview"},{"line_number":8,"context_line":"~~~~~~~~"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Cinder can be deployed using Kolla and supports the following storage"},{"line_number":11,"context_line":"backends:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* ceph"},{"line_number":14,"context_line":"* hnas_nfs"},{"line_number":15,"context_line":"* iscsi"},{"line_number":16,"context_line":"* lvm"},{"line_number":17,"context_line":"* nfs"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"LVM"},{"line_number":20,"context_line":"~~~"}],"source_content_type":"text/x-rst","patch_set":14,"id":"d4ca9efd_26490717","side":"PARENT","line":17,"range":{"start_line":10,"start_character":0,"end_line":17,"end_character":5},"in_reply_to":"975c2bd4_ecc57037","updated":"2024-10-25 14:22:10.000000000","message":"I deliberately linked to Cinder support matrix for checking if a backend has HA support.","commit_id":"527ca510b03a1b4304835dbe64f0648a1b00004b"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1fe51fca193072840ea76faa2bf6631152a2d930","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Overview"},{"line_number":8,"context_line":"~~~~~~~~"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Cinder can be deployed using Kolla and supports the following storage"},{"line_number":11,"context_line":"backends:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* ceph"},{"line_number":14,"context_line":"* hnas_nfs"},{"line_number":15,"context_line":"* iscsi"},{"line_number":16,"context_line":"* lvm"},{"line_number":17,"context_line":"* nfs"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"LVM"},{"line_number":20,"context_line":"~~~"}],"source_content_type":"text/x-rst","patch_set":14,"id":"83777cbe_f5b2e491","side":"PARENT","line":17,"range":{"start_line":10,"start_character":0,"end_line":17,"end_character":5},"in_reply_to":"c6ab58f8_7ece5a40","updated":"2024-10-25 14:39:41.000000000","message":"bare rechecks is a waste of time. the separate change will help to find when the backends chapter was dropped.","commit_id":"527ca510b03a1b4304835dbe64f0648a1b00004b"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"4e7359c185b7059a529453a2529645d6534091f8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Overview"},{"line_number":8,"context_line":"~~~~~~~~"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Cinder can be deployed using Kolla and supports the following storage"},{"line_number":11,"context_line":"backends:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* ceph"},{"line_number":14,"context_line":"* hnas_nfs"},{"line_number":15,"context_line":"* iscsi"},{"line_number":16,"context_line":"* lvm"},{"line_number":17,"context_line":"* nfs"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"LVM"},{"line_number":20,"context_line":"~~~"}],"source_content_type":"text/x-rst","patch_set":14,"id":"c6ab58f8_7ece5a40","side":"PARENT","line":17,"range":{"start_line":10,"start_character":0,"end_line":17,"end_character":5},"in_reply_to":"d4ca9efd_26490717","updated":"2024-10-25 14:24:57.000000000","message":"Creating an extra patch for this seems an unnecessary waste of time and CI resources.","commit_id":"527ca510b03a1b4304835dbe64f0648a1b00004b"}],"releasenotes/notes/cinder-ha-precheck-ca93901f1362ac0d.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9adaaa930488bd6adfc25b9bea710e02e7ea8e0b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A precheck for running Cinder HA has been introduced, which checks"},{"line_number":5,"context_line":"    for multiple cinder-volume instances and fails when ``cinder_cluster_name``"},{"line_number":6,"context_line":"    is unset. For details on configuration guidelines please check the"},{"line_number":7,"context_line":"    `HA section of Cinder guide \u003chttps://docs.openstack.org/kolla-ansible/latest/reference/storage/cinder-guide.html#ha\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"331e6985_e94d0306","line":4,"updated":"2024-05-27 18:51:21.000000000","message":"The variables are newly added, so maybe there should also be a feature section about this? Also add a note that this replaces possible user-defined config overrides that already may have implemented this feature?","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1951e1adb3542123d3362167a13e26a76d0ddbf4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A precheck for running Cinder HA has been introduced, which checks"},{"line_number":5,"context_line":"    for multiple cinder-volume instances and fails when ``cinder_cluster_name``"},{"line_number":6,"context_line":"    is unset. For details on configuration guidelines please check the"},{"line_number":7,"context_line":"    `HA section of Cinder guide \u003chttps://docs.openstack.org/kolla-ansible/latest/reference/storage/cinder-guide.html#ha\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f55d5d45_3587b395","line":4,"in_reply_to":"331e6985_e94d0306","updated":"2024-07-15 07:40:11.000000000","message":"Done","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"}],"tests/templates/globals-default.j2":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"29ff474e973ae1af94859d47a8ccf9f30609af33","unresolved":true,"context_lines":[{"line_number":152,"context_line":"{% if scenario \u003d\u003d \"cephadm\" %}"},{"line_number":153,"context_line":"# kolla-ansible vars"},{"line_number":154,"context_line":"enable_cinder: \"yes\""},{"line_number":155,"context_line":"cinder_cluster_name: \"ceph\""},{"line_number":156,"context_line":"# External Ceph"},{"line_number":157,"context_line":"glance_backend_ceph: \"yes\""},{"line_number":158,"context_line":"cinder_backend_ceph: \"yes\""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"f0e40b65_8d034f96","line":155,"updated":"2024-05-21 15:37:26.000000000","message":"not sure this is a good default name. maybe something generic like `cluster1`. Don\u0027t want people to think that ceph is a pre-requisite for HA clusters in cinder.","commit_id":"7a620f0228fe6e98291fc929ffadb493ea5341a9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"951d1a8449809b05df4dd7c5527d5c39b8f53963","unresolved":false,"context_lines":[{"line_number":152,"context_line":"{% if scenario \u003d\u003d \"cephadm\" %}"},{"line_number":153,"context_line":"# kolla-ansible vars"},{"line_number":154,"context_line":"enable_cinder: \"yes\""},{"line_number":155,"context_line":"cinder_cluster_name: \"ceph\""},{"line_number":156,"context_line":"# External Ceph"},{"line_number":157,"context_line":"glance_backend_ceph: \"yes\""},{"line_number":158,"context_line":"cinder_backend_ceph: \"yes\""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"2a427150_54511fbd","line":155,"in_reply_to":"aaab87ba_c1be12df","updated":"2024-05-21 16:59:11.000000000","message":"if needed for Zuul then OK.\nMight be worth a comment in their as well","commit_id":"7a620f0228fe6e98291fc929ffadb493ea5341a9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"81763cf04e177a8e525b09fa3333d08db92cdade","unresolved":false,"context_lines":[{"line_number":152,"context_line":"{% if scenario \u003d\u003d \"cephadm\" %}"},{"line_number":153,"context_line":"# kolla-ansible vars"},{"line_number":154,"context_line":"enable_cinder: \"yes\""},{"line_number":155,"context_line":"cinder_cluster_name: \"ceph\""},{"line_number":156,"context_line":"# External Ceph"},{"line_number":157,"context_line":"glance_backend_ceph: \"yes\""},{"line_number":158,"context_line":"cinder_backend_ceph: \"yes\""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"aaab87ba_c1be12df","line":155,"in_reply_to":"f0e40b65_8d034f96","updated":"2024-05-21 16:55:52.000000000","message":"This is the name only used in CI jobs in cephadm jobs...","commit_id":"7a620f0228fe6e98291fc929ffadb493ea5341a9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9adaaa930488bd6adfc25b9bea710e02e7ea8e0b","unresolved":true,"context_lines":[{"line_number":152,"context_line":"{% if scenario \u003d\u003d \"cephadm\" %}"},{"line_number":153,"context_line":"# kolla-ansible vars"},{"line_number":154,"context_line":"enable_cinder: \"yes\""},{"line_number":155,"context_line":"cinder_cluster_name: \"ceph\""},{"line_number":156,"context_line":"# External Ceph"},{"line_number":157,"context_line":"glance_backend_ceph: \"yes\""},{"line_number":158,"context_line":"cinder_backend_ceph: \"yes\""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"69a267a2_870b083c","line":155,"range":{"start_line":155,"start_character":22,"end_line":155,"end_character":26},"updated":"2024-05-27 18:51:21.000000000","message":"nit: maybe \"kolla_ceph\" to emphasize the example character of the name?","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1821b665b9c1b08756e334881f44330af30a6356","unresolved":false,"context_lines":[{"line_number":152,"context_line":"{% if scenario \u003d\u003d \"cephadm\" %}"},{"line_number":153,"context_line":"# kolla-ansible vars"},{"line_number":154,"context_line":"enable_cinder: \"yes\""},{"line_number":155,"context_line":"cinder_cluster_name: \"ceph\""},{"line_number":156,"context_line":"# External Ceph"},{"line_number":157,"context_line":"glance_backend_ceph: \"yes\""},{"line_number":158,"context_line":"cinder_backend_ceph: \"yes\""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9189ea39_84cf214d","line":155,"range":{"start_line":155,"start_character":22,"end_line":155,"end_character":26},"in_reply_to":"69a267a2_870b083c","updated":"2024-07-15 07:35:43.000000000","message":"Done","commit_id":"18770bb673d3cca4c18e3bd1711af282322062f0"}]}