)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"579e35eefd1527f33ebfd4acf16bbb936aa99f66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2274bfc4_578290fa","updated":"2024-03-05 07:42:43.000000000","message":"I\u0027m not sure yet how this is going to work. As you say in the doc, the value of the new var has to depend on which limit is getting applied, so how would you target the correct hosts depending on which limit you are using in your command?\n\nAlso, shouldn\u0027t larger installations be using https://docs.openstack.org/kolla-ansible/latest/user/ansible-tuning.html#fact-caching anyway, making this optimization kind of moot?","commit_id":"c0c36b85031dab590798ca887587267afe22b0da"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9dbe1c717b7184a045ea91d33450e66f27dd3dfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8376f017_3e782708","updated":"2024-03-05 10:10:25.000000000","message":"just for reference of devs and users/operators who might not be aware:\n\nnotice that using the --limit option is currently somewhat broken (depending on the task it might or might not work), see e.g. this bug report: https://bugs.launchpad.net/kolla-ansible/+bug/2054348 for details.\n\ntl;dr: `register:` in combination with dedicated hosts and `--limit` do not play well together. We should probably rewrite all/most uses of `register:` to use `set_fact:` instead, where possible.","commit_id":"c0c36b85031dab590798ca887587267afe22b0da"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"188c3141983a8bc4d990487b0eedcd6970ca45c2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7a3bbf5_f8bfbde5","in_reply_to":"2274bfc4_578290fa","updated":"2024-03-05 11:43:48.000000000","message":"For context, the main driver behind this change is being able to function with unreachable hosts in the inventory. Performance improvements will be a nice bonus.\n\nThe easiest way to make use of this is to target all hosts except for compute hosts. To make that work with prometheus you would need to define api_interface_address in the inventory for at least the compute hosts.\n\nre fact caching, I have mixed feelings about it. It\u0027s possible for the cache to get populated with facts gathered by a different user, which changes the user-related facts, producing strange issues. Also, the cache will expire at some point and you will need to gather facts again.","commit_id":"c0c36b85031dab590798ca887587267afe22b0da"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1eb25167758988553da9747a470835544016f173","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ad4361cd_67a73c84","updated":"2024-09-13 12:15:40.000000000","message":"Code itself LGTM, besides the unrelated moving of one variable.","commit_id":"040d5a9c0d3bdf018e289107b95c94e2d8d465c9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0ac8f126e6f9bf8d5c6ff8bcb0d9d34fe37667b2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"922df1a5_31ca7a9c","updated":"2024-05-28 10:13:39.000000000","message":"I think this is a good idea, but I also think we first should/need to fix the bugs with \"--limit\" before making it\u0027s usage easier:\n\nhttps://bugs.launchpad.net/kolla-ansible/+bug/2054348","commit_id":"040d5a9c0d3bdf018e289107b95c94e2d8d465c9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ebbe4ed6f9ad19538b2a74ce5a3ce459181e6164","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"229521e0_42aab8d4","in_reply_to":"150bcec6_8685d00a","updated":"2024-09-13 11:56:08.000000000","message":"Acknowledged","commit_id":"040d5a9c0d3bdf018e289107b95c94e2d8d465c9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"559aa65e49b2ddb174c9ce4a71ce4a5d28e7cff7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"150bcec6_8685d00a","in_reply_to":"922df1a5_31ca7a9c","updated":"2024-09-13 08:15:17.000000000","message":"I think it would be nice to merge this, regardless of bugs/gotchas in --limit.","commit_id":"040d5a9c0d3bdf018e289107b95c94e2d8d465c9"}],"etc/kolla/globals.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1eb25167758988553da9747a470835544016f173","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# commented parameters are shown here, To override the default value uncomment"},{"line_number":6,"context_line":"# the parameter and change its value."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Dummy variable to allow Ansible to accept this file."},{"line_number":9,"context_line":"workaround_ansible_issue_8743: yes"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"###################"},{"line_number":12,"context_line":"# Ansible options"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0caf9725_2551180f","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":34},"updated":"2024-09-13 12:15:40.000000000","message":"Why was this moved up here?\n\nI didn\u0027t realize at first this was only moved, and initially reviewed this as new code, so I checked the \"issue\", so maybe we want to recheck if this is still appropriate or necessary?:\n\nI can not find an issue with that number, github automatically redirects to this PR instead: https://github.com/ansible/ansible/pull/8743\n\nBut I don\u0027t see any connection between this PR and this variable.\n\nIs this still necessary? Thanks for any clarification.","commit_id":"040d5a9c0d3bdf018e289107b95c94e2d8d465c9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0fc8bec5d1463c65e6661536b07e514211af90d1","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# commented parameters are shown here, To override the default value uncomment"},{"line_number":6,"context_line":"# the parameter and change its value."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Dummy variable to allow Ansible to accept this file."},{"line_number":9,"context_line":"workaround_ansible_issue_8743: yes"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"###################"},{"line_number":12,"context_line":"# Ansible options"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b5af416c_3a07651f","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":34},"in_reply_to":"0caf9725_2551180f","updated":"2024-09-19 10:42:31.000000000","message":"Interesting. This variable is in many config files in Kayobe, and has been for ~7 years. I find it quite amusing that it references the wrong issue...\n\nBasically, Ansible expects -e config files to be key/value map types. If they only contain comments then they are something else (None?) and Ansible complains.\n\nI just moved it to the top to separate it from \"real\" config variables.","commit_id":"040d5a9c0d3bdf018e289107b95c94e2d8d465c9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b268b52be109c87c56085a195f67ec1761e7e913","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# commented parameters are shown here, To override the default value uncomment"},{"line_number":6,"context_line":"# the parameter and change its value."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Dummy variable to allow Ansible to accept this file."},{"line_number":9,"context_line":"workaround_ansible_issue_8743: yes"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"###################"},{"line_number":12,"context_line":"# Ansible options"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5df4feab_8577c60e","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":34},"in_reply_to":"b5af416c_3a07651f","updated":"2025-01-23 17:13:17.000000000","message":"Done","commit_id":"040d5a9c0d3bdf018e289107b95c94e2d8d465c9"}]}