)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1df22e598c88d1e4bfe4030ef84f4d72029d7b20","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This reverts commit 5b431f0f7f932293362a01703673ee05d0a5bd8d."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Reason for revert: any_errors_fatal is not templated by Ansible (tested"},{"line_number":12,"context_line":"up to ansible-core 2.15.9). This means that the default value of false"},{"line_number":13,"context_line":"is actually interpreted as true. This behaviour is demonstrated in [1]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We now have gather_facts_max_fail_percentage which can be set to 0 to"},{"line_number":16,"context_line":"provide the same functionality."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b776a3bd_0f399467","line":13,"range":{"start_line":12,"start_character":28,"end_line":13,"end_character":32},"updated":"2024-02-29 11:03:01.000000000","message":"I find this very confusing to read and I think the cause is, that this is not what is happening? Not sure though, because it\u0027s confusing to read and I might be misunderstanding.\n\nA value of false is of course not interpreted as true, but the template never gets rendered, so the value from the template doesn\u0027t end up in the actual file, so the files value resorts to the upstream default of true, is that correct?\n\nHere is my take:\n\"This means that our default value of false in the template is never rendered into the actual files, meaning they retain the upstream default of `true`.\"\n\nThe wording can still be better I think but that\u0027s my best attempt so far.\n\nDoes this convey the meaning?","commit_id":"47aec0c9ba09ab519230c0f91314dc9a2544f404"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9f5f6612cd161af1c65cf6936e33be949bc44c99","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This reverts commit 5b431f0f7f932293362a01703673ee05d0a5bd8d."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Reason for revert: any_errors_fatal is not templated by Ansible (tested"},{"line_number":12,"context_line":"up to ansible-core 2.15.9). This means that the default value of false"},{"line_number":13,"context_line":"is actually interpreted as true. This behaviour is demonstrated in [1]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We now have gather_facts_max_fail_percentage which can be set to 0 to"},{"line_number":16,"context_line":"provide the same functionality."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c397b95f_ef78175a","line":13,"range":{"start_line":12,"start_character":28,"end_line":13,"end_character":32},"in_reply_to":"04f17b12_625c6d4f","updated":"2024-02-29 11:22:36.000000000","message":"I guess that would be fine, thanks!","commit_id":"47aec0c9ba09ab519230c0f91314dc9a2544f404"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"504f6576dd21ddc1bfef064870aadf9009f4e9a3","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This reverts commit 5b431f0f7f932293362a01703673ee05d0a5bd8d."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Reason for revert: any_errors_fatal is not templated by Ansible (tested"},{"line_number":12,"context_line":"up to ansible-core 2.15.9). This means that the default value of false"},{"line_number":13,"context_line":"is actually interpreted as true. This behaviour is demonstrated in [1]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We now have gather_facts_max_fail_percentage which can be set to 0 to"},{"line_number":16,"context_line":"provide the same functionality."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"04f17b12_625c6d4f","line":13,"range":{"start_line":12,"start_character":28,"end_line":13,"end_character":32},"in_reply_to":"b776a3bd_0f399467","updated":"2024-02-29 11:10:31.000000000","message":"This is what is happening, but perhaps I have omitted some of the explanation of how it happens.\n\nThe default value of any_errors_fatal (if unspecified) is false. If you specify a value, it must be a literal that is evaluated for \"truthiness\". The original patch tried to use a variable to set the value, but because the value is not templated by ansible, it is interpreted as true because it is a non-zero length string.\n\nWould it help to include more of that in the commit message? I don\u0027t think that the reno should include that level of detail though - only a brief description of the problem.","commit_id":"47aec0c9ba09ab519230c0f91314dc9a2544f404"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"142c5fb34ca79b08d68b7ba93c06df993aecf012","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7644c5ce_afa847d2","updated":"2024-03-05 07:46:08.000000000","message":"does this need to be stacked on top of the other changes?","commit_id":"e5bd7a56b13575021aaaffa2ee4bd248b52e27d6"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"10bbd9f03255fd8a178f15a1e39edd7dd6d81b52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e11244dd_4b2ee733","in_reply_to":"2c6ae176_6d4e7820","updated":"2024-03-06 17:02:54.000000000","message":"I\u0027ve reordered the patches to put this one before https://review.opendev.org/c/openstack/kolla-ansible/+/910503/. The prometheus scrape config change has been pulled out of the patch chain.","commit_id":"e5bd7a56b13575021aaaffa2ee4bd248b52e27d6"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a78c2f2922d1b953eaf1eeb684fbb1d02552c166","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2c6ae176_6d4e7820","in_reply_to":"713b88a0_8f7fcccc","updated":"2024-03-05 11:35:35.000000000","message":"Also I think this should be backported because the any_errors_fatal feature is not doing what it is supposed to do.","commit_id":"e5bd7a56b13575021aaaffa2ee4bd248b52e27d6"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"32c1fc8eca6d733254001ff0ab44bce10d98b603","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"713b88a0_8f7fcccc","in_reply_to":"7644c5ce_afa847d2","updated":"2024-03-05 11:34:06.000000000","message":"Not necessarily. It would conflict with https://review.opendev.org/c/openstack/kolla-ansible/+/910503/, and I wanted to test them together using depends-on. I could swap the order if you\u0027d like to merge this one first.","commit_id":"e5bd7a56b13575021aaaffa2ee4bd248b52e27d6"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f795417eaa8a3cb9bb1634d3fb8d2d12c33bc6ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f428036e_ee77a675","updated":"2024-03-18 14:08:32.000000000","message":"@frickler could you replace your +2 please?","commit_id":"c77c31d921cc5dcfb4548a303fc639cee2c6326d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b0119af3268ef424c62e208c532b25d8f5852feb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6bbf783a_7d7fc662","updated":"2024-05-16 10:27:04.000000000","message":"Fixed merge conflict","commit_id":"c77c31d921cc5dcfb4548a303fc639cee2c6326d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"eae8ddfa1960c815bdf08b2656ca1d69a1866ac2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f31e1915_8e4816ab","updated":"2024-08-09 06:06:50.000000000","message":"recheck logs expired, not sure if this patch is actually still relevant, too?","commit_id":"9cebdb5d9eb46b5ae28a52ef86e5bb50342c3648"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8a03bd89c43533397184b56966d02114f95fc5d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dfed6446_b146274e","updated":"2024-06-06 08:36:52.000000000","message":"recheck not sure why this failed and zuul logs are already rotated away","commit_id":"9cebdb5d9eb46b5ae28a52ef86e5bb50342c3648"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f8997127770c4bad5fa70a9972d706711fbe4d51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f00baeb5_820bda50","in_reply_to":"f31e1915_8e4816ab","updated":"2024-08-20 13:28:22.000000000","message":"It is still relevant.","commit_id":"9cebdb5d9eb46b5ae28a52ef86e5bb50342c3648"}],"releasenotes/notes/remove-any-errors-fatal-664fc2207074f0ef.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1df22e598c88d1e4bfe4030ef84f4d72029d7b20","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support for failing execution early if fact collection fails on any of the"},{"line_number":5,"context_line":"    hosts by setting ``kolla_ansible_setup_any_errors_fatal`` to ``true`` has"},{"line_number":6,"context_line":"    been removed. This is due to the Ansible ``any_errors_fatal`` parameter not"},{"line_number":7,"context_line":"    being templated, resulting in the default value of ``false`` being"},{"line_number":8,"context_line":"    interpreted as ``true``."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    Equivalent behaviour is possible by setting the maximum failure percentage"},{"line_number":11,"context_line":"    to 0. This may be done specifically for fact gathering using"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7b3d52d9_7b8341d1","line":8,"range":{"start_line":6,"start_character":18,"end_line":8,"end_character":28},"updated":"2024-02-29 11:03:01.000000000","message":"see my comment on the commit message. I find the wording here confusing. Maybe we can rephrase it?","commit_id":"47aec0c9ba09ab519230c0f91314dc9a2544f404"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9f5f6612cd161af1c65cf6936e33be949bc44c99","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support for failing execution early if fact collection fails on any of the"},{"line_number":5,"context_line":"    hosts by setting ``kolla_ansible_setup_any_errors_fatal`` to ``true`` has"},{"line_number":6,"context_line":"    been removed. This is due to the Ansible ``any_errors_fatal`` parameter not"},{"line_number":7,"context_line":"    being templated, resulting in the default value of ``false`` being"},{"line_number":8,"context_line":"    interpreted as ``true``."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    Equivalent behaviour is possible by setting the maximum failure percentage"},{"line_number":11,"context_line":"    to 0. This may be done specifically for fact gathering using"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d4c6d03d_cdee3d32","line":8,"range":{"start_line":6,"start_character":18,"end_line":8,"end_character":28},"in_reply_to":"7b3d52d9_7b8341d1","updated":"2024-02-29 11:22:36.000000000","message":"Acknowledged","commit_id":"47aec0c9ba09ab519230c0f91314dc9a2544f404"}]}