)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"9f7726ca0b1672fda476bde2ff5128a2bd0c14e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"6cc41e50_12454a27","updated":"2024-10-09 11:50:16.000000000","message":"It seems that the patchset caused the swift tests to fail. Ivan upgraded the docker client, which\u0027s containers.get() method now takes different input parameters. I belive it should be fixed now. This also required some adjustments to unit tests.","commit_id":"3aeaf0062741c03a0d80c74a6adb44fc91622ec1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"679bd6bb81b84da580586879f70943b543b4d3f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"2c429816_8cbf43cd","updated":"2025-01-20 09:15:36.000000000","message":"since this change may affect custom changes deployments may have made, I think a releasenote would be in order. the change itself lgtm except as noted below","commit_id":"68bac9407087eb83c0534afac6e78c23ee7eff18"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f79122fa34236c3b8bda606f8584088126fc4c5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"f4a435b1_99ba15e5","updated":"2025-02-05 16:21:00.000000000","message":"still lgtm","commit_id":"7002ab2b47fadf2b1c67ad5a97b0e66928a6e493"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0b265df17e198d2cc2661f6abb3ce017fb50318f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"1e45065b_f1627ca5","updated":"2025-02-07 15:20:52.000000000","message":"latest update was just a rebase and applying the same change to some newly added code. re-applying previous approvals","commit_id":"19af5826fc10c7e068e196e68c0d9950e8d13f89"}],"ansible/library/kolla_container_facts.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"679bd6bb81b84da580586879f70943b543b4d3f7","unresolved":true,"context_lines":[{"line_number":61,"context_line":"        container_engine: docker"},{"line_number":62,"context_line":"        name:"},{"line_number":63,"context_line":"          - glance_api"},{"line_number":64,"context_line":"          - glance_registry"},{"line_number":65,"context_line":"        container_engine: podman"},{"line_number":66,"context_line":"        action: get_containers"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"8a440bac_45156627","line":64,"updated":"2025-01-20 09:15:36.000000000","message":"nit: this example is broken, glance_registry doesn\u0027t exist anymore for a long time, so we should also not copy it. can be fixed in a followup unless this patch needs an update anyway","commit_id":"68bac9407087eb83c0534afac6e78c23ee7eff18"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2fc2882cf20aae1c753517e4f9f037b639c225b5","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        container_engine: docker"},{"line_number":62,"context_line":"        name:"},{"line_number":63,"context_line":"          - glance_api"},{"line_number":64,"context_line":"          - glance_registry"},{"line_number":65,"context_line":"        container_engine: podman"},{"line_number":66,"context_line":"        action: get_containers"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"23ce5803_4a3b2ea0","line":64,"in_reply_to":"8a440bac_45156627","updated":"2025-01-23 08:29:19.000000000","message":"Added.","commit_id":"68bac9407087eb83c0534afac6e78c23ee7eff18"}],"ansible/roles/aodh/tasks/precheck.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"679bd6bb81b84da580586879f70943b543b4d3f7","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    timeout: 1"},{"line_number":24,"context_line":"    state: stopped"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - container_facts.containers[\u0027aodh_api\u0027] is not defined"},{"line_number":27,"context_line":"    - inventory_hostname in groups[\u0027aodh-api\u0027]"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"2d0cfb85_1c172bd0","line":26,"updated":"2025-01-20 09:15:36.000000000","message":"what is the reason for changing the data structure and omitting the additional entry that would allow the original statement to continue working? I would prefer if we could keep that in place and avoid having to change so many files","commit_id":"68bac9407087eb83c0534afac6e78c23ee7eff18"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2fc2882cf20aae1c753517e4f9f037b639c225b5","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    timeout: 1"},{"line_number":24,"context_line":"    state: stopped"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - container_facts.containers[\u0027aodh_api\u0027] is not defined"},{"line_number":27,"context_line":"    - inventory_hostname in groups[\u0027aodh-api\u0027]"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"63122d00_0659a9b8","line":26,"in_reply_to":"2d0cfb85_1c172bd0","updated":"2025-01-23 08:29:19.000000000","message":"This was in preparation for the subsequent patch set #912460 as now this module can return not only container info but also volume info.\n\nSee file https://review.opendev.org/c/openstack/kolla-ansible/+/912460/14/ansible/roles/ovn-db/tasks/lookup_cluster.yml for an example.","commit_id":"68bac9407087eb83c0534afac6e78c23ee7eff18"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"50e5a51b5b52befe60944708b1a8387e3a1cbf7f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    timeout: 1"},{"line_number":24,"context_line":"    state: stopped"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - container_facts.containers[\u0027aodh_api\u0027] is not defined"},{"line_number":27,"context_line":"    - inventory_hostname in groups[\u0027aodh-api\u0027]"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"ac34e1bf_54987011","line":26,"in_reply_to":"63122d00_0659a9b8","updated":"2025-01-23 09:14:07.000000000","message":"I guess in the long run this is the better approach, right.","commit_id":"68bac9407087eb83c0534afac6e78c23ee7eff18"}],"tests/test_kolla_container_facts.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"679bd6bb81b84da580586879f70943b543b4d3f7","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        dfw \u003d kcf.DockerFactsWorker(module)"},{"line_number":72,"context_line":"        dfw.client \u003d mock.MagicMock()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return dfw"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def get_PodmanFactsWorker(mod_param):"}],"source_content_type":"text/x-python","patch_set":25,"id":"2eecc830_92b701bc","line":74,"updated":"2025-01-20 09:15:36.000000000","message":"Should this return really be done inside the `with` context? If yes, maybe delete the empty line in front of it, to make it look less like an accident.","commit_id":"68bac9407087eb83c0534afac6e78c23ee7eff18"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2fc2882cf20aae1c753517e4f9f037b639c225b5","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        dfw \u003d kcf.DockerFactsWorker(module)"},{"line_number":72,"context_line":"        dfw.client \u003d mock.MagicMock()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return dfw"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def get_PodmanFactsWorker(mod_param):"}],"source_content_type":"text/x-python","patch_set":25,"id":"cc42225d_d254c030","line":74,"in_reply_to":"2eecc830_92b701bc","updated":"2025-01-23 08:29:19.000000000","message":"There are two approaches - use a decorator or use a with statement. Ivan (no longer on this project) decided to go with with statement.\n\nI updated it to a decorator, I hope this will clear it up a little.","commit_id":"68bac9407087eb83c0534afac6e78c23ee7eff18"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"50e5a51b5b52befe60944708b1a8387e3a1cbf7f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        dfw \u003d kcf.DockerFactsWorker(module)"},{"line_number":72,"context_line":"        dfw.client \u003d mock.MagicMock()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return dfw"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def get_PodmanFactsWorker(mod_param):"}],"source_content_type":"text/x-python","patch_set":25,"id":"ef070be0_288e5beb","line":74,"in_reply_to":"cc42225d_d254c030","updated":"2025-01-23 09:14:07.000000000","message":"Acknowledged","commit_id":"68bac9407087eb83c0534afac6e78c23ee7eff18"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cb84be2be19d89f2cc7778578fa3c87d6c1e7b70","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        return dfw"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def get_PodmanFactsWorker(mod_param):"},{"line_number":78,"context_line":"    module \u003d mock.MagicMock()"},{"line_number":79,"context_line":"    module.params \u003d copy.deepcopy(mod_param)"},{"line_number":80,"context_line":"    pfw \u003d kcf.PodmanFactsWorker(module)"}],"source_content_type":"text/x-python","patch_set":25,"id":"56fc505f_04ac9272","line":77,"updated":"2025-01-20 09:31:25.000000000","message":"seems this function isn\u0027t used anywhere, shouldn\u0027t all the tests below be duplicated running on podman?","commit_id":"68bac9407087eb83c0534afac6e78c23ee7eff18"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2fc2882cf20aae1c753517e4f9f037b639c225b5","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        return dfw"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def get_PodmanFactsWorker(mod_param):"},{"line_number":78,"context_line":"    module \u003d mock.MagicMock()"},{"line_number":79,"context_line":"    module.params \u003d copy.deepcopy(mod_param)"},{"line_number":80,"context_line":"    pfw \u003d kcf.PodmanFactsWorker(module)"}],"source_content_type":"text/x-python","patch_set":25,"id":"fb420399_d0e932ac","line":77,"in_reply_to":"56fc505f_04ac9272","updated":"2025-01-23 08:29:19.000000000","message":"Ivan added this in preparation for exactly this, but in the end, the data and the data format is almost identical between PodmanClient and DockerClient, so there is no need to test podman and docker independently. I\u0027ve added a note explaining this and removed the get_PodmanFactsWorker function.","commit_id":"68bac9407087eb83c0534afac6e78c23ee7eff18"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"50e5a51b5b52befe60944708b1a8387e3a1cbf7f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        return dfw"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def get_PodmanFactsWorker(mod_param):"},{"line_number":78,"context_line":"    module \u003d mock.MagicMock()"},{"line_number":79,"context_line":"    module.params \u003d copy.deepcopy(mod_param)"},{"line_number":80,"context_line":"    pfw \u003d kcf.PodmanFactsWorker(module)"}],"source_content_type":"text/x-python","patch_set":25,"id":"63dbe5d5_89ff8f86","line":77,"in_reply_to":"fb420399_d0e932ac","updated":"2025-01-23 09:14:07.000000000","message":"Acknowledged","commit_id":"68bac9407087eb83c0534afac6e78c23ee7eff18"}]}