)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fde1a7411fd010536c57f2858d327a8c4c204695","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cbd4356f_aae7cbf8","updated":"2024-03-12 16:23:35.000000000","message":"Does this need to be backported - or is this only relevant in the case where we merge your kolla_container_facts patches?\n-1 for getting attention on this question","commit_id":"61413dbbd3470c44c328cff34b6f13a4db5d9480"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bf322bc0f36ecf5b26c4a38d9079d082b51cad9b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ade2d00c_872c287d","updated":"2024-03-12 15:27:17.000000000","message":"where does this fail? is there a bug report or at least a failed CI run that shows the actual problem? I can not judge the correctness of the fix without any information why the prior solution was wrong.\n\nIf there is a bug report showing the problem, please link it in the commit message.\n\nThank you.","commit_id":"61413dbbd3470c44c328cff34b6f13a4db5d9480"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"edca95e90687c0d1f9990d2825ea17f7cffe5d62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"73b2b18a_d74ce423","in_reply_to":"985313d7_2cc19330","updated":"2024-03-12 16:06:54.000000000","message":"Acknowledged","commit_id":"61413dbbd3470c44c328cff34b6f13a4db5d9480"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"220820aee654ee5210ae5cf9daa7edd4a722b3ef","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"985313d7_2cc19330","in_reply_to":"ade2d00c_872c287d","updated":"2024-03-12 15:44:33.000000000","message":"I am not aware of any bug report nor failed CI run because the missing functionality is not used anywhere - every usage of kolla_container_facts is used to get facts from exact few containers, not every container.\n\nIf you examine the function use_docker, you can find the same condition used in the same way - to get facts of all the containers when no names are provided.\n\nI think this functionality should be available for Podman, even though it is not currently used.","commit_id":"61413dbbd3470c44c328cff34b6f13a4db5d9480"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"5fc5c40c2fed5f788ac3ceeb39a1e289ba3aead3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d712ffac_62b13c55","in_reply_to":"cbd4356f_aae7cbf8","updated":"2024-03-13 09:18:22.000000000","message":"This is pretty much independent from those patches and I think it should be backported because, in the end, it is missing functionality.","commit_id":"61413dbbd3470c44c328cff34b6f13a4db5d9480"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"28f0cc1f6b4d9d8673233124b2043d73aaa06835","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9af22d7d_b457fafe","in_reply_to":"d712ffac_62b13c55","updated":"2024-03-20 14:18:30.000000000","message":"Then please raise a bug and attach it in commit message please.","commit_id":"61413dbbd3470c44c328cff34b6f13a4db5d9480"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3eae9945bfbde0053af53e9a76f1ee33d17a2712","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7401efff_9cc20056","updated":"2024-04-02 16:30:42.000000000","message":"added to kolla whiteboard in order to get more core reviews.","commit_id":"a7c8bcda2e8b3c9d218555349d0440a9c9232fa1"}]}