)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c0013a55ee2a9b5e43624444286cd55f637b0056","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ce223705_6dd788ae","updated":"2024-03-15 13:39:12.000000000","message":"I can\u0027t see the screenshot in Gerrit for some reason. Please could you update the bug report to clarify the issue?\n\nSince we are not pinning the OpenSearch release, it makes sense (in my opinion) that we should not use the ElasticSearch 7 datasource, and that this patch should be backported in its simplest form. This is because the OpenSearch API has diverged from ElasticSearch. Hence backport +2.","commit_id":"d64d94695930d3737f9f6bf92c27fd1b05f2e763"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"dde41373a2142f3eb78fd49a5080016d6a8d684d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eb3ee4d7_bdde5cbf","updated":"2024-03-15 15:59:00.000000000","message":"Thanks for updating Dawud - one small change.","commit_id":"0dead91faf0f15f2d2a9e3ee1d38331d3a0a8f12"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"af20f6c5e62edf03013b33ce486308718a2f93a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a652e60d_7b17843a","updated":"2024-04-29 12:36:50.000000000","message":"Depends on Ia3a39c975abf815a66765f2f98c4789d6cec33d7 which was backported after antelope release.","commit_id":"9afc9da22621cc808287874915ab3c1305592d15"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d85be44bb34238c503021ccfad8d31db8fc9b53d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f0b98cb7_9de04194","updated":"2024-03-15 16:38:05.000000000","message":"Thanks Dawud - this looks good to me.","commit_id":"9afc9da22621cc808287874915ab3c1305592d15"}],"ansible/roles/grafana/defaults/main.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c0013a55ee2a9b5e43624444286cd55f637b0056","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        version: \"2.11.1\""},{"line_number":71,"context_line":"        timeField: \"@timestamp\""},{"line_number":72,"context_line":"        logLevelField: \"log_level\""},{"line_number":73,"context_line":"        logMessageField: \"payload\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"##########"},{"line_number":76,"context_line":"# Grafana"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"afea9912_145fd968","line":73,"updated":"2024-03-15 13:39:12.000000000","message":"Strictly, the addition of these two fields should be in a separate patch. They still claim to be \u0027beta\u0027 features in the doc [1], but then it talks about Grafana 6, so it seems that they\u0027ve been around for some time. There is quirk that not all logs messages are in the \u0027Payload\u0027 field (some are in \u0027message\u0027). I think we should fix that in Fluentd separately, another time. \n\n[1] https://grafana.com/grafana/plugins/grafana-opensearch-datasource/","commit_id":"d64d94695930d3737f9f6bf92c27fd1b05f2e763"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"55ccd0df3f4d122cfcc95b173d6381a3f163f9e5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        version: \"2.11.1\""},{"line_number":71,"context_line":"        timeField: \"@timestamp\""},{"line_number":72,"context_line":"        logLevelField: \"log_level\""},{"line_number":73,"context_line":"        logMessageField: \"payload\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"##########"},{"line_number":76,"context_line":"# Grafana"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6282cd8a_fe805c12","line":73,"in_reply_to":"afea9912_145fd968","updated":"2024-03-15 15:50:19.000000000","message":"Done","commit_id":"d64d94695930d3737f9f6bf92c27fd1b05f2e763"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"dde41373a2142f3eb78fd49a5080016d6a8d684d","unresolved":true,"context_lines":[{"line_number":66,"context_line":"      url: \"{{ opensearch_internal_endpoint }}\""},{"line_number":67,"context_line":"      jsonData:"},{"line_number":68,"context_line":"        flavor: \"OpenSearch\""},{"line_number":69,"context_line":"        database: \"flog-*\""},{"line_number":70,"context_line":"        version: \"2.11.1\""},{"line_number":71,"context_line":"        timeField: \"@timestamp\""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cc807da0_298d9737","line":69,"updated":"2024-03-15 15:59:00.000000000","message":"nit: Please use `opensearch_log_index_prefix` here. It\u0027s in group_vars/all.yml","commit_id":"0dead91faf0f15f2d2a9e3ee1d38331d3a0a8f12"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"8fc216f6e0a5931d07e1bfa67630322f80817e8d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      url: \"{{ opensearch_internal_endpoint }}\""},{"line_number":67,"context_line":"      jsonData:"},{"line_number":68,"context_line":"        flavor: \"OpenSearch\""},{"line_number":69,"context_line":"        database: \"flog-*\""},{"line_number":70,"context_line":"        version: \"2.11.1\""},{"line_number":71,"context_line":"        timeField: \"@timestamp\""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2eec15fa_64fa14a7","line":69,"in_reply_to":"cc807da0_298d9737","updated":"2024-03-15 16:05:34.000000000","message":"Thanks. I hadn\u0027t seen that","commit_id":"0dead91faf0f15f2d2a9e3ee1d38331d3a0a8f12"}],"releasenotes/notes/grafana-opensearch-datasource-configuration-04202c059f1abd05.yaml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d88717743aedc20926782bef641cafeaf531b68c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Updates the default Grafana datasource configuration to use values for"},{"line_number":5,"context_line":"    OpenSearch that work out of the box. Replaces the Elasticsearch values that"},{"line_number":6,"context_line":"    were previously being used."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cbe9b288_6587fef9","line":4,"updated":"2024-03-15 13:42:04.000000000","message":"Please could you expand on how to apply the fix? IIRC, you will need to manually remove the old datasource, before KA will configure the updated datasource? Please clarify the risk to breaking peoples dashboards, if they are based on the ElasticSearch datasource. I guess you may get away with it, since the actual datasource name isn\u0027t changing?","commit_id":"d64d94695930d3737f9f6bf92c27fd1b05f2e763"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"55ccd0df3f4d122cfcc95b173d6381a3f163f9e5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Updates the default Grafana datasource configuration to use values for"},{"line_number":5,"context_line":"    OpenSearch that work out of the box. Replaces the Elasticsearch values that"},{"line_number":6,"context_line":"    were previously being used."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7beeb92b_63444ead","line":4,"in_reply_to":"cbe9b288_6587fef9","updated":"2024-03-15 15:50:19.000000000","message":"I included a note on using a datasource variable as that helps with easily changing. However this shouldn\u0027t break dashboards that were using the elasticsearch plugin as if it was a fresh install they would have never had ES but if they did have the ES plugin then this isnt affecting any settings relating to that and it shouldn\u0027t break.","commit_id":"d64d94695930d3737f9f6bf92c27fd1b05f2e763"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7aa394c8a3c4d6a6564836bb44aa6638da94d897","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Updates the default Grafana OpenSearch datasource configuration to use"},{"line_number":5,"context_line":"    values for OpenSearch that work out of the box. Replaces the Elasticsearch"},{"line_number":6,"context_line":"    values that were previously being used. The new configuration can be"},{"line_number":7,"context_line":"    applied by deleting your datasource and reconfiguring Grafana through kolla"},{"line_number":8,"context_line":"    ansible. In order to prevent dashboards from breaking when the datasource"},{"line_number":9,"context_line":"    is deleted, one should use `datasource variables"},{"line_number":10,"context_line":"    \u003chttps://grafana.com/docs/grafana/latest/dashboards/variables/add-template-variables/#add-a-data-source-variable\u003e`__"},{"line_number":11,"context_line":"    in Grafana. See bug `2039500 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/2039500\u003e`__."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"cea000e3_ebdb2d7b","line":11,"range":{"start_line":2,"start_character":0,"end_line":11,"end_character":92},"updated":"2024-03-18 13:59:05.000000000","message":"we still support elasticsearch via the external es cluster feature.\n\nAt least this must go also in the `upgrade:` notes as I understand this is a breaking change, isn\u0027t it?","commit_id":"9afc9da22621cc808287874915ab3c1305592d15"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"30d838b9585de48f0bf661de20605e78e3ceffe2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Updates the default Grafana OpenSearch datasource configuration to use"},{"line_number":5,"context_line":"    values for OpenSearch that work out of the box. Replaces the Elasticsearch"},{"line_number":6,"context_line":"    values that were previously being used. The new configuration can be"},{"line_number":7,"context_line":"    applied by deleting your datasource and reconfiguring Grafana through kolla"},{"line_number":8,"context_line":"    ansible. In order to prevent dashboards from breaking when the datasource"},{"line_number":9,"context_line":"    is deleted, one should use `datasource variables"},{"line_number":10,"context_line":"    \u003chttps://grafana.com/docs/grafana/latest/dashboards/variables/add-template-variables/#add-a-data-source-variable\u003e`__"},{"line_number":11,"context_line":"    in Grafana. See bug `2039500 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/2039500\u003e`__."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ede4fdf4_05e35f0c","line":11,"range":{"start_line":2,"start_character":0,"end_line":11,"end_character":92},"in_reply_to":"c33243a5_e9100e9b","updated":"2024-03-20 13:31:36.000000000","message":"ah I was not aware that this is a no-op if the datasource already existed before, thanks for the clarification! I thought existing ES installs would need to take action when this fix is applied.","commit_id":"9afc9da22621cc808287874915ab3c1305592d15"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"48793d23b2c869a7b29aa735b2a7ee2ad66a43fa","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Updates the default Grafana OpenSearch datasource configuration to use"},{"line_number":5,"context_line":"    values for OpenSearch that work out of the box. Replaces the Elasticsearch"},{"line_number":6,"context_line":"    values that were previously being used. The new configuration can be"},{"line_number":7,"context_line":"    applied by deleting your datasource and reconfiguring Grafana through kolla"},{"line_number":8,"context_line":"    ansible. In order to prevent dashboards from breaking when the datasource"},{"line_number":9,"context_line":"    is deleted, one should use `datasource variables"},{"line_number":10,"context_line":"    \u003chttps://grafana.com/docs/grafana/latest/dashboards/variables/add-template-variables/#add-a-data-source-variable\u003e`__"},{"line_number":11,"context_line":"    in Grafana. See bug `2039500 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/2039500\u003e`__."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"afcdc1f6_e46589e5","line":11,"range":{"start_line":2,"start_character":0,"end_line":11,"end_character":92},"in_reply_to":"cea000e3_ebdb2d7b","updated":"2024-03-18 14:42:24.000000000","message":"I think if we want to support elastic through the es cluster feature we should be using a separate datasource for that, the elasticsearch datasource. I don\u0027t think we should be configuring the opensearch plugin to use elasticsearch value.\n\nAdditionally, this isn\u0027t a breaking change. For this change to be applied, you will have to delete the opensearch datasource as the api call made to grafana only adds a datasource with the name and if one already exists it is a no-op.","commit_id":"9afc9da22621cc808287874915ab3c1305592d15"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"48793d23b2c869a7b29aa735b2a7ee2ad66a43fa","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Updates the default Grafana OpenSearch datasource configuration to use"},{"line_number":5,"context_line":"    values for OpenSearch that work out of the box. Replaces the Elasticsearch"},{"line_number":6,"context_line":"    values that were previously being used. The new configuration can be"},{"line_number":7,"context_line":"    applied by deleting your datasource and reconfiguring Grafana through kolla"},{"line_number":8,"context_line":"    ansible. In order to prevent dashboards from breaking when the datasource"},{"line_number":9,"context_line":"    is deleted, one should use `datasource variables"},{"line_number":10,"context_line":"    \u003chttps://grafana.com/docs/grafana/latest/dashboards/variables/add-template-variables/#add-a-data-source-variable\u003e`__"},{"line_number":11,"context_line":"    in Grafana. See bug `2039500 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/2039500\u003e`__."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c33243a5_e9100e9b","line":11,"range":{"start_line":2,"start_character":0,"end_line":11,"end_character":92},"in_reply_to":"cea000e3_ebdb2d7b","updated":"2024-03-18 14:42:24.000000000","message":"I think that if we want to","commit_id":"9afc9da22621cc808287874915ab3c1305592d15"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d109c49703d4dbea091e7ac498644a88b91cadba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Updates the default Grafana OpenSearch datasource configuration to use"},{"line_number":5,"context_line":"    values for OpenSearch that work out of the box. Replaces the Elasticsearch"},{"line_number":6,"context_line":"    values that were previously being used. The new configuration can be"},{"line_number":7,"context_line":"    applied by deleting your datasource and reconfiguring Grafana through kolla"},{"line_number":8,"context_line":"    ansible. In order to prevent dashboards from breaking when the datasource"},{"line_number":9,"context_line":"    is deleted, one should use `datasource variables"},{"line_number":10,"context_line":"    \u003chttps://grafana.com/docs/grafana/latest/dashboards/variables/add-template-variables/#add-a-data-source-variable\u003e`__"},{"line_number":11,"context_line":"    in Grafana. See bug `2039500 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/2039500\u003e`__."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"97c7e99c_8866d420","line":11,"range":{"start_line":2,"start_character":0,"end_line":11,"end_character":92},"in_reply_to":"ede4fdf4_05e35f0c","updated":"2024-03-21 09:16:38.000000000","message":"Aside: We should probably stop using the API to configure the datasources at some stage [1]. I think that dates back to when Grafana didn\u0027t support a file, like we now use for Prometheus [2].\n\n[1] https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/grafana/tasks/post_config.yml#L23\n[2] https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/grafana/tasks/config.yml#L88","commit_id":"9afc9da22621cc808287874915ab3c1305592d15"}]}