)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"232adffa80d2b0a30a8a3e886674695d1a05ff73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"87a6c603_d9eca713","updated":"2024-09-10 08:01:21.000000000","message":"recheck TASK [service-images-pull : loadbalancer | Pull images] failed \n\n```\n    \"msg\": \"\u0027Traceback (most recent call last):\\\\n  File \\\"/usr/lib/python3/dist-packages/docker/api/client.py\\\", line 268, in _raise_for_status\\\\n    response.raise_for_status()\\\\n  File \\\"/usr/lib/python3/dist-packages/requests/models.py\\\", line 1021, in raise_for_status\\\\n    raise HTTPError(http_error_msg, response\u003dself)\\\\nrequests.exceptions.HTTPError: 404 Client Error: Not Found for url: http+docker://localhost/v1.47/images/create?tag\u003dchange_913724\u0026fromImage\u003dprimary%3A4000%2Flokolla%2Fproxysql\\\\n\\\\nThe above exception was the direct cause of the following exception:\\\\n\\\\nTraceback (most recent call last):\\\\n  File \\\"/tmp/ansible_kolla_container_payload_3ivi3iod/ansible_kolla_container_payload.zip/ansible/modules/kolla_container.py\\\", line 425, in main\\\\n  File \\\"/tmp/ansible_kolla_container_payload_3ivi3iod/ansible_kolla_container_payload.zip/ansible/module_utils/kolla_docker_worker.py\\\", line 202, in pull_image\\\\n    json.loads(line.strip().decode(\\\\\u0027utf-8\\\\\u0027)) for line in self.dc.pull(\\\\n                                                         ^^^^^^^^^^^^^\\\\n  File \\\"/usr/lib/python3/dist-packages/docker/api/image.py\\\", line 429, in pull\\\\n    self._raise_for_status(response)\\\\n  File \\\"/usr/lib/python3/dist-packages/docker/api/client.py\\\", line 270, in _raise_for_status\\\\n    raise create_api_error_from_http_exception(e) from e\\\\n          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\\\\n  File \\\"/usr/lib/python3/dist-packages/docker/errors.py\\\", line 39, in create_api_error_from_http_exception\\\\n    raise cls(e, response\u003dresponse, explanation\u003dexplanation) from e\\\\ndocker.errors.NotFound: 404 Client Error for http+docker://localhost/v1.47/images/create?tag\u003dchange_913724\u0026fromImage\u003dprimary%3A4000%2Flokolla%2Fproxysql: Not Found (\\\"manifest for primary:4000/lokolla/proxysql:change_913724 not found: manifest unknown: manifest unknown\\\")\\\\n\u0027\",\n```","commit_id":"fc05834632997aef761fb3994f6a570c58b08160"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"abaa1a452121717d6ed2c716a1d9142dd09334f7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d4202947_4131f457","in_reply_to":"87a6c603_d9eca713","updated":"2024-09-10 10:21:20.000000000","message":"Hmm, so there is something bad with CI i would say because I can see it\u0027s sucessfully tagged and built.\n\nINFO:kolla.common.utils.keepalived:Successfully tagged primary:4000/lokolla/keepalived:change_913724\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_26d/913724/12/check/kolla-ansible-debian/26d4a7a/primary/logs/build/keepalived.log","commit_id":"fc05834632997aef761fb3994f6a570c58b08160"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8d42a46dbbc75f8c4ed5b5016e2eb8354819a850","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"308b14ee_def7988a","in_reply_to":"d4202947_4131f457","updated":"2024-09-10 10:45:37.000000000","message":"Okay, fixed setup_gate.sh. Now it will probably pass.","commit_id":"fc05834632997aef761fb3994f6a570c58b08160"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e80040f1fe86a45069eba4b9444b5e512bb76155","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1747f69c_07ca571e","updated":"2024-09-11 16:06:20.000000000","message":"https://github.com/percona/percona-xtrabackup/blob/cc111bf9309c0dcd9e19aca3c5c884a4001c4050/storage/innobase/xtrabackup/src/backup_mysql.cc#L408-L420 \n\n😞","commit_id":"aede25ce242a3456a7b8c7b04795e34e0c3fa71d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ab28d15bcd5a49b55180dde8ec7013372bc5465d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"74616b4a_39c9b456","updated":"2024-09-11 12:29:25.000000000","message":"we have an issue in test-mariadb.sh:\n\n```\n   \"msg\": \"Container timed out\"\n```\n\nin task:\n\n```\nTASK [mariadb : Restart master MariaDB container(s)]\n```\n\n```\n\u003c23.253.108.25\u003e ESTABLISH SSH CONNECTION FOR USER: None\n\n\u003c23.253.108.25\u003e SSH: EXEC ssh -C -o ControlMaster\u003dauto -o ControlPersist\u003d300 -o StrictHostKeyChecking\u003dno -o KbdInteractiveAuthentication\u003dno -o PreferredAuthentications\u003dgssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication\u003dno -o ConnectTimeout\u003d10 -o \u0027ControlPath\u003d\"/home/zuul/.ansible/cp/ef2befb4e2\"\u0027 23.253.108.25 \u0027/bin/sh -c \u0027\"\u0027\"\u0027sudo -H -S -n  -u root /bin/sh -c \u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027echo BECOME-SUCCESS-eonzfululcokwzmguppuifluyckoftsv ; /usr/bin/python3\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027 \u0026\u0026 sleep 0\u0027\"\u0027\"\u0027\u0027\n\nEscalation succeeded\n\n\u003c23.253.108.25\u003e (1, b\u0027\\n{\"changed\": true, \"Id\": \"bf7e58b26c4554d3a6186890c2e0afb9fbcf2168bec5f6b098d04512fa7b64b9\", \"Names\": [\"/mariadb_clustercheck\"], \"Image\": \"primary:4000/lokolla/mariadb-clustercheck:change_913724\", \"ImageID\": \"sha256:b18a32f061b75924d4232dd228c0fedafb4fcd53bf72170531f789dc7d20998c\", \"Command\": \"dumb-init --single-child -- kolla_start\", \"Created\": 1725990149, \"Ports\": [], \"Labels\": {\"build-date\": \"20240910\", \"io.buildah.version\": \"1.33.7\", \"kolla_version\": \"18.1.0\", \"license\": \"BSD-3-Clause\", \"maintainer\": \"Kolla Project (https://launchpad.net/kolla)\", \"name\": \"mariadb-clustercheck\", \"org.opencontainers.image.authors\": \"Magauer Lukas, Neil Hanlon, Louis Abel\", \"org.opencontainers.image.license\": \"BSD-3-Clause\", \"org.opencontainers.image.name\": \"rockylinux\", \"org.opencontainers.image.url\": \"https://github.com/rocky-linux/rocky-toolbox-images\", \"org.opencontainers.image.vendor\": \"Rocky Enterprise Software Foundation\", \"org.opencontainers.image.version\": \"9\", \"vendor\": \"Rocky Enterprise Software Foundation\", \"version\": \"9\"}, \"State\": \"exited\", \"Status\": \"Exited (2) 2 minutes ago\", \"HostConfig\": {\"NetworkMode\": \"host\"}, \"NetworkSettings\": {\"Networks\": {\"host\": {\"IPAMConfig\": null, \"Links\": null, \"Aliases\": null, \"MacAddress\": \"\", \"DriverOpts\": null, \"NetworkID\": \"f39e6d357abba3b9cc36cf4061912613972ac9038f2fe2b019d0decc635a3ff5\", \"EndpointID\": \"\", \"Gateway\": \"\", \"IPAddress\": \"\", \"IPPrefixLen\": 0, \"IPv6Gateway\": \"\", \"GlobalIPv6Address\": \"\", \"GlobalIPv6PrefixLen\": 0, \"DNSNames\": null}}}, \"Mounts\": [{\"Type\": \"volume\", \"Name\": \"kolla_logs\", \"Source\": \"/var/lib/docker/volumes/kolla_logs/_data\", \"Destination\": \"/var/log/kolla\", \"Driver\": \"local\", \"Mode\": \"rw\", \"RW\": true, \"Propagation\": \"\"}, {\"Type\": \"bind\", \"Source\": \"/etc/localtime\", \"Destination\": \"/etc/localtime\", \"Mode\": \"ro\", \"RW\": false, \"Propagation\": \"rprivate\"}, {\"Type\": \"bind\", \"Source\": \"/etc/kolla/mariadb-clustercheck\", \"Destination\": \"/var/lib/kolla/config_files\", \"Mode\": \"ro\", \"RW\": false, \"Propagation\": \"rprivate\"}], \"failed\": true, \"msg\": \"Container timed out\", \"invocation\": {\"module_args\": {\"auth_email\": null, \"auth_password\": null, \"auth_registry\": \"primary:4000\", \"auth_username\": null, \"restart_policy\": \"no\", \"restart_retries\": 10, \"graceful_timeout\": 60, \"client_timeout\": 120, \"container_engine\": \"docker\", \"action\": \"recreate_or_restart_container\", \"name\": \"mariadb_clustercheck\", \"image\": \"primary:4000/lokolla/mariadb-clustercheck:change_913724\", \"volumes\": [\"/etc/kolla/mariadb-clustercheck/:/var/lib/kolla/config_files/:ro\", \"/etc/localtime:/etc/localtime:ro\", \"\", \"kolla_logs:/var/log/kolla/\"], \"dimensions\": {\"ulimits\": {\"nofile\": {\"soft\": 1048576, \"hard\": 1048576}}}, \"detach\": true, \"labels\": {}, \"cap_add\": [], \"security_opt\": [], \"privileged\": false, \"remove_on_exit\": true, \"state\": \"running\", \"tls_verify\": false, \"tty\": false, \"ignore_missing\": false, \"api_version\": \"auto\", \"environment\": {\"KOLLA_CONFIG_STRATEGY\": \"COPY_ALWAYS\", \"MYSQL_USERNAME\": \"monitor\", \"MYSQL_PASSWORD\": \"Q79n8JpduaSqk8JeM7KIX8fn7nL99MJJObOxFqtK\", \"MYSQL_HOST\": \"192.0.2.1\", \"AVAILABLE_WHEN_DONOR\": \"1\", \"KOLLA_SERVICE_NAME\": \"mariadb-clustercheck\"}}}}\\n\u0027, b\u0027\u0027)\n\n\u003c23.253.108.25\u003e Failed to connect to the host via ssh: \n\nfailed: [primary] (item\u003d{\u0027key\u0027: \u0027mariadb-clustercheck\u0027, \u0027value\u0027: {\u0027container_name\u0027: \u0027mariadb_clustercheck\u0027, \u0027group\u0027: \u0027mariadb_shard_0\u0027, \u0027enabled\u0027: False, \u0027image\u0027: \u0027primary:4000/lokolla/mariadb-clustercheck:change_913724\u0027, \u0027volumes\u0027: [\u0027/etc/kolla/mariadb-clustercheck/:/var/lib/kolla/config_files/:ro\u0027, \u0027/etc/localtime:/etc/localtime:ro\u0027, \u0027\u0027, \u0027kolla_logs:/var/log/kolla/\u0027], \u0027dimensions\u0027: {\u0027ulimits\u0027: {\u0027nofile\u0027: {\u0027soft\u0027: 1048576, \u0027hard\u0027: 1048576}}}, \u0027environment\u0027: {\u0027MYSQL_USERNAME\u0027: \u0027monitor\u0027, \u0027MYSQL_PASSWORD\u0027: \u0027Q79n8JpduaSqk8JeM7KIX8fn7nL99MJJObOxFqtK\u0027, \u0027MYSQL_HOST\u0027: \u0027192.0.2.1\u0027, \u0027AVAILABLE_WHEN_DONOR\u0027: \u00271\u0027}}}) \u003d\u003e {\n\n    \"Command\": \"dumb-init --single-child -- kolla_start\",\n```\n\njob: https://zuul.opendev.org/t/openstack/build/6bec05db47b64558b33ae00170cf1766/log/primary/logs/ansible/test-mariadb\n\nkolla-ansible-rocky9-mariadb (non-voting)FAILURE","commit_id":"aede25ce242a3456a7b8c7b04795e34e0c3fa71d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c5bc0b17f83565842e603de9587f8c634a3bc050","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a7160290_4b76516e","in_reply_to":"40afadaa_7d2bca3c","updated":"2024-09-11 15:14:06.000000000","message":"I know probably what is going on ...","commit_id":"aede25ce242a3456a7b8c7b04795e34e0c3fa71d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b38aea52db9f4fea25d3aec72d15da3cf5e0272b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"8a3116c1_d8577917","in_reply_to":"501230bb_ba3d2bcb","updated":"2024-09-12 15:46:47.000000000","message":"Yep, outdated ... \n\n(kolla-ansible)[root]# mysql -h 192.168.205.254 -u root_shard_1 -p\nEnter password: \nWelcome to the MariaDB monitor.  Commands end with ; or \\g.\nYour MySQL connection id is 618973\nServer version: 8.0.11 (ProxySQL)\n\nCopyright (c) 2000, 2018, Oracle, MariaDB Corporation Ab and others.\n\nType \u0027help;\u0027 or \u0027\\h\u0027 for help. Type \u0027\\c\u0027 to clear the current input statement.\n\nMySQL [(none)]\u003e exit\n\n\n..... reconfigure .......\n\n\nTASK [loadbalancer : Copying over proxysql config] ****************************************************************************************************************************************************************\n--- before: /etc/kolla/proxysql/proxysql.yaml\n+++ after: /root/.ansible/tmp/ansible-local-83624ea5iwm21/tmpl2pr72on/proxysql.yaml.j2\n@@ -22,6 +22,7 @@\n    interfaces: \"192.168.205.254:3306\"\n    monitor_username: \"monitor\"\n    monitor_password: \"ultimum\"\n+   server_version: \"Sven\u0027s version 10.0.1\"\n\n\n\n..........vuaalaaa.............\n\n\n\n(kolla-ansible)[root]# mysql -h 192.168.205.254 -u root_shard_1 -p\nEnter password: \nWelcome to the MariaDB monitor.  Commands end with ; or \\g.\nYour MySQL connection id is 101\nServer version: Sven\u0027s version 10.0.1 (ProxySQL)\n\nCopyright (c) 2000, 2018, Oracle, MariaDB Corporation Ab and others.\n\nType \u0027help;\u0027 or \u0027\\h\u0027 for help. Type \u0027\\c\u0027 to clear the current input statement.\n\nMySQL [(none)]\u003e","commit_id":"aede25ce242a3456a7b8c7b04795e34e0c3fa71d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"39667568fa573f68f738c52021c70abffc49edf1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"40afadaa_7d2bca3c","in_reply_to":"74616b4a_39c9b456","updated":"2024-09-11 12:32:58.000000000","message":"this is the call which fails:\n\n```\n\nfunction mariadb_recovery {\n    # Recover the database cluster.\n    echo \"Recovering the database cluster\"\n    kolla-ansible -i ${RAW_INVENTORY} -vvv mariadb_recovery --tags mariadb --skip-tags common\n```\n\nlooking into the recovery code.","commit_id":"aede25ce242a3456a7b8c7b04795e34e0c3fa71d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"723073a521f87526636215946f4f6f251d1cdb54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b1760f9f_1ead0f00","in_reply_to":"8a3116c1_d8577917","updated":"2024-09-14 13:18:14.000000000","message":"This was something different.  mariadb-clusrtercheck was not installed. But mariadb scenartio testing restore which is going through the same code ... where during the restore clustercheck was started. Now fixed.","commit_id":"aede25ce242a3456a7b8c7b04795e34e0c3fa71d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"93a935f00ccbd5e4deaccce959757918bcf135d6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"f6d92d1c_cf225238","in_reply_to":"a7160290_4b76516e","updated":"2024-09-11 15:46:26.000000000","message":"VIP - ProxySQL\n\n(kolla-ansible)[root]# mysql -h 192.168.205.254 -u root_shard_1 -p\nEnter password: \nWelcome to the MariaDB monitor.  Commands end with ; or \\g.\nYour MySQL connection id is 7706\nServer version: 8.0.11 (ProxySQL)    \u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c Client reporting through  ProxySQL   - FAIL\n\nCopyright (c) 2000, 2018, Oracle, MariaDB Corporation Ab and others.\n\nType \u0027help;\u0027 or \u0027\\h\u0027 for help. Type \u0027\\c\u0027 to clear the current input statement.\n\nMySQL [(none)]\u003e \nMySQL [(none)]\u003e \nMySQL [(none)]\u003e \nMySQL [(none)]\u003e select version();\n+-----------------------------+\n| version()                   |\n+-----------------------------+\n| 10.11.8-MariaDB-ubu2204-log |   \n+-----------------------------+\n1 row in set (0.003 sec)\n\nMySQL [(none)]\u003e exit\nBye\n(kolla-ansible)[root]# mysql -h 192.168.205.10 -u root_shard_1 -p\nEnter password: \nWelcome to the MariaDB monitor.  Commands end with ; or \\g.\nYour MariaDB connection id is 153\nServer version: 10.11.8-MariaDB-ubu2204-log mariadb.org binary distribution \u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c\u003c Client reporting direct - WORKING\n\nCopyright (c) 2000, 2018, Oracle, MariaDB Corporation Ab and others.\n\nType \u0027help;\u0027 or \u0027\\h\u0027 for help. Type \u0027\\c\u0027 to clear the current input statement.\n\nMariaDB [(none)]\u003e select version();\n+-----------------------------+\n| version()                   |\n+-----------------------------+\n| 10.11.8-MariaDB-ubu2204-log |\n+-----------------------------+\n1 row in set (0.001 sec)\n\nMariaDB [(none)]\u003e \n\n\n\n\nSo, xtrabackup is checking the version \n\nhttps://bugs.launchpad.net/ubuntu/+source/percona-xtrabackup/+bug/1826556\n\n\nI know how to fix it ... I can just configure right mysql_version variable so proxysql will start report the Mariadb Version ...\n\nBut that\u0027s not nice... and not dynamic","commit_id":"aede25ce242a3456a7b8c7b04795e34e0c3fa71d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"79d8394378c2a0157cfbb985fe897bf646f550ce","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"501230bb_ba3d2bcb","in_reply_to":"ea061498_34cb84ef","updated":"2024-09-12 07:48:28.000000000","message":"I don\u0027t understand several things:\n\n1. if this is configurable in proxysql, why would you consider using such option a \"hack\" exactly? what are the downsides?\n2. according to the docs https://proxysql.com/documentation/global-variables/mysql-variables/#mysql-server_version this should report Server version 5.5.30, is that outdated or am I looking at the wrong docs?\n\nThanks for your analysis!","commit_id":"aede25ce242a3456a7b8c7b04795e34e0c3fa71d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"11ce26f1f9df19bd6e2daaea87625540ed9ed762","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ea061498_34cb84ef","in_reply_to":"f4e6058a_5e23fce6","updated":"2024-09-11 17:25:18.000000000","message":"This is just explanation why it\u0027s happening ... Mariabackup C programme just checking binary version of client not the real server version.","commit_id":"aede25ce242a3456a7b8c7b04795e34e0c3fa71d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ee32d66ae9e2b44b9016775d8db16cf11dd9f639","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"f4e6058a_5e23fce6","in_reply_to":"f6d92d1c_cf225238","updated":"2024-09-11 16:33:45.000000000","message":"this is like a hack not fix","commit_id":"aede25ce242a3456a7b8c7b04795e34e0c3fa71d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a17603931444f83b1c9299d4490274e281e7977e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"7f9d59b6_c58be43f","updated":"2024-09-12 15:47:39.000000000","message":"recheck","commit_id":"a97c9dba2a442d99ef5f8602e4a97d6ae195ed4a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"92f99567a2eaa8085684110f347e69bef574f6ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"6802b1d9_69977fa3","updated":"2024-09-16 08:11:58.000000000","message":"recheck dependency updated","commit_id":"8bbc3dfdae147ccf04dcce42aa629f02029a9b7a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"61e0fadcc42d055c100d5275ff05bfbb717683e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"a18a0d4d_db396005","updated":"2024-09-17 05:47:59.000000000","message":"recheck network errors","commit_id":"8bbc3dfdae147ccf04dcce42aa629f02029a9b7a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"dc3ae6ac7678756f3e7e62d9b0e25b73ad0ac934","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"354d806b_ae71618f","updated":"2024-09-17 15:06:32.000000000","message":"recheck with new image","commit_id":"00a9495ffc5f76b6204af379076bdaa12cbf6dd7"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"451f4d2c9dc519fb797a7be76974b90b25758973","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"5567376c_11a5977c","updated":"2024-09-23 16:35:47.000000000","message":"I think we need an upgrade task to remove clustercheck container images","commit_id":"b724fedce6aedf90e20b7b1db00fe005b09f3c75"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"abc7b1510732142eeb58e3248d4ed79316aa0543","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"0e94f51e_58e3adef","in_reply_to":"5567376c_11a5977c","updated":"2024-09-23 16:56:11.000000000","message":"Well it depends.. it can be used by external scripts maybe ? but on the other side ..yeah it\u0027s not needed anymore.","commit_id":"b724fedce6aedf90e20b7b1db00fe005b09f3c75"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6440cf4b9e1de78a49ce93ddd17f2b8d44b711f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"c40f0b65_980d1edd","updated":"2024-09-26 07:44:10.000000000","message":"@matus.jenca@dnation.cloud why did you change my approved patch ? Rewrite release note ? \n\nAnd moreover break mariadb ...again.","commit_id":"347e2b5a54a06a1fdd5951f9de8c12a4389a0af1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"031afc771a06780988c2e9a11ea46b7d2b3d1dba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"67a1aa9f_24dc236a","updated":"2024-09-26 17:53:36.000000000","message":"Hmm, we forget to merge depends-on ...can we ? Please ?","commit_id":"f4202bdb4612cbec429e8cbc6cb2597d401aabcb"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7c1082dd0807ff49f2ebebe13d8fece2a288dc9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"a6d84607_1b740cee","updated":"2024-09-26 10:45:46.000000000","message":"recheck, rocky failed because of timeout","commit_id":"f4202bdb4612cbec429e8cbc6cb2597d401aabcb"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"230cba707df4cf07ec59973a6eaad28a62b162d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"ebdf8ec5_641a8439","updated":"2024-09-30 17:25:23.000000000","message":"recheck mariadb images","commit_id":"ee46051a15ad6c00cac63d54515f03a4dddd15a9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"fd386845c638002a52dcf08c53578a7742397934","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"4a8e2d0d_c10de8b3","updated":"2024-10-01 21:43:39.000000000","message":"recheck retry limit","commit_id":"cb3c64d8b7c01bab331b89bf3c92c29772253913"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e2f4051d48c2c8cd3f9237f2aec9f071f06a24f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"ed895301_2ff28f62","updated":"2024-10-02 12:27:24.000000000","message":"recheck new image","commit_id":"19375f0b2f8f04720e4dd4ffea21aa1e135df09d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d9387a28b76ffe888d4c7835cdad190a2d0da111","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"1ced46f4_b5def3aa","updated":"2024-10-02 14:35:31.000000000","message":"recheck new images","commit_id":"19375f0b2f8f04720e4dd4ffea21aa1e135df09d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8cbc5464b5b21c7f0c70c2b91d9381d780c30667","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":49,"id":"67b2af4b_3eb10767","updated":"2024-10-07 07:58:55.000000000","message":"accounting for previous w+1","commit_id":"2141ab4fd03b2ba286eabd329ae2c1c0631e9e44"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0d8e5cb30114494693888cdf5fefdeafe03bd248","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":49,"id":"51858b88_932072a6","in_reply_to":"45403412_48720a0d","updated":"2024-10-15 09:24:27.000000000","message":"Done","commit_id":"2141ab4fd03b2ba286eabd329ae2c1c0631e9e44"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"013fc31ca49763a94de67164a57d5df7bbece2ba","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":49,"id":"45403412_48720a0d","in_reply_to":"67b2af4b_3eb10767","updated":"2024-10-07 08:38:06.000000000","message":"it still needs https://review.opendev.org/c/openstack/kolla/+/928956","commit_id":"2141ab4fd03b2ba286eabd329ae2c1c0631e9e44"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1e4ad66bd4d6563d73d750fdd2ede5d35493db80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":51,"id":"c572635b_5310e040","updated":"2024-10-09 19:57:18.000000000","message":"recheck unrelated(?) error in neutron-server:\n\n2024-10-09 16:26:37.432 1038 CRITICAL neutron [None req-e59c7358-0f0b-446f-8f68-fbde0c1f6a15 - - - - - -] Unhandled error: sqlalchemy.exc.OperationalError: (pymysql.err.OperationalError) (9001, \u0027Max connect timeout reached while reaching hostgroup 0 after 10503ms\u0027)","commit_id":"8f97e09a89c88fc1b9728d75f005cdd1977beedb"}],"ansible/roles/mariadb/defaults/main.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0eedb6c08389b2a359940934220d9af5daf2220e","unresolved":true,"context_lines":[{"line_number":133,"context_line":"####################"},{"line_number":134,"context_line":"# Clustercheck"},{"line_number":135,"context_line":"####################"},{"line_number":136,"context_line":"enable_mariadb_clustercheck: \"{{ \u0027True\u0027 if mariadb_loadbalancer \u003d\u003d \u0027haproxy\u0027 else \u0027False\u0027 }}\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"####################"},{"line_number":139,"context_line":"# Sharding"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5936eecd_a6f768b7","line":136,"range":{"start_line":136,"start_character":0,"end_line":136,"end_character":2},"updated":"2024-06-28 07:40:34.000000000","message":"So I guess the reasoning here is that proxysql does it\u0027s own healthcheck of the sql backends[1], so we don\u0027t need this clustercheck, which is currently only used for haproxy backend health monitoring.\n\nHowever, the data from the proxysql backendcheck is only stored in sql itself it seems, while our haproxy backend checks are monitored via prometheus.\n\nFurthermore, by default the integrated prometheus-exporter for proxysql is disabled[2] and I didn\u0027t find any code that enables it in kolla{-ansible}.\n\nSo, I would just like to raise the question if we should maybe enable the prometheus proxysql exporter mechanism in proxysql to not lose the monitoring data about the sql backends.\n\nWhat\u0027s your opinion?\n\n[1]: https://proxysql.com/documentation/backend-monitoring/\n[2]: https://proxysql.com/documentation/prometheus-exporter/","commit_id":"5d0097578755ec24148a6842522e66743816b83c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c6ec999ae68e4f534aafa8d90e308312a162236a","unresolved":true,"context_lines":[{"line_number":133,"context_line":"####################"},{"line_number":134,"context_line":"# Clustercheck"},{"line_number":135,"context_line":"####################"},{"line_number":136,"context_line":"enable_mariadb_clustercheck: \"{{ \u0027True\u0027 if mariadb_loadbalancer \u003d\u003d \u0027haproxy\u0027 else \u0027False\u0027 }}\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"####################"},{"line_number":139,"context_line":"# Sharding"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9413f10e_6203db2d","line":136,"range":{"start_line":136,"start_character":0,"end_line":136,"end_character":2},"in_reply_to":"5936eecd_a6f768b7","updated":"2024-06-28 07:43:12.000000000","message":"agree, also I need to rework proxysql little bit for exporter to work","commit_id":"5d0097578755ec24148a6842522e66743816b83c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0045705899f32354e27b454c5f896f8716113bdd","unresolved":false,"context_lines":[{"line_number":133,"context_line":"####################"},{"line_number":134,"context_line":"# Clustercheck"},{"line_number":135,"context_line":"####################"},{"line_number":136,"context_line":"enable_mariadb_clustercheck: \"{{ \u0027True\u0027 if mariadb_loadbalancer \u003d\u003d \u0027haproxy\u0027 else \u0027False\u0027 }}\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"####################"},{"line_number":139,"context_line":"# Sharding"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"23853de6_7b10034e","line":136,"range":{"start_line":136,"start_character":0,"end_line":136,"end_character":2},"in_reply_to":"9413f10e_6203db2d","updated":"2024-09-09 14:57:51.000000000","message":"https://review.opendev.org/c/openstack/kolla-ansible/+/928619 \u003c\u003c Done here.","commit_id":"5d0097578755ec24148a6842522e66743816b83c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2ff6392231592595ab9acf6b023a18019c784a80","unresolved":true,"context_lines":[{"line_number":13,"context_line":"      MYSQL_PASSWORD: \"{% if enable_proxysql | bool %}{{ mariadb_monitor_password }}{% endif %}\""},{"line_number":14,"context_line":"      MYSQL_HOST: \"{{ api_interface_address }}\""},{"line_number":15,"context_line":"      AVAILABLE_WHEN_DONOR: \"1\""},{"line_number":16,"context_line":"    haproxy:"},{"line_number":17,"context_line":"      mariadb:"},{"line_number":18,"context_line":"        enabled: \"{{ enable_mariadb | bool and not enable_external_mariadb_load_balancer | bool }}\""},{"line_number":19,"context_line":"        mode: \"tcp\""},{"line_number":20,"context_line":"        port: \"{{ database_port }}\""},{"line_number":21,"context_line":"        listen_port: \"{{ mariadb_port }}\""},{"line_number":22,"context_line":"        frontend_tcp_extra:"},{"line_number":23,"context_line":"          - \"option clitcpka\""},{"line_number":24,"context_line":"          - \"timeout client 3600s\""},{"line_number":25,"context_line":"        backend_tcp_extra:"},{"line_number":26,"context_line":"          - \"option srvtcpka\""},{"line_number":27,"context_line":"          - \"timeout server 3600s\""},{"line_number":28,"context_line":"          - \"{% if enable_mariadb_clustercheck | bool %}option httpchk{% endif %}\""},{"line_number":29,"context_line":"        custom_member_list: \"{{ internal_haproxy_members.split(\u0027;\u0027) }}\""},{"line_number":30,"context_line":"      mariadb_external_lb:"},{"line_number":31,"context_line":"        enabled: \"{{ enable_external_mariadb_load_balancer | bool }}\""},{"line_number":32,"context_line":"        mode: \"tcp\""},{"line_number":33,"context_line":"        port: \"{{ database_port }}\""},{"line_number":34,"context_line":"        listen_port: \"{{ mariadb_port }}\""},{"line_number":35,"context_line":"        frontend_tcp_extra:"},{"line_number":36,"context_line":"          - \"option clitcpka\""},{"line_number":37,"context_line":"          - \"timeout client 3600s\""},{"line_number":38,"context_line":"        backend_tcp_extra:"},{"line_number":39,"context_line":"          - \"option srvtcpka\""},{"line_number":40,"context_line":"          - \"timeout server 3600s\""},{"line_number":41,"context_line":"        custom_member_list: \"{{ external_haproxy_members.split(\u0027;\u0027) }}\""},{"line_number":42,"context_line":"  mariadb-clustercheck:"},{"line_number":43,"context_line":"    container_name: mariadb_clustercheck"},{"line_number":44,"context_line":"    group: \"{{ mariadb_shard_group }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"2c0948b7_60197dd1","line":41,"range":{"start_line":16,"start_character":1,"end_line":41,"end_character":71},"updated":"2024-09-11 12:47:32.000000000","message":"shouldn\u0027t we ifdef this as well, so only configure this if haproxy is enabled?\n\nI see this showing up in the failed job:\n\n```\n            \"group\": \"mariadb_shard_0\",\n\n            \"haproxy\": {\n\n                \"mariadb\": {\n\n                    \"backend_tcp_extra\": [\n\n                        \"option srvtcpka\",\n\n                        \"timeout server 3600s\",\n```\n\nsee: https://zuul.opendev.org/t/openstack/build/6bec05db47b64558b33ae00170cf1766/log/primary/logs/ansible/test-mariadb (CTRL-F \"haproxy\")","commit_id":"aede25ce242a3456a7b8c7b04795e34e0c3fa71d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"263ce77942f6b0b40ad3c93ce7d3f2b71dab1787","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      MYSQL_PASSWORD: \"{% if enable_proxysql | bool %}{{ mariadb_monitor_password }}{% endif %}\""},{"line_number":14,"context_line":"      MYSQL_HOST: \"{{ api_interface_address }}\""},{"line_number":15,"context_line":"      AVAILABLE_WHEN_DONOR: \"1\""},{"line_number":16,"context_line":"    haproxy:"},{"line_number":17,"context_line":"      mariadb:"},{"line_number":18,"context_line":"        enabled: \"{{ enable_mariadb | bool and not enable_external_mariadb_load_balancer | bool }}\""},{"line_number":19,"context_line":"        mode: \"tcp\""},{"line_number":20,"context_line":"        port: \"{{ database_port }}\""},{"line_number":21,"context_line":"        listen_port: \"{{ mariadb_port }}\""},{"line_number":22,"context_line":"        frontend_tcp_extra:"},{"line_number":23,"context_line":"          - \"option clitcpka\""},{"line_number":24,"context_line":"          - \"timeout client 3600s\""},{"line_number":25,"context_line":"        backend_tcp_extra:"},{"line_number":26,"context_line":"          - \"option srvtcpka\""},{"line_number":27,"context_line":"          - \"timeout server 3600s\""},{"line_number":28,"context_line":"          - \"{% if enable_mariadb_clustercheck | bool %}option httpchk{% endif %}\""},{"line_number":29,"context_line":"        custom_member_list: \"{{ internal_haproxy_members.split(\u0027;\u0027) }}\""},{"line_number":30,"context_line":"      mariadb_external_lb:"},{"line_number":31,"context_line":"        enabled: \"{{ enable_external_mariadb_load_balancer | bool }}\""},{"line_number":32,"context_line":"        mode: \"tcp\""},{"line_number":33,"context_line":"        port: \"{{ database_port }}\""},{"line_number":34,"context_line":"        listen_port: \"{{ mariadb_port }}\""},{"line_number":35,"context_line":"        frontend_tcp_extra:"},{"line_number":36,"context_line":"          - \"option clitcpka\""},{"line_number":37,"context_line":"          - \"timeout client 3600s\""},{"line_number":38,"context_line":"        backend_tcp_extra:"},{"line_number":39,"context_line":"          - \"option srvtcpka\""},{"line_number":40,"context_line":"          - \"timeout server 3600s\""},{"line_number":41,"context_line":"        custom_member_list: \"{{ external_haproxy_members.split(\u0027;\u0027) }}\""},{"line_number":42,"context_line":"  mariadb-clustercheck:"},{"line_number":43,"context_line":"    container_name: mariadb_clustercheck"},{"line_number":44,"context_line":"    group: \"{{ mariadb_shard_group }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ae58cad7_b647a31e","line":41,"range":{"start_line":16,"start_character":1,"end_line":41,"end_character":71},"in_reply_to":"2c0948b7_60197dd1","updated":"2024-09-14 08:33:20.000000000","message":"This doesn\u0027t mean that anything is enabled in haproxy. It\u0027s just dict from defaults - not applied anywhere.","commit_id":"aede25ce242a3456a7b8c7b04795e34e0c3fa71d"}],"releasenotes/notes/switch-to-proxysql-907c2bc2f2c04de4.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f3f37dfdb55fabfb76061bbbf6afe53483b43fdd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e96ca3fe_246e3e78","line":5,"updated":"2024-03-20 05:30:25.000000000","message":"needs an upgrade section as well to warn users that default is changing and if they wish to continue to use clustercheck - they should set this var to this value.","commit_id":"5d0097578755ec24148a6842522e66743816b83c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"061ecebdac3578e8e4b8481237554fa4ba0fe400","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"633e609d_ae8cf273","line":5,"in_reply_to":"e96ca3fe_246e3e78","updated":"2024-06-27 16:48:30.000000000","message":"Acknowledged","commit_id":"5d0097578755ec24148a6842522e66743816b83c"}]}