)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d6c5cb2f3bcf6000b91f01092c07c26c27635a5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bc27d86c_9c1b057a","updated":"2024-03-21 13:34:48.000000000","message":"Needs testing","commit_id":"15c3a8ad11722d9b9b93c2625db7c72b72d13528"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ca686b7a00ee431d82df4feca9e610594ffb5412","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"36eb3056_47a6b4df","updated":"2024-05-16 10:22:57.000000000","message":"Tested and working.","commit_id":"15c3a8ad11722d9b9b93c2625db7c72b72d13528"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"bcdf236315cc3edbb507a5729a1d632bce30e3a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e29cc6df_415fec05","updated":"2024-05-18 08:31:11.000000000","message":"Recheck","commit_id":"667d153ef1668f48566f3ed7e2846649b36dea5e"}],"ansible/roles/mariadb/tasks/backup.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"63fcd4584cf27745fbfd3be3f982074178bc61e8","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    # NOTE(mgoddard): Try to use the same image as the MariaDB server container"},{"line_number":19,"context_line":"    # to avoid compatibility issues. See"},{"line_number":20,"context_line":"    # https://bugs.launchpad.net/kolla-ansible/+bug/2058644."},{"line_number":21,"context_line":"    image: \"{{ container_facts.mariadb.Image | default(mariadb_services.mariadb.image) }}\""},{"line_number":22,"context_line":"    name: \"mariabackup\""},{"line_number":23,"context_line":"    restart_policy: oneshot"},{"line_number":24,"context_line":"    remove_on_exit: True"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0501b817_f09ff0e9","line":21,"range":{"start_line":21,"start_character":47,"end_line":21,"end_character":86},"updated":"2024-05-18 09:25:16.000000000","message":"imho this not needed, ``container_facts`` will be always exist due to previous task.\nmaybe the good idea to give an operator choose the container?\n\n``image: \"{{ mariabackup_image_full | default(container_facts.mariadb.Image }}\"``\n\nand comment out (not remove) ``mariabackup_image_full`` variable? for backward compatibility too?","commit_id":"667d153ef1668f48566f3ed7e2846649b36dea5e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e7521e8fcdaa527ae6000fada9845d04230d89e4","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    # NOTE(mgoddard): Try to use the same image as the MariaDB server container"},{"line_number":19,"context_line":"    # to avoid compatibility issues. See"},{"line_number":20,"context_line":"    # https://bugs.launchpad.net/kolla-ansible/+bug/2058644."},{"line_number":21,"context_line":"    image: \"{{ container_facts.mariadb.Image | default(mariadb_services.mariadb.image) }}\""},{"line_number":22,"context_line":"    name: \"mariabackup\""},{"line_number":23,"context_line":"    restart_policy: oneshot"},{"line_number":24,"context_line":"    remove_on_exit: True"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"317058d0_ca15dc0a","line":21,"range":{"start_line":21,"start_character":47,"end_line":21,"end_character":86},"in_reply_to":"0501b817_f09ff0e9","updated":"2024-05-20 09:55:23.000000000","message":"I don\u0027t think mariabackup requires the mariadb service to be running, so there might not be an image to inspect.","commit_id":"667d153ef1668f48566f3ed7e2846649b36dea5e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"982ba21b2a6108bc5390da0b8e0ed0a68a6a20c2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    # NOTE(mgoddard): Try to use the same image as the MariaDB server container"},{"line_number":19,"context_line":"    # to avoid compatibility issues. See"},{"line_number":20,"context_line":"    # https://bugs.launchpad.net/kolla-ansible/+bug/2058644."},{"line_number":21,"context_line":"    image: \"{{ container_facts.mariadb.Image | default(mariadb_services.mariadb.image) }}\""},{"line_number":22,"context_line":"    name: \"mariabackup\""},{"line_number":23,"context_line":"    restart_policy: oneshot"},{"line_number":24,"context_line":"    remove_on_exit: True"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6a88bd76_217bbf12","line":21,"range":{"start_line":21,"start_character":47,"end_line":21,"end_character":86},"in_reply_to":"317058d0_ca15dc0a","updated":"2024-05-20 10:06:34.000000000","message":"Acknowledged","commit_id":"667d153ef1668f48566f3ed7e2846649b36dea5e"}]}
