)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"fc9f3cac6dcd14f6f815505b8cba9369b1e60066","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"234e26a5_f2e7ba16","updated":"2024-06-13 11:19:31.000000000","message":"@gael.therond@bitswalk.com Should we open a bug for that and confirm it\u0027s reproducible?","commit_id":"33d03a4267c9c64d774e1cf90c402326ac2de6d1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4f14b18ef55f124773c9abb5a1ab13d3204f9c7a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"87e4c3e8_8c4546ac","updated":"2024-06-19 13:20:00.000000000","message":"Before we merge another patch that might break something else - can we add test coverage for this feature?","commit_id":"33d03a4267c9c64d774e1cf90c402326ac2de6d1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"595d80e82839506e0b44d8b41a0379aaf67b6aa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e48ef76_fff5cd87","updated":"2024-06-19 13:20:13.000000000","message":"for posterity","commit_id":"33d03a4267c9c64d774e1cf90c402326ac2de6d1"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6169666372592e155b7bd2d6cb01fedf863de0e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d39be854_4a5e769a","updated":"2024-06-19 13:46:21.000000000","message":"how","commit_id":"33d03a4267c9c64d774e1cf90c402326ac2de6d1"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"555ed8d78f84503ee28fea02324122706bc942c4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5776837e_d0aa2827","updated":"2024-06-05 07:55:05.000000000","message":"interesting, In one env I\u0027m using recent antelope and have federation enabled, and it is templating backend field properly:\n\nbackend keystone_external_back\n    mode http\n    balance source","commit_id":"33d03a4267c9c64d774e1cf90c402326ac2de6d1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"69cb512a443a379608f0718149080b59fbfbd3b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8a184a9f_74d63bb2","updated":"2024-04-03 12:31:22.000000000","message":"recheck kolla-ansible-debian failed during deploy.sh with error in fluentd fixed by https://review.opendev.org/c/openstack/kolla-ansible/+/913868","commit_id":"33d03a4267c9c64d774e1cf90c402326ac2de6d1"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d1904f3ef87c3de1ab945ab942c370a7565a63b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d35da847_1b134c5a","updated":"2024-06-19 13:47:03.000000000","message":"unsure how it can be tested","commit_id":"33d03a4267c9c64d774e1cf90c402326ac2de6d1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0f7a5a03ad4d63371e84c599be19ede5c4a523d4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d9edf958_5ff8d8f7","in_reply_to":"0bfcc4be_eafc4927","updated":"2024-06-26 13:18:12.000000000","message":"I meant testing any federation - can\u0027t we setup some mini oidc server in a CI job and federate with that?","commit_id":"33d03a4267c9c64d774e1cf90c402326ac2de6d1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a2d2f27633e2bf1038bd6b257caa4f79a6bc6755","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"285a9bdf_c7ac5c61","in_reply_to":"234e26a5_f2e7ba16","updated":"2024-06-17 14:45:30.000000000","message":"I don\u0027t understand, what other bugreport than https://launchpad.net/bugs/2058656 do you want?","commit_id":"33d03a4267c9c64d774e1cf90c402326ac2de6d1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a2518fb4c2374ec485a9c8898767e08e58d21506","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"35f62de5_0304082d","in_reply_to":"285a9bdf_c7ac5c61","updated":"2024-06-26 15:06:11.000000000","message":"marking as resolved as there was no reply within 9 days and there is a bugreport already present and I don\u0027t know what other bugreport should be missing.\n\nfeel free to reopen the conversation if you know what bugreport exactly is missing here.","commit_id":"33d03a4267c9c64d774e1cf90c402326ac2de6d1"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"09b4b5ad3c2fd755c0aae8cfe5d7468eab790635","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5c82935f_e65019ed","in_reply_to":"5776837e_d0aa2827","updated":"2024-06-10 11:09:04.000000000","message":"Indeed, I was working on Zed release, but used the master branch to test it wasn\u0027t just a zed thing, I\u0027ll need to check if it is still not working.","commit_id":"33d03a4267c9c64d774e1cf90c402326ac2de6d1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"04a46be7f42368bebc1dfb84917fabf619b488e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"03ba8ca6_be626df2","in_reply_to":"5c82935f_e65019ed","updated":"2024-07-24 13:46:55.000000000","message":"Done","commit_id":"33d03a4267c9c64d774e1cf90c402326ac2de6d1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f2427b6fc4fe0b0c5eeae78fa525dd500d899e66","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0bfcc4be_eafc4927","in_reply_to":"87e4c3e8_8c4546ac","updated":"2024-06-19 17:11:03.000000000","message":"Can you elaborate how this might break something else? You mean another keystone backend? I\u0027m not sure I understand what exactly could break here.\n\nWhen I search our tests for keystone we only explicitly test if the old keystone admin endpoint is removed, that\u0027s it.\n\nSome things are tested via our integration tests of course, like services using keystone service tokens, but these are all not dedicated keystone tests.\n\nSo we don\u0027t have any specific tests for any specific keystone backend or functionality, at least I was not able to find any.\n\nMy point is: it\u0027s a really good idea to add regression tests or more tests in general. \n\nBut from my point of view we don\u0027t seem to enforce this for any patches in any particular area, most merged fixes I see don\u0027t add any tests at all, my own included.\n\nSo I wonder why you suddenly demand tests being added for this particular bugfix, when this is not demanded for other bugfixes, even if these other patches are also in niche areas we don\u0027t test (like e.g. s3 keystone auth, which was broken for several releases).\n\nSo I really wish I would understand the reasoning a little bit more, so I can learn from it for my own reviews (both as a patch author and a reviewer).\n\nSo I would be very happy if someone could explain this to me, because I really don\u0027t understand it, thank you!","commit_id":"33d03a4267c9c64d774e1cf90c402326ac2de6d1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ef8017294a7e42cc04df7f20340057f5fa1c9a52","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e17fb53f_4348f1e4","in_reply_to":"8c902e0f_3613578e","updated":"2024-06-27 14:43:34.000000000","message":"the above patch is ready for review and detects broken haproxy configs, so at least we now have a syntax check. reviews welcome.","commit_id":"33d03a4267c9c64d774e1cf90c402326ac2de6d1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"90537f89bb19968a44ae26a2220573a990186ca1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8c902e0f_3613578e","in_reply_to":"d9edf958_5ff8d8f7","updated":"2024-06-26 15:41:54.000000000","message":"I\u0027m working on a patch so we at least validate the haproxy config:\n\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/922840","commit_id":"33d03a4267c9c64d774e1cf90c402326ac2de6d1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"04a46be7f42368bebc1dfb84917fabf619b488e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de00f73a_74707910","in_reply_to":"e17fb53f_4348f1e4","updated":"2024-07-24 13:46:55.000000000","message":"Done","commit_id":"33d03a4267c9c64d774e1cf90c402326ac2de6d1"}]}