)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"908baf6427da7e327fec1cf134ab2bb0b9d77f5e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Arbet \u003cmichal.arbet@ultimum.io\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-07-15 16:58:39 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[CI] Fix swift disk preparation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes the preparation of disks"},{"line_number":10,"context_line":"for Swift and also adds some useful debug"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":47,"id":"c30bd471_5c1f3ef3","line":7,"updated":"2024-07-15 15:02:03.000000000","message":"it\u0027s not swift only change","commit_id":"1b9d28aad1ef6fd251284fafdd24321393095813"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0385d20ddb844e2d1f0b3cabf6412cefafa06c50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"dbe2704f_f30f8eaf","updated":"2024-03-22 17:06:55.000000000","message":"recheck image repository timeouting","commit_id":"59e5a319c40439aa608725c1633833c6b2c37899"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"540106e3651ae287f0cb70d572bdc2e53961b1f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"22b07d22_6128a2c3","updated":"2024-03-22 18:12:41.000000000","message":"recheck redhat quay outage","commit_id":"59e5a319c40439aa608725c1633833c6b2c37899"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0ccdcb12f6c6685f614f35ee11640d31c20b6ad2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"f52db908_1ffa1e2d","updated":"2024-06-03 13:20:53.000000000","message":"recheck for fresh results","commit_id":"e401e9f529b31368801944b2b46592d08e1ef47b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2c2a36126259c5c438fb32dbc3b899b42465a3b6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":47,"id":"90abd142_7f6872d8","updated":"2024-07-15 15:02:53.000000000","message":"In addition to that - adding debug should be one patch (refactoring), fixing anything should be separate - now we have no clue what is really changing, because the whole file is changing...","commit_id":"1b9d28aad1ef6fd251284fafdd24321393095813"}],"tests/setup_disks.sh":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9e7c5b66e752983f505f3142a12e33403ead4380","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    if [[ \"${scenario}\" \u003d\u003d \"zun\" ]]; then"},{"line_number":15,"context_line":"        # create cinder-volumes volume group for cinder lvm backend"},{"line_number":16,"context_line":"        free_device\u003d$(losetup -f)"},{"line_number":17,"context_line":"        fallocate -l 5G /var/lib/cinder_data.img"},{"line_number":18,"context_line":"        losetup ${free_device} /var/lib/cinder_data.img"},{"line_number":19,"context_line":"        pvcreate ${free_device}"}],"source_content_type":"text/x-sh","patch_set":27,"id":"8e4246fb_2791d92a","line":16,"range":{"start_line":16,"start_character":22,"end_line":16,"end_character":32},"updated":"2024-04-02 09:54:41.000000000","message":"nit: `losetup --find` would be easier to understand - I wasn\u0027t familiar with the tool at all, thanks for introducing me to it!","commit_id":"cec369a90efa4be350b7599a581d17a265c9428d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9e7c5b66e752983f505f3142a12e33403ead4380","unresolved":true,"context_lines":[{"line_number":36,"context_line":"                sleep 60"},{"line_number":37,"context_line":"            else"},{"line_number":38,"context_line":"                lsblk ${free_device}"},{"line_number":39,"context_line":"                parted ${free_device} print || echo \"parted not available\""},{"line_number":40,"context_line":"                free_partition\u003d$(blkid | grep \"${free_device}\" | grep KOLLA_SWIFT_DATA | awk -F \u0027:\u0027 \u0027{print $1}\u0027)"},{"line_number":41,"context_line":"                break"},{"line_number":42,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":27,"id":"d2752129_6ac246f3","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":2},"updated":"2024-04-02 09:54:41.000000000","message":"you already call parted before this in line 31, so either the parted check should be moved up there if it is necessary at all, or be removed entirely.\n\nif you don\u0027t want to check for the parted program to be available but something else (e.g. parted return code indicating an error in the actual command or response) the error message should be adjusted. if it is an error message it would also be good to prepend it with \"error:\" or something like that.\n\nalso: should the script exit if parted is not available, or an error is returned?","commit_id":"cec369a90efa4be350b7599a581d17a265c9428d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9e7c5b66e752983f505f3142a12e33403ead4380","unresolved":true,"context_lines":[{"line_number":42,"context_line":"            fi"},{"line_number":43,"context_line":"        done"},{"line_number":44,"context_line":"        if [[ ${result} -ne 0 ]]; then"},{"line_number":45,"context_line":"            echo \"parted ${free_device} -s -- mklabel gpt mkpart KOLLA_SWIFT_DATA 1 -1   \u003c\u003c FAILED\""},{"line_number":46,"context_line":"            exit 1"},{"line_number":47,"context_line":"        fi"},{"line_number":48,"context_line":"        set -o errexit"}],"source_content_type":"text/x-sh","patch_set":27,"id":"f4cdf85c_a22479c6","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":2},"updated":"2024-04-02 09:54:41.000000000","message":"as above mentioned: maybe prepend an \"error:\" status to this string?","commit_id":"cec369a90efa4be350b7599a581d17a265c9428d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9e7c5b66e752983f505f3142a12e33403ead4380","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    prepare_disks_logged ${scenario} \u003e ${log_file} 2\u003e\u00261"},{"line_number":78,"context_line":"    result\u003d$?"},{"line_number":79,"context_line":"    if [[ ${result} -ne 0 ]]; then"},{"line_number":80,"context_line":"        echo \"Preparing disks for Openstack failed. See ansible/prepare-disks for details\""},{"line_number":81,"context_line":"    else"},{"line_number":82,"context_line":"        echo \"Successfully prepared disks for OpenStack. See ansible/prepare-disks for details\""},{"line_number":83,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":27,"id":"089204a0_431a9689","line":80,"range":{"start_line":80,"start_character":56,"end_line":80,"end_character":77},"updated":"2024-04-02 09:54:41.000000000","message":"```\necho \"error: Preparing disks for Openstack failed. See ${log_file} for details\"\n```\n\nthis has the nice property of outputting the actual logfile being used (e.g. with the \"-upgrade\" suffix.)","commit_id":"cec369a90efa4be350b7599a581d17a265c9428d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9e7c5b66e752983f505f3142a12e33403ead4380","unresolved":true,"context_lines":[{"line_number":79,"context_line":"    if [[ ${result} -ne 0 ]]; then"},{"line_number":80,"context_line":"        echo \"Preparing disks for Openstack failed. See ansible/prepare-disks for details\""},{"line_number":81,"context_line":"    else"},{"line_number":82,"context_line":"        echo \"Successfully prepared disks for OpenStack. See ansible/prepare-disks for details\""},{"line_number":83,"context_line":"    fi"},{"line_number":84,"context_line":"    return ${result}"},{"line_number":85,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":27,"id":"83c8de03_9bd668f9","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":2},"updated":"2024-04-02 09:54:41.000000000","message":"see above, use the $log_file var here as well. also use \"info: \" as a prefix please.","commit_id":"cec369a90efa4be350b7599a581d17a265c9428d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a5d4d1ed2e2190c211309e980a6a4ceb00388097","unresolved":true,"context_lines":[{"line_number":29,"context_line":"            fi"},{"line_number":30,"context_line":"            losetup -P ${free_device} /var/lib/swift_data.img"},{"line_number":31,"context_line":"            parted ${free_device} -s -- mklabel gpt mkpart KOLLA_SWIFT_DATA 1 -1"},{"line_number":32,"context_line":"            result\u003d$?"},{"line_number":33,"context_line":"            if [[ ${result} -ne 0 ]]; then"},{"line_number":34,"context_line":"                lsblk ${free_device}"},{"line_number":35,"context_line":"                losetup -d ${free_device}"}],"source_content_type":"text/x-sh","patch_set":28,"id":"dc5a60e4_4581f3fb","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":2},"updated":"2024-06-18 12:48:26.000000000","message":"you should not use an intermediate variable to check return codes of commands, see e.g. for a list of reasons why you should not do this:\n\nhttps://www.shellcheck.net/wiki/SC2181","commit_id":"e401e9f529b31368801944b2b46592d08e1ef47b"}]}