)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6752200c1708685a9b93ef9f59132306a0a4a358","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Also enable these after an upgrade."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partial-Fix: #2058512"},{"line_number":12,"context_line":"Change-Id: Ib9bdae2e25c2b6cce30e4c8024015ab5875bc1ff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"52af3e46_5deb2fa9","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":11},"updated":"2024-05-13 09:38:09.000000000","message":"nit: use \"Partial-Bug:\" instead, see: https://docs.openstack.org/contributors/common/git.html#footers","commit_id":"77992d8542de3968c15c0533fc69cafa48d3bcb0"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"e2d520612218c16f08d70d51cf1fdbf3875b3835","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Also enable these after an upgrade."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partial-Fix: #2058512"},{"line_number":12,"context_line":"Change-Id: Ib9bdae2e25c2b6cce30e4c8024015ab5875bc1ff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"cfd4c007_34869837","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":11},"in_reply_to":"52af3e46_5deb2fa9","updated":"2024-05-13 12:26:58.000000000","message":"Done","commit_id":"77992d8542de3968c15c0533fc69cafa48d3bcb0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2d03c793b885b54b3464585c33b6f6560f44c519","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"34970e96_5deb2b0d","updated":"2024-05-10 11:16:20.000000000","message":"reno is absent","commit_id":"b13964aecb33a68c0fc9939a8c720989bb7f958b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3bbe9a0664fc8772aa4897922f38d006f9128e7a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ea8b5795_5e837f98","updated":"2024-05-17 11:19:42.000000000","message":"LGTM but needs investigation if we do not regress on supported feature flags when we backport this.","commit_id":"223556e4e2efe35c77c4607408d47e67577a68f1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d043bfaf925a4a383f16c541115133ac2c9273d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c59c7a47_ac34da10","updated":"2024-05-16 07:50:56.000000000","message":"Would this be an issue in case someone needs to revert an update because of some bug?","commit_id":"223556e4e2efe35c77c4607408d47e67577a68f1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3e3422664a89b0c33df440dc8fe3afaa590f75ec","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f9f7c30e_b9e33f32","updated":"2024-05-17 11:07:28.000000000","message":"as this has \"Backport-Candidate +1\" Did you check if all the previously enabled flags where also part of the stable feature flags in past releases?","commit_id":"223556e4e2efe35c77c4607408d47e67577a68f1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bf633d5795f31b5feea6fbd16d3b79d917becc46","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e4a9c845_b41e7836","in_reply_to":"c59c7a47_ac34da10","updated":"2024-05-16 09:25:11.000000000","message":"Basically \u0027all\u0027 enables all stable feature flags, so even if you revert an update of RMQ - that shouldn\u0027t break anything.\nThere is a PR in https://github.com/ansible-collections/community.rabbitmq/pull/170 - so after that lands we can do that properly in Ansible instead of using command.","commit_id":"223556e4e2efe35c77c4607408d47e67577a68f1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"250a66ee212909ad5a9b46166945f294c915a673","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"347b2b7a_92c03ad2","in_reply_to":"e4a9c845_b41e7836","updated":"2024-06-11 09:42:22.000000000","message":"Acknowledged","commit_id":"223556e4e2efe35c77c4607408d47e67577a68f1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"797c52eb0bbf5b1f76df293625a9c2d2868628dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"815f465c_ede48759","in_reply_to":"ea8b5795_5e837f98","updated":"2024-05-27 15:45:27.000000000","message":"Seems Matt has looked this up, thanks Matt!","commit_id":"223556e4e2efe35c77c4607408d47e67577a68f1"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"531fa5d29b1c3c20eaec130953e5428c09d28fb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4d969620_04fdab0f","in_reply_to":"f9f7c30e_b9e33f32","updated":"2024-05-20 08:23:55.000000000","message":"That\u0027s a good point. Thankfully we have only ever enabled the stable flags for each release.","commit_id":"223556e4e2efe35c77c4607408d47e67577a68f1"}],"ansible/roles/rabbitmq/defaults/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"09457aa4e878fa4c7306390b1a07251d13d9c9f4","unresolved":true,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"rabbitmq_enabled_plugins: \"{{ rabbitmq_plugins | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# Each version should match the feature flags listed as stable here:"},{"line_number":124,"context_line":"# https://www.rabbitmq.com/docs/feature-flags#core-feature-flags"},{"line_number":125,"context_line":"rabbitmq_feature_flags:"},{"line_number":126,"context_line":"  supported_3_11:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"107cbc2e_9e23b3f9","line":123,"updated":"2024-03-27 19:24:11.000000000","message":"According to RMQ docs - we could just switch to \"all\" - have you tried?","commit_id":"a8013108ff002e4aa924eb771189aff23842027c"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"781a556f259231e8f669e55ee32025886d2f3d05","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"rabbitmq_enabled_plugins: \"{{ rabbitmq_plugins | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# Each version should match the feature flags listed as stable here:"},{"line_number":124,"context_line":"# https://www.rabbitmq.com/docs/feature-flags#core-feature-flags"},{"line_number":125,"context_line":"rabbitmq_feature_flags:"},{"line_number":126,"context_line":"  supported_3_11:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f1d1acff_374b7af5","line":123,"in_reply_to":"107cbc2e_9e23b3f9","updated":"2024-04-26 15:27:00.000000000","message":"I\u0027ve tried this. Annoyingly the ansible module doesn\u0027t support this, it returns the error ``\"all feature flag is not available\"``. But it does work if we call the command directly, so I\u0027ve proposed this instead.","commit_id":"a8013108ff002e4aa924eb771189aff23842027c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2d03c793b885b54b3464585c33b6f6560f44c519","unresolved":true,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"rabbitmq_enabled_plugins: \"{{ rabbitmq_plugins | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"rabbitmq_feature_flags:"},{"line_number":101,"context_line":"  - \"quorum_queue\""},{"line_number":102,"context_line":"  - \"implicit_default_bindings\""},{"line_number":103,"context_line":"  - \"virtual_host_metadata\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"23284d75_16458f2d","side":"PARENT","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":22},"updated":"2024-05-10 11:16:20.000000000","message":"this should be mentioned in reno","commit_id":"55cdf7905d23a91a2fe0655e0d54add7a121a159"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"bf7f4232d7ca6c2146dae5b2633c26740f568011","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"rabbitmq_enabled_plugins: \"{{ rabbitmq_plugins | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"rabbitmq_feature_flags:"},{"line_number":101,"context_line":"  - \"quorum_queue\""},{"line_number":102,"context_line":"  - \"implicit_default_bindings\""},{"line_number":103,"context_line":"  - \"virtual_host_metadata\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"70c36345_110ca20d","side":"PARENT","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":22},"in_reply_to":"23284d75_16458f2d","updated":"2024-05-13 09:29:54.000000000","message":"Done","commit_id":"55cdf7905d23a91a2fe0655e0d54add7a121a159"}],"ansible/roles/rabbitmq/tasks/feature-flags.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2d03c793b885b54b3464585c33b6f6560f44c519","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Enable all stable feature flags"},{"line_number":3,"context_line":"  command: \"{{ kolla_container_engine }} exec rabbitmq rabbitmqctl enable_feature_flag all\""},{"line_number":4,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b22cd9b5_0ab3e765","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":9},"updated":"2024-05-10 11:16:20.000000000","message":"not sure why we should use not idempotent change. why not use kolla_toolbox?","commit_id":"b13964aecb33a68c0fc9939a8c720989bb7f958b"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"5d8d45dc625603124f0879d35c2fbd34b3ace18a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Enable all stable feature flags"},{"line_number":3,"context_line":"  command: \"{{ kolla_container_engine }} exec rabbitmq rabbitmqctl enable_feature_flag all\""},{"line_number":4,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e4f52129_4e6bb5a9","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":9},"in_reply_to":"b22cd9b5_0ab3e765","updated":"2024-05-10 15:22:48.000000000","message":"Annoyingly the ansible module doesn\u0027t support this, it returns the error ``\"all feature flag is not available\"``. But it does work if we call the command directly, so I\u0027ve proposed this instead.","commit_id":"b13964aecb33a68c0fc9939a8c720989bb7f958b"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"bf7f4232d7ca6c2146dae5b2633c26740f568011","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Enable all stable feature flags"},{"line_number":3,"context_line":"  command: \"{{ kolla_container_engine }} exec rabbitmq rabbitmqctl enable_feature_flag all\""},{"line_number":4,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ec64cee6_5db1ba05","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":9},"in_reply_to":"d25d9fad_a6558217","updated":"2024-05-13 09:29:54.000000000","message":"Done","commit_id":"b13964aecb33a68c0fc9939a8c720989bb7f958b"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ab10a1d9579c641685fcffa907e53b793023e790","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Enable all stable feature flags"},{"line_number":3,"context_line":"  command: \"{{ kolla_container_engine }} exec rabbitmq rabbitmqctl enable_feature_flag all\""},{"line_number":4,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d25d9fad_a6558217","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":9},"in_reply_to":"e4f52129_4e6bb5a9","updated":"2024-05-10 20:55:39.000000000","message":"ok then You just need add \u0027changed_when: false\u0027 to be idempotent.","commit_id":"b13964aecb33a68c0fc9939a8c720989bb7f958b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"381ef64e84ec11f5e1d220f9174a87474ab5b9c1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Enable all stable feature flags"},{"line_number":3,"context_line":"  command: \"{{ kolla_container_engine }} exec rabbitmq rabbitmqctl enable_feature_flag all\""},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"75c46914_5a969869","line":3,"updated":"2024-05-13 14:50:22.000000000","message":"Previously we did that in kolla_toolbox, but I guess it\u0027s fine to switch to rabbitmq container.","commit_id":"223556e4e2efe35c77c4607408d47e67577a68f1"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"64938f4ce72d99f1f4b7debce4188c9af0bdc4e8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Enable all stable feature flags"},{"line_number":3,"context_line":"  command: \"{{ kolla_container_engine }} exec rabbitmq rabbitmqctl enable_feature_flag all\""},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8512b98e_cc0b5328","line":3,"in_reply_to":"75c46914_5a969869","updated":"2024-05-14 09:34:46.000000000","message":"Seems more expected to me to call ``rabbitmqctl`` directly from a rabbitmq container, we already do this elsewhere.","commit_id":"223556e4e2efe35c77c4607408d47e67577a68f1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ef960f6956be1b996b4f92178ae19c6c56eef830","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Enable all stable feature flags"},{"line_number":3,"context_line":"  command: \"{{ kolla_container_engine }} exec rabbitmq rabbitmqctl enable_feature_flag all\""},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b138bef1_612a5f93","line":3,"in_reply_to":"8512b98e_cc0b5328","updated":"2024-05-16 07:44:06.000000000","message":"Acknowledged","commit_id":"223556e4e2efe35c77c4607408d47e67577a68f1"}],"releasenotes/notes/rabbitmq-enable-all-feature-flags-at-once-28b76958abf54083.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6752200c1708685a9b93ef9f59132306a0a4a358","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    All stable RabbitMQ feature flags are now enabled during deployments,"},{"line_number":5,"context_line":"    reconfigures, and upgrades. As such, the variable"},{"line_number":6,"context_line":"    ``rabbitmq_feature_flags`` is no longer required. This is a partial fix to"},{"line_number":7,"context_line":"    RabbitMQ SLURP support. "},{"line_number":8,"context_line":"    `LP#2049512 \u003chttps://launchpad.net/bugs/2058512\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a5644ebf_b3b448bb","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":28},"updated":"2024-05-13 09:38:09.000000000","message":"nit: whitespace","commit_id":"77992d8542de3968c15c0533fc69cafa48d3bcb0"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"e2d520612218c16f08d70d51cf1fdbf3875b3835","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    All stable RabbitMQ feature flags are now enabled during deployments,"},{"line_number":5,"context_line":"    reconfigures, and upgrades. As such, the variable"},{"line_number":6,"context_line":"    ``rabbitmq_feature_flags`` is no longer required. This is a partial fix to"},{"line_number":7,"context_line":"    RabbitMQ SLURP support. "},{"line_number":8,"context_line":"    `LP#2049512 \u003chttps://launchpad.net/bugs/2058512\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d1e53c56_50bf8877","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":28},"in_reply_to":"a5644ebf_b3b448bb","updated":"2024-05-13 12:26:58.000000000","message":"Done","commit_id":"77992d8542de3968c15c0533fc69cafa48d3bcb0"}]}