)]}'
{"tox.ini":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"92070d519e42d13f9a074fec988d53438cba5af3","unresolved":true,"context_lines":[{"line_number":161,"context_line":"commands \u003d yamllint -s ."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"# mypy is a static type checker for Python"},{"line_number":164,"context_line":"[testenv:mypy]"},{"line_number":165,"context_line":"deps \u003d {[testenv:linters]deps}"},{"line_number":166,"context_line":"commands \u003d"},{"line_number":167,"context_line":"  mypy --install-types --non-interactive"}],"source_content_type":"text/x-properties","patch_set":3,"id":"3ed28e68_1c0303d0","line":164,"updated":"2024-04-03 17:54:17.000000000","message":"Since this is a new testenv target you either need to add a new job that runs this testenv or modify an existing job to run this target as well.\n\nIn this case you may want to make the job non voting to start (or not if you want to enforce rules). If that is the case I would add a new job so that it can be nonvoting and scoped only to mypy. But if you do want it voting then adding it as a step to the linters job may make sense.","commit_id":"b5f023ee2411c5e4061d606fa708ddd111726e88"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9329e7cc53709910f95cf60f50ddee32f05b7095","unresolved":true,"context_lines":[{"line_number":161,"context_line":"commands \u003d yamllint -s ."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"# mypy is a static type checker for Python"},{"line_number":164,"context_line":"[testenv:mypy]"},{"line_number":165,"context_line":"deps \u003d {[testenv:linters]deps}"},{"line_number":166,"context_line":"commands \u003d"},{"line_number":167,"context_line":"  mypy --install-types --non-interactive"}],"source_content_type":"text/x-properties","patch_set":3,"id":"153438f3_a3a4c622","line":164,"in_reply_to":"1658ff6f_59036c67","updated":"2024-04-04 10:07:09.000000000","message":"okay, the upstream does the per branch stuff obviously in https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/zuul.d/project-templates.yaml\n\nwhich seems a little split to me, but anyway.\n\n:edit: I guess I have the history now correct. so in the past gating branches per job where defined in jobs.yaml:\n\nhttps://zuul.opendev.org/t/openstack/build/ff2c6b9780ed4a19895905d3e710230e\n\nbut nowadays this seems to be done in the project-templates:\n\nhttps://review.opendev.org/c/openstack/openstack-zuul-jobs/+/913710\n\nI think this should be cleaned up, as far as I understand it at least. I posted as much in the #opendev IRC channel.\n\nanyway this is mostly off topic for this change.","commit_id":"b5f023ee2411c5e4061d606fa708ddd111726e88"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"eaa2ad72a5eb7a7e339d85871beba2a16c747c14","unresolved":true,"context_lines":[{"line_number":161,"context_line":"commands \u003d yamllint -s ."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"# mypy is a static type checker for Python"},{"line_number":164,"context_line":"[testenv:mypy]"},{"line_number":165,"context_line":"deps \u003d {[testenv:linters]deps}"},{"line_number":166,"context_line":"commands \u003d"},{"line_number":167,"context_line":"  mypy --install-types --non-interactive"}],"source_content_type":"text/x-properties","patch_set":3,"id":"1658ff6f_59036c67","line":164,"in_reply_to":"3ed28e68_1c0303d0","updated":"2024-04-04 09:44:58.000000000","message":"I just added it to the linting job for now, as it seems easiest to test. At first I looked into adding a new job, but for smoke testing I didn\u0027t want to introduce that just now.\n\nLooking at https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/zuul.d/jobs.yaml some jobs seem rather old, and I\u0027m not sure which one follow best practices or are really current.\n\nMany linter jobs don\u0027t run against recent released branches it seems and there are even jobs for python27 (which don\u0027t seem to run, according to zuul build history at least).\n\nBut I agree, in the long run it\u0027s probably worth it to start splitting this out into it\u0027s own non-voting job. Thanks for the hints.","commit_id":"b5f023ee2411c5e4061d606fa708ddd111726e88"}]}