)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"20b860ffb5943799d0297f4a743592d56f1b8674","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Most roles are not leveraging the jinja filters available."},{"line_number":10,"context_line":"According to [1] filtering the list of services makes the execution"},{"line_number":11,"context_line":"faster than skipping the tasks."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] - https://github.com/stackhpc/ansible-scaling/blob/master/doc/skip.md"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"96d8a50a_72e2e8c9","line":11,"updated":"2024-04-17 13:29:46.000000000","message":"Do we know how much faster?","commit_id":"aa277a59fc72d198562d9cdc02124f5fa5805984"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2072bed51719a6d698dcfd752090b8273edddecc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Most roles are not leveraging the jinja filters available."},{"line_number":10,"context_line":"According to [1] filtering the list of services makes the execution"},{"line_number":11,"context_line":"faster than skipping the tasks."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] - https://github.com/stackhpc/ansible-scaling/blob/master/doc/skip.md"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9175b08a_b96c938f","line":11,"in_reply_to":"96d8a50a_72e2e8c9","updated":"2024-05-03 08:02:27.000000000","message":"Adressed in next comment.","commit_id":"aa277a59fc72d198562d9cdc02124f5fa5805984"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"ed86e819213fbe49973c45ac030409ea7585ce13","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8d55ed2d_a6c73b11","updated":"2024-04-05 08:13:41.000000000","message":"Looks like theres a problem with opensearch rn.\n\n$ curl -i --user opensearch:password \u003cVIP\u003e:5601/api/status\nHTTP/1.1 401 Unauthorized\nosd-name: optim-control-uuzyndguhg5w\ncontent-type: application/json; charset\u003dutf-8\ncache-control: private, no-cache, no-store, must-revalidate\ncontent-length: 126\ndate: Fri, 05 Apr 2024 08:06:51 GMT\nkeep-alive: timeout\u003d120\n\n{\"statusCode\":401,\"error\":\"Unauthorized\",\"message\":\"no handler found for uri [/_plugins/_security/authinfo] and method [GET]\"}","commit_id":"ccd34c12ff651ad2dcfbddc00c87cb8cb2db1028"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"3ea7183dd20428ad142daf4c272171af3ab0ae5a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cadc107c_20567adc","in_reply_to":"8d55ed2d_a6c73b11","updated":"2024-04-05 14:36:30.000000000","message":"There was a bump a while ago from opensearch 2.12.0 -\u003e 2.13.0 and it looks it is failing because of that. Here is a bug report https://bugs.launchpad.net/kolla-ansible/+bug/2060306","commit_id":"ccd34c12ff651ad2dcfbddc00c87cb8cb2db1028"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2072bed51719a6d698dcfd752090b8273edddecc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c5e87e46_7086d5e5","in_reply_to":"cadc107c_20567adc","updated":"2024-05-03 08:02:27.000000000","message":"Done","commit_id":"ccd34c12ff651ad2dcfbddc00c87cb8cb2db1028"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4d3fa53e3f49c97c8609a623f0a8d38a9c03ad35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7b4bd86a_bce1ac3d","updated":"2024-04-17 13:29:14.000000000","message":"recheck (opensearch should be fine now)","commit_id":"aa277a59fc72d198562d9cdc02124f5fa5805984"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"701e9e3fbb272f692e9018cfd6747c57d31f91be","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c80bd0e0_4a8dba06","updated":"2024-04-17 13:33:45.000000000","message":"the performance numbers in the linked document look somewhat unconvincing to me.\n\nI don\u0027t doubt there might be performance benefits for this approach but imho you need to show the difference in a better way, if there is any. maybe run more iterations?\n\nalso account for stuff like cached data (e.g. drop vm_caches) which might influence the benchmark.","commit_id":"aa277a59fc72d198562d9cdc02124f5fa5805984"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bf551381267d815d1dab053546f21c96901b7f90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d926dae6_9dd1b103","in_reply_to":"40a833bb_c07c1b91","updated":"2024-05-14 08:48:29.000000000","message":"Done","commit_id":"aa277a59fc72d198562d9cdc02124f5fa5805984"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"33b2e6f36a33c0ad1e0746ec94f7a58f14653510","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"40a833bb_c07c1b91","in_reply_to":"5edcaaac_9a0c5d84","updated":"2024-04-29 15:25:03.000000000","message":"Wow, thanks for the thorough testing comment!\n\nIt might actually be worthwhile to extract this into our developer docs (e.g. in a section \"how to test performance improvements\").\n\nLooking at those numbers we see a percentage improvement across all tests of roughly 7-17% and more important: no regressions.\n\nso in general I think this is a worthwhile change to make, thanks for providing the numbers!\n\nI\u0027ll start reviewing the code itself now.","commit_id":"aa277a59fc72d198562d9cdc02124f5fa5805984"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"b91434da3cdc175ed57edfaac09dae5d2769f80b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b5a2ca30_793e0d9b","in_reply_to":"7fba1de2_b7eaa135","updated":"2024-07-03 09:06:00.000000000","message":"Done","commit_id":"aa277a59fc72d198562d9cdc02124f5fa5805984"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"3b5683f5f2e001deccbdb8818dd5d6ac81510c20","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5edcaaac_9a0c5d84","in_reply_to":"c80bd0e0_4a8dba06","updated":"2024-04-28 11:44:44.000000000","message":"After a lot of trial and error I belive I have reached some conclusion. \n\nThis change brings the most benefit to roles with big number of services which are enabled under a specific condition like neutron for example and makes difference with larger amount of machines. In case of neutron, it has specified 16 services, from which only 4 were enabled, so that means 12 skips per machine per tasks that is using it. Which comes down to 96 skips per machine just in neutron\u0027s config.yml\nI personally belive that even if the performance benefit is not significant for other roles, it cleans up the the code a little and makes it look more consistent.\n\nI\u0027ve tested generating config for tags neutron, and nova as other services showed te best improvement. My test setup were two VMs running in our OpenStack environment. One was designated as controller and the other as the compute node. \nI\u0027ve created \"dummy\" hosts by doing the following in the inventory file.\n\n```ini\n[control]\ncontrol-a-01 ansible_host\u003d172.30.10.65 node_config_directory\u003d/etc/kolla/co-a-01\ncontrol-a-02 ansible_host\u003d172.30.10.65 node_config_directory\u003d/etc/kolla/co-a-02\ncontrol-a-03 ansible_host\u003d172.30.10.65 node_config_directory\u003d/etc/kolla/co-a-03\n```\n\nI\u0027ve done the same to make in total 3 control hosts, 20 network hosts and 20 compute hosts. Between every run, I\u0027ve deleted /etc/kolla and rebooted the VMs and dropped vm_cache on the deployment host as well as temp folder and ansible temp foler (just to be sure). The deployment was done from one of the servers where OpenStack was running. I\u0027ve enabled only the core services in OpenStack and here is the environment and config I was working with.\n```shell\n$ cat /etc/ansible/ansible.cfg \n```\n```ini\n[defaults]\nhost_key_checking \u003d False\npipelining \u003d True\nforks \u003d 16\nstdout_callback \u003d yaml\ncallbacks_enabled \u003d profile_tasks,profile_roles,timer\ninject_facts_as_vars \u003d False\n[ssh_connection]\nssh_args \u003d -o ControlMaster\u003dauto -o ControlPersist\u003d60s\n```\n```shell\n$ ansible --version\n```\n```ini\nansible [core 2.16.6]\n  config file \u003d /etc/ansible/ansible.cfg\n  configured module search path \u003d [\u0027/home/oliver/.ansible/plugins/modules\u0027, \u0027/usr/share/ansible/plugins/modules\u0027]\n  ansible python module location \u003d /home/oliver/roman/.venv/lib/python3.10/site-packages/ansible\n  ansible collection location \u003d /home/oliver/.ansible/collections:/usr/share/ansible/collections\n  executable location \u003d /home/oliver/roman/.venv/bin/ansible\n  python version \u003d 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] (/home/oliver/roman/.venv/bin/python3)\n  jinja version \u003d 3.1.3\n  libyaml \u003d True\n```\n```shell\n$ kolla-ansible --version\n```\n```shell\n17.1.0\n```\n(I\u0027ve used latest master at commit fadb484185e969c0660149fc56bde2e5c5f7adc8 and my branch of the \"improved\" kolla-ansible)\n\nThis is the command I\u0027ve been using to run the tests and also measure the impact on CPU \n```shell\n$ perf stat kolla-ansible -i inventory.ini --configdir $(pwd)/etc -vv genconfig --tags\u003d!all,nova,haproxy\n```\n\n(haproxy must be included otherwise the genconfig would fail due to missing folders)\n\nI\u0027ve taken three metrics from the deployment and that was overall deployment time, time spent on the specific role and CPU usage (measured with perf)\nThe overall genconfig time went down from average 209s to 195s. \nThe time spent on the loadbalancer role went down from average 27s to 23s.\nThe time spent on the neutron role went down from average 102s to 95s.\nThe time spent on the nova-cell role went down from average 54s to 52s. (tested separately, nova role showed the seccond biggest improvement)\nAlso the average CPUs utilized reported by perf went down from 3.31 to 3.15.\nThis command was run multiple times to make sure the resulting numbers are not influenced by other factors such as the server load. But the results were very consistent. Down to +-2s on every run.\n\nI wanted to try making metrics for the genconfig of all files, but that test proved to be quite long and had too big of a variaton in time it took.","commit_id":"aa277a59fc72d198562d9cdc02124f5fa5805984"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"62b196fecb80fb29c5c0521ddce85543a684bc0d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7fba1de2_b7eaa135","in_reply_to":"d926dae6_9dd1b103","updated":"2024-06-26 13:38:23.000000000","message":"Can we get those numbers in the commit message?","commit_id":"aa277a59fc72d198562d9cdc02124f5fa5805984"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bf551381267d815d1dab053546f21c96901b7f90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"820839ad_04a511fe","updated":"2024-05-14 08:48:29.000000000","message":"one optimisation nit (as this is about optimisation ;)). LGTM","commit_id":"49ae1cad22bbc7f0aff4dd6ce38364ed1776fb99"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"295410016ff5fce05caba10e69483d602e17196d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3d85c1fc_802c5998","updated":"2024-05-27 12:43:06.000000000","message":"we should investigate some of the non voting failing jobs (maybe they are failing due to recent CI breakage introduced by requests 2.32)","commit_id":"079bd482c494d4e7a44f1e7acd4e0ae9c736cb3a"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"43249cd700a803c1ec196fb15b7b902c5b59c01c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8a474485_e86a91a4","in_reply_to":"3d85c1fc_802c5998","updated":"2024-06-03 08:11:41.000000000","message":"I will investigate those tests. I\u0027ve already found a typo thanks to this tip. When I have more info, I\u0027ll push a new patchset.","commit_id":"079bd482c494d4e7a44f1e7acd4e0ae9c736cb3a"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"5692053f7adc4d3386bbd3ef65d8b6240c344d7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ddc0059f_867100e3","updated":"2024-06-05 07:44:15.000000000","message":"It looks like everything should be ok now. The last test failed due to connection error and did not fail in the previous run. Except for nfv tests, they fail always the same way even for different patchsets.\n\nkolla-ansible-rocky9-zun: connection error\nkolla-ansible-rocky9-scenario-nfv: looks like it fails always the same way\nkolla-ansible-rocky9-venus: connection error","commit_id":"5a3c0525fa0d2740b109c13692cabb52bd890d87"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6fb9be9902b95539349051f0b9d91884e59dbf81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"78cecf12_09743717","updated":"2024-07-24 07:53:49.000000000","message":"I don\u0027t think that this should be done under the performance label, as the resulting speedup is minimal. I would be fine though with simply doing this as code cleanup, which would require to amend the commit message and reno accordingly. Voting -1 for visibility, but the patch itself is fine","commit_id":"fb3a8f5fa9373e0412bd8fd8317d7f1cd1083e37"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f706239d6f32af373af78d9f60237c52a6ebb59d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ace596ac_02a71373","updated":"2024-07-03 11:43:41.000000000","message":"nice work. looks like these performance optimisations can be used downstream since filters were added years ago, afaik in Xena.","commit_id":"fb3a8f5fa9373e0412bd8fd8317d7f1cd1083e37"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ffb314d5e3c563f48d54910d0c9ab97b909e3c93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a5ad3d97_a7fa23bb","updated":"2024-08-08 08:40:32.000000000","message":"ok, let\u0027s go ahead with this, then","commit_id":"fb3a8f5fa9373e0412bd8fd8317d7f1cd1083e37"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ec5d6921f7b490f9d3248ae1dfbe9e4afd5ca278","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f4e0c045_583777b5","in_reply_to":"66f136b6_0755f575","updated":"2024-08-08 09:48:53.000000000","message":"Let\u0027s not complicate stable releases ;-)","commit_id":"fb3a8f5fa9373e0412bd8fd8317d7f1cd1083e37"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6dabd249b559fee3b11b06857cf02986c4df2227","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8499f01b_d2386570","in_reply_to":"78cecf12_09743717","updated":"2024-08-07 09:32:39.000000000","message":"I think some of the average performance improvements are north of 10%. I don\u0027t know at what threshold you exactly want to label something a performance improvement but I would say everything above 2% counts.\n\nThere\u0027s much prior art for this, e.g. rustc performance improvements are often in 2-3% range, but those add up, or take your usual linux performance improvements, all being labeled in both commit messages and blog posts as perf improvements, because they are.\n\nI wouldn\u0027t make a fuzz, but this patch actually has numbers that performance did in fact improve.\n\nJust look at commits 6cf22b0cb1f2dc4d8910409284fa5757a7dd67a1 or 63a7968d8d968663c4a19be164a0bdfb641491ea or 322e288368aadcb004470c22a083d7aafe594e27.\n\nFor the record, I don\u0027t want to pick on any authors there, but they all come with increased performance claims (which might be true!) without any measurements to back those up.\n\nI just found those first via `git log --grep performance`, I\u0027m sure there are more, maybe even by myself.\n\nI find it a little bit problematic if we label things a performance improvement, when we don\u0027t have numbers, but if we have numbers, we remove the label, because the numbers are not large enough.\n\nI don\u0027t know, that just seems inconsistent to me.","commit_id":"fb3a8f5fa9373e0412bd8fd8317d7f1cd1083e37"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ec5d6921f7b490f9d3248ae1dfbe9e4afd5ca278","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e297eb38_5a0960ab","in_reply_to":"8499f01b_d2386570","updated":"2024-08-08 09:48:53.000000000","message":"Acknowledged","commit_id":"fb3a8f5fa9373e0412bd8fd8317d7f1cd1083e37"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"90f28e0cb08f66989e8f1de192f48ac8b4733265","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c523fb97_0cbfbdde","in_reply_to":"ace596ac_02a71373","updated":"2024-07-10 09:13:05.000000000","message":"However, Sven gave this -1 for backport candidate. \n\n@kieske@osism.tech was this just because of the failing jobs or what is your opinion on backporting?\n\nAnd actually its 5 years old and these filters go way back into train.","commit_id":"fb3a8f5fa9373e0412bd8fd8317d7f1cd1083e37"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e6b5798c773780f5197983775c0a52877c41d965","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ff632bab_567d3a0d","in_reply_to":"c523fb97_0cbfbdde","updated":"2024-07-11 08:07:15.000000000","message":"My main objection wrt backporting would be the size of the patch. With sufficient size the chance of a backport breaking something unrelated approaches 1 imho. ;)\n\nBut I would like to hear some core opinions on that I guess. It could be argued that the changes are rather \"small\" in the sense that they are just repeating a pattern everywhere.\n\nOne question that comes to mind though, is if the performance benefit is always the same, regardless the used ansible version, which differs between releases.\n\nWas this maybe measured?\n\nWhat do you think @mnasiadka@gmail.com ?","commit_id":"fb3a8f5fa9373e0412bd8fd8317d7f1cd1083e37"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"98d2a15f94b401471688d94658b89678ed17bf07","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"66f136b6_0755f575","in_reply_to":"ff632bab_567d3a0d","updated":"2024-07-11 21:41:01.000000000","message":"I\u0027ve only tried to run the performance tests on ansible 2.16.6. If there is a probability higher then 0 of backporting it, I can try to run those test on older releases.","commit_id":"fb3a8f5fa9373e0412bd8fd8317d7f1cd1083e37"}],"ansible/roles/nova-cell/tasks/config-libvirt-tls.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"60264b216d32816fd424887396340f84a5737cfc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Copying over libvirt TLS keys (nova-libvirt)"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    service_name: nova-libvirt"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e2c0a5aa_b261fa70","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":2},"updated":"2024-04-30 08:56:02.000000000","message":"unrelated: both tasks in this file are virtually the same except for the different service name and the fact that servercert.pem and serverkey.pem are only copied to the nova-libvirt container, which could imho be special cased and we could get rid of one task, no?","commit_id":"99eba244bae495f61e78bcbf9757465f8724aa2b"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2072bed51719a6d698dcfd752090b8273edddecc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Copying over libvirt TLS keys (nova-libvirt)"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    service_name: nova-libvirt"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"68415bf1_238d512e","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":2},"in_reply_to":"e2c0a5aa_b261fa70","updated":"2024-05-03 08:02:27.000000000","message":"I tried to implement this as a single task. However, I think it raises the level of complexity of the task quite a bit. I also think that by making the server*.pem files special case (we skip them) it is introducing some inefficiencies.\n\nDo you think that merging into one tasks is worth the added complexity and two skipped items per each compute host? What are your thoughts? :)","commit_id":"99eba244bae495f61e78bcbf9757465f8724aa2b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"60264b216d32816fd424887396340f84a5737cfc","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    service_name: nova-libvirt"},{"line_number":6,"context_line":"    service: \"{{ nova_cell_services[service_name] }}\""},{"line_number":7,"context_line":"    paths:"},{"line_number":8,"context_line":"      - \"{{ node_custom_config }}/nova/nova-libvirt/{{ inventory_hostname }}/{{ item }}\""},{"line_number":9,"context_line":"      - \"{{ node_custom_config }}/nova/nova-libvirt/{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8510ae43_16050c6b","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":2},"updated":"2024-04-30 08:56:02.000000000","message":"nit: not sure what we gain here by using the variable instead of the service name directly? we don\u0027t use this anywhere else for other services.\n\nthe service name variable is only needed for the notification to restart the correct container, imho we don\u0027t need to differ in the declaration of the service variable from other places.","commit_id":"99eba244bae495f61e78bcbf9757465f8724aa2b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bf551381267d815d1dab053546f21c96901b7f90","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    service_name: nova-libvirt"},{"line_number":6,"context_line":"    service: \"{{ nova_cell_services[service_name] }}\""},{"line_number":7,"context_line":"    paths:"},{"line_number":8,"context_line":"      - \"{{ node_custom_config }}/nova/nova-libvirt/{{ inventory_hostname }}/{{ item }}\""},{"line_number":9,"context_line":"      - \"{{ node_custom_config }}/nova/nova-libvirt/{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a22b21f4_073f91d8","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":2},"in_reply_to":"1b56488a_2ef5036d","updated":"2024-05-14 08:48:29.000000000","message":"Done","commit_id":"99eba244bae495f61e78bcbf9757465f8724aa2b"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2072bed51719a6d698dcfd752090b8273edddecc","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    service_name: nova-libvirt"},{"line_number":6,"context_line":"    service: \"{{ nova_cell_services[service_name] }}\""},{"line_number":7,"context_line":"    paths:"},{"line_number":8,"context_line":"      - \"{{ node_custom_config }}/nova/nova-libvirt/{{ inventory_hostname }}/{{ item }}\""},{"line_number":9,"context_line":"      - \"{{ node_custom_config }}/nova/nova-libvirt/{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1b56488a_2ef5036d","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":2},"in_reply_to":"8510ae43_16050c6b","updated":"2024-05-03 08:02:27.000000000","message":"Yes, youre right, in these tasks service_name can be removed.","commit_id":"99eba244bae495f61e78bcbf9757465f8724aa2b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"60264b216d32816fd424887396340f84a5737cfc","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  become: true"},{"line_number":26,"context_line":"  vars:"},{"line_number":27,"context_line":"    service_name: nova-compute"},{"line_number":28,"context_line":"    service: \"{{ nova_cell_services[service_name] }}\""},{"line_number":29,"context_line":"    paths:"},{"line_number":30,"context_line":"      - \"{{ node_custom_config }}/nova/nova-libvirt/{{ inventory_hostname }}/{{ item }}\""},{"line_number":31,"context_line":"      - \"{{ node_custom_config }}/nova/nova-libvirt/{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4bbbcfc4_8528c47f","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":2},"updated":"2024-04-30 08:56:02.000000000","message":"nit: see comment above, the same applies here.","commit_id":"99eba244bae495f61e78bcbf9757465f8724aa2b"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2072bed51719a6d698dcfd752090b8273edddecc","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  become: true"},{"line_number":26,"context_line":"  vars:"},{"line_number":27,"context_line":"    service_name: nova-compute"},{"line_number":28,"context_line":"    service: \"{{ nova_cell_services[service_name] }}\""},{"line_number":29,"context_line":"    paths:"},{"line_number":30,"context_line":"      - \"{{ node_custom_config }}/nova/nova-libvirt/{{ inventory_hostname }}/{{ item }}\""},{"line_number":31,"context_line":"      - \"{{ node_custom_config }}/nova/nova-libvirt/{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f5dd2b35_81c5cdbe","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":2},"in_reply_to":"4bbbcfc4_8528c47f","updated":"2024-05-03 08:02:27.000000000","message":"same as above.","commit_id":"99eba244bae495f61e78bcbf9757465f8724aa2b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bf551381267d815d1dab053546f21c96901b7f90","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  become: true"},{"line_number":26,"context_line":"  vars:"},{"line_number":27,"context_line":"    service_name: nova-compute"},{"line_number":28,"context_line":"    service: \"{{ nova_cell_services[service_name] }}\""},{"line_number":29,"context_line":"    paths:"},{"line_number":30,"context_line":"      - \"{{ node_custom_config }}/nova/nova-libvirt/{{ inventory_hostname }}/{{ item }}\""},{"line_number":31,"context_line":"      - \"{{ node_custom_config }}/nova/nova-libvirt/{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"100f3244_5717447b","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":2},"in_reply_to":"f5dd2b35_81c5cdbe","updated":"2024-05-14 08:48:29.000000000","message":"Done","commit_id":"99eba244bae495f61e78bcbf9757465f8724aa2b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bf551381267d815d1dab053546f21c96901b7f90","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    mode: \"0600\""},{"line_number":24,"context_line":"  when:"},{"line_number":25,"context_line":"    - service | service_enabled_and_mapped_to_host"},{"line_number":26,"context_line":"    - not (service_name \u003d\u003d \u0027nova-compute\u0027 and filename \u003d\u003d \u0027servercert.pem\u0027)"},{"line_number":27,"context_line":"    - not (service_name \u003d\u003d \u0027nova-compute\u0027 and filename \u003d\u003d \u0027serverkey.pem\u0027)"},{"line_number":28,"context_line":"  loop: \"{{ services | product(key_files) | list }}\""},{"line_number":29,"context_line":"  notify:"},{"line_number":30,"context_line":"    - Restart {{service_name }} container"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f9b8dd3_90e2825e","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":74},"updated":"2024-05-14 08:48:29.000000000","message":"nit: simplify this to: `- not (service_name \u003d\u003d \u0027nova-compute\u0027 and (filename \u003d\u003d \u0027servercert.pem\u0027 or filename \u003d\u003d \u0027serverkey.pem\u0027))`?\n\nI didn\u0027t test this locally, but it _should_ work, no?","commit_id":"49ae1cad22bbc7f0aff4dd6ce38364ed1776fb99"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"295410016ff5fce05caba10e69483d602e17196d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    mode: \"0600\""},{"line_number":24,"context_line":"  when:"},{"line_number":25,"context_line":"    - service | service_enabled_and_mapped_to_host"},{"line_number":26,"context_line":"    - not (service_name \u003d\u003d \u0027nova-compute\u0027 and filename \u003d\u003d \u0027servercert.pem\u0027)"},{"line_number":27,"context_line":"    - not (service_name \u003d\u003d \u0027nova-compute\u0027 and filename \u003d\u003d \u0027serverkey.pem\u0027)"},{"line_number":28,"context_line":"  loop: \"{{ services | product(key_files) | list }}\""},{"line_number":29,"context_line":"  notify:"},{"line_number":30,"context_line":"    - Restart {{service_name }} container"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"75072c06_eb938b0a","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":74},"in_reply_to":"119a3fbb_03707636","updated":"2024-05-27 12:43:06.000000000","message":"Done","commit_id":"49ae1cad22bbc7f0aff4dd6ce38364ed1776fb99"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"de665303395dd1df5b7ae22da13168aaf18fb0ca","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    mode: \"0600\""},{"line_number":24,"context_line":"  when:"},{"line_number":25,"context_line":"    - service | service_enabled_and_mapped_to_host"},{"line_number":26,"context_line":"    - not (service_name \u003d\u003d \u0027nova-compute\u0027 and filename \u003d\u003d \u0027servercert.pem\u0027)"},{"line_number":27,"context_line":"    - not (service_name \u003d\u003d \u0027nova-compute\u0027 and filename \u003d\u003d \u0027serverkey.pem\u0027)"},{"line_number":28,"context_line":"  loop: \"{{ services | product(key_files) | list }}\""},{"line_number":29,"context_line":"  notify:"},{"line_number":30,"context_line":"    - Restart {{service_name }} container"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"119a3fbb_03707636","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":74},"in_reply_to":"5f9b8dd3_90e2825e","updated":"2024-05-15 08:09:00.000000000","message":"Yes, I belive it should be equivalent. \n\nImplemented.","commit_id":"49ae1cad22bbc7f0aff4dd6ce38364ed1776fb99"}],"ansible/roles/trove/tasks/config.yml":[{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"23a6a7a7a44fb87df918966604a78156f1967c7e","unresolved":true,"context_lines":[{"line_number":103,"context_line":"    mode: \"0660\""},{"line_number":104,"context_line":"  when:"},{"line_number":105,"context_line":"    - trove_policy_file is defined"},{"line_number":106,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":107,"context_line":"  with_dict: \"{{ trove_services }}\""},{"line_number":108,"context_line":"  notify:"},{"line_number":109,"context_line":"    - Restart {{ item.key }} container"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"28f1772d_4d433950","line":106,"updated":"2024-04-03 19:19:25.000000000","message":"Shouldn\u0027t this run only when \"item.value.enabled\" is true? Possibly a bug?","commit_id":"ccd34c12ff651ad2dcfbddc00c87cb8cb2db1028"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2072bed51719a6d698dcfd752090b8273edddecc","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    mode: \"0660\""},{"line_number":104,"context_line":"  when:"},{"line_number":105,"context_line":"    - trove_policy_file is defined"},{"line_number":106,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":107,"context_line":"  with_dict: \"{{ trove_services }}\""},{"line_number":108,"context_line":"  notify:"},{"line_number":109,"context_line":"    - Restart {{ item.key }} container"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d3b7b30a_0e9ffbf0","line":106,"in_reply_to":"28f1772d_4d433950","updated":"2024-05-03 08:02:27.000000000","message":"Done","commit_id":"ccd34c12ff651ad2dcfbddc00c87cb8cb2db1028"}],"ansible/roles/venus/tasks/config.yml":[{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"23a6a7a7a44fb87df918966604a78156f1967c7e","unresolved":true,"context_lines":[{"line_number":66,"context_line":"    mode: \"0660\""},{"line_number":67,"context_line":"  when:"},{"line_number":68,"context_line":"    - venus_policy_file is defined"},{"line_number":69,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":70,"context_line":"  with_dict: \"{{ venus_services }}\""},{"line_number":71,"context_line":"  notify:"},{"line_number":72,"context_line":"    - Restart {{ item.key }} container"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b148b16f_ba895cbf","line":69,"updated":"2024-04-03 19:19:25.000000000","message":"Shouldn\u0027t this run only when \"item.value.enabled\" is true? Possibly a bug?","commit_id":"ccd34c12ff651ad2dcfbddc00c87cb8cb2db1028"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2072bed51719a6d698dcfd752090b8273edddecc","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    mode: \"0660\""},{"line_number":67,"context_line":"  when:"},{"line_number":68,"context_line":"    - venus_policy_file is defined"},{"line_number":69,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":70,"context_line":"  with_dict: \"{{ venus_services }}\""},{"line_number":71,"context_line":"  notify:"},{"line_number":72,"context_line":"    - Restart {{ item.key }} container"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0090703f_8e451363","line":69,"in_reply_to":"b148b16f_ba895cbf","updated":"2024-05-03 08:02:27.000000000","message":"Done","commit_id":"ccd34c12ff651ad2dcfbddc00c87cb8cb2db1028"}],"ansible/roles/zun/tasks/config.yml":[{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"23a6a7a7a44fb87df918966604a78156f1967c7e","unresolved":true,"context_lines":[{"line_number":86,"context_line":"  become: true"},{"line_number":87,"context_line":"  when:"},{"line_number":88,"context_line":"    - zun_policy_file is defined"},{"line_number":89,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":90,"context_line":"  with_dict: \"{{ zun_services }}\""},{"line_number":91,"context_line":"  notify:"},{"line_number":92,"context_line":"    - Restart {{ item.key }} container"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2b9ad0d1_db2847e7","line":89,"updated":"2024-04-03 19:19:25.000000000","message":"Shouldn\u0027t this run only when \"item.value.enabled\" is true? Possibly a bug?","commit_id":"ccd34c12ff651ad2dcfbddc00c87cb8cb2db1028"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2072bed51719a6d698dcfd752090b8273edddecc","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  become: true"},{"line_number":87,"context_line":"  when:"},{"line_number":88,"context_line":"    - zun_policy_file is defined"},{"line_number":89,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":90,"context_line":"  with_dict: \"{{ zun_services }}\""},{"line_number":91,"context_line":"  notify:"},{"line_number":92,"context_line":"    - Restart {{ item.key }} container"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9749dfe2_58947587","line":89,"in_reply_to":"2b9ad0d1_db2847e7","updated":"2024-05-03 08:02:27.000000000","message":"Done","commit_id":"ccd34c12ff651ad2dcfbddc00c87cb8cb2db1028"}],"releasenotes/notes/performance-improvements-42c34ebf4243312a.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"60264b216d32816fd424887396340f84a5737cfc","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    filter gets rid of some overhead caused by"},{"line_number":7,"context_line":"    ansible skipping items in tasks."},{"line_number":8,"context_line":"    With bigger amount of hosts, this overhead"},{"line_number":9,"context_line":"    could be non-insignificant."},{"line_number":10,"context_line":"    Usage of service_enabled_and_mapped_to_host"},{"line_number":11,"context_line":"    filter is mostly cosmetic and has no effect"},{"line_number":12,"context_line":"    on the performance."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1b6c3c36_a360bd74","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":12},"updated":"2024-04-30 08:56:02.000000000","message":"nit: is ;)","commit_id":"99eba244bae495f61e78bcbf9757465f8724aa2b"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2072bed51719a6d698dcfd752090b8273edddecc","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    filter gets rid of some overhead caused by"},{"line_number":7,"context_line":"    ansible skipping items in tasks."},{"line_number":8,"context_line":"    With bigger amount of hosts, this overhead"},{"line_number":9,"context_line":"    could be non-insignificant."},{"line_number":10,"context_line":"    Usage of service_enabled_and_mapped_to_host"},{"line_number":11,"context_line":"    filter is mostly cosmetic and has no effect"},{"line_number":12,"context_line":"    on the performance."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1addb204_46d995a7","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":12},"in_reply_to":"1b6c3c36_a360bd74","updated":"2024-05-03 08:02:27.000000000","message":"Done","commit_id":"99eba244bae495f61e78bcbf9757465f8724aa2b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"60264b216d32816fd424887396340f84a5737cfc","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    ansible skipping items in tasks."},{"line_number":8,"context_line":"    With bigger amount of hosts, this overhead"},{"line_number":9,"context_line":"    could be non-insignificant."},{"line_number":10,"context_line":"    Usage of service_enabled_and_mapped_to_host"},{"line_number":11,"context_line":"    filter is mostly cosmetic and has no effect"},{"line_number":12,"context_line":"    on the performance."},{"line_number":13,"context_line":"    `Blueprint performance-improvements \u003chttps://blueprints.launchpad.net/kolla/+spec/performance-improvements\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"57495429_20bcf5b4","line":12,"range":{"start_line":10,"start_character":4,"end_line":12,"end_character":23},"updated":"2024-04-30 08:56:02.000000000","message":"nit: was that independently measured? I might have missed that.","commit_id":"99eba244bae495f61e78bcbf9757465f8724aa2b"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2072bed51719a6d698dcfd752090b8273edddecc","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    ansible skipping items in tasks."},{"line_number":8,"context_line":"    With bigger amount of hosts, this overhead"},{"line_number":9,"context_line":"    could be non-insignificant."},{"line_number":10,"context_line":"    Usage of service_enabled_and_mapped_to_host"},{"line_number":11,"context_line":"    filter is mostly cosmetic and has no effect"},{"line_number":12,"context_line":"    on the performance."},{"line_number":13,"context_line":"    `Blueprint performance-improvements \u003chttps://blueprints.launchpad.net/kolla/+spec/performance-improvements\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6570581e_48deb5fb","line":12,"range":{"start_line":10,"start_character":4,"end_line":12,"end_character":23},"in_reply_to":"57495429_20bcf5b4","updated":"2024-05-03 08:02:27.000000000","message":"Yes, I forgot to mention it in the main benchmark comment. \n\nWhen testing master against version of this branch that was using ONLY service_enabled_and_mapped_to_host filter the effect on performance was non-significant.","commit_id":"99eba244bae495f61e78bcbf9757465f8724aa2b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bf551381267d815d1dab053546f21c96901b7f90","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    ansible skipping items in tasks."},{"line_number":8,"context_line":"    With bigger amount of hosts, this overhead"},{"line_number":9,"context_line":"    could be non-insignificant."},{"line_number":10,"context_line":"    Usage of service_enabled_and_mapped_to_host"},{"line_number":11,"context_line":"    filter is mostly cosmetic and has no effect"},{"line_number":12,"context_line":"    on the performance."},{"line_number":13,"context_line":"    `Blueprint performance-improvements \u003chttps://blueprints.launchpad.net/kolla/+spec/performance-improvements\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5e05013d_598986ff","line":12,"range":{"start_line":10,"start_character":4,"end_line":12,"end_character":23},"in_reply_to":"6570581e_48deb5fb","updated":"2024-05-14 08:48:29.000000000","message":"Done","commit_id":"99eba244bae495f61e78bcbf9757465f8724aa2b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"60264b216d32816fd424887396340f84a5737cfc","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    Usage of service_enabled_and_mapped_to_host"},{"line_number":11,"context_line":"    filter is mostly cosmetic and has no effect"},{"line_number":12,"context_line":"    on the performance."},{"line_number":13,"context_line":"    `Blueprint performance-improvements \u003chttps://blueprints.launchpad.net/kolla/+spec/performance-improvements\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f028a07_3344ee22","line":13,"range":{"start_line":13,"start_character":41,"end_line":13,"end_character":110},"updated":"2024-04-30 08:56:02.000000000","message":"that Link does not exist, according to launchpad.","commit_id":"99eba244bae495f61e78bcbf9757465f8724aa2b"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2072bed51719a6d698dcfd752090b8273edddecc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    Usage of service_enabled_and_mapped_to_host"},{"line_number":11,"context_line":"    filter is mostly cosmetic and has no effect"},{"line_number":12,"context_line":"    on the performance."},{"line_number":13,"context_line":"    `Blueprint performance-improvements \u003chttps://blueprints.launchpad.net/kolla/+spec/performance-improvements\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c2fd2951_5f202a38","line":13,"range":{"start_line":13,"start_character":41,"end_line":13,"end_character":110},"in_reply_to":"9f028a07_3344ee22","updated":"2024-05-03 08:02:27.000000000","message":"Done","commit_id":"99eba244bae495f61e78bcbf9757465f8724aa2b"}]}