)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b6760051efc69e05fc7bda7552603a5782fb8289","unresolved":true,"context_lines":[{"line_number":11,"context_line":"defined and enabled for the service. However, some services like"},{"line_number":12,"context_line":"RabbitMQ, ProxySQL or Redis don\u0027t use HAProxy"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch adds new variable \u0027use_haproxy\u0027 that enables the role"},{"line_number":15,"context_line":"to be used with such services."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"PartiallyImplements: mariadb-ssl"},{"line_number":18,"context_line":"Change-Id: I8864e05212e0ed76ea3a0108b00ed9dd04b1a697"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"855a5968_926eaf6d","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":30},"updated":"2024-06-27 14:38:31.000000000","message":"this is no longer the case, please adjust the commit message accordingly.","commit_id":"330ef4a6516feec0a75a33f1dcbc2de43b6e9002"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6e7da1b2ac514991cbc08e3789248ed348a0a39d","unresolved":true,"context_lines":[{"line_number":11,"context_line":"defined and enabled for the service. However, some services like"},{"line_number":12,"context_line":"RabbitMQ, ProxySQL or Redis don\u0027t use HAProxy"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch adds new variable \u0027use_haproxy\u0027 that enables the role"},{"line_number":15,"context_line":"to be used with such services."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"PartiallyImplements: mariadb-ssl"},{"line_number":18,"context_line":"Change-Id: I8864e05212e0ed76ea3a0108b00ed9dd04b1a697"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ed9e430a_92ef7c06","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":30},"in_reply_to":"855a5968_926eaf6d","updated":"2024-06-27 15:05:53.000000000","message":"AAA, missed, thanks.","commit_id":"330ef4a6516feec0a75a33f1dcbc2de43b6e9002"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b69172d36b5ba987fc15500b6d1080a8c40babaa","unresolved":false,"context_lines":[{"line_number":11,"context_line":"defined and enabled for the service. However, some services like"},{"line_number":12,"context_line":"RabbitMQ, ProxySQL or Redis don\u0027t use HAProxy"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch adds new variable \u0027use_haproxy\u0027 that enables the role"},{"line_number":15,"context_line":"to be used with such services."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"PartiallyImplements: mariadb-ssl"},{"line_number":18,"context_line":"Change-Id: I8864e05212e0ed76ea3a0108b00ed9dd04b1a697"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"addcb764_524cd540","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":30},"in_reply_to":"ed9e430a_92ef7c06","updated":"2024-06-28 08:31:25.000000000","message":"Done","commit_id":"330ef4a6516feec0a75a33f1dcbc2de43b6e9002"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"01b8202eea875396d5a8d60d27836893bdf44bed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a68fb174_c1a2d31f","updated":"2024-04-30 13:42:35.000000000","message":"Why adding another variable and complicating conditional for those tasks ? \nThose tasks are for service-cert and service-key for BACKEND tls.\n\nSo yeah, even if i don\u0027t have haproxy, and I want to run some service itself behind TLS ... that conditional is just not necessary...\n\nI would suggest to completly remove that conditional..","commit_id":"f85e12a7618d4d234cd2b3e461683f24bcfe9561"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4b0bc72e7e6c53aca0be195b89f0ed877a115619","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b58ab914_11fe1609","in_reply_to":"a68fb174_c1a2d31f","updated":"2024-05-22 13:26:10.000000000","message":"@matus as stated in github downstream issue, please address Michals comment, as it simplifies the code.","commit_id":"f85e12a7618d4d234cd2b3e461683f24bcfe9561"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f864d7905982e65b47d7ccc3b93f95de7b504ee6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c27059cf_5d0e9455","in_reply_to":"b58ab914_11fe1609","updated":"2024-05-22 13:26:48.000000000","message":"for the curious, here is the downstream issue: https://github.com/SovereignCloudStack/issues/issues/466","commit_id":"f85e12a7618d4d234cd2b3e461683f24bcfe9561"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"20ccb972dbef389c577e6cc1c461a71e22144d95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9e955eb5_c69fa759","in_reply_to":"c27059cf_5d0e9455","updated":"2024-05-24 07:29:48.000000000","message":"Done","commit_id":"f85e12a7618d4d234cd2b3e461683f24bcfe9561"}],"ansible/roles/service-cert-copy/tasks/main.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2b6852dd13d59d33601774e8497016b257559aff","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/{{ project_name }}-cert.pem\""},{"line_number":25,"context_line":"    mode: \"0644\""},{"line_number":26,"context_line":"  become: true"},{"line_number":27,"context_line":"  # when:"},{"line_number":28,"context_line":"  #   - \u003e"},{"line_number":29,"context_line":"  #     ("},{"line_number":30,"context_line":"  #     item.value.haproxy is defined and"},{"line_number":31,"context_line":"  #     item.value.haproxy.values() | selectattr(\u0027enabled\u0027, \u0027defined\u0027) | map(attribute\u003d\u0027enabled\u0027) | map(\u0027bool\u0027) | select | list | length \u003e 0 and"},{"line_number":32,"context_line":"  #     item.value.haproxy.values() | selectattr(\u0027tls_backend\u0027, \u0027defined\u0027) | map(attribute\u003d\u0027tls_backend\u0027) | map(\u0027bool\u0027) | select | list | length \u003e 0"},{"line_number":33,"context_line":"  #     )"},{"line_number":34,"context_line":"  #     or not use_haproxy"},{"line_number":35,"context_line":"  #   - not kolla_externally_managed_cert | bool"},{"line_number":36,"context_line":"  # with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":37,"context_line":"  notify:"},{"line_number":38,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"93e4dd67_ffa2c9df","line":36,"range":{"start_line":27,"start_character":0,"end_line":36,"end_character":84},"updated":"2024-05-23 15:46:33.000000000","message":"please remove the code entirely when you are finished with testing.\nI take it you just commented it out for testing purposes?\n\nThanks.","commit_id":"77ad08fad203d958e6fe10209c11f12c4717d99b"}]}