)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f070c747c11cd55c6f4500b325ab0ab229e4aab3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Will Szumski \u003cwill@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-04-16 18:06:04 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds option to add extra scape targets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This enables you to scrape external targets more easily."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"065e6dd7_baa56848","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":38},"updated":"2024-04-25 11:05:39.000000000","message":"I would mention this is for node-exporter","commit_id":"b3d6f8fd197ee3f8b8f43fa2e29f629dae4c6cae"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"242041b50ce964ce1b05b21767383c7a9346a7f6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Will Szumski \u003cwill@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-04-16 18:06:04 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds option to add extra scape targets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This enables you to scrape external targets more easily."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"812f4f43_65bee829","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":38},"in_reply_to":"065e6dd7_baa56848","updated":"2024-06-26 13:42:21.000000000","message":"Done","commit_id":"b3d6f8fd197ee3f8b8f43fa2e29f629dae4c6cae"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"831be3cb40788d45e4249e5ce0a572a240d6f9e4","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Will Szumski \u003cwill@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-04-30 13:03:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds option to add extra scape targets for node exporter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This enables you to scrape external targets more easily."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fb44df23_1d245610","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":31},"updated":"2024-04-30 13:05:45.000000000","message":"nit/typO: scrape","commit_id":"1ed41f9b110844b56fc4e196e23bd7d637b3cf5e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5f495e6df97bd85c81f43c6dc5a29f0bd2bc2a95","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Will Szumski \u003cwill@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-04-30 13:03:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds option to add extra scape targets for node exporter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This enables you to scrape external targets more easily."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f587b9c5_36a7d5e4","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":31},"in_reply_to":"a7a1bed8_e216f42e","updated":"2024-06-26 15:55:20.000000000","message":"no? 😄","commit_id":"1ed41f9b110844b56fc4e196e23bd7d637b3cf5e"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7154956ca53005331cc7f9b92c6fa002bbb36988","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Will Szumski \u003cwill@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-04-30 13:03:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds option to add extra scape targets for node exporter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This enables you to scrape external targets more easily."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da0085bc_ea4ecfd6","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":31},"in_reply_to":"f587b9c5_36a7d5e4","updated":"2024-06-26 17:43:33.000000000","message":"Really done now.","commit_id":"1ed41f9b110844b56fc4e196e23bd7d637b3cf5e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"242041b50ce964ce1b05b21767383c7a9346a7f6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Will Szumski \u003cwill@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-04-30 13:03:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds option to add extra scape targets for node exporter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This enables you to scrape external targets more easily."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a7a1bed8_e216f42e","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":31},"in_reply_to":"fb44df23_1d245610","updated":"2024-06-26 13:42:21.000000000","message":"Done","commit_id":"1ed41f9b110844b56fc4e196e23bd7d637b3cf5e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4fd798470f32b31ebf8014d378367b57bb6d8cd4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"16a9b64c_f76bab88","updated":"2024-04-16 09:11:43.000000000","message":"Maybe it\u0027s a stupid question - but shouldn\u0027t we be able to merge_yaml?","commit_id":"64f3ed660238e4c5460283df9de53590f4b3a649"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"0b19e0b40440ef08d6b4ac7b226dfb787a2cc25f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f05ffd48_46ba162c","updated":"2024-04-16 09:36:20.000000000","message":"There are a couple of other solutions that could work for my use case:\n\n- Inventory group used for external targets where node exporter isn\u0027t deployed\n- Possibly do something with file base service discovery\n\nI mainly went with this way as it is simple, but happy to change implementation if people think there is a better solution.","commit_id":"64f3ed660238e4c5460283df9de53590f4b3a649"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"ef3464db89ec09e9c65ab2f4edc4ab6aba314d72","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"80df7e5e_88360251","in_reply_to":"16a9b64c_f76bab88","updated":"2024-04-16 09:31:56.000000000","message":"You can use that but you will need a different job name. My issue was that the dashboards in grafana are coded to use node as the job name and I wanted a way to be able to add targets to the existing job.","commit_id":"64f3ed660238e4c5460283df9de53590f4b3a649"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ccf79ad80d0d02addf2964b6020b441bbd323745","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d414f6c6_eb594df3","in_reply_to":"80df7e5e_88360251","updated":"2024-04-25 08:12:14.000000000","message":"Makes sense","commit_id":"64f3ed660238e4c5460283df9de53590f4b3a649"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"ad7369001e9420fedc4aac67bd51e031012ec6e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"89ebcf74_83893cef","updated":"2024-04-16 17:09:54.000000000","message":"Sorry, hadn\u0027t tested labels and I\u0027d accidentally quoted the json (now fixed)","commit_id":"b3d6f8fd197ee3f8b8f43fa2e29f629dae4c6cae"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"92463d90ce60d868139c873757fe2b543e539984","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c44426ca_5ba93a85","updated":"2024-06-27 14:46:17.000000000","message":"ah, sorry, I thought this was not merged yet. sorry for the noise!","commit_id":"582e2490ca994d39b9209b194e4d0326c87925fb"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0575eec919df24d940dbfce2978ab35d0b11da69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9ef4bae9_a73defc7","updated":"2024-06-26 18:49:21.000000000","message":"nits updated, accounting for previous +2s","commit_id":"582e2490ca994d39b9209b194e4d0326c87925fb"}],"ansible/roles/prometheus/defaults/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"093f6e098b28856df59ad12745b115211d291d14","unresolved":true,"context_lines":[{"line_number":174,"context_line":"####################"},{"line_number":175,"context_line":"# Node Exporter"},{"line_number":176,"context_line":"####################"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"prometheus_node_exporter_targets_extra: []"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"70a79302_c5478d45","line":177,"updated":"2024-06-26 13:42:01.000000000","message":"nit: remove newline","commit_id":"1ed41f9b110844b56fc4e196e23bd7d637b3cf5e"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f8ee38695d19793e5e1c710e6878365f3b871b8f","unresolved":false,"context_lines":[{"line_number":174,"context_line":"####################"},{"line_number":175,"context_line":"# Node Exporter"},{"line_number":176,"context_line":"####################"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"prometheus_node_exporter_targets_extra: []"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"caae44d1_d4813363","line":177,"in_reply_to":"70a79302_c5478d45","updated":"2024-06-26 17:44:09.000000000","message":"Done","commit_id":"1ed41f9b110844b56fc4e196e23bd7d637b3cf5e"}],"doc/source/reference/logging-and-monitoring/prometheus-guide.rst":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a8767b8e36be53f38ee875dad283bd064d2e2972","unresolved":false,"context_lines":[{"line_number":238,"context_line":".. code-block:: yaml"},{"line_number":239,"context_line":"  :caption: ``/etc/kolla/globals.yml``"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"  prometheus_node_exporter_targets_extra:"},{"line_number":242,"context_line":"    - target: http://10.0.0.1:1234"},{"line_number":243,"context_line":"      labels:"},{"line_number":244,"context_line":"        instance: host1"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"2ea38ea5_8c64eb24","line":244,"range":{"start_line":241,"start_character":0,"end_line":244,"end_character":23},"updated":"2024-04-30 13:06:29.000000000","message":"nit: if you happen to have an actual real world example that tends to help people even more :)","commit_id":"1ed41f9b110844b56fc4e196e23bd7d637b3cf5e"}]}