)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3ad713918dc07b09f047fa09e8391002872ae631","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow more configuration for keepalived"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is used in order to specify the addresses that keepalived will manage, and the ability to not use keepalived at all for the internal VIP address. Also implements the ability to specify the keepalived_interface."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #2062991"},{"line_number":12,"context_line":"Change-Id: I8f19ddadd81b7bedfa67e8012045bdf001c64a6f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b6db41b2_e4c64bc3","line":9,"updated":"2024-04-22 09:47:10.000000000","message":"very long line. please wrap it. read the guide: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"83350622acc744812b8791c884af666d56e443e3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3ad713918dc07b09f047fa09e8391002872ae631","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e4953af2_79287e58","updated":"2024-04-22 09:47:10.000000000","message":"reno is missing","commit_id":"83350622acc744812b8791c884af666d56e443e3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"01530b648c2f02d14a42fffa8311a54d114a4ebb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"52b7ba91_7c0a9ce5","updated":"2024-04-30 19:45:27.000000000","message":"much better, but still lack of a reno","commit_id":"27c6bfeaa2d587c4ff6d9a8b4819f1905ebd9bfd"}],"ansible/roles/loadbalancer/defaults/main.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3ad713918dc07b09f047fa09e8391002872ae631","unresolved":true,"context_lines":[{"line_number":187,"context_line":"keepalived_track_script_enabled: True"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"# Interface for VRRP advertisements"},{"line_number":190,"context_line":"keepalived_interface: \"{{ api_interface }}\""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"keepalived_internal_vip_addresses:"},{"line_number":193,"context_line":"  - \"{{ kolla_internal_vip_address }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"094fdd16_382118ea","line":190,"range":{"start_line":190,"start_character":0,"end_line":190,"end_character":20},"updated":"2024-04-22 09:47:10.000000000","message":"keepalived_internal_interface","commit_id":"83350622acc744812b8791c884af666d56e443e3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3ad713918dc07b09f047fa09e8391002872ae631","unresolved":true,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"# Interface for VRRP advertisements"},{"line_number":190,"context_line":"keepalived_interface: \"{{ api_interface }}\""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"keepalived_internal_vip_addresses:"},{"line_number":193,"context_line":"  - \"{{ kolla_internal_vip_address }}\""},{"line_number":194,"context_line":"keepalived_external_vip_addresses:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1bc20e91_e1a6715e","line":191,"updated":"2024-04-22 09:47:10.000000000","message":"keepalived_external_interface: \"{{ kolla_external_vip_interface }}\"","commit_id":"83350622acc744812b8791c884af666d56e443e3"},{"author":{"_account_id":36319,"name":"Freerk-Ole Zakfeld","display_name":"Freerk-Ole Zakfeld","email":"freerk@zakfeld.com","username":"freerkzakfeld","status":"I work as a cloud engineer at ScaleUp Technologies"},"change_message_id":"1d8256044015dc29b6a0b3b92c9153e018ca8b8a","unresolved":true,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"# Interface for VRRP advertisements"},{"line_number":190,"context_line":"keepalived_interface: \"{{ api_interface }}\""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"keepalived_internal_vip_addresses:"},{"line_number":193,"context_line":"  - \"{{ kolla_internal_vip_address }}\""},{"line_number":194,"context_line":"keepalived_external_vip_addresses:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ec55c5f_f3787365","line":191,"in_reply_to":"1bc20e91_e1a6715e","updated":"2024-04-22 10:50:15.000000000","message":"keepalived works in one instance only - so there\u0027s only one interface sending VRRP advertisements. Splitting them into internal/external would mean seperate vrrp instances - don\u0027t think that\u0027s neccesary.","commit_id":"83350622acc744812b8791c884af666d56e443e3"}],"ansible/roles/loadbalancer/templates/keepalived/keepalived.conf.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3ad713918dc07b09f047fa09e8391002872ae631","unresolved":true,"context_lines":[{"line_number":10,"context_line":"vrrp_instance kolla_internal_vip_{{ keepalived_virtual_router_id }} {"},{"line_number":11,"context_line":"    state BACKUP"},{"line_number":12,"context_line":"    nopreempt"},{"line_number":13,"context_line":"    interface {{ keepalived_interface }}"},{"line_number":14,"context_line":"    virtual_router_id {{ keepalived_virtual_router_id }}"},{"line_number":15,"context_line":"    priority {{ groups[\u0027loadbalancer\u0027].index(inventory_hostname) + 1 }}"},{"line_number":16,"context_line":"    advert_int 1"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"adb617db_e7ddf6bf","line":13,"range":{"start_line":13,"start_character":17,"end_line":13,"end_character":37},"updated":"2024-04-22 09:47:10.000000000","message":"keepalived_internal_interface","commit_id":"83350622acc744812b8791c884af666d56e443e3"},{"author":{"_account_id":36319,"name":"Freerk-Ole Zakfeld","display_name":"Freerk-Ole Zakfeld","email":"freerk@zakfeld.com","username":"freerkzakfeld","status":"I work as a cloud engineer at ScaleUp Technologies"},"change_message_id":"434e695968bac3418245d143b84b931aad6577a2","unresolved":true,"context_lines":[{"line_number":10,"context_line":"vrrp_instance kolla_internal_vip_{{ keepalived_virtual_router_id }} {"},{"line_number":11,"context_line":"    state BACKUP"},{"line_number":12,"context_line":"    nopreempt"},{"line_number":13,"context_line":"    interface {{ keepalived_interface }}"},{"line_number":14,"context_line":"    virtual_router_id {{ keepalived_virtual_router_id }}"},{"line_number":15,"context_line":"    priority {{ groups[\u0027loadbalancer\u0027].index(inventory_hostname) + 1 }}"},{"line_number":16,"context_line":"    advert_int 1"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da73a539_c6f08b3c","line":13,"range":{"start_line":13,"start_character":17,"end_line":13,"end_character":37},"in_reply_to":"adb617db_e7ddf6bf","updated":"2024-04-22 10:52:20.000000000","message":"This would create the same affect that is currently blocking us - the vrrp being sent through the internal interface instead of (in our case desired) external one.","commit_id":"83350622acc744812b8791c884af666d56e443e3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3ad713918dc07b09f047fa09e8391002872ae631","unresolved":true,"context_lines":[{"line_number":29,"context_line":"{% endif %}"},{"line_number":30,"context_line":"    virtual_ipaddress {"},{"line_number":31,"context_line":"{% for vip_address in keepalived_internal_vip_addresses %}"},{"line_number":32,"context_line":"        {{ vip_address }} dev {{ api_interface }}"},{"line_number":33,"context_line":"{% endfor %}"},{"line_number":34,"context_line":"{% if haproxy_enable_external_vip | bool %}"},{"line_number":35,"context_line":"{% for vip_address in keepalived_external_vip_addresses %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7188c8c7_be0a5d30","line":32,"range":{"start_line":32,"start_character":33,"end_line":32,"end_character":46},"updated":"2024-04-22 09:47:10.000000000","message":"keepalived_internal_interface","commit_id":"83350622acc744812b8791c884af666d56e443e3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3ad713918dc07b09f047fa09e8391002872ae631","unresolved":true,"context_lines":[{"line_number":33,"context_line":"{% endfor %}"},{"line_number":34,"context_line":"{% if haproxy_enable_external_vip | bool %}"},{"line_number":35,"context_line":"{% for vip_address in keepalived_external_vip_addresses %}"},{"line_number":36,"context_line":"        {{ vip_address }} dev {{ kolla_external_vip_interface }}"},{"line_number":37,"context_line":"{% endfor %}"},{"line_number":38,"context_line":"{% endif %}"},{"line_number":39,"context_line":"    }"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"336c8334_00a4b006","line":36,"range":{"start_line":36,"start_character":33,"end_line":36,"end_character":61},"updated":"2024-04-22 09:47:10.000000000","message":"keepalived_external_interface","commit_id":"83350622acc744812b8791c884af666d56e443e3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3ad713918dc07b09f047fa09e8391002872ae631","unresolved":true,"context_lines":[{"line_number":37,"context_line":"{% endfor %}"},{"line_number":38,"context_line":"{% endif %}"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":"{% if haproxy_enable_external_vip | bool and keepalived_interface !\u003d kolla_external_vip_interface %}"},{"line_number":41,"context_line":"    track_interface {"},{"line_number":42,"context_line":"        {{ kolla_external_vip_interface }}"},{"line_number":43,"context_line":"    }"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"8dde2c71_dd17ca12","line":40,"range":{"start_line":40,"start_character":69,"end_line":40,"end_character":97},"updated":"2024-04-22 09:47:10.000000000","message":"keepalived_external_interface","commit_id":"83350622acc744812b8791c884af666d56e443e3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3ad713918dc07b09f047fa09e8391002872ae631","unresolved":true,"context_lines":[{"line_number":37,"context_line":"{% endfor %}"},{"line_number":38,"context_line":"{% endif %}"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":"{% if haproxy_enable_external_vip | bool and keepalived_interface !\u003d kolla_external_vip_interface %}"},{"line_number":41,"context_line":"    track_interface {"},{"line_number":42,"context_line":"        {{ kolla_external_vip_interface }}"},{"line_number":43,"context_line":"    }"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"0eeb1d28_00c49ef3","line":40,"range":{"start_line":40,"start_character":45,"end_line":40,"end_character":65},"updated":"2024-04-22 09:47:10.000000000","message":"keepalived_internal_interface","commit_id":"83350622acc744812b8791c884af666d56e443e3"}]}