)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"972487de5e0bb75c8afc9c1c5fc8b3cda2d930d5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"88dd8b76_945fe142","updated":"2024-04-25 08:56:57.000000000","message":"do we need a bugreport and backports for this?","commit_id":"3dfc8847f0545666e129446213125f7f439281ce"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b8f09dbd7ad1a92f2c3edb0dce3f99c79bb327a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1fa32913_1f4804b7","in_reply_to":"88dd8b76_945fe142","updated":"2024-04-25 09:35:51.000000000","message":"Done","commit_id":"3dfc8847f0545666e129446213125f7f439281ce"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9c97e8f0a939037019751d8c1cd399363489f591","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5afe3539_45a23225","updated":"2024-04-25 09:40:55.000000000","message":"LGTM\nlet\u0027s see what CI says about it.","commit_id":"8135b92d839b901a1dd0517f89cfba680f7ab6e8"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"47b4a33471b26fc42de27c2e86130fd63671d225","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c36d0ff8_bfbc47d9","updated":"2024-06-18 14:51:53.000000000","message":"Been here for too long","commit_id":"2c0f94a868ce712a7b13ac1755f20a5cdc950535"}],"kolla_ansible/kolla_url.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5c305ce62f06cce7ee6cc487607c70f174b1dfda","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fqdn \u003d put_address_in_context(fqdn, context)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    if ((protocol \u003d\u003d \u0027http\u0027 and port \u003d\u003d \u002780\u0027) or"},{"line_number":33,"context_line":"       (protocol \u003d\u003d \u0027https\u0027 and port \u003d\u003d \u0027443\u0027) or"},{"line_number":34,"context_line":"       (protocol \u003d\u003d \u0027ws\u0027 and port \u003d\u003d \u002780\u0027) or"},{"line_number":35,"context_line":"       (protocol \u003d\u003d \u0027wss\u0027 and port \u003d\u003d \u0027443\u0027)):"}],"source_content_type":"text/x-python","patch_set":3,"id":"168a281d_f238aa81","line":32,"updated":"2024-04-29 12:52:32.000000000","message":"Is this because we pass a jinja expression? If we passed a literal number would we still see a string?\n\nAnother way that would handle both ints and strings would be to first convert to an int:\n\nport \u003d int(port)\n\nThis would also catch malformed ports.","commit_id":"8135b92d839b901a1dd0517f89cfba680f7ab6e8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e30258f2c78ae5c29d7ef300bcbf0fed1d0043f2","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fqdn \u003d put_address_in_context(fqdn, context)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    if ((protocol \u003d\u003d \u0027http\u0027 and port \u003d\u003d \u002780\u0027) or"},{"line_number":33,"context_line":"       (protocol \u003d\u003d \u0027https\u0027 and port \u003d\u003d \u0027443\u0027) or"},{"line_number":34,"context_line":"       (protocol \u003d\u003d \u0027ws\u0027 and port \u003d\u003d \u002780\u0027) or"},{"line_number":35,"context_line":"       (protocol \u003d\u003d \u0027wss\u0027 and port \u003d\u003d \u0027443\u0027)):"}],"source_content_type":"text/x-python","patch_set":3,"id":"50a8da52_c85ee531","line":32,"in_reply_to":"168a281d_f238aa81","updated":"2024-04-30 09:58:22.000000000","message":"I like this idea, seems to add some robustness (malformed port detection). But could also be implemented in a distinct changeset, I have no strong opinions on that.","commit_id":"8135b92d839b901a1dd0517f89cfba680f7ab6e8"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4720e71de59044219fdf3b31c6306c4b1510a684","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fqdn \u003d put_address_in_context(fqdn, context)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    if ((protocol \u003d\u003d \u0027http\u0027 and port \u003d\u003d \u002780\u0027) or"},{"line_number":33,"context_line":"       (protocol \u003d\u003d \u0027https\u0027 and port \u003d\u003d \u0027443\u0027) or"},{"line_number":34,"context_line":"       (protocol \u003d\u003d \u0027ws\u0027 and port \u003d\u003d \u002780\u0027) or"},{"line_number":35,"context_line":"       (protocol \u003d\u003d \u0027wss\u0027 and port \u003d\u003d \u0027443\u0027)):"}],"source_content_type":"text/x-python","patch_set":3,"id":"f1ed5b7b_593f2ba4","line":32,"in_reply_to":"50a8da52_c85ee531","updated":"2024-04-30 10:17:21.000000000","message":"Makes sense.","commit_id":"8135b92d839b901a1dd0517f89cfba680f7ab6e8"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"25532620694540f68be9bb34f8cef70442bcf476","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fqdn \u003d put_address_in_context(fqdn, context)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    if ((protocol \u003d\u003d \u0027http\u0027 and port \u003d\u003d \u002780\u0027) or"},{"line_number":33,"context_line":"       (protocol \u003d\u003d \u0027https\u0027 and port \u003d\u003d \u0027443\u0027) or"},{"line_number":34,"context_line":"       (protocol \u003d\u003d \u0027ws\u0027 and port \u003d\u003d \u002780\u0027) or"},{"line_number":35,"context_line":"       (protocol \u003d\u003d \u0027wss\u0027 and port \u003d\u003d \u0027443\u0027)):"}],"source_content_type":"text/x-python","patch_set":3,"id":"28050a4d_f0c7d003","line":32,"in_reply_to":"f1ed5b7b_593f2ba4","updated":"2024-05-07 07:58:08.000000000","message":"Done","commit_id":"8135b92d839b901a1dd0517f89cfba680f7ab6e8"}]}