)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e81297e95fb17bcc17d0b3ed8d8122038d8ced7f","unresolved":true,"context_lines":[{"line_number":10,"context_line":"yet the web servers within containers fail to respond,"},{"line_number":11,"context_line":"resulting in requests being sent to unhealthy servers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug #2065046"},{"line_number":14,"context_line":"Change-Id: I839f7f1051182fe797394e5436571d64d5c5b5a4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"2a404165_a315225c","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":10},"updated":"2024-05-07 12:44:36.000000000","message":"nit: now it\u0027s missing a \":\" so write:\n\n`Closes-Bug: #2065046`","commit_id":"8c6752f2f58f4cfa1a26d88e8be3cf6df483b4a9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c875610f3b1b616e8492b6c90ad839a713e7f026","unresolved":false,"context_lines":[{"line_number":10,"context_line":"yet the web servers within containers fail to respond,"},{"line_number":11,"context_line":"resulting in requests being sent to unhealthy servers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug #2065046"},{"line_number":14,"context_line":"Change-Id: I839f7f1051182fe797394e5436571d64d5c5b5a4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"78201ddf_5fce547c","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":10},"in_reply_to":"2a404165_a315225c","updated":"2024-05-07 12:48:17.000000000","message":"Done","commit_id":"8c6752f2f58f4cfa1a26d88e8be3cf6df483b4a9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2b2fe9340ee3eaa83c3df66532f493c18b4e64a0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"resulting in requests being sent to unhealthy servers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Revision:"},{"line_number":14,"context_line":"- Fix Merge Conflicts in Keystone"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implemented for services I currently use."},{"line_number":17,"context_line":"- Barbican (OPTIONS to /, expects 2XX or 3XX)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"0e777a88_60884763","line":14,"updated":"2024-08-08 11:26:17.000000000","message":"Revisions are tracked in gerrit, no need to add this to the commit message, please remove","commit_id":"341498329f0304aa0127079ca9476511196844ff"},{"author":{"_account_id":37014,"name":"Aravindh Murugesan","display_name":"Aravindh Murugesan","email":"aravindhstanley@gmail.com","username":"aravindh_m"},"change_message_id":"faed316f9e546d44ff4a9eadccc7af6331cc832f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"resulting in requests being sent to unhealthy servers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Revision:"},{"line_number":14,"context_line":"- Fix Merge Conflicts in Keystone"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implemented for services I currently use."},{"line_number":17,"context_line":"- Barbican (OPTIONS to /, expects 2XX or 3XX)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"76f85613_3c364c37","line":14,"in_reply_to":"0e777a88_60884763","updated":"2024-08-28 07:47:15.000000000","message":"Removed this.","commit_id":"341498329f0304aa0127079ca9476511196844ff"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2b2fe9340ee3eaa83c3df66532f493c18b4e64a0","unresolved":true,"context_lines":[{"line_number":23,"context_line":"- Keystone (OPTIONS to /, expects 2XX or 3XX)"},{"line_number":24,"context_line":"- Nova API and Metadata (OPTIONS to /, expects 2XX or 3XX)"},{"line_number":25,"context_line":"- Placement (GET to /, expects 2XX or 3XX)"},{"line_number":26,"context_line":"- Skyline API (OPTIONS to /docs, expects 2XX or 3XX)"},{"line_number":27,"context_line":"- Skyline Console (GET to /, expects 2XX or 3XX)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"In next phase, I will enable missing services and update them."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"631a83c3_62498501","line":26,"updated":"2024-08-08 11:26:17.000000000","message":"from the code you are doing a \"GET\" here, too?","commit_id":"341498329f0304aa0127079ca9476511196844ff"},{"author":{"_account_id":37014,"name":"Aravindh Murugesan","display_name":"Aravindh Murugesan","email":"aravindhstanley@gmail.com","username":"aravindh_m"},"change_message_id":"faed316f9e546d44ff4a9eadccc7af6331cc832f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"- Keystone (OPTIONS to /, expects 2XX or 3XX)"},{"line_number":24,"context_line":"- Nova API and Metadata (OPTIONS to /, expects 2XX or 3XX)"},{"line_number":25,"context_line":"- Placement (GET to /, expects 2XX or 3XX)"},{"line_number":26,"context_line":"- Skyline API (OPTIONS to /docs, expects 2XX or 3XX)"},{"line_number":27,"context_line":"- Skyline Console (GET to /, expects 2XX or 3XX)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"In next phase, I will enable missing services and update them."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"30f63740_68a921c0","line":26,"in_reply_to":"631a83c3_62498501","updated":"2024-08-28 07:47:15.000000000","message":"GET to /docs is the only public endpoint I could find.","commit_id":"341498329f0304aa0127079ca9476511196844ff"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":37014,"name":"Aravindh Murugesan","display_name":"Aravindh Murugesan","email":"aravindhstanley@gmail.com","username":"aravindh_m"},"change_message_id":"aec22f4c56aa97794914ff8e2f8d94ea8ebe2c7e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"87afd202_b1685611","updated":"2024-05-08 17:45:05.000000000","message":"Alright, I will factor this for individual services that use HTTP.","commit_id":"cf6d9bdfb2c274ed59a606c782c2b142247e1ecb"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0081c899e062cb93af3728e9605cfe8edabcf045","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9800950a_76922755","updated":"2024-05-08 13:36:01.000000000","message":"We discussed this during todays kolla meeting and came to the following conclusion:\n\nCould you split this patchset up into one per service instead of enabling this globally for every service?\n\nThis way this can be tested in a simpler way and we should maybe not enable this for all services globally that don\u0027t support http.\n\nThank you.","commit_id":"cf6d9bdfb2c274ed59a606c782c2b142247e1ecb"},{"author":{"_account_id":37014,"name":"Aravindh Murugesan","display_name":"Aravindh Murugesan","email":"aravindhstanley@gmail.com","username":"aravindh_m"},"change_message_id":"7dd8eb7fea3dd2b0815021159ca94e0aaa5aef60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3c3a4d5b_cae1b4c2","in_reply_to":"29ab60f6_b630fa07","updated":"2024-05-13 02:22:11.000000000","message":"Acknowledged","commit_id":"cf6d9bdfb2c274ed59a606c782c2b142247e1ecb"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"18fc02380396daaa0600e19f93c0b11ba35a1638","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1ce732f8_8ec9485a","in_reply_to":"87afd202_b1685611","updated":"2024-05-14 10:03:16.000000000","message":"Thanks!","commit_id":"cf6d9bdfb2c274ed59a606c782c2b142247e1ecb"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d762abc45d4908d0d47204e4002d7fe9419b3ab6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"29ab60f6_b630fa07","in_reply_to":"9800950a_76922755","updated":"2024-05-08 15:17:31.000000000","message":"This was meant to be unresolved, sorry.","commit_id":"cf6d9bdfb2c274ed59a606c782c2b142247e1ecb"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2d80b74c4d7eac81f2f1ce0902fce1853c7cc505","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9dfb3595_2756f7b0","updated":"2024-06-26 16:18:25.000000000","message":"-1 Because I would like to see one commit for all services ..why to divide it ?","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":37014,"name":"Aravindh Murugesan","display_name":"Aravindh Murugesan","email":"aravindhstanley@gmail.com","username":"aravindh_m"},"change_message_id":"854181d53381f11d48388f6901d7b64371d0350e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"24ebd12f_6e3be73c","updated":"2024-05-30 11:18:21.000000000","message":"Alright, I will wait for the keystone patch to be merged and then update the keystone config file. Thanks","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":37014,"name":"Aravindh Murugesan","display_name":"Aravindh Murugesan","email":"aravindhstanley@gmail.com","username":"aravindh_m"},"change_message_id":"7dd8eb7fea3dd2b0815021159ca94e0aaa5aef60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c60044e0_bc8ddfc7","updated":"2024-05-13 02:22:11.000000000","message":"Implementated for individual services, starting with the commonly used ones.","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7679a540c15b8f42d5fddc34f70258fa84da8c40","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f17b34c2_cad46423","updated":"2024-05-28 09:29:52.000000000","message":"This is a new feature, we should imho first merge the fix for the broken balancer config for keystone and depend on that here:\n\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/913908\n\nso I overall like this patch, but it should be refactored on top of the above and we should merge the above asap imho.","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"44ef3c311a3cd65921861c15289627d8234585b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"97ffc6d4_d45c358b","updated":"2024-06-27 15:11:46.000000000","message":"it\u0027s still master right ?","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6aa6ee974a50e501cbdaec2eaf4812c1b5ceeeb4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ac557dd7_0472907d","in_reply_to":"892a648c_8c45e57f","updated":"2024-06-27 15:17:18.000000000","message":"this would also be fine with me I guess. as far as I remember we have even healthcheck tests running in CI so we should see if there is breakage.","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ec15a0eb36a9bb48888ee24a847a3109889a0584","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ca2ac7ca_dd7b3566","in_reply_to":"9dfb3595_2756f7b0","updated":"2024-06-27 14:42:16.000000000","message":"That\u0027s funny :D Afaik (it has been some days, would need to check IRC logs) we debated this on IRC with @mnasiadka@gmail.com and the conclusion was to introduce this slowly one service at a time, if I remember correctly, so we can easier test and revert if we break something in the process.\n\nPlease correct me if I misremember something.","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"097d0bae6871d9883c8ab0606011c6e9bb100495","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2fa84041_6b64897e","in_reply_to":"ac557dd7_0472907d","updated":"2024-08-05 07:37:47.000000000","message":"nobody else objected so I guess it\u0027s fine to merge this in one patch.","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"bba7a29ebf28f923d8aa4579e754e2e0f553eb2e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"892a648c_8c45e57f","in_reply_to":"ca2ac7ca_dd7b3566","updated":"2024-06-27 15:11:34.000000000","message":"well, I didn\u0027t see.. but you are probably right that this discussion happened. But I will not change my opinion, we have CI which should pass or not.","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":37014,"name":"Aravindh Murugesan","display_name":"Aravindh Murugesan","email":"aravindhstanley@gmail.com","username":"aravindh_m"},"change_message_id":"a78ad790b1dd76575ded42a5977a649191b34fb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3ec7f099_b69b35ed","in_reply_to":"f17b34c2_cad46423","updated":"2024-08-02 16:01:07.000000000","message":"I have now rebased it on top of the Keystone Changes that were merged recently.","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":37014,"name":"Aravindh Murugesan","display_name":"Aravindh Murugesan","email":"aravindhstanley@gmail.com","username":"aravindh_m"},"change_message_id":"a78ad790b1dd76575ded42a5977a649191b34fb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8d659c0e_7e07a3ba","updated":"2024-08-02 16:01:07.000000000","message":"How do we proceed now? Try to see if CI catches any error or should I break it up to individual changes for each services? Or Single Patch like Maksim suggested? Let me know. I\u0027m open to feedback.","commit_id":"3abcc0fc205b3efde6cdd4e53edaae4b9d906d1d"},{"author":{"_account_id":37014,"name":"Aravindh Murugesan","display_name":"Aravindh Murugesan","email":"aravindhstanley@gmail.com","username":"aravindh_m"},"change_message_id":"cc76df95dd8896b25d126d9bd3292bd97ba64d57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2cc114fa_a60dd0c2","updated":"2024-08-05 14:46:31.000000000","message":"Sorry, my bad. It was a mistake","commit_id":"3abcc0fc205b3efde6cdd4e53edaae4b9d906d1d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f8de5bec907b5f97e539bae992dae6b90cc554ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c9c256e6_dfd1804d","in_reply_to":"2cc114fa_a60dd0c2","updated":"2024-08-05 15:18:10.000000000","message":"no worries, we all do, that\u0027s why we do code reviews :)","commit_id":"3abcc0fc205b3efde6cdd4e53edaae4b9d906d1d"},{"author":{"_account_id":37014,"name":"Aravindh Murugesan","display_name":"Aravindh Murugesan","email":"aravindhstanley@gmail.com","username":"aravindh_m"},"change_message_id":"f17d8e6c8a639eb097923e8b9b8933a4b8d9dfd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"817db7a5_572b36d6","updated":"2024-08-05 14:53:58.000000000","message":"Fixed it.","commit_id":"341498329f0304aa0127079ca9476511196844ff"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2b2fe9340ee3eaa83c3df66532f493c18b4e64a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d08f0768_cff84ba6","updated":"2024-08-08 11:26:17.000000000","message":"I agree that this should be done consistently for all services. I would prefer if there was a way to set the default check parameters globally, so that the per-service override would only be needed in those places that don\u0027t use the default check.","commit_id":"341498329f0304aa0127079ca9476511196844ff"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f8de5bec907b5f97e539bae992dae6b90cc554ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e30e0f1f_d8436e84","updated":"2024-08-05 15:18:10.000000000","message":"LGTM :)","commit_id":"341498329f0304aa0127079ca9476511196844ff"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"079bff164b355abf67f01c200f42b66cf23dbe1f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"37786340_6c9b56db","updated":"2024-08-08 09:50:17.000000000","message":"We should do that for all services in one patch - so please add the rest of services to that patch.\nDo we need to support disabling L7 health checks?","commit_id":"341498329f0304aa0127079ca9476511196844ff"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"32cfe46c0cd4417f813786c745ae2150326a5453","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ee504b85_7d510b61","in_reply_to":"37786340_6c9b56db","updated":"2024-08-08 11:12:55.000000000","message":"\u003e Do we need to support disabling L7 health checks?\n\nI personally can\u0027t envision a use case for that, which doesn\u0027t mean it doesn\u0027t exist.\n\nIf we would do that we should put a warning beside it, that this might be resulting in traffic being sent to unhealthy servers imho.\n\nSo if there is no strong reason presented for it, I would like to not implement that additional logic.\n\nOne reason, thinking about it, could be, to have an easy fallback if we encounter issues with L7 healthchecks instead of the currently used L4 checks. Not sure how important that really is, though.","commit_id":"341498329f0304aa0127079ca9476511196844ff"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"15c13c135561d71d1c7133e53068885c1fe51ebb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"eb273470_c350ba69","in_reply_to":"ee504b85_7d510b61","updated":"2024-12-20 11:18:44.000000000","message":"Done","commit_id":"341498329f0304aa0127079ca9476511196844ff"},{"author":{"_account_id":37014,"name":"Aravindh Murugesan","display_name":"Aravindh Murugesan","email":"aravindhstanley@gmail.com","username":"aravindh_m"},"change_message_id":"f53448a77e1b5b69432dd3416b74e32805bb00ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7f2b2111_f5721b53","updated":"2024-08-28 07:56:44.000000000","message":"I have a hard time deploying Cloudkitty in my local lab to test the public endpoint. So if you know any public endpoints for cloudkitty, please let me know.","commit_id":"d36f973acd5707391acba091d3729d680f0e2ddb"},{"author":{"_account_id":37014,"name":"Aravindh Murugesan","display_name":"Aravindh Murugesan","email":"aravindhstanley@gmail.com","username":"aravindh_m"},"change_message_id":"faed316f9e546d44ff4a9eadccc7af6331cc832f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"34301d1c_433390c3","updated":"2024-08-28 07:47:15.000000000","message":"Updated the patch to support few other services.","commit_id":"d36f973acd5707391acba091d3729d680f0e2ddb"},{"author":{"_account_id":37014,"name":"Aravindh Murugesan","display_name":"Aravindh Murugesan","email":"aravindhstanley@gmail.com","username":"aravindh_m"},"change_message_id":"fe7e8d5bc1a565e774380bcab58c59efdd728ab1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"fe1f352d_1d8a75e7","updated":"2024-08-29 07:25:53.000000000","message":"I would like some assistance to test Cloudkitty and Ironic. If you have it deployed in your environment, could you please try sending an OPTIONS call to / and let me know what status code is returned. \n\ncurl -X OPTIONS http(s)://\u003cKOLLA_VIP\u003e:8889 -vk\ncurl -X OPTIONS http(s)://\u003cKOLLA_VIP\u003e:6385 -vk","commit_id":"71043d9953ed6effc3ac80dc803e726729b90c3e"},{"author":{"_account_id":37014,"name":"Aravindh Murugesan","display_name":"Aravindh Murugesan","email":"aravindhstanley@gmail.com","username":"aravindh_m"},"change_message_id":"ced62ea92e84c351788448b6aa8022cd4e6b6296","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d56a5e4a_307bb058","in_reply_to":"941e8458_90505b55","updated":"2024-08-29 09:32:44.000000000","message":"Thanks Matt. I have enabled HTTP Check for both these services.","commit_id":"71043d9953ed6effc3ac80dc803e726729b90c3e"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"a7ef07bd2597c1d5387fabf58a453d753d72fc96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"941e8458_90505b55","in_reply_to":"fe1f352d_1d8a75e7","updated":"2024-08-29 09:02:21.000000000","message":"Just ran these curls, both CloudKitty and Ironic return 200 status codes.","commit_id":"71043d9953ed6effc3ac80dc803e726729b90c3e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d38fdc2b949aab9d5a12918beab0d0d23a9eb053","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"973f13fe_02c4125c","updated":"2024-08-29 11:31:36.000000000","message":"The code LGTM, but as this is a user facing change imho you should add a releasenote quickly summarizing the change, like is done in the commit message, but without explicitly listing every service imho.\n\nYou can add a new release note via this command: `tox -e venv -- reno new $slug` where `$slug` must be changed to an abbreviation of the change, e.g. `tox -e venv -- reno new haproxy_healtchecks_switched_to_l7`\n\nThis will create a new release note file in the appropriate folder which you can then edit. You can take a look at the docs on the syntax of the release notes, e.g. here:\n\nhttps://docs.openstack.org/reno/latest/user/usage.html#editing-a-release-note\n\nI\u0027d suggest to look at present examples on what exactly to write.\n\nHTH","commit_id":"8e8d9257f699112e0ca2448778998c41bf426906"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2db3e6b1da955d93614e1abfcba58733ed7fe0b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"317aa4b2_1cfd6a4f","in_reply_to":"973f13fe_02c4125c","updated":"2024-08-29 17:12:52.000000000","message":"Done","commit_id":"8e8d9257f699112e0ca2448778998c41bf426906"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"aaf113e196d8519783f6165724fe03fefedc527b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"ba94da37_2cfc9168","updated":"2024-09-05 11:33:24.000000000","message":"What about to download haproxy status page in CI so we will be able to check the results of new checks if it is down or not ?","commit_id":"bf85ee6b3cd265ea503d853eb9f21f9b0f952f34"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c143c18ba8356556f04d498d296ad7974363530d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"df1582a1_5731c2cf","in_reply_to":"ba94da37_2cfc9168","updated":"2024-09-06 07:36:53.000000000","message":"I was under the impression the multinode CI setups already do the usual haproxy healthchecks and CI would turn red if they don\u0027t succeed (for at least one backend), no?","commit_id":"bf85ee6b3cd265ea503d853eb9f21f9b0f952f34"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3e54007c6dee42018b76e26f88bc685038de0bec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"b858d9ed_ea93659a","updated":"2024-12-20 08:18:33.000000000","message":"just fixed the merge conflicts, let\u0027s try to move ahead with this","commit_id":"70279972b6afd75a5755054f51840a376b7cd0b9"}],"ansible/roles/haproxy-config/defaults/main.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e43b391e96bbfcfff7a93d9a19f21bb7d8913032","unresolved":true,"context_lines":[{"line_number":8,"context_line":"haproxy_frontend_redirect_extra: []"},{"line_number":9,"context_line":"haproxy_frontend_tcp_extra:"},{"line_number":10,"context_line":"  - \"option tcplog\""},{"line_number":11,"context_line":"haproxy_backend_http_extra:"},{"line_number":12,"context_line":"  - \"option httpchk\""},{"line_number":13,"context_line":"  - \"http-check expect ! rstatus ^5(?!01)\""},{"line_number":14,"context_line":"haproxy_backend_tcp_extra: []"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"haproxy_health_check: \"check inter 2000 rise 2 fall 5\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6ce5d947_07e26ea2","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":42},"updated":"2024-05-07 12:55:59.000000000","message":"Thanks for your first contribution!\n\nI\u0027m currently looking at upstream (haproxy) docs and our current implementation, as I\u0027m not 100% sure we want to enable this globally for all backend checks, for various reasons:\n\n- I\u0027m not sure if all services even speak http (I hope the CI run will maybe report something in that direction).\n- We currently have a dedicated http check for mariadb, see here: https://opendev.org/openstack/kolla-ansible/src/branch/master/ansible/roles/mariadb/defaults/main.yml#L28 and I\u0027m not sure what happens if we define that check twice.\nBut that seems to be the only dedicated httpchk that I could find.\n- The accepted status code range _might_ be problematic, but I don\u0027t really know. For certain scenarios we also might want to consider status codes in the 400 range to be problematic, but we could configure that on a per service level, I suppose.","commit_id":"e3d7c5725c1336d31903bcad236b3af8daafde81"},{"author":{"_account_id":37014,"name":"Aravindh Murugesan","display_name":"Aravindh Murugesan","email":"aravindhstanley@gmail.com","username":"aravindh_m"},"change_message_id":"7dd8eb7fea3dd2b0815021159ca94e0aaa5aef60","unresolved":false,"context_lines":[{"line_number":8,"context_line":"haproxy_frontend_redirect_extra: []"},{"line_number":9,"context_line":"haproxy_frontend_tcp_extra:"},{"line_number":10,"context_line":"  - \"option tcplog\""},{"line_number":11,"context_line":"haproxy_backend_http_extra:"},{"line_number":12,"context_line":"  - \"option httpchk\""},{"line_number":13,"context_line":"  - \"http-check expect ! rstatus ^5(?!01)\""},{"line_number":14,"context_line":"haproxy_backend_tcp_extra: []"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"haproxy_health_check: \"check inter 2000 rise 2 fall 5\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"be07241d_88b23c20","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":42},"in_reply_to":"31c88e5c_da986d21","updated":"2024-05-13 02:22:11.000000000","message":"Acknowledged","commit_id":"e3d7c5725c1336d31903bcad236b3af8daafde81"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ea30a0b82877e956481eb38eac536df085397d6b","unresolved":true,"context_lines":[{"line_number":8,"context_line":"haproxy_frontend_redirect_extra: []"},{"line_number":9,"context_line":"haproxy_frontend_tcp_extra:"},{"line_number":10,"context_line":"  - \"option tcplog\""},{"line_number":11,"context_line":"haproxy_backend_http_extra:"},{"line_number":12,"context_line":"  - \"option httpchk\""},{"line_number":13,"context_line":"  - \"http-check expect ! rstatus ^5(?!01)\""},{"line_number":14,"context_line":"haproxy_backend_tcp_extra: []"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"haproxy_health_check: \"check inter 2000 rise 2 fall 5\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"31c88e5c_da986d21","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":42},"in_reply_to":"6ce5d947_07e26ea2","updated":"2024-05-07 13:04:38.000000000","message":"so my first point about all services (maybe not) speaking http might not be an issue, according to the haproxy docs, which state:\n\n\u003e \"httpchk\" option does not necessarily require an HTTP backend, it also works\nwith plain TCP backends. [...]\n\nhttps://www.haproxy.com/documentation/haproxy-configuration-manual/2-8r1/#4.2-option%20httpchk","commit_id":"e3d7c5725c1336d31903bcad236b3af8daafde81"}],"ansible/roles/keystone/defaults/main.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"18fc02380396daaa0600e19f93c0b11ba35a1638","unresolved":true,"context_lines":[{"line_number":18,"context_line":"        listen_port: \"{{ keystone_internal_listen_port }}\""},{"line_number":19,"context_line":"        backend_http_extra:"},{"line_number":20,"context_line":"          - \"option httpchk\""},{"line_number":21,"context_line":"          - balance \"{{ \u0027source\u0027 if enable_keystone_federation | bool else \u0027roundrobin\u0027 }}\""},{"line_number":22,"context_line":"      keystone_external:"},{"line_number":23,"context_line":"        enabled: \"{{ enable_keystone }}\""},{"line_number":24,"context_line":"        mode: \"http\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"2abb8da2_cfb58d71","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":2},"updated":"2024-05-14 10:03:16.000000000","message":"not sure if this works this way, there was a recent bug in this area so imho need to double check that this is correct.","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7679a540c15b8f42d5fddc34f70258fa84da8c40","unresolved":true,"context_lines":[{"line_number":18,"context_line":"        listen_port: \"{{ keystone_internal_listen_port }}\""},{"line_number":19,"context_line":"        backend_http_extra:"},{"line_number":20,"context_line":"          - \"option httpchk\""},{"line_number":21,"context_line":"          - balance \"{{ \u0027source\u0027 if enable_keystone_federation | bool else \u0027roundrobin\u0027 }}\""},{"line_number":22,"context_line":"      keystone_external:"},{"line_number":23,"context_line":"        enabled: \"{{ enable_keystone }}\""},{"line_number":24,"context_line":"        mode: \"http\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"d90d8182_150f17eb","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":2},"in_reply_to":"2abb8da2_cfb58d71","updated":"2024-05-28 09:29:52.000000000","message":"I\u0027m talking about this:\n\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/913908\n\nBut you actually incorporated that fix here, we may want to merge the fix itself before, so we can backport it.","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"097d0bae6871d9883c8ab0606011c6e9bb100495","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        listen_port: \"{{ keystone_internal_listen_port }}\""},{"line_number":19,"context_line":"        backend_http_extra:"},{"line_number":20,"context_line":"          - \"option httpchk\""},{"line_number":21,"context_line":"          - balance \"{{ \u0027source\u0027 if enable_keystone_federation | bool else \u0027roundrobin\u0027 }}\""},{"line_number":22,"context_line":"      keystone_external:"},{"line_number":23,"context_line":"        enabled: \"{{ enable_keystone }}\""},{"line_number":24,"context_line":"        mode: \"http\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"c8ea85cd_65675643","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":2},"in_reply_to":"d90d8182_150f17eb","updated":"2024-08-05 07:37:47.000000000","message":"Done","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"18fc02380396daaa0600e19f93c0b11ba35a1638","unresolved":true,"context_lines":[{"line_number":29,"context_line":"        listen_port: \"{{ keystone_public_listen_port }}\""},{"line_number":30,"context_line":"        backend_http_extra:"},{"line_number":31,"context_line":"          - \"option httpchk\""},{"line_number":32,"context_line":"          - balance \"{{ \u0027source\u0027 if enable_keystone_federation | bool else \u0027roundrobin\u0027 }}\""},{"line_number":33,"context_line":"  keystone-ssh:"},{"line_number":34,"context_line":"    container_name: \"keystone_ssh\""},{"line_number":35,"context_line":"    group: \"keystone\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"c2c6d7ec_8dfbeded","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":2},"updated":"2024-05-14 10:03:16.000000000","message":"see above","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"097d0bae6871d9883c8ab0606011c6e9bb100495","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        listen_port: \"{{ keystone_public_listen_port }}\""},{"line_number":30,"context_line":"        backend_http_extra:"},{"line_number":31,"context_line":"          - \"option httpchk\""},{"line_number":32,"context_line":"          - balance \"{{ \u0027source\u0027 if enable_keystone_federation | bool else \u0027roundrobin\u0027 }}\""},{"line_number":33,"context_line":"  keystone-ssh:"},{"line_number":34,"context_line":"    container_name: \"keystone_ssh\""},{"line_number":35,"context_line":"    group: \"keystone\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b7b5734f_b3efd983","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":2},"in_reply_to":"c2c6d7ec_8dfbeded","updated":"2024-08-05 07:37:47.000000000","message":"Acknowledged","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"097d0bae6871d9883c8ab0606011c6e9bb100495","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        tls_backend: \"{{ keystone_enable_tls_backend }}\""},{"line_number":28,"context_line":"        port: \"{{ keystone_public_port }}\""},{"line_number":29,"context_line":"        listen_port: \"{{ keystone_public_listen_port }}\""},{"line_number":30,"context_line":"        backend_http_extra: \"{{ [\u0027balance source\u0027] if enable_keystone_federation | bool else [] }}\""},{"line_number":31,"context_line":"  keystone-ssh:"},{"line_number":32,"context_line":"    container_name: \"keystone_ssh\""},{"line_number":33,"context_line":"    group: \"keystone\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9170566f_88bfec31","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":2},"updated":"2024-08-05 07:37:47.000000000","message":"```suggestion\n         - \"option httpchk\"\n          - balance \"{{ \u0027source\u0027 if enable_keystone_federation | bool else \u0027roundrobin\u0027 }}\"\n```\nor am I missing something?","commit_id":"3abcc0fc205b3efde6cdd4e53edaae4b9d906d1d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a5eed13971783cedd78030559411febced95fd0e","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        tls_backend: \"{{ keystone_enable_tls_backend }}\""},{"line_number":28,"context_line":"        port: \"{{ keystone_public_port }}\""},{"line_number":29,"context_line":"        listen_port: \"{{ keystone_public_listen_port }}\""},{"line_number":30,"context_line":"        backend_http_extra: \"{{ [\u0027balance source\u0027] if enable_keystone_federation | bool else [] }}\""},{"line_number":31,"context_line":"  keystone-ssh:"},{"line_number":32,"context_line":"    container_name: \"keystone_ssh\""},{"line_number":33,"context_line":"    group: \"keystone\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a5b9da79_17955af6","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":2},"in_reply_to":"9170566f_88bfec31","updated":"2024-08-05 07:39:15.000000000","message":"sorry, I meant:\n\n```suggestion\n        backend_http_extra:\n          - \"option httpchk\"\n          - balance \"{{ \u0027source\u0027 if enable_keystone_federation | bool else \u0027roundrobin\u0027 }}\"\n```\nobviously","commit_id":"3abcc0fc205b3efde6cdd4e53edaae4b9d906d1d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f8de5bec907b5f97e539bae992dae6b90cc554ba","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        tls_backend: \"{{ keystone_enable_tls_backend }}\""},{"line_number":28,"context_line":"        port: \"{{ keystone_public_port }}\""},{"line_number":29,"context_line":"        listen_port: \"{{ keystone_public_listen_port }}\""},{"line_number":30,"context_line":"        backend_http_extra: \"{{ [\u0027balance source\u0027] if enable_keystone_federation | bool else [] }}\""},{"line_number":31,"context_line":"  keystone-ssh:"},{"line_number":32,"context_line":"    container_name: \"keystone_ssh\""},{"line_number":33,"context_line":"    group: \"keystone\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"323dfdec_2bb70e5e","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":2},"in_reply_to":"a5b9da79_17955af6","updated":"2024-08-05 15:18:10.000000000","message":"Done","commit_id":"3abcc0fc205b3efde6cdd4e53edaae4b9d906d1d"},{"author":{"_account_id":37014,"name":"Aravindh Murugesan","display_name":"Aravindh Murugesan","email":"aravindhstanley@gmail.com","username":"aravindh_m"},"change_message_id":"faed316f9e546d44ff4a9eadccc7af6331cc832f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        tls_backend: \"{{ keystone_enable_tls_backend }}\""},{"line_number":28,"context_line":"        port: \"{{ keystone_public_port }}\""},{"line_number":29,"context_line":"        listen_port: \"{{ keystone_public_listen_port }}\""},{"line_number":30,"context_line":"        backend_http_extra: \"{{ [\u0027balance source\u0027] if enable_keystone_federation | bool else [] }}\""},{"line_number":31,"context_line":"  keystone-ssh:"},{"line_number":32,"context_line":"    container_name: \"keystone_ssh\""},{"line_number":33,"context_line":"    group: \"keystone\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"91c4ecb5_c7a55d60","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":2},"in_reply_to":"a5b9da79_17955af6","updated":"2024-08-28 07:47:15.000000000","message":"Done","commit_id":"3abcc0fc205b3efde6cdd4e53edaae4b9d906d1d"}],"ansible/roles/skyline/defaults/main.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"18fc02380396daaa0600e19f93c0b11ba35a1638","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        listen_port: \"{{ skyline_apiserver_listen_port }}\""},{"line_number":18,"context_line":"        tls_backend: \"{{ skyline_enable_tls_backend }}\""},{"line_number":19,"context_line":"        backend_http_extra:"},{"line_number":20,"context_line":"          - \"option httpchk GET /docs\""},{"line_number":21,"context_line":"      skyline_apiserver_external:"},{"line_number":22,"context_line":"        enabled: \"{{ enable_skyline }}\""},{"line_number":23,"context_line":"        mode: \"http\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"aa9a849f_12484ac8","line":20,"range":{"start_line":20,"start_character":33,"end_line":20,"end_character":37},"updated":"2024-05-14 10:03:16.000000000","message":"Can you explain why check for \"docs\" here? Thanks!","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7679a540c15b8f42d5fddc34f70258fa84da8c40","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        listen_port: \"{{ skyline_apiserver_listen_port }}\""},{"line_number":18,"context_line":"        tls_backend: \"{{ skyline_enable_tls_backend }}\""},{"line_number":19,"context_line":"        backend_http_extra:"},{"line_number":20,"context_line":"          - \"option httpchk GET /docs\""},{"line_number":21,"context_line":"      skyline_apiserver_external:"},{"line_number":22,"context_line":"        enabled: \"{{ enable_skyline }}\""},{"line_number":23,"context_line":"        mode: \"http\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bdaef708_e9db1ddd","line":20,"range":{"start_line":20,"start_character":33,"end_line":20,"end_character":37},"in_reply_to":"0629a254_d5871db5","updated":"2024-05-28 09:29:52.000000000","message":"I think it\u0027s a decent workaround. We could also construct an authorization header, which imho is also only a workaround.\n\nA healthcheck should really be unauthenticated imho, because if it\u0027s behind auth it really is not only testing the HTTP connection but rather the auth working, which is a different thing.\n\nmarking as resolved.","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":37014,"name":"Aravindh Murugesan","display_name":"Aravindh Murugesan","email":"aravindhstanley@gmail.com","username":"aravindh_m"},"change_message_id":"799198eeeaf62639e79093061bd240677efe691d","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        listen_port: \"{{ skyline_apiserver_listen_port }}\""},{"line_number":18,"context_line":"        tls_backend: \"{{ skyline_enable_tls_backend }}\""},{"line_number":19,"context_line":"        backend_http_extra:"},{"line_number":20,"context_line":"          - \"option httpchk GET /docs\""},{"line_number":21,"context_line":"      skyline_apiserver_external:"},{"line_number":22,"context_line":"        enabled: \"{{ enable_skyline }}\""},{"line_number":23,"context_line":"        mode: \"http\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"0629a254_d5871db5","line":20,"range":{"start_line":20,"start_character":33,"end_line":20,"end_character":37},"in_reply_to":"aa9a849f_12484ac8","updated":"2024-05-14 10:42:51.000000000","message":"Skyline API required authentication on /, so I used docs coz that returned a 200, but maybe its not a good idea huh?","commit_id":"af9b610754ad39cc49757ba702273cf9b5614ea8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2b2fe9340ee3eaa83c3df66532f493c18b4e64a0","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        listen_port: \"{{ skyline_apiserver_listen_port }}\""},{"line_number":18,"context_line":"        tls_backend: \"{{ skyline_enable_tls_backend }}\""},{"line_number":19,"context_line":"        backend_http_extra:"},{"line_number":20,"context_line":"          - \"option httpchk GET /docs\""},{"line_number":21,"context_line":"      skyline_apiserver_external:"},{"line_number":22,"context_line":"        enabled: \"{{ enable_skyline }}\""},{"line_number":23,"context_line":"        mode: \"http\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"2cbf967c_3363f3de","line":20,"updated":"2024-08-08 11:26:17.000000000","message":"I didn\u0027t check, but I would assume that /docs is some static content, is that really useful as healthcheck?","commit_id":"341498329f0304aa0127079ca9476511196844ff"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"372be211fc6c5e26bd40390b42e9ed533a4df1a8","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        listen_port: \"{{ skyline_apiserver_listen_port }}\""},{"line_number":18,"context_line":"        tls_backend: \"{{ skyline_enable_tls_backend }}\""},{"line_number":19,"context_line":"        backend_http_extra:"},{"line_number":20,"context_line":"          - \"option httpchk GET /docs\""},{"line_number":21,"context_line":"      skyline_apiserver_external:"},{"line_number":22,"context_line":"        enabled: \"{{ enable_skyline }}\""},{"line_number":23,"context_line":"        mode: \"http\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"73fe30cf_bc49a347","line":20,"in_reply_to":"2cbf967c_3363f3de","updated":"2024-08-08 15:57:16.000000000","message":"well, it\u0027s an http check, so it only checks if the webserver is working, not if the application behind that is working, which would be much more complicated I think.\n\nI personally haven\u0027t found a better endpoint that is available without authentication, but maybe someone from skyline does know?\n\nMaybe don\u0027t let perfect be the enemy of good? :)","commit_id":"341498329f0304aa0127079ca9476511196844ff"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9c6caad4cf953a0c986f80cab55d9cf3cea6b7e2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        listen_port: \"{{ skyline_apiserver_listen_port }}\""},{"line_number":18,"context_line":"        tls_backend: \"{{ skyline_enable_tls_backend }}\""},{"line_number":19,"context_line":"        backend_http_extra:"},{"line_number":20,"context_line":"          - \"option httpchk GET /docs\""},{"line_number":21,"context_line":"      skyline_apiserver_external:"},{"line_number":22,"context_line":"        enabled: \"{{ enable_skyline }}\""},{"line_number":23,"context_line":"        mode: \"http\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"b1b7ca6d_6a4cf1b7","line":20,"in_reply_to":"73fe30cf_bc49a347","updated":"2024-08-08 19:18:31.000000000","message":"Sure, I won\u0027t block this patch based on this detail, if this is the best currently known option, then I\u0027m fine with it.","commit_id":"341498329f0304aa0127079ca9476511196844ff"}]}