)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"94b2fb0a98aaa77e9fcf4531d37ed506bad87739","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Victor Chembaev \u003cchembervint@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-06-24 13:51:18 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix kolla systemd unit template to prevent restart all kolla services with docker.service restart"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I70dd1751dea6bfc9bb265aeda04b3392e135324c"},{"line_number":10,"context_line":"Closes-Bug: 2065168"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff5b1127_8cb94004","line":7,"updated":"2024-06-24 11:09:37.000000000","message":"Please wrap at 72 characters. https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"06b9452f3175d47510d5864de16e26dff7144fb0"},{"author":{"_account_id":32688,"name":"Victor Chembaev","email":"chembervint@gmail.com","username":"chembervint"},"change_message_id":"75207e5a2855c513aae55df38f93ef932387b2a6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Victor Chembaev \u003cchembervint@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-06-24 13:51:18 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix kolla systemd unit template to prevent restart all kolla services with docker.service restart"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I70dd1751dea6bfc9bb265aeda04b3392e135324c"},{"line_number":10,"context_line":"Closes-Bug: 2065168"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d864cfbd_5d2f70e5","line":7,"in_reply_to":"ff5b1127_8cb94004","updated":"2024-06-24 14:26:04.000000000","message":"Done","commit_id":"06b9452f3175d47510d5864de16e26dff7144fb0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"179a3ee98c03c826047b3821c078114a6dfa7c50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e4283813_c8b09019","updated":"2024-06-13 10:14:15.000000000","message":"@chembervint@gmail.com Would you amend the commit with the short description similar to reno?","commit_id":"c93815f72bf778c3078c82d048228491a2cf98ec"},{"author":{"_account_id":32688,"name":"Victor Chembaev","email":"chembervint@gmail.com","username":"chembervint"},"change_message_id":"21191cf3941ba60b4207fbf78b23fe3f64090ca2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"38b1aa81_d1dfbd23","in_reply_to":"e4283813_c8b09019","updated":"2024-06-24 11:04:19.000000000","message":"Thank you. I\u0027ve updated the commit message","commit_id":"c93815f72bf778c3078c82d048228491a2cf98ec"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fd323b155723e56dba77586e804ee543031ba7f9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bec228d3_bbdfc376","updated":"2024-06-27 14:34:59.000000000","message":"I didn\u0027t review this in time, but please, before backporting this, can we confirm this doesn\u0027t break anything?\n\nI have formulated some concerns in the linked bug report:\n\nhttps://bugs.launchpad.net/kolla-ansible/+bug/2065168/comments/22\n\nThanks","commit_id":"c0b0dddc393e69087797831c808508a6358b3c56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c0d179fa79d78383386ccdcce33618ac632ec2da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7e069bee_f903e624","updated":"2024-06-27 08:43:03.000000000","message":"recheck kolla-ansible-ubuntu-upgrade-cephadm","commit_id":"c0b0dddc393e69087797831c808508a6358b3c56"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"100aaf67de0822be25eea45c4bcc625be1881eba","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cb1cb841_ff58a5ec","in_reply_to":"27b9824b_9cb58e74","updated":"2024-06-27 16:29:26.000000000","message":"Sven, I\u0027m not sure I understand your issue. In your comment on the bug report you\u0027re arguing against the use of docker live-restore, but this patch doesn\u0027t enable that? It just fixes live-restore for those already using it.\n\nPerhaps I\u0027m missing something, but I don\u0027t see how this patch would cause you problems if you\u0027re not using live-restore already.","commit_id":"c0b0dddc393e69087797831c808508a6358b3c56"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7ea3a8bb519cb0c683845ff0cb216c84a3da750d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5a3b600f_9478055b","in_reply_to":"27b9824b_9cb58e74","updated":"2024-06-27 16:13:45.000000000","message":"We have been using that across different major Docker Engine versions - so let’s not go crazy.","commit_id":"c0b0dddc393e69087797831c808508a6358b3c56"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bdf1144c8a6b9d4427e0b7f46d458364c2dc0d0e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fc965a54_c28548a5","in_reply_to":"bec228d3_bbdfc376","updated":"2024-06-27 15:21:46.000000000","message":"Actually for those that use live restore it’s broken right now - because each Docker Engine restart does restart all containers.","commit_id":"c0b0dddc393e69087797831c808508a6358b3c56"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d1955568ad1114f84b60f365bcb40eb2af421160","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7f8e0b95_9b760fa9","in_reply_to":"cb1cb841_ff58a5ec","updated":"2024-06-28 07:24:17.000000000","message":"\u003e Sven, I\u0027m not sure I understand your issue. In your comment on the bug report you\u0027re arguing against the use of docker live-restore, but this patch doesn\u0027t enable that? It just fixes live-restore for those already using it.\n\u003e \n\u003e Perhaps I\u0027m missing something, but I don\u0027t see how this patch would cause you problems if you\u0027re not using live-restore already.\n\nI guess that is technically correct, so the best kind of correct. :-)\n\nI had no knowledge that anybody is using that already in production! So if you got experience with it, I\u0027m glad it works, it seems it\u0027s even enabled in our downstream as well, which I somehow missed (wrong grep I guess).\n\nSo apologies for making a fuzz.\n\nNevertheless it might cause problems if the docker daemon is down for extended periods of time, e.g. when an upgrade of the docker daemon didn\u0027t go well for users of live-restore and the containers are running for longer periods of time without being able to shuffle data over the docker pipe.\n\nSo it would\u0027ve been nice if anybody had tested that prior to merging it.\n\nMarking this as resolved.","commit_id":"c0b0dddc393e69087797831c808508a6358b3c56"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"24f5529d3b7da9bad1d77bff344a2ef601f3d12c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"27b9824b_9cb58e74","in_reply_to":"fc965a54_c28548a5","updated":"2024-06-27 15:30:15.000000000","message":"1. This doesn\u0027t answer any of my questions, really, so I conclude this was not tested on major docker version upgrades or longer downtimes of docker.service to see what/if something else breaks (worst case: all services).\n2. of course this fixes a bug for users of a certain feature, the question though is, if this is a minority/majority of users (I don\u0027t know), how bad the effect is, and how bad possibly untested different outcomes outside the \"happy path\" deployment are for other users, or even the very same users.\n\nThis patch also doesn\u0027t add any testing code to an inherent highly volatile area which is inherently vulnerable to race conditions (restarts of different services affecting each other) which is a very core area of our code.","commit_id":"c0b0dddc393e69087797831c808508a6358b3c56"}]}