)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e1af9ebd199acb4d1cf387592bb25b3d41aa6b66","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Crees \u003cmattc@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-06-21 12:56:20 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add command to upgrade to a target version of RMQ"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Required before a SLURP upgrade to Caracal"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8f7a27c0_842656ec","line":7,"updated":"2024-07-15 18:00:38.000000000","message":"Add [2023.1 only] or something like that","commit_id":"9cf5841c42d4404de96c3e8cc9e5569e7126772a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"a6114cb2be039dfdd6e25285146e9e69a7c0d688","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Crees \u003cmattc@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-06-21 12:56:20 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add command to upgrade to a target version of RMQ"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Required before a SLURP upgrade to Caracal"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fcc04903_131398de","line":7,"in_reply_to":"8f7a27c0_842656ec","updated":"2024-07-17 10:41:02.000000000","message":"Done","commit_id":"9cf5841c42d4404de96c3e8cc9e5569e7126772a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f601c7cf97f820e00ae86ac244ee66a0ebc89268","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"92322565_49bd4e23","updated":"2024-06-24 15:05:22.000000000","message":"one syntax error I guess, the rest LGTM","commit_id":"9cf5841c42d4404de96c3e8cc9e5569e7126772a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"43cd82e75fd4de9b59905a0c504325da269f2e2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e51f290c_b6e8a575","updated":"2024-08-01 14:57:03.000000000","message":"IMO this is also worth a releasenote that can link to the added doc snippet","commit_id":"b0383344f37c6ad244f7eba2fc059cd8cfe3767d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"69e07bfc419a440f46acb82819852e20633a0bfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d4b13a3f_67d3c782","updated":"2024-07-18 08:30:28.000000000","message":"code LGTM\n\nthere\u0027s an - I think - unrelated error in kolla-ansible-rocky9-upgrade-cephadm (non-voting)FAILURE during pull-upgrade phase.","commit_id":"b0383344f37c6ad244f7eba2fc059cd8cfe3767d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"d7aece20bddc6869ca4cbdd9e680a4403a4c6316","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1e0fdfbd_32f2dfa3","in_reply_to":"dd703c56_7b2daeea","updated":"2024-08-05 15:59:28.000000000","message":"Done","commit_id":"b0383344f37c6ad244f7eba2fc059cd8cfe3767d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"74c5d9b993780e50640b4a7921d96297b2fd8fd5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dd703c56_7b2daeea","in_reply_to":"e51f290c_b6e8a575","updated":"2024-08-05 15:21:08.000000000","message":"ack, marking as unresolved for now.","commit_id":"b0383344f37c6ad244f7eba2fc059cd8cfe3767d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"01c6b7ea7f8cf66159d2dd68687eb2cb53b5537b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d18a8ef2_f6caa27d","updated":"2024-08-12 10:11:16.000000000","message":"As discussed in the last meeting, this has been proposed into master first:\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/926124\n\nI\u0027ll update this as a backport once master is merged.","commit_id":"24cb8d3d2daf81e15cf100d453f6b97070ca8fa7"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b81177942d9bc26a96005238091223843408abaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9ede81bd_c87ea1b6","updated":"2024-08-06 08:59:13.000000000","message":"I wrote down some questions around this topic on the kolla-whiteboard:\n\nhttps://etherpad.opendev.org/p/KollaWhiteBoard#L81\n\nfor posterity I\u0027ll archive them here as well, but please maybe let us discuss those at the meeting and not on this code review, thus I mark this as \"resolved\" (even if it isn\u0027t), thanks!\n\n```\nHow do we want to handle slurp upgrades in the future?\n\n    currently it\u0027s afaik only planned to make a special upgrade command for 2023.1 release to upgrade rmq: https://review.opendev.org/c/openstack/kolla-ansible/+/918976\n\n    problem I see is: won\u0027t we need a similar change for the next slurp upgrade cycle as well, and wouldn\u0027t it thus make sense to add a generic slurp-upgrade command to master?\n\n    maybe I missed something or is the intent to just always provide one-off patches for the slurp releases to keep the master codebase lean?\n\n    It\u0027s also unclear to me how we handle the process when users set `rabbitmq_image` via global.yml, we need to handle these users during future upgrades, see comments on the patch.\n\n    what I mean by this: how do we make sure we don\u0027t forget a reno for slurp that users need to now change their rabbitmq_image var if they changed it, etc. do we possibly want to test this in CI slurp jobs maybe?\n```","commit_id":"24cb8d3d2daf81e15cf100d453f6b97070ca8fa7"}],"ansible/rabbitmq-upgrade.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"488f2708f67b5a6709d40e65457cd529642c8618","unresolved":true,"context_lines":[{"line_number":6,"context_line":"  gather_facts: false"},{"line_number":7,"context_line":"  max_fail_percentage: \u003e-"},{"line_number":8,"context_line":"    {{ group_hosts_max_fail_percentage |"},{"line_number":9,"context_line":"       default(kolla_max_fail_percentage) |"},{"line_number":10,"context_line":"       default(100) }}"},{"line_number":11,"context_line":"  tasks:"},{"line_number":12,"context_line":"    - name: Group hosts based on enabled services (RabbitMQ Only)"},{"line_number":13,"context_line":"      group_by:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2a82514c_3417308e","line":10,"range":{"start_line":9,"start_character":7,"end_line":10,"end_character":19},"updated":"2024-06-21 13:33:14.000000000","message":"why two defaults?","commit_id":"9cf5841c42d4404de96c3e8cc9e5569e7126772a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"d8664628bac0527e701344b2c101620d0670af29","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  gather_facts: false"},{"line_number":7,"context_line":"  max_fail_percentage: \u003e-"},{"line_number":8,"context_line":"    {{ group_hosts_max_fail_percentage |"},{"line_number":9,"context_line":"       default(kolla_max_fail_percentage) |"},{"line_number":10,"context_line":"       default(100) }}"},{"line_number":11,"context_line":"  tasks:"},{"line_number":12,"context_line":"    - name: Group hosts based on enabled services (RabbitMQ Only)"},{"line_number":13,"context_line":"      group_by:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"02096ba8_acc4c552","line":10,"range":{"start_line":9,"start_character":7,"end_line":10,"end_character":19},"in_reply_to":"2a82514c_3417308e","updated":"2024-06-21 16:01:44.000000000","message":"It\u0027s inherited from this patchset: https://review.opendev.org/c/openstack/kolla-ansible/+/805598\nSeems to have been required for keeping default behaviours there, and I saw no reason to change the format for a new feature","commit_id":"9cf5841c42d4404de96c3e8cc9e5569e7126772a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f601c7cf97f820e00ae86ac244ee66a0ebc89268","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"06391110_f13a85a4","line":22,"updated":"2024-06-24 15:05:22.000000000","message":"I guess ansible-lint doesn\u0027t like this empty line at the end of the file:\n\n```\n  22:1      error    syntax error: found unexpected end of stream (syntax)\n```","commit_id":"9cf5841c42d4404de96c3e8cc9e5569e7126772a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"a6114cb2be039dfdd6e25285146e9e69a7c0d688","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"81a5f0a4_ad42c9b9","line":22,"in_reply_to":"06391110_f13a85a4","updated":"2024-07-17 10:41:02.000000000","message":"I was missing the closing ``\"``","commit_id":"9cf5841c42d4404de96c3e8cc9e5569e7126772a"}],"doc/source/reference/message-queues/rabbitmq.rst":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"488f2708f67b5a6709d40e65457cd529642c8618","unresolved":true,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":".. code-block:: console"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"   kolla-ansible rabbitmq-upgrade 2-12"}],"source_content_type":"text/x-rst","patch_set":2,"id":"69fd6f86_7365a7ac","line":187,"range":{"start_line":187,"start_character":34,"end_line":187,"end_character":38},"updated":"2024-06-21 13:33:14.000000000","message":"why not?\n\n```suggestion\n   kolla-ansible rabbitmq-upgrade 2.12\n```","commit_id":"9cf5841c42d4404de96c3e8cc9e5569e7126772a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f601c7cf97f820e00ae86ac244ee66a0ebc89268","unresolved":true,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":".. code-block:: console"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"   kolla-ansible rabbitmq-upgrade 2-12"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d46729fb_f911c519","line":187,"range":{"start_line":187,"start_character":34,"end_line":187,"end_character":38},"in_reply_to":"65bc8d7e_210a20f8","updated":"2024-06-24 15:05:22.000000000","message":"well we don\u0027t usually encode versions in image names, as far as I can see this is in fact the first time we are doing this.\n\nFrom the end user perspective it seems a little weird to supply a version number with a dash, but I\u0027m not sure it\u0027s worth it to change this again, so decide for yourself, as I have no strong opinion on this. :)","commit_id":"9cf5841c42d4404de96c3e8cc9e5569e7126772a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"d8664628bac0527e701344b2c101620d0670af29","unresolved":true,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":".. code-block:: console"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"   kolla-ansible rabbitmq-upgrade 2-12"}],"source_content_type":"text/x-rst","patch_set":2,"id":"65bc8d7e_210a20f8","line":187,"range":{"start_line":187,"start_character":34,"end_line":187,"end_character":38},"in_reply_to":"69fd6f86_7365a7ac","updated":"2024-06-21 16:01:44.000000000","message":"This lets me directly pass the input in as a suffix to the image (see the depends-on patch). I was using hyphens as that\u0027s the convention for image names in kolla. \n\nI suppose I could change the command to take decimals instead?","commit_id":"9cf5841c42d4404de96c3e8cc9e5569e7126772a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"a6114cb2be039dfdd6e25285146e9e69a7c0d688","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":".. code-block:: console"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"   kolla-ansible rabbitmq-upgrade 2-12"}],"source_content_type":"text/x-rst","patch_set":2,"id":"655b13c1_a2604c18","line":187,"range":{"start_line":187,"start_character":34,"end_line":187,"end_character":38},"in_reply_to":"d46729fb_f911c519","updated":"2024-07-17 10:41:02.000000000","message":"If your initial expectation is to use dots, others will expect that too. I\u0027ve updated to do this instead.","commit_id":"9cf5841c42d4404de96c3e8cc9e5569e7126772a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"43cd82e75fd4de9b59905a0c504325da269f2e2d","unresolved":true,"context_lines":[{"line_number":175,"context_line":"RabbitMQ version 3.13. So if you want to perform a skip-level upgrade from"},{"line_number":176,"context_line":"Antelope to Caracal, you should first upgrade RabbitMQ to version 3.12, as"},{"line_number":177,"context_line":"RabbitMQ does not support jumping two versions in one upgrade. To do this,"},{"line_number":178,"context_line":"Kolla provides an Antelope RabbitMQ release with version 2.12. You can upgrade"},{"line_number":179,"context_line":"to this with the following command:"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":".. warning::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5e25266d_d5c03765","line":178,"range":{"start_line":178,"start_character":57,"end_line":178,"end_character":61},"updated":"2024-08-01 14:57:03.000000000","message":"3.12?","commit_id":"b0383344f37c6ad244f7eba2fc059cd8cfe3767d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"8ca6df0127c31b2c888ec062c4d3c22e19986469","unresolved":false,"context_lines":[{"line_number":175,"context_line":"RabbitMQ version 3.13. So if you want to perform a skip-level upgrade from"},{"line_number":176,"context_line":"Antelope to Caracal, you should first upgrade RabbitMQ to version 3.12, as"},{"line_number":177,"context_line":"RabbitMQ does not support jumping two versions in one upgrade. To do this,"},{"line_number":178,"context_line":"Kolla provides an Antelope RabbitMQ release with version 2.12. You can upgrade"},{"line_number":179,"context_line":"to this with the following command:"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":".. warning::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"2cc96cc9_23048a78","line":178,"range":{"start_line":178,"start_character":57,"end_line":178,"end_character":61},"in_reply_to":"5e25266d_d5c03765","updated":"2024-08-05 15:19:09.000000000","message":"Done","commit_id":"b0383344f37c6ad244f7eba2fc059cd8cfe3767d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"43cd82e75fd4de9b59905a0c504325da269f2e2d","unresolved":true,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":".. code-block:: console"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"   kolla-ansible rabbitmq-upgrade 2.12"}],"source_content_type":"text/x-rst","patch_set":3,"id":"e5a36acc_43028b95","line":187,"range":{"start_line":187,"start_character":34,"end_line":187,"end_character":38},"updated":"2024-08-01 14:57:03.000000000","message":"dito","commit_id":"b0383344f37c6ad244f7eba2fc059cd8cfe3767d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"8ca6df0127c31b2c888ec062c4d3c22e19986469","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":".. code-block:: console"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"   kolla-ansible rabbitmq-upgrade 2.12"}],"source_content_type":"text/x-rst","patch_set":3,"id":"118131a9_576de316","line":187,"range":{"start_line":187,"start_character":34,"end_line":187,"end_character":38},"in_reply_to":"e5a36acc_43028b95","updated":"2024-08-05 15:19:09.000000000","message":"Done","commit_id":"b0383344f37c6ad244f7eba2fc059cd8cfe3767d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8b3a601c3d0b2bcbb1214de294ab1d02428dcea4","unresolved":true,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"   kolla-ansible rabbitmq-upgrade 3.12"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Alternatively, you can set ``rabbitmq_image`` in your configuration"},{"line_number":190,"context_line":"``globals.yml`` for idempotence in deployments. See below for more details."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"RabbitMQ versions"},{"line_number":193,"context_line":"~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9d7ed6b4_88bef082","line":190,"range":{"start_line":189,"start_character":0,"end_line":190,"end_character":75},"updated":"2024-08-06 08:46:08.000000000","message":"I overlooked this, when looking at the \"RabbitMQ versions\" part.\n\nI think it should be moved directly to the code-block.\n\nImho the information where this change needs to be done should be part of what needs to change (so the next section).\n\nThanks.","commit_id":"24cb8d3d2daf81e15cf100d453f6b97070ca8fa7"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"96e3f1c704d2b06b28e28b0a0cc8fb5007b50a34","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"   kolla-ansible rabbitmq-upgrade 3.12"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Alternatively, you can set ``rabbitmq_image`` in your configuration"},{"line_number":190,"context_line":"``globals.yml`` for idempotence in deployments. See below for more details."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"RabbitMQ versions"},{"line_number":193,"context_line":"~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":4,"id":"82e16ec8_591a347b","line":190,"range":{"start_line":189,"start_character":0,"end_line":190,"end_character":75},"in_reply_to":"9d7ed6b4_88bef082","updated":"2024-08-12 10:12:34.000000000","message":"Done","commit_id":"24cb8d3d2daf81e15cf100d453f6b97070ca8fa7"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8b3a601c3d0b2bcbb1214de294ab1d02428dcea4","unresolved":true,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"As part of SLURP support, Kolla ships versions 3.11, 3.12 and 3.13 of RabbitMQ"},{"line_number":196,"context_line":"in Antelope. By default, Antelope Kolla-Ansible will deploy version 3.11. If"},{"line_number":197,"context_line":"you wish to deploy a later version, you must override the image. For example,"},{"line_number":198,"context_line":"version 3.12:"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":".. code-block:: yaml"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"824ad7cd_b7953676","line":198,"range":{"start_line":197,"start_character":65,"end_line":198,"end_character":13},"updated":"2024-08-06 08:46:08.000000000","message":"```suggestion\nyou wish to deploy a later version, you must override the image. For example,\nif you want to use version 3.12 change ``rabbitmq_image`` in ``globals.yml`` as follows:\n```","commit_id":"24cb8d3d2daf81e15cf100d453f6b97070ca8fa7"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"96e3f1c704d2b06b28e28b0a0cc8fb5007b50a34","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"As part of SLURP support, Kolla ships versions 3.11, 3.12 and 3.13 of RabbitMQ"},{"line_number":196,"context_line":"in Antelope. By default, Antelope Kolla-Ansible will deploy version 3.11. If"},{"line_number":197,"context_line":"you wish to deploy a later version, you must override the image. For example,"},{"line_number":198,"context_line":"version 3.12:"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":".. code-block:: yaml"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"b30a89c0_7c8a2034","line":198,"range":{"start_line":197,"start_character":65,"end_line":198,"end_character":13},"in_reply_to":"824ad7cd_b7953676","updated":"2024-08-12 10:12:34.000000000","message":"Done","commit_id":"24cb8d3d2daf81e15cf100d453f6b97070ca8fa7"}],"tools/kolla-ansible":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"43cd82e75fd4de9b59905a0c504325da269f2e2d","unresolved":true,"context_lines":[{"line_number":569,"context_line":"        RMQ_VERSION\u003d\"$2\""},{"line_number":570,"context_line":"        ACTION\u003d\"Upgrade to a specific version of RabbitMQ\""},{"line_number":571,"context_line":"        PLAYBOOK\u003d\"${BASEDIR}/ansible/rabbitmq-upgrade.yml\""},{"line_number":572,"context_line":"        EXTRA_OPTS\u003d\"$EXTRA_OPTS -e rabbitmq_version_suffix\u003d${RMQ_VERSION}\""},{"line_number":573,"context_line":"        ;;"},{"line_number":574,"context_line":"(bash-completion)"},{"line_number":575,"context_line":"        bash_completion"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"0d3ebc69_1b1905e4","line":572,"updated":"2024-08-01 14:57:03.000000000","message":"I\u0027m not sure that overriding the version via the commandline is a good idea, wouldn\u0027t it be better to have the operator place this into globals.yml in order to ensure consistent results?","commit_id":"b0383344f37c6ad244f7eba2fc059cd8cfe3767d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8b3a601c3d0b2bcbb1214de294ab1d02428dcea4","unresolved":true,"context_lines":[{"line_number":569,"context_line":"        RMQ_VERSION\u003d\"$2\""},{"line_number":570,"context_line":"        ACTION\u003d\"Upgrade to a specific version of RabbitMQ\""},{"line_number":571,"context_line":"        PLAYBOOK\u003d\"${BASEDIR}/ansible/rabbitmq-upgrade.yml\""},{"line_number":572,"context_line":"        EXTRA_OPTS\u003d\"$EXTRA_OPTS -e rabbitmq_version_suffix\u003d${RMQ_VERSION}\""},{"line_number":573,"context_line":"        ;;"},{"line_number":574,"context_line":"(bash-completion)"},{"line_number":575,"context_line":"        bash_completion"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"a0acecc0_a46ef8a9","line":572,"in_reply_to":"0b70134a_5acc8d9d","updated":"2024-08-06 08:46:08.000000000","message":"what do we do with this variable on future (slurp) updates, though?\n\nassuming the user sets this, we now need at least new docs and releases notes on each slurp release, that the user has to change this, right?\n\nhow do we ensure that we don\u0027t forget about that? Should we maybe set this as part of CI slurp upgrade testing?","commit_id":"b0383344f37c6ad244f7eba2fc059cd8cfe3767d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"28774be4ac87b9617e8efe0016cc66550417d71a","unresolved":true,"context_lines":[{"line_number":569,"context_line":"        RMQ_VERSION\u003d\"$2\""},{"line_number":570,"context_line":"        ACTION\u003d\"Upgrade to a specific version of RabbitMQ\""},{"line_number":571,"context_line":"        PLAYBOOK\u003d\"${BASEDIR}/ansible/rabbitmq-upgrade.yml\""},{"line_number":572,"context_line":"        EXTRA_OPTS\u003d\"$EXTRA_OPTS -e rabbitmq_version_suffix\u003d${RMQ_VERSION}\""},{"line_number":573,"context_line":"        ;;"},{"line_number":574,"context_line":"(bash-completion)"},{"line_number":575,"context_line":"        bash_completion"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"0b70134a_5acc8d9d","line":572,"in_reply_to":"0d3ebc69_1b1905e4","updated":"2024-08-05 15:06:15.000000000","message":"I\u0027d envisioned this as a command that\u0027s just run right before an upgrade to Caracal. Passing the version in via the CLI would make this easier for a one-off operation.\n\nI suppose if someone wanted to upgrade the RMQ version, but then stay on 2023.1, they would benefit from repeatability. In this case, they could set ``rabbitmq_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/rabbitmq-\u003cversion\u003e`` in their config and wouldn\u0027t need to use this command at all.\n\nWhile it\u0027s not my intended use-case, I can see the appeal so I\u0027ll add to the docs to explain this too.","commit_id":"b0383344f37c6ad244f7eba2fc059cd8cfe3767d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"96e3f1c704d2b06b28e28b0a0cc8fb5007b50a34","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        RMQ_VERSION\u003d\"$2\""},{"line_number":570,"context_line":"        ACTION\u003d\"Upgrade to a specific version of RabbitMQ\""},{"line_number":571,"context_line":"        PLAYBOOK\u003d\"${BASEDIR}/ansible/rabbitmq-upgrade.yml\""},{"line_number":572,"context_line":"        EXTRA_OPTS\u003d\"$EXTRA_OPTS -e rabbitmq_version_suffix\u003d${RMQ_VERSION}\""},{"line_number":573,"context_line":"        ;;"},{"line_number":574,"context_line":"(bash-completion)"},{"line_number":575,"context_line":"        bash_completion"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"6d271d90_074bb30c","line":572,"in_reply_to":"a0acecc0_a46ef8a9","updated":"2024-08-12 10:12:34.000000000","message":"Discussed in whiteboard/meeting, closing here :)","commit_id":"b0383344f37c6ad244f7eba2fc059cd8cfe3767d"}]}