)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2dfc8389485fc532eab628b8a5f3dbc0d78d82e9","unresolved":true,"context_lines":[{"line_number":9,"context_line":"There is a manual upgrade to an intermediary RabbitMQ version needed in"},{"line_number":10,"context_line":"2023.1 before RabbitMQ can be skip-level upgraded to 2024.1."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/918976"},{"line_number":13,"context_line":"Change-Id: Id8a5ebe19a50ebdc59d12667889472c803b8d7c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f1c24237_db9af402","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":2},"updated":"2024-08-05 15:30:18.000000000","message":"nit: technically not needed (same repository).","commit_id":"606a11c420caf4bc21480861a90290d1292704cf"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"086922114cda69354e1638dbd676e498ee4ab135","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There is a manual upgrade to an intermediary RabbitMQ version needed in"},{"line_number":10,"context_line":"2023.1 before RabbitMQ can be skip-level upgraded to 2024.1."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/918976"},{"line_number":13,"context_line":"Change-Id: Id8a5ebe19a50ebdc59d12667889472c803b8d7c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ee3608d1_8b996c77","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":2},"in_reply_to":"f1c24237_db9af402","updated":"2024-09-19 12:12:30.000000000","message":"Done","commit_id":"606a11c420caf4bc21480861a90290d1292704cf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9bedd85e282fddb990b507f7716c0b4046bccc79","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c98ec5d6_3e81a52a","updated":"2024-05-14 09:29:14.000000000","message":"is this still WIP? it\u0027s missing a newline at the end of the new docs, thus the linter currently fails.\n\nLooks like a very nice addition, I like the idea!","commit_id":"5845febcb23b06dfe76c4bd399fb51dce00bd990"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"08f2a2642413af76eb492156ab3aa1b4409fec9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"108a2dfd_d6619201","in_reply_to":"c98ec5d6_3e81a52a","updated":"2024-05-14 09:37:51.000000000","message":"It\u0027s basically ready to go, I\u0027ll just fix the linting.\nHowever, the docs directs people to a command that isn\u0027t ready yet (in the Depends-On), I still need to resolve the CI failures there.","commit_id":"5845febcb23b06dfe76c4bd399fb51dce00bd990"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"67f929a403acb6a760ba66b8dce08e25862b5962","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aa9f9560_23400a85","updated":"2024-07-18 15:11:23.000000000","message":"LGTM! :)","commit_id":"44d62aeb1766f3730cb790d6650a05e35d947a2f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2dfc8389485fc532eab628b8a5f3dbc0d78d82e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"acb22059_36136ef8","updated":"2024-08-05 15:30:18.000000000","message":"I think we need to improve on the assert function, making sure that it really runs before the upgrade is performed.","commit_id":"606a11c420caf4bc21480861a90290d1292704cf"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"5041c89e1d965cc77879199b2807f90d6bd8b288","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ee2a453f_003c030b","updated":"2024-08-12 15:17:23.000000000","message":"Given we\u0027re going to need this in future odd releases, I\u0027ve re-written this into master to try and be release-independent: https://review.opendev.org/c/openstack/kolla-ansible/+/926146","commit_id":"96677849efccbf4e9e179b7bf8daffbc0851428c"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"086922114cda69354e1638dbd676e498ee4ab135","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"50f4a9e5_51fa8af8","updated":"2024-09-19 12:12:30.000000000","message":"Resolving old comments as this is now a backport, rather than the feature patch","commit_id":"05eb87dd001df83d2d11eb735a346e52472a403f"}],"ansible/roles/rabbitmq/tasks/version-check.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2dfc8389485fc532eab628b8a5f3dbc0d78d82e9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- block:"},{"line_number":3,"context_line":"    - name: Get container facts"},{"line_number":4,"context_line":"      become: true"},{"line_number":5,"context_line":"      kolla_container_facts:"},{"line_number":6,"context_line":"        container_engine: \"{{ kolla_container_engine }}\""},{"line_number":7,"context_line":"        name:"},{"line_number":8,"context_line":"          - \"{{ service.container_name }}\""},{"line_number":9,"context_line":"      register: container_facts"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    - block:"},{"line_number":12,"context_line":"        - name: Get RabbitMQ version"},{"line_number":13,"context_line":"          become: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"96a750fa_ae22b1fc","line":10,"range":{"start_line":3,"start_character":0,"end_line":10,"end_character":1},"updated":"2024-08-05 15:30:18.000000000","message":"not quite sure if this is actually needed here? shouldn\u0027t the fact cache already contain the service.container_name at this point in the play?","commit_id":"606a11c420caf4bc21480861a90290d1292704cf"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"086922114cda69354e1638dbd676e498ee4ab135","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- block:"},{"line_number":3,"context_line":"    - name: Get container facts"},{"line_number":4,"context_line":"      become: true"},{"line_number":5,"context_line":"      kolla_container_facts:"},{"line_number":6,"context_line":"        container_engine: \"{{ kolla_container_engine }}\""},{"line_number":7,"context_line":"        name:"},{"line_number":8,"context_line":"          - \"{{ service.container_name }}\""},{"line_number":9,"context_line":"      register: container_facts"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    - block:"},{"line_number":12,"context_line":"        - name: Get RabbitMQ version"},{"line_number":13,"context_line":"          become: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f4bc8d47_ac4b0777","line":10,"range":{"start_line":3,"start_character":0,"end_line":10,"end_character":1},"in_reply_to":"96a750fa_ae22b1fc","updated":"2024-09-19 12:12:30.000000000","message":"Done","commit_id":"606a11c420caf4bc21480861a90290d1292704cf"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2dfc8389485fc532eab628b8a5f3dbc0d78d82e9","unresolved":true,"context_lines":[{"line_number":24,"context_line":"              You are running {{ rabbitmq_version.stdout }}."},{"line_number":25,"context_line":"              Please first upgrade to 3.12 with the command ``kolla-ansible rabbitmq-upgrade 3.12``."},{"line_number":26,"context_line":"              See these docs for more details: https://docs.openstack.org/kolla-ansible/2024.1/reference/message-queues/rabbitmq.html#slurp"},{"line_number":27,"context_line":"      when: container_facts[service.container_name] is defined"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  delegate_to: \"{{ groups[role_rabbitmq_groups] | first }}\""},{"line_number":30,"context_line":"  run_once: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7bff2508_642f22b0","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":2},"updated":"2024-08-05 15:30:18.000000000","message":"this is rather brittle, if the fact is - for any reason - not defined the assert doesn\u0027t run and people run the upgrade not knowing their rabbitmq won\u0027t work.\n\nmaybe the assert should rather also check that the fact is defined and abort under this condition as well?","commit_id":"606a11c420caf4bc21480861a90290d1292704cf"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"086922114cda69354e1638dbd676e498ee4ab135","unresolved":false,"context_lines":[{"line_number":24,"context_line":"              You are running {{ rabbitmq_version.stdout }}."},{"line_number":25,"context_line":"              Please first upgrade to 3.12 with the command ``kolla-ansible rabbitmq-upgrade 3.12``."},{"line_number":26,"context_line":"              See these docs for more details: https://docs.openstack.org/kolla-ansible/2024.1/reference/message-queues/rabbitmq.html#slurp"},{"line_number":27,"context_line":"      when: container_facts[service.container_name] is defined"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  delegate_to: \"{{ groups[role_rabbitmq_groups] | first }}\""},{"line_number":30,"context_line":"  run_once: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8f59408f_186fb626","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":2},"in_reply_to":"7bff2508_642f22b0","updated":"2024-09-19 12:12:30.000000000","message":"Done","commit_id":"606a11c420caf4bc21480861a90290d1292704cf"}],"doc/source/reference/message-queues/rabbitmq.rst":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2dfc8389485fc532eab628b8a5f3dbc0d78d82e9","unresolved":true,"context_lines":[{"line_number":173,"context_line":"Antelope to Caracal, you should first upgrade RabbitMQ to version 3.12, as"},{"line_number":174,"context_line":"RabbitMQ does not support jumping two versions in one upgrade. To do this,"},{"line_number":175,"context_line":"Kolla provides an Antelope RabbitMQ release with version 3.12. You can upgrade"},{"line_number":176,"context_line":"to this with the following command:"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":".. warning::"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3907f84d_acb8902d","line":176,"range":{"start_line":176,"start_character":3,"end_line":176,"end_character":7},"updated":"2024-08-05 15:30:18.000000000","message":"nit:\n\n```suggestion\nto this version with the following command:\n```","commit_id":"606a11c420caf4bc21480861a90290d1292704cf"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"086922114cda69354e1638dbd676e498ee4ab135","unresolved":false,"context_lines":[{"line_number":173,"context_line":"Antelope to Caracal, you should first upgrade RabbitMQ to version 3.12, as"},{"line_number":174,"context_line":"RabbitMQ does not support jumping two versions in one upgrade. To do this,"},{"line_number":175,"context_line":"Kolla provides an Antelope RabbitMQ release with version 3.12. You can upgrade"},{"line_number":176,"context_line":"to this with the following command:"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":".. warning::"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"d3c56d9a_c0cb7400","line":176,"range":{"start_line":176,"start_character":3,"end_line":176,"end_character":7},"in_reply_to":"3907f84d_acb8902d","updated":"2024-09-19 12:12:30.000000000","message":"Done","commit_id":"606a11c420caf4bc21480861a90290d1292704cf"}]}