)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"13f3202fae5fcd1c63080dd9da2334a8e2c1e2fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"feabbcaf_65ef85c4","updated":"2024-05-18 08:28:40.000000000","message":"Looks good. I think it makse sense to change the name of the backend.","commit_id":"6baa4d5b9bf7a076b00795fdcbcb849937ea6137"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b175ae9d7134e4fdcc969ff97c609540652deb6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c96f42dd_eb82b81f","updated":"2024-08-20 10:12:42.000000000","message":"Reno missing, user should no that there is a new feature - add new purestorage backend and how to turn on. \n\nFor example as releasenotes/notes/add-pure-iscsi-cinder-volume-backend-88000797996e414f.yaml in past...","commit_id":"7623715679154d5db5a26dd7bba5900b12902033"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"162309f1d98b757ff54a1582374f051e263f9aaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c522b308_43e35ef2","in_reply_to":"c96f42dd_eb82b81f","updated":"2024-08-20 13:10:28.000000000","message":"Reno added","commit_id":"7623715679154d5db5a26dd7bba5900b12902033"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"7308d8b1fac9e27c09df1a52c9e00a6243a57080","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d3044325_ddc66760","updated":"2024-08-22 12:13:21.000000000","message":"recheck","commit_id":"279ed4d65db47076a6846f9c20cdcbcd60302275"}],"ansible/roles/cinder/defaults/main.yml":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"13f3202fae5fcd1c63080dd9da2334a8e2c1e2fe","unresolved":true,"context_lines":[{"line_number":266,"context_line":"cinder_backend_pure_iscsi_name: \"Pure-FlashArray-iscsi\""},{"line_number":267,"context_line":"cinder_backend_pure_fc_name: \"Pure-FlashArray-fc\""},{"line_number":268,"context_line":"cinder_backend_pure_roce_name: \"Pure-FlashArray-roce\""},{"line_number":269,"context_line":"cinder_backend_pure_nvme_tcp_name: \"Pure-FlashArray-NVMe-TCP\""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"cinder_ceph_backends:"},{"line_number":272,"context_line":"  - name: \"{{ cinder_backend_ceph_name }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7b32f762_69d59c18","line":269,"updated":"2024-05-18 08:28:40.000000000","message":"nit: I would prefer to use Pure-FlashArray-nvme-tcp here because it‘s Pure-FlashArray-roce and not Pure-FlashArray-RoCE. You also use Pure-FlashArray-nvme-tcp in the cinder.rst.","commit_id":"6baa4d5b9bf7a076b00795fdcbcb849937ea6137"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"55ada72b0e4d02240d1f6156706eddd7120451d9","unresolved":false,"context_lines":[{"line_number":266,"context_line":"cinder_backend_pure_iscsi_name: \"Pure-FlashArray-iscsi\""},{"line_number":267,"context_line":"cinder_backend_pure_fc_name: \"Pure-FlashArray-fc\""},{"line_number":268,"context_line":"cinder_backend_pure_roce_name: \"Pure-FlashArray-roce\""},{"line_number":269,"context_line":"cinder_backend_pure_nvme_tcp_name: \"Pure-FlashArray-NVMe-TCP\""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"cinder_ceph_backends:"},{"line_number":272,"context_line":"  - name: \"{{ cinder_backend_ceph_name }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b55578a0_dca57a2f","line":269,"in_reply_to":"7b32f762_69d59c18","updated":"2024-05-18 17:54:16.000000000","message":"Done","commit_id":"6baa4d5b9bf7a076b00795fdcbcb849937ea6137"}]}