)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3560df24c3bd8eee9a30a52ca14dc5a243857477","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b4211f16_dc5fe63e","updated":"2024-06-27 14:49:16.000000000","message":"I don\u0027t know much about venus, but the database sharding logic seems sane and consistent with other service configs with regards to proxysql.","commit_id":"39fa523be425c95c877458af786b9c02979ce0a4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2de6c9c43977541f9cb52b066463d1e75b795077","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c41e9350_62834567","updated":"2024-06-20 17:38:03.000000000","message":"Is that ready for reviews? I see some monologue in comments..","commit_id":"39fa523be425c95c877458af786b9c02979ce0a4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6a7d01ae359ce749c9da91f8f197323510bfcf1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e4018253_823ae036","updated":"2024-08-21 13:31:33.000000000","message":"Looks sane and no other reviews for long time","commit_id":"39fa523be425c95c877458af786b9c02979ce0a4"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d3d062081b70351197f41ce2ecd45a81edf71b03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e979641c_020f859e","updated":"2024-06-27 08:03:24.000000000","message":"lgtm, can be processed","commit_id":"39fa523be425c95c877458af786b9c02979ce0a4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2d840446d9d9496e7cd82bf8ca5ca74a409540e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e0b856b2_451eb2aa","in_reply_to":"c41e9350_62834567","updated":"2024-06-26 16:47:51.000000000","message":"yes, simple, comments resolved.","commit_id":"39fa523be425c95c877458af786b9c02979ce0a4"}],"ansible/roles/venus/defaults/main.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2cad32ac777f81e2a0cd337db5333e0e4e049c1c","unresolved":true,"context_lines":[{"line_number":46,"context_line":"# Database sharding"},{"line_number":47,"context_line":"####################"},{"line_number":48,"context_line":"venus_database_shard_root_user: \"{% if enable_proxysql | bool %}root_shard_{{ venus_database_shard_id }}{% else %}{{ database_user }}{% endif %}\""},{"line_number":49,"context_line":"venus_database_shard_id: \"{{ mariadb_default_database_shard_id | int }}\""},{"line_number":50,"context_line":"venus_database_shard:"},{"line_number":51,"context_line":"  users:"},{"line_number":52,"context_line":"    - user: \"{{ venus_database_user }}\""},{"line_number":53,"context_line":"      password: \"{{ venus_database_password }}\""},{"line_number":54,"context_line":"  rules:"},{"line_number":55,"context_line":"    - schema: \"{{ venus_database_name }}\""},{"line_number":56,"context_line":"      shard_id: \"{{ venus_database_shard_id }}\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"####################"},{"line_number":60,"context_line":"# Docker"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5aa748dc_04e1f482","line":57,"range":{"start_line":49,"start_character":0,"end_line":57,"end_character":0},"updated":"2024-05-24 10:39:52.000000000","message":"not used","commit_id":"a861e4a77e2ec0504274fd54cf44b70deafce329"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ed0b11a9a50807bed7ab0dd5f3e2814bc2353c8e","unresolved":true,"context_lines":[{"line_number":46,"context_line":"# Database sharding"},{"line_number":47,"context_line":"####################"},{"line_number":48,"context_line":"venus_database_shard_root_user: \"{% if enable_proxysql | bool %}root_shard_{{ venus_database_shard_id }}{% else %}{{ database_user }}{% endif %}\""},{"line_number":49,"context_line":"venus_database_shard_id: \"{{ mariadb_default_database_shard_id | int }}\""},{"line_number":50,"context_line":"venus_database_shard:"},{"line_number":51,"context_line":"  users:"},{"line_number":52,"context_line":"    - user: \"{{ venus_database_user }}\""},{"line_number":53,"context_line":"      password: \"{{ venus_database_password }}\""},{"line_number":54,"context_line":"  rules:"},{"line_number":55,"context_line":"    - schema: \"{{ venus_database_name }}\""},{"line_number":56,"context_line":"      shard_id: \"{{ venus_database_shard_id }}\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"####################"},{"line_number":60,"context_line":"# Docker"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b376a6bf_80e2eb40","line":57,"range":{"start_line":49,"start_character":0,"end_line":57,"end_character":0},"in_reply_to":"5343b52c_cb890d52","updated":"2024-06-20 10:43:38.000000000","message":"Check another service\u0027s defaults ... pattern is same ..","commit_id":"a861e4a77e2ec0504274fd54cf44b70deafce329"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c28559375a4dbea6b3b20f17adcca854dfca0e2d","unresolved":true,"context_lines":[{"line_number":46,"context_line":"# Database sharding"},{"line_number":47,"context_line":"####################"},{"line_number":48,"context_line":"venus_database_shard_root_user: \"{% if enable_proxysql | bool %}root_shard_{{ venus_database_shard_id }}{% else %}{{ database_user }}{% endif %}\""},{"line_number":49,"context_line":"venus_database_shard_id: \"{{ mariadb_default_database_shard_id | int }}\""},{"line_number":50,"context_line":"venus_database_shard:"},{"line_number":51,"context_line":"  users:"},{"line_number":52,"context_line":"    - user: \"{{ venus_database_user }}\""},{"line_number":53,"context_line":"      password: \"{{ venus_database_password }}\""},{"line_number":54,"context_line":"  rules:"},{"line_number":55,"context_line":"    - schema: \"{{ venus_database_name }}\""},{"line_number":56,"context_line":"      shard_id: \"{{ venus_database_shard_id }}\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"####################"},{"line_number":60,"context_line":"# Docker"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5ed988f6_0d1538ec","line":57,"range":{"start_line":49,"start_character":0,"end_line":57,"end_character":0},"in_reply_to":"5aa748dc_04e1f482","updated":"2024-06-20 08:31:37.000000000","message":"What is not used ? :D explain please ...","commit_id":"a861e4a77e2ec0504274fd54cf44b70deafce329"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"17d42e3ddc61840af7825b87154c7d215da5236f","unresolved":true,"context_lines":[{"line_number":46,"context_line":"# Database sharding"},{"line_number":47,"context_line":"####################"},{"line_number":48,"context_line":"venus_database_shard_root_user: \"{% if enable_proxysql | bool %}root_shard_{{ venus_database_shard_id }}{% else %}{{ database_user }}{% endif %}\""},{"line_number":49,"context_line":"venus_database_shard_id: \"{{ mariadb_default_database_shard_id | int }}\""},{"line_number":50,"context_line":"venus_database_shard:"},{"line_number":51,"context_line":"  users:"},{"line_number":52,"context_line":"    - user: \"{{ venus_database_user }}\""},{"line_number":53,"context_line":"      password: \"{{ venus_database_password }}\""},{"line_number":54,"context_line":"  rules:"},{"line_number":55,"context_line":"    - schema: \"{{ venus_database_name }}\""},{"line_number":56,"context_line":"      shard_id: \"{{ venus_database_shard_id }}\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"####################"},{"line_number":60,"context_line":"# Docker"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f3e73240_185b74dd","line":57,"range":{"start_line":49,"start_character":0,"end_line":57,"end_character":0},"in_reply_to":"5ed988f6_0d1538ec","updated":"2024-06-20 08:36:43.000000000","message":"https://github.com/openstack/kolla-ansible/blob/09067aa0cd3f6c0fc5528927966be45232ad52ab/ansible/roles/venus/tasks/loadbalancer.yml#L4\n\nhttps://github.com/openstack/kolla-ansible/blob/master/ansible/roles/loadbalancer-config/tasks/main.yml\n\nhttps://github.com/openstack/kolla-ansible/blob/09067aa0cd3f6c0fc5528927966be45232ad52ab/ansible/roles/proxysql-config/defaults/main.yml#L2 \n\nIf you can\u0027t find variable by grep ...it doesn\u0027t mean it is not used :) . So, please ..reset your vote ..or explain to me what exactly did you think...","commit_id":"a861e4a77e2ec0504274fd54cf44b70deafce329"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2d840446d9d9496e7cd82bf8ca5ca74a409540e2","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# Database sharding"},{"line_number":47,"context_line":"####################"},{"line_number":48,"context_line":"venus_database_shard_root_user: \"{% if enable_proxysql | bool %}root_shard_{{ venus_database_shard_id }}{% else %}{{ database_user }}{% endif %}\""},{"line_number":49,"context_line":"venus_database_shard_id: \"{{ mariadb_default_database_shard_id | int }}\""},{"line_number":50,"context_line":"venus_database_shard:"},{"line_number":51,"context_line":"  users:"},{"line_number":52,"context_line":"    - user: \"{{ venus_database_user }}\""},{"line_number":53,"context_line":"      password: \"{{ venus_database_password }}\""},{"line_number":54,"context_line":"  rules:"},{"line_number":55,"context_line":"    - schema: \"{{ venus_database_name }}\""},{"line_number":56,"context_line":"      shard_id: \"{{ venus_database_shard_id }}\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"####################"},{"line_number":60,"context_line":"# Docker"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a12b005f_de338fc0","line":57,"range":{"start_line":49,"start_character":0,"end_line":57,"end_character":0},"in_reply_to":"b376a6bf_80e2eb40","updated":"2024-06-26 16:47:51.000000000","message":"Done","commit_id":"a861e4a77e2ec0504274fd54cf44b70deafce329"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"20ee4820353b0f039a2ddbfcf65a7d93d9121b7c","unresolved":true,"context_lines":[{"line_number":46,"context_line":"# Database sharding"},{"line_number":47,"context_line":"####################"},{"line_number":48,"context_line":"venus_database_shard_root_user: \"{% if enable_proxysql | bool %}root_shard_{{ venus_database_shard_id }}{% else %}{{ database_user }}{% endif %}\""},{"line_number":49,"context_line":"venus_database_shard_id: \"{{ mariadb_default_database_shard_id | int }}\""},{"line_number":50,"context_line":"venus_database_shard:"},{"line_number":51,"context_line":"  users:"},{"line_number":52,"context_line":"    - user: \"{{ venus_database_user }}\""},{"line_number":53,"context_line":"      password: \"{{ venus_database_password }}\""},{"line_number":54,"context_line":"  rules:"},{"line_number":55,"context_line":"    - schema: \"{{ venus_database_name }}\""},{"line_number":56,"context_line":"      shard_id: \"{{ venus_database_shard_id }}\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"####################"},{"line_number":60,"context_line":"# Docker"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5343b52c_cb890d52","line":57,"range":{"start_line":49,"start_character":0,"end_line":57,"end_character":0},"in_reply_to":"f3e73240_185b74dd","updated":"2024-06-20 09:27:22.000000000","message":"ok, need to check on real deployment","commit_id":"a861e4a77e2ec0504274fd54cf44b70deafce329"}]}