)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"8cb57a034566f490b327c9c196f738d1074aa181","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve grafana dashboard deployment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Unitl now grafana dashboards were always removed and redeployed leading"},{"line_number":10,"context_line":"to a restart of the grafana services on every deployment."},{"line_number":11,"context_line":"The task is changed to find all individual dashboards that are going to"},{"line_number":12,"context_line":"be deployed and all which are currently deployed. Dashboards only"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9e59bd5e_020158ab","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":5},"updated":"2024-11-05 07:39:27.000000000","message":"nit: Until","commit_id":"f47c8b05bbd89749b4e2dd5a11e07efcb240f8e9"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"7cac054f81c12c123f4e7853f9665734b17107e2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve grafana dashboard deployment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Unitl now grafana dashboards were always removed and redeployed leading"},{"line_number":10,"context_line":"to a restart of the grafana services on every deployment."},{"line_number":11,"context_line":"The task is changed to find all individual dashboards that are going to"},{"line_number":12,"context_line":"be deployed and all which are currently deployed. Dashboards only"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"d0202aa9_0c7fba98","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":5},"in_reply_to":"9e59bd5e_020158ab","updated":"2024-11-05 08:19:33.000000000","message":"Done","commit_id":"f47c8b05bbd89749b4e2dd5a11e07efcb240f8e9"},{"author":{"_account_id":30911,"name":"Jan Horstmann","email":"horstmann@osism.tech","username":"jhorstmann"},"change_message_id":"6c93778e866a173f0184831e40e5d7336e598d25","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve grafana dashboard deployment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Unitl now grafana dashboards were always removed and redeployed leading"},{"line_number":10,"context_line":"to a restart of the grafana services on every deployment."},{"line_number":11,"context_line":"The task is changed to find all individual dashboards that are going to"},{"line_number":12,"context_line":"be deployed and all which are currently deployed. Dashboards only"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"123490b7_10d56e7e","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":5},"in_reply_to":"9e59bd5e_020158ab","updated":"2024-11-05 08:19:49.000000000","message":"Fixed, thank you","commit_id":"f47c8b05bbd89749b4e2dd5a11e07efcb240f8e9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30911,"name":"Jan Horstmann","email":"horstmann@osism.tech","username":"jhorstmann"},"change_message_id":"d53a390ad45b83f85b5dc8e32e4cd74312de1435","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d3121c2e_214c7f8d","updated":"2024-06-11 07:21:46.000000000","message":"recheck no code changes since last succesful run","commit_id":"383c8190b8b0f6e4686b0d7e1da843c4db158185"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"446a6b7cdd4e5844748b4ed2487c1a92d1acb29e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e1cf4546_8c06b77a","updated":"2024-10-09 13:22:35.000000000","message":"lgtm, but could it possible to see test in separate chained review. thanks","commit_id":"f47c8b05bbd89749b4e2dd5a11e07efcb240f8e9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5890b85ecdeeb17a92479d9369a56f96c6e04deb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fb5b9793_3be161e5","in_reply_to":"b121421e_c45131a7","updated":"2024-11-08 15:39:12.000000000","message":"@maksim.malchuk@gmail.com could you already take a look? the logs will expire in 7 days afaik. It would be nice if we don\u0027t need to repeat this to preserve CI resources.","commit_id":"f47c8b05bbd89749b4e2dd5a11e07efcb240f8e9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"cae30f49b016511347d0699a5c064e818cea96e4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f6f688ed_ae97acaa","in_reply_to":"e10c9b7b_d4aa3cfe","updated":"2024-10-11 09:03:00.000000000","message":"there need a change on top of this one with custom configuration.\nthen let see the CI logs for the tasks with containers restarts and drop the change since tests (not)passed.","commit_id":"f47c8b05bbd89749b4e2dd5a11e07efcb240f8e9"},{"author":{"_account_id":30911,"name":"Jan Horstmann","email":"horstmann@osism.tech","username":"jhorstmann"},"change_message_id":"050181cd85ded3209aa0668e60536b9e9e1d95ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e10c9b7b_d4aa3cfe","in_reply_to":"e1cf4546_8c06b77a","updated":"2024-10-11 08:35:20.000000000","message":"thanks for the feedback Maksim! Could you elaborate on the kind of test you would like to see? The issue here is that grafana containers are restarted on every deployment if custom dashboards exist.\nShould the test showcase this behaviour and that it is fixed with this patch?\nOr should it test this patch for correct behaviour (grafana up/running, dashboards deployed, ...)?\n\nI am happy to provide tests, but am unsure about how to approach the first variant.","commit_id":"f47c8b05bbd89749b4e2dd5a11e07efcb240f8e9"},{"author":{"_account_id":30911,"name":"Jan Horstmann","email":"horstmann@osism.tech","username":"jhorstmann"},"change_message_id":"d60064257ca039c4c7d598317d752b74a439e474","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b121421e_c45131a7","in_reply_to":"f6f688ed_ae97acaa","updated":"2024-10-15 15:43:02.000000000","message":"I have created this test, which runs a second deployment of grafana to showcase the issue\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/932388\n\n\nRun of the test without a fix:\n\nFirst grafana deployment: https://zuul.opendev.org/t/openstack/build/b6fcf20297ff4ae6b000f173fe3ba6bf/log/primary/logs/ansible/deploy#16251\n\nSecond grafana deployment: https://zuul.opendev.org/t/openstack/build/b6fcf20297ff4ae6b000f173fe3ba6bf/log/primary/logs/ansible/deploy#18918\n\nNote that handlers are being run on the second deployment\n\n\n\nRun of the test with a dependency on this fix:\n\nFirst grafana deployment: https://zuul.opendev.org/t/openstack/build/a5730a9c52604612a5f2161f825a5bba/log/primary/logs/ansible/deploy#16104\n\nSecond grafana deployment: https://zuul.opendev.org/t/openstack/build/a5730a9c52604612a5f2161f825a5bba/log/primary/logs/ansible/deploy#18705\n\nNote that handlers are not run on the second deployment\n\n\n\nIn the end both runs fail on an unrelated file permission check which I was to lazy to fix","commit_id":"f47c8b05bbd89749b4e2dd5a11e07efcb240f8e9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"36e9975fc611fda4aae67f03c607fbbafe4d05c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b5c97f75_286533f6","in_reply_to":"fb5b9793_3be161e5","updated":"2024-11-08 18:47:58.000000000","message":"sure, lgtm from my side","commit_id":"f47c8b05bbd89749b4e2dd5a11e07efcb240f8e9"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"2802ada4b65dcab115a4fea9a79c7bd2659f0965","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0a8c05a2_76325fbb","updated":"2026-03-25 07:32:35.000000000","message":"I didn\u0027t even know anyone was working on this.\nI had a slightly different proposal for this solution.\nYou can see 2, which is more appropriate.\n\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/963567","commit_id":"f66db6f70a963c4bf4035a88c50ad22e47b2aa2d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5890b85ecdeeb17a92479d9369a56f96c6e04deb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"06ee3a80_4a1d6f36","updated":"2024-11-08 15:39:12.000000000","message":"LGTM but I didn\u0027t take a close look at the","commit_id":"f66db6f70a963c4bf4035a88c50ad22e47b2aa2d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7cc9b8a5f90c34501f8bebf7042064d8a0ef1310","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d4007508_55851f53","updated":"2026-03-25 06:47:16.000000000","message":"Merge conflict, please rebase","commit_id":"f66db6f70a963c4bf4035a88c50ad22e47b2aa2d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f373fdc5e5e1b783b4f2e041d054da85d8c98c7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9417dc3c_9df0ec0a","in_reply_to":"0a8c05a2_76325fbb","updated":"2026-03-25 07:35:59.000000000","message":"Which is also in merge conflict","commit_id":"f66db6f70a963c4bf4035a88c50ad22e47b2aa2d"},{"author":{"_account_id":30911,"name":"Jan Horstmann","email":"horstmann@osism.tech","username":"jhorstmann"},"change_message_id":"15c60c9731ce42e2a0c06c4b0e62171a56d1cf9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b5fa81a6_7bdaf760","in_reply_to":"d4007508_55851f53","updated":"2026-04-02 11:20:47.000000000","message":"Done","commit_id":"f66db6f70a963c4bf4035a88c50ad22e47b2aa2d"}],"ansible/roles/grafana/tasks/config.yml":[{"author":{"_account_id":30911,"name":"Jan Horstmann","email":"horstmann@osism.tech","username":"jhorstmann"},"change_message_id":"15c60c9731ce42e2a0c06c4b0e62171a56d1cf9d","unresolved":true,"context_lines":[{"line_number":130,"context_line":"    - not ansible_check_mode"},{"line_number":131,"context_line":"    - service | service_enabled_and_mapped_to_host"},{"line_number":132,"context_line":"  with_items: \"{{ dashboards_templated_relative_path | reject(\u0027in\u0027, dashboards_config_relative_path) | reject(\u0027in\u0027, dashboards_config_relative_path | map(\u0027dirname\u0027)) }}\""},{"line_number":133,"context_line":"  notify:"},{"line_number":134,"context_line":"    - Restart grafana container"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"- name: Copying over custom dashboards"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"06d2895d_15a81079","line":133,"updated":"2026-04-02 11:20:47.000000000","message":"Not sure if the notify is required/wanted anymore","commit_id":"7ecc19b5147eaf2f4674e2266ef795e54c16205f"},{"author":{"_account_id":30911,"name":"Jan Horstmann","email":"horstmann@osism.tech","username":"jhorstmann"},"change_message_id":"15c60c9731ce42e2a0c06c4b0e62171a56d1cf9d","unresolved":true,"context_lines":[{"line_number":146,"context_line":"  when:"},{"line_number":147,"context_line":"    - service | service_enabled_and_mapped_to_host"},{"line_number":148,"context_line":"  with_items: \"{{ dict( dashboards_config_relative_path | zip(grafana_custom_dashboards.files) ) | dict2items }}\""},{"line_number":149,"context_line":"  notify:"},{"line_number":150,"context_line":"    - Restart grafana container"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"186b97af_ffaca63e","line":149,"updated":"2026-04-02 11:20:47.000000000","message":"Not sure if the notify is required/wanted anymore","commit_id":"7ecc19b5147eaf2f4674e2266ef795e54c16205f"}]}