)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b717987bb9805c7d6d16ac43f89cd978fea27491","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a8a69406_f6c50afa","updated":"2024-06-17 13:11:52.000000000","message":"I can agree to that once it will work for OVN ;-)","commit_id":"b9689c8c0b753a429221f8f2b4043956a3c77112"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4fc4eab29dfabc94e0635989c9aefad6aeb79de1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"652423b7_de85adc8","updated":"2024-06-18 07:31:08.000000000","message":"We do use this in production and it seems to work pretty stable, do you have any pointers to bugs that would indicate otherwise?","commit_id":"b9689c8c0b753a429221f8f2b4043956a3c77112"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5ce4335369926b90d33a7ce5979562653fec751f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"76750042_afd749f9","in_reply_to":"106b9492_5e47c1f8","updated":"2024-06-18 09:42:46.000000000","message":"I\u0027m currently looking at the original implementation in https://review.opendev.org/c/openstack/kolla-ansible/+/755589 and trying to come up with something/maybe improve it a little bit (afaik there is still a race condition in the handling of the systemd service file).","commit_id":"b9689c8c0b753a429221f8f2b4043956a3c77112"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2614cdea35d774c85c1fa382cd2c8829c9942dd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"386593e9_94a17351","in_reply_to":"19043eaa_908ebac3","updated":"2024-06-18 07:36:20.000000000","message":"from our prod:\n\n```\ndragon@mgr001:/opt/configuration$ grep -ir octavia_network_type\nenvironments/kolla/configuration.yml:octavia_network_type: tenant\ndragon@mgr001:/opt/configuration$ openstack --os-cloud admin loadbalancer healthmonitor show 5deb6320-32da-4bf3-b2fb-7703f3becc1f\n+---------------------+----------------------------------------------------------------------------------------+\n| Field               | Value                                                                                  |\n+---------------------+----------------------------------------------------------------------------------------+\n| project_id          | 431c7c19d40f496f9a5788770354e885                                                       |\n| name                | monitor_1_kube_service_shoot--infra--gha-runner_ingress-nginx_ingress-nginx-controller |\n| admin_state_up      | True                                                                                   |\n| pools               | ac2af33f-66ae-46ce-a2d3-2cfe721d66e3                                                   |\n| created_at          | 2024-04-24T13:21:53                                                                    |\n| provisioning_status | ACTIVE                                                                                 |\n| updated_at          | 2024-04-24T13:23:23                                                                    |\n| delay               | 20                                                                                     |\n| expected_codes      | None                                                                                   |\n| max_retries         | 2                                                                                      |\n| http_method         | None                                                                                   |\n| timeout             | 30                                                                                     |\n| max_retries_down    | 3                                                                                      |\n| url_path            | None                                                                                   |\n| type                | TCP                                                                                    |\n| id                  | 5deb6320-32da-4bf3-b2fb-7703f3becc1f                                                   |\n| operating_status    | ONLINE                                                                                 |\n| http_version        | None                                                                                   |\n| domain_name         | None                                                                                   |\n| tags                |                                                                                        |\n+---------------------+----------------------------------------------------------------------------------------+\n\n\n```","commit_id":"b9689c8c0b753a429221f8f2b4043956a3c77112"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f8667308031c3e17f6d6c58ec9cd8587b2657c75","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"106b9492_5e47c1f8","in_reply_to":"386593e9_94a17351","updated":"2024-06-18 07:38:40.000000000","message":"Once we have test coverage for that in Octavia or Magnum jobs - I\u0027m fine with that.","commit_id":"b9689c8c0b753a429221f8f2b4043956a3c77112"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b0202008d79184a44dfdd8e2ecb04f2fd828e1df","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c68213b0_b9a823ae","in_reply_to":"76750042_afd749f9","updated":"2024-06-18 11:53:34.000000000","message":"So I was looking into if there is a tempest test for this.\nThis tests at least some of this:\n\nhttps://github.com/openstack/octavia-tempest-plugin/blob/cb2c9586cf0e97c5bff7ab1e3c8b5c6abad30dc0/octavia_tempest_plugin/tests/api/v2/test_healthmonitor.py#L1089\n\nhowever it assumes the healthmonitors are always online:\n\nhttps://github.com/openstack/octavia-tempest-plugin/blob/cb2c9586cf0e97c5bff7ab1e3c8b5c6abad30dc0/octavia_tempest_plugin/tests/api/v2/test_healthmonitor.py#L1178\n\nThere is no tempest scenario I have found so far which also checks for the health monitor:\n\nhttps://github.com/openstack/tempest/tree/3619d297d57c719d2f297f16e8867b5b4f7abf20/tempest/scenario\n\nI would like to avoid to write new bash code for this, given that we want to switch to tempest anyway. I\u0027m now looking how easily it would be possible to supply a tempest test scenario for this usecase.","commit_id":"b9689c8c0b753a429221f8f2b4043956a3c77112"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"815986f6ed2dbfac36580bdb6e6773ecc9119dd8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"19043eaa_908ebac3","in_reply_to":"9dd9169a_f5a67339","updated":"2024-06-17 17:42:49.000000000","message":"And are you sure that works? I would be surprised.","commit_id":"b9689c8c0b753a429221f8f2b4043956a3c77112"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0c9792ad6d079aae3ab38b18b7710a1b929dac3e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9dd9169a_f5a67339","in_reply_to":"a8a69406_f6c50afa","updated":"2024-06-17 15:10:26.000000000","message":"can you elaborate, maybe I\u0027m missing something but we do use ovn?","commit_id":"b9689c8c0b753a429221f8f2b4043956a3c77112"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d3d67c677e40e0421b6645d8d1cae178ceac1d40","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"774d4e2f_ca858f05","in_reply_to":"c68213b0_b9a823ae","updated":"2024-08-22 05:53:32.000000000","message":"Well, there\u0027s another patch with a similar discussion (https://review.opendev.org/c/openstack/kolla-ansible/+/920377) - I think we may remove the sentence of not using it in production - but we need to add some considerations when this might not be the best approach (when you restart the service on all controllers at the same time, DHCP does not work, and so on).","commit_id":"b9689c8c0b753a429221f8f2b4043956a3c77112"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"093b18dff007a7070a8eba16eb1894e20c6df78f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1c181ce4_ffd1109e","updated":"2026-01-15 05:53:35.000000000","message":"did a rebase in order to show the context with the new paragraph that was added behind the change. I still think the change is fine as is. if someone has an idea how to add some better worded warning message, feel free to amend this","commit_id":"860e072c25ac5c6d0b24d24eafc32f36abed9bb1"}]}