)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"55856d8dabfd3484422b6cac9e5c4150aba9a2fe","unresolved":true,"context_lines":[{"line_number":10,"context_line":"requirements.txt since there is really no reason"},{"line_number":11,"context_line":"not to have it in the requirements.txt, given that"},{"line_number":12,"context_line":"kolla-ansible project even has ansible in its name"},{"line_number":13,"context_line":"and ansible-core is a crucial dependency."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I4d01b7eb944c4edf6a440f2b775221986509f7eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"adcd060e_5b124bf6","line":13,"updated":"2024-08-20 08:12:58.000000000","message":"Can you also add a small note about the change in test-reqs, please?","commit_id":"eeee9de4974328dcfba29cbea3170cfd5ad663a7"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"05fa3121ce54ded76e50963e40f5e0c13976e8b5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"requirements.txt since there is really no reason"},{"line_number":11,"context_line":"not to have it in the requirements.txt, given that"},{"line_number":12,"context_line":"kolla-ansible project even has ansible in its name"},{"line_number":13,"context_line":"and ansible-core is a crucial dependency."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I4d01b7eb944c4edf6a440f2b775221986509f7eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"a30decbb_68bcf5a7","line":13,"in_reply_to":"adcd060e_5b124bf6","updated":"2024-08-20 10:09:33.000000000","message":"Done","commit_id":"eeee9de4974328dcfba29cbea3170cfd5ad663a7"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0a636f50e3b31a8970d0462591a1532811e943b8","unresolved":true,"context_lines":[{"line_number":12,"context_line":"kolla-ansible project even has ansible in its name"},{"line_number":13,"context_line":"and ansible-core is a crucial dependency."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Ansible-core dependency was also added to test-requiremtns.txt"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4d01b7eb944c4edf6a440f2b775221986509f7eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3016b14e_cb1ef87f","line":15,"range":{"start_line":15,"start_character":47,"end_line":15,"end_character":58},"updated":"2024-09-02 15:59:13.000000000","message":"nit: requirements","commit_id":"f92417f7a37380cb5c23fc50c993bf6f881051a7"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"966d820cd99fae926f14eaae958d4c32742e4054","unresolved":false,"context_lines":[{"line_number":12,"context_line":"kolla-ansible project even has ansible in its name"},{"line_number":13,"context_line":"and ansible-core is a crucial dependency."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Ansible-core dependency was also added to test-requiremtns.txt"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4d01b7eb944c4edf6a440f2b775221986509f7eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"e39927f7_93d609ba","line":15,"range":{"start_line":15,"start_character":47,"end_line":15,"end_character":58},"in_reply_to":"3016b14e_cb1ef87f","updated":"2024-09-13 18:34:37.000000000","message":"Done","commit_id":"f92417f7a37380cb5c23fc50c993bf6f881051a7"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bdedb55e12f67b8d2714fc8fa06e48b80f381c73","unresolved":true,"context_lines":[{"line_number":12,"context_line":"kolla-ansible project even has ansible in its name"},{"line_number":13,"context_line":"and ansible-core is a crucial dependency."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Ansible-core dependency was also added to test-requirements.txt"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4d01b7eb944c4edf6a440f2b775221986509f7eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1cb61e5b_3828a0a2","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":2},"updated":"2024-09-28 09:03:03.000000000","message":"commit message doesn\u0027t match what\u0027s actually done (currently it\u0027s removed)\nalso ansible was removed as well","commit_id":"ee5e097c3aa98867909e55922a8056669317ce5f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"87d2fb9aa200bcdfae8986c38b80e762f1c0569f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"kolla-ansible project even has ansible in its name"},{"line_number":13,"context_line":"and ansible-core is a crucial dependency."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Ansible-core dependency was also added to test-requirements.txt"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4d01b7eb944c4edf6a440f2b775221986509f7eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"c3f1ce2f_a4321088","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":2},"in_reply_to":"1cb61e5b_3828a0a2","updated":"2024-09-30 13:48:48.000000000","message":"Done","commit_id":"ee5e097c3aa98867909e55922a8056669317ce5f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b6602b5809a4949ee5c7e5028a3e0e331b1ac75e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3bc8bc44_89a3e776","updated":"2024-06-20 07:47:50.000000000","message":"ansible-core please","commit_id":"07028b78ac1c71a3dc0810fa883902f241cf8e0f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3e4f2437024c8b4fa37e1dabba1c040c911cb458","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"793d0000_b9d9f9a6","in_reply_to":"3bc8bc44_89a3e776","updated":"2024-06-20 10:07:48.000000000","message":"Why ?","commit_id":"07028b78ac1c71a3dc0810fa883902f241cf8e0f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e5594f856721b9280facd1e16b5a453fd15b0567","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6c362a73_b320a8c7","in_reply_to":"511d27ae_0cd5cf01","updated":"2024-07-17 10:32:51.000000000","message":"changed to ansible-core","commit_id":"07028b78ac1c71a3dc0810fa883902f241cf8e0f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9b788ab3630d47654a9056d85baa122fff7ea305","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"511d27ae_0cd5cf01","in_reply_to":"793d0000_b9d9f9a6","updated":"2024-06-20 10:08:58.000000000","message":"Ansible-core is just dependency, ansible is the right one which we need to install...","commit_id":"07028b78ac1c71a3dc0810fa883902f241cf8e0f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"eaa379815eece254c9adfce4d9c9f4512eacbd52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e43821e4_1434229d","updated":"2024-07-17 10:29:41.000000000","message":"recheck - not related to requirements","commit_id":"c45069bd9d3738ee258d8e8ed85b4cf76a4235d4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b4023d96d3f66ae5ffbe492c3da37d78acecf2ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1220f4e9_83815dca","updated":"2024-07-18 15:13:24.000000000","message":"would at least need to be adjusted if we want to backport this. otherwise LGTM.","commit_id":"eeee9de4974328dcfba29cbea3170cfd5ad663a7"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"92f277e049b03b3e72f4018c64da0513cf8aea7e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ff018a80_b3d4b04f","updated":"2024-09-04 01:15:21.000000000","message":"@will@stackhpc.com How does that impact on Kayobe?","commit_id":"f92417f7a37380cb5c23fc50c993bf6f881051a7"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"99b10734a848787d0dad4e6c6936de9f94f104af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"86779135_20f0a7b3","in_reply_to":"02768ca2_0c8173bb","updated":"2024-09-26 08:46:42.000000000","message":"Done","commit_id":"f92417f7a37380cb5c23fc50c993bf6f881051a7"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"dd69e4bfec78f974995c8e36da608e52d5d050f0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"87a7ff56_38c72e47","in_reply_to":"02768ca2_0c8173bb","updated":"2024-09-26 09:12:21.000000000","message":"Seems like it will be fine (untested). We will be able to remove the ansible-core dependency here: https://github.com/openstack/kayobe/blob/master/ansible/roles/kolla-ansible/tasks/install.yml#L107. Should still allow you to install the regular ansible package as that just includes ansible-core as a dependency.","commit_id":"f92417f7a37380cb5c23fc50c993bf6f881051a7"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"df57bdd020742e146980aaa93451f5ea1ee5a8d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f82af889_591dffe3","in_reply_to":"86779135_20f0a7b3","updated":"2024-09-26 09:05:23.000000000","message":"Thanks, I\u0027ve also added tox-pep and publish-tar into parent commit as @frickler@offenerstapel.de suggested.","commit_id":"f92417f7a37380cb5c23fc50c993bf6f881051a7"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"91d687c7e078f4e5e0dbd334d090eef484aa228b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"02768ca2_0c8173bb","in_reply_to":"86f840c5_8cf53d1a","updated":"2024-09-21 22:34:24.000000000","message":"ping","commit_id":"f92417f7a37380cb5c23fc50c993bf6f881051a7"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"964d1fe669a635db005569c0d42722c482138cdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"00b4cd73_492a1909","in_reply_to":"87a7ff56_38c72e47","updated":"2024-09-26 11:48:25.000000000","message":"Done","commit_id":"f92417f7a37380cb5c23fc50c993bf6f881051a7"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e632cd5a0b7d6d0ca92bf3a687ce93c444dd751f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"86f840c5_8cf53d1a","in_reply_to":"fbc7e04f_7cd45a08","updated":"2024-09-13 18:37:32.000000000","message":"@will@stackhpc.com can u check this review please ?","commit_id":"f92417f7a37380cb5c23fc50c993bf6f881051a7"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"944a50b523168a523f8ba7b234b111ea84809288","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fbc7e04f_7cd45a08","in_reply_to":"ff018a80_b3d4b04f","updated":"2024-09-09 15:09:11.000000000","message":"how it would affect ? the same requirement is hardcoded in Kolla Ansible Shell script, isn\u0027t it ? this is just a comment because I would like to understand","commit_id":"f92417f7a37380cb5c23fc50c993bf6f881051a7"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a72fa1a969de10f65f3b0bc4812b358468f37aa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5dac914f_3f3176ef","updated":"2024-09-14 10:09:49.000000000","message":"(tox) michalarbet@pixla:~/ultimum/git/upstream/kolla-ansible$ docker run python:3.9 bash -c \"pip3 install \u0027ansible-core\u003c2.18,\u003e\u003d2.16\u0027\"\nERROR: Ignored the following versions that require a different python version: 2.16.0 Requires-Python \u003e\u003d3.10; 2.16.0b1 Requires-Python \u003e\u003d3.10; 2.16.0b2 Requires-Python \u003e\u003d3.10; 2.16.0rc1 Requires-Python \u003e\u003d3.10; 2.16.1 Requires-Python \u003e\u003d3.10; 2.16.10 Requires-Python \u003e\u003d3.10; 2.16.10rc1 Requires-Python \u003e\u003d3.10; 2.16.11 Requires-Python \u003e\u003d3.10; 2.16.11rc1 Requires-Python \u003e\u003d3.10; 2.16.1rc1 Requires-Python \u003e\u003d3.10; 2.16.2 Requires-Python \u003e\u003d3.10; 2.16.3 Requires-Python \u003e\u003d3.10; 2.16.3rc1 Requires-Python \u003e\u003d3.10; 2.16.4 Requires-Python \u003e\u003d3.10; 2.16.4rc1 Requires-Python \u003e\u003d3.10; 2.16.5 Requires-Python \u003e\u003d3.10; 2.16.5rc1 Requires-Python \u003e\u003d3.10; 2.16.6 Requires-Python \u003e\u003d3.10; 2.16.7 Requires-Python \u003e\u003d3.10; 2.16.7rc1 Requires-Python \u003e\u003d3.10; 2.16.8 Requires-Python \u003e\u003d3.10; 2.16.8rc1 Requires-Python \u003e\u003d3.10; 2.16.9 Requires-Python \u003e\u003d3.10; 2.16.9rc1 Requires-Python \u003e\u003d3.10; 2.17.0 Requires-Python \u003e\u003d3.10; 2.17.0b1 Requires-Python \u003e\u003d3.10; 2.17.0rc1 Requires-Python \u003e\u003d3.10; 2.17.0rc2 Requires-Python \u003e\u003d3.10; 2.17.1 Requires-Python \u003e\u003d3.10; 2.17.1rc1 Requires-Python \u003e\u003d3.10; 2.17.2 Requires-Python \u003e\u003d3.10; 2.17.2rc1 Requires-Python \u003e\u003d3.10; 2.17.2rc2 Requires-Python \u003e\u003d3.10; 2.17.3 Requires-Python \u003e\u003d3.10; 2.17.3rc1 Requires-Python \u003e\u003d3.10; 2.17.4 Requires-Python \u003e\u003d3.10; 2.17.4rc1 Requires-Python \u003e\u003d3.10\nERROR: Could not find a version that satisfies the requirement ansible-core\u003c2.18,\u003e\u003d2.16 (from versions: 0.0.1a1, 2.11.0b1, 2.11.0b2, 2.11.0b3, 2.11.0b4, 2.11.0rc1, 2.11.0rc2, 2.11.0, 2.11.1rc1, 2.11.1, 2.11.2rc1, 2.11.2, 2.11.3rc1, 2.11.3, 2.11.4rc1, 2.11.4, 2.11.5rc1, 2.11.5, 2.11.6rc1, 2.11.6, 2.11.7rc1, 2.11.7, 2.11.8rc1, 2.11.8, 2.11.9rc1, 2.11.9, 2.11.10rc1, 2.11.10, 2.11.11rc1, 2.11.11, 2.11.12rc1, 2.11.12, 2.12.0b1, 2.12.0b2, 2.12.0rc1, 2.12.0, 2.12.1rc1, 2.12.1, 2.12.2rc1, 2.12.2, 2.12.3rc1, 2.12.3, 2.12.4rc1, 2.12.4, 2.12.5rc1, 2.12.5, 2.12.6rc1, 2.12.6, 2.12.7rc1, 2.12.7, 2.12.8rc1, 2.12.8, 2.12.9rc1, 2.12.9, 2.12.10rc1, 2.12.10, 2.13.0b0, 2.13.0b1, 2.13.0rc1, 2.13.0, 2.13.1rc1, 2.13.1, 2.13.2rc1, 2.13.2, 2.13.3rc1, 2.13.3, 2.13.4rc1, 2.13.4, 2.13.5rc1, 2.13.5, 2.13.6rc1, 2.13.6, 2.13.7rc1, 2.13.7, 2.13.8rc1, 2.13.8, 2.13.9rc1, 2.13.9, 2.13.10rc1, 2.13.10, 2.13.11rc1, 2.13.11, 2.13.12rc1, 2.13.12, 2.13.13rc1, 2.13.13, 2.14.0b1, 2.14.0b2, 2.14.0b3, 2.14.0rc1, 2.14.0rc1.post0, 2.14.0rc2, 2.14.0, 2.14.1rc1, 2.14.1, 2.14.2rc1, 2.14.2, 2.14.3rc1, 2.14.3, 2.14.4rc1, 2.14.4, 2.14.5rc1, 2.14.5, 2.14.6rc1, 2.14.6, 2.14.7rc1, 2.14.7, 2.14.8rc1, 2.14.8, 2.14.9rc1, 2.14.9, 2.14.10rc1, 2.14.10, 2.14.11rc1, 2.14.11, 2.14.12rc1, 2.14.12, 2.14.13, 2.14.14rc1, 2.14.14, 2.14.15rc1, 2.14.15, 2.14.16rc1, 2.14.16, 2.14.17rc1, 2.14.17, 2.15.0b1, 2.15.0b2, 2.15.0b3, 2.15.0rc1, 2.15.0rc2, 2.15.0, 2.15.1rc1, 2.15.1, 2.15.2rc1, 2.15.2, 2.15.3rc1, 2.15.3, 2.15.4rc1, 2.15.4, 2.15.5rc1, 2.15.5, 2.15.6rc1, 2.15.6, 2.15.7rc1, 2.15.7, 2.15.8, 2.15.9rc1, 2.15.9, 2.15.10rc1, 2.15.10, 2.15.11rc1, 2.15.11, 2.15.12rc1, 2.15.12)\nERROR: No matching distribution found for ansible-core\u003c2.18,\u003e\u003d2.16\n\n[notice] A new release of pip is available: 23.0.1 -\u003e 24.2\n[notice] To update, run: pip install --upgrade pip","commit_id":"eea5d11e787c7984ab630bdb8fbd490478a4efd3"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b3269451152fa1ab50bdd056462ab72c97ea6a92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"00fe7ed2_5680d615","updated":"2024-09-13 20:55:56.000000000","message":"Hmm, if kolla-ansible can\u0027t be installed under python3.9 ...why we still support \u003e python3.8 ? \n\nmichalarbet@pixla:~/ultimum/git/upstream/kolla-ansible$ egrep -R \u0027^ANSIBLE_VERSION_MIN.*\u003d|^ANSIBLE_VERSION_MAX.*\u003d\u0027 tools/\ntools/kolla-ansible:ANSIBLE_VERSION_MIN\u003d2.16\ntools/kolla-ansible:ANSIBLE_VERSION_MAX\u003d2.17\n\nmichalarbet@pixla:~/ultimum/git/upstream/kolla-ansible$ grep -ri python setup.cfg \npython_requires \u003d \u003e\u003d3.8\n    Programming Language :: Python\n    Programming Language :: Python :: Implementation :: CPython\n    Programming Language :: Python :: 3 :: Only\n    Programming Language :: Python :: 3\n    Programming Language :: Python :: 3.8\n    Programming Language :: Python :: 3.9\n    Programming Language :: Python :: 3.10\n    Programming Language :: Python :: 3.11","commit_id":"eea5d11e787c7984ab630bdb8fbd490478a4efd3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"698dfbe8f2c0e56b042be8b39dda50046f78a7c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5e8629d2_51ab3348","updated":"2024-09-25 13:00:33.000000000","message":"this needs a rebase, doesn\u0027t make sense to +2 in the current non-mergeable state","commit_id":"48e9490596ff5db7e495b5e4cf85a62a54c0f33a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4e2f976a23732a43dcf7f38e0a426017091ffb84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1ef7ee83_089a4537","in_reply_to":"5e8629d2_51ab3348","updated":"2024-09-25 13:01:41.000000000","message":"ack","commit_id":"48e9490596ff5db7e495b5e4cf85a62a54c0f33a"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"ecc46e7474db4c397d17722ba98636be547bc286","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"f65f0443_4ef05289","updated":"2024-09-26 08:46:00.000000000","message":"Seems reasonable. I think we can then remove references to install ansible-core for the tests and docs, e.g:\n\n- https://github.com/openstack/kolla-ansible/blob/1cf6c3af3b17dc2877889fabd931cfa9d0971da4/tests/run.yml#L700\n- https://github.com/openstack/kolla-ansible/blob/1cf6c3af3b17dc2877889fabd931cfa9d0971da4/doc/source/user/quickstart-development.rst?plain\u003d1#L99","commit_id":"62d47d51aec4bed164a4d3ef376549efde164ca9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0ce4dcc8a603ca0f47f7d43fd52e424fc085e017","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7eb60f8b_ea41d935","updated":"2024-09-26 11:02:29.000000000","message":"recheck as ova returned none which is not parseable - CI stuff","commit_id":"828547189f1875518bf03ba06409863cfc5a2b6c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4dd8ad9f159e5e06d95b691a471dc840d7bbdefc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"6d5f4d8e_f563cafe","updated":"2024-09-30 19:40:01.000000000","message":" intermittent issue ubuntu upgrade","commit_id":"c02d736ba74af01be1a7da0409b43388c1205f25"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a263f3920afcaf4a67c3a29d5d7d5d805d5e3ed6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ef661e38_e37954f4","updated":"2024-09-30 17:20:31.000000000","message":"From the last two +2 approvals by frickler and mnasiadka, only the duplicate entry was removed from the test-requirements, which also led to changing the commit message. Therefore, I\u0027m granting +w and merging it, as it has been here also unnecessarily long.","commit_id":"c02d736ba74af01be1a7da0409b43388c1205f25"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5048da4f445bf4d4e82144f3be46741959141eb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"19181ab5_d85a3060","updated":"2024-09-30 19:40:30.000000000","message":"recheck intermittent issue ubuntu upgrade","commit_id":"c02d736ba74af01be1a7da0409b43388c1205f25"}],"requirements.txt":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"04a3c9333b9bc7e22167511906d40806eeac909c","unresolved":true,"context_lines":[{"line_number":22,"context_line":"# Password hashing"},{"line_number":23,"context_line":"bcrypt\u003e\u003d3.0.0 # Apache-2.0"},{"line_number":24,"context_line":"passlib[bcrypt]\u003e\u003d1.0.0 # BSD"},{"line_number":25,"context_line":"ansible-core\u003e\u003d2.15,\u003c2.17 # GPLv3"}],"source_content_type":"text/plain","patch_set":5,"id":"5b241dc7_a9da851f","line":25,"updated":"2024-08-20 11:21:39.000000000","message":"keep to the current structure? maybe bundle that with jmespath which is Ansible related?","commit_id":"03b7a44e29fa4b400c01fba98ce1bd72762d8579"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c165a53e1d8a913d3131284d6634f202841f6644","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# Password hashing"},{"line_number":23,"context_line":"bcrypt\u003e\u003d3.0.0 # Apache-2.0"},{"line_number":24,"context_line":"passlib[bcrypt]\u003e\u003d1.0.0 # BSD"},{"line_number":25,"context_line":"ansible-core\u003e\u003d2.15,\u003c2.17 # GPLv3"}],"source_content_type":"text/plain","patch_set":5,"id":"e1ce9dd7_f6163604","line":25,"in_reply_to":"5b241dc7_a9da851f","updated":"2024-08-20 14:13:54.000000000","message":"Done","commit_id":"03b7a44e29fa4b400c01fba98ce1bd72762d8579"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c1c141577b18c8f0a9354ee5a4b603a9697479ab","unresolved":true,"context_lines":[{"line_number":14,"context_line":"Jinja2\u003e\u003d3 # BSD License (3 clause)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Ansible and ansible\u0027s json_query"},{"line_number":17,"context_line":"ansible-core\u003e\u003d2.15,\u003c2.17 # GPLv3"},{"line_number":18,"context_line":"jmespath\u003e\u003d0.9.3 # MIT"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Hashicorp Vault"}],"source_content_type":"text/plain","patch_set":6,"id":"3d788612_f0874ed5","line":17,"updated":"2024-08-23 12:40:25.000000000","message":"\u003c2.17 seems wrong, we do test with 2.17 already\n\nI\u0027m not sure we need to cap this here at all?","commit_id":"1d86a7bd4fd722409a1e611e2e32962cd614114c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2a2d145e8f79b78ae56f7528db3fa6dc5b23be07","unresolved":true,"context_lines":[{"line_number":14,"context_line":"Jinja2\u003e\u003d3 # BSD License (3 clause)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Ansible and ansible\u0027s json_query"},{"line_number":17,"context_line":"ansible-core\u003e\u003d2.15,\u003c2.17 # GPLv3"},{"line_number":18,"context_line":"jmespath\u003e\u003d0.9.3 # MIT"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Hashicorp Vault"}],"source_content_type":"text/plain","patch_set":6,"id":"adcbe237_f1ce6baf","line":17,"in_reply_to":"3d788612_f0874ed5","updated":"2024-08-23 14:20:07.000000000","message":"agreed","commit_id":"1d86a7bd4fd722409a1e611e2e32962cd614114c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0ea0c6c55f714b40664751310dbdf9d699bf165d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Jinja2\u003e\u003d3 # BSD License (3 clause)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Ansible and ansible\u0027s json_query"},{"line_number":17,"context_line":"ansible-core\u003e\u003d2.15,\u003c2.17 # GPLv3"},{"line_number":18,"context_line":"jmespath\u003e\u003d0.9.3 # MIT"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Hashicorp Vault"}],"source_content_type":"text/plain","patch_set":6,"id":"6ecb0830_18777ecb","line":17,"in_reply_to":"adcbe237_f1ce6baf","updated":"2024-09-02 12:32:30.000000000","message":"Done","commit_id":"1d86a7bd4fd722409a1e611e2e32962cd614114c"}],"test-requirements.txt":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"04a3c9333b9bc7e22167511906d40806eeac909c","unresolved":true,"context_lines":[{"line_number":5,"context_line":"docker\u003e\u003d2.4.2 # Apache-2.0"},{"line_number":6,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":7,"context_line":"stestr\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":8,"context_line":"ansible-core\u003e\u003d2.15,\u003c2.17 # GPLv3"}],"source_content_type":"text/plain","patch_set":5,"id":"9618b14e_6856a9c8","line":8,"updated":"2024-08-20 11:21:39.000000000","message":"sort it alphabetically?","commit_id":"03b7a44e29fa4b400c01fba98ce1bd72762d8579"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c165a53e1d8a913d3131284d6634f202841f6644","unresolved":false,"context_lines":[{"line_number":5,"context_line":"docker\u003e\u003d2.4.2 # Apache-2.0"},{"line_number":6,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":7,"context_line":"stestr\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":8,"context_line":"ansible-core\u003e\u003d2.15,\u003c2.17 # GPLv3"}],"source_content_type":"text/plain","patch_set":5,"id":"ff5b6bc9_78b6800f","line":8,"in_reply_to":"9618b14e_6856a9c8","updated":"2024-08-20 14:13:54.000000000","message":"Done","commit_id":"03b7a44e29fa4b400c01fba98ce1bd72762d8579"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2d013fe780502959a771e19ca07e3149c71de51e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# ansible"},{"line_number":2,"context_line":"ansible-core\u003e\u003d2.16,\u003c2.18 # GPLv3"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# coverage testing"},{"line_number":5,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":15,"id":"c5cda6fc_e6f35717","line":2,"updated":"2024-09-26 10:24:53.000000000","message":"Actually looking at this once again, I wonder if this is in requirements.txt, why should we need to duplicate it here, which might lead to inconsistent version caps if we are not careful? Why not just drop this?","commit_id":"828547189f1875518bf03ba06409863cfc5a2b6c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"010e742268e750186b7d586130a8d4ef7c40c8f4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# ansible"},{"line_number":2,"context_line":"ansible-core\u003e\u003d2.16,\u003c2.18 # GPLv3"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# coverage testing"},{"line_number":5,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":15,"id":"a2f71c4f_634ecbb4","line":2,"in_reply_to":"229b9c58_dd56affe","updated":"2024-09-26 12:51:06.000000000","message":"it\u0027s test requirements ... actually this was the line which show me that it\u0027s unsupported in py389... (if I remember correctly)... I will try to find the patch number where it showed ..","commit_id":"828547189f1875518bf03ba06409863cfc5a2b6c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"87d2fb9aa200bcdfae8986c38b80e762f1c0569f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# ansible"},{"line_number":2,"context_line":"ansible-core\u003e\u003d2.16,\u003c2.18 # GPLv3"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# coverage testing"},{"line_number":5,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":15,"id":"bc92bf72_63043cd4","line":2,"in_reply_to":"8489fabd_4a004415","updated":"2024-09-30 13:48:48.000000000","message":"Done - unduplicated, commit message changed.","commit_id":"828547189f1875518bf03ba06409863cfc5a2b6c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bdedb55e12f67b8d2714fc8fa06e48b80f381c73","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# ansible"},{"line_number":2,"context_line":"ansible-core\u003e\u003d2.16,\u003c2.18 # GPLv3"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# coverage testing"},{"line_number":5,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":15,"id":"8489fabd_4a004415","line":2,"in_reply_to":"a2f71c4f_634ecbb4","updated":"2024-09-28 09:03:03.000000000","message":"can this be marked as resolved @michal.arbet@ultimum.io ?","commit_id":"828547189f1875518bf03ba06409863cfc5a2b6c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"964d1fe669a635db005569c0d42722c482138cdc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# ansible"},{"line_number":2,"context_line":"ansible-core\u003e\u003d2.16,\u003c2.18 # GPLv3"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# coverage testing"},{"line_number":5,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":15,"id":"229b9c58_dd56affe","line":2,"in_reply_to":"c5cda6fc_e6f35717","updated":"2024-09-26 11:48:25.000000000","message":"let\u0027s try unduplicating","commit_id":"828547189f1875518bf03ba06409863cfc5a2b6c"}]}