)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"17424969124b78653f77e82a2feb69d74acf7c57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2671fdac_c69c68d7","updated":"2024-06-24 08:48:10.000000000","message":"Does this mean we support interface names with dashes now?\n\nIf so, we could remove this note:\n\n```\n.. warning::\n\n   Ansible facts does not recognize interface names containing dashes,\n   in example ``br-ex`` or ``bond-0`` cannot be used because ansible will read\n   them as ``br_ex`` and ``bond_0`` respectively.\n   \n```\n\nin `doc/source/admin/production-architecture-guide.rst`","commit_id":"97196c81705315783e20a8b0af2a1c6c8c76f5ae"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"fc4a2fff0bdeb225d24617310b3a8dcd97b65a1c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b5afb5d6_e6adf622","in_reply_to":"1f67f084_2f0977cb","updated":"2024-06-24 09:48:57.000000000","message":"Thanks. I rebased Mark\u0027s old patch to see if there are any other gremlins.\n\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/794545","commit_id":"97196c81705315783e20a8b0af2a1c6c8c76f5ae"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"587af28a0530f4b8cab4e9683604d6abc111b6b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1f67f084_2f0977cb","in_reply_to":"2671fdac_c69c68d7","updated":"2024-06-24 09:19:19.000000000","message":"Yup, removed.","commit_id":"97196c81705315783e20a8b0af2a1c6c8c76f5ae"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"269dfa3fbd8d6663a2a5511c793e17af78390b35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a4ff3eeb_0a6e323c","in_reply_to":"b5afb5d6_e6adf622","updated":"2024-06-28 16:46:09.000000000","message":"Acknowledged","commit_id":"97196c81705315783e20a8b0af2a1c6c8c76f5ae"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"be6aaff0631bb6b0df805260dd9de2bdd1e548b6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c8f25dc8_e347e716","updated":"2024-06-24 14:36:06.000000000","message":"I think this comment from the other patchset should be addressed here:\n\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/794545/comment/7503326f_729a32bd/","commit_id":"20302a84e8c18b908a8b7ef27202780f2583f58f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f67c53194939de566feb51aeb27307be65d2a7c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a174c7ea_a2928e34","updated":"2024-06-24 09:19:12.000000000","message":"not sure if we should backport this.\nCode LGTM","commit_id":"20302a84e8c18b908a8b7ef27202780f2583f58f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f8e8a5d56b5bf655f911831fe00216ac7084cff7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a1f9f8e2_b6256bfe","in_reply_to":"5506aeec_ef978a9d","updated":"2024-07-05 11:58:04.000000000","message":"Done","commit_id":"20302a84e8c18b908a8b7ef27202780f2583f58f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"269dfa3fbd8d6663a2a5511c793e17af78390b35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7e79b331_fd5550df","in_reply_to":"80e45a82_80f2de5b","updated":"2024-06-28 16:46:09.000000000","message":"Acknowledged","commit_id":"20302a84e8c18b908a8b7ef27202780f2583f58f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"fc4a2fff0bdeb225d24617310b3a8dcd97b65a1c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"80e45a82_80f2de5b","in_reply_to":"a174c7ea_a2928e34","updated":"2024-06-24 09:48:57.000000000","message":"I had a quick dig and it seems that this has been treated as a bug in the past [1] so should be fine to backport as you suggested.\n\n[1] https://bugs.launchpad.net/kolla-ansible/+bug/1927357","commit_id":"20302a84e8c18b908a8b7ef27202780f2583f58f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c71cbf6ffddc4d9792780f4570011a885f1fae50","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5506aeec_ef978a9d","in_reply_to":"c8f25dc8_e347e716","updated":"2024-06-24 14:40:26.000000000","message":"this pattern is also used in:\n\n- `kolla-ansible/test/run.yml`\n- actually two times in above mentioned `roles/cephadm/tasks/main.yml`\n- it\u0027s also in the docs in `doc/source/reference/logging-and-monitoring/prometheus-guide.rst`\n\njust grep for `ansible_\u0027`\n\nso please fix those as well.","commit_id":"20302a84e8c18b908a8b7ef27202780f2583f58f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"627af9a6938ae8a1415ecbcb2c23b590c8cd2893","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"0b4c4127_073ccb39","updated":"2024-07-11 07:58:59.000000000","message":"recheck (depends on merged)","commit_id":"a535e65a85aa99af2e42a22a891de79a172bd033"}],"ansible/roles/rabbitmq/tasks/precheck.yml":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"290481545e7c17673fa00ebe9a4988d32964ac54","unresolved":true,"context_lines":[{"line_number":67,"context_line":"  register: rabbitmq_hostnames"},{"line_number":68,"context_line":"  with_items: \"{{ groups[\u0027rabbitmq\u0027] }}\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- name: Print rabbitmq_hostnames"},{"line_number":71,"context_line":"  debug:"},{"line_number":72,"context_line":"    var: rabbitmq_hostnames"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"- name: Print resolution"},{"line_number":75,"context_line":"  debug:"},{"line_number":76,"context_line":"    msg: \"{{ \u0027api\u0027 | kolla_address(item.0.item) }}\""},{"line_number":77,"context_line":"  with_subelements:"},{"line_number":78,"context_line":"    - \"{{ rabbitmq_hostnames.results }}\""},{"line_number":79,"context_line":"    - stdout_lines"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"- name: Check if each rabbit hostname resolves uniquely to the proper IP address"},{"line_number":82,"context_line":"  fail:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"27ce6dbf_6e242c47","line":79,"range":{"start_line":70,"start_character":0,"end_line":79,"end_character":18},"updated":"2024-07-09 10:58:04.000000000","message":"I don\u0027t think we want to merge debug tasks ...","commit_id":"21027435b719dcc75c9ca93de78702e6356f971e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ee1f89da296f0c1970d7f4915b48cd3479abd0aa","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  register: rabbitmq_hostnames"},{"line_number":68,"context_line":"  with_items: \"{{ groups[\u0027rabbitmq\u0027] }}\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- name: Print rabbitmq_hostnames"},{"line_number":71,"context_line":"  debug:"},{"line_number":72,"context_line":"    var: rabbitmq_hostnames"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"- name: Print resolution"},{"line_number":75,"context_line":"  debug:"},{"line_number":76,"context_line":"    msg: \"{{ \u0027api\u0027 | kolla_address(item.0.item) }}\""},{"line_number":77,"context_line":"  with_subelements:"},{"line_number":78,"context_line":"    - \"{{ rabbitmq_hostnames.results }}\""},{"line_number":79,"context_line":"    - stdout_lines"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"- name: Check if each rabbit hostname resolves uniquely to the proper IP address"},{"line_number":82,"context_line":"  fail:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3250dadd_fa86ad6e","line":79,"range":{"start_line":70,"start_character":0,"end_line":79,"end_character":18},"in_reply_to":"27ce6dbf_6e242c47","updated":"2024-07-09 10:59:20.000000000","message":"doh! good catch","commit_id":"21027435b719dcc75c9ca93de78702e6356f971e"}],"roles/cephadm/tasks/main.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"93bbc105d126c8998cf783f9da8f2883afb66c54","unresolved":true,"context_lines":[{"line_number":80,"context_line":"    ceph_conf_fixed: |"},{"line_number":81,"context_line":"      [global]"},{"line_number":82,"context_line":"      fsid \u003d {{ ceph_fsid }}"},{"line_number":83,"context_line":"      mon_host \u003d {% for host in groups[\u0027all\u0027] %} {{ hostvars[host][\u0027ansible_\u0027 + api_interface_name].ipv4.address }} {% if not loop.last %},{% endif %} {% endfor %}"},{"line_number":84,"context_line":"  copy:"},{"line_number":85,"context_line":"    content: \"{{ ceph_conf_fixed }}\""},{"line_number":86,"context_line":"    dest: \"/etc/ceph/ceph.conf.fixed\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"807f35bb_57812c7b","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":2},"updated":"2024-06-28 10:40:30.000000000","message":"please fix it here as well.\n```suggestion\n      mon_host \u003d {% for host in groups[\u0027all\u0027] %} {{ hostvars[host][\u0027ansible_\u0027 + api_interface_name | replace(\u0027-\u0027,\u0027_\u0027)].ipv4.address }} {% if not loop.last %},{% endif %} {% endfor %}\n```","commit_id":"80bf86cf4edee056f20291a3fb5b0e16d87edf1f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"269dfa3fbd8d6663a2a5511c793e17af78390b35","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    ceph_conf_fixed: |"},{"line_number":81,"context_line":"      [global]"},{"line_number":82,"context_line":"      fsid \u003d {{ ceph_fsid }}"},{"line_number":83,"context_line":"      mon_host \u003d {% for host in groups[\u0027all\u0027] %} {{ hostvars[host][\u0027ansible_\u0027 + api_interface_name].ipv4.address }} {% if not loop.last %},{% endif %} {% endfor %}"},{"line_number":84,"context_line":"  copy:"},{"line_number":85,"context_line":"    content: \"{{ ceph_conf_fixed }}\""},{"line_number":86,"context_line":"    dest: \"/etc/ceph/ceph.conf.fixed\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"69af5d52_0b5628df","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":2},"in_reply_to":"807f35bb_57812c7b","updated":"2024-06-28 16:46:09.000000000","message":"Fix applied.","commit_id":"80bf86cf4edee056f20291a3fb5b0e16d87edf1f"}]}