)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"31a748305151e622cf295f0b6cbd585a4ba046ca","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cc9d1bb7_34d4aafe","updated":"2024-08-20 15:05:56.000000000","message":"I think this is prior art: https://review.opendev.org/c/openstack/kolla-ansible/+/857003\n\ncan we abandon this patchset, please? (and merge soon the linked one, I also worked on this, creating yet another patchset..)","commit_id":"884712127da8ff83969a7d62399e03e69253e59e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2a5e1b06fe52572ed4cad8a5c2961f86c679b1ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bcf616eb_e52f8e4c","updated":"2024-06-24 14:08:19.000000000","message":"LGTM from the dependency side (packaging is in u-c).","commit_id":"884712127da8ff83969a7d62399e03e69253e59e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8e25860ff4b387a67a8e998ae9e0563029ca729a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fbf46900_bfb99379","updated":"2024-08-20 13:55:54.000000000","message":"recheck to get fresh logs","commit_id":"884712127da8ff83969a7d62399e03e69253e59e"}],"ansible/library/kolla_toolbox.py":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4b5adcdf6dc1810a911a6fab9a72fa24f74c2a28","unresolved":true,"context_lines":[{"line_number":117,"context_line":"    if params.get(\u0027module_name\u0027):"},{"line_number":118,"context_line":"        command.extend([\u0027-m\u0027, params.get(\u0027module_name\u0027)])"},{"line_number":119,"context_line":"    if params.get(\u0027module_args\u0027):"},{"line_number":120,"context_line":"        if Version(ansible_version) \u003c Version(\u00272.11.0\u0027):"},{"line_number":121,"context_line":"            module_args \u003d params.get(\u0027module_args\u0027)"},{"line_number":122,"context_line":"        else:"},{"line_number":123,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"39c6ad78_5c42cab4","line":120,"updated":"2024-06-24 13:49:10.000000000","message":"2.11 was long time ago, let\u0027s drop that if statement?","commit_id":"884712127da8ff83969a7d62399e03e69253e59e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4b5adcdf6dc1810a911a6fab9a72fa24f74c2a28","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"def docker_supports_environment_in_exec(client):"},{"line_number":151,"context_line":"    docker_version \u003d Version(client.api_version)"},{"line_number":152,"context_line":"    return docker_version \u003e\u003d Version(\u00271.25\u0027)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def use_docker(module):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ef9e276a_6f2a689d","line":152,"updated":"2024-06-24 13:49:10.000000000","message":"same here - https://docs.docker.com/engine/api/#api-version-matrix","commit_id":"884712127da8ff83969a7d62399e03e69253e59e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5e93537bb37bde16c12f67727a64e86c57684a6a","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"def docker_supports_environment_in_exec(client):"},{"line_number":151,"context_line":"    docker_version \u003d Version(client.api_version)"},{"line_number":152,"context_line":"    return docker_version \u003e\u003d Version(\u00271.25\u0027)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def use_docker(module):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7b2b31f1_90d9cbfb","line":152,"in_reply_to":"860e218b_9b97b0b6","updated":"2024-06-24 14:32:33.000000000","message":"I\u0027m just saying instead of fixing distutils usage - let\u0027s just drop this version checking crap - nobody should be using that old versions anymore.","commit_id":"884712127da8ff83969a7d62399e03e69253e59e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"50282de3f4360c81c4a7d612fbe948a7ba8b89ad","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"def docker_supports_environment_in_exec(client):"},{"line_number":151,"context_line":"    docker_version \u003d Version(client.api_version)"},{"line_number":152,"context_line":"    return docker_version \u003e\u003d Version(\u00271.25\u0027)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def use_docker(module):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fd586498_d7b06b01","line":152,"in_reply_to":"ed4a38f8_ef85c0c1","updated":"2024-06-24 14:15:42.000000000","message":"Hmm, I don\u0027t understand why -1 ? \n\nThis patch is fixing deprecation of distutils -\u003e packaging, I didn\u0027t touched docker version. \n\nSo if you think we can support docker \u003e 1.25, i am okay with it ..but it should be another patch with different commit message.","commit_id":"884712127da8ff83969a7d62399e03e69253e59e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2a5e1b06fe52572ed4cad8a5c2961f86c679b1ce","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"def docker_supports_environment_in_exec(client):"},{"line_number":151,"context_line":"    docker_version \u003d Version(client.api_version)"},{"line_number":152,"context_line":"    return docker_version \u003e\u003d Version(\u00271.25\u0027)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def use_docker(module):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ed4a38f8_ef85c0c1","line":152,"in_reply_to":"ef9e276a_6f2a689d","updated":"2024-06-24 14:08:19.000000000","message":"but do we want to support arbitrary docker api versions, or should we just bump the version?","commit_id":"884712127da8ff83969a7d62399e03e69253e59e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"094c576ead469b637075001396725d6ffb21df3c","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"def docker_supports_environment_in_exec(client):"},{"line_number":151,"context_line":"    docker_version \u003d Version(client.api_version)"},{"line_number":152,"context_line":"    return docker_version \u003e\u003d Version(\u00271.25\u0027)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def use_docker(module):"}],"source_content_type":"text/x-python","patch_set":1,"id":"860e218b_9b97b0b6","line":152,"in_reply_to":"fd586498_d7b06b01","updated":"2024-06-24 14:22:32.000000000","message":"*only \u003e 1.25 ... as per https://review.opendev.org/c/openstack/kolla-ansible/+/685700","commit_id":"884712127da8ff83969a7d62399e03e69253e59e"}]}