)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"11d0994e83a5332c7ea53e89c78e3ef5e50efbb1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6447befc_d371b26c","updated":"2024-06-25 15:41:30.000000000","message":"Can you link to some MariaDB release note or something similar for completeness?","commit_id":"09e05e0260c280e3b5510a265ff7411925051937"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ae3f530bc7d1094a50f71134b34cf4bce9d770da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6c1682e0_c2a71bf8","updated":"2024-09-18 16:45:52.000000000","message":"From the bug report, it is evident that this is not a database problem, but rather an issue with the user\u0027s permissions, as they cannot create a table in the given database. I have also personally tested this patch, and it does not resolve the bug at all. However, I agree that there is no need to create a separate database since the MySQL DB already exists. The only thing needed is to add the correct permission for the user. I will propose this in a different patch and change this one to a partial-bug.","commit_id":"09e05e0260c280e3b5510a265ff7411925051937"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a137042ef85bca405e7ebd21186407f0fb765a7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"adb93038_822599ff","in_reply_to":"2e19a96e_cf1457c8","updated":"2024-10-02 12:27:56.000000000","message":"Done","commit_id":"09e05e0260c280e3b5510a265ff7411925051937"},{"author":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"change_message_id":"927dcddcc3aec836694bfc88b43478adf3e38d91","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2e19a96e_cf1457c8","in_reply_to":"6447befc_d371b26c","updated":"2024-06-25 19:45:19.000000000","message":"Couldn\u0027t find a release note but I did find a reference here:\n\nhttps://mariadb.com/kb/en/mariabackup-options/#-history","commit_id":"09e05e0260c280e3b5510a265ff7411925051937"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2f33a6d1f0e39367af9c137dc158ea6e9e1b79e3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"e97ccf38_09c3568f","updated":"2024-09-23 09:14:11.000000000","message":"What happens with backups created with old schema?\n-1 for posterity","commit_id":"ebfcdda5c5781407132915c166ae1587ae820e30"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"13a5e4fa55c96246bfa1cbd432610b5c5695851f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"2dac1113_f6812d43","in_reply_to":"219def08_33dda15c","updated":"2024-09-23 09:33:46.000000000","message":"I was under the impression that for incremental backups - MariaDB is storing the LSNs in a table in mariabackup database (that\u0027s why we create one).\nIt would be good to test if we can do a restore of an old incremental backup when we change the schema - if not, then at least we need a reno.","commit_id":"ebfcdda5c5781407132915c166ae1587ae820e30"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1292c7be80be044c802cd3c57a6c963a507d98d5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3b0b701a_a24424fb","in_reply_to":"2a3273d4_39613b4e","updated":"2024-10-09 19:11:41.000000000","message":"I don\u0027t understand, default history schema was changed in mariadb itself..this patch just aligned table name with mariadb newer version.\n\nBut if you mean that we should add reno which will inform user that history for backups are now stored in different db and table name ..I can do it in follow up ... hmm ?","commit_id":"ebfcdda5c5781407132915c166ae1587ae820e30"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cd344c1c218c5c3339365d66c66d009fed28cf17","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c5f8035d_170cf59f","in_reply_to":"2dac1113_f6812d43","updated":"2024-09-23 09:35:56.000000000","message":"Let me check ..","commit_id":"ebfcdda5c5781407132915c166ae1587ae820e30"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8885661c778416dc0f685b05fcf8446162892489","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c38823ea_3fa15739","in_reply_to":"3b0b701a_a24424fb","updated":"2024-10-14 17:15:52.000000000","message":"Okay, I added this to kolla whiteboard to my \"sandbox\" as TODO.","commit_id":"ebfcdda5c5781407132915c166ae1587ae820e30"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9349c4e7535af823f223673192e56b5a9cdc06e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"d94cc375_500c28fe","in_reply_to":"5aca1405_c45e3cd2","updated":"2024-09-23 13:46:41.000000000","message":"This was tested and restore of backed database is not working (because of mariadb version - not because of this patch) \u003e\u003e\n\n2024-09-23 12:45:57 0 [ERROR] InnoDB: Upgrade after a crash is not supported. The redo log was created with MariaDB 10.6.18. You must start up and shut down MariaDB 10.7 or earlier.\n\n\nBut this was caused by mariadb version itself.\nThis raises the question of whether it\u0027s really okay to use a binary backup instead of mysqldump for example.\n\nAnyway, it was confirmed that although with difficulties and many manual steps, I was able to restore the database on an older version of MariaDB, which I then upgraded. The record in the backup database is really just for history.","commit_id":"ebfcdda5c5781407132915c166ae1587ae820e30"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d340e59a899f7b1bf9d3b60e51a45042617fe3bc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"219def08_33dda15c","in_reply_to":"6fc7a1b1_d2552fdc","updated":"2024-09-23 09:26:28.000000000","message":"Or do you think we should create mysqldump from the old one and import into the new one table ? Or just add reno to inform users to migrate old entries to the new table in new database ?","commit_id":"ebfcdda5c5781407132915c166ae1587ae820e30"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"fa8c17012e20d6f71c4c613cc00ee96cdd4b74db","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5aca1405_c45e3cd2","in_reply_to":"c5f8035d_170cf59f","updated":"2024-09-23 10:59:31.000000000","message":"From my perspective, this is really safe, since the table only contains history. The restore process doesn\u0027t interact with the database at all. This should be completely safe.\n\nHere\u0027s an example of the history in the MariaDB table:\n\n```\nMariaDB [PERCONA_SCHEMA]\u003e select * from xtrabackup_history;\n+--------------------------------------+------------+-------------+-------------------------------------------------------------------------------------------------------------------------+-----------------+------------------+-----------------------------+---------------------+---------------------+-----------+----------------------------------------------------------------------------------+-----------------+---------------+---------+-------------+--------+------------+\n| uuid                                 | name       | tool_name   | tool_command                                                                                                            | tool_version    | ibbackup_version | server_version              | start_time          | end_time            | lock_time | binlog_pos                                                                       | innodb_from_lsn | innodb_to_lsn | partial | incremental | format | compressed |\n+--------------------------------------+------------+-------------+-------------------------------------------------------------------------------------------------------------------------+-----------------+------------------+-----------------------------+---------------------+---------------------+-----------+----------------------------------------------------------------------------------+-----------------+---------------+---------+-------------+--------+------------+\n| 2c9d5390-7996-11ef-bc68-fa163e84ecfe | 23-09-2024 | mariabackup | --defaults-file\u003d/etc/mysql/my.cnf --backup --stream\u003dxbstream --history\u003d23-09-2024                                       | 10.6.18-MariaDB | 10.6.18-MariaDB  | 10.6.18-MariaDB-ubu2204-log | 2024-09-23 10:25:34 | 2024-09-23 10:25:37 |         0 | filename \u0027mysql-bin.000007\u0027, position \u002736652\u0027, GTID of the last change \u00270-1-108\u0027 |               0 |         54017 | N       | N           | tar    | N          |\n| 6e8f5bf0-7996-11ef-bc68-fa163e84ecfe | 23-09-2024 | mariabackup | --defaults-file\u003d/etc/mysql/my.cnf --backup --stream\u003dxbstream --incremental-history-name\u003d23-09-2024 --history\u003d23-09-2024 | 10.6.18-MariaDB | 10.6.18-MariaDB  | 10.6.18-MariaDB-ubu2204-log | 2024-09-23 10:27:24 | 2024-09-23 10:27:27 |         0 | filename \u0027mysql-bin.000007\u0027, position \u002739977\u0027, GTID of the last change \u00270-1-114\u0027 |           54017 |         54017 | N       | Y           | tar    | N          |\n+--------------------------------------+------------+-------------+-------------------------------------------------------------------------------------------------------------------------+-----------------+------------------+-----------------------------+---------------------+---------------------+-----------+----------------------------------------------------------------------------------+-----------------+---------------+---------+-------------+--------+------------+\n```","commit_id":"ebfcdda5c5781407132915c166ae1587ae820e30"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8f8d20d3ac6e7319b089cc8d3f58f365611505b6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"2a3273d4_39613b4e","in_reply_to":"d94cc375_500c28fe","updated":"2024-10-09 18:57:29.000000000","message":"just for completeness sake - as I was wondering and researching this - we are not using xtrabackup from percona, which actually uses this table, see:\n\nhttps://docs.percona.com/percona-xtrabackup/8.0/store-backup-history.html\n\nwe _may_ want to add a reno if we are nice to users using their own backup tooling, what do you think? I will not block on it though.","commit_id":"ebfcdda5c5781407132915c166ae1587ae820e30"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"847c0e58a60908dd0dd2e6d182986752590fe51c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"6fc7a1b1_d2552fdc","in_reply_to":"e97ccf38_09c3568f","updated":"2024-09-23 09:17:02.000000000","message":"of course nothing, they are still backed up on disk, just information in backup history is in older database. This was changed by upstream mariadb ...not us.","commit_id":"ebfcdda5c5781407132915c166ae1587ae820e30"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a137042ef85bca405e7ebd21186407f0fb765a7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"9491de02_afbcac86","updated":"2024-10-02 12:27:56.000000000","message":"recheck new image","commit_id":"9f63a9da03b07de1e146da67a1a854fcb9eb0e71"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8f8d20d3ac6e7319b089cc8d3f58f365611505b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"73118685_8486487c","updated":"2024-10-09 18:57:29.000000000","message":"recheck unrelated neutron sql connection error\n\nerror was:\n```\n/var/log/kolla/neutron/neutron-server.log\n\n2024-10-09 16:32:54.031 1043 CRITICAL keystonemiddleware.auth_token [-] Unable to validate token: Failed to fetch token data from identity server: keystonemiddleware.auth_token._exceptions.ServiceError: Failed to fetch token data from identity server\n\n2024-10-09 16:41:24.043 1046 CRITICAL neutron [None req-c23d7e31-aa0f-46d7-8c21-d91e1a0d6a15 - - - - - -] Unhandled error: sqlalchemy.exc.OperationalError: (pymysql.err.OperationalError) (9001, \u0027Max connect timeout reached while reaching hostgroup 0 after 10000ms\u0027)\n```","commit_id":"3112ecabdafee045a097645ea045ca73799af273"}],"ansible/roles/mariadb/tasks/register.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a35d1e4882b1bfe5e17827520bdfa702d7ea5f62","unresolved":true,"context_lines":[{"line_number":33,"context_line":"  when:"},{"line_number":34,"context_line":"    - inventory_hostname \u003d\u003d groups[mariadb_shard_group][0]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- name: Creating the Mariabackup database"},{"line_number":37,"context_line":"  become: true"},{"line_number":38,"context_line":"  kolla_toolbox:"},{"line_number":39,"context_line":"    container_engine: \"{{ kolla_container_engine }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"17b7e143_5a30e254","side":"PARENT","line":36,"updated":"2024-09-23 16:36:56.000000000","message":"Should we remove that database in upgrade?","commit_id":"b724fedce6aedf90e20b7b1db00fe005b09f3c75"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a137042ef85bca405e7ebd21186407f0fb765a7b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  when:"},{"line_number":34,"context_line":"    - inventory_hostname \u003d\u003d groups[mariadb_shard_group][0]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- name: Creating the Mariabackup database"},{"line_number":37,"context_line":"  become: true"},{"line_number":38,"context_line":"  kolla_toolbox:"},{"line_number":39,"context_line":"    container_engine: \"{{ kolla_container_engine }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ae2f4d15_c55f6a45","side":"PARENT","line":36,"in_reply_to":"17b7e143_5a30e254","updated":"2024-10-02 12:27:56.000000000","message":"We shouldn\u0027t - there is still history of backups, operator should if he want.","commit_id":"b724fedce6aedf90e20b7b1db00fe005b09f3c75"}]}