)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b9bea26f3a3f6047b99deac17091d9d2f1e99d9f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Parent:     63cf525a (CI: Increase RADOS timeout for cephadm jobs)"},{"line_number":2,"context_line":"Author:     Jörn Kaster \u003cjoern.kaster@epg.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2024-06-27 12:37:53 +0200"},{"line_number":4,"context_line":"Commit:     Jörn Kaster \u003cjoern.kaster@epg.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"62516e26_54f55dd7","line":1,"updated":"2024-06-27 11:19:10.000000000","message":"Could you please make this summary shorter please?","commit_id":"04f3282766c08c6953e7542f3c8dc7418008eb5e"},{"author":{"_account_id":35875,"name":"Jörn Kaster","display_name":"joek-office","email":"joern.kaster@epg.com","username":"joek-office"},"change_message_id":"cd50f940384a5a29fd31c4e3a1f1d854278f96ba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     63cf525a (CI: Increase RADOS timeout for cephadm jobs)"},{"line_number":2,"context_line":"Author:     Jörn Kaster \u003cjoern.kaster@epg.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2024-06-27 12:37:53 +0200"},{"line_number":4,"context_line":"Commit:     Jörn Kaster \u003cjoern.kaster@epg.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3b0ed333_af0ff187","line":1,"in_reply_to":"62516e26_54f55dd7","updated":"2024-07-17 07:35:08.000000000","message":"Acknowledged","commit_id":"04f3282766c08c6953e7542f3c8dc7418008eb5e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"db84a0c5e7f9581df48a7cf2d1fae9f2bf6f423e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     63cf525a (CI: Increase RADOS timeout for cephadm jobs)"},{"line_number":2,"context_line":"Author:     Jörn Kaster \u003cjoern.kaster@epg.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2024-06-27 12:37:53 +0200"},{"line_number":4,"context_line":"Commit:     Jörn Kaster \u003cjoern.kaster@epg.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e18019fc_06f0b859","line":1,"in_reply_to":"62516e26_54f55dd7","updated":"2024-07-16 14:53:32.000000000","message":"Done","commit_id":"04f3282766c08c6953e7542f3c8dc7418008eb5e"}],"ansible/roles/prometheus/defaults/main.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f2025e27312356914a586c41e8b5d455fb075317","unresolved":true,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"prometheus_openstack_exporter_disabled_volume: \"{{ \u0027--disable-service.volume\u0027 if not enable_cinder | bool else \u0027\u0027 }}\""},{"line_number":326,"context_line":"prometheus_openstack_exporter_disabled_dns: \"{{ \u0027--disable-service.dns\u0027 if not enable_designate | bool else \u0027\u0027 }}\""},{"line_number":327,"context_line":"prometheus_openstack_exporter_disabled_object: \"{{ \u0027--disable-service.object-store\u0027 if (not enable_swift | bool and not enable_ceph_rgw | bool) else \u0027\u0027 }}\""},{"line_number":328,"context_line":"prometheus_openstack_exporter_disabled_lb: \"{{ \u0027--disable-service.load-balancer --disable-metric\u003dneutron-loadbalancers --disable-metric\u003dneutron-loadbalancers_not_active\u0027 if not enable_octavia | bool else \u0027\u0027 }}\""},{"line_number":329,"context_line":"prometheus_openstack_exporter_disabled_items: \"{{ [prometheus_openstack_exporter_disabled_volume, prometheus_openstack_exporter_disabled_dns, prometheus_openstack_exporter_disabled_object, prometheus_openstack_exporter_disabled_lb | trim] | join(\u0027 \u0027) | trim }}\""},{"line_number":330,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5e50ebe1_207b18a5","line":327,"range":{"start_line":327,"start_character":84,"end_line":327,"end_character":143},"updated":"2024-06-27 15:57:25.000000000","message":"with de morgans law[1] we can write instead:\n\n```suggestion\nprometheus_openstack_exporter_disabled_object: \"{{ \u0027--disable-service.object-store\u0027 if not ( enable_swift | bool or enable_ceph_rgw | bool) else \u0027\u0027 }}\"\n```\n\nwhich is a little bit easier to understand imho.\n\nWhat do you think?\n\n[1]: https://en.wikipedia.org/wiki/De_Morgan%27s_laws","commit_id":"4f8cd2b23c9906f2f5bc713967bbe9cb622f2ce6"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"16542715931c1983192e3190e7701cce3ad54f01","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"prometheus_openstack_exporter_disabled_volume: \"{{ \u0027--disable-service.volume\u0027 if not enable_cinder | bool else \u0027\u0027 }}\""},{"line_number":326,"context_line":"prometheus_openstack_exporter_disabled_dns: \"{{ \u0027--disable-service.dns\u0027 if not enable_designate | bool else \u0027\u0027 }}\""},{"line_number":327,"context_line":"prometheus_openstack_exporter_disabled_object: \"{{ \u0027--disable-service.object-store\u0027 if (not enable_swift | bool and not enable_ceph_rgw | bool) else \u0027\u0027 }}\""},{"line_number":328,"context_line":"prometheus_openstack_exporter_disabled_lb: \"{{ \u0027--disable-service.load-balancer --disable-metric\u003dneutron-loadbalancers --disable-metric\u003dneutron-loadbalancers_not_active\u0027 if not enable_octavia | bool else \u0027\u0027 }}\""},{"line_number":329,"context_line":"prometheus_openstack_exporter_disabled_items: \"{{ [prometheus_openstack_exporter_disabled_volume, prometheus_openstack_exporter_disabled_dns, prometheus_openstack_exporter_disabled_object, prometheus_openstack_exporter_disabled_lb | trim] | join(\u0027 \u0027) | trim }}\""},{"line_number":330,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a1a59ad1_f3beeac2","line":327,"range":{"start_line":327,"start_character":84,"end_line":327,"end_character":143},"in_reply_to":"2c40633b_04d6c720","updated":"2024-07-17 19:09:44.000000000","message":"Sven, in modern programming languages, due to the optimization of compilers and interpreters, the performance differences between these options are negligible or completely absent.","commit_id":"4f8cd2b23c9906f2f5bc713967bbe9cb622f2ce6"},{"author":{"_account_id":35875,"name":"Jörn Kaster","display_name":"joek-office","email":"joern.kaster@epg.com","username":"joek-office"},"change_message_id":"cd50f940384a5a29fd31c4e3a1f1d854278f96ba","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"prometheus_openstack_exporter_disabled_volume: \"{{ \u0027--disable-service.volume\u0027 if not enable_cinder | bool else \u0027\u0027 }}\""},{"line_number":326,"context_line":"prometheus_openstack_exporter_disabled_dns: \"{{ \u0027--disable-service.dns\u0027 if not enable_designate | bool else \u0027\u0027 }}\""},{"line_number":327,"context_line":"prometheus_openstack_exporter_disabled_object: \"{{ \u0027--disable-service.object-store\u0027 if (not enable_swift | bool and not enable_ceph_rgw | bool) else \u0027\u0027 }}\""},{"line_number":328,"context_line":"prometheus_openstack_exporter_disabled_lb: \"{{ \u0027--disable-service.load-balancer --disable-metric\u003dneutron-loadbalancers --disable-metric\u003dneutron-loadbalancers_not_active\u0027 if not enable_octavia | bool else \u0027\u0027 }}\""},{"line_number":329,"context_line":"prometheus_openstack_exporter_disabled_items: \"{{ [prometheus_openstack_exporter_disabled_volume, prometheus_openstack_exporter_disabled_dns, prometheus_openstack_exporter_disabled_object, prometheus_openstack_exporter_disabled_lb | trim] | join(\u0027 \u0027) | trim }}\""},{"line_number":330,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2c40633b_04d6c720","line":327,"range":{"start_line":327,"start_character":84,"end_line":327,"end_character":143},"in_reply_to":"5e50ebe1_207b18a5","updated":"2024-07-17 07:35:08.000000000","message":"Sounds good to me.","commit_id":"4f8cd2b23c9906f2f5bc713967bbe9cb622f2ce6"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"128eaa07b6f917557af45f9e6a78a7bb09bb49fd","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"prometheus_openstack_exporter_disabled_volume: \"{{ \u0027--disable-service.volume\u0027 if not enable_cinder | bool else \u0027\u0027 }}\""},{"line_number":326,"context_line":"prometheus_openstack_exporter_disabled_dns: \"{{ \u0027--disable-service.dns\u0027 if not enable_designate | bool else \u0027\u0027 }}\""},{"line_number":327,"context_line":"prometheus_openstack_exporter_disabled_object: \"{{ \u0027--disable-service.object-store\u0027 if (not enable_swift | bool and not enable_ceph_rgw | bool) else \u0027\u0027 }}\""},{"line_number":328,"context_line":"prometheus_openstack_exporter_disabled_lb: \"{{ \u0027--disable-service.load-balancer --disable-metric\u003dneutron-loadbalancers --disable-metric\u003dneutron-loadbalancers_not_active\u0027 if not enable_octavia | bool else \u0027\u0027 }}\""},{"line_number":329,"context_line":"prometheus_openstack_exporter_disabled_items: \"{{ [prometheus_openstack_exporter_disabled_volume, prometheus_openstack_exporter_disabled_dns, prometheus_openstack_exporter_disabled_object, prometheus_openstack_exporter_disabled_lb | trim] | join(\u0027 \u0027) | trim }}\""},{"line_number":330,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f5e970b0_c74fe860","line":327,"range":{"start_line":327,"start_character":84,"end_line":327,"end_character":143},"in_reply_to":"a1a59ad1_f3beeac2","updated":"2024-07-18 14:43:27.000000000","message":"Marksim, yes, of course. I still think it\u0027s also more readable though, what do you think?","commit_id":"4f8cd2b23c9906f2f5bc713967bbe9cb622f2ce6"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3bfaabfcd571edfee26b33e243e49d87c1bfb633","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"prometheus_openstack_exporter_disabled_volume: \"{{ \u0027--disable-service.volume\u0027 if not enable_cinder | bool else \u0027\u0027 }}\""},{"line_number":326,"context_line":"prometheus_openstack_exporter_disabled_dns: \"{{ \u0027--disable-service.dns\u0027 if not enable_designate | bool else \u0027\u0027 }}\""},{"line_number":327,"context_line":"prometheus_openstack_exporter_disabled_object: \"{{ \u0027--disable-service.object-store\u0027 if (not enable_swift | bool and not enable_ceph_rgw | bool) else \u0027\u0027 }}\""},{"line_number":328,"context_line":"prometheus_openstack_exporter_disabled_lb: \"{{ \u0027--disable-service.load-balancer --disable-metric\u003dneutron-loadbalancers --disable-metric\u003dneutron-loadbalancers_not_active\u0027 if not enable_octavia | bool else \u0027\u0027 }}\""},{"line_number":329,"context_line":"prometheus_openstack_exporter_disabled_items: \"{{ [prometheus_openstack_exporter_disabled_volume, prometheus_openstack_exporter_disabled_dns, prometheus_openstack_exporter_disabled_object, prometheus_openstack_exporter_disabled_lb | trim] | join(\u0027 \u0027) | trim }}\""},{"line_number":330,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0d4270e5_06ffd774","line":327,"range":{"start_line":327,"start_character":84,"end_line":327,"end_character":143},"in_reply_to":"f5e970b0_c74fe860","updated":"2024-07-21 07:48:56.000000000","message":"Yes readable, but my opinion was that no need in optimisations like this, only if code is not well readable so.","commit_id":"4f8cd2b23c9906f2f5bc713967bbe9cb622f2ce6"}]}