)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"7b2d2272a31f86ee35782b4efe81957746a89868","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2cda95c9_b15f2d46","updated":"2024-07-15 12:25:27.000000000","message":"I\u0027ve decided not to re-open Radek\u0027s original solution to this bug, since this solution is very different from what he started with. https://review.opendev.org/c/openstack/kolla-ansible/+/744207","commit_id":"d944d1227e1d06152a278f9f46c31536d35c5fb2"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4bb023243777159fed3eb75d0ea2efb790ffc05e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2680a76e_42185510","updated":"2024-07-15 12:29:38.000000000","message":"do you plan to address this in these files as well?\n\n```\n ~/Dokumente/osism/code/opendev/kolla-ansible  on master *6 ?2  rg -lF \u0027\"Restart {{ service_name }} container\"\u0027                                                                                                        \nansible/roles/cinder/tasks/external_ceph.yml\nansible/roles/hacluster/tasks/check-containers.yml\nansible/roles/neutron/tasks/config.yml\n```\n\nthere will be even more with slightly off naming or specific service names which this grep didn\u0027t find.","commit_id":"d944d1227e1d06152a278f9f46c31536d35c5fb2"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4ebb10d1f5479fb31d5db701f5d72e7822c5f84c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1c9a9988_636f34b4","updated":"2024-07-15 12:31:49.000000000","message":"we must also watch out if we accidentally rely on this bug for some services to restart properly.\n\nThere might be services that don\u0027t work that well if not all containers are restarted (e.g. conflicting cluster configs for different nodes)","commit_id":"d944d1227e1d06152a278f9f46c31536d35c5fb2"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"926f958adaa59337e50692fb97627c8daaec8fa5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9dec537c_61c6c8a6","in_reply_to":"1c9a9988_636f34b4","updated":"2024-07-15 13:10:59.000000000","message":"Maybe we can use `listen:` to restart multiple containers if one important container is restarted.\n\nDo you think Zuul testing will discover these problems?","commit_id":"d944d1227e1d06152a278f9f46c31536d35c5fb2"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"926f958adaa59337e50692fb97627c8daaec8fa5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b58ec4d6_7dc9ccba","in_reply_to":"2680a76e_42185510","updated":"2024-07-15 13:10:59.000000000","message":"Thank you for pointing it out. This actually needs to be address in the underlying patchset. Because there should be no `\"Restart {item.key} container\"` type notify in any of the tasks. The role service-check-containers should completely replace this. It will detect if any of the files *actually* changed and only if they did will it notify handler that would restart the container.","commit_id":"d944d1227e1d06152a278f9f46c31536d35c5fb2"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e27bc198d7efc26d978bf382f7f37e81a1bd1953","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6f4768dd_c5ef4bc4","in_reply_to":"8bcd67bb_f4c7e4bd","updated":"2024-07-31 12:31:59.000000000","message":"Done","commit_id":"d944d1227e1d06152a278f9f46c31536d35c5fb2"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"e8286cceb2dd812a9417f0df460f9c0b4e8bbeef","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f85af800_d7622d62","in_reply_to":"939f2435_7f74dbb5","updated":"2024-07-30 08:02:40.000000000","message":"Most of these, I would like to address in https://review.opendev.org/c/openstack/kolla-ansible/+/773243/10 since I think it is related to refactoring of check containers. Because the container-check should be able to replace most (if not all) of those restart notifiers.\n\nBut I\u0027ve identified a group of restart notifiers that need to be addressed in a separate patchset. And those are the restarts in service-cert-copy. Which is here https://review.opendev.org/c/openstack/kolla-ansible/+/924651/2 the datils why are in the comments on that patchset.","commit_id":"d944d1227e1d06152a278f9f46c31536d35c5fb2"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c2ea236fe5a606499dfc44328253af8d5307f80e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8bcd67bb_f4c7e4bd","in_reply_to":"9dec537c_61c6c8a6","updated":"2024-07-18 15:40:42.000000000","message":"I think for the most common clustered software this should be catched by zuul, e.g. if this somehow interferes with rabbitmq clustering. I\u0027m not so sure about the individual openstack services.","commit_id":"d944d1227e1d06152a278f9f46c31536d35c5fb2"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1d010583b0ce957176067afaba28f594baa3a1e3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"939f2435_7f74dbb5","in_reply_to":"b58ec4d6_7dc9ccba","updated":"2024-07-29 14:42:01.000000000","message":"I agree, maybe I missed it, but could you link me to the underlying patchset which you are referring to here?\n\nThanks.","commit_id":"d944d1227e1d06152a278f9f46c31536d35c5fb2"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e27bc198d7efc26d978bf382f7f37e81a1bd1953","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ccaab8de_a46b3e52","in_reply_to":"f85af800_d7622d62","updated":"2024-07-31 12:31:59.000000000","message":"Acknowledged","commit_id":"d944d1227e1d06152a278f9f46c31536d35c5fb2"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c2ea236fe5a606499dfc44328253af8d5307f80e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"884c246e_97d9a02f","updated":"2024-07-18 15:40:42.000000000","message":"a cautious +1 from me.\n\ntechnically this is a bugfix and should be backported but I think it really could mess up stuff, as it\u0027s a rather central part of our code. Maybe someone can test this on some stable branch (test) deployment first?\n\nAt least I personally don\u0027t think I can judge if this is okay to backport from a risk perspective, but feel free to convince or overrule me, especially if you got more experience with this part of the code. :)","commit_id":"ebe030ee0d61ac2b13631c4065ed98c1954a8de6"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"eadd72cad541587a5062396adae98484ef9ccf73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"79157e20_0cbd95f4","updated":"2024-07-21 07:55:16.000000000","message":"agree not backport this even bugreport was created in Train/Ussuri/Victoria cycle","commit_id":"ebe030ee0d61ac2b13631c4065ed98c1954a8de6"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e27bc198d7efc26d978bf382f7f37e81a1bd1953","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5fee3ade_1ddf092c","updated":"2024-07-31 12:31:59.000000000","message":"needs some fixes for CI but overall LGTM","commit_id":"7d7a6cd91f75cc3ea3d545ce2713781e3b8cc63d"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"3786cd6d540199ea24980004a354e5642cea3f7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"760e2944_25c6daf9","updated":"2024-09-12 11:10:25.000000000","message":"CI failed due to unrelated error during build of RabbitMQ\n\nFailed to fetch https://ppa1.novemberain.com/rabbitmq/rabbitmq-server/deb/ubuntu/dists/jammy/InRelease  Connection failed [IP: 2606:4700:3035::ac43:8c3f 443]","commit_id":"fc1a7bc3efc55de6077cf165b1eba2b24db39258"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a7b4acaf0edd14c35bbf05b93cf4b34c8e2e2d2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3fc87c4c_2740cb40","updated":"2024-09-13 23:00:24.000000000","message":"I know what you think, but for example I am running kolla-ansible in docker container as my service for install for years and just patching ansible every time I am building kolla-ansible container and it working like a charm.\n\ncommit 03ad17c7129780b9e50da285e97e35e003edbf18\nAuthor: Michal Arbet \u003cmichal.arbet@ultimum.io\u003e\nDate:   Fri Oct 7 17:24:47 2022 +0200\n\n    Add ansible patch to handle notifiers correctly [ultimum]\n\n\n+@@ -653,7 +653,15 @@\n+                     result_items \u003d [task_result._result]\n+\n+                 for result_item in result_items:\n+-                    if \u0027_ansible_notify\u0027 in result_item and task_result.is_changed():\n++                    # Ultimum patch\n++                    #\n++                    # Bug https://bugs.launchpad.net/kolla-ansible/+bug/1863510\n++                    # Ansible patch https://github.com/ansible/ansible/pull/71118/files\n++                    #\n++                    # Original condition:\n++                    #\n++                    # if \u0027_ansible_notify\u0027 in result_item and task_result.is_changed():\n++                    if \u0027_ansible_notify\u0027 in result_item and result_item.get(\u0027changed\u0027, False):\n+                         # only ensure that notified handlers exist, if so save the notifications for when\n+                         # handlers are actually flushed so the last defined handlers are exexcuted,\n+                         # otherwise depending on the setting either error or warn\n\n\nI am not saying this is solution ...but why we can\u0027t provide our own image.\nMoreover, this don\u0027t reflect files changes.","commit_id":"fc1a7bc3efc55de6077cf165b1eba2b24db39258"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9a5507a3806f17b18e4f47bfc44cd261a95300be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d8a9725d_b9a256e5","updated":"2024-09-13 22:56:12.000000000","message":"This is very dangerous and can\u0027t be merged as is. I\u0027ve tested locally on keystone for example. Service check don\u0027t have every option what kolla_container has .. so the compare will be different and every service has it different. Moreover, it don\u0027t reflect just config change. Tested on keystone.","commit_id":"fc1a7bc3efc55de6077cf165b1eba2b24db39258"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1810282e30eb6bfeeb1c50b931d0b2daf004ee4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d8a3c8d7_2b2e1e57","in_reply_to":"2b4d39d9_4e9dd76c","updated":"2024-09-18 11:22:54.000000000","message":"No problem, that\u0027s what we\u0027re here for, to help each other.","commit_id":"fc1a7bc3efc55de6077cf165b1eba2b24db39258"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"9f139635756e69702a5baf630c4026def61725a8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ae998b3c_2858007e","in_reply_to":"3fc87c4c_2740cb40","updated":"2024-09-17 20:56:38.000000000","message":"So what\u0027s the path forward? This patch fixes the problem. It might not be the cleanest solution, but it works and we can integrate it into k-a. Ansible maintainers see to be resolute in their decision not to integrate the patch you sent into upstream.\n\nShould we invest effort into integrating mechanism you use into k-a (ansible service container)? Should we include patching process in quick start guide? I don\u0027t think patching ansible just to make it work for k-a is a user friendly solution. Should we leave it be?","commit_id":"fc1a7bc3efc55de6077cf165b1eba2b24db39258"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"215baa95c60251c7f95c3d5635a3cf80a1ca9077","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d459fd39_b2cc4592","in_reply_to":"ae998b3c_2858007e","updated":"2024-09-17 22:19:01.000000000","message":"No, I think you misunderstood me. I would like to see this merged. I\u0027m just saying definitely not right now. I gave an example to show that it doesn\u0027t work even now. \n\nAs example - changing the config.json command (that\u0027s completely normal... sometimes the entire config.json doesn\u0027t change, just the command changing)... \n\nThis won\u0027t trigger a restart at all - which is of course what we don\u0027t want, do we ? \n\n\nI tried this chain a bit, so I know what I am talking about and also working in parallel to get this merged :)\n\n\nFor example, I made a patch for this specific  thing mentioned above here -\u003e https://review.opendev.org/c/openstack/kolla/+/929516\n\n\nAlso this is similar issue -\u003e https://review.opendev.org/c/openstack/kolla/+/915440","commit_id":"fc1a7bc3efc55de6077cf165b1eba2b24db39258"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"d28f4ca9798ffdd7330ab40cbba4198a51f4fc37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2b4d39d9_4e9dd76c","in_reply_to":"d459fd39_b2cc4592","updated":"2024-09-18 08:10:29.000000000","message":"I see, I did misunderstood you.\n\nYes, you\u0027re right, the restarts do not work when you change the command. I\u0027ve missed that. I\u0027ve also rebased my work on top of your kolla patchset #929516\n\nThank you for the help. :)","commit_id":"fc1a7bc3efc55de6077cf165b1eba2b24db39258"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6f2302644aeb2ddf803e1b6994b33da1cce9e9f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c76c01a6_55b8d3e4","updated":"2024-10-08 09:38:24.000000000","message":"@roman.krcek@tietoevry.com I would also like to see the patch tracked at https://review.opendev.org/c/openstack/kolla/+/915440 merged before this one. Although it\u0027s not exactly the same issue, it is somewhat related. In short, if a user provides a customized policy.yaml, for example, it gets copied into the container according to config.json and replaces the policy.yaml that is \"baked\" into the image. However, if the user deletes this customized policy.yaml from /etc/kolla/config/{service}/policy.yaml and reconfigures the service, the mapping from config.json disappears, but the original \"baked\" policy.yaml does not return to its place. This means the customized one remains, and the state isn\u0027t as it should be. After this, we can proceed further.","commit_id":"ace9e5e785c8061a6ae341c5004e34e33ad1b336"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6a0c85639c0a72552842376ff1b507ed1dd52a0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"adabc2b8_9d047dc5","updated":"2024-10-31 22:30:36.000000000","message":"recheck podman timeout","commit_id":"c6c4585e6a28b2d6c533d13e6a845ee4455f39f7"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"866c772d070fb3aefe2f25279c48c962df0d4fcf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":19,"id":"6e5b6361_325ba566","updated":"2024-11-07 09:58:51.000000000","message":"not sure if we maybe should actually backport this.\nit\u0027s invasive, but it is imho a very good bugfix. :-/\nWhat do other cores think?","commit_id":"a8874a3a7640a96ad4c8dcc263fc8e28ba270096"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7ffb97c8f3e5db9588202d43319038f01f711152","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"8e018302_1ddcd07c","in_reply_to":"6e5b6361_325ba566","updated":"2025-01-29 20:49:50.000000000","message":"Acknowledged","commit_id":"a8874a3a7640a96ad4c8dcc263fc8e28ba270096"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ab242f26547d21fbbcefcc30c105ff363bf6c6ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"80b66a69_c6b8b27f","updated":"2024-11-08 15:27:16.000000000","message":"recheck temporary failure with logging at rackspace","commit_id":"5aa629bde5155ee0224cd6539d582ea7f07b5690"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ecd194686a8b826ffe3efe0b6557339722c8f662","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"f189b3e4_3b6e4a65","updated":"2024-11-25 13:16:28.000000000","message":"recheck unrelated failure during dashboard test","commit_id":"5aa629bde5155ee0224cd6539d582ea7f07b5690"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e259a0eb31ecd61f4f99e594edaed72b35c9235a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"5b8788d8_59f4452c","updated":"2024-11-25 16:26:34.000000000","message":"recheck unrelated retry_limit reached, due to error: Error mounting /var/lib/docker: mount: /var/lib/docker: can\u0027t find LABEL\u003dkolla.","commit_id":"5aa629bde5155ee0224cd6539d582ea7f07b5690"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e3c16b9dc5a1aca0de0fce9404e536b25d8e0f12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"b3615ccf_ed8b27e0","updated":"2024-11-26 11:00:00.000000000","message":"recheck kolla-ansible-debian-podman unrelated Job Timeout","commit_id":"f58bdf109dbecd412c775898eae107f0c5cc9122"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"850e33f09b394b1067ef2ab97604a36519c0b8ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"bd3a80d6_4883338e","updated":"2024-11-27 09:00:50.000000000","message":"recheck unrelated build error due to docker hub limits","commit_id":"f58bdf109dbecd412c775898eae107f0c5cc9122"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f105b1613dae962a5e5db85ffd4f2182b470113e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"db6128c9_44c77427","updated":"2024-11-27 13:50:23.000000000","message":"recheck unrelated build error due to docker hub limits","commit_id":"f58bdf109dbecd412c775898eae107f0c5cc9122"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"249b4eafc71f21bd6b0831e8d8954b630cbb122d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"7d706086_fe3bce3b","updated":"2024-11-26 14:47:01.000000000","message":"recheck unrelated failure during kolla build due to dockerhub quota limit reached https://zuul.opendev.org/t/openstack/build/fcdf17954e294c919a3a1677d1630270/log/primary/logs/build/000_FAILED_base.log","commit_id":"f58bdf109dbecd412c775898eae107f0c5cc9122"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"47861684a7c3113afbf58d85cb2a2020492da93b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"315df1b6_bd6ff520","updated":"2024-12-01 22:02:10.000000000","message":"recheck new image","commit_id":"fc0e0fb821c97aed24757424feb8cccf7befabb0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9c628d78e135b3fda061e97b6667fed4aabc9719","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"2ab6843a_7cfe83e5","updated":"2024-12-02 09:08:12.000000000","message":"recheck podman timeout","commit_id":"fc0e0fb821c97aed24757424feb8cccf7befabb0"}],"ansible/roles/service-check-containers/tasks/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"867aa08d7cdbf77587fc4984de2ceafcf4cd71be","unresolved":true,"context_lines":[{"line_number":29,"context_line":"# For details see https://github.com/ansible/ansible/issues/22579"},{"line_number":30,"context_line":"- name: \"{{ kolla_role_name | default(project_name) }} | Notify handlers to restart containers\""},{"line_number":31,"context_line":"  debug:"},{"line_number":32,"context_line":"    msg: Ansible is quirky"},{"line_number":33,"context_line":"  changed_when: container_check is changed"},{"line_number":34,"context_line":"  notify: \"{{ container_check.results | select(\u0027changed\u0027) | map(attribute\u003d\u0027item.key\u0027) | map(\u0027regex_replace\u0027, \u0027^(.*)$\u0027, \u0027Restart \\\\1 container\u0027) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4bc83d27_ee491d6c","line":32,"updated":"2024-09-11 14:07:46.000000000","message":"can we replace that debug with anything that doesn\u0027t look that weird? ;-) Can we notify from meta: or something similar?","commit_id":"9462b89b57ddac393aeaa3828828602cf105ab5a"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"24857a2b061c2f0c575d5c4bc9ce43dd61a5dc55","unresolved":true,"context_lines":[{"line_number":29,"context_line":"# For details see https://github.com/ansible/ansible/issues/22579"},{"line_number":30,"context_line":"- name: \"{{ kolla_role_name | default(project_name) }} | Notify handlers to restart containers\""},{"line_number":31,"context_line":"  debug:"},{"line_number":32,"context_line":"    msg: Ansible is quirky"},{"line_number":33,"context_line":"  changed_when: container_check is changed"},{"line_number":34,"context_line":"  notify: \"{{ container_check.results | select(\u0027changed\u0027) | map(attribute\u003d\u0027item.key\u0027) | map(\u0027regex_replace\u0027, \u0027^(.*)$\u0027, \u0027Restart \\\\1 container\u0027) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"92edc752_dcbb05d6","line":32,"in_reply_to":"4bc83d27_ee491d6c","updated":"2024-09-12 08:29:12.000000000","message":"Looks like it is not possible to use e.g. `meta: noop`, see the StackOverflow answer bellow. Although there are alternatives. Maybe I can just use a less silly message :)\n\n\nhttps://stackoverflow.com/a/62183353","commit_id":"9462b89b57ddac393aeaa3828828602cf105ab5a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ea52b0ced1cc69be185bff7de1f1a036185d0ea","unresolved":true,"context_lines":[{"line_number":29,"context_line":"# For details see https://github.com/ansible/ansible/issues/22579"},{"line_number":30,"context_line":"- name: \"{{ kolla_role_name | default(project_name) }} | Notify handlers to restart containers\""},{"line_number":31,"context_line":"  debug:"},{"line_number":32,"context_line":"    msg: Ansible is quirky"},{"line_number":33,"context_line":"  changed_when: container_check is changed"},{"line_number":34,"context_line":"  notify: \"{{ container_check.results | select(\u0027changed\u0027) | map(attribute\u003d\u0027item.key\u0027) | map(\u0027regex_replace\u0027, \u0027^(.*)$\u0027, \u0027Restart \\\\1 container\u0027) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a7ef0ba7_851923ff","line":32,"in_reply_to":"5705e1b7_0a1ed194","updated":"2024-10-08 10:14:02.000000000","message":"works for me :)","commit_id":"9462b89b57ddac393aeaa3828828602cf105ab5a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"57bfaa07028027a95dba5005421d31d47ce68b2f","unresolved":true,"context_lines":[{"line_number":29,"context_line":"# For details see https://github.com/ansible/ansible/issues/22579"},{"line_number":30,"context_line":"- name: \"{{ kolla_role_name | default(project_name) }} | Notify handlers to restart containers\""},{"line_number":31,"context_line":"  debug:"},{"line_number":32,"context_line":"    msg: Ansible is quirky"},{"line_number":33,"context_line":"  changed_when: container_check is changed"},{"line_number":34,"context_line":"  notify: \"{{ container_check.results | select(\u0027changed\u0027) | map(attribute\u003d\u0027item.key\u0027) | map(\u0027regex_replace\u0027, \u0027^(.*)$\u0027, \u0027Restart \\\\1 container\u0027) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a00df837_456cfdd2","line":32,"in_reply_to":"92edc752_dcbb05d6","updated":"2024-09-12 10:54:06.000000000","message":"well, msg: \"Notifying specific handlers\" or something would be better, if we need to do anything like that.\nWe could also just write a noop module that does this so we don\u0027t have a quirky debug msg, but I\u0027m not sure it solves anything ;-)","commit_id":"9462b89b57ddac393aeaa3828828602cf105ab5a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bc8117f2f5b3dccd808284ae5d56bac71f288881","unresolved":true,"context_lines":[{"line_number":29,"context_line":"# For details see https://github.com/ansible/ansible/issues/22579"},{"line_number":30,"context_line":"- name: \"{{ kolla_role_name | default(project_name) }} | Notify handlers to restart containers\""},{"line_number":31,"context_line":"  debug:"},{"line_number":32,"context_line":"    msg: Ansible is quirky"},{"line_number":33,"context_line":"  changed_when: container_check is changed"},{"line_number":34,"context_line":"  notify: \"{{ container_check.results | select(\u0027changed\u0027) | map(attribute\u003d\u0027item.key\u0027) | map(\u0027regex_replace\u0027, \u0027^(.*)$\u0027, \u0027Restart \\\\1 container\u0027) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff8be30f_b4d9b6f9","line":32,"in_reply_to":"a00df837_456cfdd2","updated":"2024-09-13 12:36:46.000000000","message":"what is wrong with using an `assert:` instead of debug here, like suggested in https://stackoverflow.com/a/66708947 ? feels relatively clean to me, at least from the output point of view.","commit_id":"9462b89b57ddac393aeaa3828828602cf105ab5a"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2d23b082582b7b4117638ac8b5857b0c24268bbf","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# For details see https://github.com/ansible/ansible/issues/22579"},{"line_number":30,"context_line":"- name: \"{{ kolla_role_name | default(project_name) }} | Notify handlers to restart containers\""},{"line_number":31,"context_line":"  debug:"},{"line_number":32,"context_line":"    msg: Ansible is quirky"},{"line_number":33,"context_line":"  changed_when: container_check is changed"},{"line_number":34,"context_line":"  notify: \"{{ container_check.results | select(\u0027changed\u0027) | map(attribute\u003d\u0027item.key\u0027) | map(\u0027regex_replace\u0027, \u0027^(.*)$\u0027, \u0027Restart \\\\1 container\u0027) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"47be58d5_1fcc7f18","line":32,"in_reply_to":"a7ef0ba7_851923ff","updated":"2024-10-09 12:56:21.000000000","message":"Done","commit_id":"9462b89b57ddac393aeaa3828828602cf105ab5a"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"9f139635756e69702a5baf630c4026def61725a8","unresolved":true,"context_lines":[{"line_number":29,"context_line":"# For details see https://github.com/ansible/ansible/issues/22579"},{"line_number":30,"context_line":"- name: \"{{ kolla_role_name | default(project_name) }} | Notify handlers to restart containers\""},{"line_number":31,"context_line":"  debug:"},{"line_number":32,"context_line":"    msg: Ansible is quirky"},{"line_number":33,"context_line":"  changed_when: container_check is changed"},{"line_number":34,"context_line":"  notify: \"{{ container_check.results | select(\u0027changed\u0027) | map(attribute\u003d\u0027item.key\u0027) | map(\u0027regex_replace\u0027, \u0027^(.*)$\u0027, \u0027Restart \\\\1 container\u0027) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5705e1b7_0a1ed194","line":32,"in_reply_to":"ff8be30f_b4d9b6f9","updated":"2024-09-17 20:56:38.000000000","message":"Output-wise it looks like this with option compare assertions and debug `-vv`\n\nIMO the debug option is more clear for the user, but the final decision is up to you. :)\n\n```\nTASK [service-check-containers : loadbalancer | Notify handlers to restart containers] ****************************************\ntask path: /home/ubuntu/openstack/.venv/share/kolla-ansible/ansible/roles/service-check-containers/tasks/main.yml:30\nFriday 13 September 2024  15:42:35 +0200 (0:00:02.607)       0:01:22.243 ****** \nFriday 13 September 2024  15:42:35 +0200 (0:00:02.607)       0:01:22.242 ****** \nNotification for handler Restart haproxy container has been saved.\nNotification for handler Restart keepalived container has been saved.\nchanged: [control-a-01] \u003d\u003e changed\u003dtrue \n  msg: All assertions passed\nNotification for handler Restart haproxy container has been saved.\nNotification for handler Restart keepalived container has been saved.\nchanged: [compute-a-01] \u003d\u003e changed\u003dtrue \n  msg: All assertions passed\n```\n\n```\nTASK [service-check-containers : keystone | Notify handlers to restart containers] ******************************************************\ntask path: /home/ubuntu/openstack/kolla-ansible/ansible/roles/service-check-containers/tasks/main.yml:30\nThursday 12 September 2024  10:24:15 +0200 (0:00:03.549)       0:03:49.938 **** \nThursday 12 September 2024  10:24:15 +0200 (0:00:03.549)       0:03:49.937 **** \nNotification for handler Restart keystone container has been saved.\nNotification for handler Restart keystone-ssh container has been saved.\nNotification for handler Restart keystone-fernet container has been saved.\nchanged: [control-a-01] \u003d\u003e \n  msg: Notifying handlers\nNotification for handler Restart keystone container has been saved.\nNotification for handler Restart keystone-ssh container has been saved.\nNotification for handler Restart keystone-fernet container has been saved.\nchanged: [compute-a-01] \u003d\u003e \n  msg: Notifying handlers\n```","commit_id":"9462b89b57ddac393aeaa3828828602cf105ab5a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"df6fe487dd6b0abdd86eedc02d4ea48d41407059","unresolved":true,"context_lines":[{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    service: \"{{ item.value }}\""},{"line_number":6,"context_line":"  kolla_container:"},{"line_number":7,"context_line":"    action: \"compare_container\""},{"line_number":8,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":9,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":10,"context_line":"    image: \"{{ service.image | default(omit) }}\""},{"line_number":11,"context_line":"    volumes: \"{{ service.volumes | default(omit) }}\""},{"line_number":12,"context_line":"    dimensions: \"{{ service.dimensions | default(omit) }}\""},{"line_number":13,"context_line":"    tmpfs: \"{{ service.tmpfs | default(omit) }}\""},{"line_number":14,"context_line":"    volumes_from: \"{{ service.volumes_from | default(omit) }}\""},{"line_number":15,"context_line":"    privileged: \"{{ service.privileged | default(omit) }}\""},{"line_number":16,"context_line":"    cap_add: \"{{ service.cap_add | default(omit) }}\""},{"line_number":17,"context_line":"    environment: \"{{ service.environment | default(omit) }}\""},{"line_number":18,"context_line":"    healthcheck: \"{{ service.healthcheck | default(omit) }}\""},{"line_number":19,"context_line":"    ipc_mode: \"{{ service.ipc_mode | default(omit) }}\""},{"line_number":20,"context_line":"    pid_mode: \"{{ service.pid_mode | default(omit) }}\""},{"line_number":21,"context_line":"    security_opt: \"{{ service.security_opt | default(omit) }}\""},{"line_number":22,"context_line":"    labels: \"{{ service.labels | default(omit) }}\""},{"line_number":23,"context_line":"    command: \"{{ service.command | default(omit) }}\""},{"line_number":24,"context_line":"  with_dict: \"{{ lookup(\u0027vars\u0027, (kolla_role_name | default(project_name)) + \u0027_services\u0027) | select_services_enabled_and_mapped_to_host }}\""},{"line_number":25,"context_line":"  register: container_check"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"d6b4c519_d44cb5a8","line":23,"range":{"start_line":7,"start_character":0,"end_line":23,"end_character":52},"updated":"2024-10-08 10:54:38.000000000","message":"cgroupns_mode option missing","commit_id":"ace9e5e785c8061a6ae341c5004e34e33ad1b336"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2d23b082582b7b4117638ac8b5857b0c24268bbf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    service: \"{{ item.value }}\""},{"line_number":6,"context_line":"  kolla_container:"},{"line_number":7,"context_line":"    action: \"compare_container\""},{"line_number":8,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":9,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":10,"context_line":"    image: \"{{ service.image | default(omit) }}\""},{"line_number":11,"context_line":"    volumes: \"{{ service.volumes | default(omit) }}\""},{"line_number":12,"context_line":"    dimensions: \"{{ service.dimensions | default(omit) }}\""},{"line_number":13,"context_line":"    tmpfs: \"{{ service.tmpfs | default(omit) }}\""},{"line_number":14,"context_line":"    volumes_from: \"{{ service.volumes_from | default(omit) }}\""},{"line_number":15,"context_line":"    privileged: \"{{ service.privileged | default(omit) }}\""},{"line_number":16,"context_line":"    cap_add: \"{{ service.cap_add | default(omit) }}\""},{"line_number":17,"context_line":"    environment: \"{{ service.environment | default(omit) }}\""},{"line_number":18,"context_line":"    healthcheck: \"{{ service.healthcheck | default(omit) }}\""},{"line_number":19,"context_line":"    ipc_mode: \"{{ service.ipc_mode | default(omit) }}\""},{"line_number":20,"context_line":"    pid_mode: \"{{ service.pid_mode | default(omit) }}\""},{"line_number":21,"context_line":"    security_opt: \"{{ service.security_opt | default(omit) }}\""},{"line_number":22,"context_line":"    labels: \"{{ service.labels | default(omit) }}\""},{"line_number":23,"context_line":"    command: \"{{ service.command | default(omit) }}\""},{"line_number":24,"context_line":"  with_dict: \"{{ lookup(\u0027vars\u0027, (kolla_role_name | default(project_name)) + \u0027_services\u0027) | select_services_enabled_and_mapped_to_host }}\""},{"line_number":25,"context_line":"  register: container_check"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"d2d1f42e_76b13e9b","line":23,"range":{"start_line":7,"start_character":0,"end_line":23,"end_character":52},"in_reply_to":"d6b4c519_d44cb5a8","updated":"2024-10-09 12:56:21.000000000","message":"Done","commit_id":"ace9e5e785c8061a6ae341c5004e34e33ad1b336"}]}