)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c8467e5725b6755cace902c71cc10b1cb1774385","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f1856e8c_8cdc2ae8","updated":"2024-07-18 10:09:55.000000000","message":"Thanks Dawud - this fixes a widespread issue. I have some minor comments.","commit_id":"65fe8e374d07eabae89b6f2141897df7fcd6f046"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5f9aa277c3519c22553fa8fba2e8bedd72cee014","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0a3db146_46d978cc","updated":"2024-08-22 20:15:34.000000000","message":"can you link to a bug in launchpad?","commit_id":"8965b3ee5276144a02ae3764add60b3ce4032640"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"c7a173800c2131d592fcdc22266e82bce93dea35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5a995ece_0cb624a0","in_reply_to":"0a3db146_46d978cc","updated":"2024-09-09 13:11:52.000000000","message":"Done","commit_id":"8965b3ee5276144a02ae3764add60b3ce4032640"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"c7a173800c2131d592fcdc22266e82bce93dea35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e6d54c9d_fb1ec0b3","updated":"2024-09-09 13:11:52.000000000","message":"https://bugs.launchpad.net/kolla-ansible/+bug/2079988 Bug added","commit_id":"9b3b56b62d3d41f897b29c0215db6adee480450c"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"fa1c86026eabfa8cac430985bec28d41446a539d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0edb5aed_618f22bd","updated":"2024-11-20 13:59:14.000000000","message":"recheck","commit_id":"91ddef7a37f3d52d2f0e3c8f4d48a0ef4d3057a1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9a8113b9e974e880fd8bd2320e9bbf5be660ce5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"283b978a_390f7a87","updated":"2024-11-20 14:18:50.000000000","message":"What about ansible/roles/common/templates/conf/output/01-es.conf.j2 ?","commit_id":"76d3e08f44b1b2b74f00392badc72b4e0bcc1d31"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"531e9f093fbfee417ce826423a89e44d9aa38488","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c557768f_5ebc7aa4","in_reply_to":"283b978a_390f7a87","updated":"2024-11-22 10:23:34.000000000","message":"We may as well expand the bug to cover external Elasticsearch given it\u0027s the same fix.\n\nWe also need to update 00-local.conf.j2 in this case","commit_id":"76d3e08f44b1b2b74f00392badc72b4e0bcc1d31"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"531e9f093fbfee417ce826423a89e44d9aa38488","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5f833eb6_3694d910","updated":"2024-11-22 10:23:34.000000000","message":"Please update to cover the expanded bug report.","commit_id":"e55d31a6f0d7ca47dc71b158ecb16650fafac642"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"2650d97a9666060102e04afeb8a61c58102b7377","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"76debade_ca9816ae","updated":"2024-11-22 16:52:50.000000000","message":"Thanks Dawud - just one other place I think","commit_id":"b15eb6e978d149cd530979117cb05a9908c5b4dc"}],"ansible/roles/common/defaults/main.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"87475f6d8581614cbe64aeb1b94510431074ec0b","unresolved":true,"context_lines":[{"line_number":139,"context_line":"fluentd_enable_watch_timer: \"false\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"# Set limits for queue size and chunk size"},{"line_number":142,"context_line":"fluentd_bulk_message_request_threshold: \"20M\""},{"line_number":143,"context_line":"fluentd_buffer_chunk_limit_size: \"8M\""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"fluentd_input_openstack_services:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fc555a28_a623b777","line":142,"updated":"2024-09-09 13:16:58.000000000","message":"Please justify these specific numbers with a comment here (please see previous request)","commit_id":"9b3b56b62d3d41f897b29c0215db6adee480450c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"48d17cafae098d606bb68d1082a21e56a197a0c7","unresolved":false,"context_lines":[{"line_number":139,"context_line":"fluentd_enable_watch_timer: \"false\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"# Set limits for queue size and chunk size"},{"line_number":142,"context_line":"fluentd_bulk_message_request_threshold: \"20M\""},{"line_number":143,"context_line":"fluentd_buffer_chunk_limit_size: \"8M\""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"fluentd_input_openstack_services:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7af598be_f983e244","line":142,"in_reply_to":"fc555a28_a623b777","updated":"2024-09-13 16:04:39.000000000","message":"Done","commit_id":"9b3b56b62d3d41f897b29c0215db6adee480450c"}],"ansible/roles/common/templates/conf/output/00-local.conf.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c8467e5725b6755cace902c71cc10b1cb1774385","unresolved":true,"context_lines":[{"line_number":70,"context_line":"       reconnect_on_error true"},{"line_number":71,"context_line":"       request_timeout {{ fluentd_opensearch_request_timeout }}"},{"line_number":72,"context_line":"       suppress_type_name true"},{"line_number":73,"context_line":"       bulk_message_request_threshold 20M"},{"line_number":74,"context_line":"       \u003cbuffer\u003e"},{"line_number":75,"context_line":"         @type file"},{"line_number":76,"context_line":"         path /var/lib/fluentd/data/opensearch.buffer/{{ item.facility }}.*"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"17fb04d1_b1237274","line":73,"updated":"2024-07-18 10:09:55.000000000","message":"It would be helpful to extract this as a variable, and put a comment next to it, explaining why it is set to 20MB. Otherwise, it requires some effort to figure out why 20MB is a valid setting.\n\nSomething like:\n\nWe need to ensure that the bulk_message_request_threshold is set below the default maximum content length for the OpenSearch bulk API (100MB). By default the bulk_message_request_threshold is unlimited [1], which can lead to large payloads being sent and subsequently rejected by the OpenSearch API.\n\n[1] https://github.com/fluent/fluent-plugin-opensearch?tab\u003dreadme-ov-file#bulk_message_request_threshold","commit_id":"65fe8e374d07eabae89b6f2141897df7fcd6f046"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"352c442c6e9a3b20dbb50b4a749851e18833cf0a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"       reconnect_on_error true"},{"line_number":71,"context_line":"       request_timeout {{ fluentd_opensearch_request_timeout }}"},{"line_number":72,"context_line":"       suppress_type_name true"},{"line_number":73,"context_line":"       bulk_message_request_threshold 20M"},{"line_number":74,"context_line":"       \u003cbuffer\u003e"},{"line_number":75,"context_line":"         @type file"},{"line_number":76,"context_line":"         path /var/lib/fluentd/data/opensearch.buffer/{{ item.facility }}.*"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"f054a415_61d813de","line":73,"in_reply_to":"17fb04d1_b1237274","updated":"2024-09-26 15:16:07.000000000","message":"Done","commit_id":"65fe8e374d07eabae89b6f2141897df7fcd6f046"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c8467e5725b6755cace902c71cc10b1cb1774385","unresolved":true,"context_lines":[{"line_number":75,"context_line":"         @type file"},{"line_number":76,"context_line":"         path /var/lib/fluentd/data/opensearch.buffer/{{ item.facility }}.*"},{"line_number":77,"context_line":"         flush_interval 15s"},{"line_number":78,"context_line":"         chunk_limit_size 8M"},{"line_number":79,"context_line":"       \u003c/buffer\u003e"},{"line_number":80,"context_line":"    \u003c/store\u003e"},{"line_number":81,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"dbabb10d_42fa200e","line":78,"updated":"2024-07-18 10:09:55.000000000","message":"I\u0027m curious if this is required - as I understand it relates to the size of the file buffer chunks as written to disk. Does it need to be below the bulk_message_request_threshold? What was the reason to change it from the default of 256MB?","commit_id":"65fe8e374d07eabae89b6f2141897df7fcd6f046"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"48d17cafae098d606bb68d1082a21e56a197a0c7","unresolved":false,"context_lines":[{"line_number":75,"context_line":"         @type file"},{"line_number":76,"context_line":"         path /var/lib/fluentd/data/opensearch.buffer/{{ item.facility }}.*"},{"line_number":77,"context_line":"         flush_interval 15s"},{"line_number":78,"context_line":"         chunk_limit_size 8M"},{"line_number":79,"context_line":"       \u003c/buffer\u003e"},{"line_number":80,"context_line":"    \u003c/store\u003e"},{"line_number":81,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"effa50c5_04bdfd87","line":78,"in_reply_to":"086cf111_4eeae790","updated":"2024-09-13 16:04:39.000000000","message":"Done","commit_id":"65fe8e374d07eabae89b6f2141897df7fcd6f046"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"87475f6d8581614cbe64aeb1b94510431074ec0b","unresolved":true,"context_lines":[{"line_number":75,"context_line":"         @type file"},{"line_number":76,"context_line":"         path /var/lib/fluentd/data/opensearch.buffer/{{ item.facility }}.*"},{"line_number":77,"context_line":"         flush_interval 15s"},{"line_number":78,"context_line":"         chunk_limit_size 8M"},{"line_number":79,"context_line":"       \u003c/buffer\u003e"},{"line_number":80,"context_line":"    \u003c/store\u003e"},{"line_number":81,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"086cf111_4eeae790","line":78,"in_reply_to":"697d550f_f67de46e","updated":"2024-09-09 13:16:58.000000000","message":"Still needs resolving","commit_id":"65fe8e374d07eabae89b6f2141897df7fcd6f046"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c01f1fe33ed841c91bd13b0067ebe60f615c9c0a","unresolved":true,"context_lines":[{"line_number":75,"context_line":"         @type file"},{"line_number":76,"context_line":"         path /var/lib/fluentd/data/opensearch.buffer/{{ item.facility }}.*"},{"line_number":77,"context_line":"         flush_interval 15s"},{"line_number":78,"context_line":"         chunk_limit_size 8M"},{"line_number":79,"context_line":"       \u003c/buffer\u003e"},{"line_number":80,"context_line":"    \u003c/store\u003e"},{"line_number":81,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"697d550f_f67de46e","line":78,"in_reply_to":"dbabb10d_42fa200e","updated":"2024-07-18 10:24:06.000000000","message":"I agree it makes sense to decrease from the default. I see it flushes at 95% of this value, so it could be set equal to the bulk message threshold at most, but 8MB is fine.\n\nPlease include a comment explaining the reasoning similar to above.","commit_id":"65fe8e374d07eabae89b6f2141897df7fcd6f046"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"2650d97a9666060102e04afeb8a61c58102b7377","unresolved":true,"context_lines":[{"line_number":38,"context_line":"       logstash_prefix {{ opensearch_log_index_prefix }}"},{"line_number":39,"context_line":"       reconnect_on_error true"},{"line_number":40,"context_line":"       request_timeout {{ fluentd_elasticsearch_request_timeout }}"},{"line_number":41,"context_line":"       suppress_type_name true"},{"line_number":42,"context_line":"       \u003cbuffer\u003e"},{"line_number":43,"context_line":"         @type file"},{"line_number":44,"context_line":"         path /var/lib/fluentd/data/elasticsearch.buffer/{{ item.facility }}.*"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"8ba46c20_fe538791","line":41,"updated":"2024-11-22 16:52:50.000000000","message":"Need to add the fix here too","commit_id":"b15eb6e978d149cd530979117cb05a9908c5b4dc"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"070711d6aae5f426e376fed0c41dfb87d2fa715b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"       logstash_prefix {{ opensearch_log_index_prefix }}"},{"line_number":39,"context_line":"       reconnect_on_error true"},{"line_number":40,"context_line":"       request_timeout {{ fluentd_elasticsearch_request_timeout }}"},{"line_number":41,"context_line":"       suppress_type_name true"},{"line_number":42,"context_line":"       \u003cbuffer\u003e"},{"line_number":43,"context_line":"         @type file"},{"line_number":44,"context_line":"         path /var/lib/fluentd/data/elasticsearch.buffer/{{ item.facility }}.*"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ebd3954a_03500f8f","line":41,"in_reply_to":"8ba46c20_fe538791","updated":"2024-11-22 17:28:23.000000000","message":"Done","commit_id":"b15eb6e978d149cd530979117cb05a9908c5b4dc"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"73b382e993f5dee3f6bd1f357b63e26a2f650bcb","unresolved":true,"context_lines":[{"line_number":72,"context_line":"       reconnect_on_error true"},{"line_number":73,"context_line":"       request_timeout {{ fluentd_opensearch_request_timeout }}"},{"line_number":74,"context_line":"       suppress_type_name true"},{"line_number":75,"context_line":"       bulk_message_request_threshold {{ fluentd_bulk_message_request_threshold}}"},{"line_number":76,"context_line":"       \u003cbuffer\u003e"},{"line_number":77,"context_line":"         @type file"},{"line_number":78,"context_line":"         path /var/lib/fluentd/data/opensearch.buffer/{{ item.facility }}.*"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"46180ba5_a883a725","line":75,"updated":"2024-11-27 13:05:39.000000000","message":"nit: missing space","commit_id":"e56ed653f91d35f9dd36990abc362a9ece232f27"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"75eabbb832f9eb13e1613e639dbd26291908f460","unresolved":false,"context_lines":[{"line_number":72,"context_line":"       reconnect_on_error true"},{"line_number":73,"context_line":"       request_timeout {{ fluentd_opensearch_request_timeout }}"},{"line_number":74,"context_line":"       suppress_type_name true"},{"line_number":75,"context_line":"       bulk_message_request_threshold {{ fluentd_bulk_message_request_threshold}}"},{"line_number":76,"context_line":"       \u003cbuffer\u003e"},{"line_number":77,"context_line":"         @type file"},{"line_number":78,"context_line":"         path /var/lib/fluentd/data/opensearch.buffer/{{ item.facility }}.*"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"24a02760_0ddc5f40","line":75,"in_reply_to":"46180ba5_a883a725","updated":"2024-11-27 14:13:52.000000000","message":"Done","commit_id":"e56ed653f91d35f9dd36990abc362a9ece232f27"}],"ansible/roles/common/templates/conf/output/01-es.conf.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"73b382e993f5dee3f6bd1f357b63e26a2f650bcb","unresolved":true,"context_lines":[{"line_number":29,"context_line":"         @type file"},{"line_number":30,"context_line":"         path /var/lib/fluentd/data/elasticsearch.buffer/openstack.*"},{"line_number":31,"context_line":"         flush_interval 15s"},{"line_number":32,"context_line":"         chunk_limit_size {{ fluentd_buffer_chunk_limit_size }}q"},{"line_number":33,"context_line":"       \u003c/buffer\u003e"},{"line_number":34,"context_line":"    \u003c/store\u003e"},{"line_number":35,"context_line":"\u003c/match\u003e"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"b4386efb_6401cc2c","line":32,"updated":"2024-11-27 13:05:39.000000000","message":"please fix typo at end of line","commit_id":"e56ed653f91d35f9dd36990abc362a9ece232f27"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"75eabbb832f9eb13e1613e639dbd26291908f460","unresolved":false,"context_lines":[{"line_number":29,"context_line":"         @type file"},{"line_number":30,"context_line":"         path /var/lib/fluentd/data/elasticsearch.buffer/openstack.*"},{"line_number":31,"context_line":"         flush_interval 15s"},{"line_number":32,"context_line":"         chunk_limit_size {{ fluentd_buffer_chunk_limit_size }}q"},{"line_number":33,"context_line":"       \u003c/buffer\u003e"},{"line_number":34,"context_line":"    \u003c/store\u003e"},{"line_number":35,"context_line":"\u003c/match\u003e"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5958aaf6_619bfb4e","line":32,"in_reply_to":"b4386efb_6401cc2c","updated":"2024-11-27 14:13:52.000000000","message":"Done","commit_id":"e56ed653f91d35f9dd36990abc362a9ece232f27"}]}