)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13114,"name":"Hoai-Thu Vuong","email":"thuvh87@gmail.com","username":"thuvh"},"change_message_id":"816b90ad28355818ebb8465f4db2ef1b3d71de1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d9c20978_e23d7f9d","updated":"2024-07-19 04:26:33.000000000","message":"@kiennt2609@gmail.com: should we use merge_config [1]\n\n\n[1]: https://github.com/openstack/kolla-ansible/blob/master/ansible/action_plugins/merge_configs.py)","commit_id":"140710290ffd7729927af72dff20676297b758ed"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c1ca3c9cd30f136205c5d63f8ad34f5d9bd50567","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c9a478ec_b82c382b","updated":"2024-07-19 06:29:26.000000000","message":"Please also update docs doc/source/reference/logging-and-monitoring/central-logging-guide.rst","commit_id":"140710290ffd7729927af72dff20676297b758ed"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"d1a82d6f34675852b86721862871755cb751c1e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7b072a7e_97f98f9c","in_reply_to":"2ec89c68_0a8e98db","updated":"2024-12-16 07:05:34.000000000","message":"Oh, missed it. I\u0027ve updated in the new patch.","commit_id":"140710290ffd7729927af72dff20676297b758ed"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d48d132571341513e2461463737b52d6ab5b0881","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2ec89c68_0a8e98db","in_reply_to":"c9a478ec_b82c382b","updated":"2024-12-13 10:05:25.000000000","message":"Not done","commit_id":"140710290ffd7729927af72dff20676297b758ed"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"533c047ec64edb01b89fb9e94d1e99906d0fa4e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7356dc1a_b421e602","updated":"2024-12-17 02:21:31.000000000","message":"recheck","commit_id":"b25dff072d9bf170ebf9dc9988e11775e74e28b6"}],"ansible/roles/common/tasks/config.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5ae1fbed0b6de931065701a3912eaf6b4392777b","unresolved":true,"context_lines":[{"line_number":105,"context_line":"  find:"},{"line_number":106,"context_line":"    paths:"},{"line_number":107,"context_line":"      - \"{{ node_custom_config }}/fluentd/input\""},{"line_number":108,"context_line":"      - \"{{ node_custom_config }}/fluentd/{{ inventory_hostname }}/input\""},{"line_number":109,"context_line":"    patterns: \"*.conf\""},{"line_number":110,"context_line":"  run_once: True"},{"line_number":111,"context_line":"  register: find_custom_fluentd_inputs"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"aec7875d_b592c943","line":108,"range":{"start_line":108,"start_character":45,"end_line":108,"end_character":63},"updated":"2024-07-18 08:01:25.000000000","message":"I _think_ this works, but it\u0027s a little brittle, because we `delegate_to: localhost` all variables are also consumed from the delegated host, except `inventory_hostname`.\n\nSee upstreams documentation about this:\n\nhttps://docs.ansible.com/ansible/latest/playbook_guide/playbooks_delegation.html#templating-in-delegation-context\n\n\u003e Be advised that under delegation, the execution interpreter (normally Python), connection, become, and shell plugin options will now be templated using values from the delegated to host. All variables except inventory_hostname will now be consumed from this host and not the original task host. If you need variables from the original task host for those options, you must use hostvars[inventory_hostname][\u0027varname\u0027], even inventory_hostname_short refers to the delegated host.\n\n\nI wonder if we should add a comment regarding this, because it\u0027s easy to introduce bugs here in the future.","commit_id":"d18213d0b5f761d3763c3cc73b0f038d2d4ae443"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"048734dcfeff6fa6132e5e21ab35e2043d330625","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  find:"},{"line_number":106,"context_line":"    paths:"},{"line_number":107,"context_line":"      - \"{{ node_custom_config }}/fluentd/input\""},{"line_number":108,"context_line":"      - \"{{ node_custom_config }}/fluentd/{{ inventory_hostname }}/input\""},{"line_number":109,"context_line":"    patterns: \"*.conf\""},{"line_number":110,"context_line":"  run_once: True"},{"line_number":111,"context_line":"  register: find_custom_fluentd_inputs"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ea72b639_d42805ca","line":108,"range":{"start_line":108,"start_character":45,"end_line":108,"end_character":63},"in_reply_to":"571dfd9f_05d0099d","updated":"2024-07-18 12:14:48.000000000","message":"Acknowledged","commit_id":"d18213d0b5f761d3763c3cc73b0f038d2d4ae443"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ba826c9d093d72044a8d354e3d9e006d71248c4c","unresolved":true,"context_lines":[{"line_number":105,"context_line":"  find:"},{"line_number":106,"context_line":"    paths:"},{"line_number":107,"context_line":"      - \"{{ node_custom_config }}/fluentd/input\""},{"line_number":108,"context_line":"      - \"{{ node_custom_config }}/fluentd/{{ inventory_hostname }}/input\""},{"line_number":109,"context_line":"    patterns: \"*.conf\""},{"line_number":110,"context_line":"  run_once: True"},{"line_number":111,"context_line":"  register: find_custom_fluentd_inputs"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"571dfd9f_05d0099d","line":108,"range":{"start_line":108,"start_character":45,"end_line":108,"end_character":63},"in_reply_to":"aec7875d_b592c943","updated":"2024-07-18 11:54:36.000000000","message":"I think this should be fine, since the expansion of the found files as includes for the template below will also happen on localhost, won\u0027t it?","commit_id":"d18213d0b5f761d3763c3cc73b0f038d2d4ae443"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ba826c9d093d72044a8d354e3d9e006d71248c4c","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    paths:"},{"line_number":107,"context_line":"      - \"{{ node_custom_config }}/fluentd/input\""},{"line_number":108,"context_line":"      - \"{{ node_custom_config }}/fluentd/{{ inventory_hostname }}/input\""},{"line_number":109,"context_line":"    patterns: \"*.conf\""},{"line_number":110,"context_line":"  run_once: True"},{"line_number":111,"context_line":"  register: find_custom_fluentd_inputs"},{"line_number":112,"context_line":"  delegate_to: localhost"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cc4a68e7_996dc943","line":109,"updated":"2024-07-18 11:54:36.000000000","message":"These changes are unrelated, while `patterns:` seems to be the more canonical key, both are equivalent. I\u0027m not sure doing the change combined with some real change is a good idea, if you really want to do this, make a dedicated match and make sure to amend all locations in the code that this affects.","commit_id":"d18213d0b5f761d3763c3cc73b0f038d2d4ae443"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"fff55426d95ab7dfb1121b6016be1af934f30471","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    paths:"},{"line_number":107,"context_line":"      - \"{{ node_custom_config }}/fluentd/input\""},{"line_number":108,"context_line":"      - \"{{ node_custom_config }}/fluentd/{{ inventory_hostname }}/input\""},{"line_number":109,"context_line":"    patterns: \"*.conf\""},{"line_number":110,"context_line":"  run_once: True"},{"line_number":111,"context_line":"  register: find_custom_fluentd_inputs"},{"line_number":112,"context_line":"  delegate_to: localhost"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"09ee0153_383cc398","line":109,"in_reply_to":"7f5458d4_35447ab5","updated":"2024-11-01 08:58:57.000000000","message":"Done","commit_id":"d18213d0b5f761d3763c3cc73b0f038d2d4ae443"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"becd4f655e3403ab767a3964bc93e4787e2594c6","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    paths:"},{"line_number":107,"context_line":"      - \"{{ node_custom_config }}/fluentd/input\""},{"line_number":108,"context_line":"      - \"{{ node_custom_config }}/fluentd/{{ inventory_hostname }}/input\""},{"line_number":109,"context_line":"    patterns: \"*.conf\""},{"line_number":110,"context_line":"  run_once: True"},{"line_number":111,"context_line":"  register: find_custom_fluentd_inputs"},{"line_number":112,"context_line":"  delegate_to: localhost"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f5458d4_35447ab5","line":109,"in_reply_to":"cc4a68e7_996dc943","updated":"2024-07-19 04:07:16.000000000","message":"`pattern` is the alias of `patterns`. I think there should be another patch to change this later.\n\nhttps://docs.ansible.com/ansible/latest/collections/ansible/builtin/find_module.html#parameter-patterns","commit_id":"d18213d0b5f761d3763c3cc73b0f038d2d4ae443"}],"releasenotes/notes/fluentd-custom-config-per-host-662085101e5b82b1.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ba826c9d093d72044a8d354e3d9e006d71248c4c","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds ability to configure Fluentd per-host custom config."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    It some scenarios it may be useful to apply custom config per host."},{"line_number":7,"context_line":"    Configuration of custom fluentd config is possible by placing"},{"line_number":8,"context_line":"    configuration files in"},{"line_number":9,"context_line":"    ``/etc/kolla/config/fluentd/\u003chost\u003e/\u003cinput/filter/format/output\u003e/*.conf``"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1667de64_466cffdd","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":6},"updated":"2024-07-18 11:54:36.000000000","message":"I don\u0027t think the motivation for this change needs to appear in the releasenote, just drop this line and the empty line in front for easier reading.","commit_id":"d18213d0b5f761d3763c3cc73b0f038d2d4ae443"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"becd4f655e3403ab767a3964bc93e4787e2594c6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds ability to configure Fluentd per-host custom config."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    It some scenarios it may be useful to apply custom config per host."},{"line_number":7,"context_line":"    Configuration of custom fluentd config is possible by placing"},{"line_number":8,"context_line":"    configuration files in"},{"line_number":9,"context_line":"    ``/etc/kolla/config/fluentd/\u003chost\u003e/\u003cinput/filter/format/output\u003e/*.conf``"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9c2aa203_25217ae3","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":6},"in_reply_to":"1667de64_466cffdd","updated":"2024-07-19 04:07:16.000000000","message":"Done","commit_id":"d18213d0b5f761d3763c3cc73b0f038d2d4ae443"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ba826c9d093d72044a8d354e3d9e006d71248c4c","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    It some scenarios it may be useful to apply custom config per host."},{"line_number":7,"context_line":"    Configuration of custom fluentd config is possible by placing"},{"line_number":8,"context_line":"    configuration files in"},{"line_number":9,"context_line":"    ``/etc/kolla/config/fluentd/\u003chost\u003e/\u003cinput/filter/format/output\u003e/*.conf``"},{"line_number":10,"context_line":"    on the control host."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6d4980cc_56d26b15","line":9,"range":{"start_line":9,"start_character":39,"end_line":9,"end_character":67},"updated":"2024-07-18 11:54:36.000000000","message":"This seems confusing to me, maybe use bash syntax instead?\n\n`{input,filter,format,output}`","commit_id":"d18213d0b5f761d3763c3cc73b0f038d2d4ae443"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"becd4f655e3403ab767a3964bc93e4787e2594c6","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    It some scenarios it may be useful to apply custom config per host."},{"line_number":7,"context_line":"    Configuration of custom fluentd config is possible by placing"},{"line_number":8,"context_line":"    configuration files in"},{"line_number":9,"context_line":"    ``/etc/kolla/config/fluentd/\u003chost\u003e/\u003cinput/filter/format/output\u003e/*.conf``"},{"line_number":10,"context_line":"    on the control host."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"54ff0a40_389dc5f7","line":9,"range":{"start_line":9,"start_character":39,"end_line":9,"end_character":67},"in_reply_to":"6d4980cc_56d26b15","updated":"2024-07-19 04:07:16.000000000","message":"Done","commit_id":"d18213d0b5f761d3763c3cc73b0f038d2d4ae443"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c1ca3c9cd30f136205c5d63f8ad34f5d9bd50567","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds ability to configure Fluentd per-host custom config."},{"line_number":5,"context_line":"    It some scenarios it may be useful to apply custom config per host."},{"line_number":6,"context_line":"    Configuration of custom fluentd config is possible by placing"},{"line_number":7,"context_line":"    configuration files in"},{"line_number":8,"context_line":"    ``/etc/kolla/config/fluentd/\u003chost\u003e/{input,filter,format,output}/*.conf``"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f7d104bd_7ce41f44","line":5,"updated":"2024-07-19 06:29:26.000000000","message":"In","commit_id":"140710290ffd7729927af72dff20676297b758ed"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"fff55426d95ab7dfb1121b6016be1af934f30471","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds ability to configure Fluentd per-host custom config."},{"line_number":5,"context_line":"    It some scenarios it may be useful to apply custom config per host."},{"line_number":6,"context_line":"    Configuration of custom fluentd config is possible by placing"},{"line_number":7,"context_line":"    configuration files in"},{"line_number":8,"context_line":"    ``/etc/kolla/config/fluentd/\u003chost\u003e/{input,filter,format,output}/*.conf``"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"75021e3f_563c6bd5","line":5,"in_reply_to":"f7d104bd_7ce41f44","updated":"2024-11-01 08:58:57.000000000","message":"Done","commit_id":"140710290ffd7729927af72dff20676297b758ed"}]}