)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4eb97aa691fd1ff7df0fc8097d352759a2b412af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e161035a_dff595f6","updated":"2024-08-05 15:15:45.000000000","message":"LGTM :)\nas this can be viewed as a bugfix, I voted +1 for backport candidate.","commit_id":"ae86e3a0dbef06841de9ed74cd6ef38ca75448b4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f3f2758414debd23a25e7754515bb8cea9ec6de7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9749c141_21c3bb91","updated":"2024-08-20 12:03:13.000000000","message":"Thank you folks :)","commit_id":"ae86e3a0dbef06841de9ed74cd6ef38ca75448b4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"db81c06c0885d20532420866bb079cc7205b767e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5805cbf3_4db65018","updated":"2024-08-08 13:57:01.000000000","message":"ping","commit_id":"ae86e3a0dbef06841de9ed74cd6ef38ca75448b4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c1b1d6e1ed38ee143a4c8fea331c4472abb38939","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5a8a8fc5_f6502c7e","updated":"2024-08-20 10:26:56.000000000","message":"pong","commit_id":"ae86e3a0dbef06841de9ed74cd6ef38ca75448b4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8c02cb7e5babeae527bbf098b96f6370e3461479","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eee4fe7c_48c5155b","updated":"2024-07-31 07:44:04.000000000","message":"the below comment would apply to the complete change I guess. I would find it nice if we can have some visual distinction between prefix and image name, what do you think?","commit_id":"ae86e3a0dbef06841de9ed74cd6ef38ca75448b4"}],"ansible/roles/aodh/defaults/main.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8c02cb7e5babeae527bbf098b96f6370e3461479","unresolved":true,"context_lines":[{"line_number":98,"context_line":"####################"},{"line_number":99,"context_line":"aodh_tag: \"{{ openstack_tag }}\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"aodh_api_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ docker_image_name_prefix }}aodh-api\""},{"line_number":102,"context_line":"aodh_api_tag: \"{{ aodh_tag }}\""},{"line_number":103,"context_line":"aodh_api_image_full: \"{{ aodh_api_image }}:{{ aodh_api_tag }}\""},{"line_number":104,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"53bd0863_4cd63bf0","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":2},"updated":"2024-07-31 07:44:04.000000000","message":"shouldn\u0027t we separate the prefix visually somehow, e.g. by a dash?\n\n```suggestion\naodh_api_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ docker_image_name_prefix }}-aodh-api\"\n```\n\nI\u0027m not sure we have any assumptions built into kolla how the syntax for a prefix must look like though.","commit_id":"ae86e3a0dbef06841de9ed74cd6ef38ca75448b4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"aedcaed818d612ddf303a52e32106eae62fd544a","unresolved":true,"context_lines":[{"line_number":98,"context_line":"####################"},{"line_number":99,"context_line":"aodh_tag: \"{{ openstack_tag }}\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"aodh_api_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ docker_image_name_prefix }}aodh-api\""},{"line_number":102,"context_line":"aodh_api_tag: \"{{ aodh_tag }}\""},{"line_number":103,"context_line":"aodh_api_image_full: \"{{ aodh_api_image }}:{{ aodh_api_tag }}\""},{"line_number":104,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff130856_d8da45b6","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":2},"in_reply_to":"53bd0863_4cd63bf0","updated":"2024-08-05 10:03:26.000000000","message":"No, we shouldn\u0027t ...this is how it works in kolla project to build images... Same approach.","commit_id":"ae86e3a0dbef06841de9ed74cd6ef38ca75448b4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"03a304d13a7aa2e7bf1b5d549bbe3c2d1aba2989","unresolved":false,"context_lines":[{"line_number":98,"context_line":"####################"},{"line_number":99,"context_line":"aodh_tag: \"{{ openstack_tag }}\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"aodh_api_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ docker_image_name_prefix }}aodh-api\""},{"line_number":102,"context_line":"aodh_api_tag: \"{{ aodh_tag }}\""},{"line_number":103,"context_line":"aodh_api_image_full: \"{{ aodh_api_image }}:{{ aodh_api_tag }}\""},{"line_number":104,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a1ba868c_c0e64a50","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":2},"in_reply_to":"ff130856_d8da45b6","updated":"2024-08-05 14:12:23.000000000","message":"Acknowledged","commit_id":"ae86e3a0dbef06841de9ed74cd6ef38ca75448b4"}]}