)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c8b5cf410ed4cf0acf1d78d500e69d389e65764b","unresolved":true,"context_lines":[{"line_number":12,"context_line":"in kolla."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It also removes the nova_libvirt_secret docker volume because"},{"line_number":15,"context_line":"it is a complete antipattern, and during testing, I found that"},{"line_number":16,"context_line":"it causes problems. When it was necessary to copy libvirt secrets"},{"line_number":17,"context_line":"from /etc/kolla/nova-libvirt/secrets, the docker logs reported that"},{"line_number":18,"context_line":"the resource is busy - precisely because it was a mounted docker"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"643accfe_a0b3fcb4","line":15,"updated":"2024-07-24 06:34:28.000000000","message":"In my world it is an antipattern to copy files into a container, IMO a container should be immutable. I know kolla doesn\u0027t follow this strategy consistenty, but for me this patch is a move into the wrong direction.","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"eafa62e658ee85563653228000115ec1fc838a21","unresolved":true,"context_lines":[{"line_number":12,"context_line":"in kolla."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It also removes the nova_libvirt_secret docker volume because"},{"line_number":15,"context_line":"it is a complete antipattern, and during testing, I found that"},{"line_number":16,"context_line":"it causes problems. When it was necessary to copy libvirt secrets"},{"line_number":17,"context_line":"from /etc/kolla/nova-libvirt/secrets, the docker logs reported that"},{"line_number":18,"context_line":"the resource is busy - precisely because it was a mounted docker"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"84f66dd5_220ee107","line":15,"in_reply_to":"643accfe_a0b3fcb4","updated":"2024-07-24 11:03:44.000000000","message":"Container is immutable, this is configuration.. \nBut do you agree that this is definitely bug if volume is bind into container and on the other place internal kolla\u0027s script is trying to override this ?","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"43cdc6660f8979a800831c13ca760e3ba5e5a6b6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"in kolla."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It also removes the nova_libvirt_secret docker volume because"},{"line_number":15,"context_line":"it is a complete antipattern, and during testing, I found that"},{"line_number":16,"context_line":"it causes problems. When it was necessary to copy libvirt secrets"},{"line_number":17,"context_line":"from /etc/kolla/nova-libvirt/secrets, the docker logs reported that"},{"line_number":18,"context_line":"the resource is busy - precisely because it was a mounted docker"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"c4f23c5b_dbc90f53","line":15,"in_reply_to":"84f66dd5_220ee107","updated":"2024-08-07 14:23:02.000000000","message":"Done","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c8b5cf410ed4cf0acf1d78d500e69d389e65764b","unresolved":true,"context_lines":[{"line_number":17,"context_line":"from /etc/kolla/nova-libvirt/secrets, the docker logs reported that"},{"line_number":18,"context_line":"the resource is busy - precisely because it was a mounted docker"},{"line_number":19,"context_line":"volume. This, of course, is unnecessary because the secrets are copied"},{"line_number":20,"context_line":"to the kolla host in /etc/kolla/nova-libvirt/secrets."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"I deliberately did not use the render for ceph users nova or cinder,"},{"line_number":23,"context_line":"because they can be identical - in that case, it would create only one"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"af5effaf_882bfc50","line":20,"updated":"2024-07-24 06:34:28.000000000","message":"I also admit that I don\u0027t understand yet how exactly this error is happening, let\u0027s discuss this on the bug report first.","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"43cdc6660f8979a800831c13ca760e3ba5e5a6b6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from /etc/kolla/nova-libvirt/secrets, the docker logs reported that"},{"line_number":18,"context_line":"the resource is busy - precisely because it was a mounted docker"},{"line_number":19,"context_line":"volume. This, of course, is unnecessary because the secrets are copied"},{"line_number":20,"context_line":"to the kolla host in /etc/kolla/nova-libvirt/secrets."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"I deliberately did not use the render for ceph users nova or cinder,"},{"line_number":23,"context_line":"because they can be identical - in that case, it would create only one"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"493e6a3d_5f4160db","line":20,"in_reply_to":"7f3b02a3_81f19dde","updated":"2024-08-07 14:23:02.000000000","message":"Done","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"386b0299186dafe53842d9c49aeacbc65d09a4d9","unresolved":true,"context_lines":[{"line_number":17,"context_line":"from /etc/kolla/nova-libvirt/secrets, the docker logs reported that"},{"line_number":18,"context_line":"the resource is busy - precisely because it was a mounted docker"},{"line_number":19,"context_line":"volume. This, of course, is unnecessary because the secrets are copied"},{"line_number":20,"context_line":"to the kolla host in /etc/kolla/nova-libvirt/secrets."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"I deliberately did not use the render for ceph users nova or cinder,"},{"line_number":23,"context_line":"because they can be identical - in that case, it would create only one"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f3b02a3_81f19dde","line":20,"in_reply_to":"af5effaf_882bfc50","updated":"2024-07-24 11:51:27.000000000","message":"No problem, check the bugreport, there you can find very self-descriptive log which i am going to paste right now.","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0e81588bbe96ec751d7cf82d3af23fd8c8d6992c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"17dfaedb_38cf71e6","updated":"2024-07-21 20:25:59.000000000","message":"Needs a task to remove the unnecessary volume","commit_id":"adaf9b1794e32c9b5f19dee3164497116990febd"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"18727e7d702da558b1db01e5085c476ff0c7d4c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5fea42a0_ec9b7d09","updated":"2024-07-21 11:17:12.000000000","message":"recheck rocky","commit_id":"adaf9b1794e32c9b5f19dee3164497116990febd"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"951fe9a27b4abe981bb0606a3ed714316b04ab19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"500eff2e_330308af","in_reply_to":"17dfaedb_38cf71e6","updated":"2024-07-21 21:08:34.000000000","message":"okay, but weird is that rocky upgrade is failing .. :/","commit_id":"adaf9b1794e32c9b5f19dee3164497116990febd"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"319120fb03e1708ca3a843b5c54d857eb8bcde5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6b2d3dc2_1190e496","updated":"2024-08-07 15:06:15.000000000","message":"afaik this also needs to handle the line with nova_libvirt_secrets in https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/nova-cell/tasks/libvirt-cleanup.yml#L54","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d9ba89a6c64887b7fe44135c37e463ee6a1e0555","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e505c694_701f9c2b","updated":"2024-07-22 17:08:30.000000000","message":"recheck cephadm","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7ef16af524b325c75c4ffcfffec14e125783312f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"83c8e697_5616721d","updated":"2024-08-06 09:13:04.000000000","message":"sorry, I don\u0027t have time to look into this with the needed level of detail currently, but if others are fine to approve it, I don\u0027t want to block it","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ca70a823b9266db3fcd60b8f33dcf82005e85497","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"28883389_7999c473","updated":"2024-07-23 20:20:28.000000000","message":"thanks, frickler ?","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5e1bdb8641982fa31b35b2dd815ec9917cfb7499","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3ce266eb_9018cc30","updated":"2024-08-05 10:06:06.000000000","message":"what about this patch ? can we merge finally ?","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"15a060009fa4784fe43236387c4566bfa6ebb7a7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dbef3019_af6eb200","in_reply_to":"04f3c52a_d3245d99","updated":"2024-08-07 15:21:44.000000000","message":"Simply said, this can be removed in E cycle ... but why now ? \n\nWhen user will have a new code of kolla-ansible code BUT he will not reconfigure or deploy ... post-config.yml mentioned above will not be triggered.\n\nSo, imagine user has a new code and want to cleanup libvirt right ? \n\nSo he will run \n\nkolla-ansible nova-libvirt-cleanup\n\nIf you remove that volume from the task in nova-libvirt-cleanup.yml ...volume will simply not be removed.\n\nIf you leave it as it is ... in all cases task will be green and OK ...if there will be volume or not ... So i don\u0027t see any problem ... \n\nMaybe a comment that this should be removed in E cycle ...but not now.","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7b266d88b63d642c7d9814e01e5b144042d362fc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f05d342a_45b5ddc0","in_reply_to":"04f3c52a_d3245d99","updated":"2024-08-07 15:20:27.000000000","message":"ok, I will explain as I understand it, maybe I have an error in my thinking.\n\nthis code:\n\nhttps://github.com/openstack/kolla-ansible/blob/master/ansible/roles/nova-cell/tasks/libvirt-cleanup.yml#L54\n\nwill loop - in the future, when your patch is merged - over volumes, including `nova_libvirt_secrets` and try to remove it, but this volume doesn\u0027t exist after your patch and thus the task will fail.\n\nimho we need to thus remove this volume from the linked `libvirt-cleanup.yml`, no?","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"43392e3f51c7448a4c01c6e045d6f80a4acb2d83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"931bf06d_629079ea","in_reply_to":"44c79f0e_7208fe15","updated":"2024-08-07 15:50:44.000000000","message":"Acknowledged","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f0a60a762f2834d407562646562b0b1a7103da21","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"79fedb8e_bc0ae0af","in_reply_to":"6b2d3dc2_1190e496","updated":"2024-08-07 15:06:33.000000000","message":"unresolved","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"27ea4a68e58fa2ad6c03cfe79461cd64c7d4580d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"44c79f0e_7208fe15","in_reply_to":"6d3cb014_e296a345","updated":"2024-08-07 15:42:07.000000000","message":"Sorry but you are testing something  really different ...you are trying to PRINT undefined variable with debug module ...\n\nTest should be changed to something as \n\nfile:\n  path: /tmp/non_existant_file\n  state: absent\n\nIn both cases it will not fail ...\n\nChechk my real test on real code on real servers above ...","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a63b9f81a17686f2bd4dd876a02687f2b46b57ff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"04f3c52a_d3245d99","in_reply_to":"79fedb8e_bc0ae0af","updated":"2024-08-07 15:12:42.000000000","message":"I really don\u0027t know what do you mean ... I am deleting volume with libvirt secret as below \u003e\u003e\u003e\u003e\n\nline 39 in ansible/roles/nova-cell/tasks/deploy.yml - \n\n- import_tasks: post-config.yml\n\npost-config.yml:\n\n---\n TODO(kevko) Remove in E cycle\n- name: Remove old nova_libvirt_secrets docker volume\n  become: true\n  kolla_container:\n    container_engine: \"{{ kolla_container_engine }}\"\n    action: \"remove_volume\"\n    name: nova_libvirt_secrets\n\n\nYou mentioned task where the volume is actually removed when called cleanup of libvirt... So where do you have  a problem ?","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"48752c67a386283bc14e323b16c9d12f24d2a7d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a9d8026d_8cacee6e","in_reply_to":"83c8e697_5616721d","updated":"2024-08-06 09:14:50.000000000","message":"I really tested it and it is passing everything.","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ed37cdfe023d568a2e8e4b338a0e5dd610fcd5be","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6d3cb014_e296a345","in_reply_to":"88a7eb03_60c9bcf1","updated":"2024-08-07 15:39:01.000000000","message":"Yeah,","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6437506b0f55f6e900edfdfa0442f2316cff7501","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5472506d_01c356f3","in_reply_to":"a9d8026d_8cacee6e","updated":"2024-08-06 09:15:18.000000000","message":"Also, detailed description is in bugfix.","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a97e545fc10fc803ff03cfb160d046228d578151","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b0138297_4e834d74","in_reply_to":"bd6cfef1_d269150b","updated":"2024-08-07 15:30:04.000000000","message":"It will not fail --- tested, I\u0027ve added non_existant_volume volume to that task and commented all tasks before and after ... as i don\u0027t want to break my test deployment right ? :)  \u003e\u003e\u003e\n\nSet nova_libvirt_cleanup_remove_volumes to yes  \u003e\u003e \n\n\n(kolla-ansible)[root]# cat /etc/kolla/globals.yml  | grep remove\nnova_libvirt_cleanup_remove_volumes: \"yes\"\n\n(kolla-ansible)[root]# cat  ansible/roles/nova-cell/tasks/libvirt-cleanup.yml  | grep -v \u0027\\#\u0027\n\n---\n\n- name: Remove nova_libvirt Docker volumes\n  become: true\n  kolla_container:\n    common_options: \"{{ docker_common_options }}\"\n    action: \"remove_volume\"\n    name: \"{{ item }}\"\n  loop:\n    - non_existant_volume\n  when: nova_libvirt_cleanup_remove_volumes | bool\n\n(kolla-ansible)[root]# kolla-ansible -i /etc/kolla/inventory nova-libvirt-cleanup --limit compute0\nCleanup disabled nova_libvirt containers : ansible-playbook -e @/etc/kolla/globals.yml  -e @/etc/kolla/globals.d/designate.yml -e @/etc/kolla/globals.d/neutron.yml -e @/etc/kolla/globals.d/endpoint.yml -e @/etc/kolla/passwords.yml -e CONFIG_DIR\u003d/etc/kolla  --limit compute0 /opt/kolla-ansible/ansible/nova-libvirt-cleanup.yml  --inventory /etc/kolla/inventory\n[WARNING]: Invalid characters were found in group names but not replaced, use -vvvv to see details\n\nPLAY [Gather facts for all hosts] *********************************************************************************************************************************************************************************\n\nTASK [Gather facts] ***********************************************************************************************************************************************************************************************\nskipping: [compute0]\n\nTASK [Gather package facts] ***************************************************************************************************************************************************************************************\nskipping: [compute0]\n\nTASK [Group hosts to determine when using --limit] ****************************************************************************************************************************************************************\nok: [compute0]\n\nPLAY [Gather facts for all hosts (if using --limit)] **************************************************************************************************************************************************************\n\nTASK [Gather facts] ***********************************************************************************************************************************************************************************************\nskipping: [compute0] \u003d\u003e (item\u003dcompute0) \nskipping: [compute0] \u003d\u003e (item\u003dcontroller0) \nskipping: [compute0] \u003d\u003e (item\u003dcontroller1) \nskipping: [compute0] \u003d\u003e (item\u003dcontroller2) \nskipping: [compute0] \u003d\u003e (item\u003dcompute1) \nskipping: [compute0] \u003d\u003e (item\u003dcompute2) \nskipping: [compute0] \u003d\u003e (item\u003dceph0) \nskipping: [compute0] \u003d\u003e (item\u003dceph1) \nskipping: [compute0] \u003d\u003e (item\u003dceph2) \nskipping: [compute0] \u003d\u003e (item\u003dlocalhost) \nskipping: [compute0]\n\nTASK [Gather package facts] ***************************************************************************************************************************************************************************************\nskipping: [compute0] \u003d\u003e (item\u003dcompute0) \nskipping: [compute0] \u003d\u003e (item\u003dcontroller0) \nskipping: [compute0] \u003d\u003e (item\u003dcontroller1) \nskipping: [compute0] \u003d\u003e (item\u003dcontroller2) \nskipping: [compute0] \u003d\u003e (item\u003dcompute1) \nskipping: [compute0] \u003d\u003e (item\u003dcompute2) \nskipping: [compute0] \u003d\u003e (item\u003dceph0) \nskipping: [compute0] \u003d\u003e (item\u003dceph1) \nskipping: [compute0] \u003d\u003e (item\u003dceph2) \nskipping: [compute0] \u003d\u003e (item\u003dlocalhost) \nskipping: [compute0]\n\nPLAY [Remove nova_libvirt container] ******************************************************************************************************************************************************************************\n\nTASK [nova-cell : Remove nova_libvirt Docker volumes] *************************************************************************************************************************************************************\nok: [compute0] \u003d\u003e (item\u003dnon_existant_volume)\n\nPLAY RECAP ********************************************************************************************************************************************************************************************************\ncompute0                   : ok\u003d2    changed\u003d0    unreachable\u003d0    failed\u003d0    skipped\u003d4    rescued\u003d0    ignored\u003d0  \n\n\n\nVualaa, what else ?","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1e94c66c72d24088c2505ba5b913bd075799fa33","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bd6cfef1_d269150b","in_reply_to":"dbef3019_af6eb200","updated":"2024-08-07 15:24:15.000000000","message":"I don\u0027t think it will fail...","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f5624d97deea1b2748f7bb2c2d39d24389f5f8c7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"88a7eb03_60c9bcf1","in_reply_to":"dbef3019_af6eb200","updated":"2024-08-07 15:35:14.000000000","message":"sorry, I don\u0027t quite understand this part:\n\n\u003e So, imagine user has a new code and want to cleanup libvirt right ?\n\nok \n\n\n\u003e So he will run\n\u003e kolla-ansible nova-libvirt-cleanup\n\nok\n\n\u003e If you remove that volume from the task in nova-libvirt-cleanup.yml ...volume will simply not be removed.\n\nsorry, no? with new code, volume `nova_libvirt_secrets` does not exist, because you removed that mountpoint. a loop in ansible executes the task each time with the supplied items, in this case an undefined variable. thus the task will fail.\n\nI have compiled a small test playbook to illustrate this:\n\n```\n---\n- name: Demonstrate loop failure due to undefined variable\n  hosts: localhost\n  gather_facts: false\n  vars:\n    defined_variable_1: \"Defined variable 1\"\n    defined_variable_2: \"Defined variable 2\"\n  tasks:\n    - name: Print item in loop\n      debug:\n        msg: \"Item: {{ item }}\"\n      loop:\n        - \"defined_variable_1\"\n        - \"defined_variable_2\"\n        - \"{{ undefined_variable }}\"\n\n```\n\nresult:\n\n```\nansible-playbook test-loop-undefined-vars.yml\n[...]\nTASK [Print item in loop] ***********************************************************************************************************\nfatal: [localhost]: FAILED! \u003d\u003e \n  msg: \u0027\u0027\u0027undefined_variable\u0027\u0027 is undefined. \u0027\u0027undefined_variable\u0027\u0027 is undefined\u0027\n```","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9103be275929172c64d4ca09fc9c7f5f63166856","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1d01e97b_9c313c15","updated":"2024-08-08 13:57:47.000000000","message":"ping","commit_id":"bc5ba167083e6cfcf408bef9e719da6783835292"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"38104ccc00ec6339798210db6beedbccf2a4b76b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3133bed2_ecb47d4a","updated":"2024-08-07 19:52:07.000000000","message":"recheck Debian upgrade failed","commit_id":"bc5ba167083e6cfcf408bef9e719da6783835292"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"31a4d8423c82b9ae8614fbd0925507dbf78605b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"032841d8_a31127c5","updated":"2024-08-09 15:02:42.000000000","message":"okay, but name of secret is just not important ..there is no need to care of the name.","commit_id":"4126016d6d9480b8da02ea22fdbe1f5039737b30"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"20bf82ed03949e96e179752a8b223efa8fc790c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ba50f1a4_712f3abf","updated":"2024-08-08 18:39:41.000000000","message":"recheck upgrade","commit_id":"4126016d6d9480b8da02ea22fdbe1f5039737b30"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c84a059b61a0c97d98d06324842bbd6db9706dbf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f16d0401_23c154fb","in_reply_to":"032841d8_a31127c5","updated":"2024-08-09 16:04:37.000000000","message":"So why do you need to change the name and description?\nAs long as we can strip down that change to be backported to bug relevant changes - and if you wish you can raise a separate one just for the name change and description (that won\u0027t be back ported) - I\u0027ll be happier.","commit_id":"4126016d6d9480b8da02ea22fdbe1f5039737b30"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a7b0447250fe3c13ffd75c6cd8d4a2ae97eb91b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d6693b0b_8aec555d","in_reply_to":"1d2321df_6967e83f","updated":"2024-08-15 14:59:10.000000000","message":"Done","commit_id":"4126016d6d9480b8da02ea22fdbe1f5039737b30"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b8f07dd7d8a00c6d1c9fec2ba91ff8d4b2fc315c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1d2321df_6967e83f","in_reply_to":"264e23f2_55f776dc","updated":"2024-08-15 12:03:54.000000000","message":"But even if I preserve the name and remove description in secrets the nova-libvirt will be restarted, because there is volume in libvirt removed - so container definition will be changed - so it will be restarted. If I split it, it will be restarted twice... but as you wish.","commit_id":"4126016d6d9480b8da02ea22fdbe1f5039737b30"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d04dd4a2a279d6d5d69d1bff66128e94a385ae5a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"264e23f2_55f776dc","in_reply_to":"9fd48b5c_4e7ad7d1","updated":"2024-08-13 05:42:21.000000000","message":"So, first of all - in my mind fully back portable \u003d\u003d no impact (and there\u0027s no patch that has no impact, well maybe CI-only patch), and this change has impact - at least to restart nova-libvirt and reconfigure libvirt secrets.\nAs written earlier - let\u0027s do absolutely what is required to fix the bug, but the name changes and added description is not bug-related - so please split that.","commit_id":"4126016d6d9480b8da02ea22fdbe1f5039737b30"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"14e2e686f17d24d196e4858c6927e507c620e496","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9fd48b5c_4e7ad7d1","in_reply_to":"f16d0401_23c154fb","updated":"2024-08-12 15:53:45.000000000","message":"Because client.nova might give an advanced user the impression that it is templatable (since it closely resembles the format of a Ceph keyring, like ceph.client.nova...), but it is not, and it is something entirely different. However, the user will only understand this once they study in detail how it works.\n\nTherefore, I changed the name of this secret to make it semantically distinct and clear at first glance. This change is also fully backportable since changing the name has no effect, as I have emphasized several times.\n\nSo, should I split this patch to two separate patches or can we just go with this ?","commit_id":"4126016d6d9480b8da02ea22fdbe1f5039737b30"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"50330b0780d787226410bdcb9fc465a7e4de46c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a0fdbc36_6e82078b","updated":"2024-08-16 10:15:51.000000000","message":"Ping","commit_id":"7657aac82cc4b49c8670d27b86b760fa8c497f01"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"57ce1e9a175f94073b9cb009303b7a623bd157b3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"901d5506_bb55b291","updated":"2024-08-19 12:26:32.000000000","message":"@michal.arbet@ultimum.io should that be back ported? if yes - to which releases?","commit_id":"82a642ed8b55da4e2e3478790fb3d6d2ff432630"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"95afeeada626c73aac9fdcad66620f47478fc977","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fe62fa5f_a8172811","updated":"2024-08-16 13:27:41.000000000","message":"@mnasiadka@gmail.com Satisfied now ?","commit_id":"82a642ed8b55da4e2e3478790fb3d6d2ff432630"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"02172592021a8484e8936e31f7ce9c74a8ae3795","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"80182ba2_7c79e37b","updated":"2024-08-19 09:13:08.000000000","message":"recheck - ubuntu ceph upgrade volume stuck in creating","commit_id":"82a642ed8b55da4e2e3478790fb3d6d2ff432630"}],"ansible/roles/nova-cell/tasks/external_ceph.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0df7c2375a71595b4339a25ed9422d2aa6cbc66c","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a242f68d_4965f2c4","line":167,"updated":"2024-07-22 10:49:57.000000000","message":"Although I\u0027m happy with adding description as it should not break anything... but changing names might give some headaches? Is it stored anywhere in libvirt? like in instances xml definitions?","commit_id":"bdc45a237c5f3f1b5a3fe54581888d2bd5a6a09e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ab1d9d2d4877e99b3fff1ad67fb3c5772fb96c7b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d073bbc1_911351df","line":167,"in_reply_to":"a242f68d_4965f2c4","updated":"2024-07-22 12:37:57.000000000","message":"It\u0027s totally fine, it\u0027s referenced by UUID which is not changed. Also, it\u0027s only on disk in /etc/libvirt/secrets","commit_id":"bdc45a237c5f3f1b5a3fe54581888d2bd5a6a09e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d2b00072b38fe3e2dee792575574eec4e18be94a","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"378f293f_10c81f4a","line":167,"updated":"2024-08-07 15:35:32.000000000","message":"nit: do we really need to use ephemeral-nova? ceph-nova is not enough?","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"80ab2721516ef2da01d6e65a31e4ee123d43f202","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"45938b04_ac08d197","line":167,"in_reply_to":"0e94c174_01931acd","updated":"2024-08-08 07:40:52.000000000","message":"ftr I agree with kevko here, new users tend to be surprised \"Nova storage\" means ephemeral. They tend to think \"storage\u003dlong term persistent storage\" coming from stuff like vmware and their local disk setups (libvirt/kvm).","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"89ab54babbc969ff86666e782441f79325ef81bf","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0e94c174_01931acd","line":167,"in_reply_to":"1e744a53_1d0214a1","updated":"2024-08-07 16:44:17.000000000","message":"Done","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fabc6b64594e09ed64a5939d6844569f0a8687b1","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7524bb33_40201be3","line":167,"in_reply_to":"352dadc0_0128d510","updated":"2024-08-09 13:18:19.000000000","message":"There\u0027s a polish saying that only cow does not change it\u0027s mind.","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"245c8f70c3de5da958e495e6e84705eae52132d4","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1e744a53_1d0214a1","line":167,"in_reply_to":"378f293f_10c81f4a","updated":"2024-08-07 16:34:45.000000000","message":"No it\u0027s not enough. As per openstack documentation they are saying https://docs.openstack.org/arch-design/design-storage/design-storage-concepts.html\n\nEphemeral - nova \nPersistent - cinder \n\nEspecially for new OpenStack users, it is very important to realize this. Why ask this question in the first place? Do you want to save a few pixels on the screen? Or a few bits on the disk?","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"14e2e686f17d24d196e4858c6927e507c620e496","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"943641a4_f58020b5","line":167,"in_reply_to":"3ecd9e5c_b1796f94","updated":"2024-08-12 15:53:45.000000000","message":"yeah, that\u0027s also in Slovak 🤣","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8e4453d89334fbafdccdb6986f0ae0b28bcdae41","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"352dadc0_0128d510","line":167,"in_reply_to":"41b65758_6fc9656a","updated":"2024-08-09 13:10:46.000000000","message":"So what ? Sven agree with me (thanks) and moreover you already gave +2 for this patch before... And after I changed words - docker -\u003e container, and while -\u003e when in release note ...it is -1 ? Thanks","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"25b40a33be2cbb18b6316dbb4dc511cd3e5a9f97","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6e6a69f9_70608205","line":167,"in_reply_to":"45938b04_ac08d197","updated":"2024-08-08 15:43:43.000000000","message":"And I still disagree, this is not user visible, we don\u0027t need that level of detail and we never needed it in the past.","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e5747fcf5bfc9e8e98980613bcdd0212d286c9fb","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"41b65758_6fc9656a","line":167,"in_reply_to":"4d5ebd6f_1ba5151d","updated":"2024-08-08 18:38:57.000000000","message":"I like the","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f46e29ad6efd391bd4d3a4c46d2162833f2bc223","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4d5ebd6f_1ba5151d","line":167,"in_reply_to":"6e6a69f9_70608205","updated":"2024-08-08 15:48:16.000000000","message":"Actually, Kolla user is admin who maintain the openstack cloud - so it is visible for the user. What about to remove also \"ceph\" keyword as we don\u0027t need that level of detail ...what do you think ? Just simple nova, cinder ...","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d05ceaa6f968db0397df0f8dfc03e49cf728a50b","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ecd9e5c_b1796f94","line":167,"in_reply_to":"7524bb33_40201be3","updated":"2024-08-09 13:22:48.000000000","message":"I\u0027m fine with other cores merging this change, but we have \"client.nova secret\" and \"client.cinder secret\" for a long time, so IMO we would be best with either leaving that as is or something similar to that. Especially that it\u0027s a bug and you want to get that backported for sure.","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a7b0447250fe3c13ffd75c6cd8d4a2ae97eb91b8","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a4427614_097e01e4","line":167,"in_reply_to":"943641a4_f58020b5","updated":"2024-08-15 14:59:10.000000000","message":"Done","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d2b00072b38fe3e2dee792575574eec4e18be94a","unresolved":true,"context_lines":[{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""},{"line_number":171,"context_line":"          name: \"ceph-persistent-cinder\""},{"line_number":172,"context_line":"          desc: \"Ceph Client Secret for Persistent Storage (Cinder)\""},{"line_number":173,"context_line":"          enabled: \"{{ cinder_backend_ceph }}\""},{"line_number":174,"context_line":"      notify: \"{{ libvirt_restart_handlers }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f1ceaf96_3dfe52b3","line":171,"updated":"2024-08-07 15:35:32.000000000","message":"ditto","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"89ab54babbc969ff86666e782441f79325ef81bf","unresolved":false,"context_lines":[{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""},{"line_number":171,"context_line":"          name: \"ceph-persistent-cinder\""},{"line_number":172,"context_line":"          desc: \"Ceph Client Secret for Persistent Storage (Cinder)\""},{"line_number":173,"context_line":"          enabled: \"{{ cinder_backend_ceph }}\""},{"line_number":174,"context_line":"      notify: \"{{ libvirt_restart_handlers }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"73124f5f_8393660b","line":171,"in_reply_to":"48bfc902_0d313d91","updated":"2024-08-07 16:44:17.000000000","message":"Done","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4d3d273884e18db30d766b26694e2bc563604e6e","unresolved":true,"context_lines":[{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""},{"line_number":171,"context_line":"          name: \"ceph-persistent-cinder\""},{"line_number":172,"context_line":"          desc: \"Ceph Client Secret for Persistent Storage (Cinder)\""},{"line_number":173,"context_line":"          enabled: \"{{ cinder_backend_ceph }}\""},{"line_number":174,"context_line":"      notify: \"{{ libvirt_restart_handlers }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"48bfc902_0d313d91","line":171,"in_reply_to":"f1ceaf96_3dfe52b3","updated":"2024-08-07 16:36:23.000000000","message":"Ditto","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cec02059d4051d1ac86f444fe40d34fbf8f0684d","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""},{"line_number":171,"context_line":"          name: \"ceph-persistent-cinder\""},{"line_number":172,"context_line":"          desc: \"Ceph Client Secret for Persistent Storage (Cinder)\""},{"line_number":173,"context_line":"          enabled: \"{{ cinder_backend_ceph }}\""},{"line_number":174,"context_line":"      notify: \"{{ libvirt_restart_handlers }}\""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d6f46180_52c9d13d","line":172,"range":{"start_line":167,"start_character":8,"end_line":172,"end_character":68},"updated":"2024-08-06 09:54:01.000000000","message":"I\u0027m fairly certain we need to note the changed names in the upgrades section of the reno, don\u0027t you think?","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7f5f36a82b84326f389cb3012b0efa12f837e811","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""},{"line_number":171,"context_line":"          name: \"ceph-persistent-cinder\""},{"line_number":172,"context_line":"          desc: \"Ceph Client Secret for Persistent Storage (Cinder)\""},{"line_number":173,"context_line":"          enabled: \"{{ cinder_backend_ceph }}\""},{"line_number":174,"context_line":"      notify: \"{{ libvirt_restart_handlers }}\""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5572bcb9_5901d245","line":172,"range":{"start_line":167,"start_character":8,"end_line":172,"end_character":68},"in_reply_to":"19ec4768_76d31291","updated":"2024-08-06 11:54:30.000000000","message":"I was actually not 100% sure, but don\u0027t external ceph users need to adjust their deployment to the new variable names? I rarely use this without wrappers handling all the stuff, so I\u0027m not sure though","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9e17246f34bf342d4e339637e9433d384851408e","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""},{"line_number":171,"context_line":"          name: \"ceph-persistent-cinder\""},{"line_number":172,"context_line":"          desc: \"Ceph Client Secret for Persistent Storage (Cinder)\""},{"line_number":173,"context_line":"          enabled: \"{{ cinder_backend_ceph }}\""},{"line_number":174,"context_line":"      notify: \"{{ libvirt_restart_handlers }}\""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"eca42cd0_af2fa5b9","line":172,"range":{"start_line":167,"start_character":8,"end_line":172,"end_character":68},"in_reply_to":"219903b2_5742faa0","updated":"2024-08-06 12:18:34.000000000","message":"Actually, you can see that everything is passing without any change ... That\u0027s the purpose of CI","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"519746c3c356764e53d34652fabeb317383df383","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""},{"line_number":171,"context_line":"          name: \"ceph-persistent-cinder\""},{"line_number":172,"context_line":"          desc: \"Ceph Client Secret for Persistent Storage (Cinder)\""},{"line_number":173,"context_line":"          enabled: \"{{ cinder_backend_ceph }}\""},{"line_number":174,"context_line":"      notify: \"{{ libvirt_restart_handlers }}\""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"219903b2_5742faa0","line":172,"range":{"start_line":167,"start_character":8,"end_line":172,"end_character":68},"in_reply_to":"4e1bce9f_58cc1029","updated":"2024-08-06 12:03:20.000000000","message":"Acknowledged","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ba94e6e183e0e3872469c2e91844ada079efe719","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""},{"line_number":171,"context_line":"          name: \"ceph-persistent-cinder\""},{"line_number":172,"context_line":"          desc: \"Ceph Client Secret for Persistent Storage (Cinder)\""},{"line_number":173,"context_line":"          enabled: \"{{ cinder_backend_ceph }}\""},{"line_number":174,"context_line":"      notify: \"{{ libvirt_restart_handlers }}\""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4e1bce9f_58cc1029","line":172,"range":{"start_line":167,"start_character":8,"end_line":172,"end_character":68},"in_reply_to":"5572bcb9_5901d245","updated":"2024-08-06 11:56:38.000000000","message":"No, nothing is needed to change from users ...rbd_secret_uuid and cinder_rbd_secret_uuid are same ... Just name changed to be more clear which is which ..and description added.\n\nUser really don\u0027t need to know about anything ... It was also discussed up in comments.","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7a5c8d6fad43f1edb5b61eea9c73c90a329be345","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        - item.enabled | bool"},{"line_number":165,"context_line":"      with_items:"},{"line_number":166,"context_line":"        - uuid: \"{{ rbd_secret_uuid }}\""},{"line_number":167,"context_line":"          name: \"ceph-ephemeral-nova\""},{"line_number":168,"context_line":"          desc: \"Ceph Client Secret for Ephemeral Storage (Nova)\""},{"line_number":169,"context_line":"          enabled: \"{{ nova_backend \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":170,"context_line":"        - uuid: \"{{ cinder_rbd_secret_uuid }}\""},{"line_number":171,"context_line":"          name: \"ceph-persistent-cinder\""},{"line_number":172,"context_line":"          desc: \"Ceph Client Secret for Persistent Storage (Cinder)\""},{"line_number":173,"context_line":"          enabled: \"{{ cinder_backend_ceph }}\""},{"line_number":174,"context_line":"      notify: \"{{ libvirt_restart_handlers }}\""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"19ec4768_76d31291","line":172,"range":{"start_line":167,"start_character":8,"end_line":172,"end_character":68},"in_reply_to":"d6f46180_52c9d13d","updated":"2024-08-06 10:20:53.000000000","message":"I don\u0027t think as it\u0027s not affect users .... To which section you think it should ...","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"}],"ansible/roles/nova-cell/tasks/post-config.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d2b00072b38fe3e2dee792575574eec4e18be94a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# TODO(kevko) Remove in E cycle"},{"line_number":3,"context_line":"- name: Remove old nova_libvirt_secrets docker volume"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  kolla_container:"},{"line_number":6,"context_line":"    container_engine: \"{{ kolla_container_engine }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"87fca3a6_896a8d41","line":3,"updated":"2024-08-07 15:35:32.000000000","message":"container?","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"89ab54babbc969ff86666e782441f79325ef81bf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# TODO(kevko) Remove in E cycle"},{"line_number":3,"context_line":"- name: Remove old nova_libvirt_secrets docker volume"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  kolla_container:"},{"line_number":6,"context_line":"    container_engine: \"{{ kolla_container_engine }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"654c291b_6eb003c7","line":3,"in_reply_to":"195249b3_1feef3a7","updated":"2024-08-07 16:44:17.000000000","message":"Aaaa, ok, got it.","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4d3d273884e18db30d766b26694e2bc563604e6e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# TODO(kevko) Remove in E cycle"},{"line_number":3,"context_line":"- name: Remove old nova_libvirt_secrets docker volume"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  kolla_container:"},{"line_number":6,"context_line":"    container_engine: \"{{ kolla_container_engine }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"195249b3_1feef3a7","line":3,"in_reply_to":"87fca3a6_896a8d41","updated":"2024-08-07 16:36:23.000000000","message":"no, volume","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2a9dece7f9c8daaecfa4673134791082af6e0c36","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# TODO(kevko) Remove in E cycle"},{"line_number":3,"context_line":"- name: Remove old nova_libvirt_secrets docker volume"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  kolla_container:"},{"line_number":6,"context_line":"    container_engine: \"{{ kolla_container_engine }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9b7bf4ce_5bbd0d8f","line":3,"range":{"start_line":3,"start_character":40,"end_line":3,"end_character":46},"updated":"2024-08-16 11:20:07.000000000","message":"container)\nlook at line 5","commit_id":"7657aac82cc4b49c8670d27b86b760fa8c497f01"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"698229250881279bc17d1a636921ffaf667bff60","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# TODO(kevko) Remove in E cycle"},{"line_number":3,"context_line":"- name: Remove old nova_libvirt_secrets docker volume"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  kolla_container:"},{"line_number":6,"context_line":"    container_engine: \"{{ kolla_container_engine }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba49173b_472e86a2","line":3,"range":{"start_line":3,"start_character":40,"end_line":3,"end_character":46},"in_reply_to":"9b7bf4ce_5bbd0d8f","updated":"2024-08-16 12:24:08.000000000","message":"Done","commit_id":"7657aac82cc4b49c8670d27b86b760fa8c497f01"}],"releasenotes/notes/bug-2073678-45f31547395ef3c7.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d2b00072b38fe3e2dee792575574eec4e18be94a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes busy libvirt\u0027s secret volume while secrets are changing."},{"line_number":5,"context_line":"    `LP#2073678 \u003chttps://launchpad.net/bugs/2073678\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"39179550_7deb358e","line":4,"updated":"2024-08-07 15:35:32.000000000","message":"when?","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4d3d273884e18db30d766b26694e2bc563604e6e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes busy libvirt\u0027s secret volume while secrets are changing."},{"line_number":5,"context_line":"    `LP#2073678 \u003chttps://launchpad.net/bugs/2073678\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fed44cfd_e9a74076","line":4,"in_reply_to":"39179550_7deb358e","updated":"2024-08-07 16:36:23.000000000","message":"Yeah, it\u0027s probably more english correct.","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"89ab54babbc969ff86666e782441f79325ef81bf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes busy libvirt\u0027s secret volume while secrets are changing."},{"line_number":5,"context_line":"    `LP#2073678 \u003chttps://launchpad.net/bugs/2073678\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0c1610b1_f4c8abb6","line":4,"in_reply_to":"fed44cfd_e9a74076","updated":"2024-08-07 16:44:17.000000000","message":"Done","commit_id":"2bcbbb760b21feb83db6f282429bd5a9ab45cf56"}]}